Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hpoussin] 29997: Add .ndi extension as it is usually done in network driver .inf files Clean up TCP/IP service installation, by letting setupapi do most of the work
by hpoussin＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: hpoussin Date: Wed Oct 31 11:57:13 2007 New Revision: 29997 URL: http://svn.reactos.org/svn/reactos?rev=29997&view=rev Log: Add .ndi extension as it is usually done in network driver .inf files Clean up TCP/IP service installation, by letting setupapi do most of the work Modified: trunk/reactos/media/inf/netamd.inf trunk/reactos/media/inf/netisa.inf trunk/reactos/media/inf/netrtpnt.inf trunk/reactos/media/inf/nettcpip.inf Modified: trunk/reactos/media/inf/netamd.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/netamd.inf?rev=2… ============================================================================== --- trunk/reactos/media/inf/netamd.inf (original) +++ trunk/reactos/media/inf/netamd.inf Wed Oct 31 11:57:13 2007 @@ -18,11 +18,11 @@ %AMDMfg% = AMDMfg [AMDMfg] -%PCNET.DeviceDesc% = PCNet_Inst,PCI\VEN_1022&DEV_2000 +%PCNET.DeviceDesc% = PCNet_Inst.ndi,PCI\VEN_1022&DEV_2000 ;----------------------------- PCNET DRIVER ----------------------------- -[PCNet_Inst.NT] +[PCNet_Inst.ndi.NT] Characteristics = 0x4 ; NCF_PHYSICAL BusType = 5 ; PCIBus AddReg = PCNet_AddReg.NT @@ -43,7 +43,7 @@ [PCNet_CopyFiles.NT] pcnet.sys -[PCNet_Inst.NT.Services] +[PCNet_Inst.ndi.NT.Services] AddService = PCNet, 0x00000002, PCNet_Service_Inst [PCNet_Service_Inst] Modified: trunk/reactos/media/inf/netisa.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/netisa.inf?rev=2… ============================================================================== --- trunk/reactos/media/inf/netisa.inf (original) +++ trunk/reactos/media/inf/netisa.inf Wed Oct 31 11:57:13 2007 @@ -18,11 +18,11 @@ %GenericMfg% = GenericMfg [GenericMfg] -%*PNP80D6.DeviceDesc% = NE2000_Inst,*PNP80D6 +%*PNP80D6.DeviceDesc% = NE2000_Inst.ndi,*PNP80D6 ;---------------------------- NE2000 DRIVER ----------------------------- -[NE2000_Inst.NT] +[NE2000_Inst.ndi.NT] Characteristics = 0x4 ; NCF_PHYSICAL BusType = 14 ; PNPIsaBus AddReg = NE2000_AddReg.NT @@ -36,7 +36,7 @@ [NE2000_CopyFiles.NT] ne2000.sys -[NE2000_Inst.NT.Services] +[NE2000_Inst.ndi.NT.Services] AddService = ne2000, 0x00000002, ne2000_Service_Inst [ne2000_Service_Inst] Modified: trunk/reactos/media/inf/netrtpnt.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/netrtpnt.inf?rev… ============================================================================== --- trunk/reactos/media/inf/netrtpnt.inf (original) +++ trunk/reactos/media/inf/netrtpnt.inf Wed Oct 31 11:57:13 2007 @@ -18,11 +18,11 @@ %RealtekMfg% = RealtekMfg [RealtekMfg] -%PCI\VEN_10EC&DEV_8029.DeviceDesc% = NE2000_Inst,PCI\VEN_10EC&DEV_8029 +%PCI\VEN_10EC&DEV_8029.DeviceDesc% = NE2000_Inst.ndi,PCI\VEN_10EC&DEV_8029 ;---------------------------- NE2000 DRIVER ----------------------------- -[NE2000_Inst.NT] +[NE2000_Inst.ndi.NT] Characteristics = 0x4 ; NCF_PHYSICAL BusType = 5 ; PCIBus AddReg = NE2000_AddReg.NT @@ -36,7 +36,7 @@ [NE2000_CopyFiles.NT] ne2000.sys -[NE2000_Inst.NT.Services] +[NE2000_Inst.ndi.NT.Services] AddService = ne2000, 0x00000002, ne2000_Service_Inst [ne2000_Service_Inst] Modified: trunk/reactos/media/inf/nettcpip.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/nettcpip.inf?rev… ============================================================================== --- trunk/reactos/media/inf/nettcpip.inf (original) +++ trunk/reactos/media/inf/nettcpip.inf Wed Oct 31 11:57:13 2007 @@ -14,9 +14,9 @@ ;----------------------------- TCP/IP DRIVER ---------------------------- [MS_TCPIP.PrimaryInstall] -AddReg = TCPIP_AddReg.NT +AddReg = TCPIP_AddReg_Global.NT -[TCPIP_AddReg.NT] +[TCPIP_AddReg_Global.NT] ; The following entries should be generated from .inf files during installation ; TCPIP Protocol HKLM,"SYSTEM\CurrentControlSet\Control\Network\{4D36E975-E325-11CE-BFC1-08002BE10318}\{RandomProtocolGUID_TCPIP}","Characteristics",0x00010001,0x00000080 @@ -29,24 +29,10 @@ HKLM,"SYSTEM\CurrentControlSet\Control\Network\{4D36E975-E325-11CE-BFC1-08002BE10318}\{RandomProtocolGUID_TCPIP}\Ndi","Service",0x00000000,"Tcpip" ; TCP/IP driver -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip","ErrorControl",0x00010001,0x00000001 -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip","Group",0x00000000,"PNP_TDI" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip","ImagePath",0x00020000,"system32\drivers\tcpip.sys" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip","Start",0x00010001,0x00000001 -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip","Type",0x00010001,0x00000001 ; NOTE: These settings should be added by the network setup ; These bindings are of the windows 2000 type, and will probably need to be ; twiddled to get 3rd-party network-related software to work. ; NT4 puts additional stuff in the Bind, Export, and Route values. -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","DataBasePath",0x00010000,"DataBasePath" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","Domain",0x00010000,"" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","Hostname",0x00010000,"ROSHost" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","NameServer",0x00010000,"0.0.0.0" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","ForwardBroadcasts",0x00010001,0x00000000 -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","IPEnableRouter",0x00010001,0x00000000 -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","SearchList",0x00010000,"" -HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters","EnableSecurityFilters",0x00010001,0x00000000 -;HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\PersistentRoutes",,0x00000010 HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\WinSock","UseDelayedAcceptance",0x00010001,0x00000000 HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\WinSock","MaxSockAddrLength",0x00010001,0x00000010 HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\WinSock","MinSockAddrLength",0x00010001,0x00000010 @@ -54,8 +40,29 @@ HKLM,"SYSTEM\CurrentControlSet\Services\Tcpip\Parameters\WinSock","Mapping",0x00000001,0c,00,00,00,03,00,00,00,02,00,00,00,01,00,00,00,06,00,00,00,02,00,00,00,01,00,00,00,00,00,00,00,02,00,00,00,00,00,00,00,06,00,00,00,00,00,00,00,00,00,00,00,06,00,00,00,00,00,00,00,01,00,00,00,06,00,00,00,02,00,00,00,02,00,00,00,11,00,00,00,02,00,00,00,02,00,00,00,00,00,00,00,02,00,00,00,00,00,00,00,11,00,00,00,00,00,00,00,00,00,00,00,11,00,00,00,00,00,00,00,02,00,00,00,11,00,00,00,02,00,00,00,03,00,00,00,00,00,00,00,02,00,00,00,03,00,00,00,01,00,00,00 HKLM,"SYSTEM\CurrentControlSet\Services\Winsock\Parameters","Transports",0x00010000,"Tcpip" +[MS_TCPIP.PrimaryInstall.Services] +AddService = Tcpip, , tcpip_Service_Inst + +[tcpip_Service_Inst] +ServiceType = 1 +StartType = 1 +ErrorControl = 1 +ServiceBinary = %12%\tcpip.sys +LoadOrderGroup = PNP_TDI +AddReg = tcpip_AddReg + +[tcpip_AddReg] +HKR,"Parameters","DataBasePath",0x00010000,"DataBasePath" +HKR,"Parameters","Domain",0x00010000,"" +HKR,"Parameters","Hostname",0x00010000,"ROSHost" +HKR,"Parameters","NameServer",0x00010000,"0.0.0.0" +HKR,"Parameters","ForwardBroadcasts",0x00010001,0x00000000 +HKR,"Parameters","IPEnableRouter",0x00010001,0x00000000 +HKR,"Parameters","SearchList",0x00010000,"" +HKR,"Parameters","EnableSecurityFilters",0x00010001,0x00000000 +;HKR,"Parameters","PersistentRoutes",,0x00000010 + ;-------------------------------- STRINGS ------------------------------- [Strings] ReactOS = "ReactOS Team" -

1 0

[hpoussin] 29996: Fix typo: "SourceDiskFiles" -> "SourceDisksFiles" Add more drivers to load in txtsetup.sif
by hpoussin＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: hpoussin Date: Wed Oct 31 11:56:24 2007 New Revision: 29996 URL: http://svn.reactos.org/svn/reactos?rev=29996&view=rev Log: Fix typo: "SourceDiskFiles" -> "SourceDisksFiles" Add more drivers to load in txtsetup.sif Modified: trunk/reactos/boot/bootdata/txtsetup.sif trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c Modified: trunk/reactos/boot/bootdata/txtsetup.sif URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/txtsetup.sif… ============================================================================== --- trunk/reactos/boot/bootdata/txtsetup.sif (original) +++ trunk/reactos/boot/bootdata/txtsetup.sif Wed Oct 31 11:56:24 2007 @@ -11,7 +11,9 @@ 6 = media\fonts 7 = bin -[SourceDiskFiles] +[SourceDisksFiles] +atapi.sys=,,,,,,x +buslogic.sys=,,,,,,x ;acpi.sys=,,,,,,x ;isapnp.sys=,,,,,,x ;pci.sys=,,,,,,x Modified: trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c (original) +++ trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c Wed Oct 31 11:56:24 2007 @@ -283,9 +283,6 @@ printf("Failed to get load options\n"); return; } -#if 0 - printf("LoadOptions: '%s'\n", LoadOptions); -#endif /* Set kernel command line */ MachDiskGetBootPath(reactos_kernel_cmdline, sizeof(reactos_kernel_cmdline)); @@ -311,13 +308,6 @@ Base = FrLdrCreateModule ("HARDWARE"); RegExportBinaryHive (L"\\Registry\\Machine\\HARDWARE", (PVOID)Base, &Size); FrLdrCloseModule (Base, Size); - -#if 0 - printf("Base: %x\n", Base); - printf("Size: %u\n", Size); - printf("*** System stopped ***\n"); -for(;;); -#endif /* Insert boot disk 2 */ if (MachDiskBootingFromFloppy()) @@ -410,21 +400,13 @@ return; } - /* Load atapi.sys (depends on hardware detection) */ - if (!LoadDriver(SourcePath, "atapi.sys")) - return; - - /* Load buslogic.sys (depends on hardware detection) */ - if (!LoadDriver(SourcePath, "buslogic.sys")) - return; - /* Load vfatfs.sys (could be loaded by the setup prog!) */ if (!LoadDriver(SourcePath, "vfatfs.sys")) return; /* Load additional files specified in txtsetup.inf */ if (InfFindFirstLine(InfHandle, - "SourceDiskFiles", + "SourceDisksFiles", NULL, &InfContext)) {

1 0

[hpoussin] 29995: Fix indentation
by hpoussin＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: hpoussin Date: Wed Oct 31 11:40:46 2007 New Revision: 29995 URL: http://svn.reactos.org/svn/reactos?rev=29995&view=rev Log: Fix indentation Modified: trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp Modified: trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw… ============================================================================== --- trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp (original) +++ trunk/reactos/tools/rbuild/backend/mingw/mingw.cpp Wed Oct 31 11:40:46 2007 @@ -947,10 +947,10 @@ NUL ); fp = popen ( versionCommand.c_str () , "r" ); for( i = 0; - ( i < 80 ) && - ( feof ( fp ) == 0 && - ( ( ch = fgetc( fp ) ) != -1 ) ); - i++ ) + ( i < 80 ) && + ( feof ( fp ) == 0 && + ( ( ch = fgetc( fp ) ) != -1 ) ); + i++ ) { buffer[i] = (char) ch; }

1 0

[hpoussin] 29994: Link xcopy to wine library, as it is using wine debug macros
by hpoussin＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: hpoussin Date: Wed Oct 31 11:08:00 2007 New Revision: 29994 URL: http://svn.reactos.org/svn/reactos?rev=29994&view=rev Log: Link xcopy to wine library, as it is using wine debug macros Modified: trunk/reactos/base/applications/cmdutils/xcopy/xcopy.rbuild Modified: trunk/reactos/base/applications/cmdutils/xcopy/xcopy.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/cmdutils… ============================================================================== --- trunk/reactos/base/applications/cmdutils/xcopy/xcopy.rbuild (original) +++ trunk/reactos/base/applications/cmdutils/xcopy/xcopy.rbuild Wed Oct 31 11:08:00 2007 @@ -2,6 +2,7 @@ <!DOCTYPE module SYSTEM "../../../tools/rbuild/project.dtd"> <module name="xcopy" type="win32cui" installbase="system32" installname="xcopy.exe" allowwarnings="true" unicode="true"> <include base="xcopy">.</include> + <library>wine</library> <library>kernel32</library> <library>advapi32</library> <library>user32</library>

1 0

[jimtabor] 29993: Fix gdi init so it can support batch. Used wrong limit source.
by jimtabor＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: jimtabor Date: Wed Oct 31 05:48:54 2007 New Revision: 29993 URL: http://svn.reactos.org/svn/reactos?rev=29993&view=rev Log: Fix gdi init so it can support batch. Used wrong limit source. Modified: trunk/reactos/dll/win32/gdi32/main/dllmain.c trunk/reactos/include/ndk/pstypes.h trunk/reactos/subsystems/win32/win32k/main/dllmain.c Modified: trunk/reactos/dll/win32/gdi32/main/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/gdi32/main/dllma… ============================================================================== --- trunk/reactos/dll/win32/gdi32/main/dllmain.c (original) +++ trunk/reactos/dll/win32/gdi32/main/dllmain.c Wed Oct 31 05:48:54 2007 @@ -37,7 +37,7 @@ /* map the gdi handle table to user space */ GdiHandleTable = NtCurrentTeb()->ProcessEnvironmentBlock->GdiSharedHandleTable; CurrentProcessId = NtCurrentTeb()->Cid.UniqueProcess; - GDI_BatchLimit = NtCurrentTeb()->GdiBatchCount; + GDI_BatchLimit = (DWORD) NtCurrentTeb()->ProcessEnvironmentBlock->GdiDCAttributeList; } @@ -59,23 +59,21 @@ break; case DLL_THREAD_ATTACH: + NtCurrentTeb()->GdiTebBatch.Offset = 0; + NtCurrentTeb()->GdiBatchCount = 0; break; default: return FALSE; } -#if 0 - /* FIXME: working teb handling needed */ - NtCurrentTeb()->GdiTebBatch.Offset = 0; - NtCurrentTeb()->GdiBatchCount = 0; -#endif // Very simple, the list will fill itself as it is needed. if(!SetStockObjects) { RtlZeroMemory( &stock_objects, NB_STOCK_OBJECTS); //Assume Ros is dirty. SetStockObjects = TRUE; } + return TRUE; } Modified: trunk/reactos/include/ndk/pstypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/pstypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/pstypes.h (original) +++ trunk/reactos/include/ndk/pstypes.h Wed Oct 31 05:48:54 2007 @@ -627,7 +627,7 @@ PVOID* ProcessHeaps; PVOID GdiSharedHandleTable; PVOID ProcessStarterHelper; - PVOID GdiDCAttributeList; + ULONG GdiDCAttributeList; #if (NTDDI_VERSION >= NTDDI_LONGHORN) struct _RTL_CRITICAL_SECTION *LoaderLock; #else Modified: trunk/reactos/subsystems/win32/win32k/main/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ma… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/main/dllmain.c (original) +++ trunk/reactos/subsystems/win32/win32k/main/dllmain.c Wed Oct 31 05:48:54 2007 @@ -117,6 +117,7 @@ { /* map the gdi handle table to user land */ Process->Peb->GdiSharedHandleTable = GDI_MapHandleTable(GdiTableSection, Process); + Process->Peb->GdiDCAttributeList = 5; } /* setup process flags */

1 0

[jimtabor] 29992: - Add gdi batching command structures. - Add additional region clipping data types to Dc_Attr.
by jimtabor＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: jimtabor Date: Wed Oct 31 04:47:54 2007 New Revision: 29992 URL: http://svn.reactos.org/svn/reactos?rev=29992&view=rev Log: - Add gdi batching command structures. - Add additional region clipping data types to Dc_Attr. Modified: trunk/reactos/include/reactos/win32k/ntgdihdl.h trunk/reactos/include/reactos/win32k/ntgdityp.h Modified: trunk/reactos/include/reactos/win32k/ntgdihdl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntg… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntgdihdl.h (original) +++ trunk/reactos/include/reactos/win32k/ntgdihdl.h Wed Oct 31 04:47:54 2007 @@ -281,6 +281,11 @@ SIZEL szlVirtualDeviceSize; POINTL ptlBrushOrigin; RGNATTR VisRectRegion; + FLONG RgnFlags; + COLORREF crRgnBgndClr; + ULONG ulRgnBgndClr; + HANDLE hRgnbrush; + HANDLE hRgnpen; } DC_ATTR, *PDC_ATTR; #endif Modified: trunk/reactos/include/reactos/win32k/ntgdityp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntg… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntgdityp.h (original) +++ trunk/reactos/include/reactos/win32k/ntgdityp.h Wed Oct 31 04:47:54 2007 @@ -176,5 +176,110 @@ ULONG l; } gxf_long; - +// +// GDI Batch structures. +// +typedef struct _GDIBATCHHDR +{ + SHORT Size; + SHORT Cmd; +} GDIBATCHHDR, *PGDIBATCHHDR; + +typedef struct _GDIBSPATBLT +{ + GDIBATCHHDR gbHdr; + int nXLeft; + int nYLeft; + int nWidth; + int nHeight; + HANDLE hbrush; + DWORD dwRop; + COLORREF crForegroundClr; + COLORREF crBackgroundClr; + COLORREF crBrushClr; + INT IcmBrushColor; + POINTL ptlViewportOrg; + ULONG ulForegroundClr; + ULONG ulBackgroundClr; + ULONG ulBrushClr; +} GDIBSPATBLT, *PGDIBSPATBLT; + +#ifndef _NTUSRTYP_ +typedef struct _PATRECT +{ + RECT r; + HBRUSH hBrush; +} PATRECT, * PPATRECT; #endif + +typedef struct _GDIBSPPATBLT +{ + GDIBATCHHDR gbHdr; + DWORD rop4; + DWORD Mode; + DWORD Count; + COLORREF crForegroundClr; + COLORREF crBackgroundClr; + COLORREF crBrushClr; + ULONG ulForegroundClr; + ULONG ulBackgroundClr; + ULONG ulBrushClr; + POINTL ptlViewportOrg; + PATRECT pRect; // POLYPATBLT +} GDIBSPPATBLT, *PGDIBSPPATBLT; + +typedef struct _GDIBSTEXTOUT +{ + GDIBATCHHDR gbHdr; + COLORREF crForegroundClr; + COLORREF crBackgroundClr; + LONG lmBkMode; + ULONG ulForegroundClr; + ULONG ulBackgroundClr; + int x; + int y; + UINT Options; + RECT Rect; + DWORD iCS_CP; + UINT cbCount; + UINT Size; + HANDLE hlfntNew; + FLONG flTextAlign; + POINTL ptlViewportOrg; + CHAR String[1]; +} GDIBSTEXTOUT, *PGDIBSTEXTOUT; + +typedef struct _GDIBSEXTTEXTOUT +{ + GDIBATCHHDR gbHdr; + UINT Count; + UINT Options; + RECT Rect; + POINTL ptlViewportOrg; + ULONG ulBackgroundClr; +} GDIBSEXTTEXTOUT, *PGDIBSEXTTEXTOUT; + +typedef struct _GDIBSSETBRHORG +{ + GDIBATCHHDR gbHdr; + POINTL ptlBrushOrigin; +} GDIBSSETBRHORG, *PGDIBSSETBRHORG; + +typedef struct _GDIBSEXTSELCLPRGN +{ + GDIBATCHHDR gbHdr; + int fnMode; + HANDLE hbrush; + HANDLE hpen; + COLORREF crBackgroundClr; + ULONG ulBackgroundClr; +} GDIBSEXTSELCLPRGN, *PGDIBSEXTSELCLPRGN; +// +// Use with GdiBCSelObj, GdiBCDelObj and GdiBCDelRgn. +typedef struct _GDIBSOBJECT +{ + GDIBATCHHDR gbHdr; + HGDIOBJ hgdiobj; +} GDIBSOBJJECT, *PGDIBSOBJECT; + +#endif

1 0

[weiden] 29991: Fix freeing callproc handles when freeing window classes
by weiden＠svn.reactos.org 31 Oct '07

31 Oct '07

Author: weiden Date: Wed Oct 31 04:25:42 2007 New Revision: 29991 URL: http://svn.reactos.org/svn/reactos?rev=29991&view=rev Log: Fix freeing callproc handles when freeing window classes Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Wed Oct 31 04:25:42 2007 @@ -69,7 +69,7 @@ CallProc->Next = NULL; DestroyCallProc(NULL, - Class->CallProc); + CallProc); CallProc = NextCallProc; }

1 0

[weiden] 29990: Remove unused code
by weiden＠svn.reactos.org 30 Oct '07

30 Oct '07

Author: weiden Date: Wed Oct 31 01:56:59 2007 New Revision: 29990 URL: http://svn.reactos.org/svn/reactos?rev=29990&view=rev Log: Remove unused code Modified: trunk/reactos/include/reactos/win32k/ntuser.h trunk/reactos/subsystems/win32/win32k/ntuser/class.c Modified: trunk/reactos/include/reactos/win32k/ntuser.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/win32k/ntu… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntuser.h (original) +++ trunk/reactos/include/reactos/win32k/ntuser.h Wed Oct 31 01:56:59 2007 @@ -36,7 +36,6 @@ WNDPROC WndProcExtra; PCALLPROC CallProc; }; - PCALLPROC CallProc2; PCALLPROC CallProcList; INT ClsExtra; INT WndExtra; Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Wed Oct 31 01:56:59 2007 @@ -545,7 +545,6 @@ if (!Class->System) Clone->CallProc = Class->CallProc; - Clone->CallProc2 = Class->CallProc2; Clone = Clone->Next; }

1 0

[weiden] 29989: Silence possible uninitialized variable warning when compiled with full optimizations
by weiden＠svn.reactos.org 30 Oct '07

30 Oct '07

Author: weiden Date: Wed Oct 31 01:38:43 2007 New Revision: 29989 URL: http://svn.reactos.org/svn/reactos?rev=29989&view=rev Log: Silence possible uninitialized variable warning when compiled with full optimizations Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c Modified: trunk/reactos/ntoskrnl/rtl/libsupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/rtl/libsupp.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/rtl/libsupp.c (original) +++ trunk/reactos/ntoskrnl/rtl/libsupp.c Wed Oct 31 01:38:43 2007 @@ -264,7 +264,7 @@ IN ULONG Count, IN ULONG Flags) { - ULONG_PTR Stack, NewStack, StackBegin, StackEnd; + ULONG_PTR Stack, NewStack, StackBegin, StackEnd = 0; ULONG Eip; BOOLEAN Result, StopSearch = FALSE; ULONG i = 0;

1 0

[weiden] 29988: fix compilation with full optimizations
by weiden＠svn.reactos.org 30 Oct '07

30 Oct '07

Author: weiden Date: Wed Oct 31 01:03:37 2007 New Revision: 29988 URL: http://svn.reactos.org/svn/reactos?rev=29988&view=rev Log: fix compilation with full optimizations Modified: trunk/reactos/lib/rtl/sd.c Modified: trunk/reactos/lib/rtl/sd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/sd.c?rev=29988&r1=… ============================================================================== --- trunk/reactos/lib/rtl/sd.c (original) +++ trunk/reactos/lib/rtl/sd.c Wed Oct 31 01:03:37 2007 @@ -138,8 +138,8 @@ RtlCopySecurityDescriptor(IN PSECURITY_DESCRIPTOR pSourceSecurityDescriptor, OUT PSECURITY_DESCRIPTOR pDestinationSecurityDescriptor) { - PSID Owner, Group; - PACL Dacl, Sacl; + PSID Owner = NULL, Group = NULL; + PACL Dacl = NULL, Sacl = NULL; BOOLEAN Defaulted, Present; DWORD OwnerLength, GroupLength; PSECURITY_DESCRIPTOR srcSD = pSourceSecurityDescriptor;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs