Ros-diffs

ros-diffs@reactos.org

81390 discussions

[reactos] 10/13: [NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking minor
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=98a8e8f862251844fa39f… commit 98a8e8f862251844fa39faa57822485feaf9d937 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sun Jun 2 09:45:45 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [NTOS:IO] In IopSynchronousCall first check IrpStack->MajorFunction before checking minor Minor function indices are not unique, they are subfunctions, so without first checking the major function, they are ambiguous. --- ntoskrnl/io/pnpmgr/pnpmgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/io/pnpmgr/pnpmgr.c b/ntoskrnl/io/pnpmgr/pnpmgr.c index e5530c61714..f2048782af0 100644 --- a/ntoskrnl/io/pnpmgr/pnpmgr.c +++ b/ntoskrnl/io/pnpmgr/pnpmgr.c @@ -1441,7 +1441,8 @@ IopSynchronousCall(IN PDEVICE_OBJECT DeviceObject, Irp->IoStatus.Information = IoStatusBlock.Information = 0; /* Special case for IRP_MN_FILTER_RESOURCE_REQUIREMENTS */ - if (IoStackLocation->MinorFunction == IRP_MN_FILTER_RESOURCE_REQUIREMENTS) + if ((IoStackLocation->MajorFunction == IRP_MJ_PNP) && + (IoStackLocation->MinorFunction == IRP_MN_FILTER_RESOURCE_REQUIREMENTS)) { /* Copy the resource requirements list into the IOSB */ Irp->IoStatus.Information =

1 0

[reactos] 09/13: [BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=05b37f63ea7987a3582bf… commit 05b37f63ea7987a3582bf4a6ebf2c3b07b167016 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Jun 1 14:42:14 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [BROWSEUI] Try to "fix" IEThreadParamBlock structure for x64 --- sdk/include/reactos/browseui_undoc.h | 40 ++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/sdk/include/reactos/browseui_undoc.h b/sdk/include/reactos/browseui_undoc.h index 4cd00096c53..f90ac9ada1c 100644 --- a/sdk/include/reactos/browseui_undoc.h +++ b/sdk/include/reactos/browseui_undoc.h @@ -25,6 +25,45 @@ extern "C" { #endif /* defined(__cplusplus) */ +// Name is IETHREADPARAM according to symbols / mangled function names +#ifdef _WIN64 +typedef struct IEThreadParamBlock +{ + long offset0; // 0x00 + UCHAR gap4[4]; + DWORD dwFlags; // 0x08 + long offset8; // 0x0c + IUnknown* offsetC; // 0x10 + long offset10; // 0x18 + char padding1[4]; // 0x1c + IUnknown* offset14; // 0x20 + LPITEMIDLIST directoryPIDL; // 0x28 + WCHAR awsz_30[21]; // 0x30 + WCHAR awszEventName[21]; // 0x5A + char padding2[4]; // 0x84 + IUnknown* offset70; // 0x88 + long offset74; // 0x90 unknown contents + char padding3[4]; // 0x94 + IUnknown* offset78; // 0x98 + LPITEMIDLIST offset7C; // 0xa0 + LPITEMIDLIST offset80; // 0xa8 + LONG offset84; // 0xb0 + LONG offset88; // 0xb4 + LONG offset8C; // 0xb8 + LONG offset90; // 0xbc + LONG offset94; // 0xc0 + LONG offset98; // 0xc4 + LONG offset9C; // 0xc8 + LONG offsetA0; // 0xcc + char field_B4[52]; + LONG offsetD8; // 0x104 + UCHAR gap108[24]; + DWORD dword120; + DWORD dword124; + IUnknown* offsetF8; // 0x128 instance explorer + UCHAR byteflags_130; +} IE_THREAD_PARAM_BLOCK, * PIE_THREAD_PARAM_BLOCK; +#else typedef struct IEThreadParamBlock { long offset0; @@ -54,6 +93,7 @@ typedef struct IEThreadParamBlock IUnknown * offsetF8; // instance explorer LONG offsetFC; // unknown contents } IE_THREAD_PARAM_BLOCK, *PIE_THREAD_PARAM_BLOCK; +#endif typedef struct ExplorerCommandLineParseResults {

1 0

[reactos] 08/13: [PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ede5ec65c2451bd060de2… commit ede5ec65c2451bd060de2fd6158ec14a67a3ea39 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Apr 22 13:03:24 2019 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [PSDK] dbghelp.h: Fix 64 bit version of LOADED_IMAGE --- sdk/include/psdk/dbghelp.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sdk/include/psdk/dbghelp.h b/sdk/include/psdk/dbghelp.h index b26908a6730..aa0cdff1c69 100644 --- a/sdk/include/psdk/dbghelp.h +++ b/sdk/include/psdk/dbghelp.h @@ -99,7 +99,11 @@ typedef struct _LOADED_IMAGE PSTR ModuleName; HANDLE hFile; PUCHAR MappedAddress; - PIMAGE_NT_HEADERS FileHeader; +#ifdef _IMAGEHLP64 + PIMAGE_NT_HEADERS64 FileHeader; +#else + PIMAGE_NT_HEADERS32 FileHeader; +#endif PIMAGE_SECTION_HEADER LastRvaSection; ULONG NumberOfSections; PIMAGE_SECTION_HEADER Sections;

1 0

[reactos] 07/13: [TDI] Improve spec file
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0e8392beea3f6164755e1… commit 0e8392beea3f6164755e1dba7a5fe6a0e7fadcb3 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Aug 20 17:11:40 2018 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [TDI] Improve spec file --- drivers/network/tdi/misc/tdi.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/network/tdi/misc/tdi.spec b/drivers/network/tdi/misc/tdi.spec index 24b8c246958..a6b6b2bf202 100644 --- a/drivers/network/tdi/misc/tdi.spec +++ b/drivers/network/tdi/misc/tdi.spec @@ -1,6 +1,6 @@ @ stdcall CTEAllocateString(long long) @ stdcall CTEBlock(long) - @ stdcall CTEInitEvent(long long) + @ stdcall CTEInitEvent(ptr ptr) @ stdcall CTEInitString(long long) @ stdcall CTEInitTimer(long) @ stdcall CTEInitialize() @@ -34,7 +34,7 @@ @ stdcall TdiOpenNetbiosAddress(long long long long) @ stdcall TdiRegisterAddressChangeHandler(long long long) @ stdcall TdiRegisterDeviceObject(long long) - @ stdcall TdiRegisterNetAddress(long ptr ptr ptr) + @ stdcall TdiRegisterNetAddress(ptr ptr ptr ptr) @ stdcall TdiRegisterNotificationHandler(long long long) @ stdcall TdiRegisterPnPHandlers(ptr long ptr) @ stdcall TdiReturnChainedReceives(ptr long)

1 0

[reactos] 06/13: [PSDK] Fix #ifdef in winuser.h
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=94e5e79e3b004f7f11fa5… commit 94e5e79e3b004f7f11fa52da3f37e944cd5d4cdd Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Mon Aug 20 16:02:44 2018 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [PSDK] Fix #ifdef in winuser.h --- sdk/include/psdk/winuser.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/include/psdk/winuser.h b/sdk/include/psdk/winuser.h index 594b15beb17..3ec3858e12c 100644 --- a/sdk/include/psdk/winuser.h +++ b/sdk/include/psdk/winuser.h @@ -5600,14 +5600,14 @@ typedef MONITORINFOEXW MONITORINFOEX, *LPMONITORINFOEX; #define wsprintf wsprintfW #define wvsprintf wvsprintfW -#ifndef NOGDI +#if defined(_WINGDI_) && !defined(NOGDI) #define ChangeDisplaySettings ChangeDisplaySettingsW #define ChangeDisplaySettingsEx ChangeDisplaySettingsExW #define CreateDesktop CreateDesktopW #define EnumDisplaySettings EnumDisplaySettingsW #define EnumDisplaySettingsEx EnumDisplaySettingsExW #define EnumDisplayDevices EnumDisplayDevicesW -#endif /* NOGDI */ +#endif /* _WINGDI_ && !NOGDI */ #else /* UNICODE */ #define EDITWORDBREAKPROC EDITWORDBREAKPROCA #define PROPENUMPROC PROPENUMPROCA @@ -5772,7 +5772,7 @@ typedef MONITORINFOEXA MONITORINFOEX, *LPMONITORINFOEX; #define EnumDisplaySettings EnumDisplaySettingsA #define EnumDisplaySettingsEx EnumDisplaySettingsExA #define EnumDisplayDevices EnumDisplayDevicesA -#endif /* NOGDI */ +#endif /* _WINGDI_ && !NOGDI */ #endif /* UNICODE */ #endif /* RC_INVOKED */

1 0

[reactos] 05/13: [VIDEOPRT] Fix order of some exports
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=93028748c9580f7d0d0bd… commit 93028748c9580f7d0d0bd9bae94c067e866f2fb1 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Jul 12 13:23:04 2018 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [VIDEOPRT] Fix order of some exports --- win32ss/drivers/videoprt/videoprt.spec | 66 +++++++++++++++++----------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/win32ss/drivers/videoprt/videoprt.spec b/win32ss/drivers/videoprt/videoprt.spec index 15d1a841f0b..ee12c0692de 100644 --- a/win32ss/drivers/videoprt/videoprt.spec +++ b/win32ss/drivers/videoprt/videoprt.spec @@ -72,30 +72,30 @@ @ stdcall -arch=i386,arm VideoPortQuerySystemTime(ptr) NTOSKRNL.KeQuerySystemTime @ stdcall -arch=x86_64 VideoPortQuerySystemTime(ptr) @ stdcall VideoPortQueueDpc(ptr ptr ptr) -@ stdcall -arch=i386,arm VideoPortReadPortUchar(ptr) HAL.READ_PORT_UCHAR -@ stdcall -arch=x86_64 VideoPortReadPortUchar(ptr) -@ stdcall -arch=i386,arm VideoPortReadPortUshort(ptr) HAL.READ_PORT_USHORT -@ stdcall -arch=x86_64 VideoPortReadPortUshort(ptr) -@ stdcall -arch=i386,arm VideoPortReadPortUlong(ptr) HAL.READ_PORT_ULONG -@ stdcall -arch=x86_64 VideoPortReadPortUlong(ptr) @ stdcall -arch=i386,arm VideoPortReadPortBufferUchar(ptr ptr long) HAL.READ_PORT_BUFFER_UCHAR @ stdcall -arch=x86_64 VideoPortReadPortBufferUchar(ptr ptr long) -@ stdcall -arch=i386,arm VideoPortReadPortBufferUshort(ptr ptr long) HAL.READ_PORT_BUFFER_USHORT -@ stdcall -arch=x86_64 VideoPortReadPortBufferUshort(ptr ptr long) @ stdcall -arch=i386,arm VideoPortReadPortBufferUlong(ptr ptr long) HAL.READ_PORT_BUFFER_ULONG @ stdcall -arch=x86_64 VideoPortReadPortBufferUlong(ptr ptr long) -@ stdcall -arch=i386,arm VideoPortReadRegisterUchar(ptr) NTOSKRNL.READ_REGISTER_UCHAR -@ stdcall -arch=x86_64 VideoPortReadRegisterUchar(ptr) -@ stdcall -arch=i386,arm VideoPortReadRegisterUshort(ptr) NTOSKRNL.READ_REGISTER_USHORT -@ stdcall -arch=x86_64 VideoPortReadRegisterUshort(ptr) -@ stdcall -arch=i386,arm VideoPortReadRegisterUlong(ptr) NTOSKRNL.READ_REGISTER_ULONG -@ stdcall -arch=x86_64 VideoPortReadRegisterUlong(ptr) +@ stdcall -arch=i386,arm VideoPortReadPortBufferUshort(ptr ptr long) HAL.READ_PORT_BUFFER_USHORT +@ stdcall -arch=x86_64 VideoPortReadPortBufferUshort(ptr ptr long) +@ stdcall -arch=i386,arm VideoPortReadPortUchar(ptr) HAL.READ_PORT_UCHAR +@ stdcall -arch=x86_64 VideoPortReadPortUchar(ptr) +@ stdcall -arch=i386,arm VideoPortReadPortUlong(ptr) HAL.READ_PORT_ULONG +@ stdcall -arch=x86_64 VideoPortReadPortUlong(ptr) +@ stdcall -arch=i386,arm VideoPortReadPortUshort(ptr) HAL.READ_PORT_USHORT +@ stdcall -arch=x86_64 VideoPortReadPortUshort(ptr) @ stdcall -arch=i386,arm VideoPortReadRegisterBufferUchar(ptr ptr long) NTOSKRNL.READ_REGISTER_BUFFER_UCHAR @ stdcall -arch=x86_64 VideoPortReadRegisterBufferUchar(ptr ptr long) -@ stdcall -arch=i386,arm VideoPortReadRegisterBufferUshort(ptr ptr long) NTOSKRNL.READ_REGISTER_BUFFER_USHORT -@ stdcall -arch=x86_64 VideoPortReadRegisterBufferUshort(ptr ptr long) @ stdcall -arch=i386,arm VideoPortReadRegisterBufferUlong(ptr ptr long) NTOSKRNL.READ_REGISTER_BUFFER_ULONG @ stdcall -arch=x86_64 VideoPortReadRegisterBufferUlong(ptr ptr long) +@ stdcall -arch=i386,arm VideoPortReadRegisterBufferUshort(ptr ptr long) NTOSKRNL.READ_REGISTER_BUFFER_USHORT +@ stdcall -arch=x86_64 VideoPortReadRegisterBufferUshort(ptr ptr long) +@ stdcall -arch=i386,arm VideoPortReadRegisterUchar(ptr) NTOSKRNL.READ_REGISTER_UCHAR +@ stdcall -arch=x86_64 VideoPortReadRegisterUchar(ptr) +@ stdcall -arch=i386,arm VideoPortReadRegisterUlong(ptr) NTOSKRNL.READ_REGISTER_ULONG +@ stdcall -arch=x86_64 VideoPortReadRegisterUlong(ptr) +@ stdcall -arch=i386,arm VideoPortReadRegisterUshort(ptr) NTOSKRNL.READ_REGISTER_USHORT +@ stdcall -arch=x86_64 VideoPortReadRegisterUshort(ptr) @ stdcall VideoPortReadStateEvent(ptr ptr) @ stdcall VideoPortRegisterBugcheckCallback(ptr long ptr long) @ stdcall VideoPortReleaseBuffer(ptr ptr) @@ -122,31 +122,31 @@ @ stdcall VideoPortUnmapMemory(ptr ptr ptr) @ stdcall VideoPortVerifyAccessRanges(ptr long ptr) @ stdcall VideoPortWaitForSingleObject(ptr ptr ptr) -@ stdcall -arch=i386,arm VideoPortWritePortUchar(ptr long) HAL.WRITE_PORT_UCHAR -@ stdcall -arch=x86_64 VideoPortWritePortUchar(ptr long) -@ stdcall -arch=i386,arm VideoPortWritePortUshort(ptr long) HAL.WRITE_PORT_USHORT -@ stdcall -arch=x86_64 VideoPortWritePortUshort(ptr long) -@ stdcall -arch=i386,arm VideoPortWritePortUlong(ptr long) HAL.WRITE_PORT_ULONG -@ stdcall -arch=x86_64 VideoPortWritePortUlong(ptr long) @ stdcall -arch=i386,arm VideoPortWritePortBufferUchar(ptr ptr long) HAL.WRITE_PORT_BUFFER_UCHAR @ stdcall -arch=x86_64 VideoPortWritePortBufferUchar(ptr ptr long) -@ stdcall -arch=i386,arm VideoPortWritePortBufferUshort(ptr ptr long) HAL.WRITE_PORT_BUFFER_USHORT -@ stdcall -arch=x86_64 VideoPortWritePortBufferUshort(ptr ptr long) @ stdcall -arch=i386,arm VideoPortWritePortBufferUlong(ptr ptr long) HAL.WRITE_PORT_BUFFER_ULONG @ stdcall -arch=x86_64 VideoPortWritePortBufferUlong(ptr ptr long) -@ stdcall -arch=i386,arm VideoPortWriteRegisterUchar(ptr long) NTOSKRNL.WRITE_REGISTER_UCHAR -@ stdcall -arch=x86_64 VideoPortWriteRegisterUchar(ptr long) -@ stdcall -arch=i386,arm VideoPortWriteRegisterUshort(ptr long) NTOSKRNL.WRITE_REGISTER_USHORT -@ stdcall -arch=x86_64 VideoPortWriteRegisterUshort(ptr long) -@ stdcall -arch=i386,arm VideoPortWriteRegisterUlong(ptr long) NTOSKRNL.WRITE_REGISTER_ULONG -@ stdcall -arch=x86_64 VideoPortWriteRegisterUlong(ptr long) +@ stdcall -arch=i386,arm VideoPortWritePortBufferUshort(ptr ptr long) HAL.WRITE_PORT_BUFFER_USHORT +@ stdcall -arch=x86_64 VideoPortWritePortBufferUshort(ptr ptr long) +@ stdcall -arch=i386,arm VideoPortWritePortUchar(ptr long) HAL.WRITE_PORT_UCHAR +@ stdcall -arch=x86_64 VideoPortWritePortUchar(ptr long) +@ stdcall -arch=i386,arm VideoPortWritePortUlong(ptr long) HAL.WRITE_PORT_ULONG +@ stdcall -arch=x86_64 VideoPortWritePortUlong(ptr long) +@ stdcall -arch=i386,arm VideoPortWritePortUshort(ptr long) HAL.WRITE_PORT_USHORT +@ stdcall -arch=x86_64 VideoPortWritePortUshort(ptr long) @ stdcall -arch=i386,arm VideoPortWriteRegisterBufferUchar(ptr ptr long) NTOSKRNL.WRITE_REGISTER_BUFFER_UCHAR @ stdcall -arch=x86_64 VideoPortWriteRegisterBufferUchar(ptr ptr long) -@ stdcall -arch=i386,arm VideoPortWriteRegisterBufferUshort(ptr ptr long) NTOSKRNL.WRITE_REGISTER_BUFFER_USHORT -@ stdcall -arch=x86_64 VideoPortWriteRegisterBufferUshort(ptr ptr long) @ stdcall -arch=i386,arm VideoPortWriteRegisterBufferUlong(ptr ptr long) NTOSKRNL.WRITE_REGISTER_BUFFER_ULONG @ stdcall -arch=x86_64 VideoPortWriteRegisterBufferUlong(ptr ptr long) -@ stdcall VideoPortZeroMemory(ptr long) NTOSKRNL.RtlZeroMemory +@ stdcall -arch=i386,arm VideoPortWriteRegisterBufferUshort(ptr ptr long) NTOSKRNL.WRITE_REGISTER_BUFFER_USHORT +@ stdcall -arch=x86_64 VideoPortWriteRegisterBufferUshort(ptr ptr long) +@ stdcall -arch=i386,arm VideoPortWriteRegisterUchar(ptr long) NTOSKRNL.WRITE_REGISTER_UCHAR +@ stdcall -arch=x86_64 VideoPortWriteRegisterUchar(ptr long) +@ stdcall -arch=i386,arm VideoPortWriteRegisterUlong(ptr long) NTOSKRNL.WRITE_REGISTER_ULONG +@ stdcall -arch=x86_64 VideoPortWriteRegisterUlong(ptr long) +@ stdcall -arch=i386,arm VideoPortWriteRegisterUshort(ptr long) NTOSKRNL.WRITE_REGISTER_USHORT +@ stdcall -arch=x86_64 VideoPortWriteRegisterUshort(ptr long) @ stdcall VideoPortZeroDeviceMemory(ptr long) NTOSKRNL.RtlZeroMemory +@ stdcall VideoPortZeroMemory(ptr long) NTOSKRNL.RtlZeroMemory @ stdcall VpNotifyEaData(ptr ptr) @ stdcall WdDdiWatchdogDpcCallback(ptr ptr ptr ptr)

1 0

[reactos] 04/13: [NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop in ExAllocateLocallyUniqueId
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fffe4f6385fed59082ea5… commit fffe4f6385fed59082ea5e1fd3b91b99f848ef3d Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Jul 12 15:54:52 2018 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [NTOS:EX] Use InterlockedExchangeAdd64 instead of InterlockedCompareExchange64 loop in ExAllocateLocallyUniqueId --- ntoskrnl/ex/uuid.c | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/ntoskrnl/ex/uuid.c b/ntoskrnl/ex/uuid.c index 4d3c2932bce..8af4776d0b1 100644 --- a/ntoskrnl/ex/uuid.c +++ b/ntoskrnl/ex/uuid.c @@ -339,27 +339,9 @@ VOID NTAPI ExAllocateLocallyUniqueId(OUT LUID *LocallyUniqueId) { - LARGE_INTEGER PrevLuid; - LONGLONG NewLuid, CompLuid; - /* Atomically increment the luid */ - PrevLuid.QuadPart = ExpLuid.QuadPart; - for (NewLuid = ExpLuid.QuadPart + ExpLuidIncrement; ; - NewLuid = PrevLuid.QuadPart + ExpLuidIncrement) - { - CompLuid = InterlockedCompareExchange64(&ExpLuid.QuadPart, - NewLuid, - PrevLuid.QuadPart); - if (CompLuid == PrevLuid.QuadPart) - { - break; - } - - PrevLuid.QuadPart = CompLuid; - } - - LocallyUniqueId->LowPart = PrevLuid.LowPart; - LocallyUniqueId->HighPart = PrevLuid.HighPart; + *(LONG64*)LocallyUniqueId = InterlockedExchangeAdd64(&ExpLuid.QuadPart, + ExpLuidIncrement); }

1 0

[reactos] 03/13: [WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=21c9f2a48811afa5acb37… commit 21c9f2a48811afa5acb37424e70daee5c8f4e01a Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sun Feb 11 21:53:03 2018 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [WIN32K] InitVideo() should return NTSTATUS, so return STATUS_SUCCESS instead of 1 --- win32ss/user/ntuser/display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win32ss/user/ntuser/display.c b/win32ss/user/ntuser/display.c index 19264d613b0..20bbdfceacb 100644 --- a/win32ss/user/ntuser/display.c +++ b/win32ss/user/ntuser/display.c @@ -282,7 +282,7 @@ InitVideo(VOID) InitSysParams(); - return 1; + return STATUS_SUCCESS; } NTSTATUS

1 0

[reactos] 02/13: [NTOS:IO] Improve an alignment
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e50873376d9139496203e… commit e50873376d9139496203ea2b890c26a186ecbed3 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Jan 4 18:29:24 2018 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [NTOS:IO] Improve an alignment --- ntoskrnl/io/iomgr/device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/io/iomgr/device.c b/ntoskrnl/io/iomgr/device.c index 3810dd587c4..56a4bd7e3ed 100644 --- a/ntoskrnl/io/iomgr/device.c +++ b/ntoskrnl/io/iomgr/device.c @@ -1084,7 +1084,8 @@ IoCreateDevice(IN PDRIVER_OBJECT DriverObject, if (DeviceName) ObjectAttributes.Attributes |= OBJ_PERMANENT; /* Align the Extension Size to 8-bytes */ - AlignedDeviceExtensionSize = (DeviceExtensionSize + 7) &~ 7; + AlignedDeviceExtensionSize = ALIGN_UP_BY(DeviceExtensionSize, + MEMORY_ALLOCATION_ALIGNMENT); /* Total Size */ TotalSize = AlignedDeviceExtensionSize +

1 0

[reactos] 01/13: [KSUSER] Improve pointer arithmetics
by Timo Kreuzer 15 Aug '19

15 Aug '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=06e631fafec517ed5ee9d… commit 06e631fafec517ed5ee9da196684be5052b4a311 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Dec 28 18:35:30 2017 +0100 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Thu Aug 15 18:04:57 2019 +0200 [KSUSER] Improve pointer arithmetics --- dll/directx/ksuser/ksuser.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/directx/ksuser/ksuser.c b/dll/directx/ksuser/ksuser.c index 12b54e96261..d59a84e8058 100644 --- a/dll/directx/ksuser/ksuser.c +++ b/dll/directx/ksuser/ksuser.c @@ -195,7 +195,7 @@ KsCreatePin(HANDLE FilterHandle, PHANDLE ConnectionHandle) { ULONG BufferSize = sizeof(KSPIN_CONNECT); - PKSDATAFORMAT DataFormat = ((PKSDATAFORMAT) ((ULONG_PTR)Connect + sizeof(KSPIN_CONNECT))); + PKSDATAFORMAT DataFormat = (PKSDATAFORMAT)(Connect + 1); BufferSize += DataFormat->FormatSize;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs