Ros-diffs

ros-diffs@reactos.org

81390 discussions

02/09: [NTOS][MKHIVE] Minor code formatting.
by Hermès Bélusca-Maïto 14 Oct '18

14 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4caf3913242a0c908c29e… commit 4caf3913242a0c908c29e0cc34ea6464e8149f9d Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Oct 14 01:20:31 2018 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Oct 14 15:59:34 2018 +0200 [NTOS][MKHIVE] Minor code formatting. --- ntoskrnl/config/cmapi.c | 6 +++--- sdk/tools/mkhive/registry.c | 50 ++++++++++++++++++++++----------------------- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git a/ntoskrnl/config/cmapi.c b/ntoskrnl/config/cmapi.c index 85723d1881..3b476d8c8e 100644 --- a/ntoskrnl/config/cmapi.c +++ b/ntoskrnl/config/cmapi.c @@ -982,7 +982,7 @@ CmDeleteValueKey(IN PCM_KEY_CONTROL_BLOCK Kcb, } /* Get the key value */ - Value = (PCM_KEY_VALUE)HvGetCell(Hive,ChildCell); + Value = (PCM_KEY_VALUE)HvGetCell(Hive, ChildCell); ASSERT(Value); /* Mark it and all related data as dirty */ @@ -1851,7 +1851,7 @@ CmDeleteKey(IN PCM_KEY_BODY KeyBody) { /* Don't do it twice */ Status = STATUS_SUCCESS; - goto Quickie2; + goto Quickie; } /* Get the hive and node */ @@ -1925,7 +1925,7 @@ CmDeleteKey(IN PCM_KEY_BODY KeyBody) CmpUnlockHiveFlusher((PCMHIVE)Hive); /* Release the KCB locks */ -Quickie2: +Quickie: CmpReleaseTwoKcbLockByKey(Kcb->ConvKey, Kcb->ParentKcb->ConvKey); /* Release hive lock */ diff --git a/sdk/tools/mkhive/registry.c b/sdk/tools/mkhive/registry.c index 17030bb209..1686fca08d 100644 --- a/sdk/tools/mkhive/registry.c +++ b/sdk/tools/mkhive/registry.c @@ -370,7 +370,7 @@ LIST_ENTRY CmiHiveListHead; LIST_ENTRY CmiReparsePointsHead; static LONG -RegpOpenOrCreateKey( +RegpCreateOrOpenKey( IN HKEY hParentKey, IN PCWSTR KeyName, IN BOOL AllowCreation, @@ -390,7 +390,7 @@ RegpOpenOrCreateKey( PCM_KEY_NODE SubKeyCell; HCELL_INDEX BlockOffset; - DPRINT("RegpCreateOpenKey('%S')\n", KeyName); + DPRINT("RegpCreateOrOpenKey('%S')\n", KeyName); if (*KeyName == OBJ_NAME_PATH_SEPARATOR) { @@ -491,26 +491,7 @@ RegCreateKeyW( IN LPCWSTR lpSubKey, OUT PHKEY phkResult) { - return RegpOpenOrCreateKey(hKey, lpSubKey, TRUE, FALSE, phkResult); -} - -LONG WINAPI -RegDeleteKeyW( - IN HKEY hKey, - IN LPCWSTR lpSubKey) -{ - DPRINT1("RegDeleteKeyW(0x%p, '%S') is UNIMPLEMENTED!\n", - hKey, (lpSubKey ? lpSubKey : L"")); - return ERROR_SUCCESS; -} - -LONG WINAPI -RegOpenKeyW( - IN HKEY hKey, - IN LPCWSTR lpSubKey, - OUT PHKEY phkResult) -{ - return RegpOpenOrCreateKey(hKey, lpSubKey, FALSE, FALSE, phkResult); + return RegpCreateOrOpenKey(hKey, lpSubKey, TRUE, FALSE, phkResult); } LONG WINAPI @@ -525,13 +506,32 @@ RegCreateKeyExW( OUT PHKEY phkResult, OUT LPDWORD lpdwDisposition OPTIONAL) { - return RegpOpenOrCreateKey(hKey, + return RegpCreateOrOpenKey(hKey, lpSubKey, TRUE, (dwOptions & REG_OPTION_VOLATILE) != 0, phkResult); } +LONG WINAPI +RegDeleteKeyW( + IN HKEY hKey, + IN LPCWSTR lpSubKey) +{ + DPRINT1("RegDeleteKeyW(0x%p, '%S') is UNIMPLEMENTED!\n", + hKey, (lpSubKey ? lpSubKey : L"")); + return ERROR_SUCCESS; +} + +LONG WINAPI +RegOpenKeyW( + IN HKEY hKey, + IN LPCWSTR lpSubKey, + OUT PHKEY phkResult) +{ + return RegpCreateOrOpenKey(hKey, lpSubKey, FALSE, FALSE, phkResult); +} + LONG WINAPI RegSetValueExW( IN HKEY hKey, @@ -785,9 +785,9 @@ ConnectRegistry( IN PCWSTR Path) { NTSTATUS Status; + LONG rc; PREPARSE_POINT ReparsePoint; PMEMKEY NewKey; - LONG rc; ReparsePoint = (PREPARSE_POINT)malloc(sizeof(*ReparsePoint)); if (!ReparsePoint) @@ -819,7 +819,7 @@ ConnectRegistry( if (!NT_SUCCESS(Status)) DPRINT1("Failed to add security for root key '%S'\n", Path); - /* Create key */ + /* Create the key */ rc = RegCreateKeyExW(RootKey, Path, 0,

1 0

01/09: [CMLIB] Adjust parameter types and annotations. Add diagnostic assertions.
by Hermès Bélusca-Maïto 14 Oct '18

14 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bf8a7d2db000cd54c92f2… commit bf8a7d2db000cd54c92f25ad6b0329659c7bd93f Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Oct 14 00:16:04 2018 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Oct 14 15:59:31 2018 +0200 [CMLIB] Adjust parameter types and annotations. Add diagnostic assertions. --- sdk/lib/cmlib/cmlib.h | 6 +++--- sdk/lib/cmlib/cmname.c | 2 +- sdk/lib/cmlib/cmvalue.c | 9 ++++++--- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/sdk/lib/cmlib/cmlib.h b/sdk/lib/cmlib/cmlib.h index 46676a2122..b9431c750b 100644 --- a/sdk/lib/cmlib/cmlib.h +++ b/sdk/lib/cmlib/cmlib.h @@ -595,7 +595,7 @@ CmpFindNameInList( IN PHHIVE Hive, IN PCHILD_LIST ChildList, IN PUNICODE_STRING Name, - OUT PULONG ChildIndex, + OUT PULONG ChildIndex OPTIONAL, OUT PHCELL_INDEX CellIndex ); @@ -625,7 +625,7 @@ CmpSetValueDataNew( IN PHHIVE Hive, IN PVOID Data, IN ULONG DataSize, - IN ULONG StorageType, + IN HSTORAGE_TYPE StorageType, IN HCELL_INDEX ValueCell, OUT PHCELL_INDEX DataCell ); @@ -636,7 +636,7 @@ CmpAddValueToList( IN PHHIVE Hive, IN HCELL_INDEX ValueCell, IN ULONG Index, - IN ULONG Type, + IN HSTORAGE_TYPE StorageType, IN OUT PCHILD_LIST ChildList ); diff --git a/sdk/lib/cmlib/cmname.c b/sdk/lib/cmlib/cmname.c index 918cbb282d..b12374023c 100644 --- a/sdk/lib/cmlib/cmname.c +++ b/sdk/lib/cmlib/cmname.c @@ -149,7 +149,7 @@ NTAPI CmpFindNameInList(IN PHHIVE Hive, IN PCHILD_LIST ChildList, IN PUNICODE_STRING Name, - OUT PULONG ChildIndex, + OUT PULONG ChildIndex OPTIONAL, OUT PHCELL_INDEX CellIndex) { PCELL_DATA CellData; diff --git a/sdk/lib/cmlib/cmvalue.c b/sdk/lib/cmlib/cmvalue.c index a038c776f3..86344a7707 100644 --- a/sdk/lib/cmlib/cmvalue.c +++ b/sdk/lib/cmlib/cmvalue.c @@ -207,7 +207,7 @@ NTAPI CmpAddValueToList(IN PHHIVE Hive, IN HCELL_INDEX ValueCell, IN ULONG Index, - IN ULONG Type, + IN HSTORAGE_TYPE StorageType, IN OUT PCHILD_LIST ChildList) { HCELL_INDEX ListCell; @@ -223,6 +223,8 @@ CmpAddValueToList(IN PHHIVE Hive, ChildCount++; if (ChildCount > 1) { + ASSERT(ChildList->List != HCELL_NIL); + /* The cell should be dirty at this point */ ASSERT(HvIsCellDirty(Hive, ChildList->List)); @@ -249,7 +251,8 @@ CmpAddValueToList(IN PHHIVE Hive, else { /* This is our first child, so allocate a single cell */ - ListCell = HvAllocateCell(Hive, sizeof(HCELL_INDEX), Type, HCELL_NIL); + ASSERT(ChildList->List == HCELL_NIL); + ListCell = HvAllocateCell(Hive, sizeof(HCELL_INDEX), StorageType, HCELL_NIL); } /* Fail if we couldn't get a cell */ @@ -286,7 +289,7 @@ NTAPI CmpSetValueDataNew(IN PHHIVE Hive, IN PVOID Data, IN ULONG DataSize, - IN ULONG StorageType, + IN HSTORAGE_TYPE StorageType, IN HCELL_INDEX ValueCell, OUT PHCELL_INDEX DataCell) {

1 0

01/01: [FONT][WIN32SS] Use ExFreePoolWithTag instead of ExFreePool (#941)
by Katayama Hirofumi MZ 14 Oct '18

14 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=801b71b9bfbcb23daf59d… commit 801b71b9bfbcb23daf59da30f2e399193bd6ce28 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Sun Oct 14 16:47:52 2018 +0900 Commit: Thomas Faber <18138474+ThFabba(a)users.noreply.github.com> CommitDate: Sun Oct 14 09:47:52 2018 +0200 [FONT][WIN32SS] Use ExFreePoolWithTag instead of ExFreePool (#941) --- win32ss/gdi/ntgdi/freetype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win32ss/gdi/ntgdi/freetype.c b/win32ss/gdi/ntgdi/freetype.c index 7bacfb66ec..10fb8655d7 100644 --- a/win32ss/gdi/ntgdi/freetype.c +++ b/win32ss/gdi/ntgdi/freetype.c @@ -5150,7 +5150,7 @@ IntGdiGetFontResourceInfo( /* Free the buffers */ ExFreePoolWithTag(NameInfo1, TAG_FINF); - ExFreePool(NameInfo2); + ExFreePoolWithTag(NameInfo2, TAG_FINF); if (Count == 0 && dwType != 5) {

1 0

02/02: [NTOSKRNL] Add the CcPinMappedDataCount counter
by Pierre Schweitzer 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3d13a464f7b12534f3200… commit 3d13a464f7b12534f32008f8c6eb3509cc1e456b Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Oct 13 22:50:49 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Oct 13 22:51:44 2018 +0200 [NTOSKRNL] Add the CcPinMappedDataCount counter --- ntoskrnl/cc/pin.c | 4 ++++ ntoskrnl/ex/sysinfo.c | 2 +- ntoskrnl/include/internal/cc.h | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/cc/pin.c b/ntoskrnl/cc/pin.c index 37eca96de1..4f0e4f5a82 100644 --- a/ntoskrnl/cc/pin.c +++ b/ntoskrnl/cc/pin.c @@ -23,11 +23,13 @@ extern NPAGED_LOOKASIDE_LIST iBcbLookasideList; * - Number of calls to CcMapData that couldn't wait * - Number of calls to CcPinRead that could wait * - Number of calls to CcPinRead that couldn't wait + * - Number of calls to CcPinMappedDataCount */ ULONG CcMapDataWait = 0; ULONG CcMapDataNoWait = 0; ULONG CcPinReadWait = 0; ULONG CcPinReadNoWait = 0; +ULONG CcPinMappedDataCount = 0; /* FUNCTIONS *****************************************************************/ @@ -429,6 +431,8 @@ CcPinMappedData ( iBcb = *Bcb; + ++CcPinMappedDataCount; + Result = CcpPinData(SharedCacheMap, FileOffset, Length, Flags, Bcb, &Buffer); if (Result) { diff --git a/ntoskrnl/ex/sysinfo.c b/ntoskrnl/ex/sysinfo.c index ab8481b328..09b9a6359c 100644 --- a/ntoskrnl/ex/sysinfo.c +++ b/ntoskrnl/ex/sysinfo.c @@ -767,7 +767,7 @@ QSI_DEF(SystemPerformanceInformation) Spi->CcMapDataNoWaitMiss = 0; /* FIXME */ Spi->CcMapDataWaitMiss = 0; /* FIXME */ - Spi->CcPinMappedDataCount = 0; /* FIXME */ + Spi->CcPinMappedDataCount = CcPinMappedDataCount; Spi->CcPinReadNoWait = CcPinReadNoWait; Spi->CcPinReadWait = CcPinReadWait; Spi->CcPinReadNoWaitMiss = 0; /* FIXME */ diff --git a/ntoskrnl/include/internal/cc.h b/ntoskrnl/include/internal/cc.h index 16dd1f67f0..8a5fb73838 100644 --- a/ntoskrnl/include/internal/cc.h +++ b/ntoskrnl/include/internal/cc.h @@ -62,6 +62,7 @@ extern ULONG CcMapDataWait; extern ULONG CcMapDataNoWait; extern ULONG CcPinReadWait; extern ULONG CcPinReadNoWait; +extern ULONG CcPinMappedDataCount; extern ULONG CcDataPages; extern ULONG CcDataFlushes;

1 0

01/02: [NTOSKRNL] Rewrite the way we create BCB for pinning
by Pierre Schweitzer 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1afcbbd12539577fb7bb6… commit 1afcbbd12539577fb7bb6df61378d8dd12a4f727 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Oct 13 22:46:10 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Oct 13 22:51:44 2018 +0200 [NTOSKRNL] Rewrite the way we create BCB for pinning We won't reuse a BCB created for mapping, we will now have our own dedicated BCB. This allows having a bit more cleaner implementation of CcPinMappedData() --- ntoskrnl/cc/pin.c | 306 ++++++++++++++++++++++++++++++------------------------ 1 file changed, 170 insertions(+), 136 deletions(-) diff --git a/ntoskrnl/cc/pin.c b/ntoskrnl/cc/pin.c index b3906a9321..37eca96de1 100644 --- a/ntoskrnl/cc/pin.c +++ b/ntoskrnl/cc/pin.c @@ -73,17 +73,14 @@ CcpMapData( IN PLARGE_INTEGER FileOffset, IN ULONG Length, IN ULONG Flags, - IN BOOLEAN ToPin, - OUT PVOID *pBcb, + OUT PROS_VACB *pVacb, OUT PVOID *pBuffer) { LONGLONG ReadOffset; BOOLEAN Valid; PROS_VACB Vacb; NTSTATUS Status; - PINTERNAL_BCB iBcb, DupBcb; LONGLONG ROffset; - KIRQL OldIrql; ReadOffset = FileOffset->QuadPart; @@ -146,14 +143,30 @@ CcpMapData( } *pBuffer = (PUCHAR)*pBuffer + ReadOffset % VACB_MAPPING_GRANULARITY; + *pVacb = Vacb; + + return TRUE; +} + +static +PVOID +CcpGetAppropriateBcb( + IN PROS_SHARED_CACHE_MAP SharedCacheMap, + IN PROS_VACB Vacb, + IN PLARGE_INTEGER FileOffset, + IN ULONG Length, + IN ULONG PinFlags, + IN BOOLEAN ToPin) +{ + KIRQL OldIrql; + BOOLEAN Result; + PINTERNAL_BCB iBcb, DupBcb; + iBcb = ExAllocateFromNPagedLookasideList(&iBcbLookasideList); if (iBcb == NULL) { CcRosReleaseVacb(SharedCacheMap, Vacb, TRUE, FALSE, FALSE); - CCTRACE(CC_API_DEBUG, "FileObject=%p FileOffset=%p Length=%lu Flags=0x%lx -> FALSE\n", - SharedCacheMap->FileObject, FileOffset, Length, Flags); - ExRaiseStatus(STATUS_INSUFFICIENT_RESOURCES); - return FALSE; + return NULL; } RtlZeroMemory(iBcb, sizeof(*iBcb)); @@ -166,44 +179,147 @@ CcpMapData( iBcb->PinCount = 0; iBcb->RefCount = 1; ExInitializeResourceLite(&iBcb->Lock); - *pBcb = (PVOID)iBcb; - /* Only insert if we're not to pin data */ - if (!ToPin) + KeAcquireSpinLock(&SharedCacheMap->BcbSpinLock, &OldIrql); + + /* Check if we raced with another BCB creation */ + DupBcb = CcpFindBcb(SharedCacheMap, FileOffset, Length, ToPin); + /* Yes, and we've lost */ + if (DupBcb != NULL) { - KeAcquireSpinLock(&SharedCacheMap->BcbSpinLock, &OldIrql); + Result = TRUE; + + if (ToPin) + { + DupBcb->PinCount++; + + if (BooleanFlagOn(PinFlags, PIN_EXCLUSIVE)) + { + Result = ExAcquireResourceExclusiveLite(&iBcb->Lock, BooleanFlagOn(PinFlags, PIN_WAIT)); + } + else + { + Result = ExAcquireSharedStarveExclusive(&iBcb->Lock, BooleanFlagOn(PinFlags, PIN_WAIT)); + } + + if (!Result) + { + DupBcb->PinCount--; + DupBcb = NULL; + } + } - /* Check if we raced with another BCB creation */ - DupBcb = CcpFindBcb(SharedCacheMap, FileOffset, Length, FALSE); - /* Yes, and we've lost */ - if (DupBcb != NULL) + if (Result) { /* We'll return that BCB */ ++DupBcb->RefCount; + } - /* Delete the loser */ - CcRosReleaseVacb(SharedCacheMap, Vacb, TRUE, FALSE, FALSE); - ExDeleteResourceLite(&iBcb->Lock); - ExFreeToNPagedLookasideList(&iBcbLookasideList, iBcb); + /* Delete the loser */ + CcRosReleaseVacb(SharedCacheMap, Vacb, TRUE, FALSE, FALSE); + ExDeleteResourceLite(&iBcb->Lock); + ExFreeToNPagedLookasideList(&iBcbLookasideList, iBcb); - /* Return the winner - no need to update buffer address, it's - * relative to the VACB, which is unchanged. - */ - *pBcb = DupBcb; + /* Return the winner - no need to update buffer address, it's + * relative to the VACB, which is unchanged. + */ + iBcb = DupBcb; + } + /* Nope, insert ourselves */ + else + { + if (ToPin) + { + iBcb->PinCount++; + + if (BooleanFlagOn(PinFlags, PIN_EXCLUSIVE)) + { + Result = ExAcquireResourceExclusiveLite(&iBcb->Lock, BooleanFlagOn(PinFlags, PIN_WAIT)); + } + else + { + Result = ExAcquireSharedStarveExclusive(&iBcb->Lock, BooleanFlagOn(PinFlags, PIN_WAIT)); + } + + ASSERT(Result); + } + + InsertTailList(&SharedCacheMap->BcbList, &iBcb->BcbEntry); + } + KeReleaseSpinLock(&SharedCacheMap->BcbSpinLock, OldIrql); + + return iBcb; +} + +static +BOOLEAN +CcpPinData( + IN PROS_SHARED_CACHE_MAP SharedCacheMap, + IN PLARGE_INTEGER FileOffset, + IN ULONG Length, + IN ULONG Flags, + OUT PVOID * Bcb, + OUT PVOID * Buffer) +{ + PINTERNAL_BCB NewBcb; + BOOLEAN Result; + PROS_VACB Vacb; + KIRQL OldIrql; + + KeAcquireSpinLock(&SharedCacheMap->BcbSpinLock, &OldIrql); + NewBcb = CcpFindBcb(SharedCacheMap, FileOffset, Length, TRUE); + KeReleaseSpinLock(&SharedCacheMap->BcbSpinLock, OldIrql); + + if (NewBcb != NULL) + { + NewBcb->PinCount++; + + if (BooleanFlagOn(Flags, PIN_EXCLUSIVE)) + { + Result = ExAcquireResourceExclusiveLite(&NewBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); } - /* Nope, insert ourselves */ else { - InsertTailList(&SharedCacheMap->BcbList, &iBcb->BcbEntry); + Result = ExAcquireSharedStarveExclusive(&NewBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); } - KeReleaseSpinLock(&SharedCacheMap->BcbSpinLock, OldIrql); + + if (!Result) + { + NewBcb->PinCount--; + } + else + { + NewBcb->RefCount++; + *Bcb = NewBcb; + *Buffer = (PUCHAR)NewBcb->Vacb->BaseAddress + FileOffset->QuadPart % VACB_MAPPING_GRANULARITY; + } + + return Result; } else { - InitializeListHead(&iBcb->BcbEntry); + if (BooleanFlagOn(Flags, PIN_IF_BCB)) + { + return FALSE; + } + + Result = CcpMapData(SharedCacheMap, FileOffset, Length, Flags, &Vacb, Buffer); + if (Result) + { + NewBcb = CcpGetAppropriateBcb(SharedCacheMap, Vacb, FileOffset, Length, Flags, TRUE); + if (NewBcb == NULL) + { + CcRosReleaseVacb(SharedCacheMap, Vacb, TRUE, FALSE, FALSE); + Result = FALSE; + } + else + { + *Bcb = NewBcb; + } + } } - return TRUE; + return Result; } /* @@ -222,6 +338,7 @@ CcMapData ( BOOLEAN Ret; KIRQL OldIrql; PINTERNAL_BCB iBcb; + PROS_VACB Vacb; PROS_SHARED_CACHE_MAP SharedCacheMap; DPRINT("CcMapData(FileObject 0x%p, FileOffset %I64x, Length %lu, Flags 0x%lx," @@ -250,7 +367,20 @@ CcMapData ( if (iBcb == NULL) { - Ret = CcpMapData(SharedCacheMap, FileOffset, Length, Flags, FALSE, pBcb, pBuffer); + Ret = CcpMapData(SharedCacheMap, FileOffset, Length, Flags, &Vacb, pBuffer); + if (Ret) + { + iBcb = CcpGetAppropriateBcb(SharedCacheMap, Vacb, FileOffset, Length, 0, FALSE); + if (iBcb == NULL) + { + CcRosReleaseVacb(SharedCacheMap, Vacb, TRUE, FALSE, FALSE); + Ret = FALSE; + } + else + { + *pBcb = iBcb; + } + } } else { @@ -278,6 +408,7 @@ CcPinMappedData ( OUT PVOID * Bcb) { BOOLEAN Result; + PVOID Buffer; PINTERNAL_BCB iBcb; PROS_SHARED_CACHE_MAP SharedCacheMap; @@ -297,22 +428,11 @@ CcPinMappedData ( } iBcb = *Bcb; - ASSERT(iBcb->PinCount == 0); - - iBcb->PinCount++; - - if (BooleanFlagOn(Flags, PIN_EXCLUSIVE)) - { - Result = ExAcquireResourceExclusiveLite(&iBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); - } - else - { - Result = ExAcquireSharedStarveExclusive(&iBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); - } - if (!Result) + Result = CcpPinData(SharedCacheMap, FileOffset, Length, Flags, Bcb, &Buffer); + if (Result) { - iBcb->PinCount--; + CcUnpinData(iBcb); } return Result; @@ -331,9 +451,6 @@ CcPinRead ( OUT PVOID * Bcb, OUT PVOID * Buffer) { - KIRQL OldIrql; - BOOLEAN Result; - PINTERNAL_BCB iBcb; PROS_SHARED_CACHE_MAP SharedCacheMap; CCTRACE(CC_API_DEBUG, "FileOffset=%p FileOffset=%p Length=%lu Flags=0x%lx\n", @@ -345,6 +462,11 @@ CcPinRead ( SharedCacheMap = FileObject->SectionObjectPointer->SharedCacheMap; ASSERT(SharedCacheMap); + if (!SharedCacheMap->PinAccess) + { + DPRINT1("FIXME: Pinning a file with no pin access!\n"); + return FALSE; + } if (Flags & PIN_WAIT) { @@ -355,95 +477,7 @@ CcPinRead ( ++CcPinReadNoWait; } - KeAcquireSpinLock(&SharedCacheMap->BcbSpinLock, &OldIrql); - iBcb = CcpFindBcb(SharedCacheMap, FileOffset, Length, TRUE); - KeReleaseSpinLock(&SharedCacheMap->BcbSpinLock, OldIrql); - - if (iBcb == NULL) - { - /* We failed to find an already existing BCB */ - if (BooleanFlagOn(Flags, PIN_IF_BCB)) - { - return FALSE; - } - - /* Map first */ - if (!CcpMapData(SharedCacheMap, FileOffset, Length, Flags, TRUE, Bcb, Buffer)) - { - return FALSE; - } - - /* Pin then */ - if (!CcPinMappedData(FileObject, FileOffset, Length, Flags, Bcb)) - { - CcUnpinData(*Bcb); - return FALSE; - } - - /* Did we race for the BCB creation? */ - KeAcquireSpinLock(&SharedCacheMap->BcbSpinLock, &OldIrql); - iBcb = CcpFindBcb(SharedCacheMap, FileOffset, Length, TRUE); - if (iBcb != NULL) - { - KeReleaseSpinLock(&SharedCacheMap->BcbSpinLock, OldIrql); - - /* Free our now unused BCB */ - CcUnpinData(*Bcb); - - /* Lock the found BCB and return it */ - if (BooleanFlagOn(Flags, PIN_EXCLUSIVE)) - { - Result = ExAcquireResourceExclusiveLite(&iBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); - } - else - { - Result = ExAcquireSharedStarveExclusive(&iBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); - } - - if (!Result) - { - return FALSE; - } - - ++iBcb->PinCount; - ++iBcb->RefCount; - - *Bcb = iBcb; - } - else - { - iBcb = *Bcb; - - /* Insert ourselves in the linked list */ - InsertTailList(&SharedCacheMap->BcbList, &iBcb->BcbEntry); - KeReleaseSpinLock(&SharedCacheMap->BcbSpinLock, OldIrql); - } - } - /* We found a BCB, lock it and return it */ - else - { - if (BooleanFlagOn(Flags, PIN_EXCLUSIVE)) - { - Result = ExAcquireResourceExclusiveLite(&iBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); - } - else - { - Result = ExAcquireSharedStarveExclusive(&iBcb->Lock, BooleanFlagOn(Flags, PIN_WAIT)); - } - - if (!Result) - { - return FALSE; - } - - ++iBcb->PinCount; - ++iBcb->RefCount; - - *Bcb = iBcb; - *Buffer = (PUCHAR)iBcb->Vacb->BaseAddress + FileOffset->QuadPart % VACB_MAPPING_GRANULARITY; - } - - return TRUE; + return CcpPinData(SharedCacheMap, FileOffset, Length, Flags, Bcb, Buffer); } /*

1 0

01/01: [CRT] spawn: define a unicode environment when needed CORE-9182
by Mark Jansen 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2d47c3be2987662333573… commit 2d47c3be2987662333573b65051f498f92d90dc3 Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Sat Oct 13 00:20:58 2018 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Sat Oct 13 20:30:07 2018 +0200 [CRT] spawn: define a unicode environment when needed CORE-9182 --- sdk/lib/crt/process/process.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/sdk/lib/crt/process/process.c b/sdk/lib/crt/process/process.c index f607c2eed3..ef6ad4d8fa 100644 --- a/sdk/lib/crt/process/process.c +++ b/sdk/lib/crt/process/process.c @@ -203,6 +203,7 @@ do_spawnT(int mode, const _TCHAR* cmdname, const _TCHAR* args, const _TCHAR* env BOOL bResult; DWORD dwExitCode; DWORD dwError; + DWORD dwFlags = 0; TRACE(MK_STR(do_spawnT)"(%i,'%"sT"','%"sT"','%"sT"')",mode,cmdname,args,envp); @@ -286,12 +287,20 @@ do_spawnT(int mode, const _TCHAR* cmdname, const _TCHAR* args, const _TCHAR* env create_io_inherit_block(&StartupInfo.cbReserved2, &StartupInfo.lpReserved2); + if (mode == _P_DETACH) + { + dwFlags |= DETACHED_PROCESS; + } +#ifdef _UNICODE + dwFlags |= CREATE_UNICODE_ENVIRONMENT; +#endif + bResult = CreateProcess((_TCHAR *)cmdname, (_TCHAR *)args, NULL, NULL, TRUE, - mode == _P_DETACH ? DETACHED_PROCESS : 0, + dwFlags, (LPVOID)envp, NULL, &StartupInfo,

1 0

01/01: [SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view. CORE-14976
by Mark Jansen 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=80c53821c9616538b0a8a… commit 80c53821c9616538b0a8a4a8d29bc03aa13afce4 Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Tue Oct 9 20:57:23 2018 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Sat Oct 13 20:28:49 2018 +0200 [SHELL32] CDefView: Query SFVM_DEFVIEWMODE before creating the list view. CORE-14976 --- dll/win32/shell32/CDefView.cpp | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/dll/win32/shell32/CDefView.cpp b/dll/win32/shell32/CDefView.cpp index 32f7e153e7..9e67b441df 100644 --- a/dll/win32/shell32/CDefView.cpp +++ b/dll/win32/shell32/CDefView.cpp @@ -114,7 +114,7 @@ class CDefView : private: HRESULT _MergeToolbar(); BOOL _Sort(); - VOID _DoFolderViewCB(UINT uMsg, WPARAM wParam, LPARAM lParam); + HRESULT _DoFolderViewCB(UINT uMsg, WPARAM wParam, LPARAM lParam); public: CDefView(); @@ -520,7 +520,9 @@ void CDefView::SetStyle(DWORD dwAdd, DWORD dwRemove) */ BOOL CDefView::CreateList() { + HRESULT hr; DWORD dwStyle, dwExStyle; + UINT ViewMode; TRACE("%p\n", this); @@ -533,6 +535,16 @@ BOOL CDefView::CreateList() else dwStyle |= LVS_ALIGNTOP | LVS_SHOWSELALWAYS; + ViewMode = m_FolderSettings.ViewMode; + hr = _DoFolderViewCB(SFVM_DEFVIEWMODE, NULL, (LPARAM)&ViewMode); + if (SUCCEEDED(hr)) + { + if (ViewMode >= FVM_FIRST && ViewMode <= FVM_LAST) + m_FolderSettings.ViewMode = ViewMode; + else + ERR("Ignoring invalid ViewMode from SFVM_DEFVIEWMODE: %u (was: %u)\n", ViewMode, m_FolderSettings.ViewMode); + } + switch (m_FolderSettings.ViewMode) { case FVM_ICON: @@ -3245,12 +3257,13 @@ HRESULT CDefView::_MergeToolbar() return S_OK; } -VOID CDefView::_DoFolderViewCB(UINT uMsg, WPARAM wParam, LPARAM lParam) +HRESULT CDefView::_DoFolderViewCB(UINT uMsg, WPARAM wParam, LPARAM lParam) { if (m_pShellFolderViewCB) { - m_pShellFolderViewCB->MessageSFVCB(uMsg, wParam, lParam); + return m_pShellFolderViewCB->MessageSFVCB(uMsg, wParam, lParam); } + return E_NOINTERFACE; } HRESULT CDefView_CreateInstance(IShellFolder *pFolder, REFIID riid, LPVOID * ppvOut)

1 0

01/01: [FASTFAT] Don't mess my debug log when partition SysType is printed! (when invalid chars are printed)
by Hermès Bélusca-Maïto 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8c0c90112e8f9a289ecc1… commit 8c0c90112e8f9a289ecc10a07a1042be2f700db5 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sat Oct 13 19:57:24 2018 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sat Oct 13 19:57:24 2018 +0200 [FASTFAT] Don't mess my debug log when partition SysType is printed! (when invalid chars are printed) --- drivers/filesystems/fastfat/fsctl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/filesystems/fastfat/fsctl.c b/drivers/filesystems/fastfat/fsctl.c index b7e576d2d8..6523487368 100644 --- a/drivers/filesystems/fastfat/fsctl.c +++ b/drivers/filesystems/fastfat/fsctl.c @@ -280,8 +280,14 @@ VfatHasFileSystem( BootFatX->SysType[2] != 'T' || BootFatX->SysType[3] != 'X') { - DPRINT1("SysType %c%c%c%c\n", BootFatX->SysType[0], BootFatX->SysType[1], BootFatX->SysType[2], BootFatX->SysType[3]); - *RecognizedFS=FALSE; + DPRINT1("SysType %02X%02X%02X%02X (%c%c%c%c)\n", + BootFatX->SysType[0], BootFatX->SysType[1], BootFatX->SysType[2], BootFatX->SysType[3], + isprint(BootFatX->SysType[0]) ? BootFatX->SysType[0] : '.', + isprint(BootFatX->SysType[1]) ? BootFatX->SysType[1] : '.', + isprint(BootFatX->SysType[2]) ? BootFatX->SysType[2] : '.', + isprint(BootFatX->SysType[3]) ? BootFatX->SysType[3] : '.'); + + *RecognizedFS = FALSE; } if (*RecognizedFS &&

1 0

01/01: [RTL] Make a RtlQueryEnvironmentVariable_U() DPRINT a little bit more useful.
by Hermès Bélusca-Maïto 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=47d539e6e00bd04d21af5… commit 47d539e6e00bd04d21af5ff42f0815efc423facd Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sat Oct 13 19:44:13 2018 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sat Oct 13 19:44:13 2018 +0200 [RTL] Make a RtlQueryEnvironmentVariable_U() DPRINT a little bit more useful. --- sdk/lib/rtl/path.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/lib/rtl/path.c b/sdk/lib/rtl/path.c index b52b24cd8b..7639424d0a 100644 --- a/sdk/lib/rtl/path.c +++ b/sdk/lib/rtl/path.c @@ -681,7 +681,7 @@ RtlGetFullPathName_Ustr( goto Quit; default: - DPRINT1("RtlQueryEnvironmentVariable_U returned 0x%08lx\n", Status); + DPRINT1("RtlQueryEnvironmentVariable_U(\"%wZ\") returned 0x%08lx\n", &EnvVarName, Status); EnvVarNameBuffer[0] = NewDrive; EnvVarNameBuffer[1] = L':';

1 0

01/01: [KMTESTS:CC] Add more tests for CcPinMappedData()
by Pierre Schweitzer 13 Oct '18

13 Oct '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f3ea47d94da0f1c2a1559… commit f3ea47d94da0f1c2a1559a0facb61e9726907bab Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Oct 13 19:24:07 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Oct 13 19:24:29 2018 +0200 [KMTESTS:CC] Add more tests for CcPinMappedData() --- .../rostests/kmtests/ntos_cc/CcPinMappedData_drv.c | 81 ++++++++++++++++++++++ .../kmtests/ntos_cc/CcPinMappedData_user.c | 2 +- 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/modules/rostests/kmtests/ntos_cc/CcPinMappedData_drv.c b/modules/rostests/kmtests/ntos_cc/CcPinMappedData_drv.c index 1a41bf144f..79bbf8168d 100644 --- a/modules/rostests/kmtests/ntos_cc/CcPinMappedData_drv.c +++ b/modules/rostests/kmtests/ntos_cc/CcPinMappedData_drv.c @@ -144,6 +144,57 @@ MapAndLockUserBuffer( return MmGetSystemAddressForMdlSafe(Irp->MdlAddress, NormalPagePriority); } +static +VOID +NTAPI +PinInAnotherThread(IN PVOID Context) +{ + BOOLEAN Ret; + PULONG Buffer; + PVOID Bcb, PinBcb; + LARGE_INTEGER Offset; + PTEST_CONTEXT TestContext; + + ok(TestFileObject != NULL, "Called in invalid context!\n"); + ok_eq_ulong(TestTestId, 4); + + TestContext = Context; + ok(TestContext != NULL, "Called in invalid context!\n"); + ok(TestContext->Bcb != NULL, "Called in invalid context!\n"); + ok(TestContext->Buffer != NULL, "Called in invalid context!\n"); + ok(TestContext->Length != 0, "Called in invalid context!\n"); + + Ret = FALSE; + Offset.QuadPart = 0; + + KmtStartSeh(); + Ret = CcMapData(TestFileObject, &Offset, TestContext->Length, MAP_WAIT, &Bcb, (PVOID *)&Buffer); + KmtEndSeh(STATUS_SUCCESS); + + if (!skip(Ret == TRUE, "CcMapData failed\n")) + { + ok(Bcb != TestContext->Bcb, "Returned same BCB!\n"); + ok_eq_pointer(Buffer, TestContext->Buffer); + + Ret = FALSE; + PinBcb = Bcb; + + KmtStartSeh(); + Ret = CcPinMappedData(TestFileObject, &Offset, FileSizes.FileSize.QuadPart - Offset.QuadPart, 0, &PinBcb); + KmtEndSeh(STATUS_SUCCESS); + + if (!skip(Ret == TRUE, "CcPinMappedData failed\n")) + { + ok(Bcb != PinBcb, "Returned same BCB!\n"); + ok_eq_pointer(PinBcb, TestContext->Bcb); + + Bcb = PinBcb; + } + + CcUnpinData(Bcb); + } +} + static VOID NTAPI @@ -383,6 +434,36 @@ PerformTest( CcUnpinData(Bcb); } } + else if (TestId == 4) + { + PTEST_CONTEXT TestContext; + + TestContext = ExAllocatePool(NonPagedPool, sizeof(TEST_CONTEXT)); + if (!skip(TestContext != NULL, "ExAllocatePool failed\n")) + { + Ret = FALSE; + Offset.QuadPart = 0; + KmtStartSeh(); + Ret = CcPinRead(TestFileObject, &Offset, FileSizes.FileSize.QuadPart - Offset.QuadPart, PIN_WAIT, &TestContext->Bcb, (PVOID *)&TestContext->Buffer); + KmtEndSeh(STATUS_SUCCESS); + + if (!skip(Ret == TRUE, "CcPinRead failed\n")) + { + PKTHREAD ThreadHandle; + + ok(*(PUSHORT)TestContext->Bcb == 0x2FD, "Not a BCB: %x\n", *(PUSHORT)TestContext->Bcb); + ok_eq_ulong(TestContext->Buffer[0x3000 / sizeof(ULONG)], 0xDEADBABE); + + TestContext->Length = FileSizes.FileSize.QuadPart - Offset.QuadPart; + ThreadHandle = KmtStartThread(PinInAnotherThread, TestContext); + KmtFinishThread(ThreadHandle, NULL); + + CcUnpinData(TestContext->Bcb); + } + + ExFreePool(TestContext); + } + } } } } diff --git a/modules/rostests/kmtests/ntos_cc/CcPinMappedData_user.c b/modules/rostests/kmtests/ntos_cc/CcPinMappedData_user.c index 21fe904bb9..e0fdcfda15 100644 --- a/modules/rostests/kmtests/ntos_cc/CcPinMappedData_user.c +++ b/modules/rostests/kmtests/ntos_cc/CcPinMappedData_user.c @@ -19,7 +19,7 @@ START_TEST(CcPinMappedData) KmtOpenDriver(); /* 1 basic test */ - for (TestId = 0; TestId < 4; ++TestId) + for (TestId = 0; TestId < 5; ++TestId) { Ret = KmtSendUlongToDriver(IOCTL_START_TEST, TestId); ok(Ret == ERROR_SUCCESS, "KmtSendUlongToDriver failed: %lx\n", Ret);

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs