Ros-diffs

ros-diffs@reactos.org

81390 discussions

[tfaber] 75194: [USBPORT] - Fix setting the direction in USBPORT_OpenPipe. Patch by Vadim Galyant.
by tfaber＠svn.reactos.org 25 Jun '17

25 Jun '17

Author: tfaber Date: Sun Jun 25 08:17:33 2017 New Revision: 75194 URL: http://svn.reactos.org/svn/reactos?rev=75194&view=rev Log: [USBPORT] - Fix setting the direction in USBPORT_OpenPipe. Patch by Vadim Galyant. Modified: trunk/reactos/drivers/usb/usbport/endpoint.c Modified: trunk/reactos/drivers/usb/usbport/endpoint.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbport/endpoi… ============================================================================== --- trunk/reactos/drivers/usb/usbport/endpoint.c [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbport/endpoint.c [iso-8859-1] Sun Jun 25 08:17:33 2017 @@ -796,7 +796,7 @@ goto ExitWithError; } - Direction = USB_ENDPOINT_DIRECTION_IN(EndpointDescriptor->bEndpointAddress); + Direction = USB_ENDPOINT_DIRECTION_OUT(EndpointDescriptor->bEndpointAddress); EndpointProperties->Direction = Direction; if (DeviceHandle->IsRootHub)

1 0

[tthompson] 75193: [NTFS] - Fix creation of files with long filenames.
by tthompson＠svn.reactos.org 25 Jun '17

25 Jun '17

Author: tthompson Date: Sun Jun 25 04:29:04 2017 New Revision: 75193 URL: http://svn.reactos.org/svn/reactos?rev=75193&view=rev Log: [NTFS] - Fix creation of files with long filenames. Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c [iso-8859-1] Sun Jun 25 04:29:04 2017 @@ -220,9 +220,15 @@ DPRINT1("FileNameAttribute->DirectoryFileReferenceNumber: 0x%016I64x\n", FileNameAttribute->DirectoryFileReferenceNumber); FileNameAttribute->NameLength = FilenameNoPath.Length / sizeof(WCHAR); - // TODO: Get proper nametype, add DOS links as needed - FileNameAttribute->NameType = NTFS_FILE_NAME_WIN32_AND_DOS; RtlCopyMemory(FileNameAttribute->Name, FilenameNoPath.Buffer, FilenameNoPath.Length); + + // For now, we're emulating the way Windows behaves when 8.3 name generation is disabled + // TODO: add DOS Filename as needed + if (RtlIsNameLegalDOS8Dot3(&FilenameNoPath, NULL, NULL)) + FileNameAttribute->NameType = NTFS_FILE_NAME_WIN32_AND_DOS; + else + FileNameAttribute->NameType = NTFS_FILE_NAME_POSIX; + FileRecord->LinkCount++; AttributeAddress->Length = ResidentHeaderLength +

1 0

[tthompson] 75192: [NTFS] - In the NtfsAddFilenameToDirectory() function, rename DirectoryContext parameter to the more descriptive, and accurate, IndexRootContext (to simplify the next commit).
by tthompson＠svn.reactos.org 25 Jun '17

25 Jun '17

Author: tthompson Date: Sun Jun 25 02:56:40 2017 New Revision: 75192 URL: http://svn.reactos.org/svn/reactos?rev=75192&view=rev Log: [NTFS] - In the NtfsAddFilenameToDirectory() function, rename DirectoryContext parameter to the more descriptive, and accurate, IndexRootContext (to simplify the next commit). Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/dirctl.c Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/dirctl.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/dirctl.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/dirctl.c [iso-8859-1] Sun Jun 25 02:56:40 2017 @@ -72,7 +72,7 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_RECORD_HEADER ParentFileRecord; - PNTFS_ATTR_CONTEXT DirectoryContext; + PNTFS_ATTR_CONTEXT IndexRootContext; PINDEX_ROOT_ATTRIBUTE I30IndexRoot; ULONG IndexRootOffset; ULONGLONG I30IndexRootLength; @@ -112,7 +112,7 @@ AttributeIndexRoot, L"$I30", 4, - &DirectoryContext, + &IndexRootContext, &IndexRootOffset); if (!NT_SUCCESS(Status)) { @@ -122,23 +122,23 @@ return Status; } - I30IndexRootLength = AttributeDataLength(&DirectoryContext->Record); + I30IndexRootLength = AttributeDataLength(&IndexRootContext->Record); // Allocate memory for the index root data I30IndexRoot = (PINDEX_ROOT_ATTRIBUTE)ExAllocatePoolWithTag(NonPagedPool, I30IndexRootLength, TAG_NTFS); if (!I30IndexRoot) { DPRINT1("ERROR: Couldn't allocate memory for index root attribute!\n"); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS); } // Read the Index Root - Status = ReadAttribute(DeviceExt, DirectoryContext, 0, (PCHAR)I30IndexRoot, I30IndexRootLength); + Status = ReadAttribute(DeviceExt, IndexRootContext, 0, (PCHAR)I30IndexRoot, I30IndexRootLength); if (!NT_SUCCESS(Status)) { DPRINT1("ERROR: Couln't read index root attribute for Mft index #%I64u\n", DirectoryMftIndex); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(I30IndexRoot, TAG_NTFS); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS); return Status; @@ -149,7 +149,7 @@ if (IndexNodeEntry->Data.Directory.IndexedFile != 0 || IndexNodeEntry->Flags != 2) { DPRINT1("FIXME: File-creation is only supported in empty directories right now! Be patient! :)\n"); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(I30IndexRoot, TAG_NTFS); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS); return STATUS_NOT_IMPLEMENTED; @@ -160,7 +160,7 @@ if (!NewIndexRoot) { DPRINT1("ERROR: Unable to allocate memory for new index root attribute!\n"); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(I30IndexRoot, TAG_NTFS); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS); return STATUS_INSUFFICIENT_RESOURCES; @@ -225,14 +225,14 @@ { DPRINT1("FIXME: For now, only resizing index root at the end of a file record is supported!\n"); ExFreePoolWithTag(NewIndexRoot, TAG_NTFS); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(I30IndexRoot, TAG_NTFS); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS); return STATUS_NOT_IMPLEMENTED; } // Update the length of the attribute in the file record of the parent directory - InternalSetResidentAttributeLength(DirectoryContext, + InternalSetResidentAttributeLength(IndexRootContext, ParentFileRecord, IndexRootOffset, AttributeLength); @@ -249,7 +249,7 @@ // Update the parent directory with the new index root Status = WriteAttribute(DeviceExt, - DirectoryContext, + IndexRootContext, 0, (PUCHAR)NewIndexRoot, AttributeLength, @@ -258,7 +258,7 @@ { DPRINT1("ERROR: Unable to write new index root attribute to parent directory!\n"); ExFreePoolWithTag(NewIndexRoot, TAG_NTFS); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(I30IndexRoot, TAG_NTFS); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS); return Status; @@ -278,7 +278,7 @@ // Cleanup ExFreePoolWithTag(NewIndexRoot, TAG_NTFS); - ReleaseAttributeContext(DirectoryContext); + ReleaseAttributeContext(IndexRootContext); ExFreePoolWithTag(I30IndexRoot, TAG_NTFS); ExFreePoolWithTag(ParentFileRecord, TAG_NTFS);

1 0

[tthompson] 75191: [NTFS] - Fix a mistake with AddFileName() from my last commit. Also, move CaseSensitive parameter before output parameters in the parameter list of several functions.
by tthompson＠svn.reactos.org 25 Jun '17

25 Jun '17

Author: tthompson Date: Sun Jun 25 02:38:15 2017 New Revision: 75191 URL: http://svn.reactos.org/svn/reactos?rev=75191&view=rev Log: [NTFS] - Fix a mistake with AddFileName() from my last commit. Also, move CaseSensitive parameter before output parameters in the parameter list of several functions. Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/create.c branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/fcb.c branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/ntfs.h Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/attrib.c [iso-8859-1] Sun Jun 25 02:38:15 2017 @@ -112,12 +112,12 @@ * Pointer to the FILE_OBJECT which represents the new name. * This parameter is used to determine the filename and parent directory. * -* @param ParentMftIndex -* Pointer to a ULONGLONG which will receive the index of the parent directory. -* * @param CaseSensitive * Boolean indicating if the function should operate in case-sensitive mode. This will be TRUE * if an application opened the file with the FILE_FLAG_POSIX_SEMANTICS flag. +* +* @param ParentMftIndex +* Pointer to a ULONGLONG which will receive the index of the parent directory. * * @return * STATUS_SUCCESS on success. STATUS_NOT_IMPLEMENTED if target address isn't at the end @@ -136,8 +136,8 @@ PNTFS_ATTR_RECORD AttributeAddress, PDEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject, - PULONGLONG ParentMftIndex, - BOOLEAN CaseSensitive) + BOOLEAN CaseSensitive, + PULONGLONG ParentMftIndex) { ULONG ResidentHeaderLength = FIELD_OFFSET(NTFS_ATTR_RECORD, Resident.Reserved) + sizeof(UCHAR); PFILENAME_ATTRIBUTE FileNameAttribute; Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/create.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/create.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/create.c [iso-8859-1] Sun Jun 25 02:38:15 2017 @@ -570,7 +570,10 @@ } // Create the file record on disk - Status = NtfsCreateFileRecord(DeviceExt, FileObject, BooleanFlagOn(IrpContext->Flags, IRPCONTEXT_CANWAIT)); + Status = NtfsCreateFileRecord(DeviceExt, + FileObject, + (Stack->Flags & SL_CASE_SENSITIVE), + BooleanFlagOn(IrpContext->Flags,IRPCONTEXT_CANWAIT)); if (!NT_SUCCESS(Status)) { DPRINT1("ERROR: Couldn't create file record!\n"); @@ -656,6 +659,7 @@ NTSTATUS NtfsCreateFileRecord(PDEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject, + BOOLEAN CaseSensitive, BOOLEAN CanWait) { NTSTATUS Status = STATUS_SUCCESS; @@ -665,7 +669,11 @@ ULONGLONG ParentMftIndex; ULONGLONG FileMftIndex; - DPRINT1("NtfsCreateFileRecord(%p, %p, %s)\n", DeviceExt, FileObject, CanWait ? "TRUE" : "FALSE"); + DPRINT1("NtfsCreateFileRecord(%p, %p, %s, %s)\n", + DeviceExt, + FileObject, + CaseSensitive ? "TRUE" : "FALSE", + CanWait ? "TRUE" : "FALSE"); // allocate memory for file record FileRecord = ExAllocatePoolWithTag(NonPagedPool, @@ -709,7 +717,7 @@ NextAttribute = (PNTFS_ATTR_RECORD)((ULONG_PTR)NextAttribute + (ULONG_PTR)NextAttribute->Length); // Add the $FILE_NAME attribute - AddFileName(FileRecord, NextAttribute, DeviceExt, FileObject, &ParentMftIndex); + AddFileName(FileRecord, NextAttribute, DeviceExt, FileObject, CaseSensitive, &ParentMftIndex); // save a pointer to the filename attribute FilenameAttribute = (PFILENAME_ATTRIBUTE)((ULONG_PTR)NextAttribute + NextAttribute->Resident.ValueOffset); Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/fcb.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/fcb.c [iso-8859-1] Sun Jun 25 02:38:15 2017 @@ -557,7 +557,7 @@ DPRINT1("Will now look for file '%wZ' with stream '%S'\n", &File, Colon); } - Status = NtfsLookupFileAt(Vcb, &File, &FileRecord, &MFTIndex, CurrentDir, CaseSensitive); + Status = NtfsLookupFileAt(Vcb, &File, CaseSensitive, &FileRecord, &MFTIndex, CurrentDir); if (!NT_SUCCESS(Status)) { return Status; Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c [iso-8859-1] Sun Jun 25 02:38:15 2017 @@ -2106,16 +2106,22 @@ NTSTATUS NtfsLookupFileAt(PDEVICE_EXTENSION Vcb, PUNICODE_STRING PathName, + BOOLEAN CaseSensitive, PFILE_RECORD_HEADER *FileRecord, PULONGLONG MFTIndex, - ULONGLONG CurrentMFTIndex, - BOOLEAN CaseSensitive) + ULONGLONG CurrentMFTIndex) { UNICODE_STRING Current, Remaining; NTSTATUS Status; ULONG FirstEntry = 0; - DPRINT("NtfsLookupFileAt(%p, %wZ, %p, %I64x)\n", Vcb, PathName, FileRecord, CurrentMFTIndex); + DPRINT("NtfsLookupFileAt(%p, %wZ, %s, %p, %p, %I64x)\n", + Vcb, + PathName, + CaseSensitive ? "TRUE" : "FALSE", + FileRecord, + MFTIndex, + CurrentMFTIndex); FsRtlDissectName(*PathName, &Current, &Remaining); @@ -2158,11 +2164,11 @@ NTSTATUS NtfsLookupFile(PDEVICE_EXTENSION Vcb, PUNICODE_STRING PathName, + BOOLEAN CaseSensitive, PFILE_RECORD_HEADER *FileRecord, - PULONGLONG MFTIndex, - BOOLEAN CaseSensitive) -{ - return NtfsLookupFileAt(Vcb, PathName, FileRecord, MFTIndex, NTFS_FILE_ROOT, CaseSensitive); + PULONGLONG MFTIndex) +{ + return NtfsLookupFileAt(Vcb, PathName, CaseSensitive, FileRecord, MFTIndex, NTFS_FILE_ROOT); } /** Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/ntfs.h URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/ntfs.h [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/ntfs.h [iso-8859-1] Sun Jun 25 02:38:15 2017 @@ -536,6 +536,7 @@ PNTFS_ATTR_RECORD AttributeAddress, PDEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject, + BOOLEAN CaseSensitive, PULONGLONG ParentMftIndex); NTSTATUS @@ -668,6 +669,7 @@ NTSTATUS NtfsCreateFileRecord(PDEVICE_EXTENSION DeviceExt, PFILE_OBJECT FileObject, + BOOLEAN CaseSensitive, BOOLEAN CanWait); /* devctl.c */ @@ -970,16 +972,17 @@ NTSTATUS NtfsLookupFile(PDEVICE_EXTENSION Vcb, PUNICODE_STRING PathName, + BOOLEAN CaseSensitive, PFILE_RECORD_HEADER *FileRecord, PULONGLONG MFTIndex); NTSTATUS NtfsLookupFileAt(PDEVICE_EXTENSION Vcb, PUNICODE_STRING PathName, + BOOLEAN CaseSensitive, PFILE_RECORD_HEADER *FileRecord, PULONGLONG MFTIndex, - ULONGLONG CurrentMFTIndex, - BOOLEAN CaseSensitive); + ULONGLONG CurrentMFTIndex); VOID NtfsDumpFileRecord(PDEVICE_EXTENSION Vcb,

1 0

[ashaposhnikov] 75190: [RAPPS] * available.cpp: Replaced macros with inline functions. * gui.cpp: Fixed typo.
by ashaposhnikov＠svn.reactos.org 25 Jun '17

25 Jun '17

Author: ashaposhnikov Date: Sun Jun 25 01:09:00 2017 New Revision: 75190 URL: http://svn.reactos.org/svn/reactos?rev=75190&view=rev Log: [RAPPS] * available.cpp: Replaced macros with inline functions. * gui.cpp: Fixed typo. Modified: branches/GSoC_2017/rapps/reactos/base/applications/rapps/available.cpp branches/GSoC_2017/rapps/reactos/base/applications/rapps/gui.cpp Modified: branches/GSoC_2017/rapps/reactos/base/applications/rapps/available.cpp URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2017/rapps/reactos/base/ap… ============================================================================== --- branches/GSoC_2017/rapps/reactos/base/applications/rapps/available.cpp [iso-8859-1] (original) +++ branches/GSoC_2017/rapps/reactos/base/applications/rapps/available.cpp [iso-8859-1] Sun Jun 25 01:09:00 2017 @@ -9,37 +9,52 @@ #include "rapps.h" -#define ADD_TEXT(a, b, c, d) \ - if (b[0] != '\0') \ - { \ - LoadStringW(hInst, a, szText, _countof(szText)); \ - InsertRichEditText(szText, c); \ - InsertRichEditText(b, d); \ - } \ - -#define ADD_TEXT_NEWL(a, b) \ - LoadStringW(hInst, a, szText, _countof(szText)); \ - InsertRichEditText(L"\n", 0); \ - InsertRichEditText(szText, b); \ - InsertRichEditText(L"\n", 0); - -#define GET_STRING1(a, b) \ - if (!ParserGetString(a, b, _countof(b), FindFileData.cFileName)) \ - continue; - -#define GET_STRING2(a, b) \ - if (!ParserGetString(a, b, _countof(b), FindFileData.cFileName)) \ - b[0] = '\0'; + +template<typename T, size_t N, size_t N2> +inline void _AddText(T (&szText)[N], UINT a, T (&b)[N2], DWORD c, DWORD d) { + if (b[0] != '\0') + { + LoadStringW(hInst, a, szText, N); + InsertRichEditText(szText, c); + InsertRichEditText(b, d); + } +} + +template<typename T, size_t N> +inline void _AddTextNewl(T (&szText)[N], UINT a, DWORD b) { + LoadStringW(hInst, a, szText, N); + InsertRichEditText(L"\n", 0); + InsertRichEditText(szText, b); + InsertRichEditText(L"\n", 0); +} + +template<typename T, size_t N, size_t N2> +inline BOOL _GetString(LPCWSTR a, T(&b)[N], T (&cFileName)[N2]) { + return ParserGetString(a, b, N, cFileName); +} + +template<typename T, size_t N, size_t N2> +inline void _GetStringNullFailure(LPCWSTR a, T(&b)[N], T (&cFileName)[N2]) { + if (!_GetString(a, b, cFileName)) { + b[0] = '\0'; + } +} //App is "installed" if the RegName is in the registry -#define APP_INSTALL_CHECK_K(Info, key) \ - (*Info->szRegName && (IsInstalledApplicationEx(Info->szRegName, FALSE, key) \ - || IsInstalledApplicationEx(Info->szRegName, TRUE, key))) +inline bool _AppInstallCheckKey(PAPPLICATION_INFO Info, REGSAM key) { + return *Info->szRegName + && (IsInstalledApplicationEx(Info->szRegName, TRUE, key) + || IsInstalledApplicationEx(Info->szRegName, FALSE, key)); +} + //Check both registry keys in 64bit system //TODO: check system type beforehand to avoid double checks? -#define APP_INSTALL_CHECK(Info) \ - (APP_INSTALL_CHECK_K(Info, KEY_WOW64_32KEY) || APP_INSTALL_CHECK_K(Info, KEY_WOW64_64KEY)) +inline bool _AppInstallCheck(PAPPLICATION_INFO Info) { + return _AppInstallCheckKey(Info, KEY_WOW64_32KEY) + || _AppInstallCheckKey(Info, KEY_WOW64_64KEY); +} + LIST_ENTRY CachedEntriesHead = { &CachedEntriesHead, &CachedEntriesHead }; PLIST_ENTRY pCachedEntry = &CachedEntriesHead; @@ -53,20 +68,20 @@ if (!Info) return FALSE; NewRichEditText(Info->szName, CFE_BOLD); - if (APP_INSTALL_CHECK(Info)) - { - ADD_TEXT_NEWL(IDS_STATUS_INSTALLED, CFE_ITALIC); + if (_AppInstallCheck(Info)) + { + _AddTextNewl(szText, IDS_STATUS_INSTALLED, CFE_ITALIC); } else { - ADD_TEXT_NEWL(IDS_STATUS_NOTINSTALLED, CFE_ITALIC); - } - - ADD_TEXT(IDS_AINFO_VERSION, Info->szVersion, CFE_BOLD, 0); - ADD_TEXT(IDS_AINFO_LICENSE, Info->szLicense, CFE_BOLD, 0); - ADD_TEXT(IDS_AINFO_SIZE, Info->szSize, CFE_BOLD, 0); - ADD_TEXT(IDS_AINFO_URLSITE, Info->szUrlSite, CFE_BOLD, CFE_LINK); - ADD_TEXT(IDS_AINFO_DESCRIPTION, Info->szDesc, CFE_BOLD, 0); - ADD_TEXT(IDS_AINFO_URLDOWNLOAD, Info->szUrlDownload, CFE_BOLD, CFE_LINK); + _AddTextNewl(szText, IDS_STATUS_NOTINSTALLED, CFE_ITALIC); + } + + _AddText(szText, IDS_AINFO_VERSION, Info->szVersion, CFE_BOLD, 0); + _AddText(szText, IDS_AINFO_LICENSE, Info->szLicense, CFE_BOLD, 0); + _AddText(szText, IDS_AINFO_SIZE, Info->szSize, CFE_BOLD, 0); + _AddText(szText, IDS_AINFO_URLSITE, Info->szUrlSite, CFE_BOLD, CFE_LINK); + _AddText(szText, IDS_AINFO_DESCRIPTION, Info->szDesc, CFE_BOLD, 0); + _AddText(szText, IDS_AINFO_URLDOWNLOAD, Info->szUrlDownload, CFE_BOLD, CFE_LINK); return TRUE; } @@ -272,17 +287,20 @@ if (Info->szUrlDownload[0] == 0) { - GET_STRING1(L"Name", Info->szName); - GET_STRING1(L"URLDownload", Info->szUrlDownload); - - GET_STRING2(L"RegName", Info->szRegName); - GET_STRING2(L"Version", Info->szVersion); - GET_STRING2(L"License", Info->szLicense); - GET_STRING2(L"Description", Info->szDesc); - GET_STRING2(L"Size", Info->szSize); - GET_STRING2(L"URLSite", Info->szUrlSite); - GET_STRING2(L"CDPath", Info->szCDPath); - GET_STRING2(L"SHA1", Info->szSHA1); + if (!_GetString(L"Name", Info->szName, FindFileData.cFileName) + || !_GetString(L"URLDownload", Info->szUrlDownload, FindFileData.cFileName)) + { + continue; + } + + _GetStringNullFailure(L"RegName", Info->szRegName, FindFileData.cFileName); + _GetStringNullFailure(L"Version", Info->szVersion, FindFileData.cFileName); + _GetStringNullFailure(L"License", Info->szLicense, FindFileData.cFileName); + _GetStringNullFailure(L"Description", Info->szDesc, FindFileData.cFileName); + _GetStringNullFailure(L"Size", Info->szSize, FindFileData.cFileName); + _GetStringNullFailure(L"URLSite", Info->szUrlSite, FindFileData.cFileName); + _GetStringNullFailure(L"CDPath", Info->szCDPath, FindFileData.cFileName); + _GetStringNullFailure(L"SHA1", Info->szSHA1, FindFileData.cFileName); } if (!lpEnumProc(Info)) Modified: branches/GSoC_2017/rapps/reactos/base/applications/rapps/gui.cpp URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2017/rapps/reactos/base/ap… ============================================================================== --- branches/GSoC_2017/rapps/reactos/base/applications/rapps/gui.cpp [iso-8859-1] (original) +++ branches/GSoC_2017/rapps/reactos/base/applications/rapps/gui.cpp [iso-8859-1] Sun Jun 25 01:09:00 2017 @@ -1182,7 +1182,7 @@ hImageListView = ImageList_Create(LISTVIEW_ICON_SIZE, LISTVIEW_ICON_SIZE, GetSystemColorDepth() | ILC_MASK, - 0, 1000); + 0, 1); hImageListView = ListView_SetImageList(hListView, hImageListView, LVSIL_SMALL); if (hImageListView)

1 0

[sgasiorek] 75189: - update EDD_DIRECTDRAW_LOCAL, EDD_SURFACE and EDD_DIRECTDRAW_GLOBAL structures - initial implementation of DxDdCreateD3DBuffer and DxDdCreateSurfaceObject CORE-4490
by sgasiorek＠svn.reactos.org 24 Jun '17

24 Jun '17

Author: sgasiorek Date: Sat Jun 24 22:24:04 2017 New Revision: 75189 URL: http://svn.reactos.org/svn/reactos?rev=75189&view=rev Log: - update EDD_DIRECTDRAW_LOCAL, EDD_SURFACE and EDD_DIRECTDRAW_GLOBAL structures - initial implementation of DxDdCreateD3DBuffer and DxDdCreateSurfaceObject CORE-4490 Modified: trunk/reactos/sdk/include/reactos/drivers/directx/directxint.h trunk/reactos/win32ss/reactx/dxg/d3d.c trunk/reactos/win32ss/reactx/dxg/ddraw.c trunk/reactos/win32ss/reactx/dxg/dxg_driver.h trunk/reactos/win32ss/reactx/dxg/dxg_int.h trunk/reactos/win32ss/reactx/dxg/tags.h Modified: trunk/reactos/sdk/include/reactos/drivers/directx/directxint.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/reactos/driver… ============================================================================== --- trunk/reactos/sdk/include/reactos/drivers/directx/directxint.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/reactos/drivers/directx/directxint.h [iso-8859-1] Sat Jun 24 22:24:04 2017 @@ -15,9 +15,9 @@ // /* 0x00 */ DD_BASEOBJECT pobj; // verified to match Windows XP /* 0x10 */ struct _EDD_DIRECTDRAW_GLOBAL * peDirectDrawGlobal; // verified to match Windows XP -/* 0x14 */ struct _EDD_SURFACE * peSurface_DdList; -/* 0x18 */ ULONG unk_018; -/* 0x1C */ ULONG unk_01c; +/* 0x14 */ ULONG hRefCount; +/* 0x18 */ struct _EDD_SURFACE * peSurface_DdList; +/* 0x1C */ ULONG hSurface; /* 0x20 */ ULONG unk_020; /* 0x24 */ struct _EDD_DIRECTDRAW_GLOBAL * peDirectDrawGlobal2; // verified to match Windows XP /* 0x28 */ FLATPTR fpProcess; @@ -26,9 +26,9 @@ // points to the old DDLocal when new handle is created. /* 0x34 */ FLATPTR fpProcess2; // surface memory address returned by graphic driver /* 0x38 */ ULONG isMemoryMapped; // surface memory mapped? -/* 0x3C */ HANDLE UniqueProcess; +/* 0x3C */ HANDLE hCreatorProcess; /* 0x40 */ PEPROCESS Process; -/* 0x44 */ VOID *unk_044; +/* 0x44 */ VOID *heapList; /* 0x48 */ ULONG unk_048; /* 0x4C */ ULONG unk_04C; /* 0x50 */ ULONG unk_050; @@ -68,12 +68,8 @@ // Private Direct Draw Data // struct _EDD_DIRECTDRAW_GLOBAL* peDirectDrawGlobal; + struct _EDD_DIRECTDRAW_GLOBAL* peDirectDrawGlobalNext; struct _EDD_DIRECTDRAW_LOCAL* peDirectDrawLocal; - - // - // Flags - // - FLONG fl; // // Surface Attributes @@ -84,17 +80,23 @@ HANDLE hSecure; HANDLE hdc; HBITMAP hbmGdi; - - // - // Unknown - // - ULONG field_E8; + HANDLE hGdiSurface; // // Surface Lock // RECTL rclLock; - ULONG field_FC[2]; + ULONG field_FC; + ULONG field_100; + ULONG field_104; + ULONG field_108; + ULONG field_10C; + + ULONG ldev; + struct _EDD_DIRECTDRAW_GLOBAL* peDirectDrawGlobal3; + ULONG gdev; + ULONG wWidth; + ULONG wHeight; } EDD_SURFACE, *PEDD_SURFACE; @@ -118,7 +120,9 @@ /* 0x000 */ PVOID dhpdev; // 0x000 <-- verified to match Windows XP, dhpdev, the drv hPDev --> /* 0x004 */ DWORD dwReserved1; /* 0x008 */ DWORD dwReserved2; -/* 0x00C */ ULONG unk_000c[3]; +/* 0x00C */ LPDDVIDEOPORTCAPS lpDDVideoPortCaps; // 0x00C <-- verified to match Win2k3 +/* 0x010 */ ULONG unk_010; +/* 0x014 */ ULONG unk_014; /* 0x018 */ LONG cDriverReferences; /* 0x01C */ ULONG unk_01c; /* 0x020 */ DWORD dwCallbackFlags; /* 0x020 <-- verified to match Windows XP, dwCallbackFlags Modified: trunk/reactos/win32ss/reactx/dxg/d3d.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxg/d3d.c?r… ============================================================================== --- trunk/reactos/win32ss/reactx/dxg/d3d.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxg/d3d.c [iso-8859-1] Sat Jun 24 22:24:04 2017 @@ -37,3 +37,89 @@ return RetVal; } + +DWORD +FASTCALL +intDdCreateSurfaceOrBuffer(HANDLE hDirectDrawLocal, + PEDD_SURFACE pDdSurfList, DDSURFACEDESC2 *a3, + DD_SURFACE_GLOBAL *pDdSurfGlob, + DD_SURFACE_LOCAL *pDdSurfLoc, + DD_SURFACE_MORE *pDdSurfMore, + DD_CREATESURFACEDATA *pDdCreateSurfaceData, + PVOID Address) +{ + PEDD_DIRECTDRAW_LOCAL peDdL = NULL; + PEDD_DIRECTDRAW_GLOBAL peDdGl = NULL; + DD_SURFACE_LOCAL *pCurSurfLocal; + DD_SURFACE_GLOBAL *pCurSurfGlobal; + DD_SURFACE_MORE *pCurSurfMore; + PEDD_SURFACE pCurSurf; + + ULONG CurSurf; + + if (!pDdCreateSurfaceData) + return FALSE; + + if (!pDdCreateSurfaceData->dwSCnt) + { + pDdCreateSurfaceData->ddRVal = E_FAIL; + return FALSE; + } + + peDdL = (PEDD_DIRECTDRAW_LOCAL)DdHmgLock(hDirectDrawLocal, ObjType_DDLOCAL_TYPE, FALSE); + if (!peDdL) + return FALSE; + + peDdGl = peDdL->peDirectDrawGlobal2; + + if (!(pDdSurfLoc->ddsCaps.dwCaps & DDSCAPS_VISIBLE) && !(peDdGl->ddCallbacks.dwFlags & DDHAL_CB32_CREATESURFACE)) + { + pDdCreateSurfaceData->ddRVal = E_FAIL; + return FALSE; + } + + pDdSurfList = (PEDD_SURFACE)EngAllocMem(FL_ZERO_MEMORY, pDdCreateSurfaceData->dwSCnt * sizeof(EDD_SURFACE), TAG_GDDP); + pDdSurfGlob = (DD_SURFACE_GLOBAL *)EngAllocMem(FL_ZERO_MEMORY, pDdCreateSurfaceData->dwSCnt * sizeof(DD_SURFACE_GLOBAL), TAG_GDDP); + pDdSurfLoc = (DD_SURFACE_LOCAL *)EngAllocMem(FL_ZERO_MEMORY, pDdCreateSurfaceData->dwSCnt * sizeof(DD_SURFACE_LOCAL), TAG_GDDP); + pDdSurfMore = (DD_SURFACE_MORE *)EngAllocMem(FL_ZERO_MEMORY, pDdCreateSurfaceData->dwSCnt * sizeof(DD_SURFACE_MORE), TAG_GDDP); + + gpEngFuncs.DxEngLockShareSem(); + gpEngFuncs.DxEngLockHdev(peDdGl->hDev); + + // create all surface objects + for (CurSurf = 0; CurSurf < pDdCreateSurfaceData->dwSCnt; CurSurf++) + { + pCurSurf = &pDdSurfList[CurSurf]; + pCurSurfLocal = &pDdSurfLoc[CurSurf]; + pCurSurfGlobal = &pDdSurfGlob[CurSurf]; + pCurSurfMore = &pDdSurfMore[CurSurf]; + + pCurSurf = intDdCreateNewSurfaceObject( + peDdL, + pCurSurf, + pCurSurfGlobal, + pCurSurfLocal, + pCurSurfMore); + Address = pCurSurf; + } + + gpEngFuncs.DxEngUnlockHdev(peDdGl->hDev); + gpEngFuncs.DxEngUnlockShareSem(); + + return DDHAL_DRIVER_HANDLED; +} + +DWORD +NTAPI +DxDdCreateD3DBuffer( + HANDLE hDirectDrawLocal, + PEDD_SURFACE pDdSurfList, + DDSURFACEDESC2 *a3, + DD_SURFACE_GLOBAL *pDdSurfGlob, + DD_SURFACE_LOCAL *pDdSurfLoc, + DD_SURFACE_MORE *pDdSurfMore, + DD_CREATESURFACEDATA *pDdCreateSurfaceData, + PVOID Address) +{ + return intDdCreateSurfaceOrBuffer(hDirectDrawLocal, pDdSurfList, a3, pDdSurfGlob, pDdSurfLoc, pDdSurfMore, pDdCreateSurfaceData, Address); +} Modified: trunk/reactos/win32ss/reactx/dxg/ddraw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxg/ddraw.c… ============================================================================== --- trunk/reactos/win32ss/reactx/dxg/ddraw.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxg/ddraw.c [iso-8859-1] Sat Jun 24 22:24:04 2017 @@ -223,7 +223,7 @@ /* initialize DIRECTDRAW_LOCAL */ peDdL->peDirectDrawLocal_prev = peDdGl->peDirectDrawLocalList; - peDdL->UniqueProcess = PsGetCurrentThreadProcessId(); + peDdL->hCreatorProcess = PsGetCurrentThreadProcessId(); peDdL->Process = PsGetCurrentProcess(); // link DirectDrawGlobal and DirectDrawLocal @@ -233,7 +233,7 @@ gpEngFuncs.DxEngReferenceHdev(hDev); - InterlockedExchangeAdd((LONG*)&peDdL->pobj.cExclusiveLock, 0xFFFFFFFF); + InterlockedDecrement((VOID*)&peDdL->pobj.cExclusiveLock); return peDdL->pobj.hHmgr; } @@ -331,7 +331,7 @@ } if (InlineIsEqualGUID(&drvInfoData->guidInfo, &GUID_VideoPortCaps)) { - pInfo = (VOID*)peDdGl->unk_000c[0]; + pInfo = (VOID*)peDdGl->lpDDVideoPortCaps; dwInfoSize = 72 * peDdGl->ddHalInfo.ddCaps.dwMaxVideoPorts; } if (InlineIsEqualGUID(&drvInfoData->guidInfo, &GUID_D3DCallbacks3)) @@ -462,13 +462,13 @@ *(DWORD*)((ULONG)pCallBackFlags + 8) = peDdGl->ddPaletteCallbacks.dwFlags; } - if ( pd3dNtHalCallbacks ) + if (pd3dNtHalCallbacks) memcpy(pd3dNtHalCallbacks, &peDdGl->d3dNtHalCallbacks, sizeof(peDdGl->d3dNtHalCallbacks)); - if ( pd3dNtGlobalDriverData ) + if (pd3dNtGlobalDriverData) memcpy(pd3dNtGlobalDriverData, &peDdGl->d3dNtGlobalDriverData, sizeof(peDdGl->d3dNtGlobalDriverData)); - if ( pd3dBufCallbacks ) + if (pd3dBufCallbacks) memcpy(pd3dBufCallbacks, &peDdGl->d3dBufCallbacks, sizeof(peDdGl->d3dBufCallbacks)); if (pTextureFormats) @@ -581,3 +581,95 @@ return RetVal; } + +PEDD_SURFACE +NTAPI +intDdCreateNewSurfaceObject(PEDD_DIRECTDRAW_LOCAL peDdL, HANDLE hDirectDrawLocal, PDD_SURFACE_GLOBAL pDdSurfGlob, PDD_SURFACE_LOCAL pDdSurfLoc, PDD_SURFACE_MORE pDdSurfMore) +{ + PEDD_SURFACE pSurface = NULL; + + // first check if we can assign it from current ddHandle + if (hDirectDrawLocal) + { + pSurface = (PEDD_SURFACE)DdHmgLock(hDirectDrawLocal, ObjType_DDSURFACE_TYPE, FALSE); + // check if surface is locked and belongs to correct DirectDrawLocal + if ((pSurface)&&((pSurface->peDirectDrawLocal != peDdL)||(!pSurface->hSecure))) + { + InterlockedDecrement((VOID*)&peDdL->pobj.cExclusiveLock); + return NULL; + } + } + + // if surface not found from ddHandle or ddHandle not provided + if (!pSurface) + { + // create new surface object + pSurface = (PEDD_SURFACE)DdHmgAlloc(sizeof(EDD_SURFACE), ObjType_DDSURFACE_TYPE, TRUE); + if (pSurface) + { + pSurface->ddsSurfaceLocal.lpGbl = &pSurface->ddsSurfaceGlobal; + pSurface->ddsSurfaceLocal.lpSurfMore = &pSurface->ddsSurfaceMore; + pSurface->ddsSurfaceInt.lpLcl = &pSurface->ddsSurfaceLocal; + pSurface->peDirectDrawLocal = peDdL; + pSurface->peDirectDrawGlobalNext = peDdL->peDirectDrawGlobal2; + pSurface->ldev = gpEngFuncs.DxEngGetHdevData(pSurface->peDirectDrawGlobalNext->hDev, DxEGShDevData_ldev); + pSurface->gdev = gpEngFuncs.DxEngGetHdevData(pSurface->peDirectDrawGlobalNext->hDev, DxEGShDevData_GDev); + pSurface->hSecure = (VOID*)1; + } + } + + if (pSurface) + { + pSurface->ddsSurfaceGlobal.fpVidMem = pDdSurfGlob->fpVidMem; + pSurface->ddsSurfaceGlobal.lPitch = pDdSurfGlob->lPitch; + pSurface->ddsSurfaceGlobal.wWidth = pDdSurfGlob->wWidth; + pSurface->ddsSurfaceGlobal.wHeight = pDdSurfGlob->wHeight; + pSurface->wWidth = pDdSurfGlob->wWidth; + pSurface->wHeight = pDdSurfGlob->wHeight; + memcpy(&pSurface->ddsSurfaceGlobal.ddpfSurface, &pDdSurfGlob->ddpfSurface, sizeof(pSurface->ddsSurfaceGlobal.ddpfSurface)); + pSurface->ddsSurfaceLocal.ddsCaps.dwCaps = pDdSurfLoc->ddsCaps.dwCaps; + pSurface->ddsSurfaceMore.ddsCapsEx.dwCaps2 = pDdSurfMore->ddsCapsEx.dwCaps2; + pSurface->ddsSurfaceMore.ddsCapsEx.dwCaps3 = pDdSurfMore->ddsCapsEx.dwCaps3; + pSurface->ddsSurfaceMore.ddsCapsEx.dwCaps4 = pDdSurfMore->ddsCapsEx.dwCaps4; + pSurface->ddsSurfaceMore.dwSurfaceHandle = pDdSurfMore->dwSurfaceHandle; + pSurface->hSecure = (VOID*)1; + + peDdL->peSurface_DdList = pSurface; + peDdL->hSurface = (ULONG)pSurface->pobj.hHmgr; + } + + return pSurface; +} + +HANDLE +NTAPI +DxDdCreateSurfaceObject(HANDLE hDirectDrawLocal, + HANDLE hSurface, + PDD_SURFACE_LOCAL puSurfaceLocal, + PDD_SURFACE_MORE puSurfaceMore, + PDD_SURFACE_GLOBAL puSurfaceGlobal, + BOOL bComplete) +{ + HANDLE RetVal = FALSE; + PEDD_DIRECTDRAW_LOCAL peDdL = NULL; + PEDD_SURFACE pDdSurface = NULL; + + peDdL = (PEDD_DIRECTDRAW_LOCAL)DdHmgLock(hDirectDrawLocal, ObjType_DDLOCAL_TYPE, FALSE); + + if (!peDdL) + return RetVal; + + pDdSurface = intDdCreateNewSurfaceObject(peDdL, hSurface, puSurfaceGlobal, puSurfaceLocal, puSurfaceMore); + if (!pDdSurface) + { + InterlockedDecrement((VOID*)&peDdL->pobj.cExclusiveLock); + return RetVal; + } + + RetVal = pDdSurface->pobj.hHmgr; + + InterlockedDecrement((VOID*)&pDdSurface->pobj.cExclusiveLock); + InterlockedDecrement((VOID*)&peDdL->pobj.cExclusiveLock); + + return RetVal; +} Modified: trunk/reactos/win32ss/reactx/dxg/dxg_driver.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxg/dxg_dri… ============================================================================== --- trunk/reactos/win32ss/reactx/dxg/dxg_driver.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxg/dxg_driver.h [iso-8859-1] Sat Jun 24 22:24:04 2017 @@ -131,40 +131,10 @@ DWORD NTAPI -DxDdCreateD3DBuffer( - PVOID p1, - PVOID p2, - PVOID p3, - PVOID p4, - PVOID p5, - PVOID p6, - PVOID p7, - PVOID p8) -{ - TRACE(); - return 0; -} - -DWORD -NTAPI DxDdCreateMoComp( PVOID p1, PVOID p2) { - return 0; -} - -DWORD -NTAPI -DxDdCreateSurfaceObject( - PVOID p1, - PVOID p2, - PVOID p3, - PVOID p4, - PVOID p5, - PVOID p6) -{ - TRACE(); return 0; } Modified: trunk/reactos/win32ss/reactx/dxg/dxg_int.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxg/dxg_int… ============================================================================== --- trunk/reactos/win32ss/reactx/dxg/dxg_int.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxg/dxg_int.h [iso-8859-1] Sat Jun 24 22:24:04 2017 @@ -202,8 +202,11 @@ DWORD NTAPI DxDdReenableDirectDrawObject(HANDLE DdHandle, PVOID p2); DWORD NTAPI DxDdCanCreateSurface(HANDLE DdHandle, PDD_CANCREATESURFACEDATA SurfaceData); DWORD NTAPI DxDdCanCreateD3DBuffer(HANDLE DdHandle, PDD_CANCREATESURFACEDATA SurfaceData); +DWORD NTAPI DxDdCreateD3DBuffer(HANDLE hDirectDrawLocal, PEDD_SURFACE pDdSurfList, DDSURFACEDESC2 *a3, DD_SURFACE_GLOBAL *pDdSurfGlob, DD_SURFACE_LOCAL *pDdSurfLoc, + DD_SURFACE_MORE *pDdSurfMore, DD_CREATESURFACEDATA *pDdCreateSurfaceData, PVOID Address); DWORD NTAPI DxDdLock(HANDLE hSurface, PDD_LOCKDATA puLockData, HDC hdcClip); DWORD NTAPI DxDdUnlock(HANDLE hSurface, PDD_UNLOCKDATA puUnlockData); +HANDLE NTAPI DxDdCreateSurfaceObject(HANDLE hDirectDrawLocal, HANDLE hSurface, PDD_SURFACE_LOCAL puSurfaceLocal, PDD_SURFACE_MORE puSurfaceMore, PDD_SURFACE_GLOBAL puSurfaceGlobal, BOOL bComplete); /* Internal functions */ @@ -212,6 +215,7 @@ BOOL FASTCALL DdHmgDestroy(VOID); PVOID FASTCALL DdHmgLock(HANDLE DdHandle, UCHAR ObjectType, BOOLEAN LockOwned); HANDLE FASTCALL DdHmgAlloc(ULONG objSize, CHAR objType, BOOLEAN objLock); - +PEDD_SURFACE NTAPI intDdCreateNewSurfaceObject(PEDD_DIRECTDRAW_LOCAL peDdL, HANDLE hDirectDrawLocal, + PDD_SURFACE_GLOBAL pDdSurfGlob, PDD_SURFACE_LOCAL pDdSurfLoc, PDD_SURFACE_MORE pDdSurfMore); #endif /* _DXG_PCH_ */ Modified: trunk/reactos/win32ss/reactx/dxg/tags.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxg/tags.h?… ============================================================================== --- trunk/reactos/win32ss/reactx/dxg/tags.h [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxg/tags.h [iso-8859-1] Sat Jun 24 22:24:04 2017 @@ -2,4 +2,5 @@ #define TAG_GINI 'iniG' #define TAG_GDDV 'vddG' #define TAG_GDDF 'fddG' +#define TAG_GDDP 'pddG' #define TAG_DH_0 '0 hD'

1 0

[dquintana] 75188: [NTOBJSHEX] Fix registration.
by dquintana＠svn.reactos.org 24 Jun '17

24 Jun '17

Author: dquintana Date: Sat Jun 24 22:01:46 2017 New Revision: 75188 URL: http://svn.reactos.org/svn/reactos?rev=75188&view=rev Log: [NTOBJSHEX] Fix registration. Modified: trunk/reactos/dll/shellext/ntobjshex/foldercommon.h trunk/reactos/dll/shellext/ntobjshex/ntobjfolder.h trunk/reactos/dll/shellext/ntobjshex/regfolder.h Modified: trunk/reactos/dll/shellext/ntobjshex/foldercommon.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/ntobjshex/fol… ============================================================================== --- trunk/reactos/dll/shellext/ntobjshex/foldercommon.h [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/ntobjshex/foldercommon.h [iso-8859-1] Sat Jun 24 22:01:46 2017 @@ -706,8 +706,7 @@ } return E_NOTIMPL; } - - DECLARE_REGISTRY_RESOURCEID(IDR_REGISTRYFOLDER) + DECLARE_NOT_AGGREGATABLE(TSelf) DECLARE_PROTECT_FINAL_CONSTRUCT() Modified: trunk/reactos/dll/shellext/ntobjshex/ntobjfolder.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/ntobjshex/nto… ============================================================================== --- trunk/reactos/dll/shellext/ntobjshex/ntobjfolder.h [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/ntobjshex/ntobjfolder.h [iso-8859-1] Sat Jun 24 22:01:46 2017 @@ -52,6 +52,7 @@ public CCommonFolder<CNtObjectFolder, NtPidlEntry, CNtObjectFolderExtractIcon> { public: + DECLARE_REGISTRY_RESOURCEID(IDR_NTOBJECTFOLDER) CNtObjectFolder(); virtual ~CNtObjectFolder(); Modified: trunk/reactos/dll/shellext/ntobjshex/regfolder.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/ntobjshex/reg… ============================================================================== --- trunk/reactos/dll/shellext/ntobjshex/regfolder.h [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/ntobjshex/regfolder.h [iso-8859-1] Sat Jun 24 22:01:46 2017 @@ -53,6 +53,7 @@ HKEY m_hRoot; public: + DECLARE_REGISTRY_RESOURCEID(IDR_REGISTRYFOLDER) CRegistryFolder(); virtual ~CRegistryFolder();

1 0

[ekohl] 75187: [NETAPI32] Implement NetBrowserStatisticsGet().
by ekohl＠svn.reactos.org 24 Jun '17

24 Jun '17

Author: ekohl Date: Sat Jun 24 21:47:27 2017 New Revision: 75187 URL: http://svn.reactos.org/svn/reactos?rev=75187&view=rev Log: [NETAPI32] Implement NetBrowserStatisticsGet(). Modified: trunk/reactos/dll/win32/netapi32/browser.c trunk/reactos/dll/win32/netapi32/netapi32.spec trunk/reactos/sdk/include/psdk/lmbrowsr.h trunk/reactos/sdk/include/reactos/idl/browser.idl Modified: trunk/reactos/dll/win32/netapi32/browser.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/browser… ============================================================================== --- trunk/reactos/dll/win32/netapi32/browser.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netapi32/browser.c [iso-8859-1] Sat Jun 24 21:47:27 2017 @@ -246,6 +246,69 @@ DomainName, EmulatedServerName, Role); + } + RpcExcept(EXCEPTION_EXECUTE_HANDLER) + { + status = I_RpcMapWin32Status(RpcExceptionCode()); + } + RpcEndExcept; + + return status; +} + + +NET_API_STATUS +WINAPI +NetBrowserStatisticsGet( + _In_ LPWSTR ServerName, + _In_ DWORD Level, + _Out_ LPBYTE *Buffer) +{ + BROWSER_STATISTICS_STRUCT StatisticsStruct; + BROWSER_STATISTICS_100_CONTAINER Level100Container = {0, NULL}; + BROWSER_STATISTICS_101_CONTAINER Level101Container = {0, NULL}; + NET_API_STATUS status; + + TRACE("NetBrowserStatisticsGet(%s %lu %p)\n", + debugstr_w(ServerName), Level, Buffer); + + if (Level != 100 && Level != 101) + return ERROR_INVALID_LEVEL; + + StatisticsStruct.Level = Level; + switch (Level) + { + case 100: + StatisticsStruct.Statistics.Level100 = &Level100Container; + break; + + case 101: + StatisticsStruct.Statistics.Level101 = &Level101Container; + break; + } + + RpcTryExcept + { + status = NetrBrowserStatisticsGet(ServerName, + Level, + &StatisticsStruct); + + switch (Level) + { + case 100: + if (StatisticsStruct.Statistics.Level100->Buffer != NULL) + { + *Buffer = (LPBYTE)StatisticsStruct.Statistics.Level100->Buffer; + } + break; + + case 101: + if (StatisticsStruct.Statistics.Level101->Buffer != NULL) + { + *Buffer = (LPBYTE)StatisticsStruct.Statistics.Level101->Buffer; + } + break; + } } RpcExcept(EXCEPTION_EXECUTE_HANDLER) { @@ -270,11 +333,22 @@ _In_opt_ LMCSTR domain, _Inout_opt_ LPDWORD resume_handle) { - FIXME("NetServerEnum(%s %lu %p %lu %p %p %lu %s %p)\n", + TRACE("NetServerEnum(%s %lu %p %lu %p %p %lu %s %p)\n", debugstr_w(servername), level, bufptr, prefmaxlen, entriesread, totalentries, servertype, debugstr_w(domain), resume_handle); - return ERROR_NO_BROWSER_SERVERS_FOUND; + if (resume_handle != NULL) + *resume_handle = 0; + + return NetServerEnumEx(servername, + level, + bufptr, + prefmaxlen, + entriesread, + totalentries, + servertype, + domain, + NULL); } Modified: trunk/reactos/dll/win32/netapi32/netapi32.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/netapi3… ============================================================================== --- trunk/reactos/dll/win32/netapi32/netapi32.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netapi32/netapi32.spec [iso-8859-1] Sat Jun 24 21:47:27 2017 @@ -109,7 +109,7 @@ @ stdcall NetAuditClear(wstr wstr wstr) @ stdcall NetAuditRead(wstr wstr ptr long ptr long long ptr long ptr ptr) @ stdcall NetAuditWrite(long ptr long wstr ptr) -@ stub NetBrowserStatisticsGet +@ stdcall NetBrowserStatisticsGet(wstr long ptr) @ stdcall NetConfigGet(wstr wstr wstr ptr) @ stdcall NetConfigGetAll(wstr wstr ptr) @ stdcall NetConfigSet(wstr wstr wstr long long ptr long) Modified: trunk/reactos/sdk/include/psdk/lmbrowsr.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/psdk/lmbrowsr.… ============================================================================== --- trunk/reactos/sdk/include/psdk/lmbrowsr.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/psdk/lmbrowsr.h [iso-8859-1] Sat Jun 24 21:47:27 2017 @@ -72,6 +72,7 @@ NET_API_STATUS WINAPI I_BrowserQueryStatistics(LPCWSTR,LPBROWSER_STATISTICS*); NET_API_STATUS WINAPI I_BrowserResetStatistics(LPCWSTR); NET_API_STATUS WINAPI I_BrowserDebugTrace(PWCHAR,PCHAR); +NET_API_STATUS WINAPI NetBrowserStatisticsGet(PWSTR,DWORD,PBYTE*); #ifdef __cplusplus } #endif Modified: trunk/reactos/sdk/include/reactos/idl/browser.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/reactos/idl/br… ============================================================================== --- trunk/reactos/sdk/include/reactos/idl/browser.idl [iso-8859-1] (original) +++ trunk/reactos/sdk/include/reactos/idl/browser.idl [iso-8859-1] Sat Jun 24 21:47:27 2017 @@ -122,7 +122,7 @@ [case(101)] PBROWSER_STATISTICS_101_CONTAINER Level101; [default] ; } Statistics; -}BROWSER_STATISTICS_STRUCT, *PBROWSER_STATISTICS_STRUCT, *LPBROWSER_STATISTICS_STRUCT; +} BROWSER_STATISTICS_STRUCT, *PBROWSER_STATISTICS_STRUCT, *LPBROWSER_STATISTICS_STRUCT; [ uuid(6BFFD098-A112-3610-9833-012892020162), @@ -188,7 +188,7 @@ /* Function 8 */ NET_API_STATUS __stdcall - I_BrowserrStatisticsGet( + NetrBrowserStatisticsGet( [in, string, unique] BROWSER_IDENTIFY_HANDLE ServerName, [in] DWORD Level, [in, out] LPBROWSER_STATISTICS_STRUCT StatisticsStruct);

1 0

[ekohl] 75186: [NETAPI32] Move the functions NetGetDCName, NetGetAnyDCName and NetEnumerateTrustedDomains into a separate file for the Netlogon service interface code.
by ekohl＠svn.reactos.org 24 Jun '17

24 Jun '17

Author: ekohl Date: Sat Jun 24 16:42:21 2017 New Revision: 75186 URL: http://svn.reactos.org/svn/reactos?rev=75186&view=rev Log: [NETAPI32] Move the functions NetGetDCName, NetGetAnyDCName and NetEnumerateTrustedDomains into a separate file for the Netlogon service interface code. Added: trunk/reactos/dll/win32/netapi32/netlogon.c (with props) Modified: trunk/reactos/dll/win32/netapi32/CMakeLists.txt trunk/reactos/dll/win32/netapi32/access.c Modified: trunk/reactos/dll/win32/netapi32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/CMakeLi… ============================================================================== --- trunk/reactos/dll/win32/netapi32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netapi32/CMakeLists.txt [iso-8859-1] Sat Jun 24 16:42:21 2017 @@ -26,6 +26,7 @@ nbt.c netapi32.c netbios.c + netlogon.c obsolete.c schedule.c srvsvc.c Modified: trunk/reactos/dll/win32/netapi32/access.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/access.… ============================================================================== --- trunk/reactos/dll/win32/netapi32/access.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netapi32/access.c [iso-8859-1] Sat Jun 24 16:42:21 2017 @@ -246,45 +246,3 @@ } return NERR_Success; } - -/************************************************************ - * NetGetDCName (NETAPI32.@) - * - * Return the name of the primary domain controller (PDC) - */ - -NET_API_STATUS WINAPI -NetGetDCName(LPCWSTR servername, LPCWSTR domainname, LPBYTE *bufptr) -{ - FIXME("(%s, %s, %p) stub!\n", debugstr_w(servername), - debugstr_w(domainname), bufptr); - return NERR_DCNotFound; /* say we can't find a domain controller */ -} - -/************************************************************ - * NetGetAnyDCName (NETAPI32.@) - * - * Return the name of any domain controller (DC) - */ -NET_API_STATUS WINAPI -NetGetAnyDCName( - _In_ LPCWSTR servername, - _In_ LPCWSTR domainname, - _Out_ LPBYTE *bufptr) -{ - FIXME("NetGetAnyDCName(%s, %s, %p) stub!\n", debugstr_w(servername), - debugstr_w(domainname), bufptr); - return ERROR_NO_LOGON_SERVERS; -} - -/************************************************************ - * NetEnumerateTrustedDomains (NETAPI32.@) - * - * On success, *DomainNames is a multi-sz allocated using NetApiBufferAllocate - */ -NTSTATUS WINAPI -NetEnumerateTrustedDomains(LPWSTR ServerName, LPWSTR *DomainNames) -{ - FIXME("(%s, %p) stub!\n", debugstr_w(ServerName), DomainNames); - return STATUS_NOT_IMPLEMENTED; -} Added: trunk/reactos/dll/win32/netapi32/netlogon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netapi32/netlogo… ============================================================================== --- trunk/reactos/dll/win32/netapi32/netlogon.c (added) +++ trunk/reactos/dll/win32/netapi32/netlogon.c [iso-8859-1] Sat Jun 24 16:42:21 2017 @@ -0,0 +1,57 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: NetAPI DLL + * FILE: dll/win32/netapi32/netlogon.c + * PURPOSE: Netlogon service interface code + * PROGRAMMERS: Eric Kohl (eric.kohl(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include "netapi32.h" + +WINE_DEFAULT_DEBUG_CHANNEL(netapi32); + +/* FUNCTIONS *****************************************************************/ + +NTSTATUS +WINAPI +NetEnumerateTrustedDomains( + _In_ LPWSTR ServerName, + _Out_ LPWSTR *DomainNames) +{ + FIXME("NetEnumerateTrustedDomains(%s, %p)\n", + debugstr_w(ServerName), DomainNames); + + return STATUS_NOT_IMPLEMENTED; +} + + +NET_API_STATUS +WINAPI +NetGetAnyDCName( + _In_ LPCWSTR servername, + _In_ LPCWSTR domainname, + _Out_ LPBYTE *bufptr) +{ + FIXME("NetGetAnyDCName(%s, %s, %p)\n", + debugstr_w(servername), debugstr_w(domainname), bufptr); + + return ERROR_NO_LOGON_SERVERS; +} + + +NET_API_STATUS +WINAPI +NetGetDCName( + _In_ LPCWSTR servername, + _In_ LPCWSTR domainname, + _Out_ LPBYTE *bufptr) +{ + FIXME("NetGetDCName(%s, %s, %p)\n", + debugstr_w(servername), debugstr_w(domainname), bufptr); + + return NERR_DCNotFound; +} + +/* EOF */ Propchange: trunk/reactos/dll/win32/netapi32/netlogon.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[pschweitzer] 75185: [DXG] Fix GCC build
by pschweitzer＠svn.reactos.org 24 Jun '17

24 Jun '17

Author: pschweitzer Date: Sat Jun 24 16:22:24 2017 New Revision: 75185 URL: http://svn.reactos.org/svn/reactos?rev=75185&view=rev Log: [DXG] Fix GCC build Modified: trunk/reactos/win32ss/reactx/dxg/ddsurf.c Modified: trunk/reactos/win32ss/reactx/dxg/ddsurf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/reactx/dxg/ddsurf.… ============================================================================== --- trunk/reactos/win32ss/reactx/dxg/ddsurf.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/reactx/dxg/ddsurf.c [iso-8859-1] Sat Jun 24 16:22:24 2017 @@ -5,6 +5,8 @@ * FILE: win32ss/reactx/dxg/ddsurf.c * PROGRAMER: Sebastian Gasiorek (sebastian.gasiorek(a)reactos.org) */ + +#include <dxg_int.h> /*++ * @name DxDdLock

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs