Ros-diffs

ros-diffs@reactos.org

81390 discussions

[reactos] 22/30: [NTOS:EX] Implement NtSystemDebugControl: SysDbgBreakPoint

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7b4d618994587b6ba08d9… commit 7b4d618994587b6ba08d9794c34eb466fe121823 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:48 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:48 2025 +0100 [NTOS:EX] Implement NtSystemDebugControl: SysDbgBreakPoint --- ntoskrnl/ex/dbgctrl.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index c6553324a80..8c27e3267b0 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -271,6 +271,17 @@ NtSystemDebugControl( break; case SysDbgBreakPoint: + if (KdDebuggerEnabled) + { + DbgBreakPointWithStatus(DBG_STATUS_DEBUG_CONTROL); + Status = STATUS_SUCCESS; + } + else + { + Status = STATUS_UNSUCCESSFUL; + } + break; + case SysDbgEnableKernelDebugger: case SysDbgDisableKernelDebugger: case SysDbgGetAutoKdEnable:

9 months, 3 weeks

[reactos] 21/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgCheckLowMemory

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1db1bceaa728ab13c58e1… commit 1db1bceaa728ab13c58e15da866d5a602208987b Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:23 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:48 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgCheckLowMemory --- ntoskrnl/kd64/kdapi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 482c817a9bc..76f6786c112 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2571,8 +2571,7 @@ KdSystemDebugControl( break; case SysDbgCheckLowMemory: - UNIMPLEMENTED; - Status = STATUS_NOT_IMPLEMENTED; + Status = KdpSysCheckLowMemory(0); break; default:

9 months, 3 weeks

[reactos] 20/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadBusData/SysDbgWriteBusData

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2fe3de6c69b98fa426796… commit 2fe3de6c69b98fa4267963bafca7afea0d74cd0f Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:14 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:47 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadBusData/SysDbgWriteBusData --- ntoskrnl/kd64/kdapi.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 2d900336c24..482c817a9bc 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2509,7 +2509,67 @@ KdSystemDebugControl( break; case SysDbgReadBusData: + if (InputBufferLength != sizeof(SYSDBG_BUS_DATA)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_BUS_DATA Request = *(PSYSDBG_BUS_DATA)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoWriteAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysReadBusData(Request.BusDataType, + Request.BusNumber, + Request.SlotNumber, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgWriteBusData: + if (InputBufferLength != sizeof(SYSDBG_BUS_DATA)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_BUS_DATA Request = *(PSYSDBG_BUS_DATA)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysWriteBusData(Request.BusDataType, + Request.BusNumber, + Request.SlotNumber, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgCheckLowMemory: UNIMPLEMENTED; Status = STATUS_NOT_IMPLEMENTED;

9 months, 3 weeks

[reactos] 19/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadMsr/SysDbgWriteMsr

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=19046a253bc28af7f052e… commit 19046a253bc28af7f052e35ccd23c723e5620b64 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:40:00 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:46 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadMsr/SysDbgWriteMsr --- ntoskrnl/kd64/kdapi.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index ed1a74e9ee1..2d900336c24 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2485,7 +2485,29 @@ KdSystemDebugControl( break; case SysDbgReadMsr: + if (InputBufferLength != sizeof(SYSDBG_MSR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + PSYSDBG_MSR Request = (PSYSDBG_MSR)InputBuffer; + Status = KdpSysReadMsr(Request->Address, &Request->Data); + } + break; + case SysDbgWriteMsr: + if (InputBufferLength != sizeof(SYSDBG_MSR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + PSYSDBG_MSR Request = (PSYSDBG_MSR)InputBuffer; + Status = KdpSysWriteMsr(Request->Address, &Request->Data); + } + break; + case SysDbgReadBusData: case SysDbgWriteBusData: case SysDbgCheckLowMemory:

9 months, 3 weeks

[reactos] 18/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadIoSpace/SysDbgWriteIoSpace

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b187662f3930ea3244d26… commit b187662f3930ea3244d26fd7c47e052c76ffa998 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:39:47 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:46 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadIoSpace/SysDbgWriteIoSpace --- ntoskrnl/kd64/kdapi.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 899e225f013..ed1a74e9ee1 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2423,7 +2423,67 @@ KdSystemDebugControl( break; case SysDbgReadIoSpace: + if (InputBufferLength != sizeof(SYSDBG_IO_SPACE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_IO_SPACE Request = *(PSYSDBG_IO_SPACE)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoWriteAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysReadIoSpace(Request.InterfaceType, + Request.BusNumber, + Request.AddressSpace, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgWriteIoSpace: + if (InputBufferLength != sizeof(SYSDBG_IO_SPACE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_IO_SPACE Request = *(PSYSDBG_IO_SPACE)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysWriteIoSpace(Request.InterfaceType, + Request.BusNumber, + Request.AddressSpace, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgReadMsr: case SysDbgWriteMsr: case SysDbgReadBusData:

9 months, 3 weeks

[reactos] 17/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadControlSpace/SysDbgWriteControlSpace

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=0589c178ba91e9151d942… commit 0589c178ba91e9151d9425162dd4b6947f51e0a1 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:39:33 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:45 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadControlSpace/SysDbgWriteControlSpace --- ntoskrnl/kd64/kdapi.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index d6506701841..899e225f013 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2365,7 +2365,63 @@ KdSystemDebugControl( break; case SysDbgReadControlSpace: + if (InputBufferLength != sizeof(SYSDBG_CONTROL_SPACE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_CONTROL_SPACE Request = *(PSYSDBG_CONTROL_SPACE)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoWriteAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysReadControlSpace(Request.Processor, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgWriteControlSpace: + if (InputBufferLength != sizeof(SYSDBG_CONTROL_SPACE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_CONTROL_SPACE Request = *(PSYSDBG_CONTROL_SPACE)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpSysWriteControlSpace(Request.Processor, + Request.Address, + LockedBuffer, + Request.Request, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgReadIoSpace: case SysDbgWriteIoSpace: case SysDbgReadMsr:

9 months, 3 weeks

[reactos] 16/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadPhysical/SysDbgWritePhysical

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=42e038f227bf0deeb9134… commit 42e038f227bf0deeb9134e19851bf25d74f6472f Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:39:09 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:43 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadPhysical/SysDbgWritePhysical --- ntoskrnl/kd64/kdapi.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index f6e375dbc7d..d6506701841 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2335,6 +2335,35 @@ KdSystemDebugControl( case SysDbgReadPhysical: case SysDbgWritePhysical: + if (InputBufferLength != sizeof(SYSDBG_PHYSICAL)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_PHYSICAL Request = *(PSYSDBG_PHYSICAL)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + Command == SysDbgReadVirtual ? IoWriteAccess : IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpCopyMemoryChunks(Request.Address.QuadPart, + Request.Buffer, + Request.Request, + 0, + MMDBG_COPY_PHYSICAL | (Command == SysDbgReadVirtual ? 0 : MMDBG_COPY_WRITE), + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgReadControlSpace: case SysDbgWriteControlSpace: case SysDbgReadIoSpace:

9 months, 3 weeks

[reactos] 15/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadVirtual/SysDbgWriteVirtual

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2efaa5ea1e0c3786bfeb6… commit 2efaa5ea1e0c3786bfeb6183e8d5162bab044dbd Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:38:56 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:42 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgReadVirtual/SysDbgWriteVirtual --- ntoskrnl/kd64/kdapi.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index f604779bc39..f6e375dbc7d 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2304,6 +2304,35 @@ KdSystemDebugControl( case SysDbgReadVirtual: case SysDbgWriteVirtual: + if (InputBufferLength != sizeof(SYSDBG_VIRTUAL)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + SYSDBG_VIRTUAL Request = *(PSYSDBG_VIRTUAL)InputBuffer; + PVOID LockedBuffer; + PMDL LockVariable; + + Status = ExLockUserBuffer(Request.Buffer, + Request.Request, + PreviousMode, + Command == SysDbgReadVirtual ? IoWriteAccess : IoReadAccess, + &LockedBuffer, + &LockVariable); + if (NT_SUCCESS(Status)) + { + Status = KdpCopyMemoryChunks((ULONG64)(ULONG_PTR)Request.Address, + Request.Buffer, + Request.Request, + 0, + Command == SysDbgReadVirtual ? 0 : MMDBG_COPY_WRITE, + &Length); + ExUnlockUserBuffer(LockVariable); + } + } + break; + case SysDbgReadPhysical: case SysDbgWritePhysical: case SysDbgReadControlSpace:

9 months, 3 weeks

[reactos] 14/30: [NTOS:KD64] Implement KdSystemDebugControl: SysDbgQueryVersion

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=9f97f0b2844695889c061… commit 9f97f0b2844695889c061068de648b5e5f80e3e5 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sun Sep 22 21:38:35 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:40 2025 +0100 [NTOS:KD64] Implement KdSystemDebugControl: SysDbgQueryVersion --- ntoskrnl/kd64/kdapi.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index e2dce3491e6..f604779bc39 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2291,6 +2291,17 @@ KdSystemDebugControl( switch (Command) { case SysDbgQueryVersion: + if (OutputBufferLength != sizeof(DBGKD_GET_VERSION64)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + } + else + { + KdpSysGetVersion((PDBGKD_GET_VERSION64)OutputBuffer); + Status = STATUS_SUCCESS; + } + break; + case SysDbgReadVirtual: case SysDbgWriteVirtual: case SysDbgReadPhysical:

9 months, 3 weeks

[reactos] 13/30: [NTOS:EX] In NtSystemDebugControl, check for SeDebugPrivilege

by Hervé Poussineau

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6338d513537a6872ef64c… commit 6338d513537a6872ef64cbe59b453a5e15d0dcc7 Author: Hervé Poussineau <hpoussin(a)reactos.org> AuthorDate: Sat Sep 14 09:15:51 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Jan 28 22:00:39 2025 +0100 [NTOS:EX] In NtSystemDebugControl, check for SeDebugPrivilege --- ntoskrnl/ex/dbgctrl.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ntoskrnl/ex/dbgctrl.c b/ntoskrnl/ex/dbgctrl.c index dbb47793ee5..c6553324a80 100644 --- a/ntoskrnl/ex/dbgctrl.c +++ b/ntoskrnl/ex/dbgctrl.c @@ -218,6 +218,10 @@ NtSystemDebugControl( ULONG Length = 0; NTSTATUS Status; + /* Debugger controlling requires the debug privilege */ + if (!SeSinglePrivilegeCheck(SeDebugPrivilege, PreviousMode)) + return STATUS_ACCESS_DENIED; + _SEH2_TRY { if (PreviousMode != KernelMode)

9 months, 3 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs