Author: tfaber
Date: Sun Feb 26 11:31:51 2017
New Revision: 73921
URL: http://svn.reactos.org/svn/reactos?rev=73921&view=rev
Log:
[KMTESTS:IO]
- Avoid a crash in IoFilesystem on Windows when using a free kernel with ntfs. Querying FileAllInformation with any size below sizeof(FILE_ALL_INFORMATION) is considered illegal, so only do it on checked builds (which have a size check).
Modified:
trunk/rostests/kmtests/ntos_io/IoFilesystem.c
Modified: trunk/rostests/kmtests/ntos_io/IoFilesystem.c
URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/ntos_io/IoFilesys…
==============================================================================
--- trunk/rostests/kmtests/ntos_io/IoFilesystem.c [iso-8859-1] (original)
+++ trunk/rostests/kmtests/ntos_io/IoFilesystem.c [iso-8859-1] Sun Feb 26 11:31:51 2017
@@ -115,13 +115,24 @@
ok_eq_size(Length, (ULONG_PTR)0x5555555555555555);
if (FileAllInfo)
KmtFreeGuarded(FileAllInfo);
+
+ /* No space for the name -- fastfat handles this gracefully, ntfs doesn't.
+ * But the Io manager makes it fail on checked builds, so it's
+ * technically illegal
+ */
+ Length = FIELD_OFFSET(FILE_ALL_INFORMATION, NameInformation.FileName);
+ Status = QueryFileInfo(FileHandle, (PVOID*)&FileAllInfo, &Length, FileAllInformation);
+ ok_eq_hex(Status, STATUS_INFO_LENGTH_MISMATCH);
+ ok_eq_size(Length, (ULONG_PTR)0x5555555555555555);
+ if (FileAllInfo)
+ KmtFreeGuarded(FileAllInfo);
}
/* The minimum allowed */
- Length = FIELD_OFFSET(FILE_ALL_INFORMATION, NameInformation.FileName);
+ Length = sizeof(FILE_ALL_INFORMATION);
Status = QueryFileInfo(FileHandle, (PVOID*)&FileAllInfo, &Length, FileAllInformation);
ok_eq_hex(Status, STATUS_BUFFER_OVERFLOW);
- ok_eq_size(Length, FIELD_OFFSET(FILE_ALL_INFORMATION, NameInformation.FileName));
+ ok_eq_size(Length, sizeof(FILE_ALL_INFORMATION));
if (FileAllInfo)
KmtFreeGuarded(FileAllInfo);
Author: pschweitzer
Date: Sun Feb 26 11:27:24 2017
New Revision: 73920
URL: http://svn.reactos.org/svn/reactos?rev=73920&view=rev
Log:
[NTOSKRNL]
Spotted with kmtest:IoFilesystem: these checks are not performed in free builds for kernel callers and are delegated to the FSD.
Modified:
trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c…
==============================================================================
--- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original)
+++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sun Feb 26 11:27:24 2017
@@ -2115,6 +2115,7 @@
}
_SEH2_END;
}
+#if DBG
else
{
/* Validate the information class */
@@ -2132,6 +2133,7 @@
return STATUS_INFO_LENGTH_MISMATCH;
}
}
+#endif
/* Reference the Handle */
Status = ObReferenceObjectByHandle(FileHandle,
Author: dreimer
Date: Sat Feb 25 23:02:36 2017
New Revision: 73916
URL: http://svn.reactos.org/svn/reactos?rev=73916&view=rev
Log:
[RAPPS]
Add Gecko Engine which can only be installed once during 1st stage, because someone thought this was a good idea. Now you can get it later, too.
Added:
trunk/reactos/media/rapps/gecko.txt (with props)
Added: trunk/reactos/media/rapps/gecko.txt
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/rapps/gecko.txt?rev=…
==============================================================================
--- trunk/reactos/media/rapps/gecko.txt (added)
+++ trunk/reactos/media/rapps/gecko.txt [iso-8859-1] Sat Feb 25 23:02:36 2017
@@ -0,0 +1,16 @@
+[Section]
+Name = Wine Gecko Engine
+Version = 2.40
+License = GPL
+Description = Gecko Engine normally installed on 1st stage setup, but only if internet connection was available at that time. Needed for applications using mshtml.dll.
+Size = 26.7 MiB
+Category = 14
+URLSite =
+URLDownload = https://svn.reactos.org/amine/wine_gecko-2.40-x86.msi
+SHA1 = 8a3adedf3707973d1ed4ac3b2e791486abf814bd
+CDPath = none
+
+[Section.0407]
+Description = Die Gecko Engine, welche normalerweise während des 1st stage Setups installiert wird, aber nur wenn zu diesem Zeitpunkt Internet verfügbar war. Wird für Anwendungen benötigt, die mshtml.dll einsetzen.
+Size = 26,7 MiB
+
Propchange: trunk/reactos/media/rapps/gecko.txt
------------------------------------------------------------------------------
svn:eol-style = CRLF
Author: gadamopoulos
Date: Sat Feb 25 22:54:42 2017
New Revision: 73915
URL: http://svn.reactos.org/svn/reactos?rev=73915&view=rev
Log:
[EXPLORER] -Use the hacky way to paint the start button until BCM_GETIDEALSIZE is also implemented.
Modified:
trunk/reactos/base/shell/explorer/traywnd.cpp
Modified: trunk/reactos/base/shell/explorer/traywnd.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/traywn…
==============================================================================
--- trunk/reactos/base/shell/explorer/traywnd.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/shell/explorer/traywnd.cpp [iso-8859-1] Sat Feb 25 22:54:42 2017
@@ -325,12 +325,16 @@
if (SendMessageW(BCM_SETIMAGELIST, 0, (LPARAM) &bil))
{
- /* We're using the image list, remove the BS_BITMAP style and
- don't center it horizontally */
- SetWindowStyle(m_hWnd, BS_BITMAP | BS_RIGHT, 0);
-
- UpdateSize();
- return;
+ SIZE Size = { 0, 0 };
+ if (SendMessageW(BCM_GETIDEALSIZE, 0, (LPARAM) &Size))
+ {
+ /* We're using the image list, remove the BS_BITMAP style and
+ don't center it horizontally */
+ SetWindowStyle(m_hWnd, BS_BITMAP | BS_RIGHT, 0);
+
+ UpdateSize();
+ return;
+ }
}
/* Fall back to the deprecated method on older systems that don't