Ros-diffs

ros-diffs@reactos.org

81390 discussions

[pschweitzer] 73683: [FASTFAT] vfatMakeFCBFromDirEntry(), use appropriate tag on free. Dedicated to Thomas :-)
by pschweitzer＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: pschweitzer Date: Sat Feb 4 19:37:40 2017 New Revision: 73683 URL: http://svn.reactos.org/svn/reactos?rev=73683&view=rev Log: [FASTFAT] vfatMakeFCBFromDirEntry(), use appropriate tag on free. Dedicated to Thomas :-) Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sat Feb 4 19:37:40 2017 @@ -732,7 +732,7 @@ if (!NT_SUCCESS(Status)) { vfatReleaseFCB(vcb, rcFCB); - ExFreePool(NameU.Buffer); + ExFreePoolWithTag(NameU.Buffer, TAG_FCB); return Status; } } @@ -741,7 +741,7 @@ vfatAddFCBToTable(vcb, rcFCB); *fileFCB = rcFCB; - ExFreePool(NameU.Buffer); + ExFreePoolWithTag(NameU.Buffer, TAG_FCB); return STATUS_SUCCESS; }

1 0

[ion] 73682: [CONFIGURE]: Better fix thanks to gigaherz.
by ion＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: ion Date: Sat Feb 4 18:55:47 2017 New Revision: 73682 URL: http://svn.reactos.org/svn/reactos?rev=73682&view=rev Log: [CONFIGURE]: Better fix thanks to gigaherz. Modified: trunk/reactos/configure.cmd Modified: trunk/reactos/configure.cmd URL: http://svn.reactos.org/svn/reactos/trunk/reactos/configure.cmd?rev=73682&r1… ============================================================================== --- trunk/reactos/configure.cmd [iso-8859-1] (original) +++ trunk/reactos/configure.cmd [iso-8859-1] Sat Feb 4 18:55:47 2017 @@ -58,7 +58,7 @@ cl 2>&1 | find "17.00." > NUL && set VS_VERSION=11 cl 2>&1 | find "18.00." > NUL && set VS_VERSION=12 cl 2>&1 | find "19.00." > NUL && set VS_VERSION=14 - cl 2>&1 | find "19.10." > NUL && set VS_VERSION=14 + cl 2>&1 | find "19.10." > NUL && set VS_VERSION=15 if not defined VS_VERSION ( echo Error: Visual Studio version too old or version detection failed. endlocal @@ -147,6 +147,15 @@ ) else ( set CMAKE_GENERATOR="Visual Studio 14" ) + ) else if "!VS_VERSION!" == "15" ( + if "!ARCH!" == "amd64" ( + set CMAKE_GENERATOR="Visual Studio 15 Win64" + ) else if "!ARCH!" == "arm" ( + set CMAKE_GENERATOR="Visual Studio 15 ARM" + set CMAKE_GENERATOR_HOST="Visual Studio 15" + ) else ( + set CMAKE_GENERATOR="Visual Studio 15" + ) ) ) else if /I "%1" == "RTC" ( echo Runtime checks enabled

1 0

[tfaber] 73681: [LIBUSB] - Avoid pointless assignment in CDMAMemoryManager::Initialize. CID 515285
by tfaber＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: tfaber Date: Sat Feb 4 18:36:13 2017 New Revision: 73681 URL: http://svn.reactos.org/svn/reactos?rev=73681&view=rev Log: [LIBUSB] - Avoid pointless assignment in CDMAMemoryManager::Initialize. CID 515285 Modified: trunk/reactos/sdk/lib/drivers/libusb/memory_manager.cpp Modified: trunk/reactos/sdk/lib/drivers/libusb/memory_manager.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/drivers/libusb/mem… ============================================================================== --- trunk/reactos/sdk/lib/drivers/libusb/memory_manager.cpp [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/drivers/libusb/memory_manager.cpp [iso-8859-1] Sat Feb 4 18:36:13 2017 @@ -118,7 +118,6 @@ m_PhysicalAddress = PhysicalAddress; m_VirtualBase = VirtualBase; m_DmaBufferSize = DmaBufferSize; - m_BitmapBuffer = m_BitmapBuffer; m_Lock = Lock; m_BlockSize = DefaultBlockSize;

1 0

[ion] 73680: [CONFIGURE]: Hack-support VS15 (VS 2017)
by ion＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: ion Date: Sat Feb 4 17:59:32 2017 New Revision: 73680 URL: http://svn.reactos.org/svn/reactos?rev=73680&view=rev Log: [CONFIGURE]: Hack-support VS15 (VS 2017) Modified: trunk/reactos/configure.cmd Modified: trunk/reactos/configure.cmd URL: http://svn.reactos.org/svn/reactos/trunk/reactos/configure.cmd?rev=73680&r1… ============================================================================== --- trunk/reactos/configure.cmd [iso-8859-1] (original) +++ trunk/reactos/configure.cmd [iso-8859-1] Sat Feb 4 17:59:32 2017 @@ -58,6 +58,7 @@ cl 2>&1 | find "17.00." > NUL && set VS_VERSION=11 cl 2>&1 | find "18.00." > NUL && set VS_VERSION=12 cl 2>&1 | find "19.00." > NUL && set VS_VERSION=14 + cl 2>&1 | find "19.10." > NUL && set VS_VERSION=14 if not defined VS_VERSION ( echo Error: Visual Studio version too old or version detection failed. endlocal

1 0

[pschweitzer] 73679: [FASTFAT] In vfatMakeFCBFromDirEntry(), handle vfatFCBInitializeCacheFromVolume() failure
by pschweitzer＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: pschweitzer Date: Sat Feb 4 17:54:38 2017 New Revision: 73679 URL: http://svn.reactos.org/svn/reactos?rev=73679&view=rev Log: [FASTFAT] In vfatMakeFCBFromDirEntry(), handle vfatFCBInitializeCacheFromVolume() failure Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c Modified: trunk/reactos/drivers/filesystems/fastfat/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fcb.c [iso-8859-1] Sat Feb 4 17:54:38 2017 @@ -728,7 +728,13 @@ rcFCB->RefCount = 1; if (vfatFCBIsDirectory(rcFCB)) { - vfatFCBInitializeCacheFromVolume(vcb, rcFCB); + Status = vfatFCBInitializeCacheFromVolume(vcb, rcFCB); + if (!NT_SUCCESS(Status)) + { + vfatReleaseFCB(vcb, rcFCB); + ExFreePool(NameU.Buffer); + return Status; + } } rcFCB->parentFcb = directoryFCB; InsertTailList(&directoryFCB->ParentListHead, &rcFCB->ParentListEntry);

1 0

[pschweitzer] 73678: [FASTFAT] Drop a hack that seems no longer needed
by pschweitzer＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: pschweitzer Date: Sat Feb 4 17:52:39 2017 New Revision: 73678 URL: http://svn.reactos.org/svn/reactos?rev=73678&view=rev Log: [FASTFAT] Drop a hack that seems no longer needed Modified: trunk/reactos/drivers/filesystems/fastfat/close.c Modified: trunk/reactos/drivers/filesystems/fastfat/close.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/close.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/close.c [iso-8859-1] Sat Feb 4 17:52:39 2017 @@ -86,13 +86,7 @@ IrpContext->Irp->IoStatus.Information = 0; return STATUS_SUCCESS; } -#if 0 - /* There occurs a dead look at the call to CcRosDeleteFileCache/ObDereferenceObject/VfatClose - in CmLazyCloseThreadMain if VfatClose is execute asynchronous in a worker thread. */ if (!ExAcquireResourceExclusiveLite(&IrpContext->DeviceExt->DirResource, BooleanFlagOn(IrpContext->Flags, IRPCONTEXT_CANWAIT))) -#else - if (!ExAcquireResourceExclusiveLite(&IrpContext->DeviceExt->DirResource, TRUE)) -#endif { return VfatMarkIrpContextForQueue(IrpContext); }

1 0

[tfaber] 73677: [BOOTLIB] - Zero the correct structure in EtfsOpen. CID 1341378
by tfaber＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: tfaber Date: Sat Feb 4 17:41:14 2017 New Revision: 73677 URL: http://svn.reactos.org/svn/reactos?rev=73677&view=rev Log: [BOOTLIB] - Zero the correct structure in EtfsOpen. CID 1341378 Modified: trunk/reactos/boot/environ/lib/io/etfs.c Modified: trunk/reactos/boot/environ/lib/io/etfs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/io/etfs.c… ============================================================================== --- trunk/reactos/boot/environ/lib/io/etfs.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/lib/io/etfs.c [iso-8859-1] Sat Feb 4 17:41:14 2017 @@ -601,7 +601,7 @@ } /* Zero it out */ - RtlZeroMemory(NewFile, sizeof(*EtfsFile)); + RtlZeroMemory(EtfsFile, sizeof(*EtfsFile)); /* Capture the device ID of the directory */ NewFile->DeviceId = Directory->DeviceId;

1 0

[tfaber] 73676: [SYSDM] - Fix wrong sizeof expression in DeleteHardwareProfile. CID 1322188
by tfaber＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: tfaber Date: Sat Feb 4 17:27:49 2017 New Revision: 73676 URL: http://svn.reactos.org/svn/reactos?rev=73676&view=rev Log: [SYSDM] - Fix wrong sizeof expression in DeleteHardwareProfile. CID 1322188 Modified: trunk/reactos/dll/cpl/sysdm/hardprof.c Modified: trunk/reactos/dll/cpl/sysdm/hardprof.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/sysdm/hardprof.c?r… ============================================================================== --- trunk/reactos/dll/cpl/sysdm/hardprof.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/sysdm/hardprof.c [iso-8859-1] Sat Feb 4 17:27:49 2017 @@ -327,7 +327,7 @@ { RtlMoveMemory(&pProfileData->pProfiles[pProfileData->dwSelectedProfileIndex], &pProfileData->pProfiles[pProfileData->dwSelectedProfileIndex + 1], - (pProfileData->dwProfileCount - pProfileData->dwSelectedProfileIndex - 1) * sizeof(PPROFILE)); + (pProfileData->dwProfileCount - pProfileData->dwSelectedProfileIndex - 1) * sizeof(PROFILE)); } else {

1 0

[tfaber] 73675: [BOOTLIB] - Fix operator precedence in call to MmMdAddDescriptorToList. CID 1341191.
by tfaber＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: tfaber Date: Sat Feb 4 17:00:26 2017 New Revision: 73675 URL: http://svn.reactos.org/svn/reactos?rev=73675&view=rev Log: [BOOTLIB] - Fix operator precedence in call to MmMdAddDescriptorToList. CID 1341191. Modified: trunk/reactos/boot/environ/lib/firmware/efi/firmware.c Modified: trunk/reactos/boot/environ/lib/firmware/efi/firmware.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/firmware/… ============================================================================== --- trunk/reactos/boot/environ/lib/firmware/efi/firmware.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/lib/firmware/efi/firmware.c [iso-8859-1] Sat Feb 4 17:00:26 2017 @@ -1680,8 +1680,8 @@ Status = MmMdAddDescriptorToList(MemoryMap, Descriptor, BL_MM_ADD_DESCRIPTOR_TRUNCATE_FLAG | - (Flags & BL_MM_FLAG_REQUEST_COALESCING) ? - BL_MM_ADD_DESCRIPTOR_COALESCE_FLAG : 0); + ((Flags & BL_MM_FLAG_REQUEST_COALESCING) ? + BL_MM_ADD_DESCRIPTOR_COALESCE_FLAG : 0)); if (!NT_SUCCESS(Status)) { EfiPrintf(L"Failed to add full descriptor: %lx\r\n", Status);

1 0

[spetreolle] 73674: [STOBJECT] Add a partial French translation. Remove hardcoded string. CORE-12490 #resolve
by spetreolle＠svn.reactos.org 04 Feb '17

04 Feb '17

Author: spetreolle Date: Sat Feb 4 16:12:15 2017 New Revision: 73674 URL: http://svn.reactos.org/svn/reactos?rev=73674&view=rev Log: [STOBJECT] Add a partial French translation. Remove hardcoded string. CORE-12490 #resolve Added: trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc - copied, changed from r73673, trunk/reactos/dll/shellext/stobject/lang/en-US.rc Modified: trunk/reactos/dll/shellext/stobject/stobject.rc trunk/reactos/dll/shellext/stobject/volume.cpp Copied: trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc (from r73673, trunk/reactos/dll/shellext/stobject/lang/en-US.rc) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang… ============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc [iso-8859-1] Sat Feb 4 16:12:15 2017 @@ -1,4 +1,4 @@ -LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US +LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL IDD_POWER_METER DIALOGEX 0, 0, 252, 218 STYLE DS_SHELLFONT | DS_MODALFRAME | DS_CENTER | WS_POPUP | WS_CAPTION | WS_SYSMENU @@ -6,9 +6,9 @@ CAPTION "Power Meter" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Power status", 1001, "Button", BS_GROUPBOX | WS_CHILD | WS_VISIBLE, 9, 20, 234, 189 - CONTROL "&Always show icon on the taskbar.", 1002, "Button", BS_AUTOCHECKBOX | WS_CHILD | WS_VISIBLE | WS_GROUP | WS_TABSTOP, 6, 6, 120, 10 - CONTROL "Show details for each &battery.", 1003, "Button", BS_AUTOCHECKBOX | WS_CHILD | WS_VISIBLE | WS_GROUP | WS_TABSTOP, 135, 6, 120, 8 + CONTROL "Etat de l'alimentation", 1001, "Button", BS_GROUPBOX | WS_CHILD | WS_VISIBLE, 9, 20, 234, 189 + CONTROL "&Toujours afficher l'icone.", 1002, "Button", BS_AUTOCHECKBOX | WS_CHILD | WS_VISIBLE | WS_GROUP | WS_TABSTOP, 6, 6, 120, 10 + CONTROL "Afficher les dÃ©tails pour chaque &batterie.", 1003, "Button", BS_AUTOCHECKBOX | WS_CHILD | WS_VISIBLE | WS_GROUP | WS_TABSTOP, 135, 6, 120, 8 CONTROL "", 1000, "Static", SS_LEFT | WS_CHILD | WS_GROUP, 11, 29, 229, 178 END @@ -37,9 +37,9 @@ //Volume related strings IDS_VOL_VOLUME "Volume" - IDS_VOL_ADJUST "&Adjust Audio Properties" - IDS_VOL_OPEN "&Open Volume Control" - IDS_VOL_MUTED "Volume (muted)" + IDS_VOL_ADJUST "&Ajuster les propriÃ©tÃ©s audio" + IDS_VOL_OPEN "&Ouvrir le controle du volume" + IDS_VOL_MUTED "Volume (muet)" //Keyboard-Mouse related strings IDS_KEYS_STICKY "StickyKeys" Modified: trunk/reactos/dll/shellext/stobject/stobject.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/stob… ============================================================================== --- trunk/reactos/dll/shellext/stobject/stobject.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/stobject.rc [iso-8859-1] Sat Feb 4 16:12:15 2017 @@ -43,6 +43,9 @@ #ifdef LANGUAGE_ES_ES #include "lang/es-ES.rc" #endif +#ifdef LANGUAGE_FR_FR + #include "lang/fr-FR.rc" +#endif #ifdef LANGUAGE_IT_IT #include "lang/it-IT.rc" #endif Modified: trunk/reactos/dll/shellext/stobject/volume.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/volu… ============================================================================== --- trunk/reactos/dll/shellext/stobject/volume.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/volume.cpp [iso-8859-1] Sat Feb 4 16:12:15 2017 @@ -143,6 +143,7 @@ HRESULT STDMETHODCALLTYPE Volume_Init(_In_ CSysTray * pSysTray) { HRESULT hr; + WCHAR strTooltip[128]; TRACE("Volume_Init\n"); @@ -166,7 +167,8 @@ else icon = g_hIconVolume; - return pSysTray->NotifyIcon(NIM_ADD, ID_ICON_VOLUME, icon, L"Volume Control"); + LoadStringW(g_hInstance, IDS_VOL_VOLUME, strTooltip, _countof(strTooltip)); + return pSysTray->NotifyIcon(NIM_ADD, ID_ICON_VOLUME, icon, strTooltip); } HRESULT STDMETHODCALLTYPE Volume_Update(_In_ CSysTray * pSysTray)

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs