Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hbelusca] 73233: [LSASRV] - No need to hardcode the name of the dll in the GetModuleHandleW call; - Use ARRAYSIZE instead of hardcoding string buffer sizes; - When initializing the "Network Sid", ...
by hbelusca＠svn.reactos.org 14 Nov '16

14 Nov '16

Author: hbelusca Date: Mon Nov 14 16:19:22 2016 New Revision: 73233 URL: http://svn.reactos.org/svn/reactos?rev=73233&view=rev Log: [LSASRV] - No need to hardcode the name of the dll in the GetModuleHandleW call; - Use ARRAYSIZE instead of hardcoding string buffer sizes; - When initializing the "Network Sid", use the correct localized string. Modified: trunk/reactos/dll/win32/lsasrv/lookup.c Modified: trunk/reactos/dll/win32/lsasrv/lookup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/lookup.c?… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/lookup.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/lookup.c [iso-8859-1] Mon Nov 14 16:19:22 2016 @@ -186,12 +186,12 @@ InitializeListHead(&WellKnownSidListHead); - hInstance = GetModuleHandleW(L"lsasrv.dll"); + hInstance = GetModuleHandleW(NULL); /* NT Authority */ - LsapLoadString(hInstance, IDS_NT_AUTHORITY, szAccountName, 80); - LsapLoadString(hInstance, IDS_NT_AUTHORITY, szDomainName, 80); + LsapLoadString(hInstance, IDS_NT_AUTHORITY, szAccountName, ARRAYSIZE(szAccountName)); + LsapLoadString(hInstance, IDS_NT_AUTHORITY, szDomainName, ARRAYSIZE(szDomainName)); LsapCreateSid(&NtAuthority, 0, NULL, @@ -201,7 +201,7 @@ NULL); /* Null Sid */ - LsapLoadString(hInstance, IDS_NULL_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_NULL_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_NULL_RID; LsapCreateSid(&NullSidAuthority, @@ -213,7 +213,7 @@ NULL); /* World Sid */ - LsapLoadString(hInstance, IDS_WORLD_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_WORLD_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_WORLD_RID; LsapCreateSid(&WorldSidAuthority, @@ -225,7 +225,7 @@ &LsapWorldSid); /* Local Sid */ - LsapLoadString(hInstance, IDS_LOCAL_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_LOCAL_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_LOCAL_RID; LsapCreateSid(&LocalSidAuthority, @@ -237,7 +237,7 @@ NULL); /* Creator Owner Sid */ - LsapLoadString(hInstance, IDS_CREATOR_OWNER_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_CREATOR_OWNER_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_CREATOR_OWNER_RID; LsapCreateSid(&CreatorSidAuthority, @@ -249,7 +249,7 @@ NULL); /* Creator Group Sid */ - LsapLoadString(hInstance, IDS_CREATOR_GROUP_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_CREATOR_GROUP_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_CREATOR_GROUP_RID; LsapCreateSid(&CreatorSidAuthority, @@ -261,7 +261,7 @@ NULL); /* Creator Owner Server Sid */ - LsapLoadString(hInstance, IDS_CREATOR_OWNER_SERVER_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_CREATOR_OWNER_SERVER_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_CREATOR_OWNER_SERVER_RID; LsapCreateSid(&CreatorSidAuthority, @@ -273,7 +273,7 @@ NULL); /* Creator Group Server Sid */ - LsapLoadString(hInstance, IDS_CREATOR_GROUP_SERVER_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_CREATOR_GROUP_SERVER_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_CREATOR_GROUP_SERVER_RID; LsapCreateSid(&CreatorSidAuthority, @@ -285,8 +285,8 @@ NULL); /* Dialup Sid */ - LsapLoadString(hInstance, IDS_DIALUP_RID, szAccountName, 80); - LsapLoadString(hInstance, IDS_NT_AUTHORITY, szDomainName, 80); + LsapLoadString(hInstance, IDS_DIALUP_RID, szAccountName, ARRAYSIZE(szAccountName)); + LsapLoadString(hInstance, IDS_NT_AUTHORITY, szDomainName, ARRAYSIZE(szDomainName)); SubAuthorities[0] = SECURITY_DIALUP_RID; LsapCreateSid(&NtAuthority, @@ -298,7 +298,7 @@ NULL); /* Network Sid */ - LsapLoadString(hInstance, IDS_DIALUP_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_NETWORK_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_NETWORK_RID; LsapCreateSid(&NtAuthority, @@ -310,7 +310,7 @@ &LsapNetworkSid); /* Batch Sid*/ - LsapLoadString(hInstance, IDS_BATCH_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_BATCH_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BATCH_RID; LsapCreateSid(&NtAuthority, @@ -322,7 +322,7 @@ &LsapBatchSid); /* Interactive Sid */ - LsapLoadString(hInstance, IDS_INTERACTIVE_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_INTERACTIVE_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_INTERACTIVE_RID; LsapCreateSid(&NtAuthority, @@ -334,7 +334,7 @@ &LsapInteractiveSid); /* Service Sid */ - LsapLoadString(hInstance, IDS_SERVICE_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_SERVICE_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_SERVICE_RID; LsapCreateSid(&NtAuthority, @@ -346,7 +346,7 @@ &LsapServiceSid); /* Anonymous Logon Sid */ - LsapLoadString(hInstance, IDS_ANONYMOUS_LOGON_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_ANONYMOUS_LOGON_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_ANONYMOUS_LOGON_RID; LsapCreateSid(&NtAuthority, @@ -358,7 +358,7 @@ NULL); /* Proxy Sid */ - LsapLoadString(hInstance, IDS_PROXY_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_PROXY_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_PROXY_RID; LsapCreateSid(&NtAuthority, @@ -370,7 +370,7 @@ NULL); /* Enterprise Controllers Sid */ - LsapLoadString(hInstance, IDS_ENTERPRISE_CONTROLLERS_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_ENTERPRISE_CONTROLLERS_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_ENTERPRISE_CONTROLLERS_RID; LsapCreateSid(&NtAuthority, @@ -382,7 +382,7 @@ NULL); /* Principal Self Sid */ - LsapLoadString(hInstance, IDS_PRINCIPAL_SELF_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_PRINCIPAL_SELF_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_PRINCIPAL_SELF_RID; LsapCreateSid(&NtAuthority, @@ -394,7 +394,7 @@ NULL); /* Authenticated Users Sid */ - LsapLoadString(hInstance, IDS_AUTHENTICATED_USER_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_AUTHENTICATED_USER_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_AUTHENTICATED_USER_RID; LsapCreateSid(&NtAuthority, @@ -406,7 +406,7 @@ NULL); /* Restricted Code Sid */ - LsapLoadString(hInstance, IDS_RESTRICTED_CODE_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_RESTRICTED_CODE_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_RESTRICTED_CODE_RID; LsapCreateSid(&NtAuthority, @@ -418,7 +418,7 @@ NULL); /* Terminal Server Sid */ - LsapLoadString(hInstance, IDS_TERMINAL_SERVER_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_TERMINAL_SERVER_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_TERMINAL_SERVER_RID; LsapCreateSid(&NtAuthority, @@ -430,7 +430,7 @@ NULL); /* Remote Logon Sid */ - LsapLoadString(hInstance, IDS_REMOTE_LOGON_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_REMOTE_LOGON_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_REMOTE_LOGON_RID; LsapCreateSid(&NtAuthority, @@ -442,7 +442,7 @@ NULL); /* This Organization Sid */ - LsapLoadString(hInstance, IDS_THIS_ORGANIZATION_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_THIS_ORGANIZATION_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_THIS_ORGANIZATION_RID; LsapCreateSid(&NtAuthority, @@ -454,7 +454,7 @@ NULL); /* Local System Sid */ - LsapLoadString(hInstance, IDS_LOCAL_SYSTEM_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_LOCAL_SYSTEM_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_LOCAL_SYSTEM_RID; LsapCreateSid(&NtAuthority, @@ -466,7 +466,7 @@ &LsapLocalSystemSid); /* Local Service Sid */ - LsapLoadString(hInstance, IDS_LOCAL_SERVICE_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_LOCAL_SERVICE_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_LOCAL_SERVICE_RID; LsapCreateSid(&NtAuthority, @@ -486,7 +486,7 @@ NULL); /* Network Service Sid */ - LsapLoadString(hInstance, IDS_NETWORK_SERVICE_RID, szAccountName, 80); + LsapLoadString(hInstance, IDS_NETWORK_SERVICE_RID, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_NETWORK_SERVICE_RID; LsapCreateSid(&NtAuthority, @@ -506,8 +506,8 @@ NULL); /* Builtin Domain Sid */ - LsapLoadString(hInstance, IDS_BUILTIN_DOMAIN_RID, szAccountName, 80); - LsapLoadString(hInstance, IDS_BUILTIN_DOMAIN_RID, szDomainName, 80); + LsapLoadString(hInstance, IDS_BUILTIN_DOMAIN_RID, szAccountName, ARRAYSIZE(szAccountName)); + LsapLoadString(hInstance, IDS_BUILTIN_DOMAIN_RID, szDomainName, ARRAYSIZE(szDomainName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; LsapCreateSid(&NtAuthority, @@ -519,7 +519,7 @@ NULL); /* Administrators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_ADMINS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_ADMINS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_ADMINS; @@ -532,7 +532,7 @@ &LsapAdministratorsSid); /* Users Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_USERS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_USERS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_USERS; @@ -545,7 +545,7 @@ NULL); /* Guests Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_GUESTS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_GUESTS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_GUESTS; @@ -558,7 +558,7 @@ NULL); /* Power User Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_POWER_USERS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_POWER_USERS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_POWER_USERS; @@ -571,7 +571,7 @@ NULL); /* Account Operators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_ACCOUNT_OPS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_ACCOUNT_OPS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_ACCOUNT_OPS; @@ -584,7 +584,7 @@ NULL); /* System Operators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_SYSTEM_OPS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_SYSTEM_OPS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_SYSTEM_OPS; @@ -597,7 +597,7 @@ NULL); /* Print Operators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_PRINT_OPS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_PRINT_OPS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_PRINT_OPS; @@ -610,7 +610,7 @@ NULL); /* Backup Operators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_BACKUP_OPS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_BACKUP_OPS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_BACKUP_OPS; @@ -623,7 +623,7 @@ NULL); /* Replicators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_REPLICATOR, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_REPLICATOR, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_REPLICATOR; @@ -636,7 +636,7 @@ NULL); /* RAS Servers Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_RAS_SERVERS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_RAS_SERVERS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_RAS_SERVERS; @@ -649,7 +649,7 @@ NULL); /* Pre-Windows 2000 Compatible Access Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_PREW2KCOMPACCESS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_PREW2KCOMPACCESS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_PREW2KCOMPACCESS; @@ -662,7 +662,7 @@ NULL); /* Remote Desktop Users Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_REMOTE_DESKTOP_USERS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_REMOTE_DESKTOP_USERS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_REMOTE_DESKTOP_USERS; @@ -675,7 +675,7 @@ NULL); /* Network Configuration Operators Alias Sid */ - LsapLoadString(hInstance, IDS_ALIAS_RID_NETWORK_CONFIGURATION_OPS, szAccountName, 80); + LsapLoadString(hInstance, IDS_ALIAS_RID_NETWORK_CONFIGURATION_OPS, szAccountName, ARRAYSIZE(szAccountName)); SubAuthorities[0] = SECURITY_BUILTIN_DOMAIN_RID; SubAuthorities[1] = DOMAIN_ALIAS_RID_NETWORK_CONFIGURATION_OPS;

1 0

[hbelusca] 73232: [LSASRV] - Remove trailing whitespace; - Tabs --> Spaces; - Don't always hardcode parameters sizeofs; - Use ARRAYSIZE where applicable; - Use UNICODE_NULL
by hbelusca＠svn.reactos.org 14 Nov '16

14 Nov '16

Author: hbelusca Date: Mon Nov 14 16:17:42 2016 New Revision: 73232 URL: http://svn.reactos.org/svn/reactos?rev=73232&view=rev Log: [LSASRV] - Remove trailing whitespace; - Tabs --> Spaces; - Don't always hardcode parameters sizeofs; - Use ARRAYSIZE where applicable; - Use UNICODE_NULL Modified: trunk/reactos/dll/win32/lsasrv/authpackage.c trunk/reactos/dll/win32/lsasrv/database.c trunk/reactos/dll/win32/lsasrv/dssetup.c trunk/reactos/dll/win32/lsasrv/privileges.c trunk/reactos/dll/win32/lsasrv/registry.c trunk/reactos/dll/win32/lsasrv/security.c trunk/reactos/dll/win32/lsasrv/service.c Modified: trunk/reactos/dll/win32/lsasrv/authpackage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/authpacka… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/authpackage.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/authpackage.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -950,7 +950,7 @@ Groups->GroupCount = 1; Groups->Groups[0].Sid = Sid; - Groups->Groups[0].Attributes = + Groups->Groups[0].Attributes = SE_GROUP_ENABLED | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_MANDATORY; *TokenGroups = Groups; @@ -985,7 +985,7 @@ } Groups->Groups[Groups->GroupCount].Sid = Sid; - Groups->Groups[Groups->GroupCount].Attributes = + Groups->Groups[Groups->GroupCount].Attributes = SE_GROUP_ENABLED | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_MANDATORY; Groups->GroupCount++; Modified: trunk/reactos/dll/win32/lsasrv/database.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/database.… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/database.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/database.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -254,11 +254,11 @@ /* Initialize the audit log attribute */ AuditLogInfo.AuditLogPercentFull = 0; - AuditLogInfo.MaximumLogSize = 0; // DWORD - AuditLogInfo.AuditRetentionPeriod.QuadPart = 0; // LARGE_INTEGER - AuditLogInfo.AuditLogFullShutdownInProgress = 0; // BYTE - AuditLogInfo.TimeToShutdown.QuadPart = 0; // LARGE_INTEGER - AuditLogInfo.NextAuditRecordId = 0; // DWORD + AuditLogInfo.MaximumLogSize = 0; // DWORD + AuditLogInfo.AuditRetentionPeriod.QuadPart = 0; // LARGE_INTEGER + AuditLogInfo.AuditLogFullShutdownInProgress = 0; // BYTE + AuditLogInfo.TimeToShutdown.QuadPart = 0; // LARGE_INTEGER + AuditLogInfo.NextAuditRecordId = 0; // DWORD /* Initialize the Audit Events attribute */ AuditEventsInfo = RtlAllocateHeap(RtlGetProcessHeap(), @@ -273,7 +273,7 @@ AuditEventsInfo->AuditEvents[i] = 0; /* Initialize the DNS Domain GUID attribute */ - memset(&DnsDomainGuid, 0, sizeof(GUID)); + RtlZeroMemory(&DnsDomainGuid, sizeof(DnsDomainGuid)); /* Initialize the modification attribute */ ModificationInfo.ModifiedId.QuadPart = 0; @@ -323,31 +323,31 @@ LsapSetObjectAttribute(PolicyObject, L"DefQuota", &QuotaInfo, - sizeof(POLICY_DEFAULT_QUOTA_INFO)); + sizeof(QuotaInfo)); /* Set the modification attribute */ LsapSetObjectAttribute(PolicyObject, L"PolMod", &ModificationInfo, - sizeof(POLICY_MODIFICATION_INFO)); + sizeof(ModificationInfo)); /* Set the audit full attribute */ LsapSetObjectAttribute(PolicyObject, L"PolAdtFl", &AuditFullInfo, - sizeof(POLICY_AUDIT_FULL_QUERY_INFO)); + sizeof(AuditFullInfo)); /* Set the audit log attribute */ LsapSetObjectAttribute(PolicyObject, L"PolAdtLg", &AuditLogInfo, - sizeof(POLICY_AUDIT_LOG_INFO)); + sizeof(AuditLogInfo)); /* Set the audit events attribute */ LsapSetObjectAttribute(PolicyObject, L"PolAdtEv", AuditEventsInfo, - sizeof(LSAP_POLICY_AUDIT_EVENTS_DATA)); + sizeof(*AuditEventsInfo)); /* Set the DNS Domain Name attribute */ LsapSetObjectAttribute(PolicyObject, @@ -365,7 +365,7 @@ LsapSetObjectAttribute(PolicyObject, L"PolDnDmG", &DnsDomainGuid, - sizeof(GUID)); + sizeof(DnsDomainGuid)); /* Set the Security Descriptor */ LsapSetObjectAttribute(PolicyObject, @@ -912,7 +912,7 @@ { Status = LsapRegEnumerateSubKey(DbObject->KeyHandle, Index, - 64 * sizeof(WCHAR), + sizeof(KeyName), KeyName); if (!NT_SUCCESS(Status)) break; @@ -1081,4 +1081,3 @@ } /* EOF */ - Modified: trunk/reactos/dll/win32/lsasrv/dssetup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/dssetup.c… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/dssetup.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/dssetup.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -46,7 +46,7 @@ ULONG Size; NTSTATUS Status; - ZeroMemory(&ObjectAttributes, sizeof(ObjectAttributes)); + RtlZeroMemory(&ObjectAttributes, sizeof(ObjectAttributes)); Status = LsarOpenPolicy(NULL, &ObjectAttributes, POLICY_VIEW_LOCAL_INFORMATION, @@ -142,7 +142,7 @@ { NET_API_STATUS ret; - TRACE("DsRolerGetPrimaryDomainInformation(%p, %d, %p)\n", + TRACE("DsRolerGetPrimaryDomainInformation(%p, %d, %p)\n", hBinding, InfoLevel, DomainInfo); switch (InfoLevel) Modified: trunk/reactos/dll/win32/lsasrv/privileges.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/privilege… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/privileges.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/privileges.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -88,7 +88,7 @@ return STATUS_NO_SUCH_PRIVILEGE; } - for (Priv = 0; Priv < sizeof(WellKnownPrivileges) / sizeof(WellKnownPrivileges[0]); Priv++) + for (Priv = 0; Priv < ARRAYSIZE(WellKnownPrivileges); Priv++) { if (Value->LowPart == WellKnownPrivileges[Priv].Luid.LowPart && Value->HighPart == WellKnownPrivileges[Priv].Luid.HighPart) @@ -162,7 +162,7 @@ if (Name->Length == 0 || Name->Buffer == NULL) return NULL; - for (Priv = 0; Priv < sizeof(WellKnownPrivileges) / sizeof(WellKnownPrivileges[0]); Priv++) + for (Priv = 0; Priv < ARRAYSIZE(WellKnownPrivileges); Priv++) { if (_wcsicmp(Name->Buffer, WellKnownPrivileges[Priv].Name) == 0) return (PLUID)&(WellKnownPrivileges[Priv].Luid); @@ -187,7 +187,7 @@ EnumIndex = *EnumerationContext; - for (; EnumIndex < sizeof(WellKnownPrivileges) / sizeof(WellKnownPrivileges[0]); EnumIndex++) + for (; EnumIndex < ARRAYSIZE(WellKnownPrivileges); EnumIndex++) { TRACE("EnumIndex: %lu\n", EnumIndex); TRACE("Privilege Name: %S\n", WellKnownPrivileges[EnumIndex].Name); @@ -276,7 +276,7 @@ PRPC_UNICODE_STRING NameBuffer; ULONG i; - for (i = 0; i < sizeof(WellKnownRights) / sizeof(WellKnownRights[0]); i++) + for (i = 0; i < ARRAYSIZE(WellKnownRights); i++) { if (WellKnownRights[i].Flag == RightValue) { @@ -315,7 +315,7 @@ if (Name->Length == 0 || Name->Buffer == NULL) return 0; - for (i = 0; i < sizeof(WellKnownRights) / sizeof(WellKnownRights[0]); i++) + for (i = 0; i < ARRAYSIZE(WellKnownRights); i++) { if (_wcsicmp(Name->Buffer, WellKnownRights[i].Name) == 0) return WellKnownRights[i].Flag; Modified: trunk/reactos/dll/win32/lsasrv/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/registry.… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/registry.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/registry.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -132,7 +132,7 @@ KeyInfo->NameLength); /* Terminate the string */ - Buffer[KeyInfo->NameLength / sizeof(WCHAR)] = 0; + Buffer[KeyInfo->NameLength / sizeof(WCHAR)] = UNICODE_NULL; } else { @@ -268,7 +268,7 @@ ValueInfo->NameLength); /* Terminate the string */ - Name[ValueInfo->NameLength / sizeof(WCHAR)] = 0; + Name[ValueInfo->NameLength / sizeof(WCHAR)] = UNICODE_NULL; } else { @@ -295,7 +295,7 @@ { WCHAR *ptr = (WCHAR *)((ULONG_PTR)Data + ValueInfo->DataLength); if ((ptr > (WCHAR *)Data) && ptr[-1]) - *ptr = 0; + *ptr = UNICODE_NULL; } } else @@ -383,7 +383,7 @@ { WCHAR *ptr = (WCHAR *)((ULONG_PTR)Data + ValueInfo->DataLength); if ((ptr > (WCHAR *)Data) && ptr[-1]) - *ptr = 0; + *ptr = UNICODE_NULL; } } Modified: trunk/reactos/dll/win32/lsasrv/security.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/security.… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/security.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/security.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -125,7 +125,7 @@ /* Allocate and initialize the DACL */ DaclSize = sizeof(ACL) + - sizeof(ACCESS_DENIED_ACE) - sizeof(ULONG) + RtlLengthSid(AnonymousSid) + + sizeof(ACCESS_DENIED_ACE) - sizeof(ULONG) + RtlLengthSid(AnonymousSid) + sizeof(ACCESS_ALLOWED_ACE) - sizeof(ULONG) + RtlLengthSid(AdministratorsSid) + sizeof(ACCESS_ALLOWED_ACE) - sizeof(ULONG) + RtlLengthSid(EveryoneSid) + sizeof(ACCESS_ALLOWED_ACE) - sizeof(ULONG) + RtlLengthSid(AnonymousSid) + Modified: trunk/reactos/dll/win32/lsasrv/service.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/service.c… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/service.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/service.c [iso-8859-1] Mon Nov 14 16:17:42 2016 @@ -21,4 +21,4 @@ return STATUS_SUCCESS; } -/* EOF */ +/* EOF */

1 0

[phater] 73231: [MSAFD] When out of band data is inlined, calling WSPRecv/WSPRecvFrom with flag MSG_OOB is invalid, return WSAEINVAL. CORE-12104
by phater＠svn.reactos.org 14 Nov '16

14 Nov '16

Author: phater Date: Mon Nov 14 14:10:48 2016 New Revision: 73231 URL: http://svn.reactos.org/svn/reactos?rev=73231&view=rev Log: [MSAFD] When out of band data is inlined, calling WSPRecv/WSPRecvFrom with flag MSG_OOB is invalid, return WSAEINVAL. CORE-12104 Modified: trunk/reactos/dll/win32/msafd/misc/sndrcv.c Modified: trunk/reactos/dll/win32/msafd/misc/sndrcv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msafd/misc/sndrc… ============================================================================== --- trunk/reactos/dll/win32/msafd/misc/sndrcv.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msafd/misc/sndrcv.c [iso-8859-1] Mon Nov 14 14:10:48 2016 @@ -191,6 +191,12 @@ { if (lpErrno) *lpErrno = WSAEFAULT; + return SOCKET_ERROR; + } + if (Socket->SharedData->OobInline && ReceiveFlags && (*ReceiveFlags & MSG_OOB) != 0) + { + if (lpErrno) + *lpErrno = WSAEINVAL; return SOCKET_ERROR; } @@ -379,6 +385,12 @@ { if (lpErrno) *lpErrno = WSAEFAULT; + return SOCKET_ERROR; + } + if (Socket->SharedData->OobInline && ReceiveFlags && (*ReceiveFlags & MSG_OOB) != 0) + { + if (lpErrno) + *lpErrno = WSAEINVAL; return SOCKET_ERROR; }

1 0

[akhaldi] 73230: [LOCALMON] Russian translation by Nikolay Burshtyn aka amber. CORE-12363
by akhaldi＠svn.reactos.org 14 Nov '16

14 Nov '16

Author: akhaldi Date: Mon Nov 14 11:18:11 2016 New Revision: 73230 URL: http://svn.reactos.org/svn/reactos?rev=73230&view=rev Log: [LOCALMON] Russian translation by Nikolay Burshtyn aka amber. CORE-12363 Added: trunk/reactos/win32ss/printing/monitors/localmon/lang/ru-RU.rc (with props) Modified: trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc Added: trunk/reactos/win32ss/printing/monitors/localmon/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/printing/monitors/… ============================================================================== --- trunk/reactos/win32ss/printing/monitors/localmon/lang/ru-RU.rc (added) +++ trunk/reactos/win32ss/printing/monitors/localmon/lang/ru-RU.rc [iso-8859-1] Mon Nov 14 11:18:11 2016 @@ -0,0 +1,7 @@ +LANGUAGE LANG_RUSSIAN, SUBLANG_DEFAULT + +STRINGTABLE +BEGIN + IDS_LOCAL_PORT "ÐÐ¾ÐºÐ°Ð»ÑÐ½ÑÐ¹ Ð¿Ð¾ÑÑ" + IDS_LOCAL_MONITOR "ÐÐ¾ÐºÐ°Ð»ÑÐ½ÑÐ¹ Ð¼Ð¾Ð½Ð¸ÑÐ¾Ñ" +END Propchange: trunk/reactos/win32ss/printing/monitors/localmon/lang/ru-RU.rc ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/printing/monitors/… ============================================================================== --- trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc [iso-8859-1] (original) +++ trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc [iso-8859-1] Mon Nov 14 11:18:11 2016 @@ -26,4 +26,7 @@ #endif #ifdef LANGUAGE_IT_IT #include "lang/it-IT.rc" -#endif +#endif +#ifdef LANGUAGE_RU_RU + #include "lang/ru-RU.rc" +#endif

1 0

[akhaldi] 73229: [LOCALMON] Italian translation by Carlo Bramini. CORE-12363
by akhaldi＠svn.reactos.org 14 Nov '16

14 Nov '16

Author: akhaldi Date: Mon Nov 14 10:58:53 2016 New Revision: 73229 URL: http://svn.reactos.org/svn/reactos?rev=73229&view=rev Log: [LOCALMON] Italian translation by Carlo Bramini. CORE-12363 Added: trunk/reactos/win32ss/printing/monitors/localmon/lang/it-IT.rc (with props) Modified: trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc Added: trunk/reactos/win32ss/printing/monitors/localmon/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/printing/monitors/… ============================================================================== --- trunk/reactos/win32ss/printing/monitors/localmon/lang/it-IT.rc (added) +++ trunk/reactos/win32ss/printing/monitors/localmon/lang/it-IT.rc [iso-8859-1] Mon Nov 14 10:58:53 2016 @@ -0,0 +1,7 @@ +LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL + +STRINGTABLE +BEGIN + IDS_LOCAL_PORT "Porta locale" + IDS_LOCAL_MONITOR "Monitor locale" +END Propchange: trunk/reactos/win32ss/printing/monitors/localmon/lang/it-IT.rc ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/printing/monitors/… ============================================================================== --- trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc [iso-8859-1] (original) +++ trunk/reactos/win32ss/printing/monitors/localmon/localmon.rc [iso-8859-1] Mon Nov 14 10:58:53 2016 @@ -24,3 +24,6 @@ #ifdef LANGUAGE_EN_US #include "lang/en-US.rc" #endif +#ifdef LANGUAGE_IT_IT + #include "lang/it-IT.rc" +#endif

1 0

[mjansen] 73228: [ADVAPI32][ADVAPI32_APITEST] Fix incorrect parameter output uncovered by CORE-12333 #comment Please retest!
by mjansen＠svn.reactos.org 13 Nov '16

13 Nov '16

Author: mjansen Date: Sun Nov 13 18:11:14 2016 New Revision: 73228 URL: http://svn.reactos.org/svn/reactos?rev=73228&view=rev Log: [ADVAPI32][ADVAPI32_APITEST] Fix incorrect parameter output uncovered by CORE-12333 #comment Please retest! Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c trunk/rostests/apitests/advapi32/RegQueryValueExW.c Modified: trunk/reactos/dll/win32/advapi32/reg/reg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/reg/reg… ============================================================================== --- trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/reg/reg.c [iso-8859-1] Sun Nov 13 18:11:14 2016 @@ -4147,10 +4147,16 @@ if (!NT_SUCCESS(status) && status != STATUS_BUFFER_OVERFLOW) { // NT: Valid handles with inexistant/null values or invalid (but not NULL) handles sets type to REG_NONE - if ((status == STATUS_OBJECT_NAME_NOT_FOUND) ||(status == STATUS_INVALID_HANDLE && hkey)) + // On windows these conditions are likely to be side effects of the implementation... + if (status == STATUS_INVALID_HANDLE && hkey) { if (type) *type = REG_NONE; if (count) *count = 0; + } + else if (status == STATUS_OBJECT_NAME_NOT_FOUND) + { + if (type) *type = REG_NONE; + if (data == NULL && count) *count = 0; } goto done; } Modified: trunk/rostests/apitests/advapi32/RegQueryValueExW.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/advapi32/RegQuer… ============================================================================== --- trunk/rostests/apitests/advapi32/RegQueryValueExW.c [iso-8859-1] (original) +++ trunk/rostests/apitests/advapi32/RegQueryValueExW.c [iso-8859-1] Sun Nov 13 18:11:14 2016 @@ -303,6 +303,20 @@ ok(size == 46, "Expected size = 46, size is: %ld", size); ok(!wcscmp(data23, string22W), "Expected same string! data23: %S, string22W: %S", data23, string22W); + /* Ask for a var that doesnt exist. */ + SetLastError(0xdeadbeef); + size = sizeof(data23); + memset(data23, 0, sizeof(data23)); + type = 666; + ret = RegQueryValueExW(hkey_main, L"XXXXXYYYYYZZZZZZ", NULL, &type, (LPBYTE)data23, &size); + ok(ret == ERROR_FILE_NOT_FOUND, "RegQueryValueExW returned: %lx\n", ret); + ok(GetLastError() == 0xdeadbeef, "RegQueryValueExW returned: %lx\n", GetLastError()); + /* 2k3 leaves garbage */ + ok(type == REG_NONE || broken(type != REG_NONE && type != 666), "Expected REG_NONE, Type is: %ld\n", type); + ok(size == 46, "Expected size = 46, size is: %ld", size); + ok(!wcscmp(data23,L""), "Expected same string! data23: %S, ''", data23); + + RegCloseKey(hkey_main); RegCloseKey(subkey);

1 0

[tfaber] 73227: [KMTESTS:MM] - Skip NtCreateSection tests since they hang on testbot. ROSTESTS-248
by tfaber＠svn.reactos.org 13 Nov '16

13 Nov '16

Author: tfaber Date: Sun Nov 13 16:42:16 2016 New Revision: 73227 URL: http://svn.reactos.org/svn/reactos?rev=73227&view=rev Log: [KMTESTS:MM] - Skip NtCreateSection tests since they hang on testbot. ROSTESTS-248 Modified: trunk/rostests/kmtests/ntos_mm/NtCreateSection_user.c Modified: trunk/rostests/kmtests/ntos_mm/NtCreateSection_user.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/ntos_mm/NtCreateS… ============================================================================== --- trunk/rostests/kmtests/ntos_mm/NtCreateSection_user.c [iso-8859-1] (original) +++ trunk/rostests/kmtests/ntos_mm/NtCreateSection_user.c [iso-8859-1] Sun Nov 13 16:42:16 2016 @@ -20,6 +20,11 @@ UNICODE_STRING InitOnRW = RTL_CONSTANT_STRING(L"\\Device\\Kmtest-NtCreateSection\\InitOnRW"); UNICODE_STRING InvalidInit = RTL_CONSTANT_STRING(L"\\Device\\Kmtest-NtCreateSection\\InvalidInit"); + if (skip(0, "ROSTESTS-248: skipping kmtest:NtCreateSection because it hangs on testbot\n")) + { + return; + } + KmtLoadDriver(L"NtCreateSection", FALSE); KmtOpenDriver();

1 0

[akhaldi] 73226: [DRIVERS] Spelling fixes by Josh Soref. CORE-12286
by akhaldi＠svn.reactos.org 13 Nov '16

13 Nov '16

Author: akhaldi Date: Sun Nov 13 15:31:39 2016 New Revision: 73226 URL: http://svn.reactos.org/svn/reactos?rev=73226&view=rev Log: [DRIVERS] Spelling fixes by Josh Soref. CORE-12286 Modified: trunk/reactos/drivers/base/beep/beep.c trunk/reactos/drivers/base/bootvid/arm/bootvid.c trunk/reactos/drivers/base/bootvid/i386/bootvid.c trunk/reactos/drivers/base/bootvid/i386/vga.c trunk/reactos/drivers/base/kdcom/kddll.c trunk/reactos/drivers/base/kdcom/kdserial.c trunk/reactos/drivers/base/kdgdb/gdb_input.c trunk/reactos/drivers/base/kdgdb/kdgdb.h trunk/reactos/drivers/bus/acpi/busmgr/bus.c trunk/reactos/drivers/bus/acpi/busmgr/power.c trunk/reactos/drivers/bus/acpi/busmgr/system.c trunk/reactos/drivers/bus/acpi/busmgr/utils.c trunk/reactos/drivers/bus/acpi/buspdo.c trunk/reactos/drivers/bus/acpi/cmbatt/cmbatt.c trunk/reactos/drivers/bus/acpi/cmbatt/cmbatt.h trunk/reactos/drivers/bus/acpi/cmbatt/cmbpnp.c trunk/reactos/drivers/bus/acpi/include/acpi_bus.h trunk/reactos/drivers/bus/pci/pcidef.h trunk/reactos/drivers/bus/pcix/enum.c trunk/reactos/drivers/bus/pcix/hookhal.c trunk/reactos/drivers/bus/pcix/intrface/intrface.c trunk/reactos/drivers/bus/pcix/pci/ppbridge.c trunk/reactos/drivers/bus/pcix/power.c trunk/reactos/drivers/bus/pcix/utils.c trunk/reactos/drivers/filesystems/cdfs/fcb.c trunk/reactos/drivers/filesystems/cdfs_new/allocsup.c trunk/reactos/drivers/filesystems/cdfs_new/cd.h trunk/reactos/drivers/filesystems/cdfs_new/cddata.h trunk/reactos/drivers/filesystems/cdfs_new/cdstruc.h trunk/reactos/drivers/filesystems/cdfs_new/close.c trunk/reactos/drivers/filesystems/cdfs_new/deviosup.c trunk/reactos/drivers/filesystems/cdfs_new/dirctrl.c trunk/reactos/drivers/filesystems/cdfs_new/dirsup.c trunk/reactos/drivers/filesystems/cdfs_new/fsctrl.c trunk/reactos/drivers/filesystems/cdfs_new/namesup.c trunk/reactos/drivers/filesystems/cdfs_new/pathsup.c trunk/reactos/drivers/filesystems/cdfs_new/pnp.c trunk/reactos/drivers/filesystems/cdfs_new/resrcsup.c trunk/reactos/drivers/filesystems/cdfs_new/strucsup.c trunk/reactos/drivers/filesystems/cdfs_new/verfysup.c trunk/reactos/drivers/filesystems/cdfs_new/volinfo.c trunk/reactos/drivers/filesystems/cdfs_new/wdk_wnet_to_ros.diff trunk/reactos/drivers/filesystems/cdfs_new/workque.c trunk/reactos/drivers/filesystems/fastfat/create.c trunk/reactos/drivers/filesystems/fastfat/direntry.c trunk/reactos/drivers/filesystems/fastfat/dirwr.c trunk/reactos/drivers/filesystems/fastfat/fsctl.c trunk/reactos/drivers/filesystems/fastfat/vfat.h trunk/reactos/drivers/filesystems/fs_rec/fs_rec.c trunk/reactos/drivers/filesystems/fs_rec/reiserfs.h trunk/reactos/drivers/filesystems/mup/mup.c trunk/reactos/drivers/filesystems/ntfs/create.c trunk/reactos/drivers/filesystems/ntfs/fcb.c trunk/reactos/drivers/filesystems/ntfs/ntfs.h trunk/reactos/drivers/filters/fltmgr/Interface.c trunk/reactos/drivers/filters/fltmgr/fltmgr.h trunk/reactos/drivers/filters/mountmgr/database.c trunk/reactos/drivers/filters/mountmgr/device.c trunk/reactos/drivers/filters/mountmgr/mountmgr.c trunk/reactos/drivers/filters/mountmgr/notify.c trunk/reactos/drivers/filters/mountmgr/symlink.c trunk/reactos/drivers/hid/hidclass/fdo.c trunk/reactos/drivers/input/i8042prt/keyboard.c trunk/reactos/drivers/input/i8042prt/misc.c trunk/reactos/drivers/input/kbdclass/kbdclass.c trunk/reactos/drivers/input/kbdclass/misc.c trunk/reactos/drivers/input/mouclass/misc.c trunk/reactos/drivers/input/mouclass/mouclass.c trunk/reactos/drivers/input/sermouse/misc.c trunk/reactos/drivers/input/sermouse/sermouse.txt trunk/reactos/drivers/ksfilter/ks/api.c trunk/reactos/drivers/ksfilter/ks/clocks.c trunk/reactos/drivers/ksfilter/ks/filter.c trunk/reactos/drivers/ksfilter/ks/irp.c trunk/reactos/drivers/ksfilter/ks/pin.c trunk/reactos/drivers/ksfilter/ks/worker.c trunk/reactos/drivers/multimedia/audio/sound/mixer.h trunk/reactos/drivers/multimedia/audio/sound/wave.c trunk/reactos/drivers/network/afd/afd/read.c trunk/reactos/drivers/network/afd/afd/write.c trunk/reactos/drivers/network/dd/ne2000/include/ne2000.h trunk/reactos/drivers/network/dd/ne2000/ne2000/main.c trunk/reactos/drivers/network/dd/pcnet/pcnet.c trunk/reactos/drivers/network/dd/pcnet/pcnet.h trunk/reactos/drivers/network/dd/pcnet/pcnethw.h trunk/reactos/drivers/network/dd/pcnet/requests.c trunk/reactos/drivers/network/dd/rtl8139/rtlhw.h trunk/reactos/drivers/network/lan/lan/lan.c trunk/reactos/drivers/network/lan/lan/routines.c trunk/reactos/drivers/network/ndis/ndis/buffer.c trunk/reactos/drivers/network/ndis/ndis/config.c trunk/reactos/drivers/network/ndis/ndis/efilter.c trunk/reactos/drivers/network/ndis/ndis/io.c trunk/reactos/drivers/network/ndis/ndis/main.c trunk/reactos/drivers/network/ndis/ndis/miniport.c trunk/reactos/drivers/network/ndis/ndis/protocol.c trunk/reactos/drivers/network/ndis/ndis/time.c trunk/reactos/drivers/network/tcpip/datalink/lan.c trunk/reactos/drivers/network/tcpip/include/linux.h trunk/reactos/drivers/network/tcpip/include/tcpcore.h trunk/reactos/drivers/network/tcpip/include/tcpdef.h trunk/reactos/drivers/network/tcpip/include/ticonsts.h trunk/reactos/drivers/network/tcpip/include/titypes.h trunk/reactos/drivers/network/tcpip/tcpip/buffer.c trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c trunk/reactos/drivers/network/tcpip/tcpip/mockbuffer.c trunk/reactos/drivers/network/tcpip/tests/tests/ipreceive.c trunk/reactos/drivers/network/tdi/tdi/obsolete.c trunk/reactos/drivers/parallel/parallel/parallel.h trunk/reactos/drivers/parallel/parport/fdo.c trunk/reactos/drivers/sac/driver/concmd.c trunk/reactos/drivers/sac/driver/conmgr.c trunk/reactos/drivers/sac/driver/dispatch.c trunk/reactos/drivers/sac/driver/memory.c trunk/reactos/drivers/sac/driver/sacdrv.h trunk/reactos/drivers/sac/driver/util.c trunk/reactos/drivers/sac/driver/vtutf8chan.c trunk/reactos/drivers/serial/serenum/misc.c trunk/reactos/drivers/serial/serial/misc.c trunk/reactos/drivers/storage/class/cdrom/cdrom.c trunk/reactos/drivers/storage/class/cdrom_new/cdrom.c trunk/reactos/drivers/storage/class/cdrom_new/cdrom.h trunk/reactos/drivers/storage/class/cdrom_new/cdrom.inf trunk/reactos/drivers/storage/class/cdrom_new/data.c trunk/reactos/drivers/storage/class/cdrom_new/mmc.c trunk/reactos/drivers/storage/class/class2/class2.c trunk/reactos/drivers/storage/class/disk/disk.c trunk/reactos/drivers/storage/class/disk_new/disk.c trunk/reactos/drivers/storage/class/disk_new/disk.h trunk/reactos/drivers/storage/class/disk_new/diskwmi.c trunk/reactos/drivers/storage/class/disk_new/geometry.c trunk/reactos/drivers/storage/class/disk_new/part.c trunk/reactos/drivers/storage/class/disk_new/pnp.c trunk/reactos/drivers/storage/classpnp/autorun.c trunk/reactos/drivers/storage/classpnp/class.c trunk/reactos/drivers/storage/classpnp/classp.h trunk/reactos/drivers/storage/classpnp/classwmi.c trunk/reactos/drivers/storage/classpnp/lock.c trunk/reactos/drivers/storage/classpnp/obsolete.c trunk/reactos/drivers/storage/classpnp/power.c trunk/reactos/drivers/storage/classpnp/utils.c trunk/reactos/drivers/storage/fdc/fdc/fdc.rc trunk/reactos/drivers/storage/fdc/fdc/fdo.c trunk/reactos/drivers/storage/floppy/floppy.c trunk/reactos/drivers/storage/floppy/floppy.rc trunk/reactos/drivers/storage/floppy/hardware.c trunk/reactos/drivers/storage/floppy/hardware.h trunk/reactos/drivers/storage/floppy/ioctl.c trunk/reactos/drivers/storage/floppy/readwrite.c trunk/reactos/drivers/storage/ide/atapi/atapi.c trunk/reactos/drivers/storage/ide/pciidex/misc.c trunk/reactos/drivers/storage/inc/ide.h trunk/reactos/drivers/storage/inc/rbc.h trunk/reactos/drivers/storage/port/buslogic/BusLogic958.c trunk/reactos/drivers/storage/port/buslogic/BusLogic958.h trunk/reactos/drivers/storage/port/buslogic/Log.c trunk/reactos/drivers/storage/port/buslogic/wmi.c trunk/reactos/drivers/storage/scsiport/scsiport.c trunk/reactos/drivers/usb/usbccgp/descriptor.c trunk/reactos/drivers/usb/usbccgp/fdo.c trunk/reactos/drivers/usb/usbd/usbd.c trunk/reactos/drivers/usb/usbehci/hardware.cpp trunk/reactos/drivers/usb/usbehci/usb_queue.cpp trunk/reactos/drivers/usb/usbehci/usb_request.cpp trunk/reactos/drivers/usb/usbhub/misc.c trunk/reactos/drivers/usb/usbhub/pdo.c trunk/reactos/drivers/usb/usbohci/hardware.cpp trunk/reactos/drivers/usb/usbohci/usb_queue.cpp trunk/reactos/drivers/usb/usbohci/usb_request.cpp trunk/reactos/drivers/usb/usbstor/descriptor.c trunk/reactos/drivers/usb/usbstor/disk.c trunk/reactos/drivers/usb/usbstor/fdo.c trunk/reactos/drivers/usb/usbstor/pdo.c trunk/reactos/drivers/usb/usbstor/usbstor.h trunk/reactos/drivers/usb/usbuhci/hardware.cpp trunk/reactos/drivers/usb/usbuhci/hardware.h trunk/reactos/drivers/usb/usbuhci/interfaces.h trunk/reactos/drivers/wdm/audio/backpln/audio_test/audio_test.c trunk/reactos/drivers/wdm/audio/backpln/portcls/dma_slave.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavert.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/port_dmus.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/port_topology.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavepci.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavert.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/service_group.cpp trunk/reactos/drivers/wdm/audio/backpln/portcls/undoc.cpp trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CHANGELOG.txt trunk/reactos/drivers/wdm/audio/drm/drmk/stubs.cpp trunk/reactos/drivers/wdm/audio/hdaudbus/businterface.cpp trunk/reactos/drivers/wdm/audio/hdaudbus/fdo.cpp trunk/reactos/drivers/wdm/audio/legacy/wdmaud/control.c trunk/reactos/drivers/wdm/audio/legacy/wdmaud/interface.h trunk/reactos/drivers/wdm/audio/legacy/wdmaud/mmixer.c trunk/reactos/drivers/wdm/audio/sysaudio/control.c trunk/reactos/drivers/wdm/audio/sysaudio/main.c trunk/reactos/drivers/wmi/wmilib.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/drivers/base/beep/beep.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/beep/beep.c?r… Modified: trunk/reactos/drivers/base/bootvid/arm/bootvid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/arm/b… Modified: trunk/reactos/drivers/base/bootvid/i386/bootvid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/i386/… Modified: trunk/reactos/drivers/base/bootvid/i386/vga.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/i386/… Modified: trunk/reactos/drivers/base/kdcom/kddll.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdcom/kddll.c… Modified: trunk/reactos/drivers/base/kdcom/kdserial.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdcom/kdseria… Modified: trunk/reactos/drivers/base/kdgdb/gdb_input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdgdb/gdb_inp… Modified: trunk/reactos/drivers/base/kdgdb/kdgdb.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/kdgdb/kdgdb.h… Modified: trunk/reactos/drivers/bus/acpi/busmgr/bus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/busmgr/bu… Modified: trunk/reactos/drivers/bus/acpi/busmgr/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/busmgr/po… Modified: trunk/reactos/drivers/bus/acpi/busmgr/system.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/busmgr/sy… Modified: trunk/reactos/drivers/bus/acpi/busmgr/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/busmgr/ut… Modified: trunk/reactos/drivers/bus/acpi/buspdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/buspdo.c?… Modified: trunk/reactos/drivers/bus/acpi/cmbatt/cmbatt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/cmbatt/cm… Modified: trunk/reactos/drivers/bus/acpi/cmbatt/cmbatt.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/cmbatt/cm… Modified: trunk/reactos/drivers/bus/acpi/cmbatt/cmbpnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/cmbatt/cm… Modified: trunk/reactos/drivers/bus/acpi/include/acpi_bus.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/acpi/include/a… Modified: trunk/reactos/drivers/bus/pci/pcidef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pci/pcidef.h?r… Modified: trunk/reactos/drivers/bus/pcix/enum.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/enum.c?re… Modified: trunk/reactos/drivers/bus/pcix/hookhal.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/hookhal.c… Modified: trunk/reactos/drivers/bus/pcix/intrface/intrface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/intrface/… Modified: trunk/reactos/drivers/bus/pcix/pci/ppbridge.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/pci/ppbri… Modified: trunk/reactos/drivers/bus/pcix/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/power.c?r… Modified: trunk/reactos/drivers/bus/pcix/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pcix/utils.c?r… Modified: trunk/reactos/drivers/filesystems/cdfs/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/f… Modified: trunk/reactos/drivers/filesystems/cdfs_new/allocsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/cd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/cddata.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/cdstruc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/close.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/deviosup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/dirctrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/dirsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/fsctrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/namesup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/pathsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/resrcsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/strucsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/verfysup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/volinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/wdk_wnet_to_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/cdfs_new/workque.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs_n… Modified: trunk/reactos/drivers/filesystems/fastfat/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… Modified: trunk/reactos/drivers/filesystems/fastfat/direntry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… Modified: trunk/reactos/drivers/filesystems/fastfat/vfat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… Modified: trunk/reactos/drivers/filesystems/fs_rec/fs_rec.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… Modified: trunk/reactos/drivers/filesystems/fs_rec/reiserfs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… Modified: trunk/reactos/drivers/filesystems/mup/mup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/mup/mu… Modified: trunk/reactos/drivers/filesystems/ntfs/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/c… Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/f… Modified: trunk/reactos/drivers/filesystems/ntfs/ntfs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/n… Modified: trunk/reactos/drivers/filters/fltmgr/Interface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/fltmgr/Int… Modified: trunk/reactos/drivers/filters/fltmgr/fltmgr.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/fltmgr/flt… Modified: trunk/reactos/drivers/filters/mountmgr/database.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d… Modified: trunk/reactos/drivers/filters/mountmgr/device.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d… Modified: trunk/reactos/drivers/filters/mountmgr/mountmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/m… Modified: trunk/reactos/drivers/filters/mountmgr/notify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/n… Modified: trunk/reactos/drivers/filters/mountmgr/symlink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/s… Modified: trunk/reactos/drivers/hid/hidclass/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/hid/hidclass/fdo.c… Modified: trunk/reactos/drivers/input/i8042prt/keyboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/key… Modified: trunk/reactos/drivers/input/i8042prt/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/mis… Modified: trunk/reactos/drivers/input/kbdclass/kbdclass.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/kbdclass/kbd… Modified: trunk/reactos/drivers/input/kbdclass/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/kbdclass/mis… Modified: trunk/reactos/drivers/input/mouclass/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/mouclass/mis… Modified: trunk/reactos/drivers/input/mouclass/mouclass.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/mouclass/mou… Modified: trunk/reactos/drivers/input/sermouse/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/sermouse/mis… Modified: trunk/reactos/drivers/input/sermouse/sermouse.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/sermouse/ser… Modified: trunk/reactos/drivers/ksfilter/ks/api.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/api.c?… Modified: trunk/reactos/drivers/ksfilter/ks/clocks.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/clocks… Modified: trunk/reactos/drivers/ksfilter/ks/filter.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/filter… Modified: trunk/reactos/drivers/ksfilter/ks/irp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/irp.c?… Modified: trunk/reactos/drivers/ksfilter/ks/pin.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/pin.c?… Modified: trunk/reactos/drivers/ksfilter/ks/worker.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/worker… Modified: trunk/reactos/drivers/multimedia/audio/sound/mixer.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/multimedia/audio/s… Modified: trunk/reactos/drivers/multimedia/audio/sound/wave.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/multimedia/audio/s… Modified: trunk/reactos/drivers/network/afd/afd/read.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/re… Modified: trunk/reactos/drivers/network/afd/afd/write.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/wr… Modified: trunk/reactos/drivers/network/dd/ne2000/include/ne2000.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/ne2000/… Modified: trunk/reactos/drivers/network/dd/ne2000/ne2000/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/ne2000/… Modified: trunk/reactos/drivers/network/dd/pcnet/pcnet.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/pcnet/p… Modified: trunk/reactos/drivers/network/dd/pcnet/pcnet.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/pcnet/p… Modified: trunk/reactos/drivers/network/dd/pcnet/pcnethw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/pcnet/p… Modified: trunk/reactos/drivers/network/dd/pcnet/requests.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/pcnet/r… Modified: trunk/reactos/drivers/network/dd/rtl8139/rtlhw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/dd/rtl8139… Modified: trunk/reactos/drivers/network/lan/lan/lan.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/lan/lan/la… Modified: trunk/reactos/drivers/network/lan/lan/routines.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/lan/lan/ro… Modified: trunk/reactos/drivers/network/ndis/ndis/buffer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/config.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/efilter.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/io.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/protocol.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/ndis/ndis/time.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… Modified: trunk/reactos/drivers/network/tcpip/datalink/lan.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/data… Modified: trunk/reactos/drivers/network/tcpip/include/linux.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… Modified: trunk/reactos/drivers/network/tcpip/include/tcpcore.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… Modified: trunk/reactos/drivers/network/tcpip/include/tcpdef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… Modified: trunk/reactos/drivers/network/tcpip/include/ticonsts.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… Modified: trunk/reactos/drivers/network/tcpip/include/titypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… Modified: trunk/reactos/drivers/network/tcpip/tcpip/buffer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi… Modified: trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi… Modified: trunk/reactos/drivers/network/tcpip/tcpip/mockbuffer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi… Modified: trunk/reactos/drivers/network/tcpip/tests/tests/ipreceive.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/test… Modified: trunk/reactos/drivers/network/tdi/tdi/obsolete.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tdi/tdi/ob… Modified: trunk/reactos/drivers/parallel/parallel/parallel.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/parallel/parallel/… Modified: trunk/reactos/drivers/parallel/parport/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/parallel/parport/f… Modified: trunk/reactos/drivers/sac/driver/concmd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/concmd.… Modified: trunk/reactos/drivers/sac/driver/conmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/conmgr.… Modified: trunk/reactos/drivers/sac/driver/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/dispatc… Modified: trunk/reactos/drivers/sac/driver/memory.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/memory.… Modified: trunk/reactos/drivers/sac/driver/sacdrv.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/sacdrv.… Modified: trunk/reactos/drivers/sac/driver/util.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/util.c?… Modified: trunk/reactos/drivers/sac/driver/vtutf8chan.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/sac/driver/vtutf8c… Modified: trunk/reactos/drivers/serial/serenum/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serenum/mis… Modified: trunk/reactos/drivers/serial/serial/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/serial/misc… Modified: trunk/reactos/drivers/storage/class/cdrom/cdrom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/cdro… Modified: trunk/reactos/drivers/storage/class/cdrom_new/cdrom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/cdro… Modified: trunk/reactos/drivers/storage/class/cdrom_new/cdrom.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/cdro… Modified: trunk/reactos/drivers/storage/class/cdrom_new/cdrom.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/cdro… Modified: trunk/reactos/drivers/storage/class/cdrom_new/data.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/cdro… Modified: trunk/reactos/drivers/storage/class/cdrom_new/mmc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/cdro… Modified: trunk/reactos/drivers/storage/class/class2/class2.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/clas… Modified: trunk/reactos/drivers/storage/class/disk/disk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/class/disk_new/disk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/class/disk_new/disk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/class/disk_new/diskwmi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/class/disk_new/geometry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/class/disk_new/part.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/class/disk_new/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/disk… Modified: trunk/reactos/drivers/storage/classpnp/autorun.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/a… Modified: trunk/reactos/drivers/storage/classpnp/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/c… Modified: trunk/reactos/drivers/storage/classpnp/classp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/c… Modified: trunk/reactos/drivers/storage/classpnp/classwmi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/c… Modified: trunk/reactos/drivers/storage/classpnp/lock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/l… Modified: trunk/reactos/drivers/storage/classpnp/obsolete.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/o… Modified: trunk/reactos/drivers/storage/classpnp/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/p… Modified: trunk/reactos/drivers/storage/classpnp/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/classpnp/u… Modified: trunk/reactos/drivers/storage/fdc/fdc/fdc.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/fdc/fdc/fd… Modified: trunk/reactos/drivers/storage/fdc/fdc/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/fdc/fdc/fd… Modified: trunk/reactos/drivers/storage/floppy/floppy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/flo… Modified: trunk/reactos/drivers/storage/floppy/floppy.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/flo… Modified: trunk/reactos/drivers/storage/floppy/hardware.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/har… Modified: trunk/reactos/drivers/storage/floppy/hardware.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/har… Modified: trunk/reactos/drivers/storage/floppy/ioctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/ioc… Modified: trunk/reactos/drivers/storage/floppy/readwrite.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/rea… Modified: trunk/reactos/drivers/storage/ide/atapi/atapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/atapi/… Modified: trunk/reactos/drivers/storage/ide/pciidex/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/pciide… Modified: trunk/reactos/drivers/storage/inc/ide.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/inc/ide.h?… Modified: trunk/reactos/drivers/storage/inc/rbc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/inc/rbc.h?… Modified: trunk/reactos/drivers/storage/port/buslogic/BusLogic958.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/buslo… Modified: trunk/reactos/drivers/storage/port/buslogic/BusLogic958.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/buslo… Modified: trunk/reactos/drivers/storage/port/buslogic/Log.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/buslo… Modified: trunk/reactos/drivers/storage/port/buslogic/wmi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/buslo… Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/scsiport/s… Modified: trunk/reactos/drivers/usb/usbccgp/descriptor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbccgp/descri… Modified: trunk/reactos/drivers/usb/usbccgp/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbccgp/fdo.c?… Modified: trunk/reactos/drivers/usb/usbd/usbd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbd/usbd.c?re… Modified: trunk/reactos/drivers/usb/usbehci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/hardwa… Modified: trunk/reactos/drivers/usb/usbehci/usb_queue.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/usb_qu… Modified: trunk/reactos/drivers/usb/usbehci/usb_request.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/usb_re… Modified: trunk/reactos/drivers/usb/usbhub/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbhub/misc.c?… Modified: trunk/reactos/drivers/usb/usbhub/pdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbhub/pdo.c?r… Modified: trunk/reactos/drivers/usb/usbohci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/hardwa… Modified: trunk/reactos/drivers/usb/usbohci/usb_queue.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/usb_qu… Modified: trunk/reactos/drivers/usb/usbohci/usb_request.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbohci/usb_re… Modified: trunk/reactos/drivers/usb/usbstor/descriptor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/descri… Modified: trunk/reactos/drivers/usb/usbstor/disk.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/disk.c… Modified: trunk/reactos/drivers/usb/usbstor/fdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/fdo.c?… Modified: trunk/reactos/drivers/usb/usbstor/pdo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/pdo.c?… Modified: trunk/reactos/drivers/usb/usbstor/usbstor.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbstor/usbsto… Modified: trunk/reactos/drivers/usb/usbuhci/hardware.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbuhci/hardwa… Modified: trunk/reactos/drivers/usb/usbuhci/hardware.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbuhci/hardwa… Modified: trunk/reactos/drivers/usb/usbuhci/interfaces.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbuhci/interf… Modified: trunk/reactos/drivers/wdm/audio/backpln/audio_test/audio_test.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/dma_slave.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/miniport_dmus.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavecyclic.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavepci.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/pin_wavert.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/port_dmus.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/port_topology.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavepci.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/port_wavert.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/propertyhandler.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/service_group.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/backpln/portcls/undoc.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/backpln/… Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CHANGELOG.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/… Modified: trunk/reactos/drivers/wdm/audio/drm/drmk/stubs.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drm/drmk… Modified: trunk/reactos/drivers/wdm/audio/hdaudbus/businterface.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/hdaudbus… Modified: trunk/reactos/drivers/wdm/audio/hdaudbus/fdo.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/hdaudbus… Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/control.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/w… Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/interface.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/w… Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/mmixer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/w… Modified: trunk/reactos/drivers/wdm/audio/sysaudio/control.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/sysaudio… Modified: trunk/reactos/drivers/wdm/audio/sysaudio/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/sysaudio… Modified: trunk/reactos/drivers/wmi/wmilib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wmi/wmilib.c?rev=7…

1 0

[tfaber] 73225: [WS2_32_APITEST] - Skip nonblocking tests since they hang on testbot ROSTESTS-247
by tfaber＠svn.reactos.org 13 Nov '16

13 Nov '16

Author: tfaber Date: Sun Nov 13 14:54:06 2016 New Revision: 73225 URL: http://svn.reactos.org/svn/reactos?rev=73225&view=rev Log: [WS2_32_APITEST] - Skip nonblocking tests since they hang on testbot ROSTESTS-247 Modified: trunk/rostests/apitests/ws2_32/nonblocking.c Modified: trunk/rostests/apitests/ws2_32/nonblocking.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ws2_32/nonblocki… ============================================================================== --- trunk/rostests/apitests/ws2_32/nonblocking.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ws2_32/nonblocking.c [iso-8859-1] Sun Nov 13 14:54:06 2016 @@ -31,6 +31,12 @@ fd_set readfds, writefds, exceptfds; struct timeval tval = { 0 }; char address[100]; + + if (!winetest_interactive) + { + skip("ROSTESTS-247: Skipping ws2_32_apitest:nonblocking because it times out on testbot\n"); + return; + } if (WSAStartup(MAKEWORD(2, 2), &WsaData) != 0) {

1 0

[tfaber] 73224: [KMTESTS:RTL] - Silence a GCC5+ warning CORE-11794
by tfaber＠svn.reactos.org 13 Nov '16

13 Nov '16

Author: tfaber Date: Sun Nov 13 12:19:05 2016 New Revision: 73224 URL: http://svn.reactos.org/svn/reactos?rev=73224&view=rev Log: [KMTESTS:RTL] - Silence a GCC5+ warning CORE-11794 Modified: trunk/rostests/kmtests/rtl/RtlMemory.c Modified: trunk/rostests/kmtests/rtl/RtlMemory.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/rtl/RtlMemory.c?r… ============================================================================== --- trunk/rostests/kmtests/rtl/RtlMemory.c [iso-8859-1] (original) +++ trunk/rostests/kmtests/rtl/RtlMemory.c [iso-8859-1] Sun Nov 13 12:19:05 2016 @@ -426,7 +426,14 @@ KeLowerIrql(Irql); Status = STATUS_SUCCESS; _SEH2_TRY { +#if defined(__GNUC__) && __GNUC__ >= 5 +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wmemset-transposed-args" +#endif RtlFillMemory(NULL, 0, 0x55); +#if defined(__GNUC__) && __GNUC__ >= 5 +#pragma GCC diagnostic pop +#endif } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { Status = _SEH2_GetExceptionCode(); } _SEH2_END;

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs