Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hbelusca] 72022: [SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local differences wrt. the synced Wine code. Per Amine request. ROSTESTS_234
by hbelusca＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: hbelusca Date: Wed Jul 27 19:17:35 2016 New Revision: 72022 URL: http://svn.reactos.org/svn/reactos?rev=72022&view=rev Log: [SETUPAPI_WINETEST]: Use #ifdef __REACTOS__ instead to underline our local differences wrt. the synced Wine code. Per Amine request. ROSTESTS_234 Modified: trunk/rostests/winetests/setupapi/dialog.c Modified: trunk/rostests/winetests/setupapi/dialog.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/setupapi/dialog… ============================================================================== --- trunk/rostests/winetests/setupapi/dialog.c [iso-8859-1] (original) +++ trunk/rostests/winetests/setupapi/dialog.c [iso-8859-1] Wed Jul 27 19:17:35 2016 @@ -32,11 +32,11 @@ static void test_SetupPromptForDiskA(void) { -#ifndef ROSTESTS_234_IS_FIXED - // char path[] = "C:\\windows\\system32"; +#ifdef __REACTOS__ char path[] = "C:\\ReactOS\\system32"; #else - #error "path should use GetSystemDirectoryA()" + #error "path must use GetSystemDirectoryA()! ROSTESTS_234" + char path[] = "C:\\windows\\system32"; #endif char file[] = "kernel32.dll"; char buffer[MAX_PATH]; @@ -71,11 +71,11 @@ static void test_SetupPromptForDiskW(void) { -#ifndef ROSTESTS_234_IS_FIXED - // WCHAR path[] = {'C',':','\\','w','i','n','d','o','w','s','\\','s','y','s','t','e','m','3','2','\0'}; +#ifdef __REACTOS__ WCHAR path[] = {'C',':','\\','R','e','a','c','t','O','S','\\','s','y','s','t','e','m','3','2','\0'}; #else - #error "path should use GetSystemDirectoryW()" + #error "path must use GetSystemDirectoryW()! ROSTESTS_234" + WCHAR path[] = {'C',':','\\','w','i','n','d','o','w','s','\\','s','y','s','t','e','m','3','2','\0'}; #endif WCHAR file[] = {'k','e','r','n','e','l','3','2','.','d','l','l','\0'}; WCHAR title[] = {'T','e','s','t','\0'};

1 0

[hbelusca] 72021: [SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out unexpectedly. We don't lose functionality wrt. what we had before r72008 (or with what Wine curr...
by hbelusca＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: hbelusca Date: Wed Jul 27 19:12:35 2016 New Revision: 72021 URL: http://svn.reactos.org/svn/reactos?rev=72021&view=rev Log: [SETUPAPI]: Temporarily remove the error popup since setupapi_winetest pops it out unexpectedly. We don't lose functionality wrt. what we had before r72008 (or with what Wine currently has). CORE-11689 Modified: trunk/reactos/dll/win32/setupapi/install.c Modified: trunk/reactos/dll/win32/setupapi/install.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/install… ============================================================================== --- trunk/reactos/dll/win32/setupapi/install.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/install.c [iso-8859-1] Wed Jul 27 19:12:35 2016 @@ -1577,11 +1577,15 @@ if ( hinf != INVALID_HANDLE_VALUE ) SetupCloseInfFile( hinf ); +#ifdef CORE_11689_IS_FIXED // TODO: Localize the error string. if (!ret && !(GlobalSetupFlags & PSPGF_NONINTERACTIVE)) { MessageBoxW(hwnd, section, L"setupapi.dll: An error happened...", MB_ICONERROR | MB_OK); } +#else + #pragma message("We need to understand why setupapi_winetest fails before reenabling the error popup in InstallHinfSectionW. CORE-11689") +#endif }

1 0

[hbelusca] 72020: [SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable" test path. ROSTESTS-234
by hbelusca＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: hbelusca Date: Wed Jul 27 19:05:52 2016 New Revision: 72020 URL: http://svn.reactos.org/svn/reactos?rev=72020&view=rev Log: [SETUPAPI_WINETEST]: Temporarily "hackfix" the test so that it uses a more "suitable" test path. ROSTESTS-234 Modified: trunk/rostests/winetests/setupapi/dialog.c Modified: trunk/rostests/winetests/setupapi/dialog.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/setupapi/dialog… ============================================================================== --- trunk/rostests/winetests/setupapi/dialog.c [iso-8859-1] (original) +++ trunk/rostests/winetests/setupapi/dialog.c [iso-8859-1] Wed Jul 27 19:05:52 2016 @@ -32,7 +32,12 @@ static void test_SetupPromptForDiskA(void) { - char path[] = "C:\\windows\\system32"; +#ifndef ROSTESTS_234_IS_FIXED + // char path[] = "C:\\windows\\system32"; + char path[] = "C:\\ReactOS\\system32"; +#else + #error "path should use GetSystemDirectoryA()" +#endif char file[] = "kernel32.dll"; char buffer[MAX_PATH]; UINT ret; @@ -66,7 +71,12 @@ static void test_SetupPromptForDiskW(void) { - WCHAR path[] = {'C',':','\\','w','i','n','d','o','w','s','\\','s','y','s','t','e','m','3','2','\0'}; +#ifndef ROSTESTS_234_IS_FIXED + // WCHAR path[] = {'C',':','\\','w','i','n','d','o','w','s','\\','s','y','s','t','e','m','3','2','\0'}; + WCHAR path[] = {'C',':','\\','R','e','a','c','t','O','S','\\','s','y','s','t','e','m','3','2','\0'}; +#else + #error "path should use GetSystemDirectoryW()" +#endif WCHAR file[] = {'k','e','r','n','e','l','3','2','.','d','l','l','\0'}; WCHAR title[] = {'T','e','s','t','\0'}; WCHAR disk[] = {'T','e','s','t','d','i','s','k','\0'};

1 0

[pschweitzer] 72019: [KMTESTS] Add missing dependency
by pschweitzer＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: pschweitzer Date: Wed Jul 27 16:40:30 2016 New Revision: 72019 URL: http://svn.reactos.org/svn/reactos?rev=72019&view=rev Log: [KMTESTS] Add missing dependency Modified: trunk/rostests/kmtests/CMakeLists.txt Modified: trunk/rostests/kmtests/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/CMakeLists.txt?re… ============================================================================== --- trunk/rostests/kmtests/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/kmtests/CMakeLists.txt [iso-8859-1] Wed Jul 27 16:40:30 2016 @@ -152,7 +152,8 @@ iohelper_drv ioreadwrite_drv poirp_drv - tcpip_drv) + tcpip_drv + cccopyread_drv) add_custom_target(kmtest_all) add_dependencies(kmtest_all kmtest_drivers kmtest)

1 0

[akhaldi] 72018: [0.4.2] * Apply the hackfix from CORE-9836 by Joachim Henze.
by akhaldi＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: akhaldi Date: Wed Jul 27 15:21:39 2016 New Revision: 72018 URL: http://svn.reactos.org/svn/reactos?rev=72018&view=rev Log: [0.4.2] * Apply the hackfix from CORE-9836 by Joachim Henze. Modified: branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/class.c branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/cursoricon.c branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/msgqueue.c Modified: branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/win32s… ============================================================================== --- branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/class.c [iso-8859-1] (original) +++ branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/class.c [iso-8859-1] Wed Jul 27 15:21:39 2016 @@ -267,8 +267,11 @@ if (Class->spicn) UserDereferenceObject(Class->spicn); - if (Class->spcur) + if (Class->spcur && !UserObjectInDestroy(Class->spcur)) + { UserDereferenceObject(Class->spcur); + Class->spcur = NULL; + } if (Class->spicnSm) { UserDereferenceObject(Class->spicnSm); Modified: branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/cursoricon.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/win32s… ============================================================================== --- branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] (original) +++ branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/cursoricon.c [iso-8859-1] Wed Jul 27 15:21:39 2016 @@ -1086,11 +1086,14 @@ goto leave; } + pcurOld->CURSORF_flags &= ~CURSORF_CURRENT; + /* See if it was destroyed in the meantime */ if (UserObjectInDestroy(hOldCursor)) - hOldCursor = NULL; - pcurOld->CURSORF_flags &= ~CURSORF_CURRENT; - UserDereferenceObject(pcurOld); + { + UserDereferenceObject(pcurOld); + pcurOld = NULL; + } } leave: Modified: branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/win32s… ============================================================================== --- branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] (original) +++ branches/ros-branch-0_4_2/reactos/win32ss/user/ntuser/msgqueue.c [iso-8859-1] Wed Jul 27 15:21:39 2016 @@ -2288,8 +2288,12 @@ IntGetSysCursorInfo()->CurrentCursorObject = NULL; } - TRACE("DereferenceObject pCursor\n"); - UserDereferenceObject(pCursor); + if (pCursor && UserObjectInDestroy(UserHMGetHandle(pCursor))) + { + TRACE("DereferenceObject pCursor\n"); + UserDereferenceObject(pCursor); + pCursor = NULL; + } } if (gpqForeground == MessageQueue)

1 0

[tfaber] 72017: [NTOS:PO] - Send power IRPs to the top of the device stack instead of the PDO CORE-10110 #resolve
by tfaber＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: tfaber Date: Wed Jul 27 11:15:52 2016 New Revision: 72017 URL: http://svn.reactos.org/svn/reactos?rev=72017&view=rev Log: [NTOS:PO] - Send power IRPs to the top of the device stack instead of the PDO CORE-10110 #resolve Modified: trunk/reactos/ntoskrnl/po/power.c Modified: trunk/reactos/ntoskrnl/po/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/po/power.c?rev=72… ============================================================================== --- trunk/reactos/ntoskrnl/po/power.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/po/power.c [iso-8859-1] Wed Jul 27 11:15:52 2016 @@ -153,6 +153,7 @@ PVOID Context) { PPOWER_STATE_TRAVERSE_CONTEXT PowerStateContext = Context; + PDEVICE_OBJECT TopDeviceObject; NTSTATUS Status; DPRINT("PopQuerySystemPowerStateTraverse(%p, %p)\n", DeviceNode, Context); @@ -163,13 +164,16 @@ if (DeviceNode->Flags & DNF_LEGACY_DRIVER) return STATUS_SUCCESS; - Status = PopSendQuerySystemPowerState(DeviceNode->PhysicalDeviceObject, + TopDeviceObject = IoGetAttachedDeviceReference(DeviceNode->PhysicalDeviceObject); + + Status = PopSendQuerySystemPowerState(TopDeviceObject, PowerStateContext->SystemPowerState, PowerStateContext->PowerAction); if (!NT_SUCCESS(Status)) { DPRINT1("Device '%wZ' failed IRP_MN_QUERY_POWER\n", &DeviceNode->InstancePath); } + ObDereferenceObject(TopDeviceObject); #if 0 return Status; @@ -183,6 +187,7 @@ PVOID Context) { PPOWER_STATE_TRAVERSE_CONTEXT PowerStateContext = Context; + PDEVICE_OBJECT TopDeviceObject; NTSTATUS Status; DPRINT("PopSetSystemPowerStateTraverse(%p, %p)\n", DeviceNode, Context); @@ -196,13 +201,22 @@ if (DeviceNode->Flags & DNF_LEGACY_DRIVER) return STATUS_SUCCESS; - Status = PopSendSetSystemPowerState(DeviceNode->PhysicalDeviceObject, + TopDeviceObject = IoGetAttachedDeviceReference(DeviceNode->PhysicalDeviceObject); + if (TopDeviceObject == PowerStateContext->PowerDevice) + { + ObDereferenceObject(TopDeviceObject); + return STATUS_SUCCESS; + } + + Status = PopSendSetSystemPowerState(TopDeviceObject, PowerStateContext->SystemPowerState, PowerStateContext->PowerAction); if (!NT_SUCCESS(Status)) { DPRINT1("Device '%wZ' failed IRP_MN_SET_POWER\n", &DeviceNode->InstancePath); } + + ObDereferenceObject(TopDeviceObject); #if 0 return Status;

1 0

[tfaber] 72016: [0.4.2] - Add a hack to avoid MmGetPhysicalAddress failures during USB transfers CORE-9224
by tfaber＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: tfaber Date: Wed Jul 27 10:55:39 2016 New Revision: 72016 URL: http://svn.reactos.org/svn/reactos?rev=72016&view=rev Log: [0.4.2] - Add a hack to avoid MmGetPhysicalAddress failures during USB transfers CORE-9224 Modified: branches/ros-branch-0_4_2/reactos/drivers/usb/usbehci/usb_request.cpp branches/ros-branch-0_4_2/reactos/drivers/usb/usbohci/usb_request.cpp Modified: branches/ros-branch-0_4_2/reactos/drivers/usb/usbehci/usb_request.cpp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/driver… ============================================================================== --- branches/ros-branch-0_4_2/reactos/drivers/usb/usbehci/usb_request.cpp [iso-8859-1] (original) +++ branches/ros-branch-0_4_2/reactos/drivers/usb/usbehci/usb_request.cpp [iso-8859-1] Wed Jul 27 10:55:39 2016 @@ -601,6 +601,7 @@ // // get address // + *(volatile char *)TransferBuffer; // HACK for CORE-9224 Address = MmGetPhysicalAddress(TransferBuffer); // Modified: branches/ros-branch-0_4_2/reactos/drivers/usb/usbohci/usb_request.cpp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/driver… ============================================================================== --- branches/ros-branch-0_4_2/reactos/drivers/usb/usbohci/usb_request.cpp [iso-8859-1] (original) +++ branches/ros-branch-0_4_2/reactos/drivers/usb/usbohci/usb_request.cpp [iso-8859-1] Wed Jul 27 10:55:39 2016 @@ -771,6 +771,7 @@ // // get physical page // + *(volatile char *)Buffer; // HACK for CORE-9224 Page = MmGetPhysicalAddress(Buffer).LowPart; // @@ -1087,6 +1088,7 @@ // // store physical address of buffer // + *(volatile char *)TransferBuffer; // HACK for CORE-9224 CurrentDescriptor->BufferPhysical = MmGetPhysicalAddress(TransferBuffer).LowPart; CurrentDescriptor->LastPhysicalByteAddress = CurrentDescriptor->BufferPhysical + TransferBufferLength - 1; @@ -1503,6 +1505,7 @@ // // store physical address of buffer // + *(volatile char *)MmGetMdlVirtualAddress(m_TransferBufferMDL); // HACK for CORE-9224 DataDescriptor->BufferPhysical = MmGetPhysicalAddress(MmGetMdlVirtualAddress(m_TransferBufferMDL)).LowPart; DataDescriptor->LastPhysicalByteAddress = DataDescriptor->BufferPhysical + m_TransferBufferLength - 1;

1 0

[tfaber] 72015: [0.4.2] - Update start menu banner
by tfaber＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: tfaber Date: Wed Jul 27 10:48:19 2016 New Revision: 72015 URL: http://svn.reactos.org/svn/reactos?rev=72015&view=rev Log: [0.4.2] - Update start menu banner Added: branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158-rc1.bmp - copied, changed from r72012, branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158-rc2.bmp - copied, changed from r72012, branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158-rc3.bmp - copied, changed from r72012, branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp Modified: branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp Copied: branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158-rc1.bmp (from r72012, branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp) URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/base/s… ============================================================================== Binary files - no diff available. Copied: branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158-rc2.bmp (from r72012, branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp) URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/base/s… ============================================================================== Binary files - no diff available. Copied: branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158-rc3.bmp (from r72012, branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp) URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/base/s… ============================================================================== Binary files - no diff available. Modified: branches/ros-branch-0_4_2/reactos/base/shell/explorer/res/bmp/158.bmp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/base/s… ============================================================================== Binary files - no diff available.

1 0

[akhaldi] 72014: [0.4.2] * Disable COMMAND.COM debugging messages. CORE-10710
by akhaldi＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: akhaldi Date: Wed Jul 27 10:42:15 2016 New Revision: 72014 URL: http://svn.reactos.org/svn/reactos?rev=72014&view=rev Log: [0.4.2] * Disable COMMAND.COM debugging messages. CORE-10710 Modified: branches/ros-branch-0_4_2/reactos/subsystems/mvdm/dos/command.S Modified: branches/ros-branch-0_4_2/reactos/subsystems/mvdm/dos/command.S URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/subsys… ============================================================================== --- branches/ros-branch-0_4_2/reactos/subsystems/mvdm/dos/command.S [iso-8859-1] (original) +++ branches/ros-branch-0_4_2/reactos/subsystems/mvdm/dos/command.S [iso-8859-1] Wed Jul 27 10:42:15 2016 @@ -17,7 +17,7 @@ #include "asmxtras.inc" #include <isvbop.inc> -// #define NDEBUG +#define NDEBUG /* DEFINES ********************************************************************/

1 0

[akhaldi] 72013: [0.4.2] * Apply the Wordpad related hack from CORE-5823 by Jared Smudde.
by akhaldi＠svn.reactos.org 27 Jul '16

27 Jul '16

Author: akhaldi Date: Wed Jul 27 10:40:42 2016 New Revision: 72013 URL: http://svn.reactos.org/svn/reactos?rev=72013&view=rev Log: [0.4.2] * Apply the Wordpad related hack from CORE-5823 by Jared Smudde. Modified: branches/ros-branch-0_4_2/reactos/base/applications/wordpad/res/formatbar.bmp branches/ros-branch-0_4_2/reactos/base/applications/wordpad/res/toolbar.bmp Modified: branches/ros-branch-0_4_2/reactos/base/applications/wordpad/res/formatbar.bmp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/base/a… ============================================================================== Binary files - no diff available. Modified: branches/ros-branch-0_4_2/reactos/base/applications/wordpad/res/toolbar.bmp URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_4_2/reactos/base/a… ============================================================================== Binary files - no diff available.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs