Ros-diffs

ros-diffs@reactos.org

17 participants
81085 discussions

[reactos] 01/01: [IP] Don't reference uninitialized PCB to avoid BSOD. CORE-18982

by David L Bean

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f8a6542b15efa996d6726… commit f8a6542b15efa996d672609e651485f50310a6c0 Author: David L Bean <d_bean(a)hotmail.com> AuthorDate: Mon Jul 24 13:18:16 2023 -0400 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sun Jul 30 16:52:55 2023 -0400 [IP] Don't reference uninitialized PCB to avoid BSOD. CORE-18982 transport calls to LibTCPConnect that suffer certain early failures like parameter errors or early route lookup failures return without initializing the pcb. In order to avoid later BSOD's this change clears the ConnectionRequest bucket in those cases. --- drivers/network/tcpip/ip/transport/tcp/tcp.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/network/tcpip/ip/transport/tcp/tcp.c b/drivers/network/tcpip/ip/transport/tcp/tcp.c index 3d65e9a46b9..89b9184fdca 100644 --- a/drivers/network/tcpip/ip/transport/tcp/tcp.c +++ b/drivers/network/tcpip/ip/transport/tcp/tcp.c @@ -411,7 +411,13 @@ NTSTATUS TCPConnect Status = TCPTranslateError(LibTCPConnect(Connection, &connaddr, RemotePort)); - + if (!NT_SUCCESS(Status)) + { + LockObject(Connection); + RemoveEntryList(&Bucket->Entry); + UnlockObject(Connection); + ExFreeToNPagedLookasideList(&TdiBucketLookasideList, Bucket); + } TI_DbgPrint(DEBUG_TCP,("[IP, TCPConnect] Leaving. Status = 0x%x\n", Status)); return Status;

1 year, 5 months

[reactos] 01/01: [REACTOS] Optimize PNG images (#5492)

by Andrew Dent

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e5993f13f0223eb1a068f… commit e5993f13f0223eb1a068ff7cf19f6449f6f574d3 Author: Andrew Dent <dent.ace(a)gmail.com> AuthorDate: Sun Jul 30 21:32:34 2023 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jul 30 22:32:34 2023 +0200 [REACTOS] Optimize PNG images (#5492) * [PIFMGR] Optimize png images - Lossless optimization with `pngslim`. Saves ~50%. - Restricted to RGBA color mode (‘c6’), for maximum compatibility at the cost of some compression. * [ROSAPPS] Optimize png image - Lossless optimization with `pngslim`. Saves ~10%. * [MSTSC] Optimize png image - Lossless optimization with `pngslim`. Saves ~56%. - Restricted to RGBA color mode (‘c6’), for maximum compatibility at the cost of some compression. * [Themes] Optimize png image - Lossless optimization with `pngslim`. Saves ~20%. - Restricted to RGB color mode (‘c2’), for maximum compatibility. --- base/applications/mstsc/res/video-display.png | Bin 33353 -> 14635 bytes .../Blackshade/blackshade.msstyles/BlackShade.png | Bin 426091 -> 340598 bytes .../net/tsclient/rdesktop/doc/keynums.png | Bin 9173 -> 8153 bytes subsystems/mvdm/pifmgr/res/01.png | Bin 953 -> 467 bytes subsystems/mvdm/pifmgr/res/01vdm.png | Bin 879 -> 449 bytes subsystems/mvdm/pifmgr/res/02.png | Bin 787 -> 365 bytes subsystems/mvdm/pifmgr/res/03.png | Bin 685 -> 315 bytes subsystems/mvdm/pifmgr/res/04.png | Bin 582 -> 272 bytes subsystems/mvdm/pifmgr/res/05.png | Bin 568 -> 290 bytes subsystems/mvdm/pifmgr/res/06.png | Bin 621 -> 310 bytes subsystems/mvdm/pifmgr/res/09.png | Bin 657 -> 288 bytes subsystems/mvdm/pifmgr/res/11.png | Bin 635 -> 292 bytes subsystems/mvdm/pifmgr/res/12.png | Bin 813 -> 383 bytes subsystems/mvdm/pifmgr/res/13.png | Bin 738 -> 374 bytes subsystems/mvdm/pifmgr/res/14.png | Bin 457 -> 246 bytes subsystems/mvdm/pifmgr/res/15.png | Bin 585 -> 293 bytes subsystems/mvdm/pifmgr/res/17.png | Bin 796 -> 392 bytes subsystems/mvdm/pifmgr/res/18.png | Bin 591 -> 308 bytes subsystems/mvdm/pifmgr/res/19.png | Bin 509 -> 228 bytes subsystems/mvdm/pifmgr/res/20.png | Bin 618 -> 339 bytes subsystems/mvdm/pifmgr/res/22.png | Bin 762 -> 367 bytes subsystems/mvdm/pifmgr/res/23.png | Bin 725 -> 337 bytes subsystems/mvdm/pifmgr/res/34.png | Bin 640 -> 302 bytes 23 files changed, 0 insertions(+), 0 deletions(-) diff --git a/base/applications/mstsc/res/video-display.png b/base/applications/mstsc/res/video-display.png old mode 100644 new mode 100755 index 93c3f3bfec1..f5632869a40 Binary files a/base/applications/mstsc/res/video-display.png and b/base/applications/mstsc/res/video-display.png differ diff --git a/media/themes/Blackshade/blackshade.msstyles/BlackShade.png b/media/themes/Blackshade/blackshade.msstyles/BlackShade.png index 64394a6b98c..f45a2b9227e 100644 Binary files a/media/themes/Blackshade/blackshade.msstyles/BlackShade.png and b/media/themes/Blackshade/blackshade.msstyles/BlackShade.png differ diff --git a/modules/rosapps/applications/net/tsclient/rdesktop/doc/keynums.png b/modules/rosapps/applications/net/tsclient/rdesktop/doc/keynums.png old mode 100644 new mode 100755 index 401601b9e06..1f18001f781 Binary files a/modules/rosapps/applications/net/tsclient/rdesktop/doc/keynums.png and b/modules/rosapps/applications/net/tsclient/rdesktop/doc/keynums.png differ diff --git a/subsystems/mvdm/pifmgr/res/01.png b/subsystems/mvdm/pifmgr/res/01.png index dbde11820b1..ab1e8426238 100644 Binary files a/subsystems/mvdm/pifmgr/res/01.png and b/subsystems/mvdm/pifmgr/res/01.png differ diff --git a/subsystems/mvdm/pifmgr/res/01vdm.png b/subsystems/mvdm/pifmgr/res/01vdm.png index 61db4f8a183..133ef2336a8 100644 Binary files a/subsystems/mvdm/pifmgr/res/01vdm.png and b/subsystems/mvdm/pifmgr/res/01vdm.png differ diff --git a/subsystems/mvdm/pifmgr/res/02.png b/subsystems/mvdm/pifmgr/res/02.png index e89a8af3c9e..50cadd0f9ce 100644 Binary files a/subsystems/mvdm/pifmgr/res/02.png and b/subsystems/mvdm/pifmgr/res/02.png differ diff --git a/subsystems/mvdm/pifmgr/res/03.png b/subsystems/mvdm/pifmgr/res/03.png index 35bb17c25f7..1e0598b9103 100644 Binary files a/subsystems/mvdm/pifmgr/res/03.png and b/subsystems/mvdm/pifmgr/res/03.png differ diff --git a/subsystems/mvdm/pifmgr/res/04.png b/subsystems/mvdm/pifmgr/res/04.png index 6392a475382..e86e3cda723 100644 Binary files a/subsystems/mvdm/pifmgr/res/04.png and b/subsystems/mvdm/pifmgr/res/04.png differ diff --git a/subsystems/mvdm/pifmgr/res/05.png b/subsystems/mvdm/pifmgr/res/05.png index fa84c7594a4..ae5a7f9ad0c 100644 Binary files a/subsystems/mvdm/pifmgr/res/05.png and b/subsystems/mvdm/pifmgr/res/05.png differ diff --git a/subsystems/mvdm/pifmgr/res/06.png b/subsystems/mvdm/pifmgr/res/06.png index f30f78c6b38..ac45947dd63 100644 Binary files a/subsystems/mvdm/pifmgr/res/06.png and b/subsystems/mvdm/pifmgr/res/06.png differ diff --git a/subsystems/mvdm/pifmgr/res/09.png b/subsystems/mvdm/pifmgr/res/09.png index 7e956ded5c0..d6a1e775a2d 100644 Binary files a/subsystems/mvdm/pifmgr/res/09.png and b/subsystems/mvdm/pifmgr/res/09.png differ diff --git a/subsystems/mvdm/pifmgr/res/11.png b/subsystems/mvdm/pifmgr/res/11.png index 017f2b4dda5..9580686d7da 100644 Binary files a/subsystems/mvdm/pifmgr/res/11.png and b/subsystems/mvdm/pifmgr/res/11.png differ diff --git a/subsystems/mvdm/pifmgr/res/12.png b/subsystems/mvdm/pifmgr/res/12.png index e393ff8fa8a..4a53da8793d 100644 Binary files a/subsystems/mvdm/pifmgr/res/12.png and b/subsystems/mvdm/pifmgr/res/12.png differ diff --git a/subsystems/mvdm/pifmgr/res/13.png b/subsystems/mvdm/pifmgr/res/13.png index 97cc0d45639..678589a5abf 100644 Binary files a/subsystems/mvdm/pifmgr/res/13.png and b/subsystems/mvdm/pifmgr/res/13.png differ diff --git a/subsystems/mvdm/pifmgr/res/14.png b/subsystems/mvdm/pifmgr/res/14.png index 1a395a1ad8f..b0673e29a38 100644 Binary files a/subsystems/mvdm/pifmgr/res/14.png and b/subsystems/mvdm/pifmgr/res/14.png differ diff --git a/subsystems/mvdm/pifmgr/res/15.png b/subsystems/mvdm/pifmgr/res/15.png index 9de4b5e5c6f..d62c147963e 100644 Binary files a/subsystems/mvdm/pifmgr/res/15.png and b/subsystems/mvdm/pifmgr/res/15.png differ diff --git a/subsystems/mvdm/pifmgr/res/17.png b/subsystems/mvdm/pifmgr/res/17.png index 17fa0a20ebb..f944fb5ef80 100644 Binary files a/subsystems/mvdm/pifmgr/res/17.png and b/subsystems/mvdm/pifmgr/res/17.png differ diff --git a/subsystems/mvdm/pifmgr/res/18.png b/subsystems/mvdm/pifmgr/res/18.png index 1f766dd2dc5..b2468728a19 100644 Binary files a/subsystems/mvdm/pifmgr/res/18.png and b/subsystems/mvdm/pifmgr/res/18.png differ diff --git a/subsystems/mvdm/pifmgr/res/19.png b/subsystems/mvdm/pifmgr/res/19.png index 9b7bdea8d3b..6642158404b 100644 Binary files a/subsystems/mvdm/pifmgr/res/19.png and b/subsystems/mvdm/pifmgr/res/19.png differ diff --git a/subsystems/mvdm/pifmgr/res/20.png b/subsystems/mvdm/pifmgr/res/20.png index 8bbd3a36415..622a09ba937 100644 Binary files a/subsystems/mvdm/pifmgr/res/20.png and b/subsystems/mvdm/pifmgr/res/20.png differ diff --git a/subsystems/mvdm/pifmgr/res/22.png b/subsystems/mvdm/pifmgr/res/22.png index 252de311206..728b896ab83 100644 Binary files a/subsystems/mvdm/pifmgr/res/22.png and b/subsystems/mvdm/pifmgr/res/22.png differ diff --git a/subsystems/mvdm/pifmgr/res/23.png b/subsystems/mvdm/pifmgr/res/23.png index 2a95e45e8b3..f1326f8eaea 100644 Binary files a/subsystems/mvdm/pifmgr/res/23.png and b/subsystems/mvdm/pifmgr/res/23.png differ diff --git a/subsystems/mvdm/pifmgr/res/34.png b/subsystems/mvdm/pifmgr/res/34.png index d11d0f7e1b7..0d7665bcf6d 100644 Binary files a/subsystems/mvdm/pifmgr/res/34.png and b/subsystems/mvdm/pifmgr/res/34.png differ

1 year, 5 months

[reactos] 01/01: [NTUSER] co_IntSendMessageWithCallBack: Formatting only, no functional changes

by Joachim Henze

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6b7efb331c0cd20c8610c… commit 6b7efb331c0cd20c8610cd24d5e7221cff59969a Author: Joachim Henze <Joachim.Henze(a)reactos.org> AuthorDate: Sun Jul 30 21:39:10 2023 +0200 Commit: Joachim Henze <Joachim.Henze(a)reactos.org> CommitDate: Sun Jul 30 21:39:10 2023 +0200 [NTUSER] co_IntSendMessageWithCallBack: Formatting only, no functional changes e.g. wrong indentation. Want to port something back here, and the slight tweaking allows master to remain in sync with previous releases. --- win32ss/user/ntuser/message.c | 76 ++++++++++++++++++++----------------------- 1 file changed, 36 insertions(+), 40 deletions(-) diff --git a/win32ss/user/ntuser/message.c b/win32ss/user/ntuser/message.c index fbee45fec6b..78a7956d88b 100644 --- a/win32ss/user/ntuser/message.c +++ b/win32ss/user/ntuser/message.c @@ -2,7 +2,6 @@ * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS Win32k subsystem * PURPOSE: Messages - * FILE: win32ss/user/ntuser/message.c * PROGRAMER: Casper S. Hornstrup (chorns(a)users.sourceforge.net) */ @@ -1713,12 +1712,12 @@ co_IntSendMessageNoWait(HWND hWnd, LPARAM lParam) { ULONG_PTR Result = 0; - return co_IntSendMessageWithCallBack( hWnd, - Msg, - wParam, - lParam, - NULL, - 0, + return co_IntSendMessageWithCallBack(hWnd, + Msg, + wParam, + lParam, + NULL, + 0, &Result); } /* MSDN: @@ -1729,7 +1728,7 @@ co_IntSendMessageNoWait(HWND hWnd, process the message and the sender will free the memory before it is used. */ LRESULT FASTCALL -co_IntSendMessageWithCallBack( HWND hWnd, +co_IntSendMessageWithCallBack(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam, @@ -1750,7 +1749,7 @@ co_IntSendMessageWithCallBack( HWND hWnd, if (!(Window = UserGetWindowObject(hWnd))) { - TRACE("SendMessageWithCallBack: Invalid handle 0x%p!\n",hWnd); + TRACE("SendMessageWithCallBack: Invalid handle 0x%p\n",hWnd); RETURN(FALSE); } @@ -1759,29 +1758,26 @@ co_IntSendMessageWithCallBack( HWND hWnd, if (Window->state & WNDS_DESTROYED) { /* FIXME: last error? */ - ERR("Attempted to send message to window %p that is being destroyed!\n", hWnd); + ERR("Attempted to send message to window %p that is being destroyed\n", hWnd); RETURN(FALSE); } Win32Thread = PsGetCurrentThreadWin32Thread(); - if (Win32Thread == NULL || - Win32Thread->TIF_flags & TIF_INCLEANUP) - { + if (Win32Thread == NULL || Win32Thread->TIF_flags & TIF_INCLEANUP) RETURN(FALSE); - } ptiSendTo = IntSendTo(Window, Win32Thread, Msg); if (Msg & 0x80000000 && !ptiSendTo) { - if (Win32Thread->TIF_flags & TIF_INCLEANUP) RETURN( FALSE); + if (Win32Thread->TIF_flags & TIF_INCLEANUP) RETURN(FALSE); - TRACE("SMWCB: Internal Message!\n"); - Result = (ULONG_PTR)handle_internal_message( Window, Msg, wParam, lParam ); - if (uResult) *uResult = Result; - RETURN( TRUE); + TRACE("SMWCB: Internal Message\n"); + Result = (ULONG_PTR)handle_internal_message(Window, Msg, wParam, lParam); + if (uResult) *uResult = Result; + RETURN(TRUE); } /* See if this message type is present in the table */ @@ -1796,14 +1792,14 @@ co_IntSendMessageWithCallBack( HWND hWnd, if (!lParamBufferSize) lParamBufferSize = -1; } - if (! NT_SUCCESS(PackParam(&lParamPacked, Msg, wParam, lParam, !!ptiSendTo))) + if (!NT_SUCCESS(PackParam(&lParamPacked, Msg, wParam, lParam, !!ptiSendTo))) { ERR("Failed to pack message parameters\n"); - RETURN( FALSE); + RETURN(FALSE); } /* If it can be sent now, then send it. */ - if ( !ptiSendTo ) + if (!ptiSendTo) { if (Win32Thread->TIF_flags & TIF_INCLEANUP) { @@ -1812,9 +1808,9 @@ co_IntSendMessageWithCallBack( HWND hWnd, RETURN(FALSE); } - IntCallWndProc( Window, hWnd, Msg, wParam, lParam); + IntCallWndProc(Window, hWnd, Msg, wParam, lParam); - if ( Window->state & WNDS_SERVERSIDEWINDOWPROC ) + if (Window->state & WNDS_SERVERSIDEWINDOWPROC) { TRACE("SMWCB: Server Side Window Procedure\n"); switch(Window->fnid) @@ -1823,28 +1819,28 @@ co_IntSendMessageWithCallBack( HWND hWnd, DoCallBack = !DesktopWindowProc(Window, Msg, wParam, lParamPacked, (LRESULT*)&Result); break; case FNID_MESSAGEWND: - DoCallBack = !UserMessageWindowProc(Window, Msg, wParam, lParam,(LRESULT*)&Result); + DoCallBack = !UserMessageWindowProc(Window, Msg, wParam, lParam, (LRESULT*)&Result); break; case FNID_MENU: - DoCallBack = !PopupMenuWndProc( Window, Msg, wParam, lParam,(LRESULT*)&Result); + DoCallBack = !PopupMenuWndProc(Window, Msg, wParam, lParam, (LRESULT*)&Result); break; } } if (DoCallBack) - Result = (ULONG_PTR)co_IntCallWindowProc( Window->lpfnWndProc, - !Window->Unicode, - hWnd, - Msg, - wParam, - lParamPacked, - lParamBufferSize ); + Result = (ULONG_PTR)co_IntCallWindowProc(Window->lpfnWndProc, + !Window->Unicode, + hWnd, + Msg, + wParam, + lParamPacked, + lParamBufferSize); if(uResult) { *uResult = Result; } - IntCallWndProcRet( Window, hWnd, Msg, wParam, lParam, (LRESULT *)uResult); + IntCallWndProcRet(Window, hWnd, Msg, wParam, lParam, (LRESULT *)uResult); if (CompletionCallback) { @@ -1856,9 +1852,9 @@ co_IntSendMessageWithCallBack( HWND hWnd, } } - if ( !ptiSendTo) + if (!ptiSendTo) { - if (! NT_SUCCESS(UnpackParam(lParamPacked, Msg, wParam, lParam, FALSE))) + if (!NT_SUCCESS(UnpackParam(lParamPacked, Msg, wParam, lParam, FALSE))) { ERR("Failed to unpack message parameters\n"); } @@ -1867,7 +1863,7 @@ co_IntSendMessageWithCallBack( HWND hWnd, if(!(Message = AllocateUserMessage(FALSE))) { - ERR("MsqSendMessage(): Not enough memory to allocate a message\n"); + ERR("Failed to allocate message\n"); RETURN(FALSE); } @@ -1879,7 +1875,7 @@ co_IntSendMessageWithCallBack( HWND hWnd, Message->lResult = 0; Message->QS_Flags = 0; Message->ptiReceiver = ptiSendTo; - Message->ptiSender = NULL; // mjmartin, you are right! This is null. + Message->ptiSender = NULL; Message->ptiCallBackSender = Win32Thread; Message->CompletionCallback = CompletionCallback; Message->CompletionCallbackContext = CompletionCallbackContext; @@ -1889,9 +1885,9 @@ co_IntSendMessageWithCallBack( HWND hWnd, Message->flags = SMF_RECEIVERFREE; if (Msg & 0x80000000) // Higher priority event message! - InsertHeadList(&ptiSendTo->SentMessagesListHead, &Message->ListEntry); + InsertHeadList(&ptiSendTo->SentMessagesListHead, &Message->ListEntry); else - InsertTailList(&ptiSendTo->SentMessagesListHead, &Message->ListEntry); + InsertTailList(&ptiSendTo->SentMessagesListHead, &Message->ListEntry); MsqWakeQueue(ptiSendTo, QS_SENDMESSAGE, TRUE); RETURN(TRUE);

1 year, 5 months

[reactos] 01/01: [ATL] Overload const-return-versions of FindChar/FindString/FindOneOf (#5473)

by Katayama Hirofumi MZ

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=985680068c41fe90d3d19… commit 985680068c41fe90d3d19ee6777f2f982672b931 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Sun Jul 30 07:59:01 2023 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Jul 30 07:59:01 2023 +0900 [ATL] Overload const-return-versions of FindChar/FindString/FindOneOf (#5473) Overload the const-return-versions of FindChar/FindCharReverse/FindString/FindOneOf. Modify CStringT::Replace. --- sdk/lib/atl/atlsimpstr.h | 4 ++++ sdk/lib/atl/cstringt.h | 50 +++++++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 53 insertions(+), 1 deletion(-) diff --git a/sdk/lib/atl/atlsimpstr.h b/sdk/lib/atl/atlsimpstr.h index c06a8e46cc5..7d78f41abc4 100644 --- a/sdk/lib/atl/atlsimpstr.h +++ b/sdk/lib/atl/atlsimpstr.h @@ -358,6 +358,10 @@ public: return GetData()->nDataLength; } + PXSTR GetString() throw() + { + return m_pszData; + } PCXSTR GetString() const throw() { return m_pszData; diff --git a/sdk/lib/atl/cstringt.h b/sdk/lib/atl/cstringt.h index 748cbcba993..2e5a18b1a54 100644 --- a/sdk/lib/atl/cstringt.h +++ b/sdk/lib/atl/cstringt.h @@ -99,6 +99,12 @@ public: } static LPWSTR __cdecl FindString( + _In_z_ LPWSTR pszSource, + _In_z_ LPCWSTR pszSub) + { + return ::wcsstr(pszSource, pszSub); + } + static LPCWSTR __cdecl FindString( _In_z_ LPCWSTR pszSource, _In_z_ LPCWSTR pszSub) { @@ -106,6 +112,12 @@ public: } static LPWSTR __cdecl FindChar( + _In_z_ LPWSTR pszSource, + _In_ WCHAR ch) + { + return ::wcschr(pszSource, ch); + } + static LPCWSTR __cdecl FindChar( _In_z_ LPCWSTR pszSource, _In_ WCHAR ch) { @@ -113,6 +125,12 @@ public: } static LPWSTR __cdecl FindCharReverse( + _In_z_ LPWSTR pszSource, + _In_ WCHAR ch) + { + return ::wcsrchr(pszSource, ch); + } + static LPCWSTR __cdecl FindCharReverse( _In_z_ LPCWSTR pszSource, _In_ WCHAR ch) { @@ -120,6 +138,12 @@ public: } static LPWSTR __cdecl FindOneOf( + _In_z_ LPWSTR pszSource, + _In_z_ LPCWSTR pszCharSet) + { + return ::wcspbrk(pszSource, pszCharSet); + } + static LPCWSTR __cdecl FindOneOf( _In_z_ LPCWSTR pszSource, _In_z_ LPCWSTR pszCharSet) { @@ -262,6 +286,12 @@ public: } static LPSTR __cdecl FindString( + _In_z_ LPSTR pszSource, + _In_z_ LPCSTR pszSub) + { + return ::strstr(pszSource, pszSub); + } + static LPCSTR __cdecl FindString( _In_z_ LPCSTR pszSource, _In_z_ LPCSTR pszSub) { @@ -269,6 +299,12 @@ public: } static LPSTR __cdecl FindChar( + _In_z_ LPSTR pszSource, + _In_ CHAR ch) + { + return ::strchr(pszSource, ch); + } + static LPCSTR __cdecl FindChar( _In_z_ LPCSTR pszSource, _In_ CHAR ch) { @@ -276,6 +312,12 @@ public: } static LPSTR __cdecl FindCharReverse( + _In_z_ LPSTR pszSource, + _In_ CHAR ch) + { + return ::strrchr(pszSource, ch); + } + static LPCSTR __cdecl FindCharReverse( _In_z_ LPCSTR pszSource, _In_ CHAR ch) { @@ -283,6 +325,12 @@ public: } static LPSTR __cdecl FindOneOf( + _In_z_ LPSTR pszSource, + _In_z_ LPCSTR pszCharSet) + { + return ::strpbrk(pszSource, pszCharSet); + } + static LPCSTR __cdecl FindOneOf( _In_z_ LPCSTR pszSource, _In_z_ LPCSTR pszCharSet) { @@ -876,7 +924,7 @@ public: int Replace(XCHAR chOld, XCHAR chNew) { - PCXSTR pszString = CThisSimpleString::GetString(); + PXSTR pszString = CThisSimpleString::GetString(); PXSTR pszFirst = StringTraits::FindChar(pszString, chOld); if (!pszFirst) return 0;

1 year, 5 months

[reactos] 01/01: [IP] Unlock Connection when TCPAllocatePort() fails. CORE-18371

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2010a5b8d915beebd64c6… commit 2010a5b8d915beebd64c68cb568b03c29ab64d75 Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Mon Jul 24 22:38:27 2023 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sat Jul 29 11:23:13 2023 -0400 [IP] Unlock Connection when TCPAllocatePort() fails. CORE-18371 Addendum to 874d317 (0.4.15-dev-5707, #5074). --- drivers/network/tcpip/ip/transport/tcp/accept.c | 1 + drivers/network/tcpip/ip/transport/tcp/tcp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/network/tcpip/ip/transport/tcp/accept.c b/drivers/network/tcpip/ip/transport/tcp/accept.c index 4d12c527fae..cfab933003d 100644 --- a/drivers/network/tcpip/ip/transport/tcp/accept.c +++ b/drivers/network/tcpip/ip/transport/tcp/accept.c @@ -82,6 +82,7 @@ NTSTATUS TCPListen(PCONNECTION_ENDPOINT Connection, UINT Backlog) if (AllocatedPort == (UINT) -1) { DbgPrint("ERR: No more ports available.\n"); + UnlockObject(Connection); return STATUS_TOO_MANY_ADDRESSES; } Connection->AddressFile->Port = AllocatedPort; diff --git a/drivers/network/tcpip/ip/transport/tcp/tcp.c b/drivers/network/tcpip/ip/transport/tcp/tcp.c index cd28ffaf71a..3d65e9a46b9 100644 --- a/drivers/network/tcpip/ip/transport/tcp/tcp.c +++ b/drivers/network/tcpip/ip/transport/tcp/tcp.c @@ -386,6 +386,7 @@ NTSTATUS TCPConnect if (AllocatedPort == (UINT) -1) { DbgPrint("ERR: No more ports available.\n"); + UnlockObject(Connection); return STATUS_TOO_MANY_ADDRESSES; } Connection->AddressFile->Port = AllocatedPort;

1 year, 5 months

[reactos] 14/14: [NTOS:Mm] Fix some 64 bit issues

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=539c31658985005bf22a9… commit 539c31658985005bf22a9fb03b967d7bbae1417d Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Fri Apr 14 10:34:21 2023 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Jul 29 14:00:44 2023 +0300 [NTOS:Mm] Fix some 64 bit issues --- ntoskrnl/mm/i386/page.c | 2 +- ntoskrnl/mm/pagefile.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ntoskrnl/mm/i386/page.c b/ntoskrnl/mm/i386/page.c index 38cd5066256..e0f7a304c8b 100644 --- a/ntoskrnl/mm/i386/page.c +++ b/ntoskrnl/mm/i386/page.c @@ -598,7 +598,7 @@ MmCreatePageFileMapping(PEPROCESS Process, /* And we don't support creating for other process */ ASSERT(Process == PsGetCurrentProcess()); - if (SwapEntry & (1 << 31)) + if (SwapEntry & (1 << (sizeof(SWAPENTRY) - 1))) { KeBugCheck(MEMORY_MANAGEMENT); } diff --git a/ntoskrnl/mm/pagefile.c b/ntoskrnl/mm/pagefile.c index a57c4de0304..ae15771cad2 100644 --- a/ntoskrnl/mm/pagefile.c +++ b/ntoskrnl/mm/pagefile.c @@ -152,7 +152,7 @@ MmWriteToSwapPage(SWAPENTRY SwapEntry, PFN_NUMBER Page) IO_STATUS_BLOCK Iosb; NTSTATUS Status; KEVENT Event; - UCHAR MdlBase[sizeof(MDL) + sizeof(ULONG)]; + UCHAR MdlBase[sizeof(MDL) + sizeof(PFN_NUMBER)]; PMDL Mdl = (PMDL)MdlBase; DPRINT("MmWriteToSwapPage\n"); @@ -217,7 +217,7 @@ MiReadPageFile( IO_STATUS_BLOCK Iosb; NTSTATUS Status; KEVENT Event; - UCHAR MdlBase[sizeof(MDL) + sizeof(ULONG)]; + UCHAR MdlBase[sizeof(MDL) + sizeof(PFN_NUMBER)]; PMDL Mdl = (PMDL)MdlBase; PMMPAGING_FILE PagingFile;

1 year, 5 months

[reactos] 13/14: NTOS:CC Free some VACBs when we're under memory pressure

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=69daff72d2607e514a4c8… commit 69daff72d2607e514a4c8590c26c009da7f9d5b1 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Sat Oct 1 22:48:46 2022 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Jul 29 14:00:44 2023 +0300 NTOS:CC Free some VACBs when we're under memory pressure --- ntoskrnl/cc/lazywrite.c | 10 +++++ ntoskrnl/cc/view.c | 88 ++++++++++++++---------------------------- ntoskrnl/include/internal/cc.h | 4 ++ 3 files changed, 44 insertions(+), 58 deletions(-) diff --git a/ntoskrnl/cc/lazywrite.c b/ntoskrnl/cc/lazywrite.c index 607a469d20d..87216bf3bef 100644 --- a/ntoskrnl/cc/lazywrite.c +++ b/ntoskrnl/cc/lazywrite.c @@ -130,6 +130,16 @@ CcWriteBehind(VOID) ++CcLazyWriteIos; DPRINT("Lazy writer done (%d)\n", Count); } + + /* Make sure we're not throttling writes after this */ + while (MmAvailablePages < MmThrottleTop) + { + /* Break if we can't even find one to free */ + if (!CcRosFreeOneUnusedVacb()) + { + break; + } + } } VOID diff --git a/ntoskrnl/cc/view.c b/ntoskrnl/cc/view.c index a40272f8f34..25d066abd03 100644 --- a/ntoskrnl/cc/view.c +++ b/ntoskrnl/cc/view.c @@ -595,34 +595,26 @@ CcRosUnmarkDirtyVacb ( } } -static BOOLEAN -CcRosFreeUnusedVacb ( - PULONG Count) +CcRosFreeOneUnusedVacb( + VOID) { - ULONG cFreed; - BOOLEAN Freed; KIRQL oldIrql; - PROS_VACB current; - LIST_ENTRY FreeList; PLIST_ENTRY current_entry; - - cFreed = 0; - Freed = FALSE; - InitializeListHead(&FreeList); + PROS_VACB to_free = NULL; oldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock); /* Browse all the available VACB */ current_entry = VacbLruListHead.Flink; - while (current_entry != &VacbLruListHead) + while ((current_entry != &VacbLruListHead) && (to_free == NULL)) { ULONG Refs; + PROS_VACB current; current = CONTAINING_RECORD(current_entry, ROS_VACB, VacbLruListEntry); - current_entry = current_entry->Flink; KeAcquireSpinLockAtDpcLevel(&current->SharedCacheMap->CacheMapLock); @@ -634,47 +626,32 @@ CcRosFreeUnusedVacb ( ASSERT(!current->MappedCount); ASSERT(Refs == 1); - /* Reset and move to free list */ + /* Reset it, this is the one we want to free */ RemoveEntryList(&current->CacheMapVacbListEntry); + InitializeListHead(&current->CacheMapVacbListEntry); RemoveEntryList(&current->VacbLruListEntry); InitializeListHead(&current->VacbLruListEntry); - InsertHeadList(&FreeList, &current->CacheMapVacbListEntry); + + to_free = current; } KeReleaseSpinLockFromDpcLevel(&current->SharedCacheMap->CacheMapLock); + current_entry = current_entry->Flink; } KeReleaseQueuedSpinLock(LockQueueMasterLock, oldIrql); - /* And now, free any of the found VACB, that'll free memory! */ - while (!IsListEmpty(&FreeList)) + /* And now, free the VACB that we found, if any. */ + if (to_free == NULL) { - ULONG Refs; - - current_entry = RemoveHeadList(&FreeList); - current = CONTAINING_RECORD(current_entry, - ROS_VACB, - CacheMapVacbListEntry); - InitializeListHead(&current->CacheMapVacbListEntry); - Refs = CcRosVacbDecRefCount(current); - ASSERT(Refs == 0); - ++cFreed; - } - - /* If we freed at least one VACB, return success */ - if (cFreed != 0) - { - Freed = TRUE; + return FALSE; } - /* If caller asked for free count, return it */ - if (Count != NULL) - { - *Count = cFreed; - } + /* This must be its last ref */ + NT_VERIFY(CcRosVacbDecRefCount(to_free) == 0); - return Freed; + return TRUE; } static @@ -690,7 +667,6 @@ CcRosCreateVacb ( NTSTATUS Status; KIRQL oldIrql; ULONG Refs; - BOOLEAN Retried; SIZE_T ViewSize = VACB_MAPPING_GRANULARITY; ASSERT(SharedCacheMap); @@ -711,28 +687,24 @@ CcRosCreateVacb ( CcRosVacbIncRefCount(current); - Retried = FALSE; -Retry: - /* Map VACB in system space */ - Status = MmMapViewInSystemSpaceEx(SharedCacheMap->Section, &current->BaseAddress, &ViewSize, &current->FileOffset, 0); - - if (!NT_SUCCESS(Status)) + while (TRUE) { - ULONG Freed; - /* If no space left, try to prune unused VACB - * to recover space to map our VACB - * If it succeed, retry to map, otherwise - * just fail. - */ - if (!Retried && CcRosFreeUnusedVacb(&Freed)) + /* Map VACB in system space */ + Status = MmMapViewInSystemSpaceEx(SharedCacheMap->Section, &current->BaseAddress, &ViewSize, &current->FileOffset, 0); + if (NT_SUCCESS(Status)) { - DPRINT("Prunned %d VACB, trying again\n", Freed); - Retried = TRUE; - goto Retry; + break; } - ExFreeToNPagedLookasideList(&VacbLookasideList, current); - return Status; + /* + * If no space left, try to prune one unused VACB to recover space to map our VACB. + * If it succeeds, retry to map, otherwise just fail. + */ + if (!CcRosFreeOneUnusedVacb()) + { + ExFreeToNPagedLookasideList(&VacbLookasideList, current); + return Status; + } } #if DBG diff --git a/ntoskrnl/include/internal/cc.h b/ntoskrnl/include/internal/cc.h index a56118a8558..90c315901d1 100644 --- a/ntoskrnl/include/internal/cc.h +++ b/ntoskrnl/include/internal/cc.h @@ -509,3 +509,7 @@ CcRosVacbDecRefCount( } #define CcRosVacbGetRefCount(vacb) InterlockedCompareExchange((PLONG)&(vacb)->ReferenceCount, 0, 0) #endif + +BOOLEAN +CcRosFreeOneUnusedVacb( + VOID);

1 year, 5 months

[reactos] 12/14: Revert "[NTOS:CC] Wake up lazy scan after inserting elements in the list."

by Jérôme Gardou

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=470ad188258a3561ef595… commit 470ad188258a3561ef595fc281f1643eda24e880 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Fri Sep 23 23:00:18 2022 +0200 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Jul 29 14:00:44 2023 +0300 Revert "[NTOS:CC] Wake up lazy scan after inserting elements in the list." This reverts commit 6e4f83da700fbfac5450dc9ef667585ddc870bc9. --- ntoskrnl/cc/copy.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/ntoskrnl/cc/copy.c b/ntoskrnl/cc/copy.c index 7b43ab51e60..e01f2b46865 100644 --- a/ntoskrnl/cc/copy.c +++ b/ntoskrnl/cc/copy.c @@ -400,6 +400,16 @@ CcCanIWrite ( return FALSE; } + /* Otherwise, if there are no deferred writes yet, start the lazy writer */ + if (IsListEmpty(&CcDeferredWrites)) + { + KIRQL OldIrql; + + OldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock); + CcScheduleLazyWriteScan(TRUE); + KeReleaseQueuedSpinLock(LockQueueMasterLock, OldIrql); + } + /* Initialize our wait event */ KeInitializeEvent(&WaitEvent, NotificationEvent, FALSE); @@ -427,12 +437,6 @@ CcCanIWrite ( &CcDeferredWriteSpinLock); } - /* Now make sure that the lazy scan writer will be active */ - OldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock); - if (!LazyWriter.ScanActive) - CcScheduleLazyWriteScan(TRUE); - KeReleaseQueuedSpinLock(LockQueueMasterLock, OldIrql); - #if DBG DPRINT1("Actively deferring write for: %p\n", FileObject); DPRINT1("Because:\n");

1 year, 5 months

[reactos] 11/14: [NTOS:Mm] Use MmRebalanceMemoryConsumersAndWait in the page fault handler

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=876769fdd50c911638bd9… commit 876769fdd50c911638bd91329ceed56ee6eaa1ce Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Wed Apr 5 23:02:43 2023 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Jul 29 14:00:44 2023 +0300 [NTOS:Mm] Use MmRebalanceMemoryConsumersAndWait in the page fault handler --- ntoskrnl/mm/ARM3/pagfault.c | 19 ++++++++++++++++++- ntoskrnl/mm/mmfault.c | 18 ++++++++++++++++-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/ntoskrnl/mm/ARM3/pagfault.c b/ntoskrnl/mm/ARM3/pagfault.c index a312f4a8bdd..b9a855662d9 100644 --- a/ntoskrnl/mm/ARM3/pagfault.c +++ b/ntoskrnl/mm/ARM3/pagfault.c @@ -15,6 +15,10 @@ #define MODULE_INVOLVED_IN_ARM3 #include <mm/ARM3/miarm.h> +VOID +NTAPI +MmRebalanceMemoryConsumersAndWait(VOID); + /* GLOBALS ********************************************************************/ #define HYDRA_PROCESS (PEPROCESS)1 @@ -1940,7 +1944,7 @@ _WARN("Session space stuff is not implemented yet!") return STATUS_IN_PAGE_ERROR | 0x10000000; } } - +RetryKernel: /* Acquire the working set lock */ KeRaiseIrql(APC_LEVEL, &LockIrql); MiLockWorkingSet(CurrentThread, WorkingSet); @@ -2107,6 +2111,12 @@ _WARN("Session space stuff is not implemented yet!") MiUnlockWorkingSet(CurrentThread, WorkingSet); KeLowerIrql(LockIrql); + if (Status == STATUS_NO_MEMORY) + { + MmRebalanceMemoryConsumersAndWait(); + goto RetryKernel; + } + /* We are done! */ DPRINT("Fault resolved with status: %lx\n", Status); return Status; @@ -2616,6 +2626,13 @@ ExitUser: /* Return the status */ ASSERT(KeGetCurrentIrql() <= APC_LEVEL); MiUnlockProcessWorkingSet(CurrentProcess, CurrentThread); + + if (Status == STATUS_NO_MEMORY) + { + MmRebalanceMemoryConsumersAndWait(); + goto UserFault; + } + return Status; } diff --git a/ntoskrnl/mm/mmfault.c b/ntoskrnl/mm/mmfault.c index 82633916a16..7937f7b5e5b 100644 --- a/ntoskrnl/mm/mmfault.c +++ b/ntoskrnl/mm/mmfault.c @@ -200,6 +200,10 @@ MmNotPresentFault(KPROCESSOR_MODE Mode, extern BOOLEAN Mmi386MakeKernelPageTableGlobal(PVOID Address); +VOID +NTAPI +MmRebalanceMemoryConsumersAndWait(VOID); + NTSTATUS NTAPI MmAccessFault(IN ULONG FaultCode, @@ -208,6 +212,7 @@ MmAccessFault(IN ULONG FaultCode, IN PVOID TrapInformation) { PMEMORY_AREA MemoryArea = NULL; + NTSTATUS Status; /* Cute little hack for ROS */ if ((ULONG_PTR)Address >= (ULONG_PTR)MmSystemRangeStart) @@ -252,16 +257,25 @@ MmAccessFault(IN ULONG FaultCode, return MmArmAccessFault(FaultCode, Address, Mode, TrapInformation); } +Retry: /* Keep same old ReactOS Behaviour */ if (!MI_IS_NOT_PRESENT_FAULT(FaultCode)) { /* Call access fault */ - return MmpAccessFault(Mode, (ULONG_PTR)Address, TrapInformation ? FALSE : TRUE); + Status = MmpAccessFault(Mode, (ULONG_PTR)Address, TrapInformation ? FALSE : TRUE); } else { /* Call not present */ - return MmNotPresentFault(Mode, (ULONG_PTR)Address, TrapInformation ? FALSE : TRUE); + Status = MmNotPresentFault(Mode, (ULONG_PTR)Address, TrapInformation ? FALSE : TRUE); } + + if (Status == STATUS_NO_MEMORY) + { + MmRebalanceMemoryConsumersAndWait(); + goto Retry; + } + + return Status; }

1 year, 5 months

[reactos] 10/14: [NTOS:Mm] Implement MmRebalanceMemoryConsumersAndWait

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=047dc9729f0cbf0b7b757… commit 047dc9729f0cbf0b7b7571ae522a9f8677943959 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Thu Apr 6 08:42:32 2023 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Sat Jul 29 14:00:44 2023 +0300 [NTOS:Mm] Implement MmRebalanceMemoryConsumersAndWait --- ntoskrnl/mm/balance.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/ntoskrnl/mm/balance.c b/ntoskrnl/mm/balance.c index f81027a65cd..ab71d0f195b 100644 --- a/ntoskrnl/mm/balance.c +++ b/ntoskrnl/mm/balance.c @@ -33,6 +33,7 @@ static ULONG MiMinimumPagesPerRun; static CLIENT_ID MiBalancerThreadId; static HANDLE MiBalancerThreadHandle = NULL; static KEVENT MiBalancerEvent; +static KEVENT MiBalancerDoneEvent; static KTIMER MiBalancerTimer; static LONG PageOutThreadActive; @@ -296,6 +297,19 @@ MmRebalanceMemoryConsumers(VOID) } } +VOID +NTAPI +MmRebalanceMemoryConsumersAndWait(VOID) +{ + ASSERT(PsGetCurrentProcess()->AddressCreationLock.Owner != KeGetCurrentThread()); + ASSERT(!MM_ANY_WS_LOCK_HELD(PsGetCurrentThread())); + ASSERT(KeGetCurrentIrql() < DISPATCH_LEVEL); + + KeResetEvent(&MiBalancerDoneEvent); + MmRebalanceMemoryConsumers(); + KeWaitForSingleObject(&MiBalancerDoneEvent, Executive, KernelMode, FALSE, NULL); +} + NTSTATUS NTAPI MmRequestPageMemoryConsumer(ULONG Consumer, BOOLEAN CanWait, @@ -334,6 +348,7 @@ MiBalancerThread(PVOID Unused) while (1) { + KeSetEvent(&MiBalancerDoneEvent, IO_NO_INCREMENT, FALSE); Status = KeWaitForMultipleObjects(2, WaitObjects, WaitAny, @@ -388,6 +403,7 @@ MiInitBalancerThread(VOID) LARGE_INTEGER Timeout; KeInitializeEvent(&MiBalancerEvent, SynchronizationEvent, FALSE); + KeInitializeEvent(&MiBalancerDoneEvent, SynchronizationEvent, FALSE); KeInitializeTimerEx(&MiBalancerTimer, SynchronizationTimer); Timeout.QuadPart = -20000000; /* 2 sec */

1 year, 5 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs