Ros-diffs

ros-diffs@reactos.org

81390 discussions

[reactos] 01/01: [SHELL32] Enable Network Connection Rename (#5073)
by Jose Carlos Jesus 30 Apr '23

30 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=39d5f1bf54a0f22fff618… commit 39d5f1bf54a0f22fff618e269c0dd2711aacc7f8 Author: Jose Carlos Jesus <zecarlos1957(a)hotmail.com> AuthorDate: Sun Apr 30 14:40:10 2023 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Apr 30 15:40:10 2023 +0200 [SHELL32] Enable Network Connection Rename (#5073) CORE-18750 - Add Network Connection pidl type 0x99; - Add binary comparison to pidl memory range. --- dll/win32/shell32/debughlp.cpp | 1 + dll/win32/shell32/wine/pidl.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/dll/win32/shell32/debughlp.cpp b/dll/win32/shell32/debughlp.cpp index 6778418c7a8..388349c70a6 100644 --- a/dll/win32/shell32/debughlp.cpp +++ b/dll/win32/shell32/debughlp.cpp @@ -379,6 +379,7 @@ BOOL pcheck( LPCITEMIDLIST pidl ) case PT_YAGUID: case PT_IESPECIAL2: case PT_SHARE: + case 0x99: /* Network Connection pidl type */ break; default: ERR("unknown IDLIST %p [%p] size=%u type=%x\n", diff --git a/dll/win32/shell32/wine/pidl.c b/dll/win32/shell32/wine/pidl.c index 2ee8c4650fc..9ade43d1956 100644 --- a/dll/win32/shell32/wine/pidl.c +++ b/dll/win32/shell32/wine/pidl.c @@ -522,7 +522,11 @@ BOOL _ILHACKCompareSimpleIds(LPCITEMIDLIST pidltemp1, LPCITEMIDLIST pidltemp2) } else { - return FALSE; + if ((pidltemp1->mkid.cb != pidltemp2->mkid.cb) || + !RtlEqualMemory((BYTE*)&pidltemp1->mkid, (BYTE*)&pidltemp2->mkid, pidltemp1->mkid.cb)) + { + return FALSE; + } } return TRUE;

1 0

[reactos] 01/01: [SETUPAPI] Sync setupapi/queue.c to Wine 4.8 (#5233)
by Doug Lyons 30 Apr '23

30 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5c8ec78b71de9a2ea4fac… commit 5c8ec78b71de9a2ea4faca4c7beec1e54a172a40 Author: Doug Lyons <douglyons(a)douglyons.com> AuthorDate: Sun Apr 30 08:34:26 2023 -0500 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Apr 30 15:34:26 2023 +0200 [SETUPAPI] Sync setupapi/queue.c to Wine 4.8 (#5233) Sync setupapi/queue.c to Wine 4.8 to improve cab extraction. This fixes 'fixme:(dll/win32/setupapi/queue.c:418) awful hack: extracting cabinet' --- dll/win32/setupapi/queue.c | 156 ++++++++++++++++----------------------------- media/doc/WINESYNC.txt | 2 +- 2 files changed, 55 insertions(+), 103 deletions(-) diff --git a/dll/win32/setupapi/queue.c b/dll/win32/setupapi/queue.c index 54517205729..f33fbb8f6fe 100644 --- a/dll/win32/setupapi/queue.c +++ b/dll/win32/setupapi/queue.c @@ -361,12 +361,52 @@ static WCHAR *get_destination_dir( HINF hinf, const WCHAR *section ) return PARSER_get_dest_dir( &context ); } +struct extract_cab_ctx +{ + const WCHAR *src; + const WCHAR *dst; +}; -#ifndef __REACTOS__ -static void (WINAPI *pExtractFiles)( LPSTR, LPSTR, DWORD, DWORD, DWORD, DWORD ); -#else -static void (WINAPI *pExtractFiles)( LPSTR, LPSTR, DWORD, LPSTR, LPVOID, DWORD ); -#endif +static UINT WINAPI extract_cab_cb( void *arg, UINT message, UINT_PTR param1, UINT_PTR param2 ) +{ + struct extract_cab_ctx *ctx = arg; + + switch (message) + { + case SPFILENOTIFY_FILEINCABINET: + { + FILE_IN_CABINET_INFO_W *info = (FILE_IN_CABINET_INFO_W *)param1; + const WCHAR *filename; + + if ((filename = strrchrW( info->NameInCabinet, '\\' ))) + filename++; + else + filename = info->NameInCabinet; + + if (lstrcmpiW( filename, ctx->src )) + return FILEOP_SKIP; + + strcpyW( info->FullTargetName, ctx->dst ); + return FILEOP_DOIT; + } + case SPFILENOTIFY_FILEEXTRACTED: + { + const FILEPATHS_W *paths = (const FILEPATHS_W *)param1; + return paths->Win32Error; + } + case SPFILENOTIFY_NEEDNEWCABINET: + { + const CABINET_INFO_W *info = (const CABINET_INFO_W *)param1; + strcpyW( (WCHAR *)param2, info->CabinetPath ); + return ERROR_SUCCESS; + } + case SPFILENOTIFY_CABINETINFO: + return 0; + default: + FIXME("Unexpected message %#x.\n", message); + return 0; + } +} /*********************************************************************** * extract_cabinet_file @@ -379,111 +419,23 @@ static BOOL extract_cabinet_file( const WCHAR *cabinet, const WCHAR *root, #ifndef __REACTOS__ static const WCHAR extW[] = {'.','c','a','b',0}; #endif - static HMODULE advpack; - - char *cab_path, *cab_file; - int len = strlenW( cabinet ); + static const WCHAR backslashW[] = {'\\',0}; + WCHAR path[MAX_PATH]; + struct extract_cab_ctx ctx = {src, dst}; #ifdef __REACTOS__ TRACE("extract_cabinet_file(cab = '%s' ; root = '%s' ; src = '%s' ; dst = '%s')\n", debugstr_w(cabinet), debugstr_w(root), debugstr_w(src), debugstr_w(dst)); #else + int len = strlenW( cabinet ); /* make sure the cabinet file has a .cab extension */ if (len <= 4 || strcmpiW( cabinet + len - 4, extW )) return FALSE; #endif - if (!pExtractFiles) - { - if (!advpack && !(advpack = LoadLibraryA( "advpack.dll" ))) - { - ERR( "could not load advpack.dll\n" ); - return FALSE; - } - if (!(pExtractFiles = (void *)GetProcAddress( advpack, "ExtractFiles" ))) - { - ERR( "could not find ExtractFiles in advpack.dll\n" ); - return FALSE; - } - } - - if (!(cab_path = strdupWtoA( root ))) return FALSE; - len = WideCharToMultiByte( CP_ACP, 0, cabinet, -1, NULL, 0, NULL, NULL ); - if (!(cab_file = HeapAlloc( GetProcessHeap(), 0, strlen(cab_path) + len + 1 ))) - { - HeapFree( GetProcessHeap(), 0, cab_path ); - return FALSE; - } - strcpy( cab_file, cab_path ); - if (cab_file[0] && cab_file[strlen(cab_file)-1] != '\\') strcat( cab_file, "\\" ); - WideCharToMultiByte( CP_ACP, 0, cabinet, -1, cab_file + strlen(cab_file), len, NULL, NULL ); - FIXME( "awful hack: extracting cabinet %s\n", debugstr_a(cab_file) ); - -#ifdef __REACTOS__ - { - BOOL Success; - char *src_file; - const WCHAR *src_fileW; - WCHAR TempPath[MAX_PATH]; - - /* Retrieve the temporary path */ - if (!GetTempPathW(ARRAYSIZE(TempPath), TempPath)) - { - ERR("GetTempPathW error\n"); - HeapFree( GetProcessHeap(), 0, cab_file ); - return FALSE; - } + strcpyW(path, root); + strcatW(path, backslashW); + strcatW(path, cabinet); - /* Build the real path to where the file will be extracted */ - HeapFree( GetProcessHeap(), 0, cab_path ); - if (!(cab_path = strdupWtoA( TempPath ))) - { - HeapFree( GetProcessHeap(), 0, cab_file ); - return FALSE; - } - - /* Build the file list */ - src_fileW = strrchrW(src, '\\'); // Find where the filename starts. - if (src_fileW) ++src_fileW; - else src_fileW = src; - /* Convert to ANSI */ - if (!(src_file = strdupWtoA( src_fileW ))) - { - HeapFree( GetProcessHeap(), 0, cab_file ); - HeapFree( GetProcessHeap(), 0, cab_path ); - return FALSE; - } - - /* Prepare for the move operation */ - /* Build the full path to the extracted file, that will be renamed */ - if (!(src = HeapAlloc( GetProcessHeap(), 0, (strlenW(TempPath) + 1 + strlenW(src_fileW) + 1) * sizeof(WCHAR) ))) - { - HeapFree( GetProcessHeap(), 0, src_file ); - HeapFree( GetProcessHeap(), 0, cab_file ); - HeapFree( GetProcessHeap(), 0, cab_path ); - return FALSE; - } - concat_W( (WCHAR*)src, NULL, TempPath, src_fileW ); - - TRACE("pExtractFiles(cab_file = '%s' ; cab_path = '%s', src_file = '%s')\n", - debugstr_a(cab_file), debugstr_a(cab_path), debugstr_a(src_file)); - - /* Extract to temporary folder */ - pExtractFiles( cab_file, cab_path, 0, src_file, NULL, 0 ); - HeapFree( GetProcessHeap(), 0, src_file ); - HeapFree( GetProcessHeap(), 0, cab_file ); - HeapFree( GetProcessHeap(), 0, cab_path ); - - /* Move to destination, overwriting the original file if needed */ - TRACE("Renaming src = '%s' to dst = '%s')\n", debugstr_w(src), debugstr_w(dst)); - Success = MoveFileExW( src, dst , MOVEFILE_REPLACE_EXISTING | MOVEFILE_COPY_ALLOWED ); - HeapFree( GetProcessHeap(), 0, (WCHAR*)src ); - return Success; - } -#else - pExtractFiles( cab_file, cab_path, 0, 0, 0, 0 ); - HeapFree( GetProcessHeap(), 0, cab_file ); - HeapFree( GetProcessHeap(), 0, cab_path ); - return CopyFileW( src, dst, FALSE /*FIXME*/ ); -#endif + return SetupIterateCabinetW( path, 0, extract_cab_cb, &ctx ); } @@ -1493,7 +1445,7 @@ BOOL WINAPI SetupCommitFileQueueW( HWND owner, HSPFILEQ handle, PSP_FILE_CALLBAC if (op->src_tag) { if (extract_cabinet_file( op->src_tag, op->src_root, - paths.Source, paths.Target )) break; + op->src_file, paths.Target )) break; } paths.Win32Error = GetLastError(); op_result = handler( context, SPFILENOTIFY_COPYERROR, diff --git a/media/doc/WINESYNC.txt b/media/doc/WINESYNC.txt index cb460336c0d..5ae9963f7de 100644 --- a/media/doc/WINESYNC.txt +++ b/media/doc/WINESYNC.txt @@ -363,7 +363,7 @@ secur32 - setupapi - dll/win32/setupapi/dialog.c # Synced to WineStaging-1.9.15 - dll/win32/setupapi/query.c # Partially synced to WineStaging-1.9.4 + dll/win32/setupapi/query.c # Partially synced to Wine-4.8 dll/win32/setupapi/setupcab.c # Synced to WineStaging-1.9.4 win32k -

1 0

[reactos] 01/01: [COMDLG32] Enable saving files with different extension (#4903)
by Jose Carlos Jesus 30 Apr '23

30 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a0d747fa5051e2795df65… commit a0d747fa5051e2795df6549b786ba8f2c9f6e1a6 Author: Jose Carlos Jesus <zecarlos1957(a)hotmail.com> AuthorDate: Sun Apr 30 14:21:20 2023 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Apr 30 15:21:20 2023 +0200 [COMDLG32] Enable saving files with different extension (#4903) As on Windows, gives precedence to the user's extension in file names if there is one. Otherwise appends the selected extension. If not selected, append default extension. --- dll/win32/comdlg32/filedlg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dll/win32/comdlg32/filedlg.c b/dll/win32/comdlg32/filedlg.c index cf1d2bc34c2..54bbc544aab 100644 --- a/dll/win32/comdlg32/filedlg.c +++ b/dll/win32/comdlg32/filedlg.c @@ -3099,6 +3099,7 @@ BOOL FILEDLG95_OnOpen(HWND hwnd) /* Attach the file extension with file name*/ ext = PathFindExtensionW(lpstrPathAndFile); #ifdef __REACTOS__ + if (*ext == UNICODE_NULL && fodInfos->defext) { LPWSTR filterExt = NULL, lpstrFilter = NULL, pch, pchNext; LPCWSTR the_ext = NULL;

1 0

[reactos] 01/01: [FREELDR] Add disk access handlers for UEFI (#5219)
by Justin Miller 30 Apr '23

30 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=1fd9d11f160c10e70311b… commit 1fd9d11f160c10e70311b4176d0fad950b6cfe54 Author: Justin Miller <justinmiller100(a)gmail.com> AuthorDate: Sun Apr 30 05:57:10 2023 -0700 Commit: GitHub <noreply(a)github.com> CommitDate: Sun Apr 30 14:57:10 2023 +0200 [FREELDR] Add disk access handlers for UEFI (#5219) CORE-11953 --- boot/freeldr/freeldr/arch/uefi/stubs.c | 34 -- boot/freeldr/freeldr/arch/uefi/uefidisk.c | 596 ++++++++++++++++++++++++++++++ boot/freeldr/freeldr/uefi.cmake | 7 +- 3 files changed, 600 insertions(+), 37 deletions(-) diff --git a/boot/freeldr/freeldr/arch/uefi/stubs.c b/boot/freeldr/freeldr/arch/uefi/stubs.c index 75f7ee0fc8b..28f11b7795b 100644 --- a/boot/freeldr/freeldr/arch/uefi/stubs.c +++ b/boot/freeldr/freeldr/arch/uefi/stubs.c @@ -48,40 +48,6 @@ UefiGetExtendedBIOSData(PULONG ExtendedBIOSDataArea, } -UCHAR -UefiGetFloppyCount(VOID) -{ - return 0; -} - -BOOLEAN -UefiDiskReadLogicalSectors(IN UCHAR DriveNumber, - IN ULONGLONG SectorNumber, - IN ULONG SectorCount, - OUT PVOID Buffer) -{ - return 0; -} - -BOOLEAN -UefiDiskGetDriveGeometry(UCHAR DriveNumber, - PGEOMETRY Geometry) -{ - return 0; -} - -ULONG -UefiDiskGetCacheableBlockCount(UCHAR DriveNumber) -{ - return 0; -} - -BOOLEAN -UefiInitializeBootDevices(VOID) -{ - return 0; -} - PCONFIGURATION_COMPONENT_DATA UefiHwDetect(VOID) { diff --git a/boot/freeldr/freeldr/arch/uefi/uefidisk.c b/boot/freeldr/freeldr/arch/uefi/uefidisk.c new file mode 100644 index 00000000000..772cdece7ce --- /dev/null +++ b/boot/freeldr/freeldr/arch/uefi/uefidisk.c @@ -0,0 +1,596 @@ +/* + * PROJECT: FreeLoader UEFI Support + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Disk Access Functions + * COPYRIGHT: Copyright 2022 Justin Miller <justinmiller100(a)gmail.com> + */ + +/* INCLUDES ******************************************************************/ + +#include <uefildr.h> + +#include <debug.h> +DBG_DEFAULT_CHANNEL(WARNING); + +#define TAG_HW_RESOURCE_LIST 'lRwH' +#define TAG_HW_DISK_CONTEXT 'cDwH' +#define FIRST_BIOS_DISK 0x80 +#define FIRST_PARTITION 1 + +typedef struct tagDISKCONTEXT +{ + UCHAR DriveNumber; + ULONG SectorSize; + ULONGLONG SectorOffset; + ULONGLONG SectorCount; + ULONGLONG SectorNumber; +} DISKCONTEXT; + +typedef struct _INTERNAL_UEFI_DISK +{ + UCHAR ArcDriveNumber; + UCHAR NumOfPartitions; + UCHAR UefiRootNumber; + BOOLEAN IsThisTheBootDrive; +} INTERNAL_UEFI_DISK, *PINTERNAL_UEFI_DISK; + +/* GLOBALS *******************************************************************/ + +extern EFI_SYSTEM_TABLE* GlobalSystemTable; +extern EFI_HANDLE GlobalImageHandle; +extern EFI_HANDLE PublicBootHandle; /* Freeldr itself */ + +/* Made to match BIOS */ +PVOID DiskReadBuffer; +UCHAR PcBiosDiskCount; + +UCHAR FrldrBootDrive; +ULONG FrldrBootPartition; +SIZE_T DiskReadBufferSize; +PVOID Buffer; + +static const CHAR Hex[] = "0123456789abcdef"; +static CHAR PcDiskIdentifier[32][20]; + +/* UEFI-specific */ +static ULONG UefiBootRootIdentifier; +static ULONG OffsetToBoot; +static ULONG PublicBootArcDisk; +static INTERNAL_UEFI_DISK* InternalUefiDisk = NULL; +static EFI_GUID bioGuid = BLOCK_IO_PROTOCOL; +static EFI_BLOCK_IO* bio; +static EFI_HANDLE* handles = NULL; + +/* FUNCTIONS *****************************************************************/ + +PCHAR +GetHarddiskIdentifier(UCHAR DriveNumber) +{ + TRACE("GetHarddiskIdentifier: DriveNumber: %d\n", DriveNumber); + return PcDiskIdentifier[DriveNumber - FIRST_BIOS_DISK]; +} + +static LONG lReportError = 0; // >= 0: display errors; < 0: hide errors. + +LONG +DiskReportError(BOOLEAN bShowError) +{ + /* Set the reference count */ + if (bShowError) ++lReportError; + else --lReportError; + return lReportError; +} + +static +BOOLEAN +UefiGetBootPartitionEntry( + IN UCHAR DriveNumber, + OUT PPARTITION_TABLE_ENTRY PartitionTableEntry, + OUT PULONG BootPartition) +{ + ULONG PartitionNum; + + TRACE("UefiGetBootPartitionEntry: DriveNumber: %d\n", DriveNumber - FIRST_BIOS_DISK); + /* UefiBootRoot is the offset into the array of handles where the raw disk of the boot drive is. + * Partitions start with 1 in ARC, but UEFI root drive identitfier is also first partition. */ + PartitionNum = (OffsetToBoot - UefiBootRootIdentifier); + if (PartitionNum == 0) + { + TRACE("Boot PartitionNumber is 0\n"); + /* The OffsetToBoot is equal to the RootIdentifier */ + PartitionNum = 1; + } + + *BootPartition = PartitionNum; + TRACE("UefiGetBootPartitionEntry: Boot Partition is: %d\n", PartitionNum); + return TRUE; +} + +static +ARC_STATUS +UefiDiskClose(ULONG FileId) +{ + DISKCONTEXT* Context = FsGetDeviceSpecific(FileId); + FrLdrTempFree(Context, TAG_HW_DISK_CONTEXT); + return ESUCCESS; +} + +static +ARC_STATUS +UefiDiskGetFileInformation(ULONG FileId, FILEINFORMATION *Information) +{ + DISKCONTEXT* Context = FsGetDeviceSpecific(FileId); + RtlZeroMemory(Information, sizeof(*Information)); + + /* + * The ARC specification mentions that for partitions, StartingAddress and + * EndingAddress are the start and end positions of the partition in terms + * of byte offsets from the start of the disk. + * CurrentAddress is the current offset into (i.e. relative to) the partition. + */ + Information->StartingAddress.QuadPart = Context->SectorOffset * Context->SectorSize; + Information->EndingAddress.QuadPart = (Context->SectorOffset + Context->SectorCount) * Context->SectorSize; + Information->CurrentAddress.QuadPart = Context->SectorNumber * Context->SectorSize; + + return ESUCCESS; +} + +static +ARC_STATUS +UefiDiskOpen(CHAR *Path, OPENMODE OpenMode, ULONG *FileId) +{ + DISKCONTEXT* Context; + UCHAR DriveNumber; + ULONG DrivePartition, SectorSize; + ULONGLONG SectorOffset = 0; + ULONGLONG SectorCount = 0; + ULONG UefiDriveNumber = 0; + PARTITION_TABLE_ENTRY PartitionTableEntry; + + TRACE("UefiDiskOpen: File ID: %d, Path: %s\n", FileId, Path); + + if (DiskReadBufferSize == 0) + { + ERR("DiskOpen(): DiskReadBufferSize is 0, something is wrong.\n"); + ASSERT(FALSE); + return ENOMEM; + } + + if (!DissectArcPath(Path, NULL, &DriveNumber, &DrivePartition)) + return EINVAL; + + TRACE("Opening disk: DriveNumber: %d, DrivePartition: %d\n", DriveNumber, DrivePartition); + UefiDriveNumber = DriveNumber - FIRST_BIOS_DISK; + GlobalSystemTable->BootServices->HandleProtocol(handles[UefiDriveNumber], &bioGuid, (void**)&bio); + SectorSize = bio->Media->BlockSize; + + if (DrivePartition != 0xff && DrivePartition != 0) + { + if (!DiskGetPartitionEntry(DriveNumber, DrivePartition, &PartitionTableEntry)) + return EINVAL; + + SectorOffset = PartitionTableEntry.SectorCountBeforePartition; + SectorCount = PartitionTableEntry.PartitionSectorCount; + } + else + { + GEOMETRY Geometry; + if (!MachDiskGetDriveGeometry(DriveNumber, &Geometry)) + return EINVAL; + + if (SectorSize != Geometry.BytesPerSector) + { + ERR("SectorSize (%lu) != Geometry.BytesPerSector (%lu), expect problems!\n", + SectorSize, Geometry.BytesPerSector); + } + + SectorOffset = 0; + SectorCount = (ULONGLONG)Geometry.Cylinders * Geometry.Heads * Geometry.Sectors; + } + + Context = FrLdrTempAlloc(sizeof(DISKCONTEXT), TAG_HW_DISK_CONTEXT); + if (!Context) + return ENOMEM; + + Context->DriveNumber = DriveNumber; + Context->SectorSize = SectorSize; + Context->SectorOffset = SectorOffset; + Context->SectorCount = SectorCount; + Context->SectorNumber = 0; + FsSetDeviceSpecific(*FileId, Context); + return ESUCCESS; +} + +static +ARC_STATUS +UefiDiskRead(ULONG FileId, VOID *Buffer, ULONG N, ULONG *Count) +{ + DISKCONTEXT* Context = FsGetDeviceSpecific(FileId); + UCHAR* Ptr = (UCHAR*)Buffer; + ULONG Length, TotalSectors, MaxSectors, ReadSectors; + ULONGLONG SectorOffset; + BOOLEAN ret; + + ASSERT(DiskReadBufferSize > 0); + + TotalSectors = (N + Context->SectorSize - 1) / Context->SectorSize; + MaxSectors = DiskReadBufferSize / Context->SectorSize; + SectorOffset = Context->SectorOffset + Context->SectorNumber; + + // If MaxSectors is 0, this will lead to infinite loop. + // In release builds assertions are disabled, however we also have sanity checks in DiskOpen() + ASSERT(MaxSectors > 0); + + ret = TRUE; + + while (TotalSectors) + { + ReadSectors = min(TotalSectors, MaxSectors); + + ret = MachDiskReadLogicalSectors(Context->DriveNumber, + SectorOffset, + ReadSectors, + DiskReadBuffer); + if (!ret) + break; + + Length = ReadSectors * Context->SectorSize; + Length = min(Length, N); + + RtlCopyMemory(Ptr, DiskReadBuffer, Length); + + Ptr += Length; + N -= Length; + SectorOffset += ReadSectors; + TotalSectors -= ReadSectors; + } + + *Count = (ULONG)((ULONG_PTR)Ptr - (ULONG_PTR)Buffer); + Context->SectorNumber = SectorOffset - Context->SectorOffset; + + return (ret ? ESUCCESS : EIO); +} + +static +ARC_STATUS +UefiDiskSeek(ULONG FileId, LARGE_INTEGER *Position, SEEKMODE SeekMode) +{ + DISKCONTEXT* Context = FsGetDeviceSpecific(FileId); + LARGE_INTEGER NewPosition = *Position; + + switch (SeekMode) + { + case SeekAbsolute: + break; + case SeekRelative: + NewPosition.QuadPart += (Context->SectorNumber * Context->SectorSize); + break; + default: + ASSERT(FALSE); + return EINVAL; + } + + if (NewPosition.QuadPart & (Context->SectorSize - 1)) + return EINVAL; + + /* Convert in number of sectors */ + NewPosition.QuadPart /= Context->SectorSize; + + /* HACK: CDROMs may have a SectorCount of 0 */ + if (Context->SectorCount != 0 && NewPosition.QuadPart >= Context->SectorCount) + return EINVAL; + + Context->SectorNumber = NewPosition.QuadPart; + return ESUCCESS; +} + +static const DEVVTBL UefiDiskVtbl = +{ + UefiDiskClose, + UefiDiskGetFileInformation, + UefiDiskOpen, + UefiDiskRead, + UefiDiskSeek, +}; + +static +VOID +GetHarddiskInformation(UCHAR DriveNumber) +{ + PMASTER_BOOT_RECORD Mbr; + PULONG Buffer; + ULONG i; + ULONG Checksum; + ULONG Signature; + BOOLEAN ValidPartitionTable; + CHAR ArcName[MAX_PATH]; + PARTITION_TABLE_ENTRY PartitionTableEntry; + PCHAR Identifier = PcDiskIdentifier[DriveNumber - FIRST_BIOS_DISK]; + + /* Detect disk partition type */ + DiskDetectPartitionType(DriveNumber); + + /* Read the MBR */ + if (!MachDiskReadLogicalSectors(DriveNumber, 0ULL, 1, DiskReadBuffer)) + { + ERR("Reading MBR failed\n"); + /* We failed, use a default identifier */ + sprintf(Identifier, "BIOSDISK%d", DriveNumber - FIRST_BIOS_DISK); + return; + } + + Buffer = (ULONG*)DiskReadBuffer; + Mbr = (PMASTER_BOOT_RECORD)DiskReadBuffer; + + Signature = Mbr->Signature; + TRACE("Signature: %x\n", Signature); + + /* Calculate the MBR checksum */ + Checksum = 0; + for (i = 0; i < 512 / sizeof(ULONG); i++) + { + Checksum += Buffer[i]; + } + Checksum = ~Checksum + 1; + TRACE("Checksum: %x\n", Checksum); + + ValidPartitionTable = (Mbr->MasterBootRecordMagic == 0xAA55); + + /* Fill out the ARC disk block */ + sprintf(ArcName, "multi(0)disk(0)rdisk(%u)", DriveNumber - FIRST_BIOS_DISK); + AddReactOSArcDiskInfo(ArcName, Signature, Checksum, ValidPartitionTable); + + sprintf(ArcName, "multi(0)disk(0)rdisk(%u)partition(0)", DriveNumber - FIRST_BIOS_DISK); + FsRegisterDevice(ArcName, &UefiDiskVtbl); + + /* Add partitions */ + i = FIRST_PARTITION; + DiskReportError(FALSE); + while (DiskGetPartitionEntry(DriveNumber, i, &PartitionTableEntry)) + { + if (PartitionTableEntry.SystemIndicator != PARTITION_ENTRY_UNUSED) + { + sprintf(ArcName, "multi(0)disk(0)rdisk(%u)partition(%lu)", DriveNumber - FIRST_BIOS_DISK, i); + FsRegisterDevice(ArcName, &UefiDiskVtbl); + } + i++; + } + DiskReportError(TRUE); + + InternalUefiDisk[DriveNumber].NumOfPartitions = i; + /* Convert checksum and signature to identifier string */ + Identifier[0] = Hex[(Checksum >> 28) & 0x0F]; + Identifier[1] = Hex[(Checksum >> 24) & 0x0F]; + Identifier[2] = Hex[(Checksum >> 20) & 0x0F]; + Identifier[3] = Hex[(Checksum >> 16) & 0x0F]; + Identifier[4] = Hex[(Checksum >> 12) & 0x0F]; + Identifier[5] = Hex[(Checksum >> 8) & 0x0F]; + Identifier[6] = Hex[(Checksum >> 4) & 0x0F]; + Identifier[7] = Hex[Checksum & 0x0F]; + Identifier[8] = '-'; + Identifier[9] = Hex[(Signature >> 28) & 0x0F]; + Identifier[10] = Hex[(Signature >> 24) & 0x0F]; + Identifier[11] = Hex[(Signature >> 20) & 0x0F]; + Identifier[12] = Hex[(Signature >> 16) & 0x0F]; + Identifier[13] = Hex[(Signature >> 12) & 0x0F]; + Identifier[14] = Hex[(Signature >> 8) & 0x0F]; + Identifier[15] = Hex[(Signature >> 4) & 0x0F]; + Identifier[16] = Hex[Signature & 0x0F]; + Identifier[17] = '-'; + Identifier[18] = (ValidPartitionTable ? 'A' : 'X'); + Identifier[19] = 0; + TRACE("Identifier: %s\n", Identifier); +} + +static +VOID +UefiSetupBlockDevices(VOID) +{ + ULONG BlockDeviceIndex; + ULONG SystemHandleCount; + EFI_STATUS Status; + ULONG i; + + UINTN handle_size = 0; + PcBiosDiskCount = 0; + UefiBootRootIdentifier = 0; + + /* 1) Setup a list of boothandles by using the LocateHandle protocol */ + Status = GlobalSystemTable->BootServices->LocateHandle(ByProtocol, &bioGuid, NULL, &handle_size, handles); + handles = MmAllocateMemoryWithType(handle_size, LoaderFirmwareTemporary); + Status = GlobalSystemTable->BootServices->LocateHandle(ByProtocol, &bioGuid, NULL, &handle_size, handles); + SystemHandleCount = handle_size / sizeof(EFI_HANDLE); + InternalUefiDisk = MmAllocateMemoryWithType(sizeof(INTERNAL_UEFI_DISK) * SystemHandleCount, LoaderFirmwareTemporary); + + BlockDeviceIndex = 0; + /* 2) Parse the handle list */ + for (i = 0; i < SystemHandleCount; ++i) + { + Status = GlobalSystemTable->BootServices->HandleProtocol(handles[i], &bioGuid, (void**)&bio); + if (handles[i] == PublicBootHandle) + { + OffsetToBoot = i; /* Drive offset in the handles list */ + } + + if (EFI_ERROR(Status) || + bio == NULL || + bio->Media->BlockSize == 0 || + bio->Media->BlockSize > 2048) + { + TRACE("UefiSetupBlockDevices: UEFI has found a block device that failed, skipping\n"); + continue; + } + if (bio->Media->LogicalPartition == FALSE) + { + TRACE("Found root of a HDD\n"); + PcBiosDiskCount++; + InternalUefiDisk[BlockDeviceIndex].ArcDriveNumber = BlockDeviceIndex; + InternalUefiDisk[BlockDeviceIndex].UefiRootNumber = i; + GetHarddiskInformation(BlockDeviceIndex + FIRST_BIOS_DISK); + BlockDeviceIndex++; + } + else if (handles[i] == PublicBootHandle) + { + ULONG increment = 0; + ULONG i; + + /* 3) Grab the offset into the array of handles and decrement per volume (valid partition) */ + for (increment = OffsetToBoot; increment > 0; increment--) + { + GlobalSystemTable->BootServices->HandleProtocol(handles[increment], &bioGuid, (void**)&bio); + if (bio->Media->LogicalPartition == FALSE) + { + TRACE("Found root at increment %u\n", increment); + UefiBootRootIdentifier = increment; + + for (i = 0; i <= PcBiosDiskCount; ++i) + { + /* Now only of the root drive number is equal to this drive we found above */ + if (InternalUefiDisk[i].UefiRootNumber == UefiBootRootIdentifier) + { + InternalUefiDisk[i].IsThisTheBootDrive == TRUE; + PublicBootArcDisk = i; + TRACE("Found Boot drive\n"); + } + } + + break; + } + } + } + } +} + +static +BOOLEAN +UefiSetBootpath(VOID) +{ + TRACE("UefiSetBootpath: Setting up boot path\n"); + GlobalSystemTable->BootServices->HandleProtocol(handles[UefiBootRootIdentifier], &bioGuid, (void**)&bio); + FrldrBootDrive = (FIRST_BIOS_DISK + PublicBootArcDisk); + if (bio->Media->RemovableMedia == TRUE && bio->Media->BlockSize == 2048) + { + /* Boot Partition 0xFF is the magic value that indicates booting from CD-ROM (see isoboot.S) */ + FrldrBootPartition == 0xFF; + RtlStringCbPrintfA(FrLdrBootPath, sizeof(FrLdrBootPath), + "multi(0)disk(0)cdrom(%u)", PublicBootArcDisk); + } + else + { + ULONG BootPartition; + PARTITION_TABLE_ENTRY PartitionEntry; + + /* This is a hard disk */ + if (!UefiGetBootPartitionEntry(FrldrBootDrive, &PartitionEntry, &BootPartition)) + { + ERR("Failed to get boot partition entry\n"); + return FALSE; + } + + RtlStringCbPrintfA(FrLdrBootPath, sizeof(FrLdrBootPath), + "multi(0)disk(0)rdisk(%u)partition(%lu)", + PublicBootArcDisk, BootPartition); + } + + return TRUE; +} + +BOOLEAN +UefiInitializeBootDevices(VOID) +{ + ULONG i = 0; + + DiskReadBufferSize = EFI_PAGE_SIZE; + DiskReadBuffer = MmAllocateMemoryWithType(DiskReadBufferSize, LoaderFirmwareTemporary); + UefiSetupBlockDevices(); + UefiSetBootpath(); + + /* Add it, if it's a cdrom */ + GlobalSystemTable->BootServices->HandleProtocol(handles[UefiBootRootIdentifier], &bioGuid, (void**)&bio); + if (bio->Media->RemovableMedia == TRUE && bio->Media->BlockSize == 2048) + { + PMASTER_BOOT_RECORD Mbr; + PULONG Buffer; + ULONG Checksum = 0; + ULONG Signature; + + /* Read the MBR */ + if (!MachDiskReadLogicalSectors(FrldrBootDrive, 16ULL, 1, DiskReadBuffer)) + { + ERR("Reading MBR failed\n"); + return FALSE; + } + + Buffer = (ULONG*)DiskReadBuffer; + Mbr = (PMASTER_BOOT_RECORD)DiskReadBuffer; + + Signature = Mbr->Signature; + TRACE("Signature: %x\n", Signature); + + /* Calculate the MBR checksum */ + for (i = 0; i < 2048 / sizeof(ULONG); i++) + { + Checksum += Buffer[i]; + } + Checksum = ~Checksum + 1; + TRACE("Checksum: %x\n", Checksum); + + /* Fill out the ARC disk block */ + AddReactOSArcDiskInfo(FrLdrBootPath, Signature, Checksum, TRUE); + + FsRegisterDevice(FrLdrBootPath, &UefiDiskVtbl); + PcBiosDiskCount++; // This is not accounted for in the number of pre-enumerated BIOS drives! + TRACE("Additional boot drive detected: 0x%02X\n", (int)FrldrBootDrive); + } + return TRUE; +} + +UCHAR +UefiGetFloppyCount(VOID) +{ + /* No floppy for you for now... */ + return 0; +} + +BOOLEAN +UefiDiskReadLogicalSectors( + IN UCHAR DriveNumber, + IN ULONGLONG SectorNumber, + IN ULONG SectorCount, + OUT PVOID Buffer) +{ + ULONG UefiDriveNumber; + + UefiDriveNumber = InternalUefiDisk[DriveNumber - FIRST_BIOS_DISK].UefiRootNumber; + TRACE("UefiDiskReadLogicalSectors: DriveNumber: %d\n", UefiDriveNumber); + GlobalSystemTable->BootServices->HandleProtocol(handles[UefiDriveNumber], &bioGuid, (void**)&bio); + + /* Devices setup */ + bio->ReadBlocks(bio, bio->Media->MediaId, SectorNumber, SectorCount * bio->Media->BlockSize, Buffer); + return TRUE; +} + +BOOLEAN +UefiDiskGetDriveGeometry(UCHAR DriveNumber, PGEOMETRY Geometry) +{ + ULONG UefiDriveNumber; + + UefiDriveNumber = InternalUefiDisk[DriveNumber - FIRST_BIOS_DISK].UefiRootNumber; + GlobalSystemTable->BootServices->HandleProtocol(handles[UefiDriveNumber], &bioGuid, (void**)&bio); + Geometry->Cylinders = 1; // Not relevant for the UEFI BIO protocol + Geometry->Heads = 1; // Not relevant for the UEFI BIO protocol + Geometry->Sectors = bio->Media->LastBlock; // Number of sectors per track + Geometry->BytesPerSector = bio->Media->BlockSize; // Number of bytes per sector + + return TRUE; +} + +ULONG +UefiDiskGetCacheableBlockCount(UCHAR DriveNumber) +{ + ULONG UefiDriveNumber = InternalUefiDisk[DriveNumber - FIRST_BIOS_DISK].UefiRootNumber; + TRACE("UefiDiskGetCacheableBlockCount: DriveNumber: %d\n", UefiDriveNumber); + + GlobalSystemTable->BootServices->HandleProtocol(handles[UefiDriveNumber], &bioGuid, (void**)&bio); + return bio->Media->LastBlock; +} diff --git a/boot/freeldr/freeldr/uefi.cmake b/boot/freeldr/freeldr/uefi.cmake index 94b5baa7630..0adb0a25f4b 100644 --- a/boot/freeldr/freeldr/uefi.cmake +++ b/boot/freeldr/freeldr/uefi.cmake @@ -14,11 +14,12 @@ include_directories(BEFORE list(APPEND UEFILDR_ARC_SOURCE ${FREELDR_ARC_SOURCE} arch/uefi/stubs.c - arch/uefi/uefisetup.c - arch/uefi/uefivid.c - arch/uefi/uefiutil.c arch/uefi/ueficon.c + arch/uefi/uefidisk.c arch/uefi/uefimem.c + arch/uefi/uefisetup.c + arch/uefi/uefiutil.c + arch/uefi/uefivid.c arch/vgafont.c) if(ARCH STREQUAL "i386")

1 0

[reactos] 01/01: [E1000] Stop logging MAC, is sensitive data of log-contributors (#5254)
by Joachim Henze 29 Apr '23

29 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3c797b314fb639e04c8fa… commit 3c797b314fb639e04c8fa75f010c81a4924d674d Author: Joachim Henze <joachim.henze(a)reactos.org> AuthorDate: Sat Apr 29 23:02:03 2023 +0200 Commit: GitHub <noreply(a)github.com> CommitDate: Sat Apr 29 23:02:03 2023 +0200 [E1000] Stop logging MAC, is sensitive data of log-contributors (#5254) --- drivers/network/dd/e1000/hardware.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/network/dd/e1000/hardware.c b/drivers/network/dd/e1000/hardware.c index c0c41ce9403..94208847274 100644 --- a/drivers/network/dd/e1000/hardware.c +++ b/drivers/network/dd/e1000/hardware.c @@ -676,6 +676,7 @@ NICGetPermanentMacAddress( Adapter->PermanentMacAddress[n * 2 + 1] = (AddrWord >> 8) & 0xff; } +#if 0 NDIS_DbgPrint(MIN_TRACE, ("MAC: %02x:%02x:%02x:%02x:%02x:%02x\n", Adapter->PermanentMacAddress[0], Adapter->PermanentMacAddress[1], @@ -683,6 +684,7 @@ NICGetPermanentMacAddress( Adapter->PermanentMacAddress[3], Adapter->PermanentMacAddress[4], Adapter->PermanentMacAddress[5])); +#endif return NDIS_STATUS_SUCCESS; }

1 0

[reactos] 01/01: [NOTEPAD] Delete my name from resource copyright text (#5261)
by Katayama Hirofumi MZ 28 Apr '23

28 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c9ed65e0cc0a8243f4fca… commit c9ed65e0cc0a8243f4fca98988b9205c7d03fc15 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Fri Apr 28 21:48:45 2023 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Fri Apr 28 21:48:45 2023 +0900 [NOTEPAD] Delete my name from resource copyright text (#5261) The copyright text was too long. CORE-18837 --- base/applications/notepad/lang/bg-BG.rc | 2 +- base/applications/notepad/lang/cs-CZ.rc | 2 +- base/applications/notepad/lang/da-DK.rc | 2 +- base/applications/notepad/lang/de-DE.rc | 2 +- base/applications/notepad/lang/el-GR.rc | 2 +- base/applications/notepad/lang/en-US.rc | 2 +- base/applications/notepad/lang/es-ES.rc | 2 +- base/applications/notepad/lang/et-EE.rc | 2 +- base/applications/notepad/lang/eu-ES.rc | 2 +- base/applications/notepad/lang/fi-FI.rc | 2 +- base/applications/notepad/lang/fr-FR.rc | 2 +- base/applications/notepad/lang/he-IL.rc | 2 +- base/applications/notepad/lang/hi-IN.rc | 2 +- base/applications/notepad/lang/hr-HR.rc | 2 +- base/applications/notepad/lang/hu-HU.rc | 2 +- base/applications/notepad/lang/hy-AM.rc | 2 +- base/applications/notepad/lang/id-ID.rc | 2 +- base/applications/notepad/lang/it-IT.rc | 2 +- base/applications/notepad/lang/ja-JP.rc | 2 +- base/applications/notepad/lang/lt-LT.rc | 2 +- base/applications/notepad/lang/ms-MY.rc | 2 +- base/applications/notepad/lang/nl-NL.rc | 2 +- base/applications/notepad/lang/no-NO.rc | 2 +- base/applications/notepad/lang/pl-PL.rc | 2 +- base/applications/notepad/lang/pt-BR.rc | 2 +- base/applications/notepad/lang/pt-PT.rc | 2 +- base/applications/notepad/lang/ro-RO.rc | 2 +- base/applications/notepad/lang/ru-RU.rc | 2 +- base/applications/notepad/lang/sk-SK.rc | 2 +- base/applications/notepad/lang/sl-SI.rc | 2 +- base/applications/notepad/lang/sq-AL.rc | 2 +- base/applications/notepad/lang/sv-SE.rc | 2 +- base/applications/notepad/lang/th-TH.rc | 2 +- base/applications/notepad/lang/tr-TR.rc | 2 +- base/applications/notepad/lang/uk-UA.rc | 2 +- base/applications/notepad/lang/uz-UZ.rc | 2 +- base/applications/notepad/lang/zh-CN.rc | 2 +- base/applications/notepad/lang/zh-HK.rc | 2 +- base/applications/notepad/lang/zh-TW.rc | 2 +- 39 files changed, 39 insertions(+), 39 deletions(-) diff --git a/base/applications/notepad/lang/bg-BG.rc b/base/applications/notepad/lang/bg-BG.rc index 9055c7f4d02..9d45a9f5d1d 100644 --- a/base/applications/notepad/lang/bg-BG.rc +++ b/base/applications/notepad/lang/bg-BG.rc @@ -183,5 +183,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Възпроизводствено право 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Възпроизводствено право 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/cs-CZ.rc b/base/applications/notepad/lang/cs-CZ.rc index 903e27a2950..874854b9cf4 100644 --- a/base/applications/notepad/lang/cs-CZ.rc +++ b/base/applications/notepad/lang/cs-CZ.rc @@ -184,5 +184,5 @@ paměti." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Textový dokument" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/da-DK.rc b/base/applications/notepad/lang/da-DK.rc index 4820795e77c..dc637207806 100644 --- a/base/applications/notepad/lang/da-DK.rc +++ b/base/applications/notepad/lang/da-DK.rc @@ -184,5 +184,5 @@ hukommelse, og prøv så igen." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/de-DE.rc b/base/applications/notepad/lang/de-DE.rc index d3a4abf6087..8220a475df4 100644 --- a/base/applications/notepad/lang/de-DE.rc +++ b/base/applications/notepad/lang/de-DE.rc @@ -185,5 +185,5 @@ um diese Funktion\nabzuschließen. Beenden Sie eine oder mehrere \ STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Textdokument" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/el-GR.rc b/base/applications/notepad/lang/el-GR.rc index 19256689117..4d8cb846c65 100644 --- a/base/applications/notepad/lang/el-GR.rc +++ b/base/applications/notepad/lang/el-GR.rc @@ -184,5 +184,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/en-US.rc b/base/applications/notepad/lang/en-US.rc index c28cf3240bc..a3444ea81b6 100644 --- a/base/applications/notepad/lang/en-US.rc +++ b/base/applications/notepad/lang/en-US.rc @@ -183,5 +183,5 @@ task.\nClose one or more applications to increase the amount of\nfree memory." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/es-ES.rc b/base/applications/notepad/lang/es-ES.rc index f8496402e0a..541fdfbad63 100644 --- a/base/applications/notepad/lang/es-ES.rc +++ b/base/applications/notepad/lang/es-ES.rc @@ -186,5 +186,5 @@ aumentar la cantidad\nde memoria libre." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Documento de texto" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/et-EE.rc b/base/applications/notepad/lang/et-EE.rc index 1bc674396bb..8b1171328fa 100644 --- a/base/applications/notepad/lang/et-EE.rc +++ b/base/applications/notepad/lang/et-EE.rc @@ -191,5 +191,5 @@ käsu lõpetamiseks.\nSulge üks või enam rakendust, et suurendada\nvaba mälu STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Tekstidokument" - STRING_NOTEPAD_AUTHORS "Autoriõigus 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Autoriõigus 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/eu-ES.rc b/base/applications/notepad/lang/eu-ES.rc index 5fcfd64e75a..c9719f4fbc6 100644 --- a/base/applications/notepad/lang/eu-ES.rc +++ b/base/applications/notepad/lang/eu-ES.rc @@ -184,5 +184,5 @@ memoria librearen\nkopurua handitzeko." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/fi-FI.rc b/base/applications/notepad/lang/fi-FI.rc index 97d2ab7e052..6cc2f9a1a0c 100644 --- a/base/applications/notepad/lang/fi-FI.rc +++ b/base/applications/notepad/lang/fi-FI.rc @@ -184,5 +184,5 @@ muistia." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/fr-FR.rc b/base/applications/notepad/lang/fr-FR.rc index 7d6c4b2cfeb..6216cd8804b 100644 --- a/base/applications/notepad/lang/fr-FR.rc +++ b/base/applications/notepad/lang/fr-FR.rc @@ -184,5 +184,5 @@ de la mémoire." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Document Texte" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/he-IL.rc b/base/applications/notepad/lang/he-IL.rc index f598bef0914..afcdd1a9e81 100644 --- a/base/applications/notepad/lang/he-IL.rc +++ b/base/applications/notepad/lang/he-IL.rc @@ -186,5 +186,5 @@ task.\nClose one or more applications to increase the amount of\nfree memory." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/hi-IN.rc b/base/applications/notepad/lang/hi-IN.rc index 63b52387f74..5c568dc677e 100644 --- a/base/applications/notepad/lang/hi-IN.rc +++ b/base/applications/notepad/lang/hi-IN.rc @@ -190,5 +190,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "टेक्स्ट डॉक्यूमॅन्ट" - STRING_NOTEPAD_AUTHORS "कॉपीराइट 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "कॉपीराइट 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/hr-HR.rc b/base/applications/notepad/lang/hr-HR.rc index b7abb8580a7..dea66511d0a 100644 --- a/base/applications/notepad/lang/hr-HR.rc +++ b/base/applications/notepad/lang/hr-HR.rc @@ -190,5 +190,5 @@ zadatak.\nZatvorite jednu ili više aplikacija da povećate\nslobodnu memoriju." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Tekstni dokument" - STRING_NOTEPAD_AUTHORS "Copyright 1997, 98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997, 98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/hu-HU.rc b/base/applications/notepad/lang/hu-HU.rc index 2df30434dbe..18e368941c7 100644 --- a/base/applications/notepad/lang/hu-HU.rc +++ b/base/applications/notepad/lang/hu-HU.rc @@ -184,5 +184,5 @@ Szeretné menteni a változásokat?" STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Szöveges dokumentum" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/hy-AM.rc b/base/applications/notepad/lang/hy-AM.rc index cb2827bb2f5..c1b866313b4 100644 --- a/base/applications/notepad/lang/hy-AM.rc +++ b/base/applications/notepad/lang/hy-AM.rc @@ -183,5 +183,5 @@ Would you like to save the changes ?" STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/id-ID.rc b/base/applications/notepad/lang/id-ID.rc index 35faa63fd76..8405f0f0abf 100644 --- a/base/applications/notepad/lang/id-ID.rc +++ b/base/applications/notepad/lang/id-ID.rc @@ -184,5 +184,5 @@ bebas." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Teks Dokumen" - STRING_NOTEPAD_AUTHORS "Hak Cipta 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Hak Cipta 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/it-IT.rc b/base/applications/notepad/lang/it-IT.rc index d6c6466a539..a22a1586762 100644 --- a/base/applications/notepad/lang/it-IT.rc +++ b/base/applications/notepad/lang/it-IT.rc @@ -184,5 +184,5 @@ di memoria libera." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Documento di testo" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/ja-JP.rc b/base/applications/notepad/lang/ja-JP.rc index cd3450c8741..e9df825c3ac 100644 --- a/base/applications/notepad/lang/ja-JP.rc +++ b/base/applications/notepad/lang/ja-JP.rc @@ -184,5 +184,5 @@ BEGIN STRING_PRINTFAILED "印刷が失敗しました。" STRING_TEXT_DOCUMENT "テキスト文書" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/lt-LT.rc b/base/applications/notepad/lang/lt-LT.rc index 709fa1761dd..3e474ed0041 100644 --- a/base/applications/notepad/lang/lt-LT.rc +++ b/base/applications/notepad/lang/lt-LT.rc @@ -183,5 +183,5 @@ Ar norite išsaugoti pakeitimus?" STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "(C) 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "(C) 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/ms-MY.rc b/base/applications/notepad/lang/ms-MY.rc index 3c7f28427a2..b20afcc378f 100644 --- a/base/applications/notepad/lang/ms-MY.rc +++ b/base/applications/notepad/lang/ms-MY.rc @@ -185,5 +185,5 @@ tugas ini.\nTutup satu atau lebih aplikasi untuk menambah jumlah\ningatan kosong STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/nl-NL.rc b/base/applications/notepad/lang/nl-NL.rc index 1d86e0d78b2..f3ec9a79fb1 100644 --- a/base/applications/notepad/lang/nl-NL.rc +++ b/base/applications/notepad/lang/nl-NL.rc @@ -183,5 +183,5 @@ Wilt u de wijzigingen opslaan?" STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/no-NO.rc b/base/applications/notepad/lang/no-NO.rc index f2d197e3f7b..8df8d4c00b2 100644 --- a/base/applications/notepad/lang/no-NO.rc +++ b/base/applications/notepad/lang/no-NO.rc @@ -184,5 +184,5 @@ minne." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Enerett 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Enerett 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/pl-PL.rc b/base/applications/notepad/lang/pl-PL.rc index c299cfd1d01..97874362419 100644 --- a/base/applications/notepad/lang/pl-PL.rc +++ b/base/applications/notepad/lang/pl-PL.rc @@ -178,5 +178,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Dokument tekstowy" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/pt-BR.rc b/base/applications/notepad/lang/pt-BR.rc index 81f0419d96a..5ff0071c77a 100644 --- a/base/applications/notepad/lang/pt-BR.rc +++ b/base/applications/notepad/lang/pt-BR.rc @@ -183,5 +183,5 @@ tarefa.\nFeche uma ou mais aplicações para aumentar a quantidade de memória l STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/pt-PT.rc b/base/applications/notepad/lang/pt-PT.rc index c3cfd514f13..13f0c79f1f5 100644 --- a/base/applications/notepad/lang/pt-PT.rc +++ b/base/applications/notepad/lang/pt-PT.rc @@ -183,5 +183,5 @@ tarefa.\nFeche uma ou mais aplicações para aumentar a quantidade de memória l STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Documento de texto" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/ro-RO.rc b/base/applications/notepad/lang/ro-RO.rc index 7f86d5a3d18..5b95ee1fac3 100644 --- a/base/applications/notepad/lang/ro-RO.rc +++ b/base/applications/notepad/lang/ro-RO.rc @@ -188,5 +188,5 @@ Păstrați modificările aduse?" STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Document text" - STRING_NOTEPAD_AUTHORS "Drept de autor 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Drept de autor 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/ru-RU.rc b/base/applications/notepad/lang/ru-RU.rc index 5696d407fc0..9867f769f3e 100644 --- a/base/applications/notepad/lang/ru-RU.rc +++ b/base/applications/notepad/lang/ru-RU.rc @@ -183,5 +183,5 @@ BEGIN STRING_PRINTFAILED "Печать не удалась." STRING_TEXT_DOCUMENT "Текстовый документ" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/sk-SK.rc b/base/applications/notepad/lang/sk-SK.rc index c00f4745f72..cead9a46f5e 100644 --- a/base/applications/notepad/lang/sk-SK.rc +++ b/base/applications/notepad/lang/sk-SK.rc @@ -191,5 +191,5 @@ alebo viac aplikácií, aby sa uvoľnila pamäť a skúste to znova." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/sl-SI.rc b/base/applications/notepad/lang/sl-SI.rc index 8c42268355c..0031fd14997 100644 --- a/base/applications/notepad/lang/sl-SI.rc +++ b/base/applications/notepad/lang/sl-SI.rc @@ -183,5 +183,5 @@ operacijo.\nÈe ga želite sprostiti, konèajte enega ali veè programov in posk STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/sq-AL.rc b/base/applications/notepad/lang/sq-AL.rc index efd8b75b5ea..60d5a04da2e 100644 --- a/base/applications/notepad/lang/sq-AL.rc +++ b/base/applications/notepad/lang/sq-AL.rc @@ -187,5 +187,5 @@ detyrë.\nMbyll nje ose me shume programe te rrisesh shumën e\nmemories." STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/sv-SE.rc b/base/applications/notepad/lang/sv-SE.rc index 11731ce4819..70b3e3a2baa 100644 --- a/base/applications/notepad/lang/sv-SE.rc +++ b/base/applications/notepad/lang/sv-SE.rc @@ -183,5 +183,5 @@ den här åtgärden.\nAvsluta ett eller flera program för att frigöra mer minn STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/th-TH.rc b/base/applications/notepad/lang/th-TH.rc index 1d957310321..11fe1192792 100644 --- a/base/applications/notepad/lang/th-TH.rc +++ b/base/applications/notepad/lang/th-TH.rc @@ -178,5 +178,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/tr-TR.rc b/base/applications/notepad/lang/tr-TR.rc index d5485cb3d79..1f37825511e 100644 --- a/base/applications/notepad/lang/tr-TR.rc +++ b/base/applications/notepad/lang/tr-TR.rc @@ -181,5 +181,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Metin Belgesi" - STRING_NOTEPAD_AUTHORS "Telif Hakları: 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Telif Hakları: 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/uk-UA.rc b/base/applications/notepad/lang/uk-UA.rc index 4953a0103be..a914503457a 100644 --- a/base/applications/notepad/lang/uk-UA.rc +++ b/base/applications/notepad/lang/uk-UA.rc @@ -183,5 +183,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Текстовий документ" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/uz-UZ.rc b/base/applications/notepad/lang/uz-UZ.rc index 730a57b33e3..4ea02231662 100644 --- a/base/applications/notepad/lang/uz-UZ.rc +++ b/base/applications/notepad/lang/uz-UZ.rc @@ -183,5 +183,5 @@ O‘zgarishlarni saqlashni istaysizmi?" STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "Text Document" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/zh-CN.rc b/base/applications/notepad/lang/zh-CN.rc index 538b3a7c5fa..12879a31dd8 100644 --- a/base/applications/notepad/lang/zh-CN.rc +++ b/base/applications/notepad/lang/zh-CN.rc @@ -191,5 +191,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "文本文档" - STRING_NOTEPAD_AUTHORS "版权所有 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "版权所有 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/zh-HK.rc b/base/applications/notepad/lang/zh-HK.rc index e20707c627d..7a2c9f23331 100644 --- a/base/applications/notepad/lang/zh-HK.rc +++ b/base/applications/notepad/lang/zh-HK.rc @@ -192,5 +192,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "純文字檔案" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END diff --git a/base/applications/notepad/lang/zh-TW.rc b/base/applications/notepad/lang/zh-TW.rc index cc3be17a2c6..4d64ad1ea94 100644 --- a/base/applications/notepad/lang/zh-TW.rc +++ b/base/applications/notepad/lang/zh-TW.rc @@ -191,5 +191,5 @@ BEGIN STRING_PRINTFAILED "Printing is failed." STRING_TEXT_DOCUMENT "純文字檔案" - STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk, 2020-23 katahiromz\r\n" + STRING_NOTEPAD_AUTHORS "Copyright 1997,98 Marcel Baur, 2000 Mike McCormack, 2002 Sylvain Petreolle, 2002 Andriy Palamarchuk\r\n" END

1 0

[reactos] 01/01: [RICHED20] RichEdit: CompForm and CandForm (#5257)
by Katayama Hirofumi MZ 27 Apr '23

27 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=31f3eb1d57db73b895984… commit 31f3eb1d57db73b895984a5c11c33899f07d00f7 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Fri Apr 28 08:28:57 2023 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Fri Apr 28 08:28:57 2023 +0900 [RICHED20] RichEdit: CompForm and CandForm (#5257) Correctly display the composition window and the candidate window. - At update_caret function, set the position and font of the composition window. - We don't use internal composition string. Rely on the composition window. - Improve WM_IME_SETCONTEXT, WM_IME_CONTROL, WM_IME_SELECT, WM_IME_STARTCOMPOSITION, WM_IME_COMPOSITION and WM_IME_ENDCOMPOSITION message handlings. CORE-11700 --- dll/win32/riched20/caret.c | 45 ++++++++++++++++++++++++++++++++++ dll/win32/riched20/editor.c | 57 ++++++++++++++++++++++++++++++++++++++++++++ dll/win32/riched20/editstr.h | 2 ++ 3 files changed, 104 insertions(+) diff --git a/dll/win32/riched20/caret.c b/dll/win32/riched20/caret.c index 212c9e9f992..96a95872c2d 100644 --- a/dll/win32/riched20/caret.c +++ b/dll/win32/riched20/caret.c @@ -310,6 +310,51 @@ void update_caret(ME_TextEditor *editor) } else hide_caret(editor); +#ifdef __REACTOS__ + if (ImmIsIME(GetKeyboardLayout(0))) + { + HIMC hIMC = ImmGetContext(editor->hWnd); + if (hIMC) + { + CHARFORMAT2W fmt; + LOGFONTW lf; + COMPOSITIONFORM CompForm; + POINT pt = { x, y }; + + CompForm.ptCurrentPos = pt; + if (editor->styleFlags & ES_MULTILINE) + { + CompForm.dwStyle = CFS_RECT; + CompForm.rcArea = editor->rcFormat; + } + else + { + CompForm.dwStyle = CFS_POINT; + SetRectEmpty(&CompForm.rcArea); + } + ImmSetCompositionWindow(hIMC, &CompForm); + + fmt.cbSize = sizeof(fmt); + ME_GetSelectionCharFormat(editor, &fmt); + + ZeroMemory(&lf, sizeof(lf)); + lf.lfCharSet = DEFAULT_CHARSET; + if (fmt.dwMask & CFM_SIZE) + { + HDC hdc = CreateCompatibleDC(NULL); + lf.lfHeight = -MulDiv(fmt.yHeight, GetDeviceCaps(hdc, LOGPIXELSY), 1440); + DeleteDC(hdc); + } + if (fmt.dwMask & CFM_CHARSET) + lf.lfCharSet = fmt.bCharSet; + if (fmt.dwMask & CFM_FACE) + lstrcpynW(lf.lfFaceName, fmt.szFaceName, ARRAY_SIZE(lf.lfFaceName)); + ImmSetCompositionFontW(hIMC, &lf); + + ImmReleaseContext(editor->hWnd, hIMC); + } + } +#endif } BOOL ME_InternalDeleteText(ME_TextEditor *editor, ME_Cursor *start, diff --git a/dll/win32/riched20/editor.c b/dll/win32/riched20/editor.c index 5ad25869997..bf13c417542 100644 --- a/dll/win32/riched20/editor.c +++ b/dll/win32/riched20/editor.c @@ -233,6 +233,9 @@ #include "shlwapi.h" #include "rtf.h" #include "imm.h" +#ifdef __REACTOS__ + #include "immdev.h" +#endif #include "res.h" #ifdef __REACTOS__ @@ -4103,6 +4106,14 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, ME_UpdateScrollBar(editor); if (bRepaint) ME_Repaint(editor); +#ifdef __REACTOS__ + if (ImmIsIME(GetKeyboardLayout(0))) + { + HIMC hIMC = ImmGetContext(editor->hWnd); + ImmSetCompositionFontW(hIMC, &lf); + ImmReleaseContext(editor->hWnd, hIMC); + } +#endif return 0; } case WM_SETTEXT: @@ -4779,18 +4790,52 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, ME_RewrapRepaint(editor); goto do_default; } +#ifndef __REACTOS__ /* IME messages to make richedit controls IME aware */ +#endif case WM_IME_SETCONTEXT: +#ifdef __REACTOS__ + { + if (FALSE) /* FIXME: Condition */ + lParam &= ~ISC_SHOWUICOMPOSITIONWINDOW; + + if (wParam) + { + HIMC hIMC = ImmGetContext(editor->hWnd); + LPINPUTCONTEXTDX pIC = (LPINPUTCONTEXTDX)ImmLockIMC(hIMC); + if (pIC) + { + pIC->dwUIFlags &= ~0x40000; + ImmUnlockIMC(hIMC); + } + if (FALSE) /* FIXME: Condition */ + ImmNotifyIME(hIMC, NI_COMPOSITIONSTR, CPS_CANCEL, 0); + ImmReleaseContext(editor->hWnd, hIMC); + } + + return DefWindowProcW(editor->hWnd, msg, wParam, lParam); + } +#endif case WM_IME_CONTROL: +#ifdef __REACTOS__ + return DefWindowProcW(editor->hWnd, msg, wParam, lParam); +#endif case WM_IME_SELECT: +#ifdef __REACTOS__ + return DefWindowProcW(editor->hWnd, msg, wParam, lParam); +#endif case WM_IME_COMPOSITIONFULL: return 0; case WM_IME_STARTCOMPOSITION: { +#ifdef __REACTOS__ + return DefWindowProcW(editor->hWnd, msg, wParam, lParam); +#else editor->imeStartIndex=ME_GetCursorOfs(&editor->pCursors[0]); ME_DeleteSelection(editor); ME_CommitUndo(editor); ME_UpdateRepaint(editor, FALSE); +#endif return 0; } case WM_IME_COMPOSITION: @@ -4813,23 +4858,35 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, lpCompStr = HeapAlloc(GetProcessHeap(),0,dwBufLen + sizeof(WCHAR)); ImmGetCompositionStringW(hIMC, dwIndex, lpCompStr, dwBufLen); lpCompStr[dwBufLen/sizeof(WCHAR)] = 0; +#ifndef __REACTOS__ ME_InsertTextFromCursor(editor,0,lpCompStr,dwBufLen/sizeof(WCHAR),style); +#endif HeapFree(GetProcessHeap(), 0, lpCompStr); +#ifndef __REACTOS__ if (dwIndex == GCS_COMPSTR) set_selection_cursors(editor,editor->imeStartIndex, editor->imeStartIndex + dwBufLen/sizeof(WCHAR)); +#endif } ME_ReleaseStyle(style); ME_CommitUndo(editor); ME_UpdateRepaint(editor, FALSE); +#ifdef __REACTOS__ + return DefWindowProcW(editor->hWnd, msg, wParam, lParam); +#else return 0; +#endif } case WM_IME_ENDCOMPOSITION: { +#ifdef __REACTOS__ + return DefWindowProcW(editor->hWnd, msg, wParam, lParam); +#else ME_DeleteSelection(editor); editor->imeStartIndex=-1; return 0; +#endif } case EM_GETOLEINTERFACE: { diff --git a/dll/win32/riched20/editstr.h b/dll/win32/riched20/editstr.h index 608901a5e22..337750c4052 100644 --- a/dll/win32/riched20/editstr.h +++ b/dll/win32/riched20/editstr.h @@ -426,8 +426,10 @@ typedef struct tagME_TextEditor WCHAR cPasswordMask; BOOL bHaveFocus; BOOL bDialogMode; /* Indicates that we are inside a dialog window */ +#ifndef __REACTOS__ /*for IME */ int imeStartIndex; +#endif DWORD selofs; /* The size of the selection bar on the left side of control */ ME_SelectionType nSelectionType; ME_DisplayItem *first_marked_para;

1 0

[reactos] 01/01: [ATL] Take _ATL_FREE_THREADED into account
by Mark Jansen 27 Apr '23

27 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=507aae4c30510eb6a6176… commit 507aae4c30510eb6a6176c5cfd55b0366bf1370c Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Wed Apr 19 20:27:31 2023 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Thu Apr 27 16:29:21 2023 +0200 [ATL] Take _ATL_FREE_THREADED into account When it is not defined, COM should not be initialize multithreaded --- sdk/lib/atl/atlbase.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sdk/lib/atl/atlbase.h b/sdk/lib/atl/atlbase.h index 1b0b0361b6a..d6e0e9ec386 100644 --- a/sdk/lib/atl/atlbase.h +++ b/sdk/lib/atl/atlbase.h @@ -849,7 +849,12 @@ public: static HRESULT InitializeCom() { - return ::CoInitializeEx(NULL, COINIT_MULTITHREADED); +#if defined(_ATL_FREE_THREADED) + constexpr COINIT coInit = COINIT_MULTITHREADED; +#else + constexpr COINIT coInit = COINIT_APARTMENTTHREADED; +#endif + return ::CoInitializeEx(NULL, coInit); } static void UninitializeCom()

1 0

[reactos] 01/01: [ADVPACK_APITEST] Add advpack_apitest:DelNode testcase (#5256)
by Katayama Hirofumi MZ 27 Apr '23

27 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f4b7087a0e3c047c8a79b… commit f4b7087a0e3c047c8a79b8c567f7b21c12d70375 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Thu Apr 27 20:35:41 2023 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Thu Apr 27 20:35:41 2023 +0900 [ADVPACK_APITEST] Add advpack_apitest:DelNode testcase (#5256) Preparation for advpack!DelNodeA/W functions implementation. CORE-13275, ROSTESTS-276 --- modules/rostests/apitests/CMakeLists.txt | 1 + modules/rostests/apitests/advpack/CMakeLists.txt | 10 + modules/rostests/apitests/advpack/DelNode.c | 587 +++++++++++++++++++++++ modules/rostests/apitests/advpack/testlist.c | 18 + 4 files changed, 616 insertions(+) diff --git a/modules/rostests/apitests/CMakeLists.txt b/modules/rostests/apitests/CMakeLists.txt index b9f10c04120..407b5955964 100644 --- a/modules/rostests/apitests/CMakeLists.txt +++ b/modules/rostests/apitests/CMakeLists.txt @@ -5,6 +5,7 @@ include_directories(include) add_subdirectory(acpi) add_subdirectory(advapi32) +add_subdirectory(advpack) add_subdirectory(afd) add_subdirectory(apphelp) add_subdirectory(appshim) diff --git a/modules/rostests/apitests/advpack/CMakeLists.txt b/modules/rostests/apitests/advpack/CMakeLists.txt new file mode 100644 index 00000000000..a811f98e1b3 --- /dev/null +++ b/modules/rostests/apitests/advpack/CMakeLists.txt @@ -0,0 +1,10 @@ + +list(APPEND SOURCE + DelNode.c + testlist.c) + +add_executable(advpack_apitest ${SOURCE}) +target_link_libraries(advpack_apitest wine ${PSEH_LIB}) +set_module_type(advpack_apitest win32cui) +add_importlibs(advpack_apitest advpack msvcrt kernel32 ntdll) +add_rostests_file(TARGET advpack_apitest) diff --git a/modules/rostests/apitests/advpack/DelNode.c b/modules/rostests/apitests/advpack/DelNode.c new file mode 100644 index 00000000000..7f968d5ab8f --- /dev/null +++ b/modules/rostests/apitests/advpack/DelNode.c @@ -0,0 +1,587 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Test for advpack.dll DelNode function + * COPYRIGHT: Copyright 2023 Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> + */ +#include <apitest.h> + +#include <windef.h> +#include <stdio.h> + +/* Flags for DelNode */ +#define ADN_DEL_IF_EMPTY 0x00000001 +#define ADN_DONT_DEL_SUBDIRS 0x00000002 +#define ADN_DONT_DEL_DIR 0x00000004 +#define ADN_DEL_UNC_PATHS 0x00000008 + +/* DelNodeA and DelNodeW in advpack.dll */ +typedef HRESULT (WINAPI *DELNODEA)(LPCSTR, DWORD); +typedef HRESULT (WINAPI *DELNODEW)(LPCWSTR, DWORD); + +static HINSTANCE s_hAdvPack = NULL; +static DELNODEA s_pDelNodeA = NULL; +static DELNODEW s_pDelNodeW = NULL; + +typedef struct +{ + const char *item; + BOOL is_dir; +} NODEA; + +static const NODEA s_nodesA[] = +{ + { "dir1", TRUE }, /* 0 */ + { "dir1\\dir2", TRUE }, /* 1 */ + { "dir1\\dir2\\file1", FALSE }, /* 2 */ +}; + +typedef struct +{ + const WCHAR *item; + BOOL is_dir; +} NODEW; + +static const NODEW s_nodesW[] = +{ + { L"dir1", TRUE }, /* 0 */ + { L"dir1\\dir2", TRUE }, /* 1 */ + { L"dir1\\dir2\\file1", FALSE }, /* 2 */ +}; + +typedef enum +{ + EAT_CREATE, + EAT_DELETE, + EAT_CHECK_EXIST, + EAT_CHECK_NON_EXIST, + EAT_CALL +} ENTRY_ACTION_TYPE; + +typedef struct +{ + INT lineno; + INT node; + ENTRY_ACTION_TYPE action_type; + DWORD flags; + HRESULT ret; +} ENTRY; + +/* TODO: ADN_DEL_UNC_PATHS */ +#define FLAGS0 0 +#define FLAGS1 ADN_DEL_IF_EMPTY +#define FLAGS2 ADN_DONT_DEL_DIR +#define FLAGS3 ADN_DONT_DEL_SUBDIRS +#define FLAGS4 (ADN_DONT_DEL_DIR | ADN_DONT_DEL_SUBDIRS) +#define FLAGS5 (ADN_DEL_IF_EMPTY | ADN_DONT_DEL_DIR) +#define FLAGS6 (ADN_DEL_IF_EMPTY | ADN_DONT_DEL_SUBDIRS) +#define FLAGS7 (ADN_DEL_IF_EMPTY | ADN_DONT_DEL_DIR | ADN_DONT_DEL_SUBDIRS) +#define FLAGS8 0xFFFFFFFF + +/* The test entries */ +static const ENTRY s_entries[] = +{ + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_DELETE }, + { __LINE__, 0, EAT_DELETE }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS0, S_OK }, + { __LINE__, 0, EAT_CHECK_NON_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS1, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS2, S_OK }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS3, S_OK }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS4, S_OK }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS5, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS6, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS7, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS8, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS0, S_OK }, + { __LINE__, 0, EAT_CHECK_NON_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS1, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS2, S_OK }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS3, S_OK }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS4, S_OK }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS5, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS6, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS7, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 0, EAT_CREATE }, + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 0, EAT_CALL, FLAGS8, E_FAIL }, + { __LINE__, 0, EAT_CHECK_EXIST }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS0, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS1, E_FAIL }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS2, S_OK }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS3, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS4, S_OK }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS5, E_FAIL }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS6, E_FAIL }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS7, E_FAIL }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS8, E_FAIL }, + { __LINE__, 1, EAT_CHECK_EXIST }, + { __LINE__, 2, EAT_CHECK_EXIST }, + + { __LINE__, 2, EAT_DELETE }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS0, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS1, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS2, S_OK }, + { __LINE__, 1, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS3, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS4, S_OK }, + { __LINE__, 1, EAT_CHECK_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS5, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS6, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS7, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + { __LINE__, 1, EAT_CALL, FLAGS8, S_OK }, + { __LINE__, 1, EAT_CHECK_NON_EXIST }, + + { __LINE__, 1, EAT_CREATE }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS0, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS1, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS2, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS3, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS4, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS5, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS6, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS7, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_CREATE }, + { __LINE__, 2, EAT_CALL, FLAGS8, S_OK }, + { __LINE__, 2, EAT_CHECK_NON_EXIST }, + + { __LINE__, 2, EAT_DELETE }, + { __LINE__, 1, EAT_DELETE }, + { __LINE__, 0, EAT_DELETE }, + + { __LINE__, 2, EAT_CALL, FLAGS0, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS1, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS2, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS3, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS4, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS5, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS6, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS7, E_FAIL }, + { __LINE__, 2, EAT_CALL, FLAGS8, E_FAIL }, + + { __LINE__, 1, EAT_CALL, FLAGS0, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS1, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS2, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS3, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS4, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS5, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS6, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS7, E_FAIL }, + { __LINE__, 1, EAT_CALL, FLAGS8, E_FAIL }, +}; + +static char s_cur_dir_A[MAX_PATH] = ""; +static WCHAR s_cur_dir_W[MAX_PATH] = L""; + +static char *GetPathA(const char *item) +{ + static char s_path[MAX_PATH]; + lstrcpyA(s_path, s_cur_dir_A); + lstrcatA(s_path, "\\"); + lstrcatA(s_path, item); + return s_path; +} + +static WCHAR *GetPathW(const WCHAR *item) +{ + static WCHAR s_path[MAX_PATH]; + lstrcpyW(s_path, s_cur_dir_W); + lstrcatW(s_path, L"\\"); + lstrcatW(s_path, item); + return s_path; +} + +static void cleanupA(void) +{ + size_t i, k; + for (k = 0; k < 4; ++k) + { + for (i = 0; i < _countof(s_nodesA); ++i) + { + const NODEA *node = &s_nodesA[i]; + char *path = GetPathA(node->item); + + DeleteFileA(path); + RemoveDirectoryA(path); + } + } +} + +static void Test_DelNodeA(void) +{ + DWORD attr; + size_t i; + + if (!GetCurrentDirectoryA(_countof(s_cur_dir_A), s_cur_dir_A)) + { + skip("GetCurrentDirectoryA failed\n"); + return; + } + + cleanupA(); + + for (i = 0; i < _countof(s_entries); ++i) + { + const ENTRY *entry = &s_entries[i]; + INT lineno = entry->lineno; + const NODEA *node = &s_nodesA[entry->node]; + char *path = GetPathA(node->item); + INT ret; + + switch (entry->action_type) + { + case EAT_CREATE: + if (node->is_dir) + { + CreateDirectoryA(path, NULL); + + attr = GetFileAttributesA(path); + ok(attr != INVALID_FILE_ATTRIBUTES, "Line %d: path:%s, attr:0x%08lX\n", lineno, path, attr); + ok((attr & FILE_ATTRIBUTE_DIRECTORY), "Line %d: path:%s, attr:0x%08lX\n", lineno, path, attr); + } + else + { + fclose(fopen(path, "w")); + + attr = GetFileAttributesA(path); + ok(attr != INVALID_FILE_ATTRIBUTES, "Line %d: attr was 0x%08lX\n", lineno, attr); + ok(!(attr & FILE_ATTRIBUTE_DIRECTORY), "Line %d: attr was 0x%08lX\n", lineno, attr); + } + break; + case EAT_DELETE: + if (node->is_dir) + { + RemoveDirectoryA(path); + } + else + { + DeleteFileA(path); + } + attr = GetFileAttributesA(path); + ok(attr == INVALID_FILE_ATTRIBUTES, "Line %d: cannot delete\n", lineno); + break; + case EAT_CHECK_EXIST: + attr = GetFileAttributesA(path); + ok(attr != INVALID_FILE_ATTRIBUTES, "Line %d: attr was 0x%08lX\n", lineno, attr); + break; + case EAT_CHECK_NON_EXIST: + attr = GetFileAttributesA(path); + ok(attr == INVALID_FILE_ATTRIBUTES, "Line %d: attr was 0x%08lX\n", lineno, attr); + break; + case EAT_CALL: + ret = (*s_pDelNodeA)(path, entry->flags); + ok(ret == entry->ret, "Line %d: ret:%d, path:%s, flags:0x%08lX\n", + lineno, ret, path, entry->flags); + break; + } + } + + cleanupA(); +} + +static void cleanupW(void) +{ + size_t i, k; + for (k = 0; k < 4; ++k) + { + for (i = 0; i < _countof(s_nodesW); ++i) + { + const NODEW *node = &s_nodesW[i]; + WCHAR *path = GetPathW(node->item); + + DeleteFileW(path); + RemoveDirectoryW(path); + } + } +} + +static void Test_DelNodeW(void) +{ + DWORD attr; + size_t i; + + if (!GetCurrentDirectoryW(_countof(s_cur_dir_W), s_cur_dir_W)) + { + skip("GetCurrentDirectoryA failed\n"); + return; + } + + cleanupW(); + + for (i = 0; i < _countof(s_entries); ++i) + { + const ENTRY *entry = &s_entries[i]; + INT lineno = entry->lineno; + const NODEW *node = &s_nodesW[entry->node]; + WCHAR *path = GetPathW(node->item); + INT ret; + + switch (entry->action_type) + { + case EAT_CREATE: + if (node->is_dir) + { + CreateDirectoryW(path, NULL); + + attr = GetFileAttributesW(path); + ok(attr != INVALID_FILE_ATTRIBUTES, "Line %d: path:%S, attr:0x%08lX\n", lineno, path, attr); + ok((attr & FILE_ATTRIBUTE_DIRECTORY), "Line %d: path:%S, attr:0x%08lX\n", lineno, path, attr); + } + else + { + fclose(_wfopen(path, L"w")); + + attr = GetFileAttributesW(path); + ok(attr != INVALID_FILE_ATTRIBUTES, "Line %d: attr was 0x%08lX\n", lineno, attr); + ok(!(attr & FILE_ATTRIBUTE_DIRECTORY), "Line %d: attr was 0x%08lX\n", lineno, attr); + } + break; + case EAT_DELETE: + if (node->is_dir) + { + RemoveDirectoryW(path); + } + else + { + DeleteFileW(path); + } + attr = GetFileAttributesW(path); + ok(attr == INVALID_FILE_ATTRIBUTES, "Line %d: cannot delete\n", lineno); + break; + case EAT_CHECK_EXIST: + attr = GetFileAttributesW(path); + ok(attr != INVALID_FILE_ATTRIBUTES, "Line %d: attr was 0x%08lX\n", lineno, attr); + break; + case EAT_CHECK_NON_EXIST: + attr = GetFileAttributesW(path); + ok(attr == INVALID_FILE_ATTRIBUTES, "Line %d: attr was 0x%08lX\n", lineno, attr); + break; + case EAT_CALL: + ret = (*s_pDelNodeW)(path, entry->flags); + ok(ret == entry->ret, "Line %d: ret:%d, path:%S, flags:0x%08lX\n", + lineno, ret, path, entry->flags); + break; + } + } + + cleanupW(); +} + +START_TEST(DelNode) +{ + s_hAdvPack = LoadLibraryA("advpack.dll"); + if (s_hAdvPack == NULL) + { + skip("unable to load advpack.dll\n"); + return; + } + + /* DelNodeA */ + s_pDelNodeA = (DELNODEA)GetProcAddress(s_hAdvPack, "DelNodeA"); + if (s_pDelNodeA) + { + Test_DelNodeA(); + } + else + { + skip("DelNodeA not found in advpack.dll\n"); + } + + /* DelNodeW */ + s_pDelNodeW = (DELNODEW)GetProcAddress(s_hAdvPack, "DelNodeW"); + if (s_pDelNodeW) + { + Test_DelNodeW(); + } + else + { + skip("DelNodeW not found in advpack.dll\n"); + } + + FreeLibrary(s_hAdvPack); + s_hAdvPack = NULL; +} diff --git a/modules/rostests/apitests/advpack/testlist.c b/modules/rostests/apitests/advpack/testlist.c new file mode 100644 index 00000000000..281dac8b345 --- /dev/null +++ b/modules/rostests/apitests/advpack/testlist.c @@ -0,0 +1,18 @@ +/* + * PROJECT: ReactOS API tests + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Test for advpack.dll functions + * COPYRIGHT: Copyright 2023 Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> + */ + +#define __ROS_LONG64__ +#define STANDALONE +#include <apitest.h> + +extern void func_DelNode(void); + +const struct test winetest_testlist[] = +{ + { "DelNode", func_DelNode }, + { 0, 0 } +};

1 0

[reactos] 01/01: [SHELL32] Implement SHQueryRecycleBinW
by Mark Jansen 26 Apr '23

26 Apr '23

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=4cdcea5e65326cbea7745… commit 4cdcea5e65326cbea77458a3e9daa335d2e530b7 Author: Mark Jansen <mark.jansen(a)reactos.org> AuthorDate: Wed Apr 19 20:30:24 2023 +0200 Commit: Mark Jansen <mark.jansen(a)reactos.org> CommitDate: Wed Apr 26 22:50:11 2023 +0200 [SHELL32] Implement SHQueryRecycleBinW --- dll/win32/shell32/folders/CRecycleBin.cpp | 36 +++++++++++++++++++++++--- dll/win32/shell32/shellrecyclebin/recyclebin.c | 12 --------- dll/win32/shell32/shellrecyclebin/recyclebin.h | 11 -------- 3 files changed, 32 insertions(+), 27 deletions(-) diff --git a/dll/win32/shell32/folders/CRecycleBin.cpp b/dll/win32/shell32/folders/CRecycleBin.cpp index bb44ca3cd6a..6dba39d8c69 100644 --- a/dll/win32/shell32/folders/CRecycleBin.cpp +++ b/dll/win32/shell32/folders/CRecycleBin.cpp @@ -415,7 +415,7 @@ HRESULT WINAPI CRecycleBinItemContextMenu::InvokeCommand(LPCMINVOKECOMMANDINFO l BOOL ret = TRUE; /* restore file */ - if (lpcmi->lpVerb == MAKEINTRESOURCEA(1)) + if (lpcmi->lpVerb == MAKEINTRESOURCEA(1)) ret = RestoreFile(Context.hDeletedFile); /* delete file */ else @@ -1244,10 +1244,10 @@ HRESULT WINAPI SHQueryRecycleBinA(LPCSTR pszRootPath, LPSHQUERYRBINFO pSHQueryRB HRESULT WINAPI SHQueryRecycleBinW(LPCWSTR pszRootPath, LPSHQUERYRBINFO pSHQueryRBInfo) { - FIXME("%s, %p - stub\n", debugstr_w(pszRootPath), pSHQueryRBInfo); + TRACE("%s, %p\n", debugstr_w(pszRootPath), pSHQueryRBInfo); - if (!(pszRootPath) || (pszRootPath[0] == 0) || - !(pSHQueryRBInfo) || (pSHQueryRBInfo->cbSize < sizeof(SHQUERYRBINFO))) + if (!pszRootPath || (pszRootPath[0] == 0) || + !pSHQueryRBInfo || (pSHQueryRBInfo->cbSize < sizeof(SHQUERYRBINFO))) { return E_INVALIDARG; } @@ -1255,5 +1255,33 @@ HRESULT WINAPI SHQueryRecycleBinW(LPCWSTR pszRootPath, LPSHQUERYRBINFO pSHQueryR pSHQueryRBInfo->i64Size = 0; pSHQueryRBInfo->i64NumItems = 0; + CComPtr<IRecycleBin> spRecycleBin; + HRESULT hr; + if (FAILED_UNEXPECTEDLY((hr = GetDefaultRecycleBin(pszRootPath, &spRecycleBin)))) + return hr; + + CComPtr<IRecycleBinEnumList> spEnumList; + hr = spRecycleBin->EnumObjects(&spEnumList); + if (!SUCCEEDED(hr)) + return hr; + + while (TRUE) + { + CComPtr<IRecycleBinFile> spFile; + hr = spEnumList->Next(1, &spFile, NULL); + if (hr == S_FALSE) + return S_OK; + + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + ULARGE_INTEGER Size = {}; + if (FAILED_UNEXPECTEDLY((hr = spFile->GetFileSize(&Size)))) + return hr; + + pSHQueryRBInfo->i64Size += Size.QuadPart; + pSHQueryRBInfo->i64NumItems++; + } + return S_OK; } diff --git a/dll/win32/shell32/shellrecyclebin/recyclebin.c b/dll/win32/shell32/shellrecyclebin/recyclebin.c index a6392496012..670e81b6dbf 100644 --- a/dll/win32/shell32/shellrecyclebin/recyclebin.c +++ b/dll/win32/shell32/shellrecyclebin/recyclebin.c @@ -376,18 +376,6 @@ cleanup: return FALSE; } -BOOL WINAPI -GetRecycleBinDetails( - IN LPCWSTR pszVolume OPTIONAL, - OUT ULARGE_INTEGER *pulTotalItems, - OUT ULARGE_INTEGER *pulTotalSize) -{ - pulTotalItems->QuadPart = 0; - pulTotalSize->QuadPart = 0; - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return FALSE; -} - BOOL WINAPI RestoreFile( IN HANDLE hDeletedFile) diff --git a/dll/win32/shell32/shellrecyclebin/recyclebin.h b/dll/win32/shell32/shellrecyclebin/recyclebin.h index 50c020c839f..f15828a9639 100644 --- a/dll/win32/shell32/shellrecyclebin/recyclebin.h +++ b/dll/win32/shell32/shellrecyclebin/recyclebin.h @@ -164,17 +164,6 @@ GetDeletedFileDetailsW( #define GetDeletedFileDetails GetDeletedFileDetailsA #endif -/* Get details about a whole recycle bin - * pszVolume: - * pulTotalItems: - * pulTotalSize - */ -BOOL WINAPI -GetRecycleBinDetails( - IN LPCWSTR pszVolume OPTIONAL, - OUT ULARGE_INTEGER *pulTotalItems, - OUT ULARGE_INTEGER *pulTotalSize); - /* Restores a deleted file * hDeletedFile: handle of the deleted file to restore * Returns TRUE if operation succeeded, FALSE otherwise.

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs