Ros-diffs

ros-diffs@reactos.org

10 participants
81009 discussions

[reactos] 02/09: [RAPPS] Simplify CAppsListView::SetCheckboxesVisible() into ShowCheckboxes()

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2a2df969b0ad0ff5c8fe7… commit 2a2df969b0ad0ff5c8fe72ba97aa73858a06998b Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Mon Sep 16 22:47:42 2024 +0200 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Wed Sep 18 12:31:43 2024 +0200 [RAPPS] Simplify CAppsListView::SetCheckboxesVisible() into ShowCheckboxes() --- base/applications/rapps/appview.cpp | 26 +++++++++----------------- base/applications/rapps/include/appview.h | 7 ++++--- 2 files changed, 13 insertions(+), 20 deletions(-) diff --git a/base/applications/rapps/appview.cpp b/base/applications/rapps/appview.cpp index fb7515d5cfc..03a4fd436fa 100644 --- a/base/applications/rapps/appview.cpp +++ b/base/applications/rapps/appview.cpp @@ -1109,19 +1109,11 @@ CAppsListView::SetWatermark(const CStringW &Text) m_Watermark = Text; } -VOID -CAppsListView::SetCheckboxesVisible(BOOL bIsVisible) +void +CAppsListView::ShowCheckboxes(bool bShow) { - if (bIsVisible) - { - SetExtendedListViewStyle(LVS_EX_CHECKBOXES | LVS_EX_FULLROWSELECT); - } - else - { - SetExtendedListViewStyle(LVS_EX_FULLROWSELECT); - } - - bHasCheckboxes = bIsVisible; + SetExtendedListViewStyle((bShow ? LVS_EX_CHECKBOXES : 0) | LVS_EX_FULLROWSELECT); + bHasCheckboxes = bShow; } VOID @@ -1254,7 +1246,7 @@ CAppsListView::Create(HWND hwndParent) if (hwnd) { - SetCheckboxesVisible(FALSE); + ShowCheckboxes(false); } #pragma push_macro("SubclassWindow") @@ -1363,8 +1355,8 @@ CAppsListView::SetDisplayAppType(APPLICATION_VIEW_TYPE AppType) szText.LoadStringW(IDS_APP_DESCRIPTION); AddColumn(ColumnCount++, szText, 300, LVCFMT_LEFT); - // disable checkboxes - SetCheckboxesVisible(FALSE); + // Disable checkboxes + ShowCheckboxes(false); break; case AppViewTypeAvailableApps: @@ -1379,8 +1371,8 @@ CAppsListView::SetDisplayAppType(APPLICATION_VIEW_TYPE AppType) szText.LoadStringW(IDS_APP_DESCRIPTION); AddColumn(ColumnCount++, szText, 300, LVCFMT_LEFT); - // enable checkboxes - SetCheckboxesVisible(TRUE); + // Enable checkboxes + ShowCheckboxes(true); break; default: diff --git a/base/applications/rapps/include/appview.h b/base/applications/rapps/include/appview.h index 46a3a583092..0c9aa29a733 100644 --- a/base/applications/rapps/include/appview.h +++ b/base/applications/rapps/include/appview.h @@ -195,7 +195,7 @@ class CAppsListView : public CUiWindow<CWindowImpl<CAppsListView, CListView>> }; BOOL bIsAscending = TRUE; - BOOL bHasCheckboxes = FALSE; + bool bHasCheckboxes = false; INT ItemCount = 0; INT CheckedItemCount = 0; @@ -224,8 +224,9 @@ class CAppsListView : public CUiWindow<CWindowImpl<CAppsListView, CListView>> VOID SetWatermark(const CStringW &Text); - VOID - SetCheckboxesVisible(BOOL bIsVisible); + + void + ShowCheckboxes(bool bShow); VOID ColumnClick(LPNMLISTVIEW pnmv);

3 months, 3 weeks

[reactos] 01/09: [RAPPS] Merge CMainToolbar::Show/HideButtonCaption() into one single function.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=385274e2dd0309bba8495… commit 385274e2dd0309bba84955d9f67dcbcb07bba066 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Fri Mar 22 21:58:35 2024 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Wed Sep 18 12:31:41 2024 +0200 [RAPPS] Merge CMainToolbar::Show/HideButtonCaption() into one single function. --- base/applications/rapps/appview.cpp | 20 ++++++++------------ base/applications/rapps/include/appview.h | 6 ++---- 2 files changed, 10 insertions(+), 16 deletions(-) diff --git a/base/applications/rapps/appview.cpp b/base/applications/rapps/appview.cpp index e16c0929a92..fb7515d5cfc 100644 --- a/base/applications/rapps/appview.cpp +++ b/base/applications/rapps/appview.cpp @@ -157,18 +157,14 @@ CMainToolbar::Create(HWND hwndParent) return m_hWnd; } -VOID -CMainToolbar::HideButtonCaption() -{ - DWORD dCurrentExStyle = (DWORD)SendMessageW(TB_GETEXTENDEDSTYLE, 0, 0); - SendMessageW(TB_SETEXTENDEDSTYLE, 0, dCurrentExStyle | TBSTYLE_EX_MIXEDBUTTONS); -} - -VOID -CMainToolbar::ShowButtonCaption() +void +CMainToolbar::ShowButtonCaption(bool bShow) { DWORD dCurrentExStyle = (DWORD)SendMessageW(TB_GETEXTENDEDSTYLE, 0, 0); - SendMessageW(TB_SETEXTENDEDSTYLE, 0, dCurrentExStyle & ~TBSTYLE_EX_MIXEDBUTTONS); + if (bShow) + SendMessageW(TB_SETEXTENDEDSTYLE, 0, dCurrentExStyle & ~TBSTYLE_EX_MIXEDBUTTONS); + else + SendMessageW(TB_SETEXTENDEDSTYLE, 0, dCurrentExStyle | TBSTYLE_EX_MIXEDBUTTONS); } DWORD @@ -1737,11 +1733,11 @@ CApplicationView::OnSize(HWND hwnd, WPARAM wParam, LPARAM lParam) if (dSearchbarMargin > dToolbarTreshold) { - m_Toolbar->ShowButtonCaption(); + m_Toolbar->ShowButtonCaption(true); } else if (dSearchbarMargin < dToolbarTreshold) { - m_Toolbar->HideButtonCaption(); + m_Toolbar->ShowButtonCaption(false); } RECT r = {0, 0, LOWORD(lParam), HIWORD(lParam)}; diff --git a/base/applications/rapps/include/appview.h b/base/applications/rapps/include/appview.h index debc0b2c1bb..46a3a583092 100644 --- a/base/applications/rapps/include/appview.h +++ b/base/applications/rapps/include/appview.h @@ -293,10 +293,8 @@ class CMainToolbar : public CUiWindow<CToolbar<>> HWND Create(HWND hwndParent); - VOID - HideButtonCaption(); - VOID - ShowButtonCaption(); + void + ShowButtonCaption(bool bShow); DWORD GetMaxButtonsWidth() const;

3 months, 3 weeks

[reactos] 07/07: [WIN32NT_APITEST] Fix tests for NtUserSystemParametersInfo

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e8cf32cf15b25cc0d653e… commit e8cf32cf15b25cc0d653ee898768e14dd7ba0d36 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 15:12:38 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [WIN32NT_APITEST] Fix tests for NtUserSystemParametersInfo --- .../rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c b/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c index 9ecef4907b4..5adb538a2aa 100644 --- a/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c +++ b/modules/rostests/apitests/win32nt/ntuser/NtUserSystemParametersInfo.c @@ -583,8 +583,10 @@ Test_SPI_SETDESKWALLPAPER(void) RtlInitUnicodeString(&ustrOld, szOld); /* Set no Wallpaper */ +#ifndef _M_AMD64 TEST(NtUserSystemParametersInfo(SPI_SETDESKWALLPAPER, 0, L"", 0) == 1); - TEST(NtUserSystemParametersInfo(SPI_GETDESKWALLPAPER, MAX_PATH, szNew, 0) == 1); +#endif + TEST(NtUserSystemParametersInfo(SPI_GETDESKWALLPAPER, MAX_PATH, szNew, 0) != 0); TEST(szNew[0] == 0); /* Set no Wallpaper 2 */ @@ -609,9 +611,11 @@ Test_SPI_SETDESKWALLPAPER(void) /* Get Wallpaper, too small buffer */ szNew[0] = 0; szNew[1] = 0; szNew[2] = 0; TEST(NtUserSystemParametersInfo(SPI_GETDESKWALLPAPER, 3, szNew, 0) == 1); +#if 0 // This is broken TEST(szNew[0] != 0); TEST(szNew[1] != 0); TEST(szNew[2] != 0); +#endif /* Set invalid Wallpaper */ SetLastError(0xdeadbeef);

3 months, 3 weeks

[reactos] 06/07: [WIN32NT_APITEST] Fix NtGdiCreateBitmap test on x64

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a23e8da23edebbcdc6839… commit a23e8da23edebbcdc6839a7172547b667f4493ed Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 15:03:07 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [WIN32NT_APITEST] Fix NtGdiCreateBitmap test on x64 --- modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateBitmap.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateBitmap.c b/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateBitmap.c index fee272af496..2882b0ca332 100644 --- a/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateBitmap.c +++ b/modules/rostests/apitests/win32nt/ntgdi/NtGdiCreateBitmap.c @@ -54,10 +54,17 @@ void Test_NtGdiCreateBitmap_Params(void) ok_ptr(NtGdiCreateBitmap(1, -2, 1, 1, (BYTE*)(LONG_PTR)0x80001234), NULL); ok_long(GetLastError(), ERROR_SUCCESS); +#ifndef _WIN64 // Win64 doesn't fail here /* Test huge size */ SetLastError(ERROR_SUCCESS); ok_ptr(NtGdiCreateBitmap(100000, 100000, 1, 1, NULL), NULL); ok_long(GetLastError(), ERROR_NOT_ENOUGH_MEMORY); +#endif + + /* Test too huge size */ + SetLastError(ERROR_SUCCESS); + ok_ptr(NtGdiCreateBitmap(100000, 100000, 1, 32, NULL), NULL); + ok_long(GetLastError(), ERROR_INVALID_PARAMETER); /* Test huge size and valid bits */ SetLastError(ERROR_SUCCESS);

3 months, 3 weeks

[reactos] 05/07: [CRT_APITEST] Fix version check

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f68d8d545978cd0c3426b… commit f68d8d545978cd0c3426ba0038dd7c9131393398 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 14:27:02 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [CRT_APITEST] Fix version check --- modules/rostests/apitests/crt/_mbsncmp.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/rostests/apitests/crt/_mbsncmp.c b/modules/rostests/apitests/crt/_mbsncmp.c index 836f19afd85..97ca44c13d1 100644 --- a/modules/rostests/apitests/crt/_mbsncmp.c +++ b/modules/rostests/apitests/crt/_mbsncmp.c @@ -11,6 +11,8 @@ #include <pseh/pseh2.h> #include <ndk/mmfuncs.h> +ULONG g_WinVersion; + /* * cmp functions can either return 1/-1 or the actual difference between the * first two differing characters. @@ -20,7 +22,7 @@ #ifdef TEST_CRTDLL #define RETURN_DIFF 0 #else -#define RETURN_DIFF (GetVersion() >= 0x0600) +#define RETURN_DIFF (g_WinVersion >= _WIN32_WINNT_VISTA) #endif #define DIFF_RETURN(sign, absolute) (sign (RETURN_DIFF ? absolute : 1)) @@ -29,6 +31,9 @@ START_TEST(_mbsncmp) { int ret; + ULONG Version = GetVersion(); + g_WinVersion = (Version & 0xFF) << 8 | (Version & 0xFF00) >> 8; + /* Zero length always returns true */ ret = _mbsncmp(NULL, NULL, 0); ok(ret == 0, "ret = %d\n", ret);

3 months, 3 weeks

[reactos] 04/07: [KMTEST/x64] Fix tests for RtlCaptureContextKM

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a54be9726d7fc4e38479a… commit a54be9726d7fc4e38479a5141f83e3f90f565ad0 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 14:19:27 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [KMTEST/x64] Fix tests for RtlCaptureContextKM --- .../apitests/rtl/amd64/RtlCaptureContext.c | 60 ++++++++++++++++------ 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/modules/rostests/apitests/rtl/amd64/RtlCaptureContext.c b/modules/rostests/apitests/rtl/amd64/RtlCaptureContext.c index 80917428485..286d6bfd5d8 100644 --- a/modules/rostests/apitests/rtl/amd64/RtlCaptureContext.c +++ b/modules/rostests/apitests/rtl/amd64/RtlCaptureContext.c @@ -132,20 +132,6 @@ START_TEST(RtlCaptureContext) ok_eq_hex(CapturedContext.FltSave.DataOffset, 0x00890088); ok_eq_hex(CapturedContext.FltSave.DataSelector, 0x008a); ok_eq_hex(CapturedContext.FltSave.Reserved3, 0x0000); -#else - ok_eq_hex(CapturedContext.FltSave.ControlWord, 0xcccc); - ok_eq_hex(CapturedContext.FltSave.StatusWord, 0xcccc); - ok_eq_hex(CapturedContext.FltSave.TagWord, 0xcc); - ok_eq_hex(CapturedContext.FltSave.Reserved1, 0xcc); - ok_eq_hex(CapturedContext.FltSave.MxCsr_Mask, 0xcccccccc); - ok_eq_hex(CapturedContext.FltSave.ErrorOpcode, 0xcccc); - ok_eq_hex(CapturedContext.FltSave.ErrorOffset, 0xcccccccc); - ok_eq_hex(CapturedContext.FltSave.ErrorSelector, 0xcccc); - ok_eq_hex(CapturedContext.FltSave.Reserved2, 0xcccc); - ok_eq_hex(CapturedContext.FltSave.DataOffset, 0xcccccccc); - ok_eq_hex(CapturedContext.FltSave.DataSelector, 0xcccc); - ok_eq_hex(CapturedContext.FltSave.Reserved3, 0xcccc); -#endif /* We get the value from OriginalContext.MxCsr, since we set that later in the wrapper */ ok_eq_hex(CapturedContext.FltSave.MxCsr, OriginalContext.MxCsr); @@ -167,14 +153,54 @@ START_TEST(RtlCaptureContext) ok_eq_hex64(CapturedContext.Legacy[6].High, OriginalContext.Legacy[6].High & 0xFF); ok_eq_hex64(CapturedContext.Legacy[7].Low, OriginalContext.Legacy[7].Low); ok_eq_hex64(CapturedContext.Legacy[7].High, OriginalContext.Legacy[7].High & 0xFF); +#else + ok_eq_hex(CapturedContext.FltSave.ControlWord, 0xcccc); + ok_eq_hex(CapturedContext.FltSave.StatusWord, 0xcccc); + ok_eq_hex(CapturedContext.FltSave.TagWord, 0xcc); + ok_eq_hex(CapturedContext.FltSave.Reserved1, 0xcc); + ok_eq_hex(CapturedContext.FltSave.MxCsr_Mask, 0xcccccccc); + ok_eq_hex(CapturedContext.FltSave.ErrorOpcode, 0xcccc); + ok_eq_hex(CapturedContext.FltSave.ErrorOffset, 0xcccccccc); + ok_eq_hex(CapturedContext.FltSave.ErrorSelector, 0xcccc); + ok_eq_hex(CapturedContext.FltSave.Reserved2, 0xcccc); + ok_eq_hex(CapturedContext.FltSave.DataOffset, 0xcccccccc); + ok_eq_hex(CapturedContext.FltSave.DataSelector, 0xcccc); + ok_eq_hex(CapturedContext.FltSave.Reserved3, 0xcccc); + + /* We get the value from OriginalContext.MxCsr, since we set that later in the wrapper */ + ok_eq_hex(CapturedContext.FltSave.MxCsr, 0xcccccccc); + + /* Legacy floating point registers are truncated to 10 bytes */ + ok_eq_hex64(CapturedContext.Legacy[0].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[0].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[1].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[1].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[2].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[2].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[3].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[3].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[4].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[4].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[5].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[5].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[6].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[6].High, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[7].Low, 0xcccccccccccccccc); + ok_eq_hex64(CapturedContext.Legacy[7].High, 0xcccccccccccccccc); +#endif /* We don't pass in segments, but expect the default values */ - ok_eq_hex(CapturedContext.SegCs, 0x33); ok_eq_hex(CapturedContext.SegDs, 0x2b); ok_eq_hex(CapturedContext.SegEs, 0x2b); ok_eq_hex(CapturedContext.SegFs, 0x53); ok_eq_hex(CapturedContext.SegGs, 0x2b); +#ifndef KMT_KERNEL_MODE // User mode + ok_eq_hex(CapturedContext.SegCs, 0x33); ok_eq_hex(CapturedContext.SegSs, 0x2b); +#else + ok_eq_hex(CapturedContext.SegCs, 0x10); + ok_eq_hex(CapturedContext.SegSs, 0x18); +#endif /* For Rsp and Rip we get the expected value back from the asm wrapper */ ok_eq_hex64(CapturedContext.Rsp, InOutContext.Rsp); @@ -212,7 +238,9 @@ START_TEST(RtlCaptureContext) ok_eq_hex64(InOutContext.R15, OriginalContext.R15); /* Eflags is changed (parity is flaky) */ +#ifndef KMT_KERNEL_MODE // User mode ok_eq_hex64(InOutContext.EFlags & ~0x04, OriginalContext.EFlags & 0x782); +#endif /* MxCsr is the one we passed in in OriginalContext.MxCsr */ ok_eq_hex(InOutContext.MxCsr, OriginalContext.MxCsr); @@ -235,7 +263,9 @@ START_TEST(RtlCaptureContext) ok_eq_hex64(CapturedContext.EFlags, OriginalContext.EFlags | 2); /* Parity flag is flaky */ +#ifndef KMT_KERNEL_MODE // User mode ok_eq_hex64(InOutContext.EFlags & ~4, CapturedContext.EFlags); +#endif /* MxCsr is captured/returned as passed in */ ok_eq_hex64(InOutContext.MxCsr, CapturedContext.MxCsr);

3 months, 3 weeks

[reactos] 03/07: [COM_APITEST] Fix 2 tests to pass on Windows 2003

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=70529929735e8db1918f8… commit 70529929735e8db1918f88a6461167587467a36f Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 14:06:09 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [COM_APITEST] Fix 2 tests to pass on Windows 2003 --- modules/rostests/apitests/com/com_apitest.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rostests/apitests/com/com_apitest.c b/modules/rostests/apitests/com/com_apitest.c index c60ac28d451..1241f823fa5 100644 --- a/modules/rostests/apitests/com/com_apitest.c +++ b/modules/rostests/apitests/com/com_apitest.c @@ -205,8 +205,8 @@ static KNOWN_INTERFACE KnownInterfaces[] = { ID_NAME(IID_IMenuPopup), TRUE }, { ID_NAME(IID_IModalWindow) }, { ID_NAME(IID_IMoniker) }, - { ID_NAME(IID_IMruDataList) }, - { ID_NAME(IID_IMruPidlList) }, + { ID_NAME(IID_IMruDataList), TRUE }, + { ID_NAME(IID_IMruPidlList), TRUE }, { ID_NAME(IID_IMultiMonitorDockingSite), TRUE }, { ID_NAME(IID_IMultiQI), TRUE }, { ID_NAME(IID_INameSpaceTreeControl), TRUE },

3 months, 3 weeks

[reactos] 02/07: [TESTS] Disable cmd:reactos, it's broken

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=73c6e99e14cc2155bb3e8… commit 73c6e99e14cc2155bb3e89fd5b1c0178544a1144 Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 14:02:59 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [TESTS] Disable cmd:reactos, it's broken --- modules/rostests/win32/cmd/testlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/rostests/win32/cmd/testlist.c b/modules/rostests/win32/cmd/testlist.c index bf8b9f138e7..938165372d2 100644 --- a/modules/rostests/win32/cmd/testlist.c +++ b/modules/rostests/win32/cmd/testlist.c @@ -7,6 +7,6 @@ extern void func_reactos(void); const struct test winetest_testlist[] = { - { "reactos", func_reactos }, + //{ "reactos", func_reactos }, This test is broken { 0, 0 } };

3 months, 3 weeks

[reactos] 01/07: [BROWSEUI_APITEST] Comment out tests that fail on Windows

by Timo Kreuzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5140a990fee96f6cb9fce… commit 5140a990fee96f6cb9fce1b268a1896d70ae60cd Author: Timo Kreuzer <timo.kreuzer(a)reactos.org> AuthorDate: Sat Apr 13 14:00:14 2024 +0300 Commit: Timo Kreuzer <timo.kreuzer(a)reactos.org> CommitDate: Wed Sep 18 10:22:26 2024 +0300 [BROWSEUI_APITEST] Comment out tests that fail on Windows @Katayama Hirofumi please investigate. --- modules/rostests/apitests/browseui/IAutoComplete.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/rostests/apitests/browseui/IAutoComplete.cpp b/modules/rostests/apitests/browseui/IAutoComplete.cpp index 6afff3d181b..16ffb54e1c5 100644 --- a/modules/rostests/apitests/browseui/IAutoComplete.cpp +++ b/modules/rostests/apitests/browseui/IAutoComplete.cpp @@ -449,7 +449,7 @@ DoTestCaseA(INT x, INT y, INT cx, INT cy, LPCWSTR pszInput, (WS_CHILD | WS_VISIBLE | WS_CLIPSIBLINGS | LVS_NOCOLUMNHEADER | \ LVS_OWNERDATA | LVS_OWNERDRAWFIXED | LVS_SINGLESEL | LVS_REPORT) // 0x54005405 if (bLong) - ok(style == LIST_STYLE_1, "style was 0x%08lx\n", style); + (void)0; // ok(style == LIST_STYLE_1, "style was 0x%08lx\n", style); broken on Windows else ok(style == LIST_STYLE_2, "style was 0x%08lx\n", style); ok_long(exstyle, 0); @@ -493,7 +493,7 @@ DoTestCaseA(INT x, INT y, INT cx, INT cy, LPCWSTR pszInput, // check item count INT nListCount = ListView_GetItemCount(hwndList); if (nListCount < 1000) - ok_int(nListCount, nCount); + (void)0; // ok_int(nListCount, nCount); broken on Windows else ok_int(nListCount, 1000);

3 months, 3 weeks

[reactos] 01/01: [LICCPA] Update Romanian (ro-RO) translation (#7295)

by Andrei Miloiu

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e8c7597b17a731b16be31… commit e8c7597b17a731b16be319da1d3822b1fd98d1b0 Author: Andrei Miloiu <miloiuandrei(a)gmail.com> AuthorDate: Wed Sep 18 02:10:05 2024 +0300 Commit: GitHub <noreply(a)github.com> CommitDate: Wed Sep 18 01:10:05 2024 +0200 [LICCPA] Update Romanian (ro-RO) translation (#7295) --- dll/cpl/liccpa/lang/ro-RO.rc | 28 +++++++++++++++------------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/dll/cpl/liccpa/lang/ro-RO.rc b/dll/cpl/liccpa/lang/ro-RO.rc index b11cf106bdf..e655ea4df75 100644 --- a/dll/cpl/liccpa/lang/ro-RO.rc +++ b/dll/cpl/liccpa/lang/ro-RO.rc @@ -1,33 +1,35 @@ /* - * FILE: dll/cpl/liccpa/lang/ro-RO.rc - * ReactOS Project (https://reactos.org) - * TRANSLATOR: Ștefan Fulea (stefan dot fulea at mail dot com) + * PROJECT: ReactOS Exploitation System + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Romanian resource file + * TRANSLATORS: Copyright 2011-2018 Ștefan Fulea <stefan.fulea(a)mail.com> + * Copyright 2024 Andrei Miloiu <miloiuandrei(a)gmail.com> */ LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL IDD_PROPPAGE1 DIALOGEX 20, 40, 315, 104 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_OVERLAPPED | WS_CAPTION | WS_VISIBLE | WS_SYSMENU -CAPTION "Alegeți modul de licențiere" +CAPTION "Alegere a modului de licențiere" FONT 8, "MS Shell Dlg" BEGIN - CONTROL "Mod de licențiere client", 100, "BUTTON", BS_GROUPBOX | WS_CHILD | WS_VISIBLE, 4, 4, 239, 94 + CONTROL "Mod de licențiere a clientului", 100, "BUTTON", BS_GROUPBOX | WS_CHILD | WS_VISIBLE, 4, 4, 239, 94 CONTROL "Per dispozitiv sau per utilizator", 102, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE, 13, 79, 147, 12 - CONTROL "Per server. Numărul de conexiuni paralele:", 103, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE, 13, 38, 163, 9 + CONTROL "Per server. Numărul de conexiuni simultane:", 103, "BUTTON", BS_AUTORADIOBUTTON | WS_CHILD | WS_VISIBLE, 13, 38, 163, 9 CONTROL "Produs:", 105, "STATIC", SS_LEFT | WS_CHILD | WS_VISIBLE, 13, 20, 31, 8 CONTROL "", 106, "COMBOBOX", CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_TABSTOP, 49, 20, 171, 12 - CONTROL "Con&firmă", 107, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 7, 46, 14 - CONTROL "A&nulează", 108, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 27, 46, 14 - CONTROL "Informații", 109, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 48, 46, 14 + CONTROL "OK", 107, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 7, 46, 14 + CONTROL "Revocare", 108, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 27, 46, 14 + CONTROL "Ajutor", 109, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 48, 46, 14 CONTROL "Replicare…", 110, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 263, 68, 46, 14 - CONTROL "Adaugă licențe", 111, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 30, 56, 65, 15 - CONTROL "Elimină licențe", 112, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 112, 56, 61, 16 + CONTROL "Adăugare de licențe", 111, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 30, 56, 65, 15 + CONTROL "Eliminare de licențe", 112, "BUTTON", BS_PUSHBUTTON | WS_CHILD | WS_VISIBLE | WS_TABSTOP, 112, 56, 61, 16 CONTROL "", 114, "EDIT", ES_LEFT | ES_AUTOHSCROLL | WS_CHILD | WS_VISIBLE | WS_BORDER | WS_TABSTOP, 187, 39, 32, 12 END STRINGTABLE BEGIN - IDS_CPLNAME_1 "Gestionar de licențe" - IDS_CPLDESCRIPTION_1 "Gestionar de licențe" + IDS_CPLNAME_1 "Manager de licențe" + IDS_CPLDESCRIPTION_1 "Manager de licențe" IDS_REACTOS "ReactOS - S.O. Public" END

3 months, 3 weeks

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs