https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7d1a497619f4001db59e5…
commit 7d1a497619f4001db59e552ddb69406bea4dae70
Author: Thomas Faber <thomas.faber(a)reactos.org>
AuthorDate: Sun Apr 3 20:10:37 2022 -0400
Commit: Thomas Faber <thomas.faber(a)reactos.org>
CommitDate: Sun Apr 3 20:13:09 2022 -0400
[NTOS:EX] Only set WakeTimer-related status if timer handle is valid. CORE-18133
Since STATUS_TIMER_RESUME_IGNORED is a success status, we would
otherwise go into the success case with a NULL Timer object pointer.
---
ntoskrnl/ex/timer.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ntoskrnl/ex/timer.c b/ntoskrnl/ex/timer.c
index 0ce7af03156..0c33675333c 100644
--- a/ntoskrnl/ex/timer.c
+++ b/ntoskrnl/ex/timer.c
@@ -640,7 +640,10 @@ NtSetTimer(IN HANDLE TimerHandle,
* functionality required to support them, make this check dependent
* on the actual PM capabilities
*/
- if (WakeTimer) Status = STATUS_TIMER_RESUME_IGNORED;
+ if (NT_SUCCESS(Status) && WakeTimer)
+ {
+ Status = STATUS_TIMER_RESUME_IGNORED;
+ }
/* Check status */
if (NT_SUCCESS(Status))
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=493bb8de46ce33720c931…
commit 493bb8de46ce33720c9319efa555ddb441d14519
Author: Joachim Henze <33393466+JoachimHenze(a)users.noreply.github.com>
AuthorDate: Thu Mar 31 21:18:26 2022 +0200
Commit: GitHub <noreply(a)github.com>
CommitDate: Thu Mar 31 21:18:26 2022 +0200
[CMAKE] msvc.cmake: Remove redundant '/Gy' (#4424)
* [CMAKE] msvc.cmake: Remove redundant '/Gy'
Function-level-Linking '/Gy' is already enabled unconditionally
at line 26. So no need to enable it here another time.
Makes the differences between the multiple OPTIMIZE-levels more obvious.
* [CMAKE] msvc.cmake: Fix typo in comment
---
sdk/cmake/msvc.cmake | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake
index 77de6955619..9f6d4544003 100644
--- a/sdk/cmake/msvc.cmake
+++ b/sdk/cmake/msvc.cmake
@@ -14,7 +14,7 @@ elseif(OPTIMIZE STREQUAL "3")
elseif(OPTIMIZE STREQUAL "4")
add_compile_options(/Ob0 /Od)
elseif(OPTIMIZE STREQUAL "5")
- add_compile_options(/Gy /Ob2 /Os /Ox /GS-)
+ add_compile_options(/Ob2 /Os /Ox /GS-)
endif()
# Always use string pooling: this helps reducing the binaries size since a lot
@@ -55,7 +55,7 @@ if(ARCH STREQUAL "i386")
endif()
endif()
-# CLang default to -fno-common from version 11 onward. We are not rady for this now
+# CLang default to -fno-common from version 11 onward. We are not ready for this now
if (USE_CLANG_CL)
add_compile_options(-fcommon)
endif()