Ros-diffs

ros-diffs@reactos.org

81390 discussions

[reactos] 01/01: [BROWSEUI] Enable AutoAppend of auto-completion (#3552)
by Katayama Hirofumi MZ 29 Mar '21

29 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=91e591b3d590df3c5164e… commit 91e591b3d590df3c5164ed6f88ac8da389d42cba Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Tue Mar 30 06:50:32 2021 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Tue Mar 30 06:50:32 2021 +0900 [BROWSEUI] Enable AutoAppend of auto-completion (#3552) Fix and improve Auto-Append of auto-completion. CORE-9281 - Implement CAutoComplete::DoAutoAppend method. --- dll/win32/browseui/CAutoComplete.cpp | 481 +++++++++++++++++------------------ dll/win32/browseui/CAutoComplete.h | 58 +---- 2 files changed, 239 insertions(+), 300 deletions(-) diff --git a/dll/win32/browseui/CAutoComplete.cpp b/dll/win32/browseui/CAutoComplete.cpp index b2ebc12ba68..d23b6d5cb78 100644 --- a/dll/win32/browseui/CAutoComplete.cpp +++ b/dll/win32/browseui/CAutoComplete.cpp @@ -40,6 +40,35 @@ static HHOOK s_hMouseHook = NULL; // hook handle static HWND s_hWatchWnd = NULL; // the window handle to watch +struct PREFIX_INFO +{ + LPCWSTR psz; + INT cch; +}; +static const PREFIX_INFO s_prefixes[] = +{ + { L"https://", 8 }, + { L"http://www.", 11 }, + { L"http://", 7 }, + { L"www.", 4 }, +}; + +static inline BOOL DropPrefix(const CStringW& str, CStringW& strBody) +{ + for (size_t iPrefix = 0; iPrefix < _countof(s_prefixes); ++iPrefix) + { + LPCWSTR psz = s_prefixes[iPrefix].psz; + INT cch = s_prefixes[iPrefix].cch; + if (::StrCmpNIW(str, psz, cch) == 0) + { + strBody = str.Mid(cch); + return TRUE; + } + } + strBody = str; + return FALSE; +} + // mouse hook procedure to watch the mouse click // https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/m… static LRESULT CALLBACK MouseProc(INT nCode, WPARAM wParam, LPARAM lParam) @@ -80,33 +109,41 @@ static LRESULT CALLBACK MouseProc(INT nCode, WPARAM wParam, LPARAM lParam) typedef CSimpleArray<CStringW> list_t; -static inline INT pivot(list_t& a, INT i, INT j) +static inline INT compare1(const CStringW& str1, const CStringW& str2) +{ + CStringW s1, s2; + DropPrefix(str1, s1); + DropPrefix(str2, s2); + return s1.CompareNoCase(s2); +} + +static inline INT pivot(list_t& list, INT i, INT j) { INT k = i + 1; - while (k <= j && a[i].CompareNoCase(a[k]) == 0) + while (k <= j && compare1(list[i], list[k]) == 0) k++; if (k > j) return -1; - if (a[i].CompareNoCase(a[k]) >= 0) + if (compare1(list[i], list[k]) >= 0) return i; return k; - } +} -static inline INT partition(list_t& a, INT i, INT j, const CStringW& x) +static inline INT partition(list_t& list, INT i, INT j, const CStringW& x) { INT left = i, right = j; while (left <= right) { - while (left <= j && a[left].CompareNoCase(x) < 0) + while (left <= j && compare1(list[left], x) < 0) left++; - while (right >= i && a[right].CompareNoCase(x) >= 0) + while (right >= i && compare1(list[right], x) >= 0) right--; if (left > right) break; - CStringW tmp = a[left]; - a[left] = a[right]; - a[right] = tmp; + CStringW tmp = list[left]; + list[left] = list[right]; + list[right] = tmp; left++; right--; @@ -114,16 +151,16 @@ static inline INT partition(list_t& a, INT i, INT j, const CStringW& x) return left; } -static void quicksort(list_t& a, INT i, INT j) +static void quicksort(list_t& list, INT i, INT j) { if (i == j) return; - INT p = pivot(a, i, j); + INT p = pivot(list, i, j); if (p == -1) return; - INT k = partition(a, i, j, a[p]); - quicksort(a, i, k - 1); - quicksort(a, k, j); + INT k = partition(list, i, j, list[p]); + quicksort(list, i, k - 1); + quicksort(list, k, j); } static inline void DoSort(list_t& list) @@ -142,7 +179,7 @@ static INT DoUnique(list_t& list) INT result = first; while (++first != last) { - if (list[result].CompareNoCase(list[first]) != 0) + if (compare1(list[result], list[first]) != 0) list[++result] = list[first]; } return ++result; @@ -158,7 +195,6 @@ static inline void DoUniqueAndTrim(list_t& list) } ////////////////////////////////////////////////////////////////////////////// -// CACEditCtrl // range of WCHAR (inclusive) struct RANGE @@ -217,176 +253,103 @@ EditWordBreakProcW(LPWSTR lpch, INT index, INT count, INT code) { case WB_ISDELIMITER: return IsWordBreak(lpch[index]); - case WB_LEFT: + { if (index) --index; while (index && !IsWordBreak(lpch[index])) --index; return index; - + } case WB_RIGHT: + { if (!count) break; while (index < count && lpch[index] && !IsWordBreak(lpch[index])) ++index; return index; - - default: - break; + } } return 0; } -CACEditCtrl::CACEditCtrl() : m_pDropDown(NULL), m_fnOldWordBreakProc(NULL) +static LRESULT CALLBACK +EditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam, + UINT_PTR uSubclassID, DWORD_PTR dwData) { + CAutoComplete *pThis = reinterpret_cast<CAutoComplete *>(dwData); + return pThis->EditWndProc(hwnd, uMsg, wParam, lParam); } -VOID CACEditCtrl::HookWordBreakProc(BOOL bHook) +LRESULT CAutoComplete::EditWndProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) { - if (bHook) + LRESULT ret; + HWND hwndGotFocus; + switch (uMsg) { - m_fnOldWordBreakProc = reinterpret_cast<EDITWORDBREAKPROCW>( - SendMessageW(EM_SETWORDBREAKPROC, 0, - reinterpret_cast<LPARAM>(EditWordBreakProcW))); - } - else - { - SendMessageW(EM_SETWORDBREAKPROC, 0, - reinterpret_cast<LPARAM>(m_fnOldWordBreakProc)); - } -} - -// WM_CHAR -// This message is posted to the window with the keyboard focus when WM_KEYDOWN is translated. -LRESULT CACEditCtrl::OnChar(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnChar(%p, %p)\n", this, wParam); - ATLASSERT(m_pDropDown); - return m_pDropDown->OnEditChar(wParam, lParam); -} - -// WM_CUT / WM_PASTE / WM_CLEAR @implemented -LRESULT CACEditCtrl::OnCutPasteClear(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnCutPasteClear(%p)\n", this); - ATLASSERT(m_pDropDown); - LRESULT ret = DefWindowProcW(uMsg, wParam, lParam); // do default - m_pDropDown->OnEditUpdate(TRUE); - return ret; -} - -// WM_DESTROY -// This message is sent when a window is being destroyed. -LRESULT CACEditCtrl::OnDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnDestroy(%p)\n", this); - ATLASSERT(m_pDropDown); - CAutoComplete *pDropDown = m_pDropDown; - - // unhook word break procedure - HookWordBreakProc(FALSE); - - // unsubclass because we don't watch any more - HWND hwndEdit = UnsubclassWindow(); - - // close the drop-down window - if (pDropDown) - { - pDropDown->PostMessageW(WM_CLOSE, 0, 0); - } - - return ::DefWindowProcW(hwndEdit, uMsg, wParam, lParam); // do default -} - -// WM_GETDLGCODE -// By responding to this message, an application can take control of a particular type of -// input and process the input itself. -LRESULT CACEditCtrl::OnGetDlgCode(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnGetDlgCode(%p)\n", this); - ATLASSERT(m_pDropDown); - - LRESULT ret = DefWindowProcW(uMsg, wParam, lParam); // get default - - if (m_pDropDown) - { - // some special keys need default processing. we handle them here - switch (wParam) - { - case VK_RETURN: - if (m_pDropDown->IsWindowVisible() || ::GetKeyState(VK_CONTROL) < 0) - m_pDropDown->OnEditKeyDown(VK_RETURN, 0); - break; - case VK_TAB: - if (m_pDropDown->IsWindowVisible() && m_pDropDown->UseTab()) - ret |= DLGC_WANTALLKEYS; // we want all keys to manipulate the list - break; - case VK_ESCAPE: - if (m_pDropDown->IsWindowVisible()) + case WM_CHAR: + return OnEditChar(wParam, lParam); + case WM_CUT: case WM_PASTE: case WM_CLEAR: + ret = ::DefSubclassProc(hwnd, uMsg, wParam, lParam); // do default + OnEditUpdate(TRUE); + return ret; + case WM_GETDLGCODE: + ret = ::DefSubclassProc(hwnd, uMsg, wParam, lParam); // do default + // some special keys need default processing. we handle them here + switch (wParam) + { + case VK_RETURN: + if (IsWindowVisible() || ::GetKeyState(VK_CONTROL) < 0) + OnEditKeyDown(VK_RETURN, 0); + break; + case VK_TAB: + if (IsWindowVisible() && UseTab()) + ret |= DLGC_WANTALLKEYS; // we want all keys to manipulate the list + break; + case VK_ESCAPE: + if (IsWindowVisible()) + ret |= DLGC_WANTALLKEYS; // we want all keys to manipulate the list + break; + default: + { ret |= DLGC_WANTALLKEYS; // we want all keys to manipulate the list - break; - default: + break; + } + } + return ret; + case WM_KEYDOWN: + if (OnEditKeyDown(wParam, lParam)) + return TRUE; // eat + break; + case WM_SETFOCUS: + break; + case WM_KILLFOCUS: + // hide the list if lost focus + hwndGotFocus = (HWND)wParam; + if (hwndGotFocus != m_hwndEdit && hwndGotFocus != m_hWnd) + HideDropDown(); + break; + case WM_SETTEXT: + if (!m_bInSetText) + HideDropDown(); // it's mechanical WM_SETTEXT + break; + case WM_DESTROY: + { + if (m_fnOldWordBreakProc) { - ret |= DLGC_WANTALLKEYS; // we want all keys to manipulate the list - break; + ::SendMessageW(hwnd, EM_SETWORDBREAKPROC, 0, reinterpret_cast<LPARAM>(m_fnOldWordBreakProc)); + m_fnOldWordBreakProc = NULL; } + ::RemoveWindowSubclass(hwnd, EditSubclassProc, 0); + if (::IsWindow(m_hWnd)) + PostMessageW(WM_CLOSE, 0, 0); + // remove reference to m_hwndEdit + Release(); + break; } } - return ret; -} - -// WM_KEYDOWN -// This message is posted to the window with the keyboard focus when a non-system key is pressed. -LRESULT CACEditCtrl::OnKeyDown(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnKeyDown(%p, %p)\n", this, wParam); - ATLASSERT(m_pDropDown); - if (m_pDropDown->OnEditKeyDown(wParam, lParam)) - return 1; // eat - bHandled = FALSE; // do default - return 0; -} - -// WM_KILLFOCUS @implemented -// This message is sent to a window immediately before it loses the keyboard focus. -LRESULT CACEditCtrl::OnKillFocus(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnKillFocus(%p)\n", this); - ATLASSERT(m_pDropDown); - - // hide the list if lost focus - HWND hwndGotFocus = (HWND)wParam; - if (hwndGotFocus != m_hWnd && hwndGotFocus != m_pDropDown->m_hWnd) - { - m_pDropDown->HideDropDown(); - } - - bHandled = FALSE; // do default - return 0; -} - -// WM_SETFOCUS -// This message is sent to a window after it has gained the keyboard focus. -LRESULT CACEditCtrl::OnSetFocus(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnSetFocus(%p)\n", this); - ATLASSERT(m_pDropDown); - bHandled = FALSE; // do default - return 0; -} - -// WM_SETTEXT -// An application sends this message to set the text of a window. -LRESULT CACEditCtrl::OnSetText(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) -{ - TRACE("CACEditCtrl::OnSetText(%p)\n", this); - ATLASSERT(m_pDropDown); - if (!m_pDropDown->m_bInSetText) - m_pDropDown->HideDropDown(); // it's mechanical WM_SETTEXT - bHandled = FALSE; // do default - return 0; + return ::DefSubclassProc(hwnd, uMsg, wParam, lParam); // do default } ////////////////////////////////////////////////////////////////////////////// @@ -503,7 +466,7 @@ LRESULT CACListView::OnLButtonDown(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL if (iItem != -1) { m_pDropDown->SelectItem(iItem); // select the item - CString strText = GetItemText(iItem); // get text of item + CStringW strText = GetItemText(iItem); // get text of item m_pDropDown->SetEditText(strText); // set text m_pDropDown->SetEditSel(0, strText.GetLength()); // select all m_pDropDown->HideDropDown(); // hide @@ -545,10 +508,6 @@ LRESULT CACListView::OnNCHitTest(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL & ////////////////////////////////////////////////////////////////////////////// // CACScrollBar -CACScrollBar::CACScrollBar() : m_pDropDown(NULL) -{ -} - HWND CACScrollBar::Create(HWND hwndParent) { ATLASSERT(m_hWnd == NULL); @@ -563,10 +522,6 @@ HWND CACScrollBar::Create(HWND hwndParent) ////////////////////////////////////////////////////////////////////////////// // CACSizeBox -CACSizeBox::CACSizeBox() : m_pDropDown(NULL), m_bDowner(TRUE), m_bLongList(FALSE) -{ -} - HWND CACSizeBox::Create(HWND hwndParent) { ATLASSERT(m_hWnd == NULL); @@ -684,6 +639,7 @@ CAutoComplete::CAutoComplete() : m_bInSetText(FALSE), m_bInSelectItem(FALSE) , m_bDowner(TRUE), m_dwOptions(ACO_AUTOAPPEND | ACO_AUTOSUGGEST) , m_bEnabled(TRUE), m_hwndCombo(NULL), m_hFont(NULL), m_bResized(FALSE) + , m_hwndEdit(NULL), m_fnOldEditProc(NULL), m_fnOldWordBreakProc(NULL) { } @@ -693,7 +649,8 @@ HWND CAutoComplete::CreateDropDown() DWORD dwStyle = WS_POPUP | /*WS_VISIBLE |*/ WS_CLIPSIBLINGS | WS_CLIPCHILDREN | WS_BORDER; DWORD dwExStyle = WS_EX_TOOLWINDOW | WS_EX_TOPMOST | WS_EX_NOPARENTNOTIFY; Create(NULL, NULL, NULL, dwStyle, dwExStyle); - TRACE("CAutoComplete::CreateDropDown(%p): m_hWnd == %p\n", this, m_hWnd); + TRACE("CAutoComplete::CreateDropDown(%p): m_hWnd=%p, m_hwndEdit=%p\n", + this, m_hWnd, m_hwndEdit); return m_hWnd; } @@ -705,6 +662,9 @@ CAutoComplete::~CAutoComplete() ::DeleteObject(m_hFont); m_hFont = NULL; } + // quit holding them + m_pEnum.Release(); + m_pACList.Release(); } BOOL CAutoComplete::CanAutoSuggest() @@ -729,6 +689,11 @@ BOOL CAutoComplete::IsComboBoxDropped() return (BOOL)::SendMessageW(m_hwndCombo, CB_GETDROPPEDSTATE, 0, 0); } +BOOL CAutoComplete::FilterPrefixes() +{ + return !!(m_dwOptions & ACO_FILTERPREFIXES) && m_bEnabled; +} + INT CAutoComplete::GetItemCount() { return m_outerList.GetSize(); @@ -743,20 +708,16 @@ CStringW CAutoComplete::GetItemText(INT iItem) CStringW CAutoComplete::GetEditText() { - BSTR bstrText = NULL; - CStringW strText; - if (m_hwndEdit.GetWindowTextW(bstrText)) - { - strText = bstrText; - ::SysFreeString(bstrText); - } - return strText; + WCHAR szText[L_MAX_URL_LENGTH]; + if (::GetWindowTextW(m_hwndEdit, szText, _countof(szText))) + return szText; + return L""; } VOID CAutoComplete::SetEditText(LPCWSTR pszText) { m_bInSetText = TRUE; // don't hide drop-down - m_hwndEdit.SetWindowTextW(pszText); + ::CallWindowProcW(m_fnOldEditProc, m_hwndEdit, WM_SETTEXT, 0, reinterpret_cast<LPARAM>(pszText)); m_bInSetText = FALSE; } @@ -771,7 +732,7 @@ CStringW CAutoComplete::GetStemText() VOID CAutoComplete::SetEditSel(INT ich0, INT ich1) { - m_hwndEdit.SendMessageW(EM_SETSEL, ich0, ich1); + ::CallWindowProcW(m_fnOldEditProc, m_hwndEdit, EM_SETSEL, ich0, ich1); } VOID CAutoComplete::ShowDropDown() @@ -817,23 +778,52 @@ VOID CAutoComplete::DoAutoAppend() // get the common string CStringW strCommon; + BOOL bFound = FALSE; for (INT iItem = 0; iItem < cItems; ++iItem) { - const CString& strItem = m_innerList[iItem]; // get the text of the item + const CStringW& strItem = m_innerList[iItem]; // get the text of the item - if (iItem == 0) // the first item + CStringW strBody; + if (DropPrefix(strItem, strBody) && + ::StrCmpNIW(strBody, strText, strText.GetLength()) == 0) { - strCommon = strItem; // store the text + if (!bFound) + { + bFound = TRUE; + strCommon = strBody; + continue; + } + for (INT ich = 0; ich < strBody.GetLength(); ++ich) + { + if (strCommon.GetLength() <= ich) + break; + if (ChrCmpIW(strCommon[ich], strBody[ich]) != 0) + { + strCommon = strCommon.Left(ich); + break; + } + } continue; } - for (INT ich = 0; ich < strCommon.GetLength(); ++ich) + if (::StrCmpNIW(strItem, strText, strText.GetLength()) == 0) { - if (ich < strItem.GetLength() && - ::ChrCmpIW(strCommon[ich], strItem[ich]) != 0) + if (!bFound) { - strCommon = strCommon.Left(ich); // shrink the common string - break; + bFound = TRUE; + strCommon = strItem; + continue; + } + + for (INT ich = 0; ich < strItem.GetLength(); ++ich) + { + if (strCommon.GetLength() <= ich) + break; + if (ChrCmpIW(strCommon[ich], strItem[ich]) != 0) + { + strCommon = strCommon.Left(ich); + break; + } } } } @@ -842,13 +832,10 @@ VOID CAutoComplete::DoAutoAppend() return; // no suggestion // append suggestion - INT cchOld = strText.GetLength(); - INT cchAppend = strCommon.GetLength() - cchOld; - strText += strCommon.Right(cchAppend); - SetEditText(strText); + SetEditText(strCommon); // select the appended suggestion - SetEditSel(cchOld, strText.GetLength()); + SetEditSel(strText.GetLength(), strCommon.GetLength()); } // go back a word ([Ctrl]+[Backspace]) @@ -856,8 +843,8 @@ VOID CAutoComplete::DoBackWord() { // get current selection INT ich0, ich1; - m_hwndEdit.SendMessageW(EM_GETSEL, reinterpret_cast<WPARAM>(&ich0), - reinterpret_cast<LPARAM>(&ich1)); + ::CallWindowProcW(m_fnOldEditProc, m_hwndEdit, EM_GETSEL, + reinterpret_cast<WPARAM>(&ich0), reinterpret_cast<LPARAM>(&ich1)); if (ich0 <= 0 || ich0 != ich1) // there is selection or left-side end return; // don't do anything // get text @@ -870,7 +857,7 @@ VOID CAutoComplete::DoBackWord() // select range SetEditSel(ich0, ich1); // replace selection with empty text (this is actually deletion) - m_hwndEdit.SendMessageW(EM_REPLACESEL, TRUE, (LPARAM)L""); + ::CallWindowProcW(m_fnOldEditProc, m_hwndEdit, EM_REPLACESEL, TRUE, (LPARAM)L""); } VOID CAutoComplete::UpdateScrollBar() @@ -940,7 +927,7 @@ BOOL CAutoComplete::OnEditKeyDown(WPARAM wParam, LPARAM lParam) } } // select all - INT cch = m_hwndEdit.GetWindowTextLengthW(); + INT cch = ::CallWindowProcW(m_fnOldEditProc, m_hwndEdit, WM_GETTEXTLENGTH, 0, 0); SetEditSel(0, cch); // hide HideDropDown(); @@ -963,7 +950,7 @@ BOOL CAutoComplete::OnEditKeyDown(WPARAM wParam, LPARAM lParam) // is suggestion available? if (!CanAutoSuggest()) return FALSE; // do default - m_hwndEdit.DefWindowProcW(WM_KEYDOWN, VK_DELETE, 0); // do default + ::DefSubclassProc(m_hwndEdit, WM_KEYDOWN, VK_DELETE, 0); // do default OnEditUpdate(FALSE); return TRUE; // eat } @@ -976,10 +963,6 @@ BOOL CAutoComplete::OnEditKeyDown(WPARAM wParam, LPARAM lParam) } break; } - default: - { - break; - } } return FALSE; // default } @@ -989,7 +972,7 @@ LRESULT CAutoComplete::OnEditChar(WPARAM wParam, LPARAM lParam) TRACE("CACEditCtrl::OnEditChar(%p, %p)\n", this, wParam); if (wParam == L'\n' || wParam == L'\t') return 0; // eat - LRESULT ret = m_hwndEdit.DefWindowProcW(WM_CHAR, wParam, lParam); // do default + LRESULT ret = ::DefSubclassProc(m_hwndEdit, WM_CHAR, wParam, lParam); // do default if (CanAutoSuggest() || CanAutoAppend()) OnEditUpdate(wParam != VK_BACK); return ret; @@ -997,7 +980,7 @@ LRESULT CAutoComplete::OnEditChar(WPARAM wParam, LPARAM lParam) VOID CAutoComplete::OnEditUpdate(BOOL bAppendOK) { - CString strText = GetEditText(); + CStringW strText = GetEditText(); if (m_strText.CompareNoCase(strText) == 0) { // no change @@ -1105,7 +1088,7 @@ BOOL CAutoComplete::OnListUpDown(UINT vk) // @implemented STDMETHODIMP CAutoComplete::Enable(BOOL fEnable) { - TRACE("(%p)->(%d)\n", this, fEnable); + TRACE("(%p)->Enable(%d)\n", this, fEnable); m_bEnabled = fEnable; return S_OK; } @@ -1114,37 +1097,42 @@ STDMETHODIMP CAutoComplete::Init(HWND hwndEdit, IUnknown *punkACL, LPCOLESTR pwszRegKeyPath, LPCOLESTR pwszQuickComplete) { - TRACE("(%p)->(0x%08lx, %p, %s, %s)\n", + TRACE("(%p)->Init(0x%08lx, %p, %s, %s)\n", this, hwndEdit, punkACL, debugstr_w(pwszRegKeyPath), debugstr_w(pwszQuickComplete)); - // sanity check if (m_hwndEdit || !punkACL) - { - ATLASSERT(0); return E_FAIL; - } - - // set this pointer to m_hwndEdit - m_hwndEdit.m_pDropDown = this; - + if (!hwndEdit) + return E_INVALIDARG; // do subclass textbox to watch messages - m_hwndEdit.SubclassWindow(hwndEdit); + m_fnOldEditProc = reinterpret_cast<WNDPROC>(::GetWindowLongPtrW(hwndEdit, GWLP_WNDPROC)); + if (!m_fnOldEditProc) + return E_FAIL; + if (!::SetWindowSubclass(hwndEdit, EditSubclassProc, 0, reinterpret_cast<DWORD_PTR>(this))) + return E_FAIL; + m_hwndEdit = hwndEdit; + // add reference to m_hwndEdit + AddRef(); // set word break procedure - m_hwndEdit.HookWordBreakProc(TRUE); + m_fnOldWordBreakProc = reinterpret_cast<EDITWORDBREAKPROCW>( + ::SendMessageW(m_hwndEdit, EM_SETWORDBREAKPROC, 0, + reinterpret_cast<LPARAM>(EditWordBreakProcW))); // save position - m_hwndEdit.GetWindowRect(&m_rcEdit); + ::GetWindowRect(m_hwndEdit, &m_rcEdit); // get an IEnumString ATLASSERT(!m_pEnum); punkACL->QueryInterface(IID_IEnumString, (VOID **)&m_pEnum); TRACE("m_pEnum: %p\n", static_cast<void *>(m_pEnum)); + if (m_pEnum) + m_pEnum->AddRef(); // hold not to be freed // get an IACList ATLASSERT(!m_pACList); punkACL->QueryInterface(IID_IACList, (VOID **)&m_pACList); TRACE("m_pACList: %p\n", static_cast<void *>(m_pACList)); - - AddRef(); // add reference + if (m_pACList) + m_pACList->AddRef(); // hold not to be freed UpdateDropDownState(); // create/hide the drop-down window if necessary @@ -1238,13 +1226,8 @@ STDMETHODIMP CAutoComplete::ResetEnumerator() { FIXME("(%p): stub\n", this); - HideDropDown(); - - if (IsWindowVisible()) - { - OnEditUpdate(FALSE); - } - + Reset(); + m_innerList.RemoveAll(); return S_OK; } @@ -1305,11 +1288,7 @@ VOID CAutoComplete::UpdateDropDownState() { // create the drop-down window if not existed if (!m_hWnd) - { - AddRef(); - if (!CreateDropDown()) - Release(); - } + CreateDropDown(); } else { @@ -1424,7 +1403,7 @@ VOID CAutoComplete::RepositionDropDown() // get m_hwndEdit position RECT rcEdit; - m_hwndEdit.GetWindowRect(&rcEdit); + ::GetWindowRect(m_hwndEdit, &rcEdit); INT x = rcEdit.left, y = rcEdit.bottom; // get list extent @@ -1572,6 +1551,15 @@ INT CAutoComplete::UpdateOuterList() { // is the beginning matched? const CStringW& strTarget = m_innerList[iItem]; + CStringW strBody; + if (DropPrefix(strTarget, strBody)) + { + if (::StrCmpNIW(strBody, strText, strText.GetLength()) == 0) + { + m_outerList.Add(strTarget); + continue; + } + } if (::StrCmpNIW(strTarget, strText, strText.GetLength()) == 0) { m_outerList.Add(strTarget); @@ -1614,13 +1602,11 @@ VOID CAutoComplete::UpdateCompletion(BOOL bAppendOK) RepositionDropDown(); else HideDropDown(); - return; } if (CanAutoAppend() && bAppendOK) // can we auto-append? { DoAutoAppend(); - return; } } @@ -1659,28 +1645,21 @@ LRESULT CAutoComplete::OnCreate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &b m_hFont = reinterpret_cast<HFONT>(::GetStockObject(DEFAULT_GUI_FONT)); m_hwndList.SetFont(m_hFont); + // add reference to CAutoComplete::m_hWnd + AddRef(); return 0; // success } -// WM_DESTROY -// This message is sent when a window is being destroyed. -LRESULT CAutoComplete::OnDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) +// WM_NCDESTROY +LRESULT CAutoComplete::OnNCDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) { - TRACE("CAutoComplete::OnDestroy(%p)\n", this); + TRACE("CAutoComplete::OnNCDestroy(%p)\n", this); // hide if (IsWindowVisible()) HideDropDown(); - // unsubclass EDIT control - if (m_hwndEdit) - { - m_hwndEdit.HookWordBreakProc(FALSE); - m_hwndEdit.UnsubclassWindow(); - } - // clear CAutoComplete pointers - m_hwndEdit.m_pDropDown = NULL; m_hwndList.m_pDropDown = NULL; m_hwndScrollBar.m_pDropDown = NULL; m_hwndSizeBox.m_pDropDown = NULL; @@ -1692,8 +1671,8 @@ LRESULT CAutoComplete::OnDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL & // clean up m_hwndCombo = NULL; + // remove reference to CAutoComplete::m_hWnd Release(); - return 0; } @@ -1709,7 +1688,7 @@ LRESULT CAutoComplete::OnExitSizeMove(UINT uMsg, WPARAM wParam, LPARAM lParam, B UINT uSWP_ = SWP_NOMOVE | SWP_NOSIZE | SWP_NOZORDER | SWP_FRAMECHANGED | SWP_NOACTIVATE; SetWindowPos(NULL, 0, 0, 0, 0, uSWP_); - m_hwndEdit.SetFocus(); // restore focus + ::SetFocus(m_hwndEdit); // restore focus return 0; } @@ -1943,8 +1922,6 @@ LRESULT CAutoComplete::OnNCHitTest(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL // This message is sent when the window size is changed. LRESULT CAutoComplete::OnSize(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled) { - TRACE("CAutoComplete::OnSize(%p)\n", this); - // calculate the positions of the controls CRect rcList, rcScrollBar, rcSizeBox; CalcRects(m_bDowner, rcList, rcScrollBar, rcSizeBox); @@ -1974,6 +1951,8 @@ LRESULT CAutoComplete::OnShowWindow(UINT uMsg, WPARAM wParam, LPARAM lParam, BOO BOOL bShow = (BOOL)wParam; if (bShow) { + if (s_hWatchWnd != m_hWnd && ::IsWindowVisible(s_hWatchWnd)) + ::ShowWindowAsync(s_hWatchWnd, SW_HIDE); s_hWatchWnd = m_hWnd; // watch this // unhook mouse if any @@ -2034,7 +2013,7 @@ LRESULT CAutoComplete::OnTimer(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bH // m_hwndEdit is moved? RECT rcEdit; - m_hwndEdit.GetWindowRect(&rcEdit); + ::GetWindowRect(m_hwndEdit, &rcEdit); if (!::EqualRect(&rcEdit, &m_rcEdit)) { // if so, hide diff --git a/dll/win32/browseui/CAutoComplete.h b/dll/win32/browseui/CAutoComplete.h index eb979baf314..f779fdaf4bf 100644 --- a/dll/win32/browseui/CAutoComplete.h +++ b/dll/win32/browseui/CAutoComplete.h @@ -24,53 +24,11 @@ #include "atltypes.h" #include "rosctrls.h" -class CACEditCtrl; class CACListView; class CACScrollBar; class CACSizeBox; class CAutoComplete; -////////////////////////////////////////////////////////////////////////////// -// CACEditCtrl --- auto-completion textbox - -class CACEditCtrl - : public CWindowImpl<CACEditCtrl, CWindow, CControlWinTraits> -{ -public: - CAutoComplete* m_pDropDown; - static LPCWSTR GetWndClassName() { return WC_EDITW; } - - CACEditCtrl(); - VOID HookWordBreakProc(BOOL bHook); - - // message map - BEGIN_MSG_MAP(CACEditCtrl) - MESSAGE_HANDLER(WM_CHAR, OnChar) - MESSAGE_HANDLER(WM_CLEAR, OnCutPasteClear) - MESSAGE_HANDLER(WM_CUT, OnCutPasteClear) - MESSAGE_HANDLER(WM_DESTROY, OnDestroy) - MESSAGE_HANDLER(WM_GETDLGCODE, OnGetDlgCode) - MESSAGE_HANDLER(WM_KEYDOWN, OnKeyDown) - MESSAGE_HANDLER(WM_KILLFOCUS, OnKillFocus) - MESSAGE_HANDLER(WM_PASTE, OnCutPasteClear) - MESSAGE_HANDLER(WM_SETFOCUS, OnSetFocus) - MESSAGE_HANDLER(WM_SETTEXT, OnSetText) - END_MSG_MAP() - -protected: - // protected variables - EDITWORDBREAKPROCW m_fnOldWordBreakProc; - // message handlers - LRESULT OnChar(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnCutPasteClear(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnGetDlgCode(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnKeyDown(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnKillFocus(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnSetFocus(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnSetText(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); -}; - ////////////////////////////////////////////////////////////////////////////// // CACListView --- auto-completion list control @@ -121,8 +79,7 @@ class CACScrollBar : public CWindowImpl<CACScrollBar> public: CAutoComplete* m_pDropDown; static LPCWSTR GetWndClassName() { return WC_SCROLLBARW; } - - CACScrollBar(); + CACScrollBar() : m_pDropDown(NULL) { } HWND Create(HWND hwndParent); protected: @@ -139,8 +96,7 @@ class CACSizeBox : public CWindowImpl<CACSizeBox> public: CAutoComplete* m_pDropDown; static LPCWSTR GetWndClassName() { return WC_SCROLLBARW; } - - CACSizeBox(); + CACSizeBox() : m_pDropDown(NULL), m_bDowner(TRUE), m_bLongList(FALSE) { } HWND Create(HWND hwndParent); VOID SetStatus(BOOL bDowner, BOOL bLongList); @@ -188,6 +144,7 @@ public: BOOL CanAutoAppend(); BOOL UseTab(); BOOL IsComboBoxDropped(); + BOOL FilterPrefixes(); INT GetItemCount(); CStringW GetItemText(INT iItem); @@ -203,6 +160,7 @@ public: VOID DoBackWord(); VOID UpdateScrollBar(); + LRESULT EditWndProc(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam); LRESULT OnEditChar(WPARAM wParam, LPARAM lParam); BOOL OnEditKeyDown(WPARAM wParam, LPARAM lParam); VOID OnEditUpdate(BOOL bAppendOK); @@ -234,11 +192,13 @@ protected: HFONT m_hFont; // the font BOOL m_bResized; // re-sized by size-box? RECT m_rcEdit; // in screen coordinates, to watch the position + HWND m_hwndEdit; // the textbox + WNDPROC m_fnOldEditProc; // old textbox procedure + EDITWORDBREAKPROCW m_fnOldWordBreakProc; // The following variables are non-POD: CStringW m_strText; // internal text (used in selecting item and reverting text) CStringW m_strStemText; // dirname + '\\' CStringW m_strQuickComplete; // used for [Ctrl]+[Enter] - CACEditCtrl m_hwndEdit; // subclassed to watch CACListView m_hwndList; // this listview is virtual CACScrollBar m_hwndScrollBar; // scroll bar contol CACSizeBox m_hwndSizeBox; // the size grip @@ -259,7 +219,7 @@ protected: // message map BEGIN_MSG_MAP(CAutoComplete) MESSAGE_HANDLER(WM_CREATE, OnCreate) - MESSAGE_HANDLER(WM_DESTROY, OnDestroy) + MESSAGE_HANDLER(WM_NCDESTROY, OnNCDestroy) MESSAGE_HANDLER(WM_DRAWITEM, OnDrawItem) MESSAGE_HANDLER(WM_EXITSIZEMOVE, OnExitSizeMove) MESSAGE_HANDLER(WM_GETMINMAXINFO, OnGetMinMaxInfo) @@ -276,7 +236,7 @@ protected: END_MSG_MAP() // message handlers LRESULT OnCreate(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); - LRESULT OnDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); + LRESULT OnNCDestroy(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); LRESULT OnDrawItem(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); LRESULT OnExitSizeMove(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled); LRESULT OnGetMinMaxInfo(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandled);

1 0

[reactos] 01/01: [WIDL] Do not transfer an explicit primitive binding handle to the server
by Eric Kohl 28 Mar '21

28 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6b04e463044c7f1f705e4… commit 6b04e463044c7f1f705e488c7b5bb0d3d4a02ae4 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sun Mar 28 16:20:10 2021 +0200 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sun Mar 28 16:20:10 2021 +0200 [WIDL] Do not transfer an explicit primitive binding handle to the server This enables us to run WIDL-generated code on Windows XP again. This patch has already been sent upstream. --- sdk/tools/widl/typegen.c | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/sdk/tools/widl/typegen.c b/sdk/tools/widl/typegen.c index baa2b189a0e..2aeb6ebca44 100644 --- a/sdk/tools/widl/typegen.c +++ b/sdk/tools/widl/typegen.c @@ -1321,7 +1321,9 @@ static void write_proc_func_header( FILE *file, int indent, const type_t *iface, } stack_size += get_stack_size( var, NULL ); param_num++; - nb_args++; + + if (var != handle_var || implicit_fc || explicit_fc != FC_BIND_PRIMITIVE) + nb_args++; } if (!is_void( type_function_get_rettype( func->type ))) { @@ -1428,6 +1430,8 @@ static void write_procformatstring_func( FILE *file, int indent, const type_t *i int is_interpreted = is_interpreted_func( iface, func ); int is_new_style = is_interpreted && (get_stub_mode() == MODE_Oif); var_t *retval = type_function_get_retval( func->type ); + unsigned char explicit_fc, implicit_fc; + const var_t *handle_var = get_func_handle_var( iface, func, &explicit_fc, &implicit_fc ); if (is_interpreted) write_proc_func_header( file, indent, iface, func, offset, num_proc ); @@ -1437,11 +1441,18 @@ static void write_procformatstring_func( FILE *file, int indent, const type_t *i const var_t *var; LIST_FOR_EACH_ENTRY( var, type_get_function_args(func->type), const var_t, entry ) { - print_file( file, 0, "/* %u (parameter %s) */\n", *offset, var->name ); - if (is_new_style) - *offset += write_new_procformatstring_type(file, indent, var, FALSE, &stack_offset); + if (var != handle_var || implicit_fc || explicit_fc != FC_BIND_PRIMITIVE) + { + print_file( file, 0, "/* %u (parameter %s) */\n", *offset, var->name ); + if (is_new_style) + *offset += write_new_procformatstring_type(file, indent, var, FALSE, &stack_offset); + else + *offset += write_old_procformatstring_type(file, indent, var, FALSE, is_interpreted); + } else - *offset += write_old_procformatstring_type(file, indent, var, FALSE, is_interpreted); + { + stack_offset += pointer_size; + } } }

1 0

[reactos] 01/01: [LIBCNTPR] Fix a typo
by Jérôme Gardou 25 Mar '21

25 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3a14c97d0c7004a0d72a1… commit 3a14c97d0c7004a0d72a1f7e0b0b418587d1b26d Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Thu Mar 25 11:52:22 2021 +0100 Commit: Jérôme Gardou <jerome.gardou(a)reactos.org> CommitDate: Thu Mar 25 11:54:49 2021 +0100 [LIBCNTPR] Fix a typo There is no console to display to. --- sdk/lib/crt/libcntpr.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/lib/crt/libcntpr.cmake b/sdk/lib/crt/libcntpr.cmake index e91db0896cc..2ffb192219d 100644 --- a/sdk/lib/crt/libcntpr.cmake +++ b/sdk/lib/crt/libcntpr.cmake @@ -12,7 +12,7 @@ list(APPEND LIBCNTPR_SOURCE misc/fltused.c printf/_snprintf.c printf/_snwprintf.c - printf/_vcprintf.c + printf/_vscprintf.c printf/_vscwprintf.c printf/_vsnprintf.c printf/_vsnwprintf.c

1 0

[reactos] 01/01: [ATL] CWindowImplBaseT::WindowProc(): Narrow 2 ATLASSERT() down (#3529)
by Serge Gautherie 25 Mar '21

25 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=49639c77599c9c7dbc742… commit 49639c77599c9c7dbc742846a5498f5f05348b50 Author: Serge Gautherie <32623169+SergeGautherie(a)users.noreply.github.com> AuthorDate: Thu Mar 25 11:51:29 2021 +0100 Commit: GitHub <noreply(a)github.com> CommitDate: Thu Mar 25 19:51:29 2021 +0900 [ATL] CWindowImplBaseT::WindowProc(): Narrow 2 ATLASSERT() down (#3529) Addendum to e076e05. CORE-17505 --- sdk/lib/atl/atlwin.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/sdk/lib/atl/atlwin.h b/sdk/lib/atl/atlwin.h index c25fd1404d0..214c2959789 100644 --- a/sdk/lib/atl/atlwin.h +++ b/sdk/lib/atl/atlwin.h @@ -1579,9 +1579,12 @@ public: LONG_PTR saveWindowProc; ATLASSERT(pThis != NULL); - ATLASSERT(pThis != NULL && (pThis->m_dwState & WINSTATE_DESTROYED) == 0); - ATLASSERT(pThis != NULL && pThis->m_hWnd != NULL); - if (pThis == NULL || (pThis->m_dwState & WINSTATE_DESTROYED) != 0 || pThis->m_hWnd == NULL) + if (pThis == NULL) + return 0; + + ATLASSERT((pThis->m_dwState & WINSTATE_DESTROYED) == 0); + ATLASSERT(pThis->m_hWnd != NULL); + if ((pThis->m_dwState & WINSTATE_DESTROYED) != 0 || pThis->m_hWnd == NULL) return 0; hWnd = pThis->m_hWnd;

1 0

[reactos] 04/04: [NTOS:SE] Specify the code section of SepCreateSystemProcessToken as INIT
by George Bișoc 24 Mar '21

24 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=eba68ffb9ccf0681e9f08… commit eba68ffb9ccf0681e9f08a3dbdccf6495b25c5f3 Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Sat Mar 13 20:45:15 2021 +0100 Commit: Victor Perevertkin <victor(a)perevertkin.ru> CommitDate: Thu Mar 25 02:30:46 2021 +0300 [NTOS:SE] Specify the code section of SepCreateSystemProcessToken as INIT This function is used during the Security kernel module phase initialisation to set up the system process token which the phase initialisation procedure in itself is stored in the INIT section. With that being said, do the same for SepCreateSystemProcessToken too and add a header documentation as an addition. --- ntoskrnl/se/token.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ntoskrnl/se/token.c b/ntoskrnl/se/token.c index bd56397225f..31601411b07 100644 --- a/ntoskrnl/se/token.c +++ b/ntoskrnl/se/token.c @@ -1389,6 +1389,15 @@ Quit: return Status; } +/** + * @brief + * Creates the system process token. + * + * @return + * Returns the system process token if the operations have + * completed successfully. + */ +CODE_SEG("INIT") PTOKEN NTAPI SepCreateSystemProcessToken(VOID)

1 0

[reactos] 03/04: [NTOS:SE] Create the anonymous logon tokens on Security initialisation phase
by George Bișoc 24 Mar '21

24 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5b5b814af8a9c5e5e7a54… commit 5b5b814af8a9c5e5e7a54b7a05baaf38bf8bb06f Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Sat Mar 13 20:32:18 2021 +0100 Commit: Victor Perevertkin <victor(a)perevertkin.ru> CommitDate: Thu Mar 25 02:30:46 2021 +0300 [NTOS:SE] Create the anonymous logon tokens on Security initialisation phase --- ntoskrnl/include/internal/se.h | 4 ++++ ntoskrnl/se/semgr.c | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/ntoskrnl/include/internal/se.h b/ntoskrnl/include/internal/se.h index 8f73dce719c..ed5989c7054 100644 --- a/ntoskrnl/include/internal/se.h +++ b/ntoskrnl/include/internal/se.h @@ -198,6 +198,10 @@ extern PSECURITY_DESCRIPTOR SeSystemDefaultSd; extern PSECURITY_DESCRIPTOR SeUnrestrictedSd; extern PSECURITY_DESCRIPTOR SeSystemAnonymousLogonSd; +/* Anonymous Logon Tokens */ +extern PTOKEN SeAnonymousLogonToken; +extern PTOKEN SeAnonymousLogonTokenNoEveryone; + #define SepAcquireTokenLockExclusive(Token) \ { \ diff --git a/ntoskrnl/se/semgr.c b/ntoskrnl/se/semgr.c index 56b9d5093be..4e217c8a982 100644 --- a/ntoskrnl/se/semgr.c +++ b/ntoskrnl/se/semgr.c @@ -15,6 +15,8 @@ /* GLOBALS ********************************************************************/ +PTOKEN SeAnonymousLogonToken = NULL; +PTOKEN SeAnonymousLogonTokenNoEveryone = NULL; PSE_EXPORTS SeExports = NULL; SE_EXPORTS SepExports; ULONG SidInTokenCalls = 0; @@ -122,6 +124,16 @@ SepInitializationPhase0(VOID) ObInitializeFastReference(&PsGetCurrentProcess()->Token, NULL); ObInitializeFastReference(&PsGetCurrentProcess()->Token, SepCreateSystemProcessToken()); + + /* Initialise the anonymous logon tokens */ + SeAnonymousLogonToken = SepCreateSystemAnonymousLogonToken(); + if (!SeAnonymousLogonToken) + return FALSE; + + SeAnonymousLogonTokenNoEveryone = SepCreateSystemAnonymousLogonTokenNoEveryone(); + if (!SeAnonymousLogonTokenNoEveryone) + return FALSE; + return TRUE; }

1 0

[reactos] 02/04: [NTOS:SE] Implement SepCreateSystemAnonymousLogonToken and SepCreateSystemAnonymousLogonTokenNoEveryone functions
by George Bișoc 24 Mar '21

24 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=fe0f9d8646083e367b402… commit fe0f9d8646083e367b402e6e709b39d6785af6b3 Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Sat Mar 13 20:11:58 2021 +0100 Commit: Victor Perevertkin <victor(a)perevertkin.ru> CommitDate: Thu Mar 25 02:30:46 2021 +0300 [NTOS:SE] Implement SepCreateSystemAnonymousLogonToken and SepCreateSystemAnonymousLogonTokenNoEveryone functions These private functions are needed to set up two different kinds of system's anonymous logon tokens: one that includes everyone in the group and the other that doesn't. These functions are needed as next step closer to the implementation of NtImpersonateAnonymousToken system call. --- ntoskrnl/include/internal/se.h | 6 ++ ntoskrnl/se/token.c | 140 +++++++++++++++++++++++++++++++++++++++-- 2 files changed, 140 insertions(+), 6 deletions(-) diff --git a/ntoskrnl/include/internal/se.h b/ntoskrnl/include/internal/se.h index cb812c2fbdc..8f73dce719c 100644 --- a/ntoskrnl/include/internal/se.h +++ b/ntoskrnl/include/internal/se.h @@ -335,6 +335,12 @@ PTOKEN NTAPI SepCreateSystemProcessToken(VOID); +PTOKEN +SepCreateSystemAnonymousLogonToken(VOID); + +PTOKEN +SepCreateSystemAnonymousLogonTokenNoEveryone(VOID); + BOOLEAN NTAPI SeDetailedAuditingWithToken(IN PTOKEN Token); diff --git a/ntoskrnl/se/token.c b/ntoskrnl/se/token.c index 872e5e15d0d..bd56397225f 100644 --- a/ntoskrnl/se/token.c +++ b/ntoskrnl/se/token.c @@ -1,10 +1,9 @@ /* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: ntoskrnl/se/token.c - * PURPOSE: Security manager - * - * PROGRAMMERS: David Welch <welch(a)cwcom.net> + * PROJECT: ReactOS Kernel + * LICENSE: GPL-2.0-or-later (https://spdx.org/licenses/GPL-2.0-or-later) + * PURPOSE: Security token implementation support + * COPYRIGHT: Copyright David Welch <welch(a)cwcom.net> + * Copyright 2021 George Bișoc <george.bisoc(a)reactos.org> */ /* INCLUDES *******************************************************************/ @@ -1530,6 +1529,135 @@ SepCreateSystemProcessToken(VOID) return Token; } +/** + * @brief + * Creates the anonymous logon token for the system. The difference between this + * token and the other one is the inclusion of everyone SID group (being SeWorldSid). + * The other token lacks such group. + * + * @return + * Returns the system's anonymous logon token if the operations have + * completed successfully. + */ +CODE_SEG("INIT") +PTOKEN +SepCreateSystemAnonymousLogonToken(VOID) +{ + SID_AND_ATTRIBUTES Groups[32], UserSid; + PSID PrimaryGroup; + PTOKEN Token; + ULONG GroupsLength; + LARGE_INTEGER Expiration; + OBJECT_ATTRIBUTES ObjectAttributes; + NTSTATUS Status; + + /* The token never expires */ + Expiration.QuadPart = -1; + + /* The user is the anonymous logon */ + UserSid.Sid = SeAnonymousLogonSid; + UserSid.Attributes = 0; + + /* The primary group is also the anonymous logon */ + PrimaryGroup = SeAnonymousLogonSid; + + /* The only group for the token is the World */ + Groups[0].Sid = SeWorldSid; + Groups[0].Attributes = SE_GROUP_ENABLED | SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT; + GroupsLength = sizeof(SID_AND_ATTRIBUTES) + + SeLengthSid(Groups[0].Sid); + ASSERT(GroupsLength <= sizeof(Groups)); + + /* Initialise the object attributes for the token */ + InitializeObjectAttributes(&ObjectAttributes, NULL, 0, NULL, NULL); + ASSERT(SeSystemAnonymousLogonDacl != NULL); + + /* Create token */ + Status = SepCreateToken((PHANDLE)&Token, + KernelMode, + 0, + &ObjectAttributes, + TokenPrimary, + SecurityAnonymous, + &SeAnonymousAuthenticationId, + &Expiration, + &UserSid, + 1, + Groups, + GroupsLength, + 0, + NULL, + NULL, + PrimaryGroup, + SeSystemAnonymousLogonDacl, + &SeSystemTokenSource, + TRUE); + ASSERT(Status == STATUS_SUCCESS); + + /* Return the anonymous logon token */ + return Token; +} + +/** + * @brief + * Creates the anonymous logon token for the system. This kind of token + * doesn't include the everyone SID group (being SeWorldSid). + * + * @return + * Returns the system's anonymous logon token if the operations have + * completed successfully. + */ +CODE_SEG("INIT") +PTOKEN +SepCreateSystemAnonymousLogonTokenNoEveryone(VOID) +{ + SID_AND_ATTRIBUTES UserSid; + PSID PrimaryGroup; + PTOKEN Token; + LARGE_INTEGER Expiration; + OBJECT_ATTRIBUTES ObjectAttributes; + NTSTATUS Status; + + /* The token never expires */ + Expiration.QuadPart = -1; + + /* The user is the anonymous logon */ + UserSid.Sid = SeAnonymousLogonSid; + UserSid.Attributes = 0; + + /* The primary group is also the anonymous logon */ + PrimaryGroup = SeAnonymousLogonSid; + + /* Initialise the object attributes for the token */ + InitializeObjectAttributes(&ObjectAttributes, NULL, 0, NULL, NULL); + ASSERT(SeSystemAnonymousLogonDacl != NULL); + + /* Create token */ + Status = SepCreateToken((PHANDLE)&Token, + KernelMode, + 0, + &ObjectAttributes, + TokenPrimary, + SecurityAnonymous, + &SeAnonymousAuthenticationId, + &Expiration, + &UserSid, + 0, + NULL, + 0, + 0, + NULL, + NULL, + PrimaryGroup, + SeSystemAnonymousLogonDacl, + &SeSystemTokenSource, + TRUE); + ASSERT(Status == STATUS_SUCCESS); + + /* Return the anonymous (not including everyone) logon token */ + return Token; +} + /* PUBLIC FUNCTIONS ***********************************************************/ /*

1 0

[reactos] 01/04: [NTOS:SE] Set up an ACL and SD for the anonymous logon
by George Bișoc 24 Mar '21

24 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b28530d4acf3e3909fa89… commit b28530d4acf3e3909fa89eda14f4945a941de0b3 Author: George Bișoc <george.bisoc(a)reactos.org> AuthorDate: Sat Mar 13 14:33:15 2021 +0100 Commit: Victor Perevertkin <victor(a)perevertkin.ru> CommitDate: Thu Mar 25 02:30:46 2021 +0300 [NTOS:SE] Set up an ACL and SD for the anonymous logon --- ntoskrnl/include/internal/se.h | 2 ++ ntoskrnl/se/acl.c | 26 ++++++++++++++++++++++++++ ntoskrnl/se/sd.c | 14 ++++++++++++++ 3 files changed, 42 insertions(+) diff --git a/ntoskrnl/include/internal/se.h b/ntoskrnl/include/internal/se.h index 56a1287d8bf..cb812c2fbdc 100644 --- a/ntoskrnl/include/internal/se.h +++ b/ntoskrnl/include/internal/se.h @@ -187,6 +187,7 @@ extern PACL SePublicDefaultUnrestrictedDacl; extern PACL SePublicOpenDacl; extern PACL SePublicOpenUnrestrictedDacl; extern PACL SeUnrestrictedDacl; +extern PACL SeSystemAnonymousLogonDacl; /* SDs */ extern PSECURITY_DESCRIPTOR SePublicDefaultSd; @@ -195,6 +196,7 @@ extern PSECURITY_DESCRIPTOR SePublicOpenSd; extern PSECURITY_DESCRIPTOR SePublicOpenUnrestrictedSd; extern PSECURITY_DESCRIPTOR SeSystemDefaultSd; extern PSECURITY_DESCRIPTOR SeUnrestrictedSd; +extern PSECURITY_DESCRIPTOR SeSystemAnonymousLogonSd; #define SepAcquireTokenLockExclusive(Token) \ diff --git a/ntoskrnl/se/acl.c b/ntoskrnl/se/acl.c index 25635610a16..1da423b43c2 100644 --- a/ntoskrnl/se/acl.c +++ b/ntoskrnl/se/acl.c @@ -21,6 +21,7 @@ PACL SePublicDefaultUnrestrictedDacl = NULL; PACL SePublicOpenDacl = NULL; PACL SePublicOpenUnrestrictedDacl = NULL; PACL SeUnrestrictedDacl = NULL; +PACL SeSystemAnonymousLogonDacl = NULL; /* FUNCTIONS ******************************************************************/ @@ -217,6 +218,31 @@ SepInitDACLs(VOID) GENERIC_READ | GENERIC_EXECUTE, SeRestrictedCodeSid); + /* create SystemAnonymousLogonDacl */ + AclLength = sizeof(ACL) + + (sizeof(ACE) + RtlLengthSid(SeWorldSid)) + + (sizeof(ACE) + RtlLengthSid(SeAnonymousLogonSid)); + + SeSystemAnonymousLogonDacl = ExAllocatePoolWithTag(PagedPool, + AclLength, + TAG_ACL); + if (SeSystemAnonymousLogonDacl == NULL) + return FALSE; + + RtlCreateAcl(SeSystemAnonymousLogonDacl, + AclLength, + ACL_REVISION); + + RtlAddAccessAllowedAce(SeSystemAnonymousLogonDacl, + ACL_REVISION, + GENERIC_ALL, + SeWorldSid); + + RtlAddAccessAllowedAce(SeSystemAnonymousLogonDacl, + ACL_REVISION, + GENERIC_ALL, + SeAnonymousLogonSid); + return TRUE; } diff --git a/ntoskrnl/se/sd.c b/ntoskrnl/se/sd.c index ccf17bb8388..dca0db419ff 100644 --- a/ntoskrnl/se/sd.c +++ b/ntoskrnl/se/sd.c @@ -21,6 +21,7 @@ PSECURITY_DESCRIPTOR SePublicOpenSd = NULL; PSECURITY_DESCRIPTOR SePublicOpenUnrestrictedSd = NULL; PSECURITY_DESCRIPTOR SeSystemDefaultSd = NULL; PSECURITY_DESCRIPTOR SeUnrestrictedSd = NULL; +PSECURITY_DESCRIPTOR SeSystemAnonymousLogonSd = NULL; /* PRIVATE FUNCTIONS **********************************************************/ @@ -107,6 +108,19 @@ SepInitSDs(VOID) SeUnrestrictedDacl, FALSE); + /* Create SystemAnonymousLogonSd */ + SeSystemAnonymousLogonSd = ExAllocatePoolWithTag(PagedPool, + sizeof(SECURITY_DESCRIPTOR), TAG_SD); + if (SeSystemAnonymousLogonSd == NULL) + return FALSE; + + RtlCreateSecurityDescriptor(SeSystemAnonymousLogonSd, + SECURITY_DESCRIPTOR_REVISION); + RtlSetDaclSecurityDescriptor(SeSystemAnonymousLogonSd, + TRUE, + SeSystemAnonymousLogonDacl, + FALSE); + return TRUE; }

1 0

[reactos] 01/01: [BROWSEUI] Support ACO_USETAB and SHACF_USETAB on auto-completion (#3549)
by Katayama Hirofumi MZ 24 Mar '21

24 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=d5c72a2e090edd4a11091… commit d5c72a2e090edd4a11091b8b46007490fbcb6c5a Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Thu Mar 25 07:42:24 2021 +0900 Commit: GitHub <noreply(a)github.com> CommitDate: Thu Mar 25 07:42:24 2021 +0900 [BROWSEUI] Support ACO_USETAB and SHACF_USETAB on auto-completion (#3549) Support Tab key on auto-completion. CORE-9281 --- dll/win32/browseui/CAutoComplete.cpp | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) diff --git a/dll/win32/browseui/CAutoComplete.cpp b/dll/win32/browseui/CAutoComplete.cpp index 8fe44e27977..b2ebc12ba68 100644 --- a/dll/win32/browseui/CAutoComplete.cpp +++ b/dll/win32/browseui/CAutoComplete.cpp @@ -26,7 +26,6 @@ TODO: - implement ACO_SEARCH style - implement ACO_FILTERPREFIXES style - - implement ACO_USETAB style - implement ACO_RTLREADING style */ @@ -321,7 +320,7 @@ LRESULT CACEditCtrl::OnGetDlgCode(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL break; case VK_TAB: if (m_pDropDown->IsWindowVisible() && m_pDropDown->UseTab()) - m_pDropDown->OnEditKeyDown(VK_TAB, 0); + ret |= DLGC_WANTALLKEYS; // we want all keys to manipulate the list break; case VK_ESCAPE: if (m_pDropDown->IsWindowVisible()) @@ -949,9 +948,13 @@ BOOL CAutoComplete::OnEditKeyDown(WPARAM wParam, LPARAM lParam) } case VK_TAB: { + // ACO_USETAB if (IsWindowVisible() && UseTab()) { - FIXME("ACO_USETAB\n"); + if (GetKeyState(VK_SHIFT) < 0) + return OnListUpDown(VK_UP); + else + return OnListUpDown(VK_DOWN); } break; } @@ -1114,21 +1117,6 @@ CAutoComplete::Init(HWND hwndEdit, IUnknown *punkACL, TRACE("(%p)->(0x%08lx, %p, %s, %s)\n", this, hwndEdit, punkACL, debugstr_w(pwszRegKeyPath), debugstr_w(pwszQuickComplete)); - if (m_dwOptions & ACO_AUTOSUGGEST) - TRACE(" ACO_AUTOSUGGEST\n"); - if (m_dwOptions & ACO_AUTOAPPEND) - TRACE(" ACO_AUTOAPPEND\n"); - if (m_dwOptions & ACO_SEARCH) - FIXME(" ACO_SEARCH not supported\n"); - if (m_dwOptions & ACO_FILTERPREFIXES) - FIXME(" ACO_FILTERPREFIXES not supported\n"); - if (m_dwOptions & ACO_USETAB) - FIXME(" ACO_USETAB not supported\n"); - if (m_dwOptions & ACO_UPDOWNKEYDROPSLIST) - TRACE(" ACO_UPDOWNKEYDROPSLIST\n"); - if (m_dwOptions & ACO_RTLREADING) - FIXME(" ACO_RTLREADING not supported\n"); - // sanity check if (m_hwndEdit || !punkACL) { @@ -1199,6 +1187,14 @@ STDMETHODIMP CAutoComplete::SetOptions(DWORD dwFlag) { TRACE("(%p) -> (0x%x)\n", this, dwFlag); m_dwOptions = dwFlag; + + if (m_dwOptions & ACO_SEARCH) + FIXME(" ACO_SEARCH not supported\n"); + if (m_dwOptions & ACO_FILTERPREFIXES) + FIXME(" ACO_FILTERPREFIXES not supported\n"); + if (m_dwOptions & ACO_RTLREADING) + FIXME(" ACO_RTLREADING not supported\n"); + UpdateDropDownState(); // create/hide the drop-down window if necessary return S_OK; }

1 0

[reactos] 02/02: [NTOS:CC] Wake up lazy scan after inserting elements in the list.
by Jérôme Gardou 24 Mar '21

24 Mar '21

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6e4f83da700fbfac5450d… commit 6e4f83da700fbfac5450dc9ef667585ddc870bc9 Author: Jérôme Gardou <jerome.gardou(a)reactos.org> AuthorDate: Tue Feb 16 17:17:57 2021 +0100 Commit: Jérôme Gardou <jerome.gardou(a)reactos.org> CommitDate: Wed Mar 24 15:28:04 2021 +0100 [NTOS:CC] Wake up lazy scan after inserting elements in the list. --- ntoskrnl/cc/copy.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/ntoskrnl/cc/copy.c b/ntoskrnl/cc/copy.c index 30864bc319e..09af125540c 100644 --- a/ntoskrnl/cc/copy.c +++ b/ntoskrnl/cc/copy.c @@ -381,16 +381,6 @@ CcCanIWrite ( return FALSE; } - /* Otherwise, if there are no deferred writes yet, start the lazy writer */ - if (IsListEmpty(&CcDeferredWrites)) - { - KIRQL OldIrql; - - OldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock); - CcScheduleLazyWriteScan(TRUE); - KeReleaseQueuedSpinLock(LockQueueMasterLock, OldIrql); - } - /* Initialize our wait event */ KeInitializeEvent(&WaitEvent, NotificationEvent, FALSE); @@ -418,6 +408,12 @@ CcCanIWrite ( &CcDeferredWriteSpinLock); } + /* Now make sure that the lazy scan writer will be active */ + OldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock); + if (!LazyWriter.ScanActive) + CcScheduleLazyWriteScan(TRUE); + KeReleaseQueuedSpinLock(LockQueueMasterLock, OldIrql); + #if DBG DPRINT1("Actively deferring write for: %p\n", FileObject); DPRINT1("Because:\n");

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs