Ros-diffs

ros-diffs@reactos.org

81390 discussions

[ion] 26251: - Add missing .rbuild files from last commit. - Move serial stack to /serial. - Move parallel stack to /parallel and make room for parport/parclass (NT5+ Parallel stack).
by ion＠svn.reactos.org 03 Apr '07

03 Apr '07

Author: ion Date: Tue Apr 3 18:22:00 2007 New Revision: 26251 URL: http://svn.reactos.org/svn/reactos?rev=26251&view=rev Log: - Add missing .rbuild files from last commit. - Move serial stack to /serial. - Move parallel stack to /parallel and make room for parport/parclass (NT5+ Parallel stack). Added: trunk/reactos/drivers/parallel/ trunk/reactos/drivers/parallel/directory.rbuild trunk/reactos/drivers/parallel/parallel/ - copied from r26249, trunk/reactos/drivers/base/parallel/ trunk/reactos/drivers/parallel/parclass/ trunk/reactos/drivers/parallel/parport/ trunk/reactos/drivers/serial/ trunk/reactos/drivers/serial/directory.rbuild trunk/reactos/drivers/serial/serenum/ - copied from r26249, trunk/reactos/drivers/bus/serenum/ trunk/reactos/drivers/serial/serial/ - copied from r26249, trunk/reactos/drivers/base/serial/ trunk/reactos/drivers/storage/class/directory.rbuild trunk/reactos/drivers/storage/ide/directory.rbuild trunk/reactos/drivers/storage/port/directory.rbuild Removed: trunk/reactos/drivers/base/parallel/ trunk/reactos/drivers/base/serial/ trunk/reactos/drivers/bus/serenum/ Modified: trunk/reactos/drivers/base/directory.rbuild trunk/reactos/drivers/bus/directory.rbuild trunk/reactos/drivers/drivers.rbuild Modified: trunk/reactos/drivers/base/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/directory.rbu… ============================================================================== --- trunk/reactos/drivers/base/directory.rbuild (original) +++ trunk/reactos/drivers/base/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -12,10 +12,4 @@ </directory> <directory name="null"> <xi:include href="null/null.rbuild" /> -</directory> -<directory name="parallel"> - <xi:include href="parallel/parallel.rbuild" /> -</directory> -<directory name="serial"> - <xi:include href="serial/serial.rbuild" /> -</directory> +</directory> Modified: trunk/reactos/drivers/bus/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/directory.rbui… ============================================================================== --- trunk/reactos/drivers/bus/directory.rbuild (original) +++ trunk/reactos/drivers/bus/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -7,6 +7,3 @@ <directory name="pci"> <xi:include href="pci/pci.rbuild" /> </directory> -<directory name="serenum"> - <xi:include href="serenum/serenum.rbuild" /> -</directory> Modified: trunk/reactos/drivers/drivers.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/drivers.rbuild?rev… ============================================================================== --- trunk/reactos/drivers/drivers.rbuild (original) +++ trunk/reactos/drivers/drivers.rbuild Tue Apr 3 18:22:00 2007 @@ -17,6 +17,12 @@ <directory name="network"> <xi:include href="network/directory.rbuild" /> </directory> +<directory name="parallel"> + <xi:include href="parallel/directory.rbuild" /> +</directory> +<directory name="serial"> + <xi:include href="serial/directory.rbuild" /> +</directory> <directory name="storage"> <xi:include href="storage/directory.rbuild" /> </directory> Added: trunk/reactos/drivers/parallel/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/parallel/directory… ============================================================================== --- trunk/reactos/drivers/parallel/directory.rbuild (added) +++ trunk/reactos/drivers/parallel/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -1,0 +1,3 @@ +<directory name="parallel"> + <xi:include href="parallel/parallel.rbuild" /> +</directory> Added: trunk/reactos/drivers/serial/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/serial/directory.r… ============================================================================== --- trunk/reactos/drivers/serial/directory.rbuild (added) +++ trunk/reactos/drivers/serial/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -1,0 +1,6 @@ +<directory name="serial"> + <xi:include href="serial/serial.rbuild" /> +</directory> +<directory name="serenum"> + <xi:include href="serenum/serenum.rbuild" /> +</directory> Added: trunk/reactos/drivers/storage/class/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class/dire… ============================================================================== --- trunk/reactos/drivers/storage/class/directory.rbuild (added) +++ trunk/reactos/drivers/storage/class/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -1,0 +1,9 @@ +<directory name="cdrom"> + <xi:include href="cdrom/cdrom.rbuild" /> +</directory> +<directory name="class2"> + <xi:include href="class2/class2.rbuild" /> +</directory> +<directory name="disk"> + <xi:include href="disk/disk.rbuild" /> +</directory> Added: trunk/reactos/drivers/storage/ide/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/direct… ============================================================================== --- trunk/reactos/drivers/storage/ide/directory.rbuild (added) +++ trunk/reactos/drivers/storage/ide/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -1,0 +1,9 @@ +<directory name="atapi"> + <xi:include href="atapi/atapi.rbuild" /> +</directory> +<directory name="pciide"> + <xi:include href="pciide/pciide.rbuild" /> +</directory> +<directory name="pciidex"> + <xi:include href="pciidex/pciidex.rbuild" /> +</directory> Added: trunk/reactos/drivers/storage/port/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/direc… ============================================================================== --- trunk/reactos/drivers/storage/port/directory.rbuild (added) +++ trunk/reactos/drivers/storage/port/directory.rbuild Tue Apr 3 18:22:00 2007 @@ -1,0 +1,6 @@ +<directory name="buslogic"> + <xi:include href="buslogic/buslogic.rbuild" /> +</directory> +<directory name="diskdump"> + <xi:include href="diskdump/diskdump.rbuild" /> +</directory>

1 0

[ion] 26250: - Cleanup /storage directory and prepare for NT5+ Storage Stack and Floppy Port/Class drop.
by ion＠svn.reactos.org 03 Apr '07

03 Apr '07

Author: ion Date: Tue Apr 3 18:14:25 2007 New Revision: 26250 URL: http://svn.reactos.org/svn/reactos?rev=26250&view=rev Log: - Cleanup /storage directory and prepare for NT5+ Storage Stack and Floppy Port/Class drop. Added: trunk/reactos/drivers/storage/class/ trunk/reactos/drivers/storage/class/cdrom/ - copied from r26249, trunk/reactos/drivers/storage/cdrom/ trunk/reactos/drivers/storage/class/class2/ - copied from r26249, trunk/reactos/drivers/storage/class2/ trunk/reactos/drivers/storage/class/disk/ - copied from r26249, trunk/reactos/drivers/storage/disk/ trunk/reactos/drivers/storage/class/include/ - copied from r26249, trunk/reactos/drivers/storage/include/ trunk/reactos/drivers/storage/classpnp/ trunk/reactos/drivers/storage/fdc/ trunk/reactos/drivers/storage/fdc/fdc/ trunk/reactos/drivers/storage/fdc/flpydisk/ trunk/reactos/drivers/storage/ide/ trunk/reactos/drivers/storage/ide/atapi/ - copied from r26249, trunk/reactos/drivers/storage/atapi/ trunk/reactos/drivers/storage/ide/pciide/ - copied from r26249, trunk/reactos/drivers/storage/pciide/ trunk/reactos/drivers/storage/ide/pciidex/ - copied from r26249, trunk/reactos/drivers/storage/pciidex/ trunk/reactos/drivers/storage/port/ trunk/reactos/drivers/storage/port/buslogic/ - copied from r26249, trunk/reactos/drivers/storage/buslogic/ trunk/reactos/drivers/storage/port/diskdump/ - copied from r26249, trunk/reactos/drivers/storage/diskdump/ Removed: trunk/reactos/drivers/storage/atapi/ trunk/reactos/drivers/storage/buslogic/ trunk/reactos/drivers/storage/cdrom/ trunk/reactos/drivers/storage/class2/ trunk/reactos/drivers/storage/disk/ trunk/reactos/drivers/storage/diskdump/ trunk/reactos/drivers/storage/include/ trunk/reactos/drivers/storage/pciide/ trunk/reactos/drivers/storage/pciidex/ trunk/reactos/drivers/test/ Modified: trunk/reactos/drivers/drivers.rbuild trunk/reactos/drivers/storage/directory.rbuild trunk/reactos/drivers/storage/port/diskdump/diskdump.c Modified: trunk/reactos/drivers/drivers.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/drivers.rbuild?rev… ============================================================================== --- trunk/reactos/drivers/drivers.rbuild (original) +++ trunk/reactos/drivers/drivers.rbuild Tue Apr 3 18:14:25 2007 @@ -20,9 +20,6 @@ <directory name="storage"> <xi:include href="storage/directory.rbuild" /> </directory> -<directory name="test"> - <xi:include href="test/directory.rbuild" /> -</directory> <directory name="usb"> <xi:include href="usb/directory.rbuild" /> </directory> Modified: trunk/reactos/drivers/storage/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/directory.… ============================================================================== --- trunk/reactos/drivers/storage/directory.rbuild (original) +++ trunk/reactos/drivers/storage/directory.rbuild Tue Apr 3 18:14:25 2007 @@ -1,30 +1,15 @@ -<directory name="atapi"> - <xi:include href="atapi/atapi.rbuild" /> -</directory> -<directory name="buslogic"> - <xi:include href="buslogic/buslogic.rbuild" /> -</directory> -<directory name="cdrom"> - <xi:include href="cdrom/cdrom.rbuild" /> -</directory> -<directory name="class2"> - <xi:include href="class2/class2.rbuild" /> -</directory> -<directory name="disk"> - <xi:include href="disk/disk.rbuild" /> +<directory name="class"> + <xi:include href="class/directory.rbuild" /> </directory> <directory name="floppy"> <xi:include href="floppy/floppy.rbuild" /> </directory> -<directory name="pciide"> - <xi:include href="pciide/pciide.rbuild" /> +<directory name="ide"> + <xi:include href="ide/directory.rbuild" /> </directory> -<directory name="pciidex"> - <xi:include href="pciidex/pciidex.rbuild" /> +<directory name="port"> + <xi:include href="port/directory.rbuild" /> </directory> <directory name="scsiport"> <xi:include href="scsiport/scsiport.rbuild" /> -</directory> -<directory name="diskdump"> - <xi:include href="diskdump/diskdump.rbuild" /> </directory> Modified: trunk/reactos/drivers/storage/port/diskdump/diskdump.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/port/diskd… ============================================================================== --- trunk/reactos/drivers/storage/port/diskdump/diskdump.c (original) +++ trunk/reactos/drivers/storage/port/diskdump/diskdump.c Tue Apr 3 18:14:25 2007 @@ -31,7 +31,7 @@ #include <scsi.h> #include <ntdddisk.h> #include <ntddscsi.h> -#include <include/class2.h> +#include <../class/include/class2.h> #include <diskdump/diskdump.h> #include <ndk/rtlfuncs.h>

1 0

[fireball] 26249: - Remove old unused code for sending sense requests. - Bugfix new sense request code (it was saving a pointer to the wrong SRB). - Implement requests, which bypass frozen queue. CdRom should now work properly. - Some very small code reformating.
by fireball＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: fireball Date: Tue Apr 3 00:24:54 2007 New Revision: 26249 URL: http://svn.reactos.org/svn/reactos?rev=26249&view=rev Log: - Remove old unused code for sending sense requests. - Bugfix new sense request code (it was saving a pointer to the wrong SRB). - Implement requests, which bypass frozen queue. CdRom should now work properly. - Some very small code reformating. Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/scsiport/s… ============================================================================== --- trunk/reactos/drivers/storage/scsiport/scsiport.c (original) +++ trunk/reactos/drivers/storage/scsiport/scsiport.c Tue Apr 3 00:24:54 2007 @@ -42,7 +42,7 @@ #include "scsiport_int.h" -ULONG InternalDebugLevel = 0; +ULONG InternalDebugLevel = 0x00; /* TYPES *********************************************************************/ @@ -117,15 +117,6 @@ static VOID STDCALL ScsiPortIoTimer(PDEVICE_OBJECT DeviceObject, PVOID Context); - -#if 0 -static PSCSI_REQUEST_BLOCK -ScsiPortInitSenseRequestSrb(PSCSI_PORT_DEVICE_EXTENSION DeviceExtension, - PSCSI_REQUEST_BLOCK OriginalSrb); - -static VOID -ScsiPortFreeSenseRequestSrb(PSCSI_PORT_DEVICE_EXTENSION DeviceExtension); -#endif static NTSTATUS SpiBuildDeviceMap (PSCSI_PORT_DEVICE_EXTENSION DeviceExtension, @@ -2174,16 +2165,14 @@ static NTSTATUS STDCALL ScsiPortCreateClose(IN PDEVICE_OBJECT DeviceObject, - IN PIRP Irp) + IN PIRP Irp) { - DPRINT("ScsiPortCreateClose()\n"); - - Irp->IoStatus.Status = STATUS_SUCCESS; - Irp->IoStatus.Information = FILE_OPENED; - - IoCompleteRequest(Irp, IO_NO_INCREMENT); - - return(STATUS_SUCCESS); + DPRINT("ScsiPortCreateClose()\n"); + + Irp->IoStatus.Status = STATUS_SUCCESS; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + + return STATUS_SUCCESS; } static NTSTATUS @@ -2824,8 +2813,68 @@ if (Srb->SrbFlags & SRB_FLAGS_BYPASS_FROZEN_QUEUE) { - /* TODO: Handle bypass-requests */ - ASSERT(FALSE); + /* Handle bypass-requests */ + + /* Is this an abort request? */ + if (Srb->Function == SRB_FUNCTION_ABORT_COMMAND) + { + PSCSI_REQUEST_BLOCK_INFO SrbInfo; + + /* Get pointer to SRB info structure */ + SrbInfo = SpiGetSrbData(DeviceExtension, + Srb->PathId, + Srb->TargetId, + Srb->Lun, + Srb->QueueTag); + + /* Check if the request is still "active" */ + if (SrbInfo == NULL || + SrbInfo->Srb == NULL || + !(SrbInfo->Srb->SrbFlags & SRB_FLAGS_IS_ACTIVE)) + { + /* It's not, mark it as active then */ + Srb->SrbFlags |= SRB_FLAGS_IS_ACTIVE; + + if (StartTimer) + LunExtension->RequestTimeout = -1; + + DPRINT("Request has been already completed, but abort request came\n"); + Srb->SrbStatus = SRB_STATUS_ABORT_FAILED; + + /* Notify about request complete */ + ScsiPortNotification(RequestComplete, + DeviceExtension->MiniPortDeviceExtension, + Srb); + + /* and about readiness for the next request */ + ScsiPortNotification(NextRequest, + DeviceExtension->MiniPortDeviceExtension); + + /* They might ask for some work, so queue the DPC for them */ + IoRequestDpc(DeviceExtension->DeviceObject, NULL, NULL); + + /* We're done in this branch */ + return TRUE; + } + } + else + { + /* Add number of queued requests */ + LunExtension->QueueCount++; + } + + /* Bypass requests don't need request sense */ + LunExtension->Flags &= ~LUNEX_NEED_REQUEST_SENSE; + + /* Is disconnect disabled for this request? */ + if (Srb->SrbFlags & SRB_FLAGS_DISABLE_DISCONNECT) + { + /* Set the corresponding flag */ + DeviceExtension->Flags &= ~SCSI_PORT_DISCONNECT_ALLOWED; + } + + /* Transfer timeout value from Srb to Lun */ + LunExtension->RequestTimeout = Srb->TimeOutValue; } else { @@ -3513,7 +3562,7 @@ LARGE_INTEGER LargeInt; PVOID *Ptr; - DPRINT("SpiSendRequestSense() entered\n"); + DPRINT("SpiSendRequestSense() entered, InitialSrb %p\n", InitialSrb); /* Allocate Srb */ Srb = ExAllocatePool(NonPagedPool, sizeof(SCSI_REQUEST_BLOCK) + sizeof(PVOID)); @@ -3546,7 +3595,7 @@ /* Save Srb */ Ptr = (PVOID *)(Srb+1); - *Ptr = Srb; + *Ptr = InitialSrb; /* Build CDB for REQUEST SENSE */ Srb->CdbLength = 6; @@ -4607,46 +4656,6 @@ /* Release the spinlock */ KeReleaseSpinLockFromDpcLevel(&DeviceExtension->SpinLock); } - -#if 0 -static PSCSI_REQUEST_BLOCK -ScsiPortInitSenseRequestSrb(PSCSI_PORT_DEVICE_EXTENSION DeviceExtension, - PSCSI_REQUEST_BLOCK OriginalSrb) -{ - PSCSI_REQUEST_BLOCK Srb; - PCDB Cdb; - - Srb = &DeviceExtension->InternalSrb; - - RtlZeroMemory(Srb, - sizeof(SCSI_REQUEST_BLOCK)); - - Srb->PathId = OriginalSrb->PathId; - Srb->TargetId = OriginalSrb->TargetId; - Srb->Function = SRB_FUNCTION_EXECUTE_SCSI; - Srb->Length = sizeof(SCSI_REQUEST_BLOCK); - Srb->SrbFlags = SRB_FLAGS_DATA_IN | SRB_FLAGS_DISABLE_SYNCH_TRANSFER; - - Srb->TimeOutValue = 4; - - Srb->CdbLength = 6; - Srb->DataBuffer = &DeviceExtension->InternalSenseData; - Srb->DataTransferLength = sizeof(SENSE_DATA); - - Cdb = (PCDB)Srb->Cdb; - Cdb->CDB6INQUIRY.OperationCode = SCSIOP_REQUEST_SENSE; - Cdb->CDB6INQUIRY.AllocationLength = sizeof(SENSE_DATA); - - return(Srb); -} - - -static VOID -ScsiPortFreeSenseRequestSrb(PSCSI_PORT_DEVICE_EXTENSION DeviceExtension) -{ - DeviceExtension->OriginalSrb = NULL; -} -#endif /********************************************************************** * NAME INTERNAL

1 0

[ion] 26248: - Revert 26244, 26245, 26246, 26247. - Stop committing on crack. - Read IRC logs and use your head. - GCC 3.4.5 is buggy, don't use. Don't break good code to hide compiler bugs.
by ion＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: ion Date: Mon Apr 2 19:08:54 2007 New Revision: 26248 URL: http://svn.reactos.org/svn/reactos?rev=26248&view=rev Log: - Revert 26244, 26245, 26246, 26247. - Stop committing on crack. - Read IRC logs and use your head. - GCC 3.4.5 is buggy, don't use. Don't break good code to hide compiler bugs. Modified: trunk/reactos/drivers/network/afd/afd/tdi.c trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c trunk/reactos/ntoskrnl/cm/ntfunc.c trunk/reactos/ntoskrnl/ex/sysinfo.c trunk/reactos/ntoskrnl/ex/timer.c trunk/reactos/ntoskrnl/fsrtl/fastio.c trunk/reactos/ntoskrnl/io/iomgr/driver.c trunk/reactos/ntoskrnl/io/iomgr/file.c trunk/reactos/ntoskrnl/io/iomgr/iofunc.c trunk/reactos/ntoskrnl/io/iomgr/irp.c trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c trunk/reactos/ntoskrnl/ke/i386/usercall.c trunk/reactos/ntoskrnl/ke/thrdobj.c trunk/reactos/ntoskrnl/mm/section.c trunk/reactos/ntoskrnl/mm/virtual.c trunk/reactos/ntoskrnl/ob/obdir.c trunk/reactos/ntoskrnl/ob/obhandle.c trunk/reactos/ntoskrnl/ob/obwait.c trunk/reactos/ntoskrnl/ps/job.c trunk/reactos/ntoskrnl/ps/query.c trunk/reactos/ntoskrnl/ps/thread.c trunk/reactos/ntoskrnl/se/acl.c trunk/reactos/ntoskrnl/se/priv.c trunk/reactos/ntoskrnl/se/sd.c trunk/reactos/ntoskrnl/se/sid.c trunk/reactos/ntoskrnl/se/token.c trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c trunk/reactos/subsystems/win32/win32k/ntuser/class.c trunk/reactos/subsystems/win32/win32k/objects/brush.c trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c trunk/reactos/subsystems/win32/win32k/objects/coord.c trunk/reactos/subsystems/win32/win32k/objects/dc.c trunk/reactos/subsystems/win32/win32k/objects/dibobj.c trunk/reactos/subsystems/win32/win32k/objects/fillshap.c trunk/reactos/subsystems/win32/win32k/objects/line.c trunk/reactos/subsystems/win32/win32k/objects/print.c trunk/reactos/subsystems/win32/win32k/objects/rect.c trunk/reactos/subsystems/win32/win32k/objects/region.c Modified: trunk/reactos/drivers/network/afd/afd/tdi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/td… ============================================================================== --- trunk/reactos/drivers/network/afd/afd/tdi.c (original) +++ trunk/reactos/drivers/network/afd/afd/tdi.c Mon Apr 2 19:08:54 2007 @@ -766,9 +766,9 @@ PIO_COMPLETION_ROUTINE CompletionRoutine, PVOID CompletionContext ) { - PDEVICE_OBJECT DeviceObject = NULL; + PDEVICE_OBJECT DeviceObject; NTSTATUS Status = STATUS_SUCCESS; - PMDL Mdl = NULL; + PMDL Mdl; DeviceObject = IoGetRelatedDeviceObject(TransportObject); if (!DeviceObject) { @@ -843,8 +843,8 @@ PVOID CompletionContext) { NTSTATUS Status = STATUS_SUCCESS; - PDEVICE_OBJECT DeviceObject = NULL; - PMDL Mdl = NULL; + PDEVICE_OBJECT DeviceObject; + PMDL Mdl; DeviceObject = IoGetRelatedDeviceObject(TransportObject); if (!DeviceObject) { Modified: trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi… ============================================================================== --- trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c (original) +++ trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c Mon Apr 2 19:08:54 2007 @@ -1265,9 +1265,9 @@ * Status of operation */ { - PTCP_REQUEST_QUERY_INFORMATION_EX InputBuffer = NULL; + PTCP_REQUEST_QUERY_INFORMATION_EX InputBuffer; PTRANSPORT_CONTEXT TranContext; - PTI_QUERY_CONTEXT QueryContext = NULL; + PTI_QUERY_CONTEXT QueryContext; PVOID OutputBuffer; TDI_REQUEST Request; UINT Size; Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/ntfunc.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/cm/ntfunc.c (original) +++ trunk/reactos/ntoskrnl/cm/ntfunc.c Mon Apr 2 19:08:54 2007 @@ -299,7 +299,7 @@ unsigned i; REG_PRE_CREATE_KEY_INFORMATION PreCreateKeyInfo; REG_POST_CREATE_KEY_INFORMATION PostCreateKeyInfo; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; UNICODE_STRING CapturedClass = {0}; HANDLE hKey; @@ -1308,7 +1308,7 @@ IN POBJECT_ATTRIBUTES ObjectAttributes) { UNICODE_STRING RemainingPath; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; PVOID Object = NULL; HANDLE hKey = NULL; NTSTATUS Status = STATUS_SUCCESS; @@ -2145,7 +2145,7 @@ NTSTATUS Status; REG_DELETE_VALUE_KEY_INFORMATION DeleteValueKeyInfo; REG_POST_OPERATION_INFORMATION PostOperationInfo; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; UNICODE_STRING CapturedValueName; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/sysinfo.c (original) +++ trunk/reactos/ntoskrnl/ex/sysinfo.c Mon Apr 2 19:08:54 2007 @@ -232,10 +232,10 @@ ANSI_STRING AName; UNICODE_STRING WName; BOOLEAN Result; - PCH Value = NULL; + PCH Value; ANSI_STRING AValue; UNICODE_STRING WValue; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -378,7 +378,7 @@ { UNICODE_STRING CapturedName, CapturedValue; ANSI_STRING AName, AValue; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; NTSTATUS Status; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/ex/timer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/timer.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/ex/timer.c (original) +++ trunk/reactos/ntoskrnl/ex/timer.c Mon Apr 2 19:08:54 2007 @@ -510,7 +510,7 @@ { PETIMER Timer; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); - NTSTATUS Status = STATUS_UNSUCCESSFUL; + NTSTATUS Status; PTIMER_BASIC_INFORMATION BasicInfo = TimerInformation; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/fastio.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/fastio.c (original) +++ trunk/reactos/ntoskrnl/fsrtl/fastio.c Mon Apr 2 19:08:54 2007 @@ -83,7 +83,7 @@ IN PDEVICE_OBJECT DeviceObject) { - PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; + PFSRTL_COMMON_FCB_HEADER FcbHeader; LARGE_INTEGER Offset; PFAST_IO_DISPATCH FastIoDispatch; PDEVICE_OBJECT Device; @@ -258,7 +258,7 @@ BOOLEAN Result = TRUE; PFAST_IO_DISPATCH FastIoDispatch; PDEVICE_OBJECT Device; - PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; + PFSRTL_COMMON_FCB_HEADER FcbHeader; /* WDK doc. Offset=0xffffffffffffffff indicates append to the end of file */ BOOLEAN FileOffsetAppend = ((FileOffset->HighPart == 0xffffffff) && (FileOffset->LowPart == 0xffffffff)); @@ -915,7 +915,7 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; + PFSRTL_COMMON_FCB_HEADER FcbHeader; BOOLEAN Result = TRUE; LARGE_INTEGER Offset; PFAST_IO_DISPATCH FastIoDispatch; @@ -1159,7 +1159,7 @@ BOOLEAN Result = TRUE; PFAST_IO_DISPATCH FastIoDispatch; PDEVICE_OBJECT Device; - PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; + PFSRTL_COMMON_FCB_HEADER FcbHeader; LARGE_INTEGER OldFileSize; LARGE_INTEGER OldValidDataLength; Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Mon Apr 2 19:08:54 2007 @@ -1475,7 +1475,7 @@ UNICODE_STRING ImagePath; UNICODE_STRING ServiceName; UNICODE_STRING CapturedDriverServiceName = {0}; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; NTSTATUS Status; ULONG Type; PDEVICE_NODE DeviceNode; Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/file.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/file.c Mon Apr 2 19:08:54 2007 @@ -1629,7 +1629,7 @@ IN PVOID ExtraCreateParameters OPTIONAL, IN ULONG Options) { - KPROCESSOR_MODE AccessMode = {0}; + KPROCESSOR_MODE AccessMode; HANDLE LocalHandle = 0; LARGE_INTEGER SafeAllocationSize; PVOID SystemEaBuffer = NULL; Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Mon Apr 2 19:08:54 2007 @@ -198,12 +198,12 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_OBJECT FileObject; - PDEVICE_OBJECT DeviceObject = NULL; - PIRP Irp = NULL; + PDEVICE_OBJECT DeviceObject; + PIRP Irp; PIO_STACK_LOCATION StackPtr; PKEVENT EventObject = NULL; BOOLEAN LockedForSynch = FALSE; - ULONG AccessType = 0; + ULONG AccessType; OBJECT_HANDLE_INFORMATION HandleInformation; ACCESS_MASK DesiredAccess; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); @@ -1212,9 +1212,9 @@ { PFILE_OBJECT FileObject; PLARGE_INTEGER LocalLength = NULL; - PIRP Irp = NULL; - PIO_STACK_LOCATION StackPtr = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PIO_STACK_LOCATION StackPtr; + PDEVICE_OBJECT DeviceObject; PKEVENT Event = NULL; BOOLEAN LockedForSync = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); @@ -1386,8 +1386,8 @@ IN PUNICODE_STRING FileName OPTIONAL, IN BOOLEAN RestartScan) { - PIRP Irp = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PDEVICE_OBJECT DeviceObject; PFILE_OBJECT FileObject; PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); @@ -1627,9 +1627,9 @@ OBJECT_HANDLE_INFORMATION HandleInformation; PFILE_OBJECT FileObject; NTSTATUS Status = STATUS_SUCCESS; - PIRP Irp = NULL; - PDEVICE_OBJECT DeviceObject = NULL; - PIO_STACK_LOCATION StackPtr = NULL; + PIRP Irp; + PDEVICE_OBJECT DeviceObject; + PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; @@ -1938,8 +1938,8 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_OBJECT FileObject; - PIRP Irp = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PDEVICE_OBJECT DeviceObject; PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); PKEVENT EventObject = NULL; @@ -2197,9 +2197,9 @@ { PFILE_OBJECT FileObject; NTSTATUS Status = STATUS_SUCCESS; - PIRP Irp = NULL; - PDEVICE_OBJECT DeviceObject = NULL; - PIO_STACK_LOCATION StackPtr = NULL; + PIRP Irp; + PDEVICE_OBJECT DeviceObject; + PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; @@ -2576,9 +2576,9 @@ { PFILE_OBJECT FileObject; PLARGE_INTEGER LocalLength = NULL; - PIRP Irp = NULL; - PIO_STACK_LOCATION StackPtr = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PIO_STACK_LOCATION StackPtr; + PDEVICE_OBJECT DeviceObject; PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); @@ -2760,8 +2760,8 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_OBJECT FileObject; - PIRP Irp = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PDEVICE_OBJECT DeviceObject; PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); PKEVENT EventObject = NULL; @@ -3027,9 +3027,9 @@ IN FS_INFORMATION_CLASS FsInformationClass) { PFILE_OBJECT FileObject; - PIRP Irp = NULL; - PIO_STACK_LOCATION StackPtr = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PIO_STACK_LOCATION StackPtr; + PDEVICE_OBJECT DeviceObject; PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); @@ -3190,9 +3190,9 @@ IN FS_INFORMATION_CLASS FsInformationClass) { PFILE_OBJECT FileObject; - PIRP Irp = NULL; - PIO_STACK_LOCATION StackPtr = NULL; - PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp; + PIO_STACK_LOCATION StackPtr; + PDEVICE_OBJECT DeviceObject; PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); Modified: trunk/reactos/ntoskrnl/io/iomgr/irp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irp.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/irp.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/irp.c Mon Apr 2 19:08:54 2007 @@ -610,8 +610,8 @@ IN PLARGE_INTEGER StartingOffset, IN PIO_STATUS_BLOCK IoStatusBlock) { - PIRP Irp = NULL; - PIO_STACK_LOCATION StackPtr = NULL; + PIRP Irp; + PIO_STACK_LOCATION StackPtr; /* Allocate IRP */ Irp = IoAllocateIrp(DeviceObject->StackSize, FALSE); @@ -745,7 +745,7 @@ IN PKEVENT Event, IN PIO_STATUS_BLOCK IoStatusBlock) { - PIRP Irp = NULL; + PIRP Irp; PIO_STACK_LOCATION StackPtr; ULONG BufferLength; Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugpla… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c Mon Apr 2 19:08:54 2007 @@ -443,7 +443,7 @@ UNICODE_STRING DeviceInstance; ULONG BufferSize; ULONG Property = 0; - PVOID Buffer = NULL; + PVOID Buffer; DPRINT("IopGetDeviceProperty() called\n"); DPRINT("Device name: %wZ\n", &PropertyData->DeviceInstance); Modified: trunk/reactos/ntoskrnl/ke/i386/usercall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/usercall.… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/usercall.c (original) +++ trunk/reactos/ntoskrnl/ke/i386/usercall.c Mon Apr 2 19:08:54 2007 @@ -148,8 +148,8 @@ OUT PVOID *Result, OUT PULONG ResultLength) { - ULONG_PTR NewStack =0, OldStack = 0; - PULONG UserEsp = NULL; + ULONG_PTR NewStack, OldStack; + PULONG UserEsp; NTSTATUS CallbackStatus = STATUS_SUCCESS; PEXCEPTION_REGISTRATION_RECORD ExceptionList; PTEB Teb; Modified: trunk/reactos/ntoskrnl/ke/thrdobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/thrdobj.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ke/thrdobj.c (original) +++ trunk/reactos/ntoskrnl/ke/thrdobj.c Mon Apr 2 19:08:54 2007 @@ -723,7 +723,7 @@ ULONG i; PKWAIT_BLOCK TimerWaitBlock; PKTIMER Timer; - NTSTATUS Status = STATUS_UNSUCCESSFUL; + NTSTATUS Status; /* Initalize the Dispatcher Header */ KeInitializeDispatcherHeader(&Thread->DispatcherHeader, Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c (original) +++ trunk/reactos/ntoskrnl/mm/section.c Mon Apr 2 19:08:54 2007 @@ -3670,7 +3670,7 @@ SIZE_T SafeViewSize; PROS_SECTION_OBJECT Section; PEPROCESS Process; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; PMADDRESS_SPACE AddressSpace; NTSTATUS Status = STATUS_SUCCESS; ULONG tmpProtect; Modified: trunk/reactos/ntoskrnl/mm/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/virtual.c (original) +++ trunk/reactos/ntoskrnl/mm/virtual.c Mon Apr 2 19:08:54 2007 @@ -554,10 +554,10 @@ IN ULONG NumberOfBytesToRead, OUT PULONG NumberOfBytesRead OPTIONAL) { - PMDL Mdl = NULL; + PMDL Mdl; PVOID SystemAddress; - KPROCESSOR_MODE PreviousMode = {0}; - PEPROCESS Process, CurrentProcess = NULL; + KPROCESSOR_MODE PreviousMode; + PEPROCESS Process, CurrentProcess; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -769,11 +769,11 @@ IN ULONG NumberOfBytesToWrite, OUT PULONG NumberOfBytesWritten OPTIONAL) { - PMDL Mdl = NULL; - PVOID SystemAddress = NULL; + PMDL Mdl; + PVOID SystemAddress; PEPROCESS Process; - KPROCESSOR_MODE PreviousMode = {0}; - NTSTATUS CopyStatus = STATUS_SUCCESS, Status = STATUS_SUCCESS; + KPROCESSOR_MODE PreviousMode; + NTSTATUS CopyStatus, Status = STATUS_SUCCESS; DPRINT("NtWriteVirtualMemory(ProcessHandle %x, BaseAddress %x, " "Buffer %x, NumberOfBytesToWrite %d)\n",ProcessHandle,BaseAddress, Modified: trunk/reactos/ntoskrnl/ob/obdir.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obdir.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obdir.c (original) +++ trunk/reactos/ntoskrnl/ob/obdir.c Mon Apr 2 19:08:54 2007 @@ -466,7 +466,7 @@ KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); ULONG SkipEntries = 0; NTSTATUS Status = STATUS_SUCCESS; - PVOID LocalBuffer = NULL; + PVOID LocalBuffer; POBJECT_DIRECTORY_INFORMATION DirectoryInfo; ULONG Length, TotalLength; ULONG Count, CurrentEntry; Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obhandle.c (original) +++ trunk/reactos/ntoskrnl/ob/obhandle.c Mon Apr 2 19:08:54 2007 @@ -3150,7 +3150,7 @@ IN ULONG HandleAttributes, IN ULONG Options) { - PEPROCESS SourceProcess, TargetProcess, Target = NULL; + PEPROCESS SourceProcess, TargetProcess, Target; HANDLE hTarget; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/ob/obwait.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obwait.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obwait.c (original) +++ trunk/reactos/ntoskrnl/ob/obwait.c Mon Apr 2 19:08:54 2007 @@ -56,7 +56,7 @@ ULONG i = 0, ReferencedObjects = 0, j; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); LARGE_INTEGER SafeTimeOut; - BOOLEAN LockInUse = FALSE; + BOOLEAN LockInUse; PHANDLE_TABLE_ENTRY HandleEntry; POBJECT_HEADER ObjectHeader; PHANDLE_TABLE HandleTable; @@ -457,7 +457,7 @@ { KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); POBJECT_TYPE Type; - PVOID SignalObj, WaitObj, WaitableObject = NULL; + PVOID SignalObj, WaitObj, WaitableObject; LARGE_INTEGER SafeTimeOut; OBJECT_HANDLE_INFORMATION HandleInfo; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/ps/job.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/job.c?rev=2624… ============================================================================== --- trunk/reactos/ntoskrnl/ps/job.c (original) +++ trunk/reactos/ntoskrnl/ps/job.c Mon Apr 2 19:08:54 2007 @@ -225,8 +225,8 @@ { HANDLE hJob; PEJOB Job; - KPROCESSOR_MODE PreviousMode = {0}; - PEPROCESS CurrentProcess = NULL; + KPROCESSOR_MODE PreviousMode; + PEPROCESS CurrentProcess; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -396,7 +396,7 @@ ACCESS_MASK DesiredAccess, POBJECT_ATTRIBUTES ObjectAttributes) { - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; HANDLE hJob; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/ps/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/ps/query.c (original) +++ trunk/reactos/ntoskrnl/ps/query.c Mon Apr 2 19:08:54 2007 @@ -484,7 +484,7 @@ PEPROCESS Process; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); ACCESS_MASK Access; - NTSTATUS Status = STATUS_NOT_IMPLEMENTED; + NTSTATUS Status; HANDLE PortHandle = NULL; HANDLE TokenHandle = NULL; PROCESS_SESSION_INFORMATION SessionInfo = {0}; @@ -719,7 +719,7 @@ PETHREAD Thread; ULONG Access; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); - NTSTATUS Status = STATUS_INVALID_PARAMETER; + NTSTATUS Status; HANDLE TokenHandle = NULL; KPRIORITY Priority = 0; KAFFINITY Affinity = 0, CombinedAffinity; Modified: trunk/reactos/ntoskrnl/ps/thread.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/thread.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/ps/thread.c (original) +++ trunk/reactos/ntoskrnl/ps/thread.c Mon Apr 2 19:08:54 2007 @@ -141,7 +141,7 @@ PspSystemThreadStartup(IN PKSTART_ROUTINE StartRoutine, IN PVOID StartContext) { - PETHREAD Thread = NULL; + PETHREAD Thread; PSTRACE(PS_THREAD_DEBUG, "StartRoutine: %p StartContext: %p\n", StartRoutine, StartContext); Modified: trunk/reactos/ntoskrnl/se/acl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/acl.c?rev=2624… ============================================================================== --- trunk/reactos/ntoskrnl/se/acl.c (original) +++ trunk/reactos/ntoskrnl/se/acl.c Mon Apr 2 19:08:54 2007 @@ -275,7 +275,7 @@ IN BOOLEAN CaptureIfKernel, OUT PACL *CapturedAcl) { - PACL NewAcl = NULL; + PACL NewAcl; ULONG AclSize = 0; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/se/priv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/priv.c?rev=262… ============================================================================== --- trunk/reactos/ntoskrnl/se/priv.c (original) +++ trunk/reactos/ntoskrnl/se/priv.c Mon Apr 2 19:08:54 2007 @@ -184,7 +184,7 @@ PLUID_AND_ATTRIBUTES* Dest, PULONG Length) { - ULONG BufferSize = 0; + ULONG BufferSize; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -300,7 +300,7 @@ ULONG PrivilegeControl = 0; ULONG Length; BOOLEAN CheckResult; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/se/sd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sd.c?rev=26248… ============================================================================== --- trunk/reactos/ntoskrnl/se/sd.c (original) +++ trunk/reactos/ntoskrnl/se/sd.c Mon Apr 2 19:08:54 2007 @@ -394,7 +394,7 @@ { PISECURITY_DESCRIPTOR OriginalSecurityDescriptor = _OriginalSecurityDescriptor; SECURITY_DESCRIPTOR DescriptorCopy; - PISECURITY_DESCRIPTOR NewDescriptor = NULL; + PISECURITY_DESCRIPTOR NewDescriptor; ULONG OwnerSAC = 0, GroupSAC = 0; ULONG OwnerSize = 0, GroupSize = 0; ULONG SaclSize = 0, DaclSize = 0; Modified: trunk/reactos/ntoskrnl/se/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sid.c?rev=2624… ============================================================================== --- trunk/reactos/ntoskrnl/se/sid.c (original) +++ trunk/reactos/ntoskrnl/se/sid.c Mon Apr 2 19:08:54 2007 @@ -236,7 +236,7 @@ OUT PSID *CapturedSid) { ULONG SidSize = 0; - PISID NewSid = NULL, Sid = (PISID)InputSid; + PISID NewSid, Sid = (PISID)InputSid; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/se/token.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/token.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/se/token.c (original) +++ trunk/reactos/ntoskrnl/se/token.c Mon Apr 2 19:08:54 2007 @@ -669,8 +669,8 @@ ULONG Ulong; } Unused; PTOKEN Token; - ULONG RequiredLength = 0; - KPROCESSOR_MODE PreviousMode = {0}; + ULONG RequiredLength; + KPROCESSOR_MODE PreviousMode; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -1253,7 +1253,7 @@ IN ULONG TokenInformationLength) { PTOKEN Token; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; ULONG NeededAccess = TOKEN_ADJUST_DEFAULT; NTSTATUS Status = STATUS_SUCCESS; @@ -1496,7 +1496,7 @@ IN TOKEN_TYPE TokenType, OUT PHANDLE NewTokenHandle) { - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; HANDLE hToken; PTOKEN Token; PTOKEN NewToken; @@ -2134,7 +2134,7 @@ PVOID EndMem; ULONG uLength; ULONG i; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; ULONG nTokenPrivileges = 0; LARGE_INTEGER LocalExpirationTime = {{0}}; NTSTATUS Status = STATUS_SUCCESS; @@ -2464,7 +2464,7 @@ OBJECT_ATTRIBUTES ObjectAttributes; SECURITY_DESCRIPTOR SecurityDescriptor; PACL Dacl = NULL; - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -2661,7 +2661,7 @@ IN HANDLE SecondTokenHandle, OUT PBOOLEAN Equal) { - KPROCESSOR_MODE PreviousMode = {0}; + KPROCESSOR_MODE PreviousMode; PTOKEN FirstToken, SecondToken; BOOLEAN IsEqual; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c Mon Apr 2 19:08:54 2007 @@ -40,11 +40,11 @@ HANDLE *puhSurface ) { - INT i = 0; + INT i; DWORD ddRVal = DDHAL_DRIVER_NOTHANDLED; NTSTATUS Status = FALSE; - PDD_DIRECTDRAW pDirectDraw = NULL; - PDD_SURFACE phsurface = NULL; + PDD_DIRECTDRAW pDirectDraw; + PDD_SURFACE phsurface; PDD_SURFACE_LOCAL pLocal; PDD_SURFACE_MORE pMore; @@ -53,7 +53,7 @@ DD_CREATESURFACEDATA CreateSurfaceData; /* FIXME alloc so mayne we need */ - PHANDLE *myhSurface = NULL; + PHANDLE *myhSurface; /* GCC4 warnns on value are unisitaed, but they are initated in seh @@ -508,7 +508,7 @@ { DWORD ddRVal = DDHAL_DRIVER_NOTHANDLED; DD_GETSCANLINEDATA GetScanLineData; - PDD_DIRECTDRAW pDirectDraw = NULL; + PDD_DIRECTDRAW pDirectDraw; NTSTATUS Status = FALSE; DPRINT1("NtGdiDdGetScanLine\n"); Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c Mon Apr 2 19:08:54 2007 @@ -292,7 +292,7 @@ DWORD *puFourCC ) { - PDD_DIRECTDRAW pDirectDraw = NULL; + PDD_DIRECTDRAW pDirectDraw; NTSTATUS Status = FALSE; BOOL Ret=FALSE; @@ -549,7 +549,7 @@ { BOOL Ret=FALSE; NTSTATUS Status = FALSE; - PDD_DIRECTDRAW pDirectDraw = NULL; + PDD_DIRECTDRAW pDirectDraw; if (hDirectDrawLocal == NULL) { Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Mon Apr 2 19:08:54 2007 @@ -1137,7 +1137,7 @@ IN DWORD dwFlags) { PW32THREADINFO ti; - PW32PROCESSINFO pi = NULL; + PW32PROCESSINFO pi; PWINDOWCLASS Class; RTL_ATOM ClassAtom; RTL_ATOM Ret = (RTL_ATOM)0; @@ -1484,7 +1484,7 @@ if (MenuName->Length != 0) { ANSI_STRING AnsiString; - PWSTR strBufW = NULL; + PWSTR strBufW; AnsiString.MaximumLength = RtlUnicodeStringToAnsiSize(MenuName); Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/brush.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/brush.c Mon Apr 2 19:08:54 2007 @@ -628,7 +628,7 @@ IN BOOL bPen, IN PVOID PackedDIB) { - BITMAPINFO *SafeBitmapInfoAndData = NULL; + BITMAPINFO *SafeBitmapInfoAndData; NTSTATUS Status = STATUS_SUCCESS; HBRUSH hBrush; Modified: trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c Mon Apr 2 19:08:54 2007 @@ -203,7 +203,7 @@ int STDCALL NtGdiGetClipBox(HDC hDC, LPRECT rc) { - int Ret = FALSE; + int Ret; NTSTATUS Status = STATUS_SUCCESS; RECT Saferect; Modified: trunk/reactos/subsystems/win32/win32k/objects/coord.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/coord.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/coord.c Mon Apr 2 19:08:54 2007 @@ -82,7 +82,7 @@ XFORM xformTemp; XFORM xform1 = {0}, xform2 = {0}; NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret = FALSE; + BOOL Ret; _SEH_TRY { @@ -170,10 +170,10 @@ LPPOINT UnsafePoints, int Count) { - PDC dc = NULL; + PDC dc; NTSTATUS Status = STATUS_SUCCESS; - LPPOINT Points = NULL; - ULONG Size = 0; + LPPOINT Points; + ULONG Size; dc = DC_LockDc(hDC); if (!dc) @@ -320,7 +320,7 @@ NtGdiGetWorldTransform(HDC hDC, LPXFORM XForm) { - PDC dc = NULL; + PDC dc; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc ( hDC ); @@ -393,10 +393,10 @@ BOOL STDCALL NtGdiLPtoDP ( HDC hDC, LPPOINT UnsafePoints, INT Count ) { - PDC dc = NULL; + PDC dc; NTSTATUS Status = STATUS_SUCCESS; - LPPOINT Points = NULL; - ULONG Size = 0; + LPPOINT Points; + ULONG Size; dc = DC_LockDc(hDC); if (!dc) @@ -479,7 +479,7 @@ CONST LPXFORM UnsafeXForm, DWORD Mode) { - PDC dc = NULL; + PDC dc; XFORM SafeXForm; BOOL Ret = FALSE; @@ -520,7 +520,7 @@ int YOffset, LPPOINT UnsafePoint) { - PDC dc = NULL; + PDC dc; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc ( hDC ); @@ -569,7 +569,7 @@ int YOffset, LPPOINT Point) { - PDC dc = NULL; + PDC dc; dc = DC_LockDc(hDC); if (!dc) @@ -758,7 +758,7 @@ int YExtent, LPSIZE Size) { - PDC dc = NULL; + PDC dc; dc = DC_LockDc(hDC); if ( !dc ) @@ -830,7 +830,7 @@ int Y, LPPOINT Point) { - PDC dc = NULL; + PDC dc; dc = DC_LockDc(hDC); if (!dc) @@ -881,7 +881,7 @@ int YExtent, LPSIZE Size) { - PDC dc = NULL; + PDC dc; dc = DC_LockDc(hDC); if (!dc) @@ -944,7 +944,7 @@ int Y, LPPOINT Point) { - PDC dc = NULL; + PDC dc; dc = DC_LockDc(hDC); if (!dc) @@ -993,7 +993,7 @@ NtGdiSetWorldTransform(HDC hDC, CONST LPXFORM XForm) { - PDC dc = NULL; + PDC dc; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc (hDC); Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dc.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dc.c Mon Apr 2 19:08:54 2007 @@ -1249,8 +1249,8 @@ BOOL STDCALL NtGdiGetDCOrgEx(HDC hDC, LPPOINT Point) { - BOOL Ret = FALSE; - DC *dc = NULL; + BOOL Ret; + DC *dc; POINT SafePoint; NTSTATUS Status = STATUS_SUCCESS; @@ -1812,7 +1812,7 @@ NtGdiGetObject(HANDLE handle, INT count, LPVOID buffer) { INT Ret = 0; - LPVOID SafeBuf = NULL; + LPVOID SafeBuf; NTSTATUS Status = STATUS_SUCCESS; INT RetCount = 0; Modified: trunk/reactos/subsystems/win32/win32k/objects/dibobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dibobj.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dibobj.c Mon Apr 2 19:08:54 2007 @@ -27,9 +27,9 @@ UINT STDCALL NtGdiSetDIBColorTable(HDC hDC, UINT StartIndex, UINT Entries, CONST RGBQUAD *Colors) { - PDC dc = NULL; - PBITMAPOBJ BitmapObj = NULL; - PPALGDI PalGDI = NULL; + PDC dc; + PBITMAPOBJ BitmapObj; + PPALGDI PalGDI; UINT Index; if (!(dc = DC_LockDc(hDC))) return 0; @@ -92,9 +92,9 @@ UINT STDCALL NtGdiGetDIBColorTable(HDC hDC, UINT StartIndex, UINT Entries, RGBQUAD *Colors) { - PDC dc = NULL; - PBITMAPOBJ BitmapObj = NULL; - PPALGDI PalGDI = NULL; + PDC dc; + PBITMAPOBJ BitmapObj; + PPALGDI PalGDI; UINT Index; if (!(dc = DC_LockDc(hDC))) return 0; Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/fillshap.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/fillshap.c Mon Apr 2 19:08:54 2007 @@ -827,8 +827,8 @@ CONST PPOINT UnsafePoints, int Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; + DC *dc; + LPPOINT Safept; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret = FALSE; @@ -906,9 +906,9 @@ CONST LPINT PolyCounts, int Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; - LPINT SafePolyPoints = NULL; + DC *dc; + LPPOINT Safept; + LPINT SafePolyPoints; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -1559,11 +1559,11 @@ ULONG uMesh, ULONG ulMode) { - DC *dc = NULL; + DC *dc; BOOL Ret; - PTRIVERTEX SafeVertex = NULL; - PVOID SafeMesh = NULL; - ULONG SizeMesh = 0; + PTRIVERTEX SafeVertex; + PVOID SafeMesh; + ULONG SizeMesh; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc(hdc); Modified: trunk/reactos/subsystems/win32/win32k/objects/line.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/line.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/line.c Mon Apr 2 19:08:54 2007 @@ -501,7 +501,7 @@ int Y, LPPOINT Point) { - DC *dc = NULL; + DC *dc; POINT SafePoint; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -554,8 +554,8 @@ CONST LPPOINT pt, DWORD Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; + DC *dc; + LPPOINT Safept; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -642,8 +642,8 @@ CONST LPPOINT pt, DWORD Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; + DC *dc; + LPPOINT Safept; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -732,7 +732,7 @@ IN LPBYTE lpbTypes, IN ULONG cCount) { - PDC dc = NULL; + PDC dc; BOOL result = FALSE; POINT lastmove; unsigned int i; @@ -806,8 +806,8 @@ CONST LPPOINT pt, int Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; + DC *dc; + LPPOINT Safept; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -894,8 +894,8 @@ CONST LPPOINT pt, DWORD Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; + DC *dc; + LPPOINT Safept; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -983,9 +983,9 @@ CONST LPDWORD PolyPoints, DWORD Count) { - DC *dc = NULL; - LPPOINT Safept = NULL; - LPDWORD SafePolyPoints = NULL; + DC *dc; + LPPOINT Safept; + LPDWORD SafePolyPoints; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; Modified: trunk/reactos/subsystems/win32/win32k/objects/print.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/print.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/print.c Mon Apr 2 19:08:54 2007 @@ -160,7 +160,7 @@ LPVOID SafeInData = NULL; LPVOID SafeOutData = NULL; NTSTATUS Status = STATUS_SUCCESS; - INT Result = 0; + INT Result; if ( pDC == NULL ) { Modified: trunk/reactos/subsystems/win32/win32k/objects/rect.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/rect.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/rect.c Mon Apr 2 19:08:54 2007 @@ -188,7 +188,7 @@ { RECT Dest, Src1 = {0}, Src2 = {0}; NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret = FALSE; + BOOL Ret; _SEH_TRY { @@ -300,7 +300,7 @@ { RECT Dest, Src1, Src2 = {0}; NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret = FALSE; + BOOL Ret; _SEH_TRY { Modified: trunk/reactos/subsystems/win32/win32k/objects/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/region.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/region.c Mon Apr 2 19:08:54 2007 @@ -2253,8 +2253,8 @@ DWORD Count, LPRGNDATA RgnData) { - HRGN hRgn = 0; - PROSRGNDATA Region = NULL; + HRGN hRgn; + PROSRGNDATA Region; DWORD nCount = 0; NTSTATUS Status = STATUS_SUCCESS; @@ -2404,7 +2404,7 @@ { PROSRGNDATA Rgn; RECT SafeRect; - DWORD ret = 0; + DWORD ret; NTSTATUS Status = STATUS_SUCCESS; if (!(Rgn = RGNDATA_LockRgn(hRgn))) @@ -2637,7 +2637,7 @@ NtGdiRectInRegion(HRGN hRgn, CONST LPRECT unsaferc) { - PROSRGNDATA Rgn = NULL; + PROSRGNDATA Rgn; RECT rc = {0}; BOOL Ret; NTSTATUS Status = STATUS_SUCCESS; @@ -2713,7 +2713,7 @@ NtGdiUnionRectWithRgn(HRGN hDest, CONST PRECT UnsafeRect) { RECT SafeRect; - PROSRGNDATA Rgn = NULL; + PROSRGNDATA Rgn; NTSTATUS Status = STATUS_SUCCESS; if(!(Rgn = (PROSRGNDATA)RGNDATA_LockRgn(hDest))) @@ -2759,7 +2759,7 @@ */ DWORD STDCALL NtGdiGetRegionData(HRGN hrgn, DWORD count, LPRGNDATA rgndata) { - DWORD size = 0; + DWORD size; PROSRGNDATA obj = RGNDATA_LockRgn( hrgn ); NTSTATUS Status = STATUS_SUCCESS; @@ -3399,7 +3399,7 @@ INT Count, INT PolyFillMode) { - POINT *SafePoints = NULL; + POINT *SafePoints; NTSTATUS Status = STATUS_SUCCESS; HRGN hRgn; @@ -3495,9 +3495,9 @@ INT Count, INT PolyFillMode) { - POINT *Safept = NULL; - INT *SafePolyCounts = NULL; - INT nPoints = 0, nEmpty, nInvalid, i; + POINT *Safept; + INT *SafePolyCounts; + INT nPoints, nEmpty, nInvalid, i; HRGN hRgn; NTSTATUS Status = STATUS_SUCCESS;

1 0

[greatlrd] 26246: fixing the build for gcc 3.4.5
by greatlrd＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: greatlrd Date: Mon Apr 2 13:48:51 2007 New Revision: 26246 URL: http://svn.reactos.org/svn/reactos?rev=26246&view=rev Log: fixing the build for gcc 3.4.5 Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c trunk/reactos/ntoskrnl/ex/sysinfo.c trunk/reactos/ntoskrnl/ex/timer.c trunk/reactos/ntoskrnl/fsrtl/fastio.c trunk/reactos/ntoskrnl/io/iomgr/driver.c trunk/reactos/ntoskrnl/io/iomgr/file.c trunk/reactos/ntoskrnl/io/iomgr/iofunc.c trunk/reactos/ntoskrnl/io/iomgr/irp.c trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c trunk/reactos/ntoskrnl/ke/i386/usercall.c trunk/reactos/ntoskrnl/ke/thrdobj.c trunk/reactos/ntoskrnl/mm/section.c trunk/reactos/ntoskrnl/mm/virtual.c trunk/reactos/ntoskrnl/ob/obdir.c trunk/reactos/ntoskrnl/ob/obhandle.c trunk/reactos/ntoskrnl/ob/obwait.c trunk/reactos/ntoskrnl/ps/job.c trunk/reactos/ntoskrnl/ps/query.c trunk/reactos/ntoskrnl/ps/thread.c trunk/reactos/ntoskrnl/se/acl.c trunk/reactos/ntoskrnl/se/priv.c trunk/reactos/ntoskrnl/se/sd.c trunk/reactos/ntoskrnl/se/sid.c trunk/reactos/ntoskrnl/se/token.c Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cm/ntfunc.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/cm/ntfunc.c (original) +++ trunk/reactos/ntoskrnl/cm/ntfunc.c Mon Apr 2 13:48:51 2007 @@ -299,7 +299,7 @@ unsigned i; REG_PRE_CREATE_KEY_INFORMATION PreCreateKeyInfo; REG_POST_CREATE_KEY_INFORMATION PostCreateKeyInfo; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; UNICODE_STRING CapturedClass = {0}; HANDLE hKey; @@ -1308,7 +1308,7 @@ IN POBJECT_ATTRIBUTES ObjectAttributes) { UNICODE_STRING RemainingPath; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; PVOID Object = NULL; HANDLE hKey = NULL; NTSTATUS Status = STATUS_SUCCESS; @@ -2145,7 +2145,7 @@ NTSTATUS Status; REG_DELETE_VALUE_KEY_INFORMATION DeleteValueKeyInfo; REG_POST_OPERATION_INFORMATION PostOperationInfo; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; UNICODE_STRING CapturedValueName; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/sysinfo.c (original) +++ trunk/reactos/ntoskrnl/ex/sysinfo.c Mon Apr 2 13:48:51 2007 @@ -232,10 +232,10 @@ ANSI_STRING AName; UNICODE_STRING WName; BOOLEAN Result; - PCH Value; + PCH Value = NULL; ANSI_STRING AValue; UNICODE_STRING WValue; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -378,7 +378,7 @@ { UNICODE_STRING CapturedName, CapturedValue; ANSI_STRING AName, AValue; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; NTSTATUS Status; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/ex/timer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/timer.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/ex/timer.c (original) +++ trunk/reactos/ntoskrnl/ex/timer.c Mon Apr 2 13:48:51 2007 @@ -510,7 +510,7 @@ { PETIMER Timer; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); - NTSTATUS Status; + NTSTATUS Status = STATUS_UNSUCCESSFUL; PTIMER_BASIC_INFORMATION BasicInfo = TimerInformation; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/fastio.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/fastio.c (original) +++ trunk/reactos/ntoskrnl/fsrtl/fastio.c Mon Apr 2 13:48:51 2007 @@ -83,7 +83,7 @@ IN PDEVICE_OBJECT DeviceObject) { - PFSRTL_COMMON_FCB_HEADER FcbHeader; + PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; LARGE_INTEGER Offset; PFAST_IO_DISPATCH FastIoDispatch; PDEVICE_OBJECT Device; @@ -258,7 +258,7 @@ BOOLEAN Result = TRUE; PFAST_IO_DISPATCH FastIoDispatch; PDEVICE_OBJECT Device; - PFSRTL_COMMON_FCB_HEADER FcbHeader; + PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; /* WDK doc. Offset=0xffffffffffffffff indicates append to the end of file */ BOOLEAN FileOffsetAppend = ((FileOffset->HighPart == 0xffffffff) && (FileOffset->LowPart == 0xffffffff)); @@ -915,7 +915,7 @@ OUT PIO_STATUS_BLOCK IoStatus, IN PDEVICE_OBJECT DeviceObject) { - PFSRTL_COMMON_FCB_HEADER FcbHeader; + PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; BOOLEAN Result = TRUE; LARGE_INTEGER Offset; PFAST_IO_DISPATCH FastIoDispatch; @@ -1159,7 +1159,7 @@ BOOLEAN Result = TRUE; PFAST_IO_DISPATCH FastIoDispatch; PDEVICE_OBJECT Device; - PFSRTL_COMMON_FCB_HEADER FcbHeader; + PFSRTL_COMMON_FCB_HEADER FcbHeader = NULL; LARGE_INTEGER OldFileSize; LARGE_INTEGER OldValidDataLength; Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Mon Apr 2 13:48:51 2007 @@ -1475,7 +1475,7 @@ UNICODE_STRING ImagePath; UNICODE_STRING ServiceName; UNICODE_STRING CapturedDriverServiceName = {0}; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; NTSTATUS Status; ULONG Type; PDEVICE_NODE DeviceNode; Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/file.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/file.c Mon Apr 2 13:48:51 2007 @@ -1629,7 +1629,7 @@ IN PVOID ExtraCreateParameters OPTIONAL, IN ULONG Options) { - KPROCESSOR_MODE AccessMode; + KPROCESSOR_MODE AccessMode = {0}; HANDLE LocalHandle = 0; LARGE_INTEGER SafeAllocationSize; PVOID SystemEaBuffer = NULL; Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Mon Apr 2 13:48:51 2007 @@ -198,12 +198,12 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_OBJECT FileObject; - PDEVICE_OBJECT DeviceObject; - PIRP Irp; + PDEVICE_OBJECT DeviceObject = NULL; + PIRP Irp = NULL; PIO_STACK_LOCATION StackPtr; PKEVENT EventObject = NULL; BOOLEAN LockedForSynch = FALSE; - ULONG AccessType; + ULONG AccessType = 0; OBJECT_HANDLE_INFORMATION HandleInformation; ACCESS_MASK DesiredAccess; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); @@ -1212,9 +1212,9 @@ { PFILE_OBJECT FileObject; PLARGE_INTEGER LocalLength = NULL; - PIRP Irp; - PIO_STACK_LOCATION StackPtr; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PIO_STACK_LOCATION StackPtr = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PKEVENT Event = NULL; BOOLEAN LockedForSync = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); @@ -1386,8 +1386,8 @@ IN PUNICODE_STRING FileName OPTIONAL, IN BOOLEAN RestartScan) { - PIRP Irp; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PFILE_OBJECT FileObject; PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); @@ -1627,9 +1627,9 @@ OBJECT_HANDLE_INFORMATION HandleInformation; PFILE_OBJECT FileObject; NTSTATUS Status = STATUS_SUCCESS; - PIRP Irp; - PDEVICE_OBJECT DeviceObject; - PIO_STACK_LOCATION StackPtr; + PIRP Irp = NULL; + PDEVICE_OBJECT DeviceObject = NULL; + PIO_STACK_LOCATION StackPtr = NULL; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; @@ -1938,8 +1938,8 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_OBJECT FileObject; - PIRP Irp; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); PKEVENT EventObject = NULL; @@ -2197,9 +2197,9 @@ { PFILE_OBJECT FileObject; NTSTATUS Status = STATUS_SUCCESS; - PIRP Irp; - PDEVICE_OBJECT DeviceObject; - PIO_STACK_LOCATION StackPtr; + PIRP Irp = NULL; + PDEVICE_OBJECT DeviceObject = NULL; + PIO_STACK_LOCATION StackPtr = NULL; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; @@ -2576,9 +2576,9 @@ { PFILE_OBJECT FileObject; PLARGE_INTEGER LocalLength = NULL; - PIRP Irp; - PIO_STACK_LOCATION StackPtr; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PIO_STACK_LOCATION StackPtr = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); @@ -2760,8 +2760,8 @@ { NTSTATUS Status = STATUS_SUCCESS; PFILE_OBJECT FileObject; - PIRP Irp; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PIO_STACK_LOCATION StackPtr; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); PKEVENT EventObject = NULL; @@ -3027,9 +3027,9 @@ IN FS_INFORMATION_CLASS FsInformationClass) { PFILE_OBJECT FileObject; - PIRP Irp; - PIO_STACK_LOCATION StackPtr; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PIO_STACK_LOCATION StackPtr = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); @@ -3190,9 +3190,9 @@ IN FS_INFORMATION_CLASS FsInformationClass) { PFILE_OBJECT FileObject; - PIRP Irp; - PIO_STACK_LOCATION StackPtr; - PDEVICE_OBJECT DeviceObject; + PIRP Irp = NULL; + PIO_STACK_LOCATION StackPtr = NULL; + PDEVICE_OBJECT DeviceObject = NULL; PKEVENT Event = NULL; BOOLEAN LocalEvent = FALSE; KPROCESSOR_MODE PreviousMode = KeGetPreviousMode(); Modified: trunk/reactos/ntoskrnl/io/iomgr/irp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irp.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/irp.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/irp.c Mon Apr 2 13:48:51 2007 @@ -610,8 +610,8 @@ IN PLARGE_INTEGER StartingOffset, IN PIO_STATUS_BLOCK IoStatusBlock) { - PIRP Irp; - PIO_STACK_LOCATION StackPtr; + PIRP Irp = NULL; + PIO_STACK_LOCATION StackPtr = NULL; /* Allocate IRP */ Irp = IoAllocateIrp(DeviceObject->StackSize, FALSE); @@ -745,7 +745,7 @@ IN PKEVENT Event, IN PIO_STATUS_BLOCK IoStatusBlock) { - PIRP Irp; + PIRP Irp = NULL; PIO_STACK_LOCATION StackPtr; ULONG BufferLength; Modified: trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/plugpla… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/plugplay.c Mon Apr 2 13:48:51 2007 @@ -443,7 +443,7 @@ UNICODE_STRING DeviceInstance; ULONG BufferSize; ULONG Property = 0; - PVOID Buffer; + PVOID Buffer = NULL; DPRINT("IopGetDeviceProperty() called\n"); DPRINT("Device name: %wZ\n", &PropertyData->DeviceInstance); Modified: trunk/reactos/ntoskrnl/ke/i386/usercall.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/usercall.… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/usercall.c (original) +++ trunk/reactos/ntoskrnl/ke/i386/usercall.c Mon Apr 2 13:48:51 2007 @@ -148,8 +148,8 @@ OUT PVOID *Result, OUT PULONG ResultLength) { - ULONG_PTR NewStack, OldStack; - PULONG UserEsp; + ULONG_PTR NewStack =0, OldStack = 0; + PULONG UserEsp = NULL; NTSTATUS CallbackStatus = STATUS_SUCCESS; PEXCEPTION_REGISTRATION_RECORD ExceptionList; PTEB Teb; Modified: trunk/reactos/ntoskrnl/ke/thrdobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/thrdobj.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ke/thrdobj.c (original) +++ trunk/reactos/ntoskrnl/ke/thrdobj.c Mon Apr 2 13:48:51 2007 @@ -723,7 +723,7 @@ ULONG i; PKWAIT_BLOCK TimerWaitBlock; PKTIMER Timer; - NTSTATUS Status; + NTSTATUS Status = STATUS_UNSUCCESSFUL; /* Initalize the Dispatcher Header */ KeInitializeDispatcherHeader(&Thread->DispatcherHeader, Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c (original) +++ trunk/reactos/ntoskrnl/mm/section.c Mon Apr 2 13:48:51 2007 @@ -3670,7 +3670,7 @@ SIZE_T SafeViewSize; PROS_SECTION_OBJECT Section; PEPROCESS Process; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; PMADDRESS_SPACE AddressSpace; NTSTATUS Status = STATUS_SUCCESS; ULONG tmpProtect; Modified: trunk/reactos/ntoskrnl/mm/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/virtual.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/virtual.c (original) +++ trunk/reactos/ntoskrnl/mm/virtual.c Mon Apr 2 13:48:51 2007 @@ -554,10 +554,10 @@ IN ULONG NumberOfBytesToRead, OUT PULONG NumberOfBytesRead OPTIONAL) { - PMDL Mdl; + PMDL Mdl = NULL; PVOID SystemAddress; - KPROCESSOR_MODE PreviousMode; - PEPROCESS Process, CurrentProcess; + KPROCESSOR_MODE PreviousMode = {0}; + PEPROCESS Process, CurrentProcess = NULL; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -769,11 +769,11 @@ IN ULONG NumberOfBytesToWrite, OUT PULONG NumberOfBytesWritten OPTIONAL) { - PMDL Mdl; - PVOID SystemAddress; + PMDL Mdl = NULL; + PVOID SystemAddress = NULL; PEPROCESS Process; - KPROCESSOR_MODE PreviousMode; - NTSTATUS CopyStatus, Status = STATUS_SUCCESS; + KPROCESSOR_MODE PreviousMode = {0}; + NTSTATUS CopyStatus = STATUS_SUCCESS, Status = STATUS_SUCCESS; DPRINT("NtWriteVirtualMemory(ProcessHandle %x, BaseAddress %x, " "Buffer %x, NumberOfBytesToWrite %d)\n",ProcessHandle,BaseAddress, Modified: trunk/reactos/ntoskrnl/ob/obdir.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obdir.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obdir.c (original) +++ trunk/reactos/ntoskrnl/ob/obdir.c Mon Apr 2 13:48:51 2007 @@ -466,7 +466,7 @@ KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); ULONG SkipEntries = 0; NTSTATUS Status = STATUS_SUCCESS; - PVOID LocalBuffer; + PVOID LocalBuffer = NULL; POBJECT_DIRECTORY_INFORMATION DirectoryInfo; ULONG Length, TotalLength; ULONG Count, CurrentEntry; Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obhandle.c (original) +++ trunk/reactos/ntoskrnl/ob/obhandle.c Mon Apr 2 13:48:51 2007 @@ -3150,7 +3150,7 @@ IN ULONG HandleAttributes, IN ULONG Options) { - PEPROCESS SourceProcess, TargetProcess, Target; + PEPROCESS SourceProcess, TargetProcess, Target = NULL; HANDLE hTarget; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/ob/obwait.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/obwait.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obwait.c (original) +++ trunk/reactos/ntoskrnl/ob/obwait.c Mon Apr 2 13:48:51 2007 @@ -56,7 +56,7 @@ ULONG i = 0, ReferencedObjects = 0, j; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); LARGE_INTEGER SafeTimeOut; - BOOLEAN LockInUse; + BOOLEAN LockInUse = FALSE; PHANDLE_TABLE_ENTRY HandleEntry; POBJECT_HEADER ObjectHeader; PHANDLE_TABLE HandleTable; @@ -457,7 +457,7 @@ { KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); POBJECT_TYPE Type; - PVOID SignalObj, WaitObj, WaitableObject; + PVOID SignalObj, WaitObj, WaitableObject = NULL; LARGE_INTEGER SafeTimeOut; OBJECT_HANDLE_INFORMATION HandleInfo; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/ps/job.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/job.c?rev=2624… ============================================================================== --- trunk/reactos/ntoskrnl/ps/job.c (original) +++ trunk/reactos/ntoskrnl/ps/job.c Mon Apr 2 13:48:51 2007 @@ -225,8 +225,8 @@ { HANDLE hJob; PEJOB Job; - KPROCESSOR_MODE PreviousMode; - PEPROCESS CurrentProcess; + KPROCESSOR_MODE PreviousMode = {0}; + PEPROCESS CurrentProcess = NULL; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -396,7 +396,7 @@ ACCESS_MASK DesiredAccess, POBJECT_ATTRIBUTES ObjectAttributes) { - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; HANDLE hJob; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/ps/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/ps/query.c (original) +++ trunk/reactos/ntoskrnl/ps/query.c Mon Apr 2 13:48:51 2007 @@ -484,7 +484,7 @@ PEPROCESS Process; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); ACCESS_MASK Access; - NTSTATUS Status; + NTSTATUS Status = STATUS_NOT_IMPLEMENTED; HANDLE PortHandle = NULL; HANDLE TokenHandle = NULL; PROCESS_SESSION_INFORMATION SessionInfo = {0}; @@ -719,7 +719,7 @@ PETHREAD Thread; ULONG Access; KPROCESSOR_MODE PreviousMode = ExGetPreviousMode(); - NTSTATUS Status; + NTSTATUS Status = STATUS_INVALID_PARAMETER; HANDLE TokenHandle = NULL; KPRIORITY Priority = 0; KAFFINITY Affinity = 0, CombinedAffinity; Modified: trunk/reactos/ntoskrnl/ps/thread.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/thread.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/ps/thread.c (original) +++ trunk/reactos/ntoskrnl/ps/thread.c Mon Apr 2 13:48:51 2007 @@ -141,7 +141,7 @@ PspSystemThreadStartup(IN PKSTART_ROUTINE StartRoutine, IN PVOID StartContext) { - PETHREAD Thread; + PETHREAD Thread = NULL; PSTRACE(PS_THREAD_DEBUG, "StartRoutine: %p StartContext: %p\n", StartRoutine, StartContext); Modified: trunk/reactos/ntoskrnl/se/acl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/acl.c?rev=2624… ============================================================================== --- trunk/reactos/ntoskrnl/se/acl.c (original) +++ trunk/reactos/ntoskrnl/se/acl.c Mon Apr 2 13:48:51 2007 @@ -275,7 +275,7 @@ IN BOOLEAN CaptureIfKernel, OUT PACL *CapturedAcl) { - PACL NewAcl; + PACL NewAcl = NULL; ULONG AclSize = 0; NTSTATUS Status = STATUS_SUCCESS; Modified: trunk/reactos/ntoskrnl/se/priv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/priv.c?rev=262… ============================================================================== --- trunk/reactos/ntoskrnl/se/priv.c (original) +++ trunk/reactos/ntoskrnl/se/priv.c Mon Apr 2 13:48:51 2007 @@ -184,7 +184,7 @@ PLUID_AND_ATTRIBUTES* Dest, PULONG Length) { - ULONG BufferSize; + ULONG BufferSize = 0; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -300,7 +300,7 @@ ULONG PrivilegeControl = 0; ULONG Length; BOOLEAN CheckResult; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/se/sd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sd.c?rev=26246… ============================================================================== --- trunk/reactos/ntoskrnl/se/sd.c (original) +++ trunk/reactos/ntoskrnl/se/sd.c Mon Apr 2 13:48:51 2007 @@ -394,7 +394,7 @@ { PISECURITY_DESCRIPTOR OriginalSecurityDescriptor = _OriginalSecurityDescriptor; SECURITY_DESCRIPTOR DescriptorCopy; - PISECURITY_DESCRIPTOR NewDescriptor; + PISECURITY_DESCRIPTOR NewDescriptor = NULL; ULONG OwnerSAC = 0, GroupSAC = 0; ULONG OwnerSize = 0, GroupSize = 0; ULONG SaclSize = 0, DaclSize = 0; Modified: trunk/reactos/ntoskrnl/se/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/sid.c?rev=2624… ============================================================================== --- trunk/reactos/ntoskrnl/se/sid.c (original) +++ trunk/reactos/ntoskrnl/se/sid.c Mon Apr 2 13:48:51 2007 @@ -236,7 +236,7 @@ OUT PSID *CapturedSid) { ULONG SidSize = 0; - PISID NewSid, Sid = (PISID)InputSid; + PISID NewSid = NULL, Sid = (PISID)InputSid; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); Modified: trunk/reactos/ntoskrnl/se/token.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/token.c?rev=26… ============================================================================== --- trunk/reactos/ntoskrnl/se/token.c (original) +++ trunk/reactos/ntoskrnl/se/token.c Mon Apr 2 13:48:51 2007 @@ -669,8 +669,8 @@ ULONG Ulong; } Unused; PTOKEN Token; - ULONG RequiredLength; - KPROCESSOR_MODE PreviousMode; + ULONG RequiredLength = 0; + KPROCESSOR_MODE PreviousMode = {0}; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -1253,7 +1253,7 @@ IN ULONG TokenInformationLength) { PTOKEN Token; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; ULONG NeededAccess = TOKEN_ADJUST_DEFAULT; NTSTATUS Status = STATUS_SUCCESS; @@ -1496,7 +1496,7 @@ IN TOKEN_TYPE TokenType, OUT PHANDLE NewTokenHandle) { - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; HANDLE hToken; PTOKEN Token; PTOKEN NewToken; @@ -2134,7 +2134,7 @@ PVOID EndMem; ULONG uLength; ULONG i; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; ULONG nTokenPrivileges = 0; LARGE_INTEGER LocalExpirationTime = {{0}}; NTSTATUS Status = STATUS_SUCCESS; @@ -2464,7 +2464,7 @@ OBJECT_ATTRIBUTES ObjectAttributes; SECURITY_DESCRIPTOR SecurityDescriptor; PACL Dacl = NULL; - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; NTSTATUS Status = STATUS_SUCCESS; PAGED_CODE(); @@ -2661,7 +2661,7 @@ IN HANDLE SecondTokenHandle, OUT PBOOLEAN Equal) { - KPROCESSOR_MODE PreviousMode; + KPROCESSOR_MODE PreviousMode = {0}; PTOKEN FirstToken, SecondToken; BOOLEAN IsEqual; NTSTATUS Status = STATUS_SUCCESS;

2 1

[greatlrd] 26247: some gcc 3.4.5 fixed; but not all we need
by greatlrd＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: greatlrd Date: Mon Apr 2 14:32:21 2007 New Revision: 26247 URL: http://svn.reactos.org/svn/reactos?rev=26247&view=rev Log: some gcc 3.4.5 fixed; but not all we need Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c trunk/reactos/subsystems/win32/win32k/ntuser/class.c trunk/reactos/subsystems/win32/win32k/objects/brush.c trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c trunk/reactos/subsystems/win32/win32k/objects/coord.c trunk/reactos/subsystems/win32/win32k/objects/dc.c trunk/reactos/subsystems/win32/win32k/objects/dibobj.c trunk/reactos/subsystems/win32/win32k/objects/fillshap.c trunk/reactos/subsystems/win32/win32k/objects/line.c trunk/reactos/subsystems/win32/win32k/objects/print.c trunk/reactos/subsystems/win32/win32k/objects/rect.c trunk/reactos/subsystems/win32/win32k/objects/region.c Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/dd.c Mon Apr 2 14:32:21 2007 @@ -40,11 +40,11 @@ HANDLE *puhSurface ) { - INT i; + INT i = 0; DWORD ddRVal = DDHAL_DRIVER_NOTHANDLED; NTSTATUS Status = FALSE; - PDD_DIRECTDRAW pDirectDraw; - PDD_SURFACE phsurface; + PDD_DIRECTDRAW pDirectDraw = NULL; + PDD_SURFACE phsurface = NULL; PDD_SURFACE_LOCAL pLocal; PDD_SURFACE_MORE pMore; @@ -53,7 +53,7 @@ DD_CREATESURFACEDATA CreateSurfaceData; /* FIXME alloc so mayne we need */ - PHANDLE *myhSurface; + PHANDLE *myhSurface = NULL; /* GCC4 warnns on value are unisitaed, but they are initated in seh @@ -508,7 +508,7 @@ { DWORD ddRVal = DDHAL_DRIVER_NOTHANDLED; DD_GETSCANLINEDATA GetScanLineData; - PDD_DIRECTDRAW pDirectDraw; + PDD_DIRECTDRAW pDirectDraw = NULL; NTSTATUS Status = FALSE; DPRINT1("NtGdiDdGetScanLine\n"); Modified: trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntddraw/ddraw.c Mon Apr 2 14:32:21 2007 @@ -292,7 +292,7 @@ DWORD *puFourCC ) { - PDD_DIRECTDRAW pDirectDraw; + PDD_DIRECTDRAW pDirectDraw = NULL; NTSTATUS Status = FALSE; BOOL Ret=FALSE; @@ -549,7 +549,7 @@ { BOOL Ret=FALSE; NTSTATUS Status = FALSE; - PDD_DIRECTDRAW pDirectDraw; + PDD_DIRECTDRAW pDirectDraw = NULL; if (hDirectDrawLocal == NULL) { Modified: trunk/reactos/subsystems/win32/win32k/ntuser/class.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/class.c (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/class.c Mon Apr 2 14:32:21 2007 @@ -1137,7 +1137,7 @@ IN DWORD dwFlags) { PW32THREADINFO ti; - PW32PROCESSINFO pi; + PW32PROCESSINFO pi = NULL; PWINDOWCLASS Class; RTL_ATOM ClassAtom; RTL_ATOM Ret = (RTL_ATOM)0; @@ -1484,7 +1484,7 @@ if (MenuName->Length != 0) { ANSI_STRING AnsiString; - PWSTR strBufW; + PWSTR strBufW = NULL; AnsiString.MaximumLength = RtlUnicodeStringToAnsiSize(MenuName); Modified: trunk/reactos/subsystems/win32/win32k/objects/brush.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/brush.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/brush.c Mon Apr 2 14:32:21 2007 @@ -628,7 +628,7 @@ IN BOOL bPen, IN PVOID PackedDIB) { - BITMAPINFO *SafeBitmapInfoAndData; + BITMAPINFO *SafeBitmapInfoAndData = NULL; NTSTATUS Status = STATUS_SUCCESS; HBRUSH hBrush; Modified: trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/cliprgn.c Mon Apr 2 14:32:21 2007 @@ -203,7 +203,7 @@ int STDCALL NtGdiGetClipBox(HDC hDC, LPRECT rc) { - int Ret; + int Ret = FALSE; NTSTATUS Status = STATUS_SUCCESS; RECT Saferect; Modified: trunk/reactos/subsystems/win32/win32k/objects/coord.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/coord.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/coord.c Mon Apr 2 14:32:21 2007 @@ -82,7 +82,7 @@ XFORM xformTemp; XFORM xform1 = {0}, xform2 = {0}; NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret; + BOOL Ret = FALSE; _SEH_TRY { @@ -170,10 +170,10 @@ LPPOINT UnsafePoints, int Count) { - PDC dc; + PDC dc = NULL; NTSTATUS Status = STATUS_SUCCESS; - LPPOINT Points; - ULONG Size; + LPPOINT Points = NULL; + ULONG Size = 0; dc = DC_LockDc(hDC); if (!dc) @@ -320,7 +320,7 @@ NtGdiGetWorldTransform(HDC hDC, LPXFORM XForm) { - PDC dc; + PDC dc = NULL; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc ( hDC ); @@ -393,10 +393,10 @@ BOOL STDCALL NtGdiLPtoDP ( HDC hDC, LPPOINT UnsafePoints, INT Count ) { - PDC dc; + PDC dc = NULL; NTSTATUS Status = STATUS_SUCCESS; - LPPOINT Points; - ULONG Size; + LPPOINT Points = NULL; + ULONG Size = 0; dc = DC_LockDc(hDC); if (!dc) @@ -479,7 +479,7 @@ CONST LPXFORM UnsafeXForm, DWORD Mode) { - PDC dc; + PDC dc = NULL; XFORM SafeXForm; BOOL Ret = FALSE; @@ -520,7 +520,7 @@ int YOffset, LPPOINT UnsafePoint) { - PDC dc; + PDC dc = NULL; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc ( hDC ); @@ -569,7 +569,7 @@ int YOffset, LPPOINT Point) { - PDC dc; + PDC dc = NULL; dc = DC_LockDc(hDC); if (!dc) @@ -758,7 +758,7 @@ int YExtent, LPSIZE Size) { - PDC dc; + PDC dc = NULL; dc = DC_LockDc(hDC); if ( !dc ) @@ -830,7 +830,7 @@ int Y, LPPOINT Point) { - PDC dc; + PDC dc = NULL; dc = DC_LockDc(hDC); if (!dc) @@ -881,7 +881,7 @@ int YExtent, LPSIZE Size) { - PDC dc; + PDC dc = NULL; dc = DC_LockDc(hDC); if (!dc) @@ -944,7 +944,7 @@ int Y, LPPOINT Point) { - PDC dc; + PDC dc = NULL; dc = DC_LockDc(hDC); if (!dc) @@ -993,7 +993,7 @@ NtGdiSetWorldTransform(HDC hDC, CONST LPXFORM XForm) { - PDC dc; + PDC dc = NULL; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc (hDC); Modified: trunk/reactos/subsystems/win32/win32k/objects/dc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dc.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dc.c Mon Apr 2 14:32:21 2007 @@ -1249,8 +1249,8 @@ BOOL STDCALL NtGdiGetDCOrgEx(HDC hDC, LPPOINT Point) { - BOOL Ret; - DC *dc; + BOOL Ret = FALSE; + DC *dc = NULL; POINT SafePoint; NTSTATUS Status = STATUS_SUCCESS; @@ -1812,7 +1812,7 @@ NtGdiGetObject(HANDLE handle, INT count, LPVOID buffer) { INT Ret = 0; - LPVOID SafeBuf; + LPVOID SafeBuf = NULL; NTSTATUS Status = STATUS_SUCCESS; INT RetCount = 0; Modified: trunk/reactos/subsystems/win32/win32k/objects/dibobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/dibobj.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/dibobj.c Mon Apr 2 14:32:21 2007 @@ -27,9 +27,9 @@ UINT STDCALL NtGdiSetDIBColorTable(HDC hDC, UINT StartIndex, UINT Entries, CONST RGBQUAD *Colors) { - PDC dc; - PBITMAPOBJ BitmapObj; - PPALGDI PalGDI; + PDC dc = NULL; + PBITMAPOBJ BitmapObj = NULL; + PPALGDI PalGDI = NULL; UINT Index; if (!(dc = DC_LockDc(hDC))) return 0; @@ -92,9 +92,9 @@ UINT STDCALL NtGdiGetDIBColorTable(HDC hDC, UINT StartIndex, UINT Entries, RGBQUAD *Colors) { - PDC dc; - PBITMAPOBJ BitmapObj; - PPALGDI PalGDI; + PDC dc = NULL; + PBITMAPOBJ BitmapObj = NULL; + PPALGDI PalGDI = NULL; UINT Index; if (!(dc = DC_LockDc(hDC))) return 0; Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/fillshap.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/fillshap.c Mon Apr 2 14:32:21 2007 @@ -827,8 +827,8 @@ CONST PPOINT UnsafePoints, int Count) { - DC *dc; - LPPOINT Safept; + DC *dc = NULL; + LPPOINT Safept = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret = FALSE; @@ -906,9 +906,9 @@ CONST LPINT PolyCounts, int Count) { - DC *dc; - LPPOINT Safept; - LPINT SafePolyPoints; + DC *dc = NULL; + LPPOINT Safept = NULL; + LPINT SafePolyPoints = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -1559,11 +1559,11 @@ ULONG uMesh, ULONG ulMode) { - DC *dc; + DC *dc = NULL; BOOL Ret; - PTRIVERTEX SafeVertex; - PVOID SafeMesh; - ULONG SizeMesh; + PTRIVERTEX SafeVertex = NULL; + PVOID SafeMesh = NULL; + ULONG SizeMesh = 0; NTSTATUS Status = STATUS_SUCCESS; dc = DC_LockDc(hdc); Modified: trunk/reactos/subsystems/win32/win32k/objects/line.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/line.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/line.c Mon Apr 2 14:32:21 2007 @@ -501,7 +501,7 @@ int Y, LPPOINT Point) { - DC *dc; + DC *dc = NULL; POINT SafePoint; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -554,8 +554,8 @@ CONST LPPOINT pt, DWORD Count) { - DC *dc; - LPPOINT Safept; + DC *dc = NULL; + LPPOINT Safept = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -642,8 +642,8 @@ CONST LPPOINT pt, DWORD Count) { - DC *dc; - LPPOINT Safept; + DC *dc = NULL; + LPPOINT Safept = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -732,7 +732,7 @@ IN LPBYTE lpbTypes, IN ULONG cCount) { - PDC dc; + PDC dc = NULL; BOOL result = FALSE; POINT lastmove; unsigned int i; @@ -806,8 +806,8 @@ CONST LPPOINT pt, int Count) { - DC *dc; - LPPOINT Safept; + DC *dc = NULL; + LPPOINT Safept = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -894,8 +894,8 @@ CONST LPPOINT pt, DWORD Count) { - DC *dc; - LPPOINT Safept; + DC *dc = NULL; + LPPOINT Safept = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; @@ -983,9 +983,9 @@ CONST LPDWORD PolyPoints, DWORD Count) { - DC *dc; - LPPOINT Safept; - LPDWORD SafePolyPoints; + DC *dc = NULL; + LPPOINT Safept = NULL; + LPDWORD SafePolyPoints = NULL; NTSTATUS Status = STATUS_SUCCESS; BOOL Ret; Modified: trunk/reactos/subsystems/win32/win32k/objects/print.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/print.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/print.c Mon Apr 2 14:32:21 2007 @@ -160,7 +160,7 @@ LPVOID SafeInData = NULL; LPVOID SafeOutData = NULL; NTSTATUS Status = STATUS_SUCCESS; - INT Result; + INT Result = 0; if ( pDC == NULL ) { Modified: trunk/reactos/subsystems/win32/win32k/objects/rect.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/rect.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/rect.c Mon Apr 2 14:32:21 2007 @@ -188,7 +188,7 @@ { RECT Dest, Src1 = {0}, Src2 = {0}; NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret; + BOOL Ret = FALSE; _SEH_TRY { @@ -300,7 +300,7 @@ { RECT Dest, Src1, Src2 = {0}; NTSTATUS Status = STATUS_SUCCESS; - BOOL Ret; + BOOL Ret = FALSE; _SEH_TRY { Modified: trunk/reactos/subsystems/win32/win32k/objects/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/region.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/region.c Mon Apr 2 14:32:21 2007 @@ -2253,8 +2253,8 @@ DWORD Count, LPRGNDATA RgnData) { - HRGN hRgn; - PROSRGNDATA Region; + HRGN hRgn = 0; + PROSRGNDATA Region = NULL; DWORD nCount = 0; NTSTATUS Status = STATUS_SUCCESS; @@ -2404,7 +2404,7 @@ { PROSRGNDATA Rgn; RECT SafeRect; - DWORD ret; + DWORD ret = 0; NTSTATUS Status = STATUS_SUCCESS; if (!(Rgn = RGNDATA_LockRgn(hRgn))) @@ -2637,7 +2637,7 @@ NtGdiRectInRegion(HRGN hRgn, CONST LPRECT unsaferc) { - PROSRGNDATA Rgn; + PROSRGNDATA Rgn = NULL; RECT rc = {0}; BOOL Ret; NTSTATUS Status = STATUS_SUCCESS; @@ -2713,7 +2713,7 @@ NtGdiUnionRectWithRgn(HRGN hDest, CONST PRECT UnsafeRect) { RECT SafeRect; - PROSRGNDATA Rgn; + PROSRGNDATA Rgn = NULL; NTSTATUS Status = STATUS_SUCCESS; if(!(Rgn = (PROSRGNDATA)RGNDATA_LockRgn(hDest))) @@ -2759,7 +2759,7 @@ */ DWORD STDCALL NtGdiGetRegionData(HRGN hrgn, DWORD count, LPRGNDATA rgndata) { - DWORD size; + DWORD size = 0; PROSRGNDATA obj = RGNDATA_LockRgn( hrgn ); NTSTATUS Status = STATUS_SUCCESS; @@ -3399,7 +3399,7 @@ INT Count, INT PolyFillMode) { - POINT *SafePoints; + POINT *SafePoints = NULL; NTSTATUS Status = STATUS_SUCCESS; HRGN hRgn; @@ -3495,9 +3495,9 @@ INT Count, INT PolyFillMode) { - POINT *Safept; - INT *SafePolyCounts; - INT nPoints, nEmpty, nInvalid, i; + POINT *Safept = NULL; + INT *SafePolyCounts = NULL; + INT nPoints = 0, nEmpty, nInvalid, i; HRGN hRgn; NTSTATUS Status = STATUS_SUCCESS;

1 0

[greatlrd] 26245: fixing the build for gcc 3.4.5
by greatlrd＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: greatlrd Date: Mon Apr 2 13:01:15 2007 New Revision: 26245 URL: http://svn.reactos.org/svn/reactos?rev=26245&view=rev Log: fixing the build for gcc 3.4.5 Modified: trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c Modified: trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi… ============================================================================== --- trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c (original) +++ trunk/reactos/drivers/network/tcpip/tcpip/dispatch.c Mon Apr 2 13:01:15 2007 @@ -1265,9 +1265,9 @@ * Status of operation */ { - PTCP_REQUEST_QUERY_INFORMATION_EX InputBuffer; + PTCP_REQUEST_QUERY_INFORMATION_EX InputBuffer = NULL; PTRANSPORT_CONTEXT TranContext; - PTI_QUERY_CONTEXT QueryContext; + PTI_QUERY_CONTEXT QueryContext = NULL; PVOID OutputBuffer; TDI_REQUEST Request; UINT Size;

1 0

[greatlrd] 26244: fixing the build for gcc 3.4.5
by greatlrd＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: greatlrd Date: Mon Apr 2 12:58:34 2007 New Revision: 26244 URL: http://svn.reactos.org/svn/reactos?rev=26244&view=rev Log: fixing the build for gcc 3.4.5 Modified: trunk/reactos/drivers/network/afd/afd/tdi.c Modified: trunk/reactos/drivers/network/afd/afd/tdi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/afd/afd/td… ============================================================================== --- trunk/reactos/drivers/network/afd/afd/tdi.c (original) +++ trunk/reactos/drivers/network/afd/afd/tdi.c Mon Apr 2 12:58:34 2007 @@ -766,9 +766,9 @@ PIO_COMPLETION_ROUTINE CompletionRoutine, PVOID CompletionContext ) { - PDEVICE_OBJECT DeviceObject; + PDEVICE_OBJECT DeviceObject = NULL; NTSTATUS Status = STATUS_SUCCESS; - PMDL Mdl; + PMDL Mdl = NULL; DeviceObject = IoGetRelatedDeviceObject(TransportObject); if (!DeviceObject) { @@ -843,8 +843,8 @@ PVOID CompletionContext) { NTSTATUS Status = STATUS_SUCCESS; - PDEVICE_OBJECT DeviceObject; - PMDL Mdl; + PDEVICE_OBJECT DeviceObject = NULL; + PMDL Mdl = NULL; DeviceObject = IoGetRelatedDeviceObject(TransportObject); if (!DeviceObject) {

1 0

[fireball] 26243: - Revert double spinlock releasing introduced by 26242 (but thanks for fixing DPRINT :) ).
by fireball＠svn.reactos.org 02 Apr '07

02 Apr '07

Author: fireball Date: Mon Apr 2 12:00:31 2007 New Revision: 26243 URL: http://svn.reactos.org/svn/reactos?rev=26243&view=rev Log: - Revert double spinlock releasing introduced by 26242 (but thanks for fixing DPRINT :) ). Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/scsiport/s… ============================================================================== --- trunk/reactos/drivers/storage/scsiport/scsiport.c (original) +++ trunk/reactos/drivers/storage/scsiport/scsiport.c Mon Apr 2 12:00:31 2007 @@ -2426,7 +2426,9 @@ { /* Get next logical unit request */ SpiGetNextRequestFromLun(DeviceExtension, LunExtension); - KeReleaseSpinLock(&DeviceExtension->SpinLock, Irql); + + /* SpiGetNextRequestFromLun() releases the spinlock */ + KeLowerIrql(Irql); } else { @@ -3071,8 +3073,9 @@ /* Process the request */ SpiGetNextRequestFromLun(DeviceObject->DeviceExtension, LunExtension); - /* Release spinlock */ - KeReleaseSpinLock(&DeviceExtension->SpinLock, Irql); + /* SpiGetNextRequestFromLun() releases the spinlock, + so we just lower irql back to what it was before */ + KeLowerIrql(Irql); } /* Check if data overrun happened */

1 0

[dgorbachev] 26242: Do not assume ReleaseSpinLock == LowerIrql.
by dgorbachev＠svn.reactos.org 01 Apr '07

01 Apr '07

Author: dgorbachev Date: Mon Apr 2 02:04:26 2007 New Revision: 26242 URL: http://svn.reactos.org/svn/reactos?rev=26242&view=rev Log: Do not assume ReleaseSpinLock == LowerIrql. Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c Modified: trunk/reactos/drivers/storage/scsiport/scsiport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/scsiport/s… ============================================================================== --- trunk/reactos/drivers/storage/scsiport/scsiport.c (original) +++ trunk/reactos/drivers/storage/scsiport/scsiport.c Mon Apr 2 02:04:26 2007 @@ -710,7 +710,7 @@ if (!NT_SUCCESS(Status)) { - DPRINT1("Unable to open driver's registry key %ws, status 0x%08x\n", RegistryPath, Status); + DPRINT1("Unable to open driver's registry key %wZ, status 0x%08x\n", RegistryPath, Status); ConfigInfo->ServiceKey = NULL; } @@ -2426,7 +2426,7 @@ { /* Get next logical unit request */ SpiGetNextRequestFromLun(DeviceExtension, LunExtension); - KeLowerIrql(Irql); + KeReleaseSpinLock(&DeviceExtension->SpinLock, Irql); } else { @@ -3071,8 +3071,8 @@ /* Process the request */ SpiGetNextRequestFromLun(DeviceObject->DeviceExtension, LunExtension); - /* Lower irql back */ - KeLowerIrql(Irql); + /* Release spinlock */ + KeReleaseSpinLock(&DeviceExtension->SpinLock, Irql); } /* Check if data overrun happened */

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs