Ros-diffs

ros-diffs@reactos.org

81390 discussions

[spetreolle] 25817: fix include file case
by spetreolle＠svn.reactos.org 16 Feb '07

16 Feb '07

Author: spetreolle Date: Fri Feb 16 19:57:09 2007 New Revision: 25817 URL: http://svn.reactos.org/svn/reactos?rev=25817&view=rev Log: fix include file case Modified: trunk/rosapps/dxtest/win32kdxtest/main.c Modified: trunk/rosapps/dxtest/win32kdxtest/main.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/main.c… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/main.c (original) +++ trunk/rosapps/dxtest/win32kdxtest/main.c Fri Feb 16 19:57:09 2007 @@ -17,7 +17,7 @@ #include "Windows2000Sp4.h" /* Windows syscall code */ -#include "Windowsos.h" +#include "windowsos.h" /* ReactOS syscall code */ #include "sysreactos.h"

1 0

[greatlrd] 25816: fixed all dam warings before some start nag on me
by greatlrd＠svn.reactos.org 16 Feb '07

16 Feb '07

Author: greatlrd Date: Fri Feb 16 19:48:54 2007 New Revision: 25816 URL: http://svn.reactos.org/svn/reactos?rev=25816&view=rev Log: fixed all dam warings before some start nag on me Modified: trunk/rosapps/dxtest/win32kdxtest/main.c trunk/rosapps/dxtest/win32kdxtest/test.h Modified: trunk/rosapps/dxtest/win32kdxtest/main.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/main.c… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/main.c (original) +++ trunk/rosapps/dxtest/win32kdxtest/main.c Fri Feb 16 19:48:54 2007 @@ -106,7 +106,7 @@ puD3dTextureFormats, puNumHeaps, puvmList, puNumFourCC, puFourCC); - testing_noteq(retValue,NULL,fails,"1. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(retValue,0,fails,"1. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); testing_noteq(pHalInfo,NULL,fails,"2. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); testing_noteq(pCallBackFlags,NULL,fails,"3. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); testing_noteq(puD3dCallbacks,NULL,fails,"4. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); @@ -123,7 +123,7 @@ puvmList, puNumFourCC, puFourCC); - testing_noteq(retValue,NULL,fails,"1. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(retValue,0,fails,"1. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); testing_noteq(pHalInfo,NULL,fails,"2. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); testing_noteq(pCallBackFlags,NULL,fails,"3. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); testing_noteq(puD3dCallbacks,NULL,fails,"4. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); @@ -137,8 +137,6 @@ show_status(fails, "NtGdiDdQueryDirectDrawObject\0"); - - return retValue; } /* @@ -159,8 +157,6 @@ testing_eq(retValue,TRUE,fails,"NtGdiDdDeleteDirectDrawObject(NULL);\0"); show_status(fails, "NtGdiDdDeleteDirectDrawObject\0"); - - return retValue; } Modified: trunk/rosapps/dxtest/win32kdxtest/test.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/test.h… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/test.h (original) +++ trunk/rosapps/dxtest/win32kdxtest/test.h Fri Feb 16 19:48:54 2007 @@ -35,7 +35,7 @@ if (input == value) \ { \ counter++; \ - printf("FAIL ret=%s, %d != %d )\n",text,input,value); \ + printf("FAIL ret=%s, %d != %d )\n",text,(int)input,(int)value); \ } @@ -43,7 +43,7 @@ if (input != value) \ { \ counter++; \ - printf("FAIL ret=%s, %d == %d )\n",text,input,value); \ + printf("FAIL ret=%s, %d == %d )\n",text,(int)input,(int)value); \ }

1 0

[greatlrd] 25815: adding a NULL test for NtGdiDdQueryDirectDrawObject
by greatlrd＠svn.reactos.org 16 Feb '07

16 Feb '07

Author: greatlrd Date: Fri Feb 16 19:43:27 2007 New Revision: 25815 URL: http://svn.reactos.org/svn/reactos?rev=25815&view=rev Log: adding a NULL test for NtGdiDdQueryDirectDrawObject Modified: trunk/rosapps/dxtest/win32kdxtest/main.c Modified: trunk/rosapps/dxtest/win32kdxtest/main.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/main.c… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/main.c (original) +++ trunk/rosapps/dxtest/win32kdxtest/main.c Fri Feb 16 19:43:27 2007 @@ -86,25 +86,54 @@ int fails=0; BOOL retValue=FALSE; - DD_HALINFO *pHalInfo; - DWORD *pCallBackFlags; - LPD3DNTHAL_CALLBACKS puD3dCallbacks; - LPD3DNTHAL_GLOBALDRIVERDATA puD3dDriverData; - PDD_D3DBUFCALLBACKS puD3dBufferCallbacks; - LPDDSURFACEDESC puD3dTextureFormats; - DWORD *puNumHeaps; - VIDEOMEMORY *puvmList; - DWORD *puNumFourCC; - DWORD *puFourCC; + DD_HALINFO *pHalInfo = NULL; + DWORD *pCallBackFlags = NULL; + LPD3DNTHAL_CALLBACKS puD3dCallbacks = NULL; + LPD3DNTHAL_GLOBALDRIVERDATA puD3dDriverData = NULL; + PDD_D3DBUFCALLBACKS puD3dBufferCallbacks = NULL; + LPDDSURFACEDESC puD3dTextureFormats = NULL; + DWORD *puNumHeaps = NULL; + VIDEOMEMORY *puvmList = NULL; + DWORD *puNumFourCC = NULL; + DWORD *puFourCC = NULL; printf("Start testing of NtGdiDdQueryDirectDrawObject\n"); + /* testing NULL */ + retValue = sysNtGdiDdQueryDirectDrawObject( NULL, pHalInfo, + pCallBackFlags, puD3dCallbacks, + puD3dDriverData, puD3dBufferCallbacks, + puD3dTextureFormats, puNumHeaps, + puvmList, puNumFourCC, + puFourCC); + testing_noteq(retValue,NULL,fails,"1. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(pHalInfo,NULL,fails,"2. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(pCallBackFlags,NULL,fails,"3. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(puD3dCallbacks,NULL,fails,"4. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(puD3dDriverData,NULL,fails,"5. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(puD3dBufferCallbacks,NULL,fails,"6. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(puD3dTextureFormats,NULL,fails,"7. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(puNumFourCC,NULL,fails,"8. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + testing_noteq(puFourCC,NULL,fails,"9. NtGdiDdQueryDirectDrawObject(NULL, ...);\0"); + retValue = sysNtGdiDdQueryDirectDrawObject( hDirectDrawLocal, pHalInfo, pCallBackFlags, puD3dCallbacks, puD3dDriverData, puD3dBufferCallbacks, puD3dTextureFormats, puNumHeaps, puvmList, puNumFourCC, puFourCC); + + testing_noteq(retValue,NULL,fails,"1. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(pHalInfo,NULL,fails,"2. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(pCallBackFlags,NULL,fails,"3. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(puD3dCallbacks,NULL,fails,"4. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(puD3dDriverData,NULL,fails,"5. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(puD3dBufferCallbacks,NULL,fails,"6. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(puD3dTextureFormats,NULL,fails,"7. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(puNumFourCC,NULL,fails,"8. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + testing_noteq(puFourCC,NULL,fails,"9. NtGdiDdQueryDirectDrawObject(hDirectDrawLocal, NULL, ...);\0"); + + show_status(fails, "NtGdiDdQueryDirectDrawObject\0");

1 0

[greatlrd] 25814: -- Rewrite how we should do syscall now we define the syscall number in a include files. if we getting syscall table for another windows version and sp we can simple adding it to a another include file and use that file to run other that windows. rember the syscall table is diffent in all version of windows and reactos. if u compile this version in vs u will only be avail run it in windows 2000 sp4 and not under any windows version. -- add one more testcase (NtGdiDdDeleteDirect
by greatlrd＠svn.reactos.org 16 Feb '07

16 Feb '07

Author: greatlrd Date: Fri Feb 16 19:27:46 2007 New Revision: 25814 URL: http://svn.reactos.org/svn/reactos?rev=25814&view=rev Log: -- Rewrite how we should do syscall now we define the syscall number in a include files. if we getting syscall table for another windows version and sp we can simple adding it to a another include file and use that file to run other that windows. rember the syscall table is diffent in all version of windows and reactos. if u compile this version in vs u will only be avail run it in windows 2000 sp4 and not under any windows version. -- add one more testcase (NtGdiDdDeleteDirectDrawObject) -- start adding thrid testcase (NtGdiDdQueryDirectDrawObject), this one will take bit longer to completed but I add a stub for it for now. Added: trunk/rosapps/dxtest/win32kdxtest/windowsos.h (with props) Modified: trunk/rosapps/dxtest/win32kdxtest/Windows2000Sp4.h trunk/rosapps/dxtest/win32kdxtest/main.c trunk/rosapps/dxtest/win32kdxtest/sysreactos.h trunk/rosapps/dxtest/win32kdxtest/test.h trunk/rosapps/dxtest/win32kdxtest/win32kdxtest_vc8_auto.vcproj Modified: trunk/rosapps/dxtest/win32kdxtest/Windows2000Sp4.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/Window… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/Windows2000Sp4.h (original) +++ trunk/rosapps/dxtest/win32kdxtest/Windows2000Sp4.h Fri Feb 16 19:27:46 2007 @@ -2,18 +2,9 @@ #if !defined(__REACTOS__) - HANDLE sysNtGdiDdCreateDirectDrawObject(HDC hdc) - { - INT retValue; - _asm - { - mov eax, 0x1039 - lea edx, [hdc] - int 0x2E - mov [retValue],eax - } - return retValue; - } + #define syscallid_NtGdiDdCreateDirectDrawObject 0x1039 + #define syscallid_NtGdiDdDeleteDirectDrawObject 0x103E + #define syscallid_NtGdiDdQueryDirectDrawObject 0x1053 #endif Modified: trunk/rosapps/dxtest/win32kdxtest/main.c URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/main.c… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/main.c (original) +++ trunk/rosapps/dxtest/win32kdxtest/main.c Fri Feb 16 19:27:46 2007 @@ -1,51 +1,142 @@ #include <stdio.h> +/* SDK/DDK/NDK Headers. */ #include <windows.h> +#include <wingdi.h> +#include <winddi.h> +#include <d3dnthal.h> + + #include "test.h" -#include "Windows2000Sp4.h" + +/* which syscall table shall we use WIndows or ReactOS */ + +/* Windows 2000 sp4 syscall table for win32k */ +#include "Windows2000Sp4.h" + +/* Windows syscall code */ +#include "Windowsos.h" + +/* ReactOS syscall code */ #include "sysreactos.h" + +/* +#define DdQueryDirectDrawObject GdiEntry2 + +#define DdCreateSurfaceObject GdiEntry4 +#define DdDeleteSurfaceObject GdiEntry5 +#define DdResetVisrgn GdiEntry6 +#define DdGetDC GdiEntry7 +#define DdReleaseDC GdiEntry8 +#define DdCreateDIBSection GdiEntry9 +#define DdReenableDirectDrawObject GdiEntry10 +#define DdAttachSurface GdiEntry11 +#define DdUnattachSurface GdiEntry12 +#define DdQueryDisplaySettingsUniqueness GdiEntry13 +#define DdGetDxHandle GdiEntry14 +#define DdSetGammaRamp GdiEntry15 +#define DdSwapTextureHandles GdiEntry16 +*/ int main(int argc, char **argv) { + HANDLE hDirectDrawLocal; - test_NtGdiDdCreateDirectDrawObject(); + hDirectDrawLocal = test_NtGdiDdCreateDirectDrawObject(); + + test_NtGdiDdQueryDirectDrawObject(hDirectDrawLocal); + + test_NtGdiDdDeleteDirectDrawObject(hDirectDrawLocal); return 0; } - -void +/* + * Test see if we getting a DirectDrawObject from win32k + * + */ +HANDLE test_NtGdiDdCreateDirectDrawObject() { HANDLE retValue=0; int fails=0; HDC hdc=CreateDCW(L"Display",NULL,NULL,NULL); - printf("Start testing of NtGdiDdCreateDirectDrawObject(NULL)\n"); + printf("Start testing of NtGdiDdCreateDirectDrawObject\n"); retValue = sysNtGdiDdCreateDirectDrawObject(NULL); - - if (retValue != NULL) - { - printf("FAIL NtGdiDdCreateDirectDrawObject(NULL) != 0\n"); - fails++; - } + testing_noteq(retValue,NULL,fails,"NtGdiDdCreateDirectDrawObject(NULL);\0"); retValue = sysNtGdiDdCreateDirectDrawObject(hdc); - if (retValue == NULL) - { - printf("FAIL NtGdiDdCreateDirectDrawObject(NULL) == 0)\n"); - fails++; - } + testing_eq(retValue,NULL,fails,"NtGdiDdCreateDirectDrawObject(hdc);\0"); - if (fails == 0) - { - printf("End testing of NtGdiDdCreateDirectDrawObject Status : ok\n"); - } - else - { - printf("End testing of NtGdiDdCreateDirectDrawObject Status : fail\n"); - } + show_status(fails, "NtGdiDdCreateDirectDrawObject\0"); + + return retValue; } +/* + * Test see if we can setup DirectDrawObject + * + */ +void +test_NtGdiDdQueryDirectDrawObject( HANDLE hDirectDrawLocal) +{ + int fails=0; + BOOL retValue=FALSE; + + DD_HALINFO *pHalInfo; + DWORD *pCallBackFlags; + LPD3DNTHAL_CALLBACKS puD3dCallbacks; + LPD3DNTHAL_GLOBALDRIVERDATA puD3dDriverData; + PDD_D3DBUFCALLBACKS puD3dBufferCallbacks; + LPDDSURFACEDESC puD3dTextureFormats; + DWORD *puNumHeaps; + VIDEOMEMORY *puvmList; + DWORD *puNumFourCC; + DWORD *puFourCC; + + printf("Start testing of NtGdiDdQueryDirectDrawObject\n"); + + retValue = sysNtGdiDdQueryDirectDrawObject( hDirectDrawLocal, pHalInfo, + pCallBackFlags, puD3dCallbacks, + puD3dDriverData, puD3dBufferCallbacks, + puD3dTextureFormats, puNumHeaps, + puvmList, puNumFourCC, + puFourCC); + + + show_status(fails, "NtGdiDdQueryDirectDrawObject\0"); + + return retValue; +} + +/* + * Test see if we can delete a DirectDrawObject from win32k + * + */ +void +test_NtGdiDdDeleteDirectDrawObject(HANDLE hDirectDrawLocal) +{ + int fails=0; + BOOL retValue=FALSE; + printf("Start testing of NtGdiDdDeleteDirectDrawObject\n"); + + retValue = sysNtGdiDdDeleteDirectDrawObject(hDirectDrawLocal); + testing_eq(retValue,FALSE,fails,"NtGdiDdDeleteDirectDrawObject(hDirectDrawLocal);\0"); + + retValue = sysNtGdiDdDeleteDirectDrawObject(NULL); + testing_eq(retValue,TRUE,fails,"NtGdiDdDeleteDirectDrawObject(NULL);\0"); + + show_status(fails, "NtGdiDdDeleteDirectDrawObject\0"); + + return retValue; +} + + + + + + + Modified: trunk/rosapps/dxtest/win32kdxtest/sysreactos.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/sysrea… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/sysreactos.h (original) +++ trunk/rosapps/dxtest/win32kdxtest/sysreactos.h Fri Feb 16 19:27:46 2007 @@ -1,5 +1,7 @@ #if defined(__REACTOS__) - #define sysNtGdiDdCreateDirectDrawObject NtGdiDdCreateDirectDrawObject; + #define sysNtGdiDdCreateDirectDrawObject NtGdiDdCreateDirectDrawObject + #define sysNtGdiDdDeleteDirectDrawObject NtGdiDdDeleteDirectDrawObject + #define sysNtGdiDdQueryDirectDrawObject NtGdiDdQueryDirectDrawObject #endif Modified: trunk/rosapps/dxtest/win32kdxtest/test.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/test.h… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/test.h (original) +++ trunk/rosapps/dxtest/win32kdxtest/test.h Fri Feb 16 19:27:46 2007 @@ -1,5 +1,71 @@ + + +HANDLE test_NtGdiDdCreateDirectDrawObject(); +void test_NtGdiDdDeleteDirectDrawObject(HANDLE hDirectDrawLocal); +void test_NtGdiDdQueryDirectDrawObject( HANDLE hDirectDrawLocal); + + HANDLE sysNtGdiDdCreateDirectDrawObject(HDC hdc); +BOOL sysNtGdiDdDeleteDirectDrawObject( HANDLE hDirectDrawLocal); +BOOL sysNtGdiDdQueryDirectDrawObject( HANDLE hDirectDrawLocal, DD_HALINFO *pHalInfo, + DWORD *pCallBackFlags, + LPD3DNTHAL_CALLBACKS puD3dCallbacks, + LPD3DNTHAL_GLOBALDRIVERDATA puD3dDriverData, + PDD_D3DBUFCALLBACKS puD3dBufferCallbacks, + LPDDSURFACEDESC puD3dTextureFormats, + DWORD *puNumHeaps, VIDEOMEMORY *puvmList, + DWORD *puNumFourCC, DWORD *puFourCC); + HANDLE NtGdiDdCreateDirectDrawObject(HDC hdc); -void test_NtGdiDdCreateDirectDrawObject(); +BOOL NtGdiDdDeleteDirectDrawObject( HANDLE hDirectDrawLocal); +BOOL NtGdiDdQueryDirectDrawObject( HANDLE hDirectDrawLocal, DD_HALINFO *pHalInfo, + DWORD *pCallBackFlags, + LPD3DNTHAL_CALLBACKS puD3dCallbacks, + LPD3DNTHAL_GLOBALDRIVERDATA puD3dDriverData, + PDD_D3DBUFCALLBACKS puD3dBufferCallbacks, + LPDDSURFACEDESC puD3dTextureFormats, + DWORD *puNumHeaps, VIDEOMEMORY *puvmList, + DWORD *puNumFourCC, DWORD *puFourCC); + + + +#define testing_eq(input,value,counter,text) \ + if (input == value) \ + { \ + counter++; \ + printf("FAIL ret=%s, %d != %d )\n",text,input,value); \ + } + + +#define testing_noteq(input,value,counter,text) \ + if (input != value) \ + { \ + counter++; \ + printf("FAIL ret=%s, %d == %d )\n",text,input,value); \ + } + + +#define show_status(counter, text) \ + if (counter == 0) \ + { \ + printf("End testing of %s Status : ok\n\n",text); \ + } \ + else \ + { \ + printf("End testing of %s Status : fail\n\n",text); \ + } + + +#if !defined(__REACTOS__) + +#define win_syscall(inValue,outValue,syscallid) \ + __asm { mov eax, syscallid }; \ + __asm { lea edx, [inValue] }; \ + __asm { int 0x2E }; \ + __asm { mov outValue,eax}; + + + +#endif Modified: trunk/rosapps/dxtest/win32kdxtest/win32kdxtest_vc8_auto.vcproj URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/win32k… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/win32kdxtest_vc8_auto.vcproj (original) +++ trunk/rosapps/dxtest/win32kdxtest/win32kdxtest_vc8_auto.vcproj Fri Feb 16 19:27:46 2007 @@ -592,6 +592,10 @@ RelativePath=".\Windows2000Sp4.h" > </File> + <File + RelativePath=".\windowsos.h" + > + </File> </Filter> <Filter Name="Header Files" Added: trunk/rosapps/dxtest/win32kdxtest/windowsos.h URL: http://svn.reactos.org/svn/reactos/trunk/rosapps/dxtest/win32kdxtest/window… ============================================================================== --- trunk/rosapps/dxtest/win32kdxtest/windowsos.h (added) +++ trunk/rosapps/dxtest/win32kdxtest/windowsos.h Fri Feb 16 19:27:46 2007 @@ -1,0 +1,32 @@ + +#if !defined(__REACTOS__) + + HANDLE sysNtGdiDdCreateDirectDrawObject(HDC hdc) + { + INT retValue; + win_syscall(hdc,retValue, syscallid_NtGdiDdCreateDirectDrawObject); + return retValue; + } + + BOOL sysNtGdiDdDeleteDirectDrawObject(HANDLE hDirectDrawLocal) + { + INT retValue; + win_syscall(hDirectDrawLocal,retValue, syscallid_NtGdiDdDeleteDirectDrawObject); + return retValue; + } + + BOOL sysNtGdiDdQueryDirectDrawObject( HANDLE hDirectDrawLocal, DD_HALINFO *pHalInfo, + DWORD *pCallBackFlags, + LPD3DNTHAL_CALLBACKS puD3dCallbacks, + LPD3DNTHAL_GLOBALDRIVERDATA puD3dDriverData, + PDD_D3DBUFCALLBACKS puD3dBufferCallbacks, + LPDDSURFACEDESC puD3dTextureFormats, + DWORD *puNumHeaps, VIDEOMEMORY *puvmList, + DWORD *puNumFourCC, DWORD *puFourCC) + { + INT retValue; + win_syscall(hDirectDrawLocal,retValue, syscallid_NtGdiDdQueryDirectDrawObject); + return retValue; + } + +#endif Propchange: trunk/rosapps/dxtest/win32kdxtest/windowsos.h ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[mbosma] 25813: Use XML file from trunk.
by mbosma＠svn.reactos.org 16 Feb '07

16 Feb '07

Author: mbosma Date: Fri Feb 16 14:17:28 2007 New Revision: 25813 URL: http://svn.reactos.org/svn/reactos?rev=25813&view=rev Log: Use XML file from trunk. Modified: branches/ros-branch-0_3_1/reactos/base/applications/downloader/downloader.xml Modified: branches/ros-branch-0_3_1/reactos/base/applications/downloader/downloader.xml URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_1/reactos/base/a… ============================================================================== --- branches/ros-branch-0_3_1/reactos/base/applications/downloader/downloader.xml (original) +++ branches/ros-branch-0_3_1/reactos/base/applications/downloader/downloader.xml Fri Feb 16 14:17:28 2007 @@ -1,54 +1,90 @@ <tree Version="1">  <category name="Internet & Network" icon="1"> - <application name="Firefox"> + <application name="Firefox 1.5"> + <regname>Mozilla Firefox (1.5)</regname> + <licence>MPL/GPL/LGPL</licence> + <version>1.5.0.9</version> + <description>The most popular and one of the best free WebBrowsers out there.</description> + <location>http://ftp-mozilla.netscape.com/pub/mozilla.org/firefox/releases/1.5.0.9/wi…</location> + </application> + <application name="Firefox 2.0"> + <regname>Mozilla Firefox (2.0.0.1)</regname> + <licence>MPL/GPL/LGPL</licence> + <version>2.0.0.1</version> <description>The most popular and one of the best free WebBrowsers out there.</description> <location>http://ftp-mozilla.netscape.com/pub/mozilla.org/firefox/releases/latest/win…</location> </application> <application name="Thunderbird"> + <regname>Mozilla Thunderbird (1.5)</regname> + <licence>MPL/GPL/LGPL</licence> + <version>1.5.0.9</version> <description>The most popular and one of the best free MailClients out there.</description> <location>http://ftp-mozilla.netscape.com/pub/mozilla.org/thunderbird/releases/latest…</location> </application> <application name="SeaMonkey"> + <regname>SeaMonkey (1.0.7)</regname> + <version>1.0.7</version> <description>Mozilla Suite is alive. This is the one and only Browser, Mail, Chat, Composer bundle you will ever need.</description> <location>http://ftp-mozilla.netscape.com/pub/mozilla.org/seamonkey/releases/1.0.7/se…</location> + </application> + <application name="Mozilla ActiveX Control"> + <regname>Mozilla ActiveX Control v1.7.12 (ReactOS special)</regname> + <version>1.7.12</version> + <description>Essential Component to get ReactOS Explorer's and other application's Internet Browsing feature running.</description> + <location>http://ovh.dl.sourceforge.net/sourceforge/reactos/MozillaControl1712-ReactO…</location> + </application> + <application name="Off By One Browser"> + <regname>The Off By One Web Browser</regname> + <description>The Off By One Browser is a very small and fast web browser with full HTML 3.2 support.</description> + <location>http://offbyone.com/offbyone/images/OffByOneSetup.exe</location> </application> <application name="Samba TNG"> <description>This tool allows you to access your Windows shared folders/printers with ReactOS.</description> <location>http://svn.reactos.org/packages/samba-tng.exe</location> </application> - <application name="Mozilla ActiveX Control"> - <description>Essential Component to get ReactOS Explorer's and other application's Internet Browsing feature running.</description> - <location>http://ovh.dl.sourceforge.net/sourceforge/reactos/MozillaControl1712-ReactO…</location> - </application> <application name="Miranda IM"> + <regname>Miranda IM</regname> + <version>0.5.1</version> <description>Open source multiprotocol instant messaging application - May not work completely.</description> <location>http://ovh.dl.sourceforge.net/sourceforge/miranda/miranda-im-v0.5.1-unicode…</location> </application> <application name="Putty"> + <regname>PuTTY version 0.59</regname> + <licence>MIT</licence> + <version>0.59</version> <description>A free SSH, Telnet, rlogin, and raw TCP client.</description> - <location>http://the.earth.li/~sgtatham/putty/latest/x86/putty-0.58-installer.exe</location> + <location>http://the.earth.li/~sgtatham/putty/latest/x86/putty-0.59-installer.exe</location> </application> </category> <category name="Office" icon="2"> <application name="Abiword"> + <regname>"AbiWord 2.4.1 (remove only)"</regname> + <version>2.4.1</version> <description>Word processor.</description> <location>http://www.abiword.org/downloads/abiword/2.4.1/Windows/abiword-setup-2.4.1.…</location> </application> <application name="OpenOffice"> + <regname>OpenOffice.org 2.1</regname> + <version>2.1.0</version> <description>THE Open Source Office Suite.</description> <location>http://ftp.tu-chemnitz.de/pub/openoffice-extended//stable/2.1.0/OOo_2.1.0_W…</location> </application> </category> <category name="Graphics" icon="3"> <application name="IrfanView"> + <regname>IrfanView (remove only)</regname> + <version>3.99</version> <description>Viewer for all kinds of graphics/audio files/video files.</description> <location>http://gd.tuwien.ac.at/graphics/irfanview/iview399.exe</location> </application> <application name="IrfanView Plugins"> + <version>3.99</version> <description>Additional Plugins for supporting more file types.</description> <location>http://irfanview.tuwien.ac.at/plugins/irfanview_plugins_399.exe</location> </application> <application name="TuxPaint"> + <regname>Tux Paint 0.9.16</regname> + <version>0.9.16</version> <description>An open source bitmap graphics editor geared towards young children.</description> <location>http://ovh.dl.sourceforge.net/sourceforge/tuxpaint/tuxpaint-0.9.16-win32-in…</location> </application> @@ -57,12 +93,28 @@ </category> <category name="Development" icon="5"> <application name="ReactOS Build Environment"> + <regname>ReactOS Build Environment 0.3.4</regname> + <version>0.3.4</version> <description>Allows you to build the ReactOS Source. For more instructions see ReactOS wiki.</description> - <location>http://ovh.dl.sourceforge.net/sourceforge/reactos/RosBE-0.3.3.exe</location> + <location>http://ovh.dl.sourceforge.net/sourceforge/reactos/RosBE-0.3.4.exe</location> + </application> + <application name="MinGW"> + <regname>MinGW 5.1.3</regname> + <version>5.1.3</version> + <description>A Port of the GNU toolchain with GCC, GDB, GNU make, etc.</description> + <location>http://puzzle.dl.sourceforge.net/sourceforge/mingw/MinGW-5.1.3.exe</location> + </application> + <application name="FreeBASIC"> + <regname>FreeBASIC 0.16b</regname> + <version>0.16b</version> + <description>Open Source Basic Compiler. The Basic syntax is compatible to QBASIC.</description> + <location>http://switch.dl.sourceforge.net/sourceforge/fbc/FreeBASIC-v0.16b-win32.exe</location> </application> </category> <category name="Games & Fun" icon="6"> <application name="ScummVM"> + <regname>ScummVM 0.9.1</regname> + <version>0.9.1</version> <description>SamNMax, Day of Tentacle, etc on ReactOS</description> <location>http://ovh.dl.sourceforge.net/sourceforge/scummvm/scummvm-0.9.1-win32.exe</location> </application> @@ -70,25 +122,61 @@ <description>Nice Clone of Chip's Challenge originally made for the Atari Lynx. Includes free CCLP2 Graphics Pack, so you dont need the copyrighted Original.</description> <location>http://www.muppetlabs.com/~breadbox/pub/software/tworld/tworld-1.3.0-win32-…</location> </application> + <application name="OpenTTD"> + <regname>OpenTTD 0.5.0</regname> + <version>0.5.0-RC5</version> + <description>Open-source-clone of the "Transport Tycoon Deluxe" game-engine. You need a copy of Transport Tycoon.</description> + <location>http://ovh.dl.sourceforge.net/sourceforge/openttd/openttd-0.5.0-RC5-win32.e…</location> + </application> + <application name="LBreakout2">LBreakout2 2.4.1 + <regname>LBreakout2 2.4.1</regname> + <version>2.4.1</version> + <description>Breakout Clone using SDL libs.</description> + <location>http://switch.dl.sourceforge.net/sourceforge/lgames/lbreakout2-2.4.1-win32.…</location> + </application> + <application name="LGeneral"> + <regname>LGeneral 1.1</regname> + <version>1.1</version> + <description>Panzer General Clone using SDL libs.</description> + <location>http://kent.dl.sourceforge.net/sourceforge/lgames/lgeneral-1.1-win32.exe</location> + </application> + <application name="LMarbles"> + <regname>LMarbles 1.0.6</regname> + <version>1.0.6</version> + <description>Atomix Clone using SDL libs.</description> + <location>http://heanet.dl.sourceforge.net/sourceforge/lgames/lmarbles-1.0.6-win32.exe</location> + </application> </category> <category name="Tools" icon="7"> <application name="7-Zip"> + <regname>7-Zip 4.42</regname> + <version>4.42</version> <description>Utility to create and open 7zip, zip, tar, rar and other archive files.</description> <location>http://ovh.dl.sourceforge.net/sourceforge/sevenzip/7z442.exe</location> </application> <application name="uTorrent"> + <regname>µTorrent</regname> + <version>1.6</version> <description>Small and fast Torrent Client.</description> <location>http://download.utorrent.com/1.6/uTorrent-1.6-install.exe</location> </application> <application name="Audio Grabber"> + <regname>Audiograbber 1.83 SE </regname> + <version>1.83 SE</version> <description>A very good CD Ripper/Audio File Converter.</description> <location>http://www.audiograbber.de/files/342677432/agsetup183se.exe</location> </application> </category> <category name="Others" icon="8"> <application name="Simple Direct Media Layer (SDL) Runtime"> + <version>1.2.11</version> <description>Needed for many Open Source Games to run. You need 7-Zip or a similar Utility to extract it.</description> <location>http://ovh.dl.sourceforge.net/sourceforge/libsdl/SDL-1.2.11-win32.zip</location> </application> + <application name="DOSBox"> + <version>0.65</version> + <description>DOSBox is a DOS emulator.</description> + <location>http://puzzle.dl.sourceforge.net/sourceforge/dosbox/DOSBox0.65-win32-instal…</location> + </application> </category> </tree>

1 0

[mbosma] 25812: Lester Kortenhoeven (lester(at)kortenhoeven(dot)de): * CP_ACP changed into CP_UTF8 * removed unnecessary code in xml.c * fix memory leak * add more programs
by mbosma＠svn.reactos.org 16 Feb '07

16 Feb '07

Author: mbosma Date: Fri Feb 16 14:07:28 2007 New Revision: 25812 URL: http://svn.reactos.org/svn/reactos?rev=25812&view=rev Log: Lester Kortenhoeven (lester(at)kortenhoeven(dot)de): * CP_ACP changed into CP_UTF8 * removed unnecessary code in xml.c * fix memory leak * add more programs Modified: trunk/reactos/base/applications/downloader/downloader.xml trunk/reactos/base/applications/downloader/main.c trunk/reactos/base/applications/downloader/xml.c Modified: trunk/reactos/base/applications/downloader/downloader.xml URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/download… ============================================================================== --- trunk/reactos/base/applications/downloader/downloader.xml (original) +++ trunk/reactos/base/applications/downloader/downloader.xml Fri Feb 16 14:07:28 2007 @@ -98,6 +98,18 @@ <description>Allows you to build the ReactOS Source. For more instructions see ReactOS wiki.</description> <location>http://ovh.dl.sourceforge.net/sourceforge/reactos/RosBE-0.3.4.exe</location> </application> + <application name="MinGW"> + <regname>MinGW 5.1.3</regname> + <version>5.1.3</version> + <description>A Port of the GNU toolchain with GCC, GDB, GNU make, etc.</description> + <location>http://puzzle.dl.sourceforge.net/sourceforge/mingw/MinGW-5.1.3.exe</location> + </application> + <application name="FreeBASIC"> + <regname>FreeBASIC 0.16b</regname> + <version>0.16b</version> + <description>Open Source Basic Compiler. The Basic syntax is compatible to QBASIC.</description> + <location>http://switch.dl.sourceforge.net/sourceforge/fbc/FreeBASIC-v0.16b-win32.exe</location> + </application> </category> <category name="Games & Fun" icon="6"> <application name="ScummVM"> @@ -109,6 +121,12 @@ <application name="Tile World"> <description>Nice Clone of Chip's Challenge originally made for the Atari Lynx. Includes free CCLP2 Graphics Pack, so you dont need the copyrighted Original.</description> <location>http://www.muppetlabs.com/~breadbox/pub/software/tworld/tworld-1.3.0-win32-…</location> + </application> + <application name="OpenTTD"> + <regname>OpenTTD 0.5.0</regname> + <version>0.5.0-RC5</version> + <description>Open-source-clone of the "Transport Tycoon Deluxe" game-engine. You need a copy of Transport Tycoon.</description> + <location>http://ovh.dl.sourceforge.net/sourceforge/openttd/openttd-0.5.0-RC5-win32.e…</location> </application> <application name="LBreakout2">LBreakout2 2.4.1 <regname>LBreakout2 2.4.1</regname> @@ -137,7 +155,7 @@ <location>http://ovh.dl.sourceforge.net/sourceforge/sevenzip/7z442.exe</location> </application> <application name="uTorrent"> - <regname>µTorrent</regname>  + <regname>µTorrent</regname> <version>1.6</version> <description>Small and fast Torrent Client.</description> <location>http://download.utorrent.com/1.6/uTorrent-1.6-install.exe</location> @@ -151,8 +169,14 @@ </category> <category name="Others" icon="8"> <application name="Simple Direct Media Layer (SDL) Runtime"> + <version>1.2.11</version> <description>Needed for many Open Source Games to run. You need 7-Zip or a similar Utility to extract it.</description> <location>http://ovh.dl.sourceforge.net/sourceforge/libsdl/SDL-1.2.11-win32.zip</location> </application> + <application name="DOSBox"> + <version>0.65</version> + <description>DOSBox is a DOS emulator.</description> + <location>http://puzzle.dl.sourceforge.net/sourceforge/dosbox/DOSBox0.65-win32-instal…</location> + </application> </category> </tree> Modified: trunk/reactos/base/applications/downloader/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/download… ============================================================================== --- trunk/reactos/base/applications/downloader/main.c (original) +++ trunk/reactos/base/applications/downloader/main.c Fri Feb 16 14:07:28 2007 @@ -19,6 +19,7 @@ HBITMAP hLogo, hUnderline; WCHAR* DescriptionHeadline = L""; WCHAR* DescriptionText = L""; +WCHAR ApplicationText[700]; struct Category Root; struct Application* SelectedApplication; @@ -27,6 +28,7 @@ BOOL ProcessXML (const char* filename, struct Category* Root); VOID FreeTree (struct Category* Node); WCHAR Strings [STRING_COUNT][MAX_STRING_LENGHT]; + BOOL getUninstaller(WCHAR* RegName, WCHAR* Uninstaller) { @@ -131,9 +133,6 @@ if(StrCmpW(CurrentApplication->RegName,L"")) { if(getUninstaller(CurrentApplication->RegName, Uninstaller)) Insert.item.iImage = 9; - } else { - if(getUninstaller(CurrentApplication->Name, Uninstaller)) - Insert.item.iImage = 9; } SendMessage(hwnd, TVM_INSERTITEM, 0, (LPARAM)&Insert); CurrentApplication = CurrentApplication->Next; @@ -333,9 +332,6 @@ if(StrCmpW(SelectedApplication->RegName, L"")) { if(getUninstaller(SelectedApplication->RegName, Uninstaller)) startUninstaller(Uninstaller); - } else { - if(getUninstaller(SelectedApplication->Name, Uninstaller)) - startUninstaller(Uninstaller); } } } @@ -367,33 +363,29 @@ SelectedApplication = (struct Application*) ((LPNMTREEVIEW)lParam)->itemNew.lParam; if(SelectedApplication) { - DescriptionText = calloc(700,sizeof(WCHAR)); + ApplicationText[0]=L'\0'; if(StrCmpW(SelectedApplication->Version, L"")) { - StrCatW(DescriptionText, Strings[IDS_VERSION]); - StrCatW(DescriptionText, SelectedApplication->Version); - StrCatW(DescriptionText, L"\n"); + StrCatW(ApplicationText, Strings[IDS_VERSION]); + StrCatW(ApplicationText, SelectedApplication->Version); + StrCatW(ApplicationText, L"\n"); } if(StrCmpW(SelectedApplication->Licence, L"")) { - StrCatW(DescriptionText, Strings[IDS_LICENCE]); - StrCatW(DescriptionText, SelectedApplication->Licence); - StrCatW(DescriptionText, L"\n"); + StrCatW(ApplicationText, Strings[IDS_LICENCE]); + StrCatW(ApplicationText, SelectedApplication->Licence); + StrCatW(ApplicationText, L"\n"); } if(StrCmpW(SelectedApplication->Maintainer, L"")) { - StrCatW(DescriptionText, Strings[IDS_MAINTAINER]); - StrCatW(DescriptionText, SelectedApplication->Maintainer); - StrCatW(DescriptionText, L"\n"); + StrCatW(ApplicationText, Strings[IDS_MAINTAINER]); + StrCatW(ApplicationText, SelectedApplication->Maintainer); + StrCatW(ApplicationText, L"\n"); } if(StrCmpW(SelectedApplication->Licence, L"") || StrCmpW(SelectedApplication->Version, L"") || StrCmpW(SelectedApplication->Maintainer, L"")) - StrCatW(DescriptionText, L"\n"); - StrCatW(DescriptionText, SelectedApplication->Description); - ShowMessage(SelectedApplication->Name, DescriptionText); + StrCatW(ApplicationText, L"\n"); + StrCatW(ApplicationText, SelectedApplication->Description); + ShowMessage(SelectedApplication->Name, ApplicationText); WCHAR Uninstaller[200]; if(StrCmpW(SelectedApplication->RegName, L"")) { if(getUninstaller(SelectedApplication->RegName, Uninstaller)) { - bShowUninstaller = TRUE; - } - } else { - if(getUninstaller(SelectedApplication->Name, Uninstaller)) { bShowUninstaller = TRUE; } } Modified: trunk/reactos/base/applications/downloader/xml.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/download… ============================================================================== --- trunk/reactos/base/applications/downloader/xml.c (original) +++ trunk/reactos/base/applications/downloader/xml.c Fri Feb 16 14:07:28 2007 @@ -9,6 +9,7 @@ #include <string.h> #include <stdio.h> #include <windows.h> +#include <shlwapi.h> #include "structures.h" #include "resources.h" @@ -54,7 +55,7 @@ { if(!strcmp(arg[i], "name")) { - MultiByteToWideChar(CP_ACP, 0, arg[i+1], -1, Current->Name, 0x100); + MultiByteToWideChar(CP_UTF8, 0, arg[i+1], -1, Current->Name, 0x100); } if(!strcmp(arg[i], "icon")) { @@ -81,20 +82,11 @@ CurrentApplication = Current->Apps; } - int currentlengt = lstrlenW(CurrentApplication->Maintainer); - MultiByteToWideChar(CP_ACP, 0, 0, 0, &CurrentApplication->Maintainer[currentlengt], 0x100-currentlengt); - currentlengt = lstrlenW(CurrentApplication->RegName); - MultiByteToWideChar(CP_ACP, 0, 0, 0, &CurrentApplication->RegName[currentlengt], 0x100-currentlengt); - currentlengt = lstrlenW(CurrentApplication->Version); - MultiByteToWideChar(CP_ACP, 0, 0, 0, &CurrentApplication->Version[currentlengt], 0x100-currentlengt); - currentlengt = lstrlenW(CurrentApplication->Licence); - MultiByteToWideChar(CP_ACP, 0, 0, 0, &CurrentApplication->Licence[currentlengt], 0x100-currentlengt); - for (i=0; arg[i]; i+=2) { if(!strcmp(arg[i], "name")) { - MultiByteToWideChar(CP_ACP, 0, arg[i+1], -1, CurrentApplication->Name, 0x100); + MultiByteToWideChar(CP_UTF8, 0, arg[i+1], -1, CurrentApplication->Name, 0x100); } } } @@ -115,32 +107,32 @@ if(!strcmp(CurrentTag, "maintainer")) { int currentlengt = lstrlenW(CurrentApplication->Maintainer); - MultiByteToWideChar(CP_ACP, 0, data, len, &CurrentApplication->Maintainer[currentlengt], 0x100-currentlengt); + MultiByteToWideChar(CP_UTF8, 0, data, len, &CurrentApplication->Maintainer[currentlengt], 0x100-currentlengt); } else if(!strcmp(CurrentTag, "regname")) { int currentlengt = lstrlenW(CurrentApplication->RegName); - MultiByteToWideChar(CP_ACP, 0, data, len, &CurrentApplication->RegName[currentlengt], 0x100-currentlengt); + MultiByteToWideChar(CP_UTF8, 0, data, len, &CurrentApplication->RegName[currentlengt], 0x100-currentlengt); } else if(!strcmp(CurrentTag, "description")) { int currentlengt = lstrlenW(CurrentApplication->Description); - MultiByteToWideChar(CP_ACP, 0, data, len, &CurrentApplication->Description[currentlengt], 0x400-currentlengt); + MultiByteToWideChar(CP_UTF8, 0, data, len, &CurrentApplication->Description[currentlengt], 0x400-currentlengt); } else if(!strcmp(CurrentTag, "location")) { int currentlengt = lstrlenW(CurrentApplication->Location); - MultiByteToWideChar(CP_ACP, 0, data, len, &CurrentApplication->Location[currentlengt], 0x100-currentlengt); + MultiByteToWideChar(CP_UTF8, 0, data, len, &CurrentApplication->Location[currentlengt], 0x100-currentlengt); } else if(!strcmp(CurrentTag, "version")) { int currentlengt = lstrlenW(CurrentApplication->Version); - MultiByteToWideChar(CP_ACP, 0, data, len, &CurrentApplication->Version[currentlengt], 0x400-currentlengt); + MultiByteToWideChar(CP_UTF8, 0, data, len, &CurrentApplication->Version[currentlengt], 0x400-currentlengt); } else if(!strcmp(CurrentTag, "licence")) { int currentlengt = lstrlenW(CurrentApplication->Licence); - MultiByteToWideChar(CP_ACP, 0, data, len, &CurrentApplication->Licence[currentlengt], 0x100-currentlengt); + MultiByteToWideChar(CP_UTF8, 0, data, len, &CurrentApplication->Licence[currentlengt], 0x100-currentlengt); } }

1 0

[fireball] 25811: Merge 25810
by fireball＠svn.reactos.org 15 Feb '07

15 Feb '07

Author: fireball Date: Fri Feb 16 01:00:37 2007 New Revision: 25811 URL: http://svn.reactos.org/svn/reactos?rev=25811&view=rev Log: Merge 25810 Modified: branches/ros-branch-0_3_1/reactos/media/inf/netamd.inf branches/ros-branch-0_3_1/reactos/media/inf/netisa.inf branches/ros-branch-0_3_1/reactos/media/inf/netrtpnt.inf Modified: branches/ros-branch-0_3_1/reactos/media/inf/netamd.inf URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_1/reactos/media/… ============================================================================== --- branches/ros-branch-0_3_1/reactos/media/inf/netamd.inf (original) +++ branches/ros-branch-0_3_1/reactos/media/inf/netamd.inf Fri Feb 16 01:00:37 2007 @@ -27,7 +27,7 @@ CopyFiles = PCNet_CopyFiles.NT [PCNet_AddReg.NT] -HKR,,Characteristics,0x00010001,0x0000000 +HKR,,Characteristics,0x00010001,0x00000004 ; NCF_PHYSICAL HKR,,BUS_TO_SCAN,,"ALL" HKR,,BUSTIMER,,"0" HKR,,BUSTYPE,,"5" Modified: branches/ros-branch-0_3_1/reactos/media/inf/netisa.inf URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_1/reactos/media/… ============================================================================== --- branches/ros-branch-0_3_1/reactos/media/inf/netisa.inf (original) +++ branches/ros-branch-0_3_1/reactos/media/inf/netisa.inf Fri Feb 16 01:00:37 2007 @@ -9,7 +9,7 @@ Class = Net ClassGUID = {4D36E972-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 02/15/2007,1.01.0.0 +DriverVer = 02/15/2007,1.02 [DestinationDirs] DefaultDestDir = 12 @@ -27,7 +27,7 @@ CopyFiles = NE2000_CopyFiles.NT [NE2000_AddReg.NT] -HKR,,Characteristics,0x00010001,0x0000000 +HKR,,Characteristics,0x00010001,0x00000004 ; NCF_PHYSICAL HKR,,Port,0x00000000,"c100" HKR,,Irq,0x00000000,"B" HKR,,NetworkAddress,0x00000000,"001122334455" Modified: branches/ros-branch-0_3_1/reactos/media/inf/netrtpnt.inf URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_1/reactos/media/… ============================================================================== --- branches/ros-branch-0_3_1/reactos/media/inf/netrtpnt.inf (original) +++ branches/ros-branch-0_3_1/reactos/media/inf/netrtpnt.inf Fri Feb 16 01:00:37 2007 @@ -9,7 +9,7 @@ Class = Net ClassGUID = {4D36E972-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 11/14/2005,1.00 +DriverVer = 02/15/2007,1.01 [DestinationDirs] DefaultDestDir = 12 @@ -27,7 +27,7 @@ CopyFiles = NE2000_CopyFiles.NT [NE2000_AddReg.NT] -HKR,,Characteristics,0x00010001,0x00000000 +HKR,,Characteristics,0x00010001,0x00000004 ; NCF_PHYSICAL HKR,,BusType,0x00000000,"5" HKR,,Port,0x00000000,"c100" HKR,,Irq,0x00000000,"B"

1 0

[hpoussin] 25810: Set correct value for Characteristics (tested by Colin_Finck on IRC)
by hpoussin＠svn.reactos.org 15 Feb '07

15 Feb '07

Author: hpoussin Date: Thu Feb 15 23:39:33 2007 New Revision: 25810 URL: http://svn.reactos.org/svn/reactos?rev=25810&view=rev Log: Set correct value for Characteristics (tested by Colin_Finck on IRC) Modified: trunk/reactos/media/inf/netamd.inf trunk/reactos/media/inf/netisa.inf trunk/reactos/media/inf/netrtpnt.inf Modified: trunk/reactos/media/inf/netamd.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/netamd.inf?rev=2… ============================================================================== --- trunk/reactos/media/inf/netamd.inf (original) +++ trunk/reactos/media/inf/netamd.inf Thu Feb 15 23:39:33 2007 @@ -27,7 +27,7 @@ CopyFiles = PCNet_CopyFiles.NT [PCNet_AddReg.NT] -HKR,,Characteristics,0x00010001,0x0000000 +HKR,,Characteristics,0x00010001,0x00000004 ; NCF_PHYSICAL HKR,,BUS_TO_SCAN,,"ALL" HKR,,BUSTIMER,,"0" HKR,,BUSTYPE,,"5" Modified: trunk/reactos/media/inf/netisa.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/netisa.inf?rev=2… ============================================================================== --- trunk/reactos/media/inf/netisa.inf (original) +++ trunk/reactos/media/inf/netisa.inf Thu Feb 15 23:39:33 2007 @@ -9,7 +9,7 @@ Class = Net ClassGUID = {4D36E972-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 02/15/2007,1.01.0.0 +DriverVer = 02/15/2007,1.02 [DestinationDirs] DefaultDestDir = 12 @@ -27,7 +27,7 @@ CopyFiles = NE2000_CopyFiles.NT [NE2000_AddReg.NT] -HKR,,Characteristics,0x00010001,0x0000000 +HKR,,Characteristics,0x00010001,0x00000004 ; NCF_PHYSICAL HKR,,Port,0x00000000,"c100" HKR,,Irq,0x00000000,"B" HKR,,NetworkAddress,0x00000000,"001122334455" Modified: trunk/reactos/media/inf/netrtpnt.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/netrtpnt.inf?rev… ============================================================================== --- trunk/reactos/media/inf/netrtpnt.inf (original) +++ trunk/reactos/media/inf/netrtpnt.inf Thu Feb 15 23:39:33 2007 @@ -9,7 +9,7 @@ Class = Net ClassGUID = {4D36E972-E325-11CE-BFC1-08002BE10318} Provider = %ReactOS% -DriverVer = 11/14/2005,1.00 +DriverVer = 02/15/2007,1.01 [DestinationDirs] DefaultDestDir = 12 @@ -27,7 +27,7 @@ CopyFiles = NE2000_CopyFiles.NT [NE2000_AddReg.NT] -HKR,,Characteristics,0x00010001,0x00000000 +HKR,,Characteristics,0x00010001,0x00000004 ; NCF_PHYSICAL HKR,,BusType,0x00000000,"5" HKR,,Port,0x00000000,"c100" HKR,,Irq,0x00000000,"B"

1 0

[ekohl] 25809: - Declare local functions static and get rid of prototypes by moving functions around. - Clean up the code. No changes to the functionality.
by ekohl＠svn.reactos.org 15 Feb '07

15 Feb '07

Author: ekohl Date: Thu Feb 15 23:24:38 2007 New Revision: 25809 URL: http://svn.reactos.org/svn/reactos?rev=25809&view=rev Log: - Declare local functions static and get rid of prototypes by moving functions around. - Clean up the code. No changes to the functionality. Modified: trunk/reactos/dll/cpl/desk/advappdlg.c trunk/reactos/dll/cpl/desk/appearance.c trunk/reactos/dll/cpl/desk/appearance.h Modified: trunk/reactos/dll/cpl/desk/advappdlg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/advappdlg.c?r… ============================================================================== --- trunk/reactos/dll/cpl/desk/advappdlg.c (original) +++ trunk/reactos/dll/cpl/desk/advappdlg.c Thu Feb 15 23:24:38 2007 @@ -12,193 +12,58 @@ #include "desk.h" #include "appearance.h" -INT_PTR CALLBACK -AdvAppearanceDlgProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) -{ - int iListIndex; - GLOBALS* g; - - switch(uMsg) - { - case WM_INITDIALOG: - { - g = (GLOBALS*)lParam; - SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)g); - AdvAppearanceDlg_Init(hwndDlg); - break; - } - case WM_DESTROY: - { - AdvAppearanceDlg_CleanUp(hwndDlg); - break; - } - case WM_COMMAND: - { - g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - switch(LOWORD(wParam)) - { - case IDOK: - { - SaveCurrentValues(hwndDlg); - EndDialog(hwndDlg, 0); - break; - } - case IDCANCEL: - { - g->ThemeAdv = g->Theme; - EndDialog(hwndDlg, 0); - break; - } - case IDC_ADVAPPEARANCE_ELEMENT: - { - if(HIWORD(wParam) == CBN_SELCHANGE) - { - SaveCurrentValues(hwndDlg); - iListIndex = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETCURSEL, 0, 0); - g->CurrentElement = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETITEMDATA, (WPARAM)iListIndex, 0); - UpdateControls(hwndDlg, g->CurrentElement); - break; - } - break; - } - case IDC_ADVAPPEARANCE_COLOR1_B: - { - GetColor(hwndDlg, g->CurrentElement, 0); - break; - } - case IDC_ADVAPPEARANCE_COLOR2_B: - { - GetColor(hwndDlg, g->CurrentElement, 1); - break; - } - case IDC_ADVAPPEARANCE_FONTCOLOR_B: - { - GetColor(hwndDlg, g->CurrentElement, 2); - break; - } - default: - { - return FALSE; - } - } - break; - } - default: - { - return FALSE; - } - } - return TRUE; -} - - -/* Initialize the advanced appearance dialog */ -void -AdvAppearanceDlg_Init(HWND hwndDlg) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - int i, iElement, iListIndex, iDeskIndex = 0; - TCHAR tstrText[80]; - LOGFONT lfFont; - LOGFONT lfButtonFont; - HFONT hMyFont; - HDC hScreenDC; - - /* Copy the current theme values */ - g->ThemeAdv = g->Theme; - - /* Add the elements to the combo */ - for(iElement = 0; iElement < NUM_ELEMENTS; iElement++) - { - LoadString(hApplet, IDS_ELEMENT_1 + iElement, (LPTSTR)&tstrText, 79); - iListIndex = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_ADDSTRING, 0, (LPARAM)&tstrText); - SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_SETITEMDATA, (WPARAM)iListIndex, (LPARAM)iElement); - } - - /* Get the list index of the desktop element */ - for(iListIndex = 0; iListIndex < NUM_ELEMENTS; iListIndex++) - { - iElement = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETITEMDATA, (WPARAM)iListIndex, 0); - if (iElement == 0) - { - iDeskIndex = iListIndex; - break; - } - } - SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_SETCURSEL, iDeskIndex, 0); - - /* Set colors for the color buttons */ - g->crCOLOR_BTNFACE = g->Theme.crColor[COLOR_BTNFACE]; - g->crCOLOR_BTNTEXT = g->Theme.crColor[COLOR_BTNTEXT]; - g->crCOLOR_BTNSHADOW = g->Theme.crColor[COLOR_BTNSHADOW]; - g->crCOLOR_BTNHIGHLIGHT = g->Theme.crColor[COLOR_BTNHIGHLIGHT]; - - /* Create font for bold button */ - lfButtonFont = g->Theme.lfFont[FONT_DIALOG]; - lfButtonFont.lfWeight = FW_BOLD; - lfButtonFont.lfItalic = FALSE; - hMyFont = CreateFontIndirect(&lfButtonFont); - if (hMyFont) - { - if (g->hBoldFont) - { - DeleteObject(g->hBoldFont); - } - g->hBoldFont = hMyFont; - } - - /* Create font for italic button */ - lfButtonFont.lfWeight = FW_REGULAR; - lfButtonFont.lfItalic = TRUE; - hMyFont = CreateFontIndirect(&lfButtonFont); - if (hMyFont) - { - if (g->hItalicFont) - { - DeleteObject(g->hItalicFont); - } - g->hItalicFont = hMyFont; - } - - /* Set the fonts for the font style buttons */ - SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTBOLD, WM_SETFONT, (WPARAM)g->hBoldFont, (LPARAM)TRUE); - SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTITALIC, WM_SETFONT, (WPARAM)g->hItalicFont, (LPARAM)TRUE); - - /* Draw Bitmaps for the colorbuttons */ - InitColorButtons(hwndDlg); - - /* Make the UpDown control count correctly */ - SendMessage (GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_SIZE_UD), UDM_SETRANGE, 0L, MAKELONG (200, 1)); - - /* Fill font selection combo */ - lfFont.lfCharSet = DEFAULT_CHARSET; - lfFont.lfFaceName[0] = (TCHAR)0; - lfFont.lfPitchAndFamily = 0; - hScreenDC = GetDC(0); - EnumFontFamiliesEx(hScreenDC, &lfFont, (FONTENUMPROC)EnumFontFamExProc, (LPARAM)GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_FONT_C), 0); - ReleaseDC(0, hScreenDC); - - /* Fill font size combo */ - TCHAR Size[4]; - for (i = 6; i <= 24; i++) - { - SetDlgItemInt(hwndDlg, IDC_CONVERT, i, FALSE); - GetDlgItemText(hwndDlg, IDC_CONVERT, (LPTSTR)&Size, 3); - SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTSIZE_E, CB_ADDSTRING, 0, (LPARAM)&Size); - } - - /* Update the controls */ - iListIndex = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETCURSEL, 0, 0); - g->CurrentElement = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETITEMDATA, (WPARAM)iListIndex, 0); - UpdateControls(hwndDlg, g->CurrentElement); - return; -} + + +/* Draw the current color on the color picker buttons */ +static VOID +UpdateButtonColor(HWND hwndDlg, GLOBALS* g, INT ID, INT nButton, INT nColor) +{ + HDC hdcColorButton, hdcCompat; + RECT rect; + HBRUSH hbrush; + HWND hwndColorButton; + COLORREF crColor = g->ThemeAdv.crColor[nColor]; + HGDIOBJ hgdiTmp; + + if (nColor != -1) + { + /* Create a DC to draw on */ + hwndColorButton = GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_COLOR1_B); + hdcColorButton = GetDC(hwndColorButton); + hdcCompat = CreateCompatibleDC(hdcColorButton); + ReleaseDC(hwndColorButton, hdcColorButton); + + /* Select the button image to it */ + hgdiTmp = SelectObject(hdcCompat, g->hbmpColor[nButton]); + + /* Create a brush and draw the rectangle */ + rect.left = 2; + rect.top = 2; + rect.right = 22; + rect.bottom = 13; + hbrush = CreateSolidBrush(crColor); + FillRect(hdcCompat, &rect, hbrush); + DeleteObject(hbrush); + + /* hdcCompat is not needed anymore */ + SelectObject(hdcCompat,hgdiTmp); + DeleteDC(hdcCompat); + + SendDlgItemMessage(hwndDlg, ID, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)g->hbmpColor[nButton]); + EnableWindow(GetDlgItem(hwndDlg, ID), TRUE); + } + else + { + SendDlgItemMessage(hwndDlg, ID, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)NULL); + EnableWindow(GetDlgItem(hwndDlg, ID), FALSE); + } +} + /* Create the basic bitmaps for the color picker buttons */ -void -InitColorButtons(HWND hwndDlg) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); +static VOID +InitColorButtons(HWND hwndDlg, GLOBALS* g) +{ INT i; HDC hdcColorButton, hdcCompat; RECT rect; @@ -209,7 +74,7 @@ const POINT Points[3] = {{29,6},{33,6},{31,8}}; - hwndColorButton = GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_COLOR1_B); + hwndColorButton = GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_COLOR1_B); hdcColorButton = GetDC(hwndColorButton); for (i = 0; i <= 2; i++) { @@ -223,13 +88,19 @@ hgdiTemp = SelectObject(hdcCompat, g->hbmpColor[i]); /* Draw the buttons background color */ - rect.left = 0; rect.top = 0; rect.right = 36; rect.bottom = 15; + rect.left = 0; + rect.top = 0; + rect.right = 36; + rect.bottom = 15; hbrush = CreateSolidBrush(g->crCOLOR_BTNFACE); FillRect(hdcCompat, &rect, hbrush); DeleteObject(hbrush); /* Draw the rectangle */ - rect.left = 1; rect.top = 1; rect.right = 23; rect.bottom = 14; + rect.left = 1; + rect.top = 1; + rect.right = 23; + rect.bottom = 14; hbrush = CreateSolidBrush(g->crCOLOR_BTNTEXT); FillRect(hdcCompat, &rect, hbrush); DeleteObject(hbrush); @@ -260,52 +131,48 @@ /* FIXME: HACK, see Points definition */ Polygon(hdcCompat, Points, 3); - /* Cleanup */ + /* Cleanup */ SelectObject(hdcCompat,hgdiTemp); DeleteDC(hdcCompat); DeleteObject(hPen); DeleteObject(hbrush); } + ReleaseDC(hwndColorButton, hdcColorButton); /* Set the images of the buttons */ SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_COLOR1_B, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)g->hbmpColor[0]); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_COLOR2_B, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)g->hbmpColor[1]); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTCOLOR_B, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)g->hbmpColor[2]); - return; -} - -void -AdvAppearanceDlg_CleanUp(HWND hwndDlg) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - DeleteObject(g->hBoldFont); - DeleteObject(g->hItalicFont); - return; -} +} + /* This is the callback function to add the installed fonts to the font combo */ -int CALLBACK -EnumFontFamExProc( - ENUMLOGFONTEX *lpelfe, - NEWTEXTMETRICEX *lpntme, - DWORD dwFontType, - LPARAM lParam) +static int CALLBACK +EnumFontFamExProc(ENUMLOGFONTEX *lpelfe, NEWTEXTMETRICEX *lpntme, DWORD dwFontType, LPARAM lParam) { /* Don't enumerate more than 100 fonts */ - if (SendMessage((HWND)lParam, CB_GETCOUNT, 0, 0) >= 100) return(0); + if (SendMessage((HWND)lParam, CB_GETCOUNT, 0, 0) >= 100) + return 0; /* Only add the string once */ - if (SendMessage((HWND)lParam, CB_FINDSTRINGEXACT, -1, (WPARAM)&(lpelfe->elfLogFont.lfFaceName)) != CB_ERR) return(2); + if (SendMessage((HWND)lParam, CB_FINDSTRINGEXACT, -1, (WPARAM)&(lpelfe->elfLogFont.lfFaceName)) != CB_ERR) + return 2; + SendMessage((HWND)lParam, CB_ADDSTRING, 0, (WPARAM)&(lpelfe->elfLogFont.lfFaceName)); - return(1); -} + + return 1; +} + /* Update all the controls with the current values for the selected screen element */ -void -UpdateControls(HWND hwndDlg, int iElement) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); +static VOID +UpdateControls(HWND hwndDlg, GLOBALS *g) +{ + INT iElement; + HDC hdcDlg; + + iElement = g->CurrentElement; /* First enable / disable the controls */ EnableWindow(GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_SIZE_E), (g_Assignment[iElement].Size != -1)); @@ -322,16 +189,16 @@ EnableWindow(GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_FONTITALIC), (g_Assignment[iElement].Font != -1)); /* Update the colors of the color buttons */ - UpdateButtonColor(hwndDlg, IDC_ADVAPPEARANCE_COLOR1_B, 0, g_Assignment[iElement].Color1); - UpdateButtonColor(hwndDlg, IDC_ADVAPPEARANCE_COLOR2_B, 1, g_Assignment[iElement].Color2); - UpdateButtonColor(hwndDlg, IDC_ADVAPPEARANCE_FONTCOLOR_B, 2, g_Assignment[iElement].FontColor); + UpdateButtonColor(hwndDlg, g, IDC_ADVAPPEARANCE_COLOR1_B, 0, g_Assignment[iElement].Color1); + UpdateButtonColor(hwndDlg, g, IDC_ADVAPPEARANCE_COLOR2_B, 1, g_Assignment[iElement].Color2); + UpdateButtonColor(hwndDlg, g, IDC_ADVAPPEARANCE_FONTCOLOR_B, 2, g_Assignment[iElement].FontColor); if (g_Assignment[iElement].Size != -1) SetDlgItemInt(hwndDlg, IDC_ADVAPPEARANCE_SIZE_E, g->ThemeAdv.Size[g_Assignment[iElement].Size], FALSE); else SetDlgItemText(hwndDlg, IDC_ADVAPPEARANCE_SIZE_E, TEXT("")); - HDC hdcDlg = GetDC(hwndDlg); + hdcDlg = GetDC(hwndDlg); if (g_Assignment[iElement].Font != -1) { LOGFONT lfFont = g->ThemeAdv.lfFont[g_Assignment[iElement].Font]; @@ -341,26 +208,30 @@ SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONT_C, CB_FINDSTRINGEXACT, -1, (WPARAM)lfFont.lfFaceName); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTBOLD, BM_SETCHECK, g->ThemeAdv.lfFont[g_Assignment[iElement].Font].lfWeight == FW_BOLD?1:0, 0); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTITALIC, BM_SETCHECK, g->ThemeAdv.lfFont[g_Assignment[iElement].Font].lfItalic, 0); - } else { + } + else + { SetDlgItemText(hwndDlg, IDC_ADVAPPEARANCE_FONT_C, NULL); SetDlgItemText(hwndDlg, IDC_ADVAPPEARANCE_FONTSIZE_E, NULL); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTBOLD, BM_SETCHECK, 0, 0); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTITALIC, BM_SETCHECK, 0, 0); } + ReleaseDC(hwndDlg, hdcDlg); - return; -} - -void -SaveCurrentValues(HWND hwndDlg) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); +} + + +static VOID +SaveCurrentValues(HWND hwndDlg, GLOBALS *g) +{ BOOL bTranslated; HDC hdcDlg = GetDC(hwndDlg); + if (g_Assignment[g->CurrentElement].Size != -1) { g->ThemeAdv.Size[g_Assignment[g->CurrentElement].Size] = GetDlgItemInt(hwndDlg, IDC_ADVAPPEARANCE_SIZE_E, &bTranslated, FALSE); } + if (g_Assignment[g->CurrentElement].Font != -1) { g->ThemeAdv.lfFont[g_Assignment[g->CurrentElement].Font].lfHeight = -MulDiv(GetDlgItemInt(hwndDlg, IDC_ADVAPPEARANCE_FONTSIZE_E, &bTranslated, FALSE), GetDeviceCaps(hdcDlg, LOGPIXELSY), 72); @@ -368,78 +239,40 @@ g->ThemeAdv.lfFont[g_Assignment[g->CurrentElement].Font].lfItalic = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTITALIC, BM_GETCHECK, 0, 0); GetDlgItemText(hwndDlg, IDC_ADVAPPEARANCE_FONT_C, g->ThemeAdv.lfFont[g_Assignment[g->CurrentElement].Font].lfFaceName, LF_FACESIZE * sizeof(TCHAR)); } + ReleaseDC(hwndDlg, hdcDlg); - return; -} - -/* Draw the current color on the color picker buttons */ -void -UpdateButtonColor(HWND hwndDlg, int ID, int nButton, int nColor) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - HDC hdcColorButton, hdcCompat; - RECT rect; - HBRUSH hbrush; - HWND hwndColorButton; - COLORREF crColor = g->ThemeAdv.crColor[nColor]; - - if(nColor != -1) - { - /* Create a DC to draw on */ - hwndColorButton = GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_COLOR1_B); - hdcColorButton = GetDC(hwndColorButton); - hdcCompat = CreateCompatibleDC(hdcColorButton); - ReleaseDC(hwndColorButton, hdcColorButton); - - /* Select the button image to it */ - HGDIOBJ hgdiTmp = SelectObject(hdcCompat, g->hbmpColor[nButton]); - - /* Create a brush and draw the rectangle */ - rect.left = 2; rect.top = 2; rect.right = 22; rect.bottom = 13; - hbrush = CreateSolidBrush(crColor); - FillRect(hdcCompat, &rect, hbrush); - DeleteObject(hbrush); - - /* hdcCompat is not needed anymore */ - SelectObject(hdcCompat,hgdiTmp); - DeleteDC(hdcCompat); - - SendDlgItemMessage(hwndDlg, ID, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)g->hbmpColor[nButton]); - EnableWindow(GetDlgItem(hwndDlg, ID), TRUE); - } else { - SendDlgItemMessage(hwndDlg, ID, BM_SETIMAGE, (WPARAM)IMAGE_BITMAP, (LPARAM)NULL); - EnableWindow(GetDlgItem(hwndDlg, ID), FALSE); - } - return; -} +} + /* Select a color using a color picker */ -BOOL -GetColor(HWND hwndDlg, int iElement, int nButton) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); +static BOOL +GetColor(HWND hwndDlg, GLOBALS* g, INT nButton) +{ CHOOSECOLOR cc; COLORREF crCustom[16] = { 0 }; COLORREF crColor; - int ID = 0; - int ColorIndex = 0; + INT ID = 0; + INT ColorIndex = 0; /* Get the color index from the element index and button number */ - if (nButton == 0) - { - ColorIndex = g_Assignment[iElement].Color1; - ID = IDC_ADVAPPEARANCE_COLOR1_B; - } - if (nButton == 1) - { - ColorIndex = g_Assignment[iElement].Color2; - ID = IDC_ADVAPPEARANCE_COLOR2_B; - } - if (nButton == 2) - { - ColorIndex = g_Assignment[iElement].FontColor; - ID = IDC_ADVAPPEARANCE_FONTCOLOR_B; - } + switch (nButton) + { + case 0: + ColorIndex = g_Assignment[g->CurrentElement].Color1; + ID = IDC_ADVAPPEARANCE_COLOR1_B; + break; + + case 1: + ColorIndex = g_Assignment[g->CurrentElement].Color2; + ID = IDC_ADVAPPEARANCE_COLOR2_B; + break; + + case 2: + ColorIndex = g_Assignment[g->CurrentElement].FontColor; + ID = IDC_ADVAPPEARANCE_FONTCOLOR_B; + break; + } + crColor = g->ThemeAdv.crColor[ColorIndex]; /* Prepare cc structure */ @@ -459,9 +292,186 @@ g->ThemeAdv.crColor[ColorIndex] = cc.rgbResult; if (crColor != cc.rgbResult) { - UpdateButtonColor(hwndDlg, ID, nButton, ColorIndex); - return(TRUE); + UpdateButtonColor(hwndDlg, g, ID, nButton, ColorIndex); + return TRUE; } } - return(FALSE); -} + + return FALSE; +} + + +/* Initialize the advanced appearance dialog */ +static VOID +AdvAppearanceDlg_Init(HWND hwndDlg, GLOBALS *g) +{ + INT i, iElement, iListIndex, iDeskIndex = 0; + TCHAR tstrText[80]; + LOGFONT lfFont; + LOGFONT lfButtonFont; + HFONT hMyFont; + HDC hScreenDC; + TCHAR Size[4]; + + /* Copy the current theme values */ + g->ThemeAdv = g->Theme; + + /* Add the elements to the combo */ + for (iElement = 0; iElement < NUM_ELEMENTS; iElement++) + { + LoadString(hApplet, IDS_ELEMENT_1 + iElement, (LPTSTR)&tstrText, 79); + iListIndex = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_ADDSTRING, 0, (LPARAM)&tstrText); + SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_SETITEMDATA, (WPARAM)iListIndex, (LPARAM)iElement); + } + + /* Get the list index of the desktop element */ + for (iListIndex = 0; iListIndex < NUM_ELEMENTS; iListIndex++) + { + iElement = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETITEMDATA, (WPARAM)iListIndex, 0); + if (iElement == 0) + { + iDeskIndex = iListIndex; + break; + } + } + + SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_SETCURSEL, iDeskIndex, 0); + + /* Set colors for the color buttons */ + g->crCOLOR_BTNFACE = g->Theme.crColor[COLOR_BTNFACE]; + g->crCOLOR_BTNTEXT = g->Theme.crColor[COLOR_BTNTEXT]; + g->crCOLOR_BTNSHADOW = g->Theme.crColor[COLOR_BTNSHADOW]; + g->crCOLOR_BTNHIGHLIGHT = g->Theme.crColor[COLOR_BTNHIGHLIGHT]; + + /* Create font for bold button */ + lfButtonFont = g->Theme.lfFont[FONT_DIALOG]; + lfButtonFont.lfWeight = FW_BOLD; + lfButtonFont.lfItalic = FALSE; + hMyFont = CreateFontIndirect(&lfButtonFont); + if (hMyFont) + { + if (g->hBoldFont) + DeleteObject(g->hBoldFont); + + g->hBoldFont = hMyFont; + } + + /* Create font for italic button */ + lfButtonFont.lfWeight = FW_REGULAR; + lfButtonFont.lfItalic = TRUE; + hMyFont = CreateFontIndirect(&lfButtonFont); + if (hMyFont) + { + if (g->hItalicFont) + DeleteObject(g->hItalicFont); + + g->hItalicFont = hMyFont; + } + + /* Set the fonts for the font style buttons */ + SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTBOLD, WM_SETFONT, (WPARAM)g->hBoldFont, (LPARAM)TRUE); + SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTITALIC, WM_SETFONT, (WPARAM)g->hItalicFont, (LPARAM)TRUE); + + /* Draw Bitmaps for the colorbuttons */ + InitColorButtons(hwndDlg, g); + + /* Make the UpDown control count correctly */ + SendMessage (GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_SIZE_UD), UDM_SETRANGE, 0L, MAKELONG (200, 1)); + + /* Fill font selection combo */ + lfFont.lfCharSet = DEFAULT_CHARSET; + lfFont.lfFaceName[0] = (TCHAR)0; + lfFont.lfPitchAndFamily = 0; + hScreenDC = GetDC(0); + EnumFontFamiliesEx(hScreenDC, &lfFont, (FONTENUMPROC)EnumFontFamExProc, (LPARAM)GetDlgItem(hwndDlg, IDC_ADVAPPEARANCE_FONT_C), 0); + ReleaseDC(0, hScreenDC); + + /* Fill font size combo */ + for (i = 6; i <= 24; i++) + { + SetDlgItemInt(hwndDlg, IDC_CONVERT, i, FALSE); + GetDlgItemText(hwndDlg, IDC_CONVERT, (LPTSTR)&Size, 3); + SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTSIZE_E, CB_ADDSTRING, 0, (LPARAM)&Size); + } + + /* Update the controls */ + iListIndex = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETCURSEL, 0, 0); + g->CurrentElement = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETITEMDATA, (WPARAM)iListIndex, 0); + UpdateControls(hwndDlg, g); +} + + +static VOID +AdvAppearanceDlg_CleanUp(HWND hwndDlg, GLOBALS* g) +{ + DeleteObject(g->hBoldFont); + DeleteObject(g->hItalicFont); +} + + +INT_PTR CALLBACK +AdvAppearanceDlgProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) +{ + INT iListIndex; + GLOBALS* g; + + g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); + + switch (uMsg) + { + case WM_INITDIALOG: + g = (GLOBALS*)lParam; + SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)g); + AdvAppearanceDlg_Init(hwndDlg, g); + break; + + case WM_DESTROY: + AdvAppearanceDlg_CleanUp(hwndDlg, g); + break; + + case WM_COMMAND: + switch(LOWORD(wParam)) + { + case IDOK: + SaveCurrentValues(hwndDlg, g); + EndDialog(hwndDlg, 0); + break; + + case IDCANCEL: + g->ThemeAdv = g->Theme; + EndDialog(hwndDlg, 0); + break; + + case IDC_ADVAPPEARANCE_ELEMENT: + if (HIWORD(wParam) == CBN_SELCHANGE) + { + SaveCurrentValues(hwndDlg, g); + iListIndex = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETCURSEL, 0, 0); + g->CurrentElement = SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_ELEMENT, CB_GETITEMDATA, (WPARAM)iListIndex, 0); + UpdateControls(hwndDlg, g); + } + break; + + case IDC_ADVAPPEARANCE_COLOR1_B: + GetColor(hwndDlg, g, 0); + break; + + case IDC_ADVAPPEARANCE_COLOR2_B: + GetColor(hwndDlg, g, 1); + break; + + case IDC_ADVAPPEARANCE_FONTCOLOR_B: + GetColor(hwndDlg, g, 2); + break; + + default: + return FALSE; + } + break; + + default: + return FALSE; + } + + return TRUE; +} Modified: trunk/reactos/dll/cpl/desk/appearance.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/appearance.c?… ============================================================================== --- trunk/reactos/dll/cpl/desk/appearance.c (original) +++ trunk/reactos/dll/cpl/desk/appearance.c Thu Feb 15 23:24:38 2007 @@ -95,109 +95,240 @@ /******************************************************************************/ -INT_PTR CALLBACK -AppearancePageProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) -{ - INT i, index; - GLOBALS* g = NULL; - - switch(uMsg) - { - case WM_INITDIALOG: +static VOID +LoadCurrentTheme(GLOBALS* g) +{ + INT i; + NONCLIENTMETRICS NonClientMetrics; + + g->Theme.bHasChanged = FALSE; + /* FIXME: it may be custom! */ + g->Theme.bIsCustom = FALSE; + + /* Load colors */ + for (i = 0; i <= 30; i++) + { + g->ColorList[i] = i; + g->Theme.crColor[i] = (COLORREF)GetSysColor(i); + } + + /* Load sizes */ + for (i = 0; i <= 11; i++) + { + g->Theme.Size[i] = GetSystemMetrics(g_SizeMetric[i]); + } + + /* Load fonts */ + NonClientMetrics.cbSize = sizeof(NONCLIENTMETRICS); + SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &NonClientMetrics, 0); + g->Theme.lfFont[FONT_CAPTION] = NonClientMetrics.lfCaptionFont; + g->Theme.lfFont[FONT_SMCAPTION] = NonClientMetrics.lfSmCaptionFont; + g->Theme.lfFont[FONT_MENU] = NonClientMetrics.lfMenuFont; + g->Theme.lfFont[FONT_INFO] = NonClientMetrics.lfStatusFont; + g->Theme.lfFont[FONT_DIALOG] = NonClientMetrics.lfMessageFont; + SystemParametersInfo(SPI_GETICONTITLELOGFONT, sizeof(LOGFONT), &g->Theme.lfFont[FONT_ICON], 0); +} + + +static VOID +LoadThemeFromReg(GLOBALS* g, INT iPreset) +{ + INT i; + TCHAR strSizeName[20] = {TEXT("Sizes\\0")}; + TCHAR strValueName[10]; + HKEY hkNewSchemes, hkScheme, hkSize; + DWORD dwType, dwLength; + + if(RegOpenKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Appearance\\New Schemes"), + 0, KEY_READ, &hkNewSchemes) == ERROR_SUCCESS) + { + if(RegOpenKeyEx(hkNewSchemes, g->ThemeTemplates[iPreset].strKeyName, 0, KEY_READ, &hkScheme) == ERROR_SUCCESS) { - AppearancePage_Init(hwndDlg); - break; + lstrcpyn(&strSizeName[6],g->ThemeTemplates[iPreset].strSizeName, 3); + if(RegOpenKeyEx(hkScheme, strSizeName, 0, KEY_READ, &hkSize) == ERROR_SUCCESS) + { + dwLength = sizeof(BOOL); + RegQueryValueEx(hkSize, TEXT("FlatMenus"), NULL, &dwType, (LPBYTE)&g->Theme.bFlatMenus, &dwLength); + + for (i = 0; i <= 30; i++) + { + wsprintf(strValueName, TEXT("Color #%d"), i); + dwLength = sizeof(COLORREF); + RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&g->Theme.crColor[i], &dwLength); + } + for (i = 0; i <= 5; i++) + { + wsprintf(strValueName, TEXT("Font #%d"), i); + dwLength = sizeof(LOGFONT); + g->Theme.lfFont[i].lfFaceName[0] = 'x'; + RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&g->Theme.lfFont[i], &dwLength); + } + for (i = 0; i <= 8; i++) + { + wsprintf(strValueName, TEXT("Size #%d"), i); + dwLength = sizeof(DWORD); + RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&g->Theme.Size[i], &dwLength); + } + RegCloseKey(hkScheme); + } + RegCloseKey(hkScheme); } - case WM_DESTROY: + RegCloseKey(hkNewSchemes); + } +} + + +static VOID +ApplyTheme(GLOBALS* g) +{ + INT i, Result; + HKEY hKey; + DWORD dwDisposition = 0; + TCHAR clText[16] = {0}; + NONCLIENTMETRICS NonClientMetrics; + HFONT hMyFont; + LOGFONT lfButtonFont; + + if (!g->Theme.bHasChanged) + return; + + g->Theme.bHasChanged = FALSE; + + /* Update some globals */ + g->crCOLOR_BTNFACE = g->Theme.crColor[COLOR_BTNFACE]; + g->crCOLOR_BTNTEXT = g->Theme.crColor[COLOR_BTNTEXT]; + g->crCOLOR_BTNSHADOW = g->Theme.crColor[COLOR_BTNSHADOW]; + g->crCOLOR_BTNHIGHLIGHT = g->Theme.crColor[COLOR_BTNHIGHLIGHT]; + lfButtonFont = g->Theme.lfFont[FONT_DIALOG]; + + /* Create new font for bold button */ + lfButtonFont.lfWeight = FW_BOLD; + lfButtonFont.lfItalic = FALSE; + hMyFont = CreateFontIndirect(&lfButtonFont); + if (hMyFont) + { + if (g->hBoldFont) + DeleteObject(g->hBoldFont); + g->hBoldFont = hMyFont; + } + + /* Create new font for italic button */ + lfButtonFont.lfWeight = FW_REGULAR; + lfButtonFont.lfItalic = TRUE; + hMyFont = CreateFontIndirect(&lfButtonFont); + if (hMyFont) + { + if (g->hItalicFont) + DeleteObject(g->hItalicFont); + g->hItalicFont = hMyFont; + } + + /* Apply Colors from global variable */ + SetSysColors(30, &g->ColorList[0], &g->Theme.crColor[0]); + + /* Save colors to registry */ + Result = RegOpenKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Colors"), 0, KEY_ALL_ACCESS, &hKey); + if (Result != ERROR_SUCCESS) + { + /* Could not open the key, try to create it */ + Result = RegCreateKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Colors"), 0, NULL, 0, KEY_ALL_ACCESS, NULL,&hKey, &dwDisposition); + } + + if (Result == ERROR_SUCCESS) + { + for (i = 0; i <= 30; i++) { - AppearancePage_CleanUp(hwndDlg); - break; + DWORD red = GetRValue(g->Theme.crColor[i]); + DWORD green = GetGValue(g->Theme.crColor[i]); + DWORD blue = GetBValue(g->Theme.crColor[i]); + wsprintf(clText, TEXT("%d %d %d"), red, green, blue); + RegSetValueEx(hKey, g_RegColorNames[i], 0, REG_SZ, (BYTE *)clText, lstrlen( clText )*sizeof(TCHAR) + sizeof(TCHAR)); } - case WM_COMMAND: - { - g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - switch(LOWORD(wParam)) - { - case IDC_APPEARANCE_ADVANCED: - { - DialogBoxParam(hApplet, (LPCTSTR)IDD_ADVAPPEARANCE, - hwndDlg, AdvAppearanceDlgProc, (LPARAM)g); - - /* Was anything changed in the advanced appearance dialog? */ - if (memcmp(&g->Theme, &g->ThemeAdv, sizeof(THEME)) != 0) - { - PropSheet_Changed(GetParent(hwndDlg), hwndDlg); - g->Theme = g->ThemeAdv; - g->Theme.bHasChanged = TRUE; - } - break; - } - case IDC_APPEARANCE_COLORSCHEME: - { - if(HIWORD(wParam) == CBN_SELCHANGE) - { - PropSheet_Changed(GetParent(hwndDlg), hwndDlg); - g->Theme.bHasChanged = TRUE; - i = SendDlgItemMessage(hwndDlg, IDC_APPEARANCE_COLORSCHEME, CB_GETCURSEL, 0, 0); - index = SendDlgItemMessage(hwndDlg, IDC_APPEARANCE_COLORSCHEME, CB_GETITEMDATA, (WPARAM)i, 0); - LoadThemeFromReg(g, index); - break; - } - break; - } - default: - { - return FALSE; - } - } - return TRUE; - } - case WM_NOTIFY: - { - g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - LPNMHDR lpnm = (LPNMHDR)lParam; - switch(lpnm->code) - { - case PSN_APPLY: - { - if (g->Theme.bHasChanged) - { - ApplyTheme(g); - } - return(TRUE); - break; - } - default: - { - return FALSE; - } - } - return TRUE; - } - default: - { - return FALSE; - } - } - return TRUE; -} - -void -AppearancePage_Init(HWND hwndDlg) -{ - GLOBALS* g; + + RegCloseKey(hKey); + } + + /* Apply the fonts */ + NonClientMetrics.cbSize = sizeof(NONCLIENTMETRICS); + SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &NonClientMetrics, 0); + NonClientMetrics.lfCaptionFont = g->Theme.lfFont[FONT_CAPTION]; + NonClientMetrics.lfSmCaptionFont = g->Theme.lfFont[FONT_SMCAPTION]; + NonClientMetrics.lfMenuFont = g->Theme.lfFont[FONT_MENU]; + NonClientMetrics.lfStatusFont = g->Theme.lfFont[FONT_INFO]; + NonClientMetrics.lfMessageFont = g->Theme.lfFont[FONT_DIALOG]; + SystemParametersInfo(SPI_SETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &NonClientMetrics, 0); + SystemParametersInfo(SPI_SETICONTITLELOGFONT, sizeof(LOGFONT), &g->Theme.lfFont[FONT_ICON], 0); + + /* FIXME: Apply size metrics */ + + /* Save fonts and size metrics to registry */ + Result = RegOpenKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Desktop\\WindowMetrics"), 0, KEY_ALL_ACCESS, &hKey); + if (Result != ERROR_SUCCESS) + { + /* Could not open the key, try to create it */ + Result = RegCreateKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Desktop\\WindowMetrics"), 0, NULL, 0, KEY_ALL_ACCESS, NULL,&hKey, &dwDisposition); + } + + if (Result == ERROR_SUCCESS) + { + RegSetValueEx(hKey, TEXT("CaptionFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_CAPTION], sizeof(LOGFONT)); + RegSetValueEx(hKey, TEXT("SmCaptionFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_SMCAPTION], sizeof(LOGFONT)); + RegSetValueEx(hKey, TEXT("IconFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_ICON], sizeof(LOGFONT)); + RegSetValueEx(hKey, TEXT("MenuFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_MENU], sizeof(LOGFONT)); + RegSetValueEx(hKey, TEXT("StatusFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_INFO], sizeof(LOGFONT)); + RegSetValueEx(hKey, TEXT("MessageFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_DIALOG], sizeof(LOGFONT)); + + /* Save size metrics to registry */ + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_BORDER_X]); + RegSetValueEx(hKey, TEXT("BorderWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_CAPTION_Y]); + RegSetValueEx(hKey, TEXT("CaptionWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_CAPTION_Y]); + RegSetValueEx(hKey, TEXT("CaptionHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SMCAPTION_Y]); + RegSetValueEx(hKey, TEXT("SmCaptionWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SMCAPTION_Y]); + RegSetValueEx(hKey, TEXT("SmCaptionHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_ICON_SPC_X]); + RegSetValueEx(hKey, TEXT("IconSpacing"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_ICON_SPC_Y]); + RegSetValueEx(hKey, TEXT("IconVerticalSpacing"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_MENU_X]); + RegSetValueEx(hKey, TEXT("MenuWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_MENU_Y]); + RegSetValueEx(hKey, TEXT("MenuHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SCROLL_X]); + RegSetValueEx(hKey, TEXT("ScrollWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SCROLL_Y]); + RegSetValueEx(hKey, TEXT("ScrollHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + wsprintf(clText, TEXT("%d"), g->Theme.Size[SIZE_ICON_X]); + RegSetValueEx(hKey, TEXT("Shell Icon Sizet"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); + + RegCloseKey(hKey); + } +} + + +/* Draw the preview window, unimplemented */ +#if 0 +static VOID +DrawPreview(HWND hwndPreview, THEME* pTheme) +{ +} +#endif + + +static VOID +AppearancePage_Init(HWND hwndDlg, GLOBALS *g) +{ HKEY hkNewSchemes, hkScheme, hkSizes, hkSize; FILETIME ftLastWriteTime; TCHAR strSelectedStyle[4]; DWORD dwLength, dwType; DWORD dwDisposition = 0; - int iStyle, iSize, iTemplateIndex, iListIndex = 0; - int Result; - - g = (GLOBALS*)malloc(sizeof(GLOBALS)); - // FIXME: correct handling of error (g == NULL) - - SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)g); + INT iStyle, iSize, iTemplateIndex, iListIndex = 0; + INT Result; + LoadCurrentTheme(g); /* Fill color schemes combo */ @@ -264,230 +395,91 @@ RegCloseKey(hkNewSchemes); } SendMessage(GetDlgItem(hwndDlg, IDC_APPEARANCE_COLORSCHEME), LB_SETCURSEL, 0, 0); - return; -} - -void -AppearancePage_CleanUp(HWND hwndDlg) -{ - GLOBALS* g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); - free(g); - return; -} - -void -LoadCurrentTheme(GLOBALS* g) -{ - int i; - NONCLIENTMETRICS NonClientMetrics; - - g->Theme.bHasChanged = FALSE; - /* FIXME: it may be custom! */ - g->Theme.bIsCustom = FALSE; - - /* Load colors */ - for(i = 0; i <= 30; i++) - { - g->ColorList[i] = i; - g->Theme.crColor[i] = (COLORREF)GetSysColor(i); - } - - /* Load sizes */ - for(i = 0; i <= 11; i++) - { - g->Theme.Size[i] = GetSystemMetrics(g_SizeMetric[i]); - } - - /* Load fonts */ - NonClientMetrics.cbSize = sizeof(NONCLIENTMETRICS); - SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &NonClientMetrics, 0); - g->Theme.lfFont[FONT_CAPTION] = NonClientMetrics.lfCaptionFont; - g->Theme.lfFont[FONT_SMCAPTION] = NonClientMetrics.lfSmCaptionFont; - g->Theme.lfFont[FONT_MENU] = NonClientMetrics.lfMenuFont; - g->Theme.lfFont[FONT_INFO] = NonClientMetrics.lfStatusFont; - g->Theme.lfFont[FONT_DIALOG] = NonClientMetrics.lfMessageFont; - SystemParametersInfo(SPI_GETICONTITLELOGFONT, sizeof(LOGFONT), &g->Theme.lfFont[FONT_ICON], 0); - - return; -} - -void -LoadThemeFromReg(GLOBALS* g, INT iPreset) -{ - int i; - TCHAR strSizeName[20] = {TEXT("Sizes\\0")}; - TCHAR strValueName[10]; - HKEY hkNewSchemes, hkScheme, hkSize; - DWORD dwType, dwLength; - - if(RegOpenKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Appearance\\New Schemes"), - 0, KEY_READ, &hkNewSchemes) == ERROR_SUCCESS) - { - if(RegOpenKeyEx(hkNewSchemes, g->ThemeTemplates[iPreset].strKeyName, 0, KEY_READ, &hkScheme) == ERROR_SUCCESS) - { - lstrcpyn(&strSizeName[6],g->ThemeTemplates[iPreset].strSizeName, 3); - if(RegOpenKeyEx(hkScheme, strSizeName, 0, KEY_READ, &hkSize) == ERROR_SUCCESS) +} + + +static VOID +AppearancePage_CleanUp(HWND hwndDlg, GLOBALS *g) +{ +} + + +INT_PTR CALLBACK +AppearancePageProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) +{ + INT i, index; + GLOBALS *g; + LPNMHDR lpnm; + + g = (GLOBALS*)GetWindowLongPtr(hwndDlg, DWLP_USER); + + switch (uMsg) + { + case WM_INITDIALOG: + g = (GLOBALS*)malloc(sizeof(GLOBALS)); + if (g == NULL) + return FALSE; + + SetWindowLongPtr(hwndDlg, DWLP_USER, (LONG_PTR)g); + AppearancePage_Init(hwndDlg, g); + break; + + case WM_DESTROY: + AppearancePage_CleanUp(hwndDlg, g); + free(g); + break; + + case WM_COMMAND: + switch (LOWORD(wParam)) { - dwLength = sizeof(BOOL); - RegQueryValueEx(hkSize, TEXT("FlatMenus"), NULL, &dwType, (LPBYTE)&g->Theme.bFlatMenus, &dwLength); - - for (i = 0; i <= 30; i++) - { - wsprintf(strValueName, TEXT("Color #%d"), i); - dwLength = sizeof(COLORREF); - RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&g->Theme.crColor[i], &dwLength); - } - for (i = 0; i <= 5; i++) - { - wsprintf(strValueName, TEXT("Font #%d"), i); - dwLength = sizeof(LOGFONT); - g->Theme.lfFont[i].lfFaceName[0] = 'x'; - RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&g->Theme.lfFont[i], &dwLength); - } - for (i = 0; i <= 8; i++) - { - wsprintf(strValueName, TEXT("Size #%d"), i); - dwLength = sizeof(DWORD); - RegQueryValueEx(hkSize, strValueName, NULL, &dwType, (LPBYTE)&g->Theme.Size[i], &dwLength); - } - RegCloseKey(hkScheme); + case IDC_APPEARANCE_ADVANCED: + DialogBoxParam(hApplet, (LPCTSTR)IDD_ADVAPPEARANCE, + hwndDlg, AdvAppearanceDlgProc, (LPARAM)g); + + /* Was anything changed in the advanced appearance dialog? */ + if (memcmp(&g->Theme, &g->ThemeAdv, sizeof(THEME)) != 0) + { + PropSheet_Changed(GetParent(hwndDlg), hwndDlg); + g->Theme = g->ThemeAdv; + g->Theme.bHasChanged = TRUE; + } + break; + + case IDC_APPEARANCE_COLORSCHEME: + if(HIWORD(wParam) == CBN_SELCHANGE) + { + PropSheet_Changed(GetParent(hwndDlg), hwndDlg); + g->Theme.bHasChanged = TRUE; + i = SendDlgItemMessage(hwndDlg, IDC_APPEARANCE_COLORSCHEME, CB_GETCURSEL, 0, 0); + index = SendDlgItemMessage(hwndDlg, IDC_APPEARANCE_COLORSCHEME, CB_GETITEMDATA, (WPARAM)i, 0); + LoadThemeFromReg(g, index); + } + break; + + default: + return FALSE; } - RegCloseKey(hkScheme); - } - RegCloseKey(hkNewSchemes); - } - return; -} - -void -ApplyTheme(GLOBALS* g) -{ - int i, Result; - HKEY hKey; - DWORD dwDisposition = 0; - TCHAR clText[16] = {0}; - NONCLIENTMETRICS NonClientMetrics; - HFONT hMyFont; - LOGFONT lfButtonFont; - - if (!g->Theme.bHasChanged) return; - - g->Theme.bHasChanged = FALSE; - - /* Update some globals */ - g->crCOLOR_BTNFACE = g->Theme.crColor[COLOR_BTNFACE]; - g->crCOLOR_BTNTEXT = g->Theme.crColor[COLOR_BTNTEXT]; - g->crCOLOR_BTNSHADOW = g->Theme.crColor[COLOR_BTNSHADOW]; - g->crCOLOR_BTNHIGHLIGHT = g->Theme.crColor[COLOR_BTNHIGHLIGHT]; - lfButtonFont = g->Theme.lfFont[FONT_DIALOG]; - - /* Create new font for bold button */ - lfButtonFont.lfWeight = FW_BOLD; - lfButtonFont.lfItalic = FALSE; - hMyFont = CreateFontIndirect(&lfButtonFont); - if (hMyFont) - { - if (g->hBoldFont) DeleteObject(g->hBoldFont); - g->hBoldFont = hMyFont; - } - - /* Create new font for italic button */ - lfButtonFont.lfWeight = FW_REGULAR; - lfButtonFont.lfItalic = TRUE; - hMyFont = CreateFontIndirect(&lfButtonFont); - if (hMyFont) - { - if (g->hItalicFont) DeleteObject(g->hItalicFont); - g->hItalicFont = hMyFont; - } - - /* Apply Colors from global variable */ - SetSysColors(30, &g->ColorList[0], &g->Theme.crColor[0]); - - /* Save colors to registry */ - Result = RegOpenKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Colors"), 0, KEY_ALL_ACCESS, &hKey); - if (Result != ERROR_SUCCESS) - { - /* Could not open the key, try to create it */ - Result = RegCreateKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Colors"), 0, NULL, 0, KEY_ALL_ACCESS, NULL,&hKey, &dwDisposition); - } - if (Result == ERROR_SUCCESS) - { - for(i = 0; i <= 30; i++) - { - DWORD red = GetRValue(g->Theme.crColor[i]); - DWORD green = GetGValue(g->Theme.crColor[i]); - DWORD blue = GetBValue(g->Theme.crColor[i]); - wsprintf(clText, TEXT("%d %d %d"), red, green, blue); - RegSetValueEx(hKey, g_RegColorNames[i], 0, REG_SZ, (BYTE *)clText, lstrlen( clText )*sizeof(TCHAR) + sizeof(TCHAR)); - } - RegCloseKey(hKey); - } - - /* Apply the fonts */ - NonClientMetrics.cbSize = sizeof(NONCLIENTMETRICS); - SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &NonClientMetrics, 0); - NonClientMetrics.lfCaptionFont = g->Theme.lfFont[FONT_CAPTION]; - NonClientMetrics.lfSmCaptionFont = g->Theme.lfFont[FONT_SMCAPTION]; - NonClientMetrics.lfMenuFont = g->Theme.lfFont[FONT_MENU]; - NonClientMetrics.lfStatusFont = g->Theme.lfFont[FONT_INFO]; - NonClientMetrics.lfMessageFont = g->Theme.lfFont[FONT_DIALOG]; - SystemParametersInfo(SPI_SETNONCLIENTMETRICS, sizeof(NONCLIENTMETRICS), &NonClientMetrics, 0); - SystemParametersInfo(SPI_SETICONTITLELOGFONT, sizeof(LOGFONT), &g->Theme.lfFont[FONT_ICON], 0); - - /* FIXME: Apply size metrics */ - - /* Save fonts and size metrics to registry */ - Result = RegOpenKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Desktop\\WindowMetrics"), 0, KEY_ALL_ACCESS, &hKey); - if (Result != ERROR_SUCCESS) - { - /* Could not open the key, try to create it */ - Result = RegCreateKeyEx(HKEY_CURRENT_USER, TEXT("Control Panel\\Desktop\\WindowMetrics"), 0, NULL, 0, KEY_ALL_ACCESS, NULL,&hKey, &dwDisposition); - } - if (Result == ERROR_SUCCESS) - { - RegSetValueEx(hKey, TEXT("CaptionFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_CAPTION], sizeof(LOGFONT)); - RegSetValueEx(hKey, TEXT("SmCaptionFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_SMCAPTION], sizeof(LOGFONT)); - RegSetValueEx(hKey, TEXT("IconFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_ICON], sizeof(LOGFONT)); - RegSetValueEx(hKey, TEXT("MenuFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_MENU], sizeof(LOGFONT)); - RegSetValueEx(hKey, TEXT("StatusFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_INFO], sizeof(LOGFONT)); - RegSetValueEx(hKey, TEXT("MessageFont"), 0, REG_BINARY, (BYTE *)&g->Theme.lfFont[FONT_DIALOG], sizeof(LOGFONT)); - - /* Save size metrics to registry */ - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_BORDER_X]); - RegSetValueEx(hKey, TEXT("BorderWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_CAPTION_Y]); - RegSetValueEx(hKey, TEXT("CaptionWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_CAPTION_Y]); - RegSetValueEx(hKey, TEXT("CaptionHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SMCAPTION_Y]); - RegSetValueEx(hKey, TEXT("SmCaptionWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SMCAPTION_Y]); - RegSetValueEx(hKey, TEXT("SmCaptionHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_ICON_SPC_X]); - RegSetValueEx(hKey, TEXT("IconSpacing"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_ICON_SPC_Y]); - RegSetValueEx(hKey, TEXT("IconVerticalSpacing"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_MENU_X]); - RegSetValueEx(hKey, TEXT("MenuWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_MENU_Y]); - RegSetValueEx(hKey, TEXT("MenuHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SCROLL_X]); - RegSetValueEx(hKey, TEXT("ScrollWidth"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), -15 * g->Theme.Size[SIZE_SCROLL_Y]); - RegSetValueEx(hKey, TEXT("ScrollHeight"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - wsprintf(clText, TEXT("%d"), g->Theme.Size[SIZE_ICON_X]); - RegSetValueEx(hKey, TEXT("Shell Icon Sizet"), 0, REG_SZ, (BYTE *)clText, sizeof(clText)); - - RegCloseKey(hKey); - } - return; -} - -/* Draw the preview window, unimplemented */ -void -DrawPreview(HWND hwndPreview, THEME* pTheme) -{ - return; -} - + return TRUE; + + case WM_NOTIFY: + lpnm = (LPNMHDR)lParam; + switch (lpnm->code) + { + case PSN_APPLY: + if (g->Theme.bHasChanged) + { + ApplyTheme(g); + } + return TRUE; + + default: + return FALSE; + } + return TRUE; + + default: + return FALSE; + } + + return TRUE; +} Modified: trunk/reactos/dll/cpl/desk/appearance.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/appearance.h?… ============================================================================== --- trunk/reactos/dll/cpl/desk/appearance.h (original) +++ trunk/reactos/dll/cpl/desk/appearance.h Thu Feb 15 23:24:38 2007 @@ -85,19 +85,6 @@ /* prototypes for appearance.c */ INT_PTR CALLBACK AppearancePageProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam); -void AppearancePage_Init(HWND hwndDlg); -void AppearancePage_CleanUp(HWND hwndDlg); -void LoadCurrentTheme(GLOBALS* g); -void LoadThemeFromReg(GLOBALS* g, INT iPreset); -void ApplyTheme(GLOBALS* g); /* prototypes for advappearancedlg.c */ INT_PTR CALLBACK AdvAppearanceDlgProc(HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam); -void AdvAppearanceDlg_Init(HWND hwndDlg); -void AdvAppearanceDlg_CleanUp(HWND hwndDlg); -void UpdateControls(HWND hwndDlg, int iElement); -void SaveCurrentValues(HWND hwndDlg); -void InitColorButtons(HWND hwndDlg); -void UpdateButtonColor(HWND hwndDlg, int ID, int nButton, int nColor); -BOOL GetColor(HWND hwndDlg, int iElement, int nButton); -int CALLBACK EnumFontFamExProc(ENUMLOGFONTEX*, NEWTEXTMETRICEX*, DWORD, LPARAM);

1 0

[hpoussin] 25808: Start registry keys enumeration at 0 instead of 1. This fixes enumeration of all protocols (which start at 0). Another side effect is that this fixes enumeration of network adapters (which, due to another bug, also start at 0 instead of 1 as in MS Windows). By the way, the correct way of enumerating adapters and protocols is to use the SetupDi* functions, which will potential fix other bugs. Fixes bug 2034 in branch 0.3.1
by hpoussin＠svn.reactos.org 15 Feb '07

15 Feb '07

Author: hpoussin Date: Thu Feb 15 21:26:51 2007 New Revision: 25808 URL: http://svn.reactos.org/svn/reactos?rev=25808&view=rev Log: Start registry keys enumeration at 0 instead of 1. This fixes enumeration of all protocols (which start at 0). Another side effect is that this fixes enumeration of network adapters (which, due to another bug, also start at 0 instead of 1 as in MS Windows). By the way, the correct way of enumerating adapters and protocols is to use the SetupDi* functions, which will potential fix other bugs. Fixes bug 2034 in branch 0.3.1 Modified: branches/ros-branch-0_3_1/reactos/dll/cpl/ncpa/ncpa.c Modified: branches/ros-branch-0_3_1/reactos/dll/cpl/ncpa/ncpa.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_1/reactos/dll/cp… ============================================================================== --- branches/ros-branch-0_3_1/reactos/dll/cpl/ncpa/ncpa.c (original) +++ branches/ros-branch-0_3_1/reactos/dll/cpl/ncpa/ncpa.c Thu Feb 15 21:26:51 2007 @@ -100,7 +100,7 @@ return; } - for(i=1;;i++) + for(i=0;;i++) { TCHAR pszNewPath[MAX_PATH]; ret = RegEnumKeyEx(hKey,i,tpszName,&dwNameLen,NULL,NULL,NULL,NULL);

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs