Ros-diffs

ros-diffs@reactos.org

81390 discussions

[fireball] 25727: Those Wmi*() are not kernel APIs.
by fireball＠svn.reactos.org 05 Feb '07

05 Feb '07

Author: fireball Date: Mon Feb 5 13:47:27 2007 New Revision: 25727 URL: http://svn.reactos.org/svn/reactos?rev=25727&view=rev Log: Those Wmi*() are not kernel APIs. Modified: trunk/reactos/include/ddk/winddk.h Modified: trunk/reactos/include/ddk/winddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/winddk.h?rev=2… ============================================================================== --- trunk/reactos/include/ddk/winddk.h (original) +++ trunk/reactos/include/ddk/winddk.h Mon Feb 5 13:47:27 2007 @@ -10526,7 +10526,6 @@ /** WMI library support routines **/ -NTKERNELAPI NTSTATUS NTAPI WmiCompleteRequest( @@ -10536,7 +10535,6 @@ IN ULONG BufferUsed, IN CCHAR PriorityBoost); -NTKERNELAPI NTSTATUS NTAPI WmiFireEvent( @@ -10556,7 +10554,6 @@ OUT PULONG RequiredLength OPTIONAL, IN PVOID Buffer OPTIONAL); -NTKERNELAPI NTSTATUS NTAPI WmiSystemControl(

1 0

[tkreuzer] 25726: Make LoadCursorIconImage() find shared icons, even if they don't have the desired width/height. Now explorer doesn't leak icons / bitmaps anymore. fixes bug 1554 See issue #1554 for more details.
by tkreuzer＠svn.reactos.org 05 Feb '07

05 Feb '07

Author: tkreuzer Date: Mon Feb 5 03:59:59 2007 New Revision: 25726 URL: http://svn.reactos.org/svn/reactos?rev=25726&view=rev Log: Make LoadCursorIconImage() find shared icons, even if they don't have the desired width/height. Now explorer doesn't leak icons / bitmaps anymore. fixes bug 1554 See issue #1554 for more details. Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c Modified: trunk/reactos/dll/win32/user32/windows/bitmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/b… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/bitmap.c (original) +++ trunk/reactos/dll/win32/user32/windows/bitmap.c Mon Feb 5 03:59:59 2007 @@ -186,9 +186,8 @@ UINT fuLoad, ULONG uType) { + HRSRC hResInfo; HANDLE hResource; - HANDLE h2Resource; - HANDLE hfRes; HANDLE hFile; HANDLE hSection; CURSORICONFILEDIR *IconDIR; @@ -211,52 +210,69 @@ if (hinst == NULL) hinst = User32Instance; - hResource = hfRes = FindResourceW(hinst, lpszName, + hResInfo = FindResourceW(hinst, lpszName, Icon ? RT_GROUP_ICON : RT_GROUP_CURSOR); - if (hResource == NULL) - return NULL; - - if (fuLoad & LR_SHARED) - { - hIcon = NtUserFindExistingCursorIcon(hinst, (HRSRC)hfRes, width, height); - if (hIcon) - return hIcon; - } - - hResource = LoadResource(hinst, hResource); + if (hResInfo == NULL) + return NULL; + + hResource = LoadResource(hinst, hResInfo); if (hResource == NULL) return NULL; IconResDir = LockResource(hResource); if (IconResDir == NULL) - return NULL; + { + FreeResource(hResource); + return NULL; + } /* Find the best fitting in the IconResDir for this resolution */ id = LookupIconIdFromDirectoryEx((PBYTE)IconResDir, Icon, width, height, fuLoad & (LR_DEFAULTCOLOR | LR_MONOCHROME)); - h2Resource = FindResourceW(hinst, MAKEINTRESOURCEW(id), + FreeResource(hResource); + + hResInfo = FindResourceW(hinst, MAKEINTRESOURCEW(id), Icon ? (LPCWSTR) RT_ICON : (LPCWSTR) RT_CURSOR); - if (h2Resource == NULL) - return NULL; - - hResource = LoadResource(hinst, h2Resource); + if (hResInfo == NULL) + { + return NULL; + } + + /* Now we have found the icon we want to load. + * Let's see if we already loaded it */ + if (fuLoad & LR_SHARED) + { + hIcon = NtUserFindExistingCursorIcon(hinst, hResInfo, 0, 0); + if (hIcon) + { + return hIcon; + } + } + + hResource = LoadResource(hinst, hResInfo); if (hResource == NULL) - return NULL; + { + return NULL; + } ResIcon = LockResource(hResource); if (ResIcon == NULL) - return NULL; + { + FreeResource(hResource); + return NULL; + } hIcon = CreateIconFromResourceEx((PBYTE)ResIcon, - SizeofResource(hinst, h2Resource), + SizeofResource(hinst, hResInfo), Icon, 0x00030000, width, height, fuLoad & (LR_DEFAULTCOLOR | LR_MONOCHROME)); + FreeResource(hResource); if (hIcon && 0 != (fuLoad & LR_SHARED)) { - NtUserSetCursorIconData((HICON)hIcon, NULL, NULL, hinst, (HRSRC)hfRes, + NtUserSetCursorIconData((HICON)hIcon, NULL, NULL, hinst, hResInfo, (HRSRC)NULL); } @@ -650,7 +666,7 @@ { /* Look if the colors of the DIB are black and white */ - monochrome = + monochrome = (bi->bmiColors[0].rgbRed == 0xff && bi->bmiColors[0].rgbGreen == 0xff && bi->bmiColors[0].rgbBlue == 0xff

1 0

[tkreuzer] 25725: MSDN sais: "The CreateIconFromResource function calls CreateIconFromResourceEx passing LR_DEFAULTSIZE|LR_SHARED as flags." (not supported yet in CreateIconFromResourceEx())
by tkreuzer＠svn.reactos.org 05 Feb '07

05 Feb '07

Author: tkreuzer Date: Mon Feb 5 03:21:38 2007 New Revision: 25725 URL: http://svn.reactos.org/svn/reactos?rev=25725&view=rev Log: MSDN sais: "The CreateIconFromResource function calls CreateIconFromResourceEx passing LR_DEFAULTSIZE|LR_SHARED as flags." (not supported yet in CreateIconFromResourceEx()) Modified: trunk/reactos/dll/win32/user32/windows/icon.c Modified: trunk/reactos/dll/win32/user32/windows/icon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/i… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/icon.c (original) +++ trunk/reactos/dll/win32/user32/windows/icon.c Mon Feb 5 03:21:38 2007 @@ -206,7 +206,7 @@ BOOL fIcon, DWORD dwVer) { - return CreateIconFromResourceEx(presbits, dwResSize, fIcon, dwVer, 0, 0, 0); + return CreateIconFromResourceEx(presbits, dwResSize, fIcon, dwVer, 0, 0, LR_DEFAULTSIZE|LR_SHARED ); }

1 0

[spetreolle] 25724: fix build
by spetreolle＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: spetreolle Date: Mon Feb 5 01:35:09 2007 New Revision: 25724 URL: http://svn.reactos.org/svn/reactos?rev=25724&view=rev Log: fix build Modified: trunk/reactos/ntoskrnl/inbv/inbv.c Modified: trunk/reactos/ntoskrnl/inbv/inbv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/inbv/inbv.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/inbv/inbv.c (original) +++ trunk/reactos/ntoskrnl/inbv/inbv.c Mon Feb 5 01:35:09 2007 @@ -3,7 +3,7 @@ #include <ntoskrnl.h> #define NDEBUG #include <debug.h> -#include "bootvid\bootvid.h" +#include "bootvid/bootvid.h" /* GLOBALS *******************************************************************/ @@ -239,7 +239,7 @@ InbvAcquireLock(); /* Make sure we're installed and display the string */ - if (InbvBootDriverInstalled) VidDisplayString(String); + if (InbvBootDriverInstalled) VidDisplayString((PUCHAR) String); /* Call Headless (We don't support headless for now) HeadlessDispatch(DISPLAY_STRING); */

1 0

[greatlrd] 25723: Good news after all bugfix in cmd it seam pipe works with unicode. only bug left 1. we need found where we miss translate some part from unicode -> ansi and use current codepage. This change are not for 0.3.1 it is target for next release.
by greatlrd＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: greatlrd Date: Mon Feb 5 00:48:07 2007 New Revision: 25723 URL: http://svn.reactos.org/svn/reactos?rev=25723&view=rev Log: Good news after all bugfix in cmd it seam pipe works with unicode. only bug left 1. we need found where we miss translate some part from unicode -> ansi and use current codepage. This change are not for 0.3.1 it is target for next release. Modified: trunk/reactos/base/shell/cmd/cmd.rbuild Modified: trunk/reactos/base/shell/cmd/cmd.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/cmd.rbuild?… ============================================================================== --- trunk/reactos/base/shell/cmd/cmd.rbuild (original) +++ trunk/reactos/base/shell/cmd/cmd.rbuild Mon Feb 5 00:48:07 2007 @@ -4,6 +4,8 @@ <define name="__USE_W32API" /> <define name="ANONYMOUSUNIONS" /> <define name="_WIN32_WINNT">0x0501</define> + <define name="UNICODE" /> + <define name="_UNICODE" /> <pch>precomp.h</pch> <compilationunit name="unit.c"> <file>alias.c</file> @@ -67,6 +69,8 @@ <define name="__USE_W32API" /> <define name="ANONYMOUSUNIONS" /> <define name="_WIN32_WINNT">0x0501</define> + <define name="UNICODE" /> + <define name="_UNICODE" /> <library>cmd_base</library> <library>kernel32</library> <library>advapi32</library>

1 0

[spetreolle] 25722: fix bootvid build
by spetreolle＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: spetreolle Date: Sun Feb 4 22:19:18 2007 New Revision: 25722 URL: http://svn.reactos.org/svn/reactos?rev=25722&view=rev Log: fix bootvid build Modified: trunk/reactos/drivers/base/bootvid/bootdata.c trunk/reactos/drivers/base/bootvid/precomp.h Modified: trunk/reactos/drivers/base/bootvid/bootdata.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootd… ============================================================================== --- trunk/reactos/drivers/base/bootvid/bootdata.c (original) +++ trunk/reactos/drivers/base/bootvid/bootdata.c Sun Feb 4 22:19:18 2007 @@ -48,7 +48,7 @@ 0x0 // End of command stream }; -CHAR FontData[256 * 13] = +UCHAR FontData[256 * 13] = { 0x00, 0x00, 0x3C, 0x24, 0x24, 0x24, 0x24, 0x24, 0x24, 0x3C, 0x00, 0x00, 0x00, // 0 0x00, 0x00, 0x3C, 0x24, 0x24, 0x24, 0x24, 0x24, 0x24, 0x3C, 0x00, 0x00, 0x00, // 13 Modified: trunk/reactos/drivers/base/bootvid/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/preco… ============================================================================== --- trunk/reactos/drivers/base/bootvid/precomp.h (original) +++ trunk/reactos/drivers/base/bootvid/precomp.h Sun Feb 4 22:19:18 2007 @@ -1,7 +1,7 @@ #include "ntddk.h" -#include "arc\arc.h" +#include "arc/arc.h" #include "halfuncs.h" -#include "drivers\bootvid\bootvid.h" +#include "drivers/bootvid/bootvid.h" // // Command Stream Definitions

1 0

[ion] 25721: - Fix call to VidInitialize. - Disable call to HalDisplayReset to avoid bugcheck. [Lock held] - Don't unload bootvid after Phase 3 I/O Init since we still need to call it. - Implement HalpTranslateResourceAddress since bootvid (and other windows boot drivers, potentially) needs it.
by ion＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: ion Date: Sun Feb 4 22:15:04 2007 New Revision: 25721 URL: http://svn.reactos.org/svn/reactos?rev=25721&view=rev Log: - Fix call to VidInitialize. - Disable call to HalDisplayReset to avoid bugcheck. [Lock held] - Don't unload bootvid after Phase 3 I/O Init since we still need to call it. - Implement HalpTranslateResourceAddress since bootvid (and other windows boot drivers, potentially) needs it. Modified: trunk/reactos/drivers/base/bootvid/bootvid.c trunk/reactos/hal/halx86/generic/bus.c trunk/reactos/include/reactos/drivers/bootvid/bootvid.h trunk/reactos/ntoskrnl/inbv/inbv.c trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/drivers/base/bootvid/bootvid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/base/bootvid/bootv… ============================================================================== --- trunk/reactos/drivers/base/bootvid/bootvid.c (original) +++ trunk/reactos/drivers/base/bootvid/bootvid.c Sun Feb 4 22:15:04 2007 @@ -423,7 +423,7 @@ // // Reset the display // - HalResetDisplay(); + //HalResetDisplay(); curr_x = 0; curr_y = 0; Modified: trunk/reactos/hal/halx86/generic/bus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bus.c?r… ============================================================================== --- trunk/reactos/hal/halx86/generic/bus.c (original) +++ trunk/reactos/hal/halx86/generic/bus.c Sun Feb 4 22:15:04 2007 @@ -93,6 +93,28 @@ return Vector; } +BOOLEAN +NTAPI +HalpFindBusAddressTranslation(IN PHYSICAL_ADDRESS BusAddress, + IN OUT PULONG AddressSpace, + OUT PPHYSICAL_ADDRESS TranslatedAddress, + IN OUT PULONG_PTR Context, + IN BOOLEAN NextBus) +{ + /* Make sure we have a context */ + if (!Context) return FALSE; + + /* If we have data in the context, then this shouldn't be a new lookup */ + if ((*Context) && (NextBus == TRUE)) return FALSE; + + /* Return bus data */ + TranslatedAddress->QuadPart = BusAddress.QuadPart; + + /* Set context value and return success */ + *Context = 1; + return TRUE; +} + VOID NTAPI HalpInitNonBusHandler(VOID) @@ -100,7 +122,7 @@ /* These should be written by the PCI driver later, but we give defaults */ HalPciTranslateBusAddress = HalpTranslateBusAddress; HalPciAssignSlotResources = HalpAssignSlotResources; - //HalFindBusAddressTranslation = HalpFindBusAddressTranslation; + HalFindBusAddressTranslation = HalpFindBusAddressTranslation; } /* PUBLIC FUNCTIONS **********************************************************/ Modified: trunk/reactos/include/reactos/drivers/bootvid/bootvid.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/drivers/bo… ============================================================================== --- trunk/reactos/include/reactos/drivers/bootvid/bootvid.h (original) +++ trunk/reactos/include/reactos/drivers/bootvid/bootvid.h Sun Feb 4 22:15:04 2007 @@ -40,7 +40,7 @@ IN ULONG Width, IN ULONG Height, IN ULONG Delta); - + VOID NTAPI VidDisplayString(PUCHAR String); @@ -50,7 +50,7 @@ VidBitBlt(PUCHAR Buffer, ULONG Left, ULONG Top); - + VOID NTAPI VidScreenToBufferBlt(PUCHAR Buffer, @@ -59,7 +59,7 @@ ULONG Width, ULONG Height, ULONG Delta); - + VOID NTAPI VidSolidColorFill(IN ULONG Left, @@ -68,5 +68,4 @@ IN ULONG Bottom, IN UCHAR Color); - #endif Modified: trunk/reactos/ntoskrnl/inbv/inbv.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/inbv/inbv.c?rev=2… ============================================================================== --- trunk/reactos/ntoskrnl/inbv/inbv.c (original) +++ trunk/reactos/ntoskrnl/inbv/inbv.c Sun Feb 4 22:15:04 2007 @@ -104,8 +104,7 @@ } /* Initialize the video */ - InbvBootDriverInstalled = VidInitialize(CustomLogo); - DPRINT1("Init: %lx\n", InbvBootDriverInstalled); + InbvBootDriverInstalled = VidInitialize(!CustomLogo); if (InbvBootDriverInstalled) { /* Find bitmap resources in the kernel */ @@ -239,10 +238,8 @@ /* Acquire the lock */ InbvAcquireLock(); -#if 0 /* Make sure we're installed and display the string */ if (InbvBootDriverInstalled) VidDisplayString(String); -#endif /* Call Headless (We don't support headless for now) HeadlessDispatch(DISPLAY_STRING); */ Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Sun Feb 4 22:15:04 2007 @@ -1018,7 +1018,7 @@ } /* Loop modules again */ - NextEntry = ListHead->Flink->Flink->Flink; + NextEntry = ListHead->Flink->Flink->Flink->Flink; while (ListHead != NextEntry) { /* Get the entry */

1 0

[greatlrd] 25720: patch from : Paolo Devoti <devotip at gmail.com> fix issue : fix it.rc typo see bug 1983 as well See issue #2017 for more details.
by greatlrd＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: greatlrd Date: Sun Feb 4 21:25:47 2007 New Revision: 25720 URL: http://svn.reactos.org/svn/reactos?rev=25720&view=rev Log: patch from : Paolo Devoti <devotip at gmail.com> fix issue : fix it.rc typo see bug 1983 as well See issue #2017 for more details. Modified: trunk/reactos/base/shell/cmd/it-IT.rc Modified: trunk/reactos/base/shell/cmd/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/it-IT.rc?re… ============================================================================== --- trunk/reactos/base/shell/cmd/it-IT.rc (original) +++ trunk/reactos/base/shell/cmd/it-IT.rc Sun Feb 4 21:25:47 2007 @@ -28,7 +28,7 @@ Per attivarne uno nuovo o sostituire uno esistente:\n\ ALIAS da=dir a:\n\n\ Per rimuovere un alias:\n\ - ALIAS da=" + ALIAS da=\n" STRING_BEEP_HELP, "Segnale acustico.\n\nBEEP\n" @@ -107,7 +107,7 @@ STRING_COPY_HELP1, "Sovrascrivi %s (Si/No/Tutti)? " -STRING_COPY_HELP2, "Copia uno o piu' file in un'altra destinazione.\n\n\ +STRING_COPY_HELP2, "Copia uno o più file in un'altra destinazione.\n\n\ COPY [/V][/Y|/-Y][/A|/B] sorgente [/A|/B]\n\ [+ sorgente [/A|/B] [+ ...]] [destinazione [/A|/B]]\n\n\ sorgente Inica il file o i file da copiare.\n\ @@ -134,7 +134,7 @@ Scrivi DATE senza parametri per visualizzare la data attuale e\n\ chiedere quella nuova. Premi ENTER per mantenerla inalterata.\n" -STRING_DEL_HELP1, "Cancella uno o piu' file.\n\n\ +STRING_DEL_HELP1, "Cancella uno o più file.\n\n\ DEL [/N /P /T /Q /S /W /Y /Z /A[[:]attributi]] file ...\n\ DELETE [/N /P /T /Q /S /W /Y /Z /A[[:]attributi]] file ...\n\ ERASE [/N /P /T /Q /S /W /Y /Z /A[[:]attributi]] file ...\n\n\ @@ -155,9 +155,9 @@ H nascosto\n\ - prefisso con il significato di non\n" -STRING_DEL_HELP2, "All files in the directory will be deleted!\nAre you sure (Y/N)?" -STRING_DEL_HELP3, " %lu file deleted\n" -STRING_DEL_HELP4, " %lu files deleted\n" +STRING_DEL_HELP2, "Tutti i file nella cartella saranno cancellati!\nSei sicuro (S/N)?" +STRING_DEL_HELP3, " %lu file cancellato\n" +STRING_DEL_HELP4, " %lu file cancellati\n" STRING_DELAY_HELP, "aspetta per il tempo indicato in secondi o millisecondi\n\ DELAY [/m]n\n\n\ @@ -179,8 +179,8 @@ /L Usa minuscole.\n\ /N Nuovo formato con i nomi dei file sulla estrema destra.\n\ /O Elenca i file ordinati.\n\ - sortorder N Per nome (alfabetico) S Dimensione (per primo il piu' piccolo)\n\ - E Estensione (alfabetico) D By date/time (per primo il piu' vecchio)\n\ + sortorder N Per nome (alfabetico) S Dimensione (per primo il più piccolo)\n\ + E Estensione (alfabetico) D By date/time (per primo il più vecchio)\n\ G Le cartelle per prime - Prefisso per invertire l'ordine\n\ /P Pasa dopo ogni schermata piena.\n\ /Q Visualizza il proprietario del file.\n\ @@ -244,7 +244,7 @@ STRING_FOR_HELP1, "Esegue un comand specifico per ogni file indicato\n\n\ FOR %variabile IN (listafile) DO comando [parametri]\n\n\ %variabile Indica un parametro sostituibile.\n\ - (listafile)Indica un insieme di uno o piu' file. Si possono usare i\ + (listafile)Indica un insieme di uno o più file. Si possono usare i\ caratteri jolly.\n\ comando Indica un comando da eseguire per ogni file.\n\ parametri Indica i parametri o le selezioni per il comando.\n\n\ @@ -309,7 +309,7 @@ STRING_MOVE_HELP1, "Sovrascrivi %s (Si/No/Tutti)? " STRING_MOVE_HELP2, "Sposta i file o cambia il nome a file e cartelle.\n\n\ -Per spostare uno o piu' file:\n\ +Per spostare uno o più file:\n\ MOVE [/N][disco:][percorso]nomefile1[,...] destinazione\n\n\ To rename a directory:\n\ MOVE [/N][disco:][percorso]]cartella1 cartella2\n\n\ @@ -421,7 +421,7 @@ STRING_TIME_HELP1, "Visualizza o assegna l'ora di sistema.\n\n\ TIME [/T][ora]\n\n\ /T Visualizza solo\n\n\ -Se TIME è usato senza parametri viene visualizzata l'ra attuale e richiesta\n\ +Se TIME è usato senza parametri viene visualizzata l'ora attuale e richiesta\n\ quella nuova. Premere INVIO per non modificarla.\n" STRING_TIME_HELP2, "Inserisci la nuova ora: " @@ -526,12 +526,12 @@ CLS Cancella lo schermo.\n\ CMD Esegue un altro interprete dei comandi.\n\ COLOR Imposta i colori della console.\n\ -COPY Copia uno o piu' file in un'altra destinazione.\n\ +COPY Copia uno o più file in un'altra destinazione.\n\ DATE Visualizza o modifica la data.\n\ -DELETE Cancella uno o piu' file.\n\ +DELETE Cancella uno o più file.\n\ DIR Visualizza un elenco di file e sottocartelle in una cartella.\n\ ECHO Visualizza messaggi, o abilita e disabilita la visualizzazione dei comandi.\n\ -ERASE Cancella uno o piu' file.\n\ +ERASE Cancella uno o più file.\n\ EXIT Esce dall'interprete dei comandi.\n\ FOR Esegue un comando per ognuno dei file indicati.\n\ FREE Spazio libero.\n\ @@ -542,7 +542,7 @@ LABEL Crea, modifica, o cancella l'etichetta di un disco.\n\ MD Crea una cartella.\n\ MKDIR Crea una cartella.\n\ -MOVE Muove uno o piu' file da una cartella a un'altra\n\ +MOVE Muove uno o più file da una cartella a un'altra\n\ PATH Visualizza o imposta i percorsi di ricerca per gli eseguibili.\n\ PAUSE Ferma l'esecuzione di un batch e visualizza un messaggio.\n\ POPD Ripristina il valore precedente della cartella corrente salvato da\n\ @@ -551,8 +551,8 @@ PUSHD Salva la cartella corrente e poi la cambia.\n\ RD Rimuove una cartella.\n\ REM Commenti in un batch.\n\ -REN Rinomina uno piu' file.\n\ -RENAME Rinomina uno piu' file.\n\ +REN Rinomina uno più file.\n\ +RENAME Rinomina uno più file.\n\ RMDIR Rimuove una cartella.\n\ SCREEN Sposta il cursore e visualizza un testo.\n\ SET Visualizza, modifica, o cancella le variabili di ambiente.\n\

1 0

[greatlrd] 25719: fixed a problem possible overwrite memory in cmd. base on knowlges from bug 2017. the patch are incorrect to fix it. we simple do not allown overwrite the memory. both on trunk and 0.3.1 See issue #2017 for more details.
by greatlrd＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: greatlrd Date: Sun Feb 4 21:19:34 2007 New Revision: 25719 URL: http://svn.reactos.org/svn/reactos?rev=25719&view=rev Log: fixed a problem possible overwrite memory in cmd. base on knowlges from bug 2017. the patch are incorrect to fix it. we simple do not allown overwrite the memory. both on trunk and 0.3.1 See issue #2017 for more details. Modified: trunk/reactos/base/shell/cmd/cmd.c Modified: trunk/reactos/base/shell/cmd/cmd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/cmd.c?rev=2… ============================================================================== --- trunk/reactos/base/shell/cmd/cmd.c (original) +++ trunk/reactos/base/shell/cmd/cmd.c Sun Feb 4 21:19:34 2007 @@ -187,6 +187,9 @@ INT c = 0; INT n = 0; + if (len <= 1) + return 0; + if (num.QuadPart == 0) { des[0] = _T('0'); @@ -203,6 +206,8 @@ temp[30 - c++] = (TCHAR)(num.QuadPart % 10) + _T('0'); num.QuadPart /= 10; } + if (c>len) + c=len; for (n = 0; n <= c; n++) des[n] = temp[31 - c + n];

1 0

[greatlrd] 25718: fixed a problem possible overwrite memory in cmd. base on knowlges from bug 2017. the patch are incorrect to fix it. we simple do not allown overwrite the memory. See issue #2017 for more details.
by greatlrd＠svn.reactos.org 04 Feb '07

04 Feb '07

Author: greatlrd Date: Sun Feb 4 21:17:34 2007 New Revision: 25718 URL: http://svn.reactos.org/svn/reactos?rev=25718&view=rev Log: fixed a problem possible overwrite memory in cmd. base on knowlges from bug 2017. the patch are incorrect to fix it. we simple do not allown overwrite the memory. See issue #2017 for more details. Modified: branches/ros-branch-0_3_1/reactos/base/shell/cmd/cmd.c Modified: branches/ros-branch-0_3_1/reactos/base/shell/cmd/cmd.c URL: http://svn.reactos.org/svn/reactos/branches/ros-branch-0_3_1/reactos/base/s… ============================================================================== --- branches/ros-branch-0_3_1/reactos/base/shell/cmd/cmd.c (original) +++ branches/ros-branch-0_3_1/reactos/base/shell/cmd/cmd.c Sun Feb 4 21:17:34 2007 @@ -187,6 +187,9 @@ INT c = 0; INT n = 0; + if (len <= 1) + return 0; + if (num.QuadPart == 0) { des[0] = _T('0'); @@ -203,6 +206,8 @@ temp[30 - c++] = (TCHAR)(num.QuadPart % 10) + _T('0'); num.QuadPart /= 10; } + if (c>len) + c=len; for (n = 0; n <= c; n++) des[n] = temp[31 - c + n];

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs