Ros-diffs

ros-diffs@reactos.org

81390 discussions

[arty] 25028: Partially unregress python 2.4 installer.
by arty＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: arty Date: Sun Dec 3 13:42:35 2006 New Revision: 25028 URL: http://svn.reactos.org/svn/reactos?rev=25028&view=rev Log: Partially unregress python 2.4 installer. Modified: branches/arty-stable/reactos/ntoskrnl/cc/view.c branches/arty-stable/reactos/ntoskrnl/mm/balance.c branches/arty-stable/reactos/ntoskrnl/ps/process.c Modified: branches/arty-stable/reactos/ntoskrnl/cc/view.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/cc… ============================================================================== --- branches/arty-stable/reactos/ntoskrnl/cc/view.c (original) +++ branches/arty-stable/reactos/ntoskrnl/cc/view.c Sun Dec 3 13:42:35 2006 @@ -314,13 +314,11 @@ ULONG PagesPerSegment; ULONG PagesFreed; KIRQL oldIrql; - LIST_ENTRY FreeList; + BOOLEAN Locked; DPRINT("CcRosTrimCache(Target %d)\n", Target); *NrFreed = 0; - - InitializeListHead(&FreeList); ExEnterCriticalRegionAndAcquireFastMutexUnsafe(&ViewLock); current_entry = CacheSegmentLRUListHead.Flink; @@ -331,13 +329,15 @@ current_entry = current_entry->Flink; KeAcquireSpinLock(&current->Bcb->BcbLock, &oldIrql); + Locked = CcTryToAcquireBrokenMutex(&current->Lock); + if (!Locked) continue; + if (current->ReferenceCount == 0) { RemoveEntryList(&current->BcbSegmentListEntry); KeReleaseSpinLock(&current->Bcb->BcbLock, oldIrql); RemoveEntryList(&current->CacheSegmentListEntry); RemoveEntryList(&current->CacheSegmentLRUListEntry); - InsertHeadList(&FreeList, &current->BcbSegmentListEntry); PagesPerSegment = current->Bcb->CacheSegmentSize / PAGE_SIZE; PagesFreed = min(PagesPerSegment, Target); Target -= PagesFreed; @@ -350,9 +350,10 @@ ULONG i; NTSTATUS Status; - CcRosCacheSegmentIncRefCount(current); + CcRosCacheSegmentIncRefCount(current); last = current; current->PageOut = TRUE; + ExReleaseFastMutexUnsafeAndLeaveCriticalRegion(&current->Lock); KeReleaseSpinLock(&current->Bcb->BcbLock, oldIrql); ExReleaseFastMutexUnsafeAndLeaveCriticalRegion(&ViewLock); for (i = 0; i < current->Bcb->CacheSegmentSize / PAGE_SIZE; i++) @@ -375,16 +376,9 @@ } KeReleaseSpinLock(&current->Bcb->BcbLock, oldIrql); } + ExReleaseFastMutexUnsafeAndLeaveCriticalRegion(&current->Lock); } ExReleaseFastMutexUnsafeAndLeaveCriticalRegion(&ViewLock); - - while (!IsListEmpty(&FreeList)) - { - current_entry = RemoveHeadList(&FreeList); - current = CONTAINING_RECORD(current_entry, CACHE_SEGMENT, - BcbSegmentListEntry); - CcRosInternalFreeCacheSegment(current); - } DPRINT("CcRosTrimCache() finished\n"); return(STATUS_SUCCESS); @@ -680,7 +674,8 @@ KEBUGCHECKCC; } - current->BaseAddress = CiCacheSegMappingRegionBase + StartingOffset * PAGE_SIZE; + char *mapbase = CiCacheSegMappingRegionBase; + current->BaseAddress = mapbase + StartingOffset * PAGE_SIZE; if (CiCacheSegMappingRegionHint == StartingOffset) { @@ -899,10 +894,12 @@ RegionSize = CacheSeg->Bcb->CacheSegmentSize / PAGE_SIZE; /* Unmap all the pages. */ + char *csbase = CacheSeg->BaseAddress, *mapbase = CiCacheSegMappingRegionBase; + for (i = 0; i < RegionSize; i++) { MmDeleteVirtualMapping(NULL, - CacheSeg->BaseAddress + (i * PAGE_SIZE), + csbase + (i * PAGE_SIZE), FALSE, NULL, &Page); @@ -911,7 +908,7 @@ KeAcquireSpinLock(&CiCacheSegMappingRegionLock, &oldIrql); /* Deallocate all the pages used. */ - Base = (ULONG)(CacheSeg->BaseAddress - CiCacheSegMappingRegionBase) / PAGE_SIZE; + Base = (ULONG)(csbase - mapbase) / PAGE_SIZE; RtlClearBits(&CiCacheSegMappingRegionAllocMap, Base, RegionSize); Modified: branches/arty-stable/reactos/ntoskrnl/mm/balance.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/mm… ============================================================================== --- branches/arty-stable/reactos/ntoskrnl/mm/balance.c (original) +++ branches/arty-stable/reactos/ntoskrnl/mm/balance.c Sun Dec 3 13:42:35 2006 @@ -102,7 +102,7 @@ } KeAcquireSpinLock(&AllocationListLock, &oldIrql); - if (MmGetReferenceCountPage(Page) == 1) + if (MmGetReferenceCountPage(Page) > 0) { (void)InterlockedDecrementUL(&MiMemoryConsumers[Consumer].PagesUsed); if (IsListEmpty(&AllocationListHead) || MmStats.NrFreePages < MiMinimumAvailablePages) @@ -139,7 +139,7 @@ MiMemoryConsumers[Consumer].PagesTarget; if (Target < 1) { - Target = 1; + return; } if (MiMemoryConsumers[Consumer].Trim != NULL) Modified: branches/arty-stable/reactos/ntoskrnl/ps/process.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ps… ============================================================================== --- branches/arty-stable/reactos/ntoskrnl/ps/process.c (original) +++ branches/arty-stable/reactos/ntoskrnl/ps/process.c Sun Dec 3 13:42:35 2006 @@ -560,6 +560,8 @@ /* Create or Clone the Handle Table */ ObpCreateHandleTable(Parent, Process); + memset(&Process->VadRoot, 0, sizeof(Process->VadRoot)); + /* Set Process's Directory Base */ MmCopyMmInfo(Parent ? Parent : PsInitialSystemProcess, Process,

1 0

[greatlrd] 25027: Fixed so we can optain the HAL again. Do not trust on ddraw value yo get blindy. it will rest the value you need to optian the HAL and you can not spy on it so easy then.
by greatlrd＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: greatlrd Date: Sun Dec 3 12:12:35 2006 New Revision: 25027 URL: http://svn.reactos.org/svn/reactos?rev=25027&view=rev Log: Fixed so we can optain the HAL again. Do not trust on ddraw value yo get blindy. it will rest the value you need to optian the HAL and you can not spy on it so easy then. Modified: trunk/reactos/dll/directx/ddraw/startup.c Modified: trunk/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/startup.… ============================================================================== --- trunk/reactos/dll/directx/ddraw/startup.c (original) +++ trunk/reactos/dll/directx/ddraw/startup.c Sun Dec 3 12:12:35 2006 @@ -80,6 +80,7 @@ This->lpLcl->lpGbl->lpModeInfo[0].lPitch = (devmode.dmPelsWidth*devmode.dmBitsPerPel)/8; This->lpLcl->lpGbl->lpModeInfo[0].wRefreshRate = (WORD)devmode.dmDisplayFrequency; + if (lpGuid == NULL) { devicetypes = 1; @@ -656,8 +657,6 @@ DeleteDC((HDC)This->lpLcl->hDC); return DD_FALSE; } - - return DD_OK; // Do not relase HDC it have been map in kernel mode // DeleteDC(hdc); @@ -941,21 +940,14 @@ /* FIXME cleanup */ return DDERR_OUTOFMEMORY; } - - - /* - We need manual fill this struct member we can not trust on - the heap zero the struct if you play to much with directdraw - in Windows 2000. This is a small workaround of one of directdraw - bugs - */ /* FIXME read dwAppHackFlags flag from the system register instead for hard code it */ This->lpLcl->dwAppHackFlags = 0; - This->lpLcl->dwErrorMode = 0; + /* Do mot inistate this value if we do we can not open the HAL interface */ + //This->lpLcl->dwErrorMode = 0; This->lpLcl->dwHotTracking = 0; This->lpLcl->dwIMEState = 0; This->lpLcl->dwLocalFlags = DDRAWILCL_DIRECTDRAW7; @@ -966,7 +958,6 @@ supriese for me */ //This->lpLcl->dwObsolete1 = 0; - This->lpLcl->dwPreferredMode = 0; This->lpLcl->dwProcessId = 0; This->lpLcl->dwUnused0 = 0; This->lpLcl->hD3DInstance = NULL; @@ -974,14 +965,17 @@ This->lpLcl->hDDVxd = 0; This->lpLcl->hFocusWnd = 0; This->lpLcl->hGammaCalibrator = 0; - This->lpLcl->hWnd = 0; + /* Do mot inistate this value if we do we can not open the HAL interface */ + //This->lpLcl->hWnd = 0; This->lpLcl->hWndPopup = 0; This->lpLcl->lpCB = NULL; This->lpLcl->lpDDCB = NULL; This->lpLcl->lpDDMore = 0; This->lpLcl->lpGammaCalibrator = 0; This->lpLcl->lpGbl = &ddgbl; - This->lpLcl->lpPrimary = NULL; + + /* Do mot inistate this value if we do we can not open the HAL interface */ + //This->lpLcl->lpPrimary = NULL; This->lpLcl->pD3DIUnknown = NULL; This->lpLcl->pUnkOuter = NULL;

1 0

[ion] 25026: - Clear capacity data buffer before reading it to avoid 0xCCCCCCCC values and manually set failure code if nobody filled it in (a hack, but I don't understand our pre-Nixon-era storage stack to "properly" fix it, so this is good enough and kills off the 0xCCCCCCCC byte non-paged pool allocations.
by ion＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: ion Date: Sun Dec 3 11:08:08 2006 New Revision: 25026 URL: http://svn.reactos.org/svn/reactos?rev=25026&view=rev Log: - Clear capacity data buffer before reading it to avoid 0xCCCCCCCC values and manually set failure code if nobody filled it in (a hack, but I don't understand our pre-Nixon-era storage stack to "properly" fix it, so this is good enough and kills off the 0xCCCCCCCC byte non-paged pool allocations. Modified: trunk/reactos/drivers/storage/cdrom/cdrom.c trunk/reactos/drivers/storage/class2/class2.c Modified: trunk/reactos/drivers/storage/cdrom/cdrom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/cdrom/cdro… ============================================================================== --- trunk/reactos/drivers/storage/cdrom/cdrom.c (original) +++ trunk/reactos/drivers/storage/cdrom/cdrom.c Sun Dec 3 11:08:08 2006 @@ -1409,6 +1409,7 @@ MmBuildMdlForNonPagedPool (SubIrp->MdlAddress); Srb->DataBuffer = DataBuffer; + RtlZeroMemory(DataBuffer, sizeof(READ_CAPACITY_DATA)); IoCallDriver (DeviceExtension->PortDeviceObject, SubIrp); return; Modified: trunk/reactos/drivers/storage/class2/class2.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/class2/cla… ============================================================================== --- trunk/reactos/drivers/storage/class2/class2.c (original) +++ trunk/reactos/drivers/storage/class2/class2.c Sun Dec 3 11:08:08 2006 @@ -1772,6 +1772,7 @@ } RtlZeroMemory(&Srb, sizeof(SCSI_REQUEST_BLOCK)); + RtlZeroMemory(CapacityBuffer, sizeof(READ_CAPACITY_DATA)); Srb.CdbLength = 10; Srb.TimeOutValue = DeviceExtension->TimeOutValue; @@ -1787,6 +1788,7 @@ FALSE); DPRINT("Status: %lx\n", Status); DPRINT("Srb: %p\n", &Srb); + if (CapacityBuffer->BytesPerBlock == 0) Status = STATUS_NOT_SUPPORTED; if (NT_SUCCESS(Status)) { SectorSize = (((PUCHAR)&CapacityBuffer->BytesPerBlock)[0] << 24) |

1 0

[ion] 25025: - Enable V86/DR save in HAL Clock Interrupt (and fix build). - Add debug message to fs_rec driver to analyse why it's trying to allocate 4GB of non paged memory.
by ion＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: ion Date: Sun Dec 3 10:34:03 2006 New Revision: 25025 URL: http://svn.reactos.org/svn/reactos?rev=25025&view=rev Log: - Enable V86/DR save in HAL Clock Interrupt (and fix build). - Add debug message to fs_rec driver to analyse why it's trying to allocate 4GB of non paged memory. Modified: trunk/reactos/drivers/filesystems/fs_rec/udfs.c trunk/reactos/hal/halx86/generic/systimer.S Modified: trunk/reactos/drivers/filesystems/fs_rec/udfs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fs_rec… ============================================================================== --- trunk/reactos/drivers/filesystems/fs_rec/udfs.c (original) +++ trunk/reactos/drivers/filesystems/fs_rec/udfs.c Sun Dec 3 10:34:03 2006 @@ -232,7 +232,7 @@ DPRINT ("FsRecDeviceIoControl() failed (Status %lx)\n", Status); return(Status); } - DPRINT ("BytesPerSector: %lu\n", DiskGeometry.BytesPerSector); + DPRINT1 ("BytesPerSector: %lu\n", DiskGeometry.BytesPerSector); /* Check the volume recognition sequence */ Status = FsRecCheckVolumeRecognitionSequence(DeviceObject, Modified: trunk/reactos/hal/halx86/generic/systimer.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/systime… ============================================================================== --- trunk/reactos/hal/halx86/generic/systimer.S (original) +++ trunk/reactos/hal/halx86/generic/systimer.S Sun Dec 3 10:34:03 2006 @@ -199,10 +199,12 @@ .globl _HalpClockInterrupt@0 .func HalpClockInterrupt@0 +V86_hci: V86_TRAP_FIXUP +Dr_hci: DR_TRAP_FIXUP _HalpClockInterrupt@0: /* Enter trap */ - INT_PROLOG Hci, DoPushFakeErrorCode + INT_PROLOG hci, DoPushFakeErrorCode /* Push vector and make stack for IRQL */ push 0x30

1 0

[arty] 25024: Stable branch (mostly at 24900) WORKSFORME
by arty＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: arty Date: Sun Dec 3 07:54:29 2006 New Revision: 25024 URL: http://svn.reactos.org/svn/reactos?rev=25024&view=rev Log: Stable branch (mostly at 24900) WORKSFORME Modified: branches/arty-stable/reactos/base/applications/control/lang/fr-FR.rc branches/arty-stable/reactos/base/applications/control/lang/it-IT.rc branches/arty-stable/reactos/base/applications/control/rsrc.rc branches/arty-stable/reactos/base/applications/devmgmt/devmgmt.rc branches/arty-stable/reactos/base/applications/devmgmt/rsrc.rc branches/arty-stable/reactos/base/applications/games/solitaire/rsrc.rc branches/arty-stable/reactos/base/applications/games/solitaire/sol.rc branches/arty-stable/reactos/base/applications/games/winemine/rsrc.rc branches/arty-stable/reactos/base/applications/games/winemine/winemine.rc branches/arty-stable/reactos/base/applications/getfirefox/lang/it-IT.rc branches/arty-stable/reactos/base/applications/getfirefox/rsrc.rc branches/arty-stable/reactos/base/applications/ibrowser/fr-FR.rc branches/arty-stable/reactos/base/applications/ibrowser/ibrowser_intres.rc branches/arty-stable/reactos/base/applications/ibrowser/it-IT.rc branches/arty-stable/reactos/base/applications/imagesoft/adjust.c branches/arty-stable/reactos/base/applications/imagesoft/brightness.c branches/arty-stable/reactos/base/applications/imagesoft/contrast.c branches/arty-stable/reactos/base/applications/imagesoft/floatwindow.c branches/arty-stable/reactos/base/applications/imagesoft/imageprop.h branches/arty-stable/reactos/base/applications/imagesoft/imagesoft.rbuild branches/arty-stable/reactos/base/applications/imagesoft/lang/en-GB.rc branches/arty-stable/reactos/base/applications/imagesoft/lang/en-US.rc branches/arty-stable/reactos/base/applications/imagesoft/mainwnd.c branches/arty-stable/reactos/base/applications/imagesoft/precomp.h branches/arty-stable/reactos/base/applications/imagesoft/resource.h branches/arty-stable/reactos/base/applications/msconfig/lang/cs-CZ.rc branches/arty-stable/reactos/base/applications/msconfig/lang/it-IT.rc branches/arty-stable/reactos/base/applications/msconfig/rsrc.rc branches/arty-stable/reactos/base/applications/notepad/lang/cs-CZ.rc branches/arty-stable/reactos/base/applications/notepad/lang/fr-FR.rc branches/arty-stable/reactos/base/applications/notepad/lang/it-IT.rc branches/arty-stable/reactos/base/applications/sm/rsrc.rc branches/arty-stable/reactos/base/applications/sm/sm.rc branches/arty-stable/reactos/base/applications/sndvol32/rsrc.rc branches/arty-stable/reactos/base/applications/sndvol32/sndvol32.rc branches/arty-stable/reactos/base/applications/taskmgr/taskmgr.rc branches/arty-stable/reactos/base/setup/vmwinst/rsrc.rc branches/arty-stable/reactos/base/setup/vmwinst/vmwinst.rc branches/arty-stable/reactos/base/setup/welcome/rsrc.rc branches/arty-stable/reactos/base/setup/welcome/welcome.rc branches/arty-stable/reactos/base/system/expand/expand.rc branches/arty-stable/reactos/base/system/expand/rsrc.rc branches/arty-stable/reactos/base/system/format/format.rc branches/arty-stable/reactos/base/system/format/rsrc.rc branches/arty-stable/reactos/base/system/regsvr32/regsvr32.rc branches/arty-stable/reactos/base/system/regsvr32/rsrc.rc branches/arty-stable/reactos/base/system/rundll32/rsrc.rc branches/arty-stable/reactos/base/system/rundll32/rundll32.rc branches/arty-stable/reactos/base/system/userinit/lang/de-DE.rc branches/arty-stable/reactos/base/system/userinit/lang/el-GR.rc branches/arty-stable/reactos/base/system/userinit/lang/en-US.rc branches/arty-stable/reactos/base/system/userinit/lang/es-ES.rc branches/arty-stable/reactos/base/system/userinit/lang/fr-FR.rc branches/arty-stable/reactos/base/system/userinit/lang/hu-HU.rc branches/arty-stable/reactos/base/system/userinit/lang/ja-JP.rc branches/arty-stable/reactos/base/system/userinit/lang/nb-NO.rc branches/arty-stable/reactos/base/system/userinit/lang/ru-RU.rc branches/arty-stable/reactos/base/system/userinit/lang/sv-SE.rc branches/arty-stable/reactos/base/system/userinit/lang/uk-UA.rc branches/arty-stable/reactos/base/system/userinit/rsrc.rc branches/arty-stable/reactos/base/system/winlogon/rsrc.rc branches/arty-stable/reactos/base/system/winlogon/winlogon.rc branches/arty-stable/reactos/boot/bootdata/hivesys.inf branches/arty-stable/reactos/boot/freeldr/freeldr/reactos/reactos.c branches/arty-stable/reactos/dll/cpl/desk/settings.c branches/arty-stable/reactos/dll/cpl/mmsys/de-DE.rc branches/arty-stable/reactos/dll/cpl/mmsys/el-GR.rc branches/arty-stable/reactos/dll/cpl/mmsys/en-US.rc branches/arty-stable/reactos/dll/cpl/mmsys/es-ES.rc branches/arty-stable/reactos/dll/cpl/mmsys/fr-FR.rc branches/arty-stable/reactos/dll/cpl/mmsys/mmsys.rc branches/arty-stable/reactos/dll/cpl/mmsys/nl-NL.rc branches/arty-stable/reactos/dll/cpl/mmsys/ru-RU.rc branches/arty-stable/reactos/dll/cpl/mmsys/uk-UK.rc branches/arty-stable/reactos/dll/cpl/sysdm/en.rc branches/arty-stable/reactos/dll/cpl/sysdm/general.c branches/arty-stable/reactos/dll/cpl/sysdm/resource.h branches/arty-stable/reactos/dll/cpl/timedate/Fr.rc branches/arty-stable/reactos/dll/directx/ddraw/callbacks_hel.c branches/arty-stable/reactos/dll/directx/ddraw/callbacks_surf_hel.c branches/arty-stable/reactos/dll/directx/ddraw/ddraw.rbuild branches/arty-stable/reactos/dll/directx/ddraw/main.c branches/arty-stable/reactos/dll/directx/ddraw/main/ddraw_main.c branches/arty-stable/reactos/dll/directx/ddraw/rosdraw.h branches/arty-stable/reactos/dll/directx/ddraw/startup.c branches/arty-stable/reactos/dll/ntdll/dbg/dbgui.c branches/arty-stable/reactos/dll/ntdll/ldr/utils.c branches/arty-stable/reactos/dll/win32/console/console.rc branches/arty-stable/reactos/dll/win32/console/rsrc.rc branches/arty-stable/reactos/dll/win32/gdi32/include/gdi32p.h branches/arty-stable/reactos/dll/win32/gdi32/misc/misc.c branches/arty-stable/reactos/dll/win32/gdi32/objects/metafile.c branches/arty-stable/reactos/dll/win32/gdi32/objects/painting.c branches/arty-stable/reactos/dll/win32/kernel32/debug/debugger.c branches/arty-stable/reactos/dll/win32/kernel32/process/create.c branches/arty-stable/reactos/dll/win32/msi/action.c branches/arty-stable/reactos/dll/win32/msi/alter.c branches/arty-stable/reactos/dll/win32/msi/database.c branches/arty-stable/reactos/dll/win32/msi/delete.c branches/arty-stable/reactos/dll/win32/msi/dialog.c branches/arty-stable/reactos/dll/win32/msi/events.c branches/arty-stable/reactos/dll/win32/msi/files.c branches/arty-stable/reactos/dll/win32/msi/handle.c branches/arty-stable/reactos/dll/win32/msi/helpers.c branches/arty-stable/reactos/dll/win32/msi/insert.c branches/arty-stable/reactos/dll/win32/msi/install.c branches/arty-stable/reactos/dll/win32/msi/join.c branches/arty-stable/reactos/dll/win32/msi/msi.spec branches/arty-stable/reactos/dll/win32/msi/msi_De.rc branches/arty-stable/reactos/dll/win32/msi/msi_Nl.rc branches/arty-stable/reactos/dll/win32/msi/msi_ros.diff branches/arty-stable/reactos/dll/win32/msi/msipriv.h branches/arty-stable/reactos/dll/win32/msi/package.c branches/arty-stable/reactos/dll/win32/msi/preview.c branches/arty-stable/reactos/dll/win32/msi/query.h branches/arty-stable/reactos/dll/win32/msi/registry.c branches/arty-stable/reactos/dll/win32/msi/select.c branches/arty-stable/reactos/dll/win32/msi/source.c branches/arty-stable/reactos/dll/win32/msi/sql.tab.c branches/arty-stable/reactos/dll/win32/msi/sql.tab.h branches/arty-stable/reactos/dll/win32/msi/sql.y branches/arty-stable/reactos/dll/win32/msi/suminfo.c branches/arty-stable/reactos/dll/win32/msi/table.c branches/arty-stable/reactos/dll/win32/msi/tokenize.c branches/arty-stable/reactos/dll/win32/msi/update.c branches/arty-stable/reactos/dll/win32/msi/where.c branches/arty-stable/reactos/dll/win32/newdev/newdev.rc branches/arty-stable/reactos/dll/win32/newdev/rsrc.rc branches/arty-stable/reactos/dll/win32/setupapi/res/lang/Uk.rc branches/arty-stable/reactos/dll/win32/setupapi/setupapi.rc branches/arty-stable/reactos/dll/win32/shellext/slayer/rsrc.rc branches/arty-stable/reactos/dll/win32/shellext/slayer/slayer.rc branches/arty-stable/reactos/drivers/base/kdcom/kdcom.def branches/arty-stable/reactos/hal/hal/hal.c branches/arty-stable/reactos/hal/hal/hal.def branches/arty-stable/reactos/hal/halx86/generic/beep.c branches/arty-stable/reactos/hal/halx86/generic/bus.c branches/arty-stable/reactos/hal/halx86/generic/cmos.c branches/arty-stable/reactos/hal/halx86/generic/display.c branches/arty-stable/reactos/hal/halx86/generic/drive.c branches/arty-stable/reactos/hal/halx86/generic/generic.rbuild branches/arty-stable/reactos/hal/halx86/generic/halinit.c branches/arty-stable/reactos/hal/halx86/generic/irq.S branches/arty-stable/reactos/hal/halx86/generic/irql.c branches/arty-stable/reactos/hal/halx86/generic/misc.c branches/arty-stable/reactos/hal/halx86/generic/pci.c branches/arty-stable/reactos/hal/halx86/generic/portio.c branches/arty-stable/reactos/hal/halx86/generic/processor.c branches/arty-stable/reactos/hal/halx86/generic/profil.c branches/arty-stable/reactos/hal/halx86/generic/reboot.c branches/arty-stable/reactos/hal/halx86/generic/spinlock.c branches/arty-stable/reactos/hal/halx86/generic/sysinfo.c branches/arty-stable/reactos/hal/halx86/generic/systimer.S branches/arty-stable/reactos/hal/halx86/generic/timer.c branches/arty-stable/reactos/hal/halx86/include/halp.h branches/arty-stable/reactos/hal/halx86/mp/apic.c branches/arty-stable/reactos/hal/halx86/mp/halinit.c branches/arty-stable/reactos/hal/halx86/mp/halmp.rbuild branches/arty-stable/reactos/hal/halx86/mp/processor_mp.c branches/arty-stable/reactos/hal/halx86/mp/spinlock.c branches/arty-stable/reactos/hal/halx86/up/halinit_up.c branches/arty-stable/reactos/hal/halx86/xbox/halinit_xbox.c branches/arty-stable/reactos/include/ndk/asm.h branches/arty-stable/reactos/ntoskrnl/KrnlFun.c branches/arty-stable/reactos/ntoskrnl/dbgk/dbgkutil.c branches/arty-stable/reactos/ntoskrnl/dbgk/debug.c branches/arty-stable/reactos/ntoskrnl/ex/init.c branches/arty-stable/reactos/ntoskrnl/include/internal/dbgk.h branches/arty-stable/reactos/ntoskrnl/include/internal/i386/asmmacro.S branches/arty-stable/reactos/ntoskrnl/include/internal/mm.h branches/arty-stable/reactos/ntoskrnl/include/internal/ps.h branches/arty-stable/reactos/ntoskrnl/io/iomgr/file.c branches/arty-stable/reactos/ntoskrnl/io/iomgr/iofunc.c branches/arty-stable/reactos/ntoskrnl/ke/freeldr.c branches/arty-stable/reactos/ntoskrnl/ke/i386/clock.S branches/arty-stable/reactos/ntoskrnl/ke/i386/exp.c branches/arty-stable/reactos/ntoskrnl/ke/i386/irq.c branches/arty-stable/reactos/ntoskrnl/ke/i386/kiinit.c branches/arty-stable/reactos/ntoskrnl/ke/i386/trap.s branches/arty-stable/reactos/ntoskrnl/mm/section.c branches/arty-stable/reactos/ntoskrnl/ntoskrnl.def branches/arty-stable/reactos/ntoskrnl/ntoskrnl.rbuild branches/arty-stable/reactos/ntoskrnl/tests/TestDebug.c branches/arty-stable/reactos/ntoskrnl/tests/TestTimer.c branches/arty-stable/reactos/subsystems/ntvdm/de-DE.rc branches/arty-stable/reactos/subsystems/ntvdm/en-US.rc branches/arty-stable/reactos/subsystems/ntvdm/es-ES.rc branches/arty-stable/reactos/subsystems/ntvdm/fr-FR.rc branches/arty-stable/reactos/subsystems/ntvdm/hu-HU.rc branches/arty-stable/reactos/subsystems/ntvdm/ja-JP.rc branches/arty-stable/reactos/subsystems/ntvdm/nb-NO.rc branches/arty-stable/reactos/subsystems/ntvdm/ntvdm.rc branches/arty-stable/reactos/subsystems/ntvdm/uk-UA.rc branches/arty-stable/reactos/subsystems/win32/csrss/win32csr/conio.c branches/arty-stable/reactos/subsystems/win32/csrss/win32csr/rsrc.rc branches/arty-stable/reactos/subsystems/win32/csrss/win32csr/win32csr.rc branches/arty-stable/reactos/tools/rbuild/backend/codeblocks/codeblocks.cpp branches/arty-stable/reactos/tools/rbuild/backend/mingw/mingw.cpp branches/arty-stable/reactos/tools/rbuild/backend/mingw/mingw.h branches/arty-stable/reactos/tools/rbuild/backend/msvc/msvc.cpp branches/arty-stable/reactos/tools/rbuild/backend/msvc/msvc.h [This mail would be too long, it was shortened to contain the URLs only.] Modified: branches/arty-stable/reactos/base/applications/control/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/control/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/control/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/devmgmt/devmgmt.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/devmgmt/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/games/solitaire/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/games/solitaire/sol.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/games/winemine/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/games/winemine/winemine.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/getfirefox/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/getfirefox/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/ibrowser/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/ibrowser/ibrowser_intres.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/ibrowser/it-IT.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/adjust.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/brightness.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/contrast.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/floatwindow.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/imageprop.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/imagesoft.rbuild URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/lang/en-GB.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/mainwnd.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/precomp.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/imagesoft/resource.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/msconfig/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/msconfig/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/msconfig/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/notepad/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/notepad/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/notepad/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/sm/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/sm/sm.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/sndvol32/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/sndvol32/sndvol32.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/applications/taskmgr/taskmgr.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/applic… Modified: branches/arty-stable/reactos/base/setup/vmwinst/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/setup/… Modified: branches/arty-stable/reactos/base/setup/vmwinst/vmwinst.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/setup/… Modified: branches/arty-stable/reactos/base/setup/welcome/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/setup/… Modified: branches/arty-stable/reactos/base/setup/welcome/welcome.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/setup/… Modified: branches/arty-stable/reactos/base/system/expand/expand.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/expand/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/format/format.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/format/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/regsvr32/regsvr32.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/regsvr32/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/rundll32/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/rundll32/rundll32.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/nb-NO.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/userinit/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/winlogon/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/base/system/winlogon/winlogon.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/base/system… Modified: branches/arty-stable/reactos/boot/bootdata/hivesys.inf URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/boot/bootda… Modified: branches/arty-stable/reactos/boot/freeldr/freeldr/reactos/reactos.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/boot/freeld… Modified: branches/arty-stable/reactos/dll/cpl/desk/settings.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/des… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/de-DE.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/el-GR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/en-US.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/es-ES.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/mmsys.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/nl-NL.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/mmsys/uk-UK.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/mms… Modified: branches/arty-stable/reactos/dll/cpl/sysdm/en.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/sys… Modified: branches/arty-stable/reactos/dll/cpl/sysdm/general.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/sys… Modified: branches/arty-stable/reactos/dll/cpl/sysdm/resource.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/sys… Modified: branches/arty-stable/reactos/dll/cpl/timedate/Fr.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/cpl/tim… Modified: branches/arty-stable/reactos/dll/directx/ddraw/callbacks_hel.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/directx/ddraw/callbacks_surf_hel.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/directx/ddraw/ddraw.rbuild URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/directx/ddraw/main.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/directx/ddraw/main/ddraw_main.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/directx/ddraw/rosdraw.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/directx… Modified: branches/arty-stable/reactos/dll/ntdll/dbg/dbgui.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/ntdll/d… Modified: branches/arty-stable/reactos/dll/ntdll/ldr/utils.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/ntdll/l… Modified: branches/arty-stable/reactos/dll/win32/console/console.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/c… Modified: branches/arty-stable/reactos/dll/win32/console/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/c… Modified: branches/arty-stable/reactos/dll/win32/gdi32/include/gdi32p.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/g… Modified: branches/arty-stable/reactos/dll/win32/gdi32/misc/misc.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/g… Modified: branches/arty-stable/reactos/dll/win32/gdi32/objects/metafile.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/g… Modified: branches/arty-stable/reactos/dll/win32/gdi32/objects/painting.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/g… Modified: branches/arty-stable/reactos/dll/win32/kernel32/debug/debugger.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/k… Modified: branches/arty-stable/reactos/dll/win32/kernel32/process/create.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/k… Modified: branches/arty-stable/reactos/dll/win32/msi/action.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/alter.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/database.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/delete.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/dialog.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/events.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/files.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/handle.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/helpers.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/insert.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/install.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/join.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/msi.spec URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/msi_De.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/msi_Nl.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/msi_ros.diff URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/msipriv.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/package.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/preview.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/query.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/registry.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/select.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/source.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/sql.tab.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/sql.tab.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/sql.y URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/suminfo.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/table.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/tokenize.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/update.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/msi/where.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/m… Modified: branches/arty-stable/reactos/dll/win32/newdev/newdev.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/n… Modified: branches/arty-stable/reactos/dll/win32/newdev/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/n… Modified: branches/arty-stable/reactos/dll/win32/setupapi/res/lang/Uk.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/s… Modified: branches/arty-stable/reactos/dll/win32/setupapi/setupapi.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/s… Modified: branches/arty-stable/reactos/dll/win32/shellext/slayer/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/s… Modified: branches/arty-stable/reactos/dll/win32/shellext/slayer/slayer.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/dll/win32/s… Modified: branches/arty-stable/reactos/drivers/base/kdcom/kdcom.def URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/drivers/bas… Modified: branches/arty-stable/reactos/hal/hal/hal.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/hal/hal… Modified: branches/arty-stable/reactos/hal/hal/hal.def URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/hal/hal… Modified: branches/arty-stable/reactos/hal/halx86/generic/beep.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/bus.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/cmos.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/display.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/drive.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/generic.rbuild URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/halinit.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/irq.S URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/irql.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/misc.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/pci.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/portio.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/processor.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/profil.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/reboot.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/spinlock.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/sysinfo.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/systimer.S URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/generic/timer.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/include/halp.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/mp/apic.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/mp/halinit.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/mp/halmp.rbuild URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/mp/processor_mp.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/mp/spinlock.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/up/halinit_up.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/hal/halx86/xbox/halinit_xbox.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/hal/halx86/… Modified: branches/arty-stable/reactos/include/ndk/asm.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/include/ndk… Modified: branches/arty-stable/reactos/ntoskrnl/KrnlFun.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/Kr… Modified: branches/arty-stable/reactos/ntoskrnl/dbgk/dbgkutil.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/db… Modified: branches/arty-stable/reactos/ntoskrnl/dbgk/debug.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/db… Modified: branches/arty-stable/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ex… Modified: branches/arty-stable/reactos/ntoskrnl/include/internal/dbgk.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/in… Modified: branches/arty-stable/reactos/ntoskrnl/include/internal/i386/asmmacro.S URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/in… Modified: branches/arty-stable/reactos/ntoskrnl/include/internal/mm.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/in… Modified: branches/arty-stable/reactos/ntoskrnl/include/internal/ps.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/in… Modified: branches/arty-stable/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/io… Modified: branches/arty-stable/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/io… Modified: branches/arty-stable/reactos/ntoskrnl/ke/freeldr.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ke… Modified: branches/arty-stable/reactos/ntoskrnl/ke/i386/clock.S URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ke… Modified: branches/arty-stable/reactos/ntoskrnl/ke/i386/exp.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ke… Modified: branches/arty-stable/reactos/ntoskrnl/ke/i386/irq.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ke… Modified: branches/arty-stable/reactos/ntoskrnl/ke/i386/kiinit.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ke… Modified: branches/arty-stable/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/ke… Modified: branches/arty-stable/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/mm… Modified: branches/arty-stable/reactos/ntoskrnl/ntoskrnl.def URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/nt… Modified: branches/arty-stable/reactos/ntoskrnl/ntoskrnl.rbuild URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/nt… Modified: branches/arty-stable/reactos/ntoskrnl/tests/TestDebug.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/te… Modified: branches/arty-stable/reactos/ntoskrnl/tests/TestTimer.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/ntoskrnl/te… Modified: branches/arty-stable/reactos/subsystems/ntvdm/de-DE.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/en-US.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/es-ES.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/nb-NO.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/ntvdm.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/ntvdm/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/win32/csrss/win32csr/conio.c URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/win32/csrss/win32csr/rsrc.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/subsystems/win32/csrss/win32csr/win32csr.rc URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/subsystems/… Modified: branches/arty-stable/reactos/tools/rbuild/backend/codeblocks/codeblocks.cpp URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/tools/rbuil… Modified: branches/arty-stable/reactos/tools/rbuild/backend/mingw/mingw.cpp URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/tools/rbuil… Modified: branches/arty-stable/reactos/tools/rbuild/backend/mingw/mingw.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/tools/rbuil… Modified: branches/arty-stable/reactos/tools/rbuild/backend/msvc/msvc.cpp URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/tools/rbuil… Modified: branches/arty-stable/reactos/tools/rbuild/backend/msvc/msvc.h URL: http://svn.reactos.org/svn/reactos/branches/arty-stable/reactos/tools/rbuil…

1 0

[arty] 25023: Create a stable branch for working on x86.
by arty＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: arty Date: Sun Dec 3 06:49:15 2006 New Revision: 25023 URL: http://svn.reactos.org/svn/reactos?rev=25023&view=rev Log: Create a stable branch for working on x86. Added: branches/arty-stable/ - copied from r25022, trunk/

1 0

[greatlrd] 25022: fixed a werid crash do not initate the member dwObsolete1 in LPDDRAWI_DIRECTDRAW_LCL
by greatlrd＠svn.reactos.org 03 Dec '06

03 Dec '06

Author: greatlrd Date: Sun Dec 3 03:17:56 2006 New Revision: 25022 URL: http://svn.reactos.org/svn/reactos?rev=25022&view=rev Log: fixed a werid crash do not initate the member dwObsolete1 in LPDDRAWI_DIRECTDRAW_LCL Modified: trunk/reactos/dll/directx/ddraw/startup.c Modified: trunk/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/startup.… ============================================================================== --- trunk/reactos/dll/directx/ddraw/startup.c (original) +++ trunk/reactos/dll/directx/ddraw/startup.c Sun Dec 3 03:17:56 2006 @@ -960,7 +960,12 @@ This->lpLcl->dwIMEState = 0; This->lpLcl->dwLocalFlags = DDRAWILCL_DIRECTDRAW7; This->lpLcl->dwLocalRefCnt = 0; - This->lpLcl->dwObsolete1 = 0; + /* + do not rest this flag to NULL it need be unistae for some reason other wise + somet thing will crash dwObsolete1 seam being use for something this was a + supriese for me + */ + //This->lpLcl->dwObsolete1 = 0; This->lpLcl->dwPreferredMode = 0; This->lpLcl->dwProcessId = 0; This->lpLcl->dwUnused0 = 0;

1 0

[greatlrd] 25021: bug fixed some more info getting same as ms ddraw when you execute DirectDrawCreateEx fixed some comment in main.c, Comment why memory does not being fill to zero in lest windows 2000 after you play with directdraw.
by greatlrd＠svn.reactos.org 02 Dec '06

02 Dec '06

Author: greatlrd Date: Sun Dec 3 02:04:11 2006 New Revision: 25021 URL: http://svn.reactos.org/svn/reactos?rev=25021&view=rev Log: bug fixed some more info getting same as ms ddraw when you execute DirectDrawCreateEx fixed some comment in main.c, Comment why memory does not being fill to zero in lest windows 2000 after you play with directdraw. Modified: trunk/reactos/dll/directx/ddraw/main.c trunk/reactos/dll/directx/ddraw/startup.c Modified: trunk/reactos/dll/directx/ddraw/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/main.c?r… ============================================================================== --- trunk/reactos/dll/directx/ddraw/main.c (original) +++ trunk/reactos/dll/directx/ddraw/main.c Sun Dec 3 02:04:11 2006 @@ -33,9 +33,14 @@ DirectDrawCreate (LPGUID lpGUID, LPDIRECTDRAW* lplpDD, LPUNKNOWN pUnkOuter) -{ +{ + /* + remove this when UML digram are in place + this api is finish and is working as it should + */ DX_WINDBG_trace(); + /* check the pointer if it vaild to read from */ if (IsBadWritePtr( lplpDD, sizeof( LPVOID )) ) { return DDERR_INVALIDPARAMS; @@ -44,10 +49,11 @@ /* check see if pUnkOuter is null or not */ if (pUnkOuter) { - /* we do not use same error code as MS, ms use CLASS_E_NOAGGREGATION */ - return CLASS_E_NOAGGREGATION; + /* we are using same error code as MS*/ + return CLASS_E_NOAGGREGATION; } + /* Create our DirectDraw interface */ return Create_DirectDraw (lpGUID, lplpDD, &IID_IDirectDraw7, FALSE); } @@ -63,8 +69,13 @@ REFIID id, LPUNKNOWN pUnkOuter) { + /* + remove this when UML digram are in place + this api is finish and is working as it should + */ DX_WINDBG_trace(); + /* check the pointer if it vaild to read from */ if (IsBadWritePtr( lplpDD, sizeof( LPVOID )) ) { return DDERR_INVALIDPARAMS; @@ -73,7 +84,7 @@ /* check see if pUnkOuter is null or not */ if (pUnkOuter) { - /* we do not use same error code as MS, ms use CLASS_E_NOAGGREGATION */ + /* we are using same error code as MS*/ return CLASS_E_NOAGGREGATION; } @@ -83,6 +94,7 @@ return DDERR_INVALIDPARAMS; } + /* Create our DirectDraw interface */ return Create_DirectDraw (lpGUID, (LPDIRECTDRAW*)lplpDD, id, TRUE); } Modified: trunk/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/startup.… ============================================================================== --- trunk/reactos/dll/directx/ddraw/startup.c (original) +++ trunk/reactos/dll/directx/ddraw/startup.c Sun Dec 3 02:04:11 2006 @@ -942,9 +942,43 @@ return DDERR_OUTOFMEMORY; } + + /* + We need manual fill this struct member we can not trust on + the heap zero the struct if you play to much with directdraw + in Windows 2000. This is a small workaround of one of directdraw + bugs + */ + + /* + FIXME + read dwAppHackFlags flag from the system register instead for hard code it + */ + This->lpLcl->dwAppHackFlags = 0; + This->lpLcl->dwErrorMode = 0; + This->lpLcl->dwHotTracking = 0; + This->lpLcl->dwIMEState = 0; + This->lpLcl->dwLocalFlags = DDRAWILCL_DIRECTDRAW7; + This->lpLcl->dwLocalRefCnt = 0; + This->lpLcl->dwObsolete1 = 0; + This->lpLcl->dwPreferredMode = 0; + This->lpLcl->dwProcessId = 0; + This->lpLcl->dwUnused0 = 0; + This->lpLcl->hD3DInstance = NULL; + This->lpLcl->hDC = 0; + This->lpLcl->hDDVxd = 0; + This->lpLcl->hFocusWnd = 0; + This->lpLcl->hGammaCalibrator = 0; + This->lpLcl->hWnd = 0; + This->lpLcl->hWndPopup = 0; + This->lpLcl->lpCB = NULL; + This->lpLcl->lpDDCB = NULL; + This->lpLcl->lpDDMore = 0; + This->lpLcl->lpGammaCalibrator = 0; This->lpLcl->lpGbl = &ddgbl; - This->lpLcl->dwLocalRefCnt = 0; - This->lpLcl->dwLocalFlags = DDRAWILCL_DIRECTDRAW7; + This->lpLcl->lpPrimary = NULL; + This->lpLcl->pD3DIUnknown = NULL; + This->lpLcl->pUnkOuter = NULL; *pIface = (LPDIRECTDRAW)This; @@ -955,7 +989,7 @@ if (StartDirectDraw((LPDIRECTDRAW*)This, pGUID) == DD_OK); { - + This->lpLcl->hDD = ddgbl.hDD; return DD_OK; }

1 0

[ion] 25020: - Implement V86 trap fixup during traps and interrupts. - Implement DR register save/restore during traps, interrupts and system calls. - Remove respective entry from krnlfun.c.
by ion＠svn.reactos.org 02 Dec '06

02 Dec '06

Author: ion Date: Sat Dec 2 23:49:56 2006 New Revision: 25020 URL: http://svn.reactos.org/svn/reactos?rev=25020&view=rev Log: - Implement V86 trap fixup during traps and interrupts. - Implement DR register save/restore during traps, interrupts and system calls. - Remove respective entry from krnlfun.c. Modified: trunk/reactos/include/ndk/asm.h trunk/reactos/ntoskrnl/KrnlFun.c trunk/reactos/ntoskrnl/include/internal/i386/asmmacro.S trunk/reactos/ntoskrnl/ke/i386/trap.s Modified: trunk/reactos/include/ndk/asm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/asm.h?rev=2502… ============================================================================== --- trunk/reactos/include/ndk/asm.h (original) +++ trunk/reactos/include/ndk/asm.h Sat Dec 2 23:49:56 2006 @@ -135,6 +135,16 @@ #define KPROCESS_IOPM_OFFSET 0x30 #define KPROCESS_ACTIVE_PROCESSORS 0x34 #define EPROCESS_VDM_OBJECTS 0x144 + +// +// KPRCB Offsets +// +#define KPRCB_DR0 0x2F8 +#define KPRCB_DR1 0x2FC +#define KPRCB_DR2 0x300 +#define KPRCB_DR3 0x304 +#define KPRCB_DR6 0x308 +#define KPRCB_DR7 0x20C // // KPCR Offsets Modified: trunk/reactos/ntoskrnl/KrnlFun.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/KrnlFun.c?rev=250… ============================================================================== --- trunk/reactos/ntoskrnl/KrnlFun.c (original) +++ trunk/reactos/ntoskrnl/KrnlFun.c Sat Dec 2 23:49:56 2006 @@ -28,7 +28,6 @@ // // Ke: // - Figure out why the DPC stack doesn't really work. -// - Add DR macro/save and VM macro/save. // - New optimized table-based tick-hashed timer implementation. // - New Thread Scheduler based on 2003. // - Implement KiCallbackReturn, KiGetTickCount, KiRaiseAssertion. Modified: trunk/reactos/ntoskrnl/include/internal/i386/asmmacro.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/i386/asmmacro.S (original) +++ trunk/reactos/ntoskrnl/include/internal/i386/asmmacro.S Sat Dec 2 23:49:56 2006 @@ -187,6 +187,104 @@ .endm // +// @name V86_TRAP_FIXUP +// +// This macro sets up the debug header in the trap frame. +// +// @param None. +// +// @remark ebp = PKTRAP_FRAME +// +.macro V86_TRAP_FIXUP + /* Get V86 segment registers */ + mov eax, [ebp+KTRAP_FRAME_V86_FS] + mov ebx, [ebp+KTRAP_FRAME_V86_GS] + mov ecx, [ebp+KTRAP_FRAME_V86_ES] + mov edx, [ebp+KTRAP_FRAME_V86_DS] + + /* Restore them into Protected Mode trap frame */ + mov [ebp+KTRAP_FRAME_FS], ax + mov [ebp+KTRAP_FRAME_GS], bx + mov [ebp+KTRAP_FRAME_ES], cx + mov [ebp+KTRAP_FRAME_DS], dx + + /* Go back to mainline code */ + jmp 1f +.endm + +// +// @name DR_TRAP_FIXUP +// +// This macro sets up the debug header in the trap frame. +// +// @param None. +// +// @remark ebp = PKTRAP_FRAME +// +.macro DR_TRAP_FIXUP + /* Check if this was V86 mode */ + test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK + jnz 2f + + /* Check if it was user mode */ + test byte ptr [ebp+KTRAP_FRAME_CS], MODE_MASK + jz 3f + +2: + /* Get DR0, 1, 2 */ + mov ebx, dr0 + mov ecx, dr1 + mov edi, dr2 + + /* Save them */ + mov [ebp+KTRAP_FRAME_DR0], ebx + mov [ebp+KTRAP_FRAME_DR1], ecx + mov [ebp+KTRAP_FRAME_DR2], edi + + /* Get DR3, 6, 7 */ + mov ebx, dr0 + mov ecx, dr1 + mov edi, dr2 + + /* Save them */ + mov [ebp+KTRAP_FRAME_DR3], ebx + mov [ebp+KTRAP_FRAME_DR6], ecx + mov [ebp+KTRAP_FRAME_DR7], edi + + /* Clear DR7 */ + xor ebx, ebx + mov dr7, ebx + + /* Get the PRCB */ + mov edi, PCR[KPCR_PRCB] + + /* Get DR0, 1 */ + mov ebx, [edi+KPRCB_DR0] + mov ecx, [edi+KPRCB_DR1] + + /* Set them */ + mov dr0, ebx + mov dr1, ecx + + /* Get DR2, 3 */ + mov ebx, [edi+KPRCB_DR2] + mov ecx, [edi+KPRCB_DR3] + + /* Set them */ + mov dr2, ebx + mov dr3, ecx + + /* Get DR6, 7 */ + mov ebx, [edi+KPRCB_DR6] + mov ecx, [edi+KPRCB_DR7] + + /* Set them */ + mov dr6, ebx + mov dr7, ecx + jz 3f +.endm + +// // @name SET_TF_DEBUG_HEADER // // This macro sets up the debug header in the trap frame. @@ -315,6 +413,7 @@ /* Save FS and set it to PCR */ push fs mov ebx, KGDT_R0_PCR + .byte 0x66 mov fs, bx /* Save exception list and bogus previous mode */ @@ -336,16 +435,23 @@ sub esp, 0x30 /* Load the segment registers */ + .byte 0x66 mov ds, ax + .byte 0x66 mov es, ax + + /* Check if this interrupt happened in 16-bit mode */ + cmp esp, 0x10000 + jb _Ki16BitStackException /* Set up frame */ mov ebp, esp /* Check if this was from V86 Mode */ - /* test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK; */ - /* jnz V86_Label; */ - + test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK + jnz V86_&Label + +1: /* Get current thread */ mov ecx, [fs:KPCR_CURRENT_THREAD] cld @@ -353,9 +459,10 @@ /* Flush DR7 */ and dword ptr [ebp+KTRAP_FRAME_DR7], 0 +3: /* Check if the thread was being debugged */ - /* test byte ptr [ecx+KTHREAD_DEBUG_ACTIVE], 0xFF; */ - /* jnz Dr_Label; */ + test byte ptr [ecx+KTHREAD_DEBUG_ACTIVE], 0xFF + jnz Dr_&Label /* Set the Trap Frame Debug Header */ SET_TF_DEBUG_HEADER @@ -399,10 +506,11 @@ mov dword ptr [esp+KTRAP_FRAME_PREVIOUS_MODE], -1 /* Check if this was from V86 Mode */ - /* test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK */ - /* jnz V86_&Label*/ + test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK + jnz V86_&Label /* Check if this was kernel mode */ +1: cmp dword ptr [esp+KTRAP_FRAME_CS], KGDT_R0_CODE jz 1f @@ -463,9 +571,10 @@ .endif /* Save DR registers if needed */ - //jnz Dr_&Label + jnz Dr_&Label /* Set the trap frame debug header */ +3: SET_TF_DEBUG_HEADER .endm @@ -484,7 +593,7 @@ // // @remark None. // -.macro SYSCALL_PROLOG +.macro SYSCALL_PROLOG Label /* Create a trap frame */ push 0 push ebp @@ -495,6 +604,7 @@ /* Load PCR Selector into fs */ mov ebx, KGDT_R0_PCR + .byte 0x66 mov fs, bx /* Get a pointer to the current thread */ @@ -507,19 +617,15 @@ mov dword ptr [fs:KPCR_EXCEPTION_LIST], -1 /* Save the old previous mode */ - push ss:[esi+KTHREAD_PREVIOUS_MODE] + push [esi+KTHREAD_PREVIOUS_MODE] /* Skip the other registers */ sub esp, 0x48 - - /* Hack: it seems that on VMWare someone damages ES/DS on exit. Investigate! */ - mov [esp+KTRAP_FRAME_DS], ds - mov [esp+KTRAP_FRAME_ES], es /* Set the new previous mode based on the saved CS selector */ mov ebx, [esp+0x6C] and ebx, 1 - mov byte ptr ss:[esi+KTHREAD_PREVIOUS_MODE], bl + mov byte ptr [esi+KTHREAD_PREVIOUS_MODE], bl /* Go on the Kernel stack frame */ mov ebp, esp @@ -539,9 +645,108 @@ cld /* Save DR registers if needed */ - //jnz Dr_kss_&Label + jnz Dr_&Label /* Set the trap frame debug header */ +3: + SET_TF_DEBUG_HEADER + + /* Enable interrupts */ + sti +.endm + +// +// @name FASTCALL_PROLOG +// +// TODO +// +// @param Label +// Unique label identifying the name of the caller function; will be +// used to append to the name of the DR helper function, which must +// already exist. +// +// @remark None. +// +.macro FASTCALL_PROLOG Label + /* Set FS to PCR */ + mov ecx, KGDT_R0_PCR + mov fs, cx + //push KGDT_R0_PCR + //pop fs + + /* Set user selector */ + mov ecx, KGDT_R3_DATA | RPL_MASK + + /* Set DS/ES to User Selector */ + mov ds, cx + mov es, cx + + /* Set the current stack to Kernel Stack */ + mov ecx, [fs:KPCR_TSS] + mov esp, [ecx+KTSS_ESP0] + + /* Set up a fake INT Stack. */ + push KGDT_R3_DATA + RPL_MASK + push edx /* Ring 3 SS:ESP */ + pushf /* Ring 3 EFLAGS */ + push 2 /* Ring 0 EFLAGS */ + add edx, 8 /* Skip user parameter list */ + popf /* Set our EFLAGS */ + or dword ptr [esp], EFLAGS_INTERRUPT_MASK /* Re-enable IRQs in EFLAGS, to fake INT */ + push KGDT_R3_CODE + RPL_MASK + push dword ptr ds:KUSER_SHARED_SYSCALL_RET + + /* Setup the Trap Frame stack */ + push 0 + push ebp + push ebx + push esi + push edi + push KGDT_R3_TEB + RPL_MASK + + /* Save pointer to our PCR */ + mov ebx, [fs:KPCR_SELF] + + /* Get a pointer to the current thread */ + mov esi, [ebx+KPCR_CURRENT_THREAD] + + /* Set the exception handler chain terminator */ + push [ebx+KPCR_EXCEPTION_LIST] + mov dword ptr [ebx+KPCR_EXCEPTION_LIST], -1 + + /* Use the thread's stack */ + mov ebp, [esi+KTHREAD_INITIAL_STACK] + + /* Push previous mode */ + push UserMode + + /* Skip the other registers */ + sub esp, 0x48 + + /* Make space for us on the stack */ + sub ebp, 0x29C + + /* Write the previous mode */ + mov byte ptr [esi+KTHREAD_PREVIOUS_MODE], UserMode + + /* Sanity check */ + cmp ebp, esp + jnz BadStack + + /* Flush DR7 */ + and dword ptr [ebp+KTRAP_FRAME_DR7], 0 + + /* Check if the thread was being debugged */ + test byte ptr [esi+KTHREAD_DEBUG_ACTIVE], 0xFF + + /* Set the thread's trap frame */ + mov [esi+KTHREAD_TRAP_FRAME], ebp + + /* Save DR registers if needed */ + jnz Dr_&Label + + /* Set the trap frame debug header */ +3: SET_TF_DEBUG_HEADER /* Enable interrupts */ @@ -966,6 +1171,13 @@ mov esi, [esp+KTRAP_FRAME_EIP] mov [ebx], esi +.if \RestoreVolatiles + /* Restore volatiles */ + mov eax, [esp+KTRAP_FRAME_EAX] + mov edx, [esp+KTRAP_FRAME_EDX] + mov ecx, [esp+KTRAP_FRAME_ECX] +.endif + /* Return */ add esp, KTRAP_FRAME_EDI pop edi Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s Sat Dec 2 23:49:56 2006 @@ -96,100 +96,22 @@ int 3 .func KiSystemService +Dr_kss: DR_TRAP_FIXUP _KiSystemService: /* Enter the shared system call prolog */ - SYSCALL_PROLOG + SYSCALL_PROLOG kss /* Jump to the actual handler */ jmp SharedCode .endfunc .func KiFastCallEntry +Dr_FastCallDrSave: DR_TRAP_FIXUP _KiFastCallEntry: - /* Set FS to PCR */ - mov ecx, KGDT_R0_PCR - mov fs, cx - //push KGDT_R0_PCR - //pop fs - - /* Set user selector */ - mov ecx, KGDT_R3_DATA | RPL_MASK - - /* Set DS/ES to User Selector */ - mov ds, cx - mov es, cx - - /* Set the current stack to Kernel Stack */ - mov ecx, [fs:KPCR_TSS] - mov esp, ss:[ecx+KTSS_ESP0] - - /* Set up a fake INT Stack. */ - push KGDT_R3_DATA + RPL_MASK - push edx /* Ring 3 SS:ESP */ - pushf /* Ring 3 EFLAGS */ - push 2 /* Ring 0 EFLAGS */ - add edx, 8 /* Skip user parameter list */ - popf /* Set our EFLAGS */ - or dword ptr [esp], EFLAGS_INTERRUPT_MASK /* Re-enable IRQs in EFLAGS, to fake INT */ - push KGDT_R3_CODE + RPL_MASK - push dword ptr ds:KUSER_SHARED_SYSCALL_RET - - /* Setup the Trap Frame stack */ - push 0 - push ebp - push ebx - push esi - push edi - push KGDT_R3_TEB + RPL_MASK - - /* Save pointer to our PCR */ - mov ebx, [fs:KPCR_SELF] - - /* Get a pointer to the current thread */ - mov esi, [ebx+KPCR_CURRENT_THREAD] - - /* Set the exception handler chain terminator */ - push [ebx+KPCR_EXCEPTION_LIST] - mov dword ptr [ebx+KPCR_EXCEPTION_LIST], -1 - - /* Use the thread's stack */ - mov ebp, [esi+KTHREAD_INITIAL_STACK] - - /* Push previous mode */ - push UserMode - - /* Skip the other registers */ - sub esp, 0x48 - - /* Make space for us on the stack */ - sub ebp, 0x29C - - /* Write the previous mode */ - mov byte ptr [esi+KTHREAD_PREVIOUS_MODE], UserMode - - /* Sanity check */ - cmp ebp, esp - jnz BadStack - - /* Flush DR7 */ - and dword ptr [ebp+KTRAP_FRAME_DR7], 0 - - /* Check if the thread was being debugged */ - test byte ptr [esi+KTHREAD_DEBUG_ACTIVE], 0xFF - - /* Set the thread's trap frame */ - mov [esi+KTHREAD_TRAP_FRAME], ebp - - /* Save DR registers if needed */ - //jnz Dr_FastCallDrSave - - /* Set the trap frame debug header */ - SET_TF_DEBUG_HEADER - - /* Enable interrupts */ - sti + /* Enter the fast system call prolog */ + FASTCALL_PROLOG FastCallDrSave SharedCode: @@ -514,13 +436,15 @@ int 3 .func KiDebugService +Dr_kids: DR_TRAP_FIXUP +V86_kids: V86_TRAP_FIXUP _KiDebugService: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(kids) + TRAP_PROLOG kids /* Increase EIP so we skip the INT3 */ //inc dword ptr [ebp+KTRAP_FRAME_EIP] @@ -749,12 +673,14 @@ /* HARDWARE TRAP HANDLERS ****************************************************/ .func KiTrap0 +Dr_kit0: DR_TRAP_FIXUP +V86_kit0: V86_TRAP_FIXUP _KiTrap0: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(0) + TRAP_PROLOG kit0 /* Check for V86 */ test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK @@ -788,12 +714,14 @@ .endfunc .func KiTrap1 +Dr_kit1: DR_TRAP_FIXUP +V86_kit1: V86_TRAP_FIXUP _KiTrap1: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(1) + TRAP_PROLOG kit1 /* Check for V86 */ test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK @@ -839,12 +767,14 @@ .endfunc .func KiTrap3 +Dr_kit3: DR_TRAP_FIXUP +V86_kit3: V86_TRAP_FIXUP _KiTrap3: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(3) + TRAP_PROLOG kit3 /* Check for V86 */ test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK @@ -887,12 +817,14 @@ .endfunc .func KiTrap4 +Dr_kit4: DR_TRAP_FIXUP +V86_kit4: V86_TRAP_FIXUP _KiTrap4: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(4) + TRAP_PROLOG kit4 /* Check for V86 */ test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK @@ -927,12 +859,14 @@ .endfunc .func KiTrap5 +Dr_kit5: DR_TRAP_FIXUP +V86_kit5: V86_TRAP_FIXUP _KiTrap5: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(5) + TRAP_PROLOG kit5 /* Check for V86 */ test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK @@ -971,6 +905,8 @@ .endfunc .func KiTrap6 +Dr_kit6: DR_TRAP_FIXUP +V86_kit6: V86_TRAP_FIXUP _KiTrap6: /* It this a V86 GPF? */ @@ -989,7 +925,7 @@ push 0 /* Enter trap */ - TRAP_PROLOG(6) + TRAP_PROLOG kit6 /* Check if this happened in kernel mode */ test byte ptr [ebp+KTRAP_FRAME_CS], MODE_MASK @@ -1086,12 +1022,14 @@ .endfunc .func KiTrap7 +Dr_kit7: DR_TRAP_FIXUP +V86_kit7: V86_TRAP_FIXUP _KiTrap7: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(7) + TRAP_PROLOG kit7 /* Get the current thread and stack */ StartTrapHandle: @@ -1405,12 +1343,14 @@ .endfunc .func KiTrap9 +Dr_kit9: DR_TRAP_FIXUP +V86_kit9: V86_TRAP_FIXUP _KiTrap9: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(9) + TRAP_PROLOG kit9 /* Enable interrupts and bugcheck */ sti @@ -1419,9 +1359,11 @@ .endfunc .func KiTrap10 +Dr_kit10: DR_TRAP_FIXUP +V86_kit10: V86_TRAP_FIXUP _KiTrap10: /* Enter trap */ - TRAP_PROLOG(10) + TRAP_PROLOG kit10 /* Check for V86 */ test dword ptr [ebp+KTRAP_FRAME_EFLAGS], EFLAGS_V86_MASK @@ -1448,9 +1390,11 @@ .endfunc .func KiTrap11 +Dr_kit11: DR_TRAP_FIXUP +V86_kit11: V86_TRAP_FIXUP _KiTrap11: /* Enter trap */ - TRAP_PROLOG(11) + TRAP_PROLOG kit11 /* FIXME: ROS Doesn't handle segment faults yet */ mov eax, 11 @@ -1458,9 +1402,11 @@ .endfunc .func KiTrap12 +Dr_kit12: DR_TRAP_FIXUP +V86_kit12: V86_TRAP_FIXUP _KiTrap12: /* Enter trap */ - TRAP_PROLOG(12) + TRAP_PROLOG kit12 /* FIXME: ROS Doesn't handle stack faults yet */ mov eax, 12 @@ -1468,6 +1414,8 @@ .endfunc .func KiTrap13 +Dr_kitd: DR_TRAP_FIXUP +V86_kitd: V86_TRAP_FIXUP _KiTrap13: /* It this a V86 GPF? */ @@ -1531,7 +1479,7 @@ NotV86: /* Enter trap */ - TRAP_PROLOG(13) + TRAP_PROLOG kitd /* Check if this was from kernel-mode */ test dword ptr [ebp+KTRAP_FRAME_CS], MODE_MASK @@ -1678,9 +1626,11 @@ .endfunc .func KiTrap14 +Dr_kit14: DR_TRAP_FIXUP +V86_kit14: V86_TRAP_FIXUP _KiTrap14: /* Enter trap */ - TRAP_PROLOG(14) + TRAP_PROLOG kit14 /* Call the C exception handler */ push 14 @@ -1693,12 +1643,14 @@ .endfunc .func KiTrap0F +Dr_kit15: DR_TRAP_FIXUP +V86_kit15: V86_TRAP_FIXUP _KiTrap0F: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(15) + TRAP_PROLOG kit15 sti /* Raise a fatal exception */ @@ -1707,12 +1659,14 @@ .endfunc .func KiTrap16 +Dr_kit16: DR_TRAP_FIXUP +V86_kit16: V86_TRAP_FIXUP _KiTrap16: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(16) + TRAP_PROLOG kit16 /* Check if this is the NPX Thread */ mov eax, fs:[KPCR_CURRENT_THREAD] @@ -1732,12 +1686,14 @@ .endfunc .func KiTrap17 +Dr_kit17: DR_TRAP_FIXUP +V86_kit17: V86_TRAP_FIXUP _KiTrap17: /* Push error code */ push 0 /* Enter trap */ - TRAP_PROLOG(17) + TRAP_PROLOG kit17 /* FIXME: ROS Doesn't handle alignment faults yet */ mov eax, 17 @@ -1784,6 +1740,22 @@ ret .endfunc +.func Ki16BitStackException +_Ki16BitStackException: + + /* Save stack */ + push ss + push esp + + /* Go to kernel mode thread stack */ + mov eax, fs:[KPCR_CURRENT_THREAD] + add esp, [eax+KTHREAD_INITIAL_STACK] + + /* Switch to good stack segment */ + /* TODO */ + int 3 +.endfunc + /* UNEXPECTED INTERRUPT HANDLERS **********************************************/ .globl _KiStartUnexpectedRange@0 @@ -1796,6 +1768,8 @@ jmp _KiUnexpectedInterruptTail .func KiUnexpectedInterruptTail +V86_kui: V86_TRAP_FIXUP +Dr_kui: DR_TRAP_FIXUP _KiUnexpectedInterruptTail: /* Enter interrupt trap */ @@ -1907,6 +1881,8 @@ .endfunc .func KiInterruptTemplate +V86_kit: V86_TRAP_FIXUP +Dr_kit: DR_TRAP_FIXUP _KiInterruptTemplate: /* Enter interrupt trap */

1 0

[greatlrd] 25019: fixed so only NULL and DDCREATE_HARDWAREONLY are accpect when you linking two directdraw interface.
by greatlrd＠svn.reactos.org 02 Dec '06

02 Dec '06

Author: greatlrd Date: Sat Dec 2 22:26:55 2006 New Revision: 25019 URL: http://svn.reactos.org/svn/reactos?rev=25019&view=rev Log: fixed so only NULL and DDCREATE_HARDWAREONLY are accpect when you linking two directdraw interface. Modified: trunk/reactos/dll/directx/ddraw/startup.c Modified: trunk/reactos/dll/directx/ddraw/startup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/startup.… ============================================================================== --- trunk/reactos/dll/directx/ddraw/startup.c (original) +++ trunk/reactos/dll/directx/ddraw/startup.c Sat Dec 2 22:26:55 2006 @@ -912,12 +912,24 @@ else { /* We got the DirectDraw interface alloc and we need create the link */ - LPDDRAWI_DIRECTDRAW_INT newThis; + + LPDDRAWI_DIRECTDRAW_INT newThis; newThis = DxHeapMemAlloc(sizeof(DDRAWI_DIRECTDRAW_INT)); if (newThis == NULL) { return DDERR_OUTOFMEMORY; } + + /* we need check the GUID lpGUID what type it is */ + if (pGUID != DDCREATE_HARDWAREONLY) + { + if (pGUID !=NULL) + { + This = newThis; + return DDERR_INVALIDDIRECTDRAWGUID; + } + } + newThis->lpLink = This; This = newThis; }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs