Ros-diffs

ros-diffs@reactos.org

81390 discussions

[ion] 24626: - Add NtAccessCheckAndAuditAlarm, NtAccessCheckByType, NtAccessCheckByTypeAndAuditAlarm, NtAccessCheckByTypeResultList, NtAccessCheckByTypeResultListAndAuditAlarm, NtAccessCheckByTypeResultListAndAuditAlarmByHandle, NtAccessCheckByTypeResultListAndAuditAlarmByHandleByGodHowMuchLongerCanTheseAPINamesGet. - Last one is a joke.
by ion＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: ion Date: Mon Oct 23 21:47:40 2006 New Revision: 24626 URL: http://svn.reactos.org/svn/reactos?rev=24626&view=rev Log: - Add NtAccessCheckAndAuditAlarm, NtAccessCheckByType, NtAccessCheckByTypeAndAuditAlarm, NtAccessCheckByTypeResultList, NtAccessCheckByTypeResultListAndAuditAlarm, NtAccessCheckByTypeResultListAndAuditAlarmByHandle, NtAccessCheckByTypeResultListAndAuditAlarmByHandleByGodHowMuchLongerCanTheseAPINamesGet. - Last one is a joke. Modified: trunk/reactos/include/ddk/ntifs.h trunk/reactos/ntoskrnl/se/semgr.c Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=24… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h (original) +++ trunk/reactos/include/ddk/ntifs.h Mon Oct 23 21:47:40 2006 @@ -399,6 +399,14 @@ #define SE_SACL_PROTECTED 0x2000 #define SE_RM_CONTROL_VALID 0x4000 #define SE_SELF_RELATIVE 0x8000 + +typedef enum _AUDIT_EVENT_TYPE +{ + AuditEventObjectAccess, + AuditEventDirectoryServiceAccess +} AUDIT_EVENT_TYPE, *PAUDIT_EVENT_TYPE; + +#define AUDIT_ALLOW_NO_PRIVILEGE 0x1 #define FSCTL_REQUEST_OPLOCK_LEVEL_1 CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 0, METHOD_BUFFERED, FILE_ANY_ACCESS) #define FSCTL_REQUEST_OPLOCK_LEVEL_2 CTL_CODE(FILE_DEVICE_FILE_SYSTEM, 1, METHOD_BUFFERED, FILE_ANY_ACCESS) Modified: trunk/reactos/ntoskrnl/se/semgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/se/semgr.c?rev=24… ============================================================================== --- trunk/reactos/ntoskrnl/se/semgr.c (original) +++ trunk/reactos/ntoskrnl/se/semgr.c Mon Oct 23 21:47:40 2006 @@ -1146,6 +1146,131 @@ return Status; } +NTSTATUS +NTAPI +NtAccessCheckAndAuditAlarm(IN PUNICODE_STRING SubsystemName, + IN HANDLE HandleId, + IN PUNICODE_STRING ObjectTypeName, + IN PUNICODE_STRING ObjectName, + IN PSECURITY_DESCRIPTOR SecurityDescriptor, + IN ACCESS_MASK DesiredAccess, + IN PGENERIC_MAPPING GenericMapping, + IN BOOLEAN ObjectCreation, + OUT PACCESS_MASK GrantedAccess, + OUT PNTSTATUS AccessStatus, + OUT PBOOLEAN GenerateOnClose) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +NTSTATUS +NTAPI +NtAccessCheckByType(IN PSECURITY_DESCRIPTOR SecurityDescriptor, + IN PSID PrincipalSelfSid, + IN PTOKEN ClientToken, + IN ACCESS_MASK DesiredAccess, + IN POBJECT_TYPE_LIST ObjectTypeList, + IN ULONG ObjectTypeLength, + IN PGENERIC_MAPPING GenericMapping, + IN PPRIVILEGE_SET PrivilegeSet, + IN ULONG PrivilegeSetLength, + OUT PACCESS_MASK GrantedAccess, + OUT PNTSTATUS AccessStatus) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + + +NTSTATUS +NTAPI +NtAccessCheckByTypeAndAuditAlarm(IN PUNICODE_STRING SubsystemName, + IN HANDLE HandleId, + IN PUNICODE_STRING ObjectTypeName, + IN PUNICODE_STRING ObjectName, + IN PSECURITY_DESCRIPTOR SecurityDescriptor, + IN PSID PrincipalSelfSid, + IN ACCESS_MASK DesiredAccess, + IN AUDIT_EVENT_TYPE AuditType, + IN ULONG Flags, + IN POBJECT_TYPE_LIST ObjectTypeList, + IN ULONG ObjectTypeLength, + IN PGENERIC_MAPPING GenericMapping, + IN BOOLEAN ObjectCreation, + OUT PACCESS_MASK GrantedAccess, + OUT PNTSTATUS AccessStatus, + OUT PBOOLEAN GenerateOnClose) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +NTSTATUS +NTAPI +NtAccessCheckByTypeResultList(IN PSECURITY_DESCRIPTOR SecurityDescriptor, + IN PSID PrincipalSelfSid, + IN PTOKEN ClientToken, + IN ACCESS_MASK DesiredAccess, + IN POBJECT_TYPE_LIST ObjectTypeList, + IN ULONG ObjectTypeLength, + IN PGENERIC_MAPPING GenericMapping, + IN PPRIVILEGE_SET PrivilegeSet, + IN ULONG PrivilegeSetLength, + OUT PACCESS_MASK GrantedAccess, + OUT PNTSTATUS AccessStatus) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +NTSTATUS +NTAPI +NtAccessCheckByTypeResultListAndAuditAlarm(IN PUNICODE_STRING SubsystemName, + IN HANDLE HandleId, + IN PUNICODE_STRING ObjectTypeName, + IN PUNICODE_STRING ObjectName, + IN PSECURITY_DESCRIPTOR SecurityDescriptor, + IN PSID PrincipalSelfSid, + IN ACCESS_MASK DesiredAccess, + IN AUDIT_EVENT_TYPE AuditType, + IN ULONG Flags, + IN POBJECT_TYPE_LIST ObjectTypeList, + IN ULONG ObjectTypeLength, + IN PGENERIC_MAPPING GenericMapping, + IN BOOLEAN ObjectCreation, + OUT PACCESS_MASK GrantedAccess, + OUT PNTSTATUS AccessStatus, + OUT PBOOLEAN GenerateOnClose) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + +NTSTATUS +NTAPI +NtAccessCheckByTypeResultListAndAuditAlarmByHandle(IN PUNICODE_STRING SubsystemName, + IN HANDLE HandleId, + IN PTOKEN ClientToken, + IN PUNICODE_STRING ObjectTypeName, + IN PUNICODE_STRING ObjectName, + IN PSECURITY_DESCRIPTOR SecurityDescriptor, + IN PSID PrincipalSelfSid, + IN ACCESS_MASK DesiredAccess, + IN AUDIT_EVENT_TYPE AuditType, + IN ULONG Flags, + IN POBJECT_TYPE_LIST ObjectTypeList, + IN ULONG ObjectTypeLength, + IN PGENERIC_MAPPING GenericMapping, + IN BOOLEAN ObjectCreation, + OUT PACCESS_MASK GrantedAccess, + OUT PNTSTATUS AccessStatus, + OUT PBOOLEAN GenerateOnClose) +{ + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +} + VOID STDCALL SeQuerySecurityAccessMask(IN SECURITY_INFORMATION SecurityInformation, OUT PACCESS_MASK DesiredAccess)

1 0

[greatlrd] 24625: rewrite D3DParseUnknownCommand to use switch case instead it looks better. Add a summer of msdn documentions how the first input parameter works. So u do not need read the whole doc for it. Add some more comment in the code
by greatlrd＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: greatlrd Date: Mon Oct 23 21:37:51 2006 New Revision: 24625 URL: http://svn.reactos.org/svn/reactos?rev=24625&view=rev Log: rewrite D3DParseUnknownCommand to use switch case instead it looks better. Add a summer of msdn documentions how the first input parameter works. So u do not need read the whole doc for it. Add some more comment in the code Modified: trunk/reactos/dll/directx/ddraw/main.c Modified: trunk/reactos/dll/directx/ddraw/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ddraw/main.c?r… ============================================================================== --- trunk/reactos/dll/directx/ddraw/main.c (original) +++ trunk/reactos/dll/directx/ddraw/main.c Mon Oct 23 21:37:51 2006 @@ -128,11 +128,26 @@ for more info about this command - */ - -/* - * UNIMPLEMENT - * Status FIXME need be implement and this code is realy need be tested + summuer the msdn + + The buffer start with D3DHAL_DP2COMMAND struct afer that it follow either one struct or no struct at at all + example for command D3DDP2OP_VIEWPORTINFO + + then lpCmd will look like this + ---------------------------------------- + | struct | Pos | + ---------------------------------------- + | D3DHAL_DP2COMMAND | 0x00 - 0x03 | + --------------------------------------- + | D3DHAL_DP2VIEWPORTINFO | 0x04 - xxxx | + --------------------------------------- + + to calc end of the lpCmd buffer in this exmaple + D3DHAL_DP2COMMAND->wStateCount * sizeof(D3DHAL_DP2VIEWPORTINFO); + now you got number of bytes but we need add the size of D3DHAL_DP2COMMAND + to get this right. the end should be + sizeof(D3DHAL_DP2COMMAND) + ( D3DHAL_DP2COMMAND->wStateCount * sizeof(D3DHAL_DP2VIEWPORTINFO)); + to get the xxxx end positions. */ HRESULT @@ -140,10 +155,9 @@ D3DParseUnknownCommand( LPVOID lpCmd, LPVOID *lpRetCmd) { + DWORD retCode = DD_OK; LPD3DHAL_DP2COMMAND dp2command = lpCmd; - - DWORD retCode = D3DERR_COMMAND_UNPARSED; - + /* prevent it crash if null pointer are being sent */ if ( (lpCmd == NULL) || (lpRetCmd == NULL) ) { @@ -151,35 +165,40 @@ } *lpRetCmd = lpCmd; - - /* check for vaild command, only 3 command is vaild */ - if (dp2command->bCommand == D3DDP2OP_VIEWPORTINFO) - { - /* dp2command->wStateCount * sizeof D3DHAL_DP2VIEWPORTINFO + 4 bytes */ - *(PBYTE)lpRetCmd += ((dp2command->wStateCount * sizeof(D3DHAL_DP2VIEWPORTINFO)) + sizeof(ULONG_PTR)); - retCode = 0; - } - else if (dp2command->bCommand == D3DDP2OP_WINFO) - { - /* dp2command->wStateCount * sizeof D3DHAL_DP2WINFO + 4 bytes */ - *(PBYTE)lpRetCmd += (dp2command->wStateCount * sizeof(D3DHAL_DP2WINFO)) + sizeof(ULONG_PTR); - retCode = 0; - } - else if (dp2command->bCommand == 0x0d) - { - /* dp2command->wStateCount * how many wStateCount ? + 4 bytes */ - *(PBYTE)lpRetCmd += ((dp2command->wStateCount * dp2command->bReserved) + sizeof(ULONG_PTR)); - retCode = 0; - } - - /* set error code for command 0 to 3, 8 and 15 to 255 */ - else if ( (dp2command->bCommand <= D3DDP2OP_INDEXEDTRIANGLELIST) || // dp2command->bCommand <= with 0 to 3 + + switch (dp2command->bCommand) + { + /* check for vaild command, only 3 command is vaild */ + case D3DDP2OP_VIEWPORTINFO: + *(PBYTE)lpRetCmd += ((dp2command->wStateCount * sizeof(D3DHAL_DP2VIEWPORTINFO)) + sizeof(D3DHAL_DP2COMMAND)); + break; + + case D3DDP2OP_WINFO: + *(PBYTE)lpRetCmd += (dp2command->wStateCount * sizeof(D3DHAL_DP2WINFO)) + sizeof(D3DHAL_DP2COMMAND); + break; + + case 0x0d: /* Undocumented in MSDN */ + *(PBYTE)lpRetCmd += ((dp2command->wStateCount * dp2command->bReserved) + sizeof(D3DHAL_DP2COMMAND)); + break; + + + /* set the error code */ + default: + + if ( (dp2command->bCommand <= D3DDP2OP_INDEXEDTRIANGLELIST) || // dp2command->bCommand <= with 0 to 3 (dp2command->bCommand == D3DDP2OP_RENDERSTATE) || // dp2command->bCommand == with 8 (dp2command->bCommand >= D3DDP2OP_LINELIST) ) // dp2command->bCommand >= with 15 to 255 - { - retCode = E_FAIL; + { + /* set error code for command 0 to 3, 8 and 15 to 255 */ + retCode = E_FAIL; + } + else + { /* set error code for 4 - 7, 9 - 12, 14 */ + retCode = D3DERR_COMMAND_UNPARSED; + } + } - + return retCode; }

1 0

[janderwald] 24624: - revert 24623
by janderwald＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: janderwald Date: Mon Oct 23 13:06:27 2006 New Revision: 24624 URL: http://svn.reactos.org/svn/reactos?rev=24624&view=rev Log: - revert 24623 Modified: trunk/reactos/ntoskrnl/ntoskrnl.def Modified: trunk/reactos/ntoskrnl/ntoskrnl.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.def?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.def (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.def Mon Oct 23 13:06:27 2006 @@ -777,7 +777,6 @@ NtCreateFile@44 NtCreateSection@28 NtDeleteAtom@4 -NtDeleteBootEntry@4 NtDeleteFile@4 NtDeviceIoControlFile@40 NtDuplicateObject@28 @@ -1328,6 +1327,7 @@ ZwCreateSection@28 ZwCreateSymbolicLinkObject@16 ZwCreateTimer@16 +ZwDeleteBootEntry@4 ZwDeleteFile@4 ZwDeleteKey@4 ZwDeleteValueKey@8

1 0

[janderwald] 24623: - really fix build
by janderwald＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: janderwald Date: Mon Oct 23 12:54:19 2006 New Revision: 24623 URL: http://svn.reactos.org/svn/reactos?rev=24623&view=rev Log: - really fix build Modified: trunk/reactos/ntoskrnl/ntoskrnl.def Modified: trunk/reactos/ntoskrnl/ntoskrnl.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.def?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.def (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.def Mon Oct 23 12:54:19 2006 @@ -777,6 +777,7 @@ NtCreateFile@44 NtCreateSection@28 NtDeleteAtom@4 +NtDeleteBootEntry@4 NtDeleteFile@4 NtDeviceIoControlFile@40 NtDuplicateObject@28 @@ -1327,7 +1328,6 @@ ZwCreateSection@28 ZwCreateSymbolicLinkObject@16 ZwCreateTimer@16 -ZwDeleteBootEntry@4 ZwDeleteFile@4 ZwDeleteKey@4 ZwDeleteValueKey@8

1 0

[janderwald] 24622: - fix build
by janderwald＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: janderwald Date: Mon Oct 23 12:42:27 2006 New Revision: 24622 URL: http://svn.reactos.org/svn/reactos?rev=24622&view=rev Log: - fix build Modified: trunk/reactos/ntoskrnl/dbgk/debug.c Modified: trunk/reactos/ntoskrnl/dbgk/debug.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/dbgk/debug.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/dbgk/debug.c (original) +++ trunk/reactos/ntoskrnl/dbgk/debug.c Mon Oct 23 12:42:27 2006 @@ -874,7 +874,7 @@ VOID NTAPI -DbgkpDeleteObject(IN PVOID Object) +DbgkpDeleteObject(IN PVOID DebugObject) { PAGED_CODE();

1 0

[ion] 24621: - Fix another build break... sorry for the SVN Server is fucked due to the CIA post-commit hook and is being unusable.
by ion＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: ion Date: Mon Oct 23 09:55:06 2006 New Revision: 24621 URL: http://svn.reactos.org/svn/reactos?rev=24621&view=rev Log: - Fix another build break... sorry for the SVN Server is fucked due to the CIA post-commit hook and is being unusable. Modified: trunk/reactos/dll/ntdll/dbg/dbgui.c trunk/reactos/dll/ntdll/def/ntdll.def Modified: trunk/reactos/dll/ntdll/dbg/dbgui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/dbg/dbgui.c?rev=… ============================================================================== --- trunk/reactos/dll/ntdll/dbg/dbgui.c (original) +++ trunk/reactos/dll/ntdll/dbg/dbgui.c Mon Oct 23 09:55:06 2006 @@ -78,11 +78,12 @@ NTSTATUS NTAPI DbgUiConvertStateChangeStructure(IN PDBGUI_WAIT_STATE_CHANGE WaitStateChange, - OUT LPDEBUG_EVENT DebugEvent) + OUT PVOID Win32DebugEvent) { NTSTATUS Status; OBJECT_ATTRIBUTES ObjectAttributes; THREAD_BASIC_INFORMATION ThreadBasicInfo; + LPDEBUG_EVENT DebugEvent = Win32DebugEvent; HANDLE ThreadHandle; /* Write common data */ Modified: trunk/reactos/dll/ntdll/def/ntdll.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.def?re… ============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.def (original) +++ trunk/reactos/dll/ntdll/def/ntdll.def Mon Oct 23 09:55:06 2006 @@ -132,7 +132,6 @@ NtFsControlFile@40 NtGetContextThread@8 NtGetPlugPlayEvent@16 -NtGetTickCount@0 NtImpersonateAnonymousToken@4 NtImpersonateClientOfPort@8 NtImpersonateThread@12 @@ -290,7 +289,6 @@ NtWriteFileGather@36 NtWriteRequestData@24 NtWriteVirtualMemory@20 -NtW32Call@20 NtYieldExecution@0 ;PfxFindPrefix ;PfxInitialize @@ -803,7 +801,6 @@ ZwFsControlFile@40 ZwGetContextThread@8 ZwGetPlugPlayEvent@16 -ZwGetTickCount@0 ZwImpersonateAnonymousToken@4 ZwImpersonateClientOfPort@8 ZwImpersonateThread@12 @@ -961,7 +958,6 @@ ZwWriteFileGather@36 ZwWriteRequestData@24 ZwWriteVirtualMemory@20 -ZwW32Call@20 ZwYieldExecution@0 __isascii __iscsym

1 0

[ion] 24620: - Fix some EFI prototypes and exports. - Add BOOT_ENTRY definition. - Fix build breakage from earlier commit.
by ion＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: ion Date: Mon Oct 23 09:49:07 2006 New Revision: 24620 URL: http://svn.reactos.org/svn/reactos?rev=24620&view=rev Log: - Fix some EFI prototypes and exports. - Add BOOT_ENTRY definition. - Fix build breakage from earlier commit. Modified: trunk/reactos/include/ndk/iofuncs.h trunk/reactos/include/ndk/iotypes.h trunk/reactos/include/ndk/umfuncs.h trunk/reactos/ntoskrnl/ex/efi.c trunk/reactos/ntoskrnl/ntoskrnl.def Modified: trunk/reactos/include/ndk/iofuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/iofuncs.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/iofuncs.h (original) +++ trunk/reactos/include/ndk/iofuncs.h Mon Oct 23 09:49:07 2006 @@ -32,8 +32,8 @@ NTSTATUS NTAPI NtAddBootEntry( - IN PUNICODE_STRING EntryName, - IN PUNICODE_STRING EntryValue + IN PBOOT_ENTRY BootEntry, + IN ULONG Id ); NTSYSCALLAPI @@ -109,8 +109,7 @@ NTSTATUS NTAPI NtDeleteBootEntry( - IN PUNICODE_STRING EntryName, - IN PUNICODE_STRING EntryValue + IN ULONG Id ); NTSYSCALLAPI Modified: trunk/reactos/include/ndk/iotypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/iotypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/iotypes.h (original) +++ trunk/reactos/include/ndk/iotypes.h Mon Oct 23 09:49:07 2006 @@ -1102,6 +1102,21 @@ } BOOT_OPTIONS, *PBOOT_OPTIONS; // +// Firmware Boot Entry +// +typedef struct _BOOT_ENTRY +{ + ULONG Version; + ULONG Length; + ULONG Id; + ULONG Attributes; + ULONG FriendlyNameOffset; + ULONG BootFilePathOffset; + ULONG OsOptionsLength; + CHAR OsOptions[1]; +} BOOT_ENTRY, *PBOOT_ENTRY; + +// // APC Callback for NtCreateFile // typedef VOID Modified: trunk/reactos/include/ndk/umfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/umfuncs.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/umfuncs.h (original) +++ trunk/reactos/include/ndk/umfuncs.h Mon Oct 23 09:49:07 2006 @@ -168,7 +168,7 @@ NTAPI DbgUiConvertStateChangeStructure( IN PDBGUI_WAIT_STATE_CHANGE WaitStateChange, - IN LPDEBUG_EVENT DebugEvent + IN PVOID DebugEvent ); VOID Modified: trunk/reactos/ntoskrnl/ex/efi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/efi.c?rev=2462… ============================================================================== --- trunk/reactos/ntoskrnl/ex/efi.c (original) +++ trunk/reactos/ntoskrnl/ex/efi.c Mon Oct 23 09:49:07 2006 @@ -16,8 +16,8 @@ NTSTATUS NTAPI -NtAddBootEntry(IN PUNICODE_STRING EntryName, - IN PUNICODE_STRING EntryValue) +NtAddBootEntry(IN PBOOT_ENTRY Entry, + IN ULONG Id) { UNIMPLEMENTED; return STATUS_NOT_IMPLEMENTED; @@ -25,8 +25,7 @@ NTSTATUS NTAPI -NtDeleteBootEntry(IN PUNICODE_STRING EntryName, - IN PUNICODE_STRING EntryValue) +NtDeleteBootEntry(IN ULONG Id) { UNIMPLEMENTED; return STATUS_NOT_IMPLEMENTED; Modified: trunk/reactos/ntoskrnl/ntoskrnl.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.def?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.def (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.def Mon Oct 23 09:49:07 2006 @@ -1327,7 +1327,7 @@ ZwCreateSection@28 ZwCreateSymbolicLinkObject@16 ZwCreateTimer@16 -ZwDeleteBootEntry@8 +ZwDeleteBootEntry@4 ZwDeleteFile@4 ZwDeleteKey@4 ZwDeleteValueKey@8

1 0

[ion] 24619: - Implement DbgUiConvertStateChangeStructure. Win32/Native Debugging should be fully implemented now (and waiting on the kernel to support it.)
by ion＠svn.reactos.org 23 Oct '06

23 Oct '06

Author: ion Date: Mon Oct 23 09:08:19 2006 New Revision: 24619 URL: http://svn.reactos.org/svn/reactos?rev=24619&view=rev Log: - Implement DbgUiConvertStateChangeStructure. Win32/Native Debugging should be fully implemented now (and waiting on the kernel to support it.) Modified: trunk/reactos/dll/ntdll/dbg/dbgui.c Modified: trunk/reactos/dll/ntdll/dbg/dbgui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/dbg/dbgui.c?rev=… ============================================================================== --- trunk/reactos/dll/ntdll/dbg/dbgui.c (original) +++ trunk/reactos/dll/ntdll/dbg/dbgui.c Mon Oct 23 09:08:19 2006 @@ -73,15 +73,240 @@ } /* - * @unimplemented + * @implemented */ NTSTATUS NTAPI DbgUiConvertStateChangeStructure(IN PDBGUI_WAIT_STATE_CHANGE WaitStateChange, OUT LPDEBUG_EVENT DebugEvent) { - /* FIXME: UNIMPLEMENTED */ - return STATUS_NOT_IMPLEMENTED; + NTSTATUS Status; + OBJECT_ATTRIBUTES ObjectAttributes; + THREAD_BASIC_INFORMATION ThreadBasicInfo; + HANDLE ThreadHandle; + + /* Write common data */ + DebugEvent->dwProcessId = (DWORD)WaitStateChange-> + AppClientId.UniqueProcess; + DebugEvent->dwThreadId = (DWORD)WaitStateChange->AppClientId.UniqueThread; + + /* Check what kind of even this is */ + switch (WaitStateChange->NewState) + { + /* New thread */ + case DbgCreateThreadStateChange: + + /* Setup Win32 code */ + DebugEvent->dwDebugEventCode = CREATE_THREAD_DEBUG_EVENT; + + /* Copy data over */ + DebugEvent->u.CreateThread.hThread = + WaitStateChange->StateInfo.CreateThread.HandleToThread; + DebugEvent->u.CreateThread.lpStartAddress = + WaitStateChange->StateInfo.CreateThread.NewThread.StartAddress; + + /* Query the TEB */ + Status = NtQueryInformationThread(WaitStateChange->StateInfo. + CreateThread.HandleToThread, + ThreadBasicInformation, + &ThreadBasicInfo, + sizeof(ThreadBasicInfo), + NULL); + if (!NT_SUCCESS(Status)) + { + /* Failed to get PEB address */ + DebugEvent->u.CreateThread.lpThreadLocalBase = NULL; + } + else + { + /* Write PEB Address */ + DebugEvent->u.CreateThread.lpThreadLocalBase = + ThreadBasicInfo.TebBaseAddress; + } + break; + + /* New process */ + case DbgCreateProcessStateChange: + + /* Write Win32 debug code */ + DebugEvent->dwDebugEventCode = CREATE_PROCESS_DEBUG_EVENT; + + /* Copy data over */ + DebugEvent->u.CreateProcessInfo.hProcess = + WaitStateChange->StateInfo.CreateProcessInfo.HandleToProcess; + DebugEvent->u.CreateProcessInfo.hThread = + WaitStateChange->StateInfo.CreateProcessInfo.HandleToThread; + DebugEvent->u.CreateProcessInfo.hFile = + WaitStateChange->StateInfo.CreateProcessInfo.NewProcess. + FileHandle; + DebugEvent->u.CreateProcessInfo.lpBaseOfImage = + WaitStateChange->StateInfo.CreateProcessInfo.NewProcess. + BaseOfImage; + DebugEvent->u.CreateProcessInfo.dwDebugInfoFileOffset = + WaitStateChange->StateInfo.CreateProcessInfo.NewProcess. + DebugInfoFileOffset; + DebugEvent->u.CreateProcessInfo.nDebugInfoSize = + WaitStateChange->StateInfo.CreateProcessInfo.NewProcess. + DebugInfoSize; + DebugEvent->u.CreateProcessInfo.lpStartAddress = + WaitStateChange->StateInfo.CreateProcessInfo.NewProcess. + InitialThread.StartAddress; + + /* Query TEB address */ + Status = NtQueryInformationThread(WaitStateChange->StateInfo. + CreateProcessInfo.HandleToThread, + ThreadBasicInformation, + &ThreadBasicInfo, + sizeof(ThreadBasicInfo), + NULL); + if (!NT_SUCCESS(Status)) + { + /* Failed to get PEB address */ + DebugEvent->u.CreateThread.lpThreadLocalBase = NULL; + } + else + { + /* Write PEB Address */ + DebugEvent->u.CreateThread.lpThreadLocalBase = + ThreadBasicInfo.TebBaseAddress; + } + + /* Clear image name */ + DebugEvent->u.CreateProcessInfo.lpImageName = NULL; + DebugEvent->u.CreateProcessInfo.fUnicode = TRUE; + break; + + /* Thread exited */ + case DbgExitThreadStateChange: + + /* Write the Win32 debug code and the exit status */ + DebugEvent->dwDebugEventCode = EXIT_THREAD_DEBUG_EVENT; + DebugEvent->u.ExitThread.dwExitCode = + WaitStateChange->StateInfo.ExitThread.ExitStatus; + break; + + /* Process exited */ + case DbgExitProcessStateChange: + + /* Write the Win32 debug code and the exit status */ + DebugEvent->dwDebugEventCode = EXIT_PROCESS_DEBUG_EVENT; + DebugEvent->u.ExitProcess.dwExitCode = + WaitStateChange->StateInfo.ExitProcess.ExitStatus; + break; + + /* Any sort of exception */ + case DbgExceptionStateChange: + case DbgBreakpointStateChange: + case DbgSingleStepStateChange: + + /* Check if this was a debug print */ + if (WaitStateChange->StateInfo.Exception.ExceptionRecord. + ExceptionCode == DBG_PRINTEXCEPTION_C) + { + /* Set the Win32 code */ + DebugEvent->dwDebugEventCode = OUTPUT_DEBUG_STRING_EVENT; + + /* Copy debug string information */ + DebugEvent->u.DebugString.lpDebugStringData = + (PVOID)WaitStateChange-> + StateInfo.Exception.ExceptionRecord. + ExceptionInformation[1]; + DebugEvent->u.DebugString.nDebugStringLength = + WaitStateChange->StateInfo.Exception.ExceptionRecord. + ExceptionInformation[0]; + DebugEvent->u.DebugString.fUnicode = FALSE; + } + else if (WaitStateChange->StateInfo.Exception.ExceptionRecord. + ExceptionCode == DBG_RIPEXCEPTION) + { + /* Set the Win32 code */ + DebugEvent->dwDebugEventCode = RIP_EVENT; + + /* Set exception information */ + DebugEvent->u.RipInfo.dwType = + WaitStateChange->StateInfo.Exception.ExceptionRecord. + ExceptionInformation[1]; + DebugEvent->u.RipInfo.dwError = + WaitStateChange->StateInfo.Exception.ExceptionRecord. + ExceptionInformation[0]; + } + else + { + /* Otherwise, this is a debug event, copy info over */ + DebugEvent->dwDebugEventCode = EXCEPTION_DEBUG_EVENT; + DebugEvent->u.Exception.ExceptionRecord = + WaitStateChange->StateInfo.Exception.ExceptionRecord; + DebugEvent->u.Exception.dwFirstChance = + WaitStateChange->StateInfo.Exception.FirstChance; + } + break; + + /* DLL Load */ + case DbgLoadDllStateChange : + + /* Set the Win32 debug code */ + DebugEvent->dwDebugEventCode = LOAD_DLL_DEBUG_EVENT; + + /* Copy the rest of the data */ + DebugEvent->u.LoadDll.lpBaseOfDll = + WaitStateChange->StateInfo.LoadDll.BaseOfDll; + DebugEvent->u.LoadDll.hFile = + WaitStateChange->StateInfo.LoadDll.FileHandle; + DebugEvent->u.LoadDll.dwDebugInfoFileOffset = + WaitStateChange->StateInfo.LoadDll.DebugInfoFileOffset; + DebugEvent->u.LoadDll.nDebugInfoSize = + WaitStateChange->StateInfo.LoadDll.DebugInfoSize; + + /* Open the thread */ + InitializeObjectAttributes(&ObjectAttributes, NULL, 0, NULL, NULL); + Status = NtOpenThread(&ThreadHandle, + THREAD_QUERY_INFORMATION, + &ObjectAttributes, + &WaitStateChange->AppClientId); + if (NT_SUCCESS(Status)) + { + /* Query thread information */ + Status = NtQueryInformationThread(ThreadHandle, + ThreadBasicInformation, + &ThreadBasicInfo, + sizeof(ThreadBasicInfo), + NULL); + NtClose(ThreadHandle); + } + + /* Check if we got thread information */ + if (NT_SUCCESS(Status)) + { + /* Save the image name from the TIB */ + DebugEvent->u.LoadDll.lpImageName = + &((PTEB)ThreadBasicInfo.TebBaseAddress)-> + Tib.ArbitraryUserPointer; + } + else + { + /* Otherwise, no name */ + DebugEvent->u.LoadDll.lpImageName = NULL; + } + + /* It's Unicode */ + DebugEvent->u.LoadDll.fUnicode = TRUE; + break; + + /* DLL Unload */ + case DbgUnloadDllStateChange: + + /* Set Win32 code and DLL Base */ + DebugEvent->dwDebugEventCode = UNLOAD_DLL_DEBUG_EVENT; + DebugEvent->u.UnloadDll.lpBaseOfDll = + WaitStateChange->StateInfo.UnloadDll.BaseAddress; + break; + + /* Anything else, fail */ + default: return STATUS_UNSUCCESSFUL; + } + + /* Return success */ + return STATUS_SUCCESS; } /*

1 0

[ion] 24618: - Implement WaitForDebugEvent. Calls out to DbgUiConvertWaitStateStructure which is still unimplemented.
by ion＠svn.reactos.org 22 Oct '06

22 Oct '06

Author: ion Date: Mon Oct 23 03:47:12 2006 New Revision: 24618 URL: http://svn.reactos.org/svn/reactos?rev=24618&view=rev Log: - Implement WaitForDebugEvent. Calls out to DbgUiConvertWaitStateStructure which is still unimplemented. Modified: trunk/reactos/dll/win32/kernel32/debug/debugger.c trunk/reactos/include/psdk/ntstatus.h Modified: trunk/reactos/dll/win32/kernel32/debug/debugger.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/debug/d… ============================================================================== --- trunk/reactos/dll/win32/kernel32/debug/debugger.c (original) +++ trunk/reactos/dll/win32/kernel32/debug/debugger.c Mon Oct 23 03:47:12 2006 @@ -465,16 +465,109 @@ } /* - * @unimplemented + * @implemented */ BOOL WINAPI WaitForDebugEvent(IN LPDEBUG_EVENT lpDebugEvent, IN DWORD dwMilliseconds) { - /* FIXME: TODO */ - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return FALSE; + LARGE_INTEGER WaitTime; + PLARGE_INTEGER Timeout; + DBGUI_WAIT_STATE_CHANGE WaitStateChange; + NTSTATUS Status; + + /* Check if this is an infinite wait */ + if (dwMilliseconds == INFINITE) + { + /* Under NT, this means no timer argument */ + Timeout = NULL; + } + else + { + /* Otherwise, convert the time to NT Format */ + WaitTime.QuadPart = UInt32x32To64(-10000, dwMilliseconds); + Timeout = &WaitTime; + } + + /* Loop while we keep getting interrupted */ + do + { + /* Call the native API */ + Status = DbgUiWaitStateChange(&WaitStateChange, Timeout); + } while ((Status == STATUS_ALERTED) || (Status == STATUS_USER_APC)); + + /* Check if the wait failed */ + if (!(NT_SUCCESS(Status)) || (Status != DBG_UNABLE_TO_PROVIDE_HANDLE)) + { + /* Set the error code and quit */ + SetLastErrorByStatus(Status); + return FALSE; + } + + /* Check if we timed out */ + if (Status == STATUS_TIMEOUT) + { + /* Fail with a timeout error */ + SetLastError(ERROR_SEM_TIMEOUT); + return FALSE; + } + + /* Convert the structure */ + Status = DbgUiConvertStateChangeStructure(&WaitStateChange, lpDebugEvent); + if (!NT_SUCCESS(Status)) + { + /* Set the error code and quit */ + SetLastErrorByStatus(Status); + return FALSE; + } + + /* Check what kind of event this was */ + switch (lpDebugEvent->dwDebugEventCode) + { + /* New thread was created */ + case CREATE_THREAD_DEBUG_EVENT: + + /* Setup the thread data */ + SaveThreadHandle(lpDebugEvent->dwProcessId, + lpDebugEvent->dwThreadId, + lpDebugEvent->u.CreateThread.hThread); + break; + + /* New process was created */ + case CREATE_PROCESS_DEBUG_EVENT: + + /* Setup the process data */ + SaveProcessHandle(lpDebugEvent->dwProcessId, + lpDebugEvent->u.CreateProcessInfo.hProcess); + + /* Setup the thread data */ + SaveThreadHandle(lpDebugEvent->dwProcessId, + lpDebugEvent->dwThreadId, + lpDebugEvent->u.CreateThread.hThread); + break; + + /* Process was exited */ + case EXIT_PROCESS_DEBUG_EVENT: + + /* Mark the thread data as such */ + MarkProcessHandle(lpDebugEvent->dwProcessId); + break; + + /* Thread was exited */ + case EXIT_THREAD_DEBUG_EVENT: + + /* Mark the thread data */ + MarkThreadHandle(lpDebugEvent->dwThreadId); + break; + + /* Nothing to do for anything else */ + default: + break; + } + + /* Return success */ + return TRUE; } /* EOF */ Modified: trunk/reactos/include/psdk/ntstatus.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntstatus.h?re… ============================================================================== --- trunk/reactos/include/psdk/ntstatus.h (original) +++ trunk/reactos/include/psdk/ntstatus.h Mon Oct 23 03:47:12 2006 @@ -58,6 +58,7 @@ #define STATUS_WAIT_63 ((NTSTATUS)0x0000003f) #define STATUS_ABANDONED ((NTSTATUS)0x00000080) #define STATUS_ABANDONED_WAIT_63 ((NTSTATUS)0x000000BF) +#define STATUS_USER_APC ((NTSTATUS)0x000000C0) #define STATUS_KERNEL_APC ((NTSTATUS)0x00000100) #define STATUS_ALERTED ((NTSTATUS)0x00000101) #define STATUS_TIMEOUT ((NTSTATUS)0x00000102)

1 0

[ion] 24617: - Define DBGSS_THREAD_DATA and DbgSsGet/SetThreadData. This is what is located in DbgSsReserved[0] (an internal high-level structure that subsystem debuggers can use for whatever purposes they need). DbgSsReserved[1] is the actual native debug object used only by DbgUi in ntdll. - Implement SaveThreadHandle, SaveProcesHandle, MarkThreadHandle, MarkProcessHandle, RemoveHandles and CloseAllProcessHandles to deal with this structure. - Call these functions when required, except for Wai
by ion＠svn.reactos.org 22 Oct '06

22 Oct '06

Author: ion Date: Mon Oct 23 03:28:33 2006 New Revision: 24617 URL: http://svn.reactos.org/svn/reactos?rev=24617&view=rev Log: - Define DBGSS_THREAD_DATA and DbgSsGet/SetThreadData. This is what is located in DbgSsReserved[0] (an internal high-level structure that subsystem debuggers can use for whatever purposes they need). DbgSsReserved[1] is the actual native debug object used only by DbgUi in ntdll. - Implement SaveThreadHandle, SaveProcesHandle, MarkThreadHandle, MarkProcessHandle, RemoveHandles and CloseAllProcessHandles to deal with this structure. - Call these functions when required, except for WaitForDebugEvent which will set them up once implemented. Modified: trunk/reactos/dll/ntdll/dbg/dbgui.c trunk/reactos/dll/win32/kernel32/debug/debugger.c Modified: trunk/reactos/dll/ntdll/dbg/dbgui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/dbg/dbgui.c?rev=… ============================================================================== --- trunk/reactos/dll/ntdll/dbg/dbgui.c (original) +++ trunk/reactos/dll/ntdll/dbg/dbgui.c Mon Oct 23 03:28:33 2006 @@ -78,7 +78,7 @@ NTSTATUS NTAPI DbgUiConvertStateChangeStructure(IN PDBGUI_WAIT_STATE_CHANGE WaitStateChange, - IN LPDEBUG_EVENT DebugEvent) + OUT LPDEBUG_EVENT DebugEvent) { /* FIXME: UNIMPLEMENTED */ return STATUS_NOT_IMPLEMENTED; Modified: trunk/reactos/dll/win32/kernel32/debug/debugger.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/debug/d… ============================================================================== --- trunk/reactos/dll/win32/kernel32/debug/debugger.c (original) +++ trunk/reactos/dll/win32/kernel32/debug/debugger.c Mon Oct 23 03:28:33 2006 @@ -9,11 +9,250 @@ /* INCLUDES *****************************************************************/ #include <k32.h> - #define NDEBUG #include "debug.h" -/* FUNCTIONS *****************************************************************/ +typedef struct _DBGSS_THREAD_DATA +{ + struct _DBGSS_THREAD_DATA *Next; + HANDLE ThreadHandle; + HANDLE ProcessHandle; + DWORD ProcessId; + DWORD ThreadId; + BOOLEAN HandleMarked; +} DBGSS_THREAD_DATA, *PDBGSS_THREAD_DATA; + +#define DbgSsSetThreadData(d) \ + NtCurrentTeb()->DbgSsReserved[0] = d + +#define DbgSsGetThreadData() \ + ((PDBGSS_THREAD_DATA)NtCurrentTeb()->DbgSsReserved[0]) + +/* PRIVATE FUNCTIONS *********************************************************/ + +VOID +WINAPI +SaveThreadHandle(IN DWORD dwProcessId, + IN DWORD dwThreadId, + IN HANDLE hThread) +{ + PDBGSS_THREAD_DATA ThreadData; + + /* Allocate a thread structure */ + ThreadData = RtlAllocateHeap(RtlGetProcessHeap(), + 0, + sizeof(DBGSS_THREAD_DATA)); + if (!ThreadData) return; + + /* Fill it out */ + ThreadData->ThreadHandle = hThread; + ThreadData->ProcessId = dwProcessId; + ThreadData->ThreadId = dwThreadId; + ThreadData->ProcessHandle = NULL; + ThreadData->HandleMarked = FALSE; + + /* Link it */ + ThreadData->Next = DbgSsGetThreadData(); + DbgSsSetThreadData(ThreadData); +} + +VOID +WINAPI +SaveProcessHandle(IN DWORD dwProcessId, + IN HANDLE hProcess) +{ + PDBGSS_THREAD_DATA ThreadData; + + /* Allocate a thread structure */ + ThreadData = RtlAllocateHeap(RtlGetProcessHeap(), + 0, + sizeof(DBGSS_THREAD_DATA)); + if (!ThreadData) return; + + /* Fill it out */ + ThreadData->ProcessHandle = hProcess; + ThreadData->ProcessId = dwProcessId; + ThreadData->ThreadId = 0; + ThreadData->ThreadHandle = NULL; + ThreadData->HandleMarked = FALSE; + + /* Link it */ + ThreadData->Next = DbgSsGetThreadData(); + DbgSsSetThreadData(ThreadData); +} + +VOID +WINAPI +MarkThreadHandle(IN DWORD dwThreadId) +{ + PDBGSS_THREAD_DATA ThreadData; + + /* Loop all thread data events */ + ThreadData = DbgSsGetThreadData(); + while (ThreadData) + { + /* Check if this one matches */ + if (ThreadData->ThreadId == dwThreadId) + { + /* Mark the structure and break out */ + ThreadData->HandleMarked = TRUE; + break; + } + + /* Move to the next one */ + ThreadData = ThreadData->Next; + } +} + +VOID +WINAPI +MarkProcessHandle(IN DWORD dwProcessId) +{ + PDBGSS_THREAD_DATA ThreadData; + + /* Loop all thread data events */ + ThreadData = DbgSsGetThreadData(); + while (ThreadData) + { + /* Check if this one matches */ + if (ThreadData->ProcessId == dwProcessId) + { + /* Make sure the thread ID is empty */ + if (!ThreadData->ThreadId) + { + /* Mark the structure and break out */ + ThreadData->HandleMarked = TRUE; + break; + } + } + + /* Move to the next one */ + ThreadData = ThreadData->Next; + } +} + +VOID +WINAPI +RemoveHandles(IN DWORD dwProcessId, + IN DWORD dwThreadId) +{ + PDBGSS_THREAD_DATA ThreadData; + + /* Loop all thread data events */ + ThreadData = DbgSsGetThreadData(); + while (ThreadData) + { + /* Check if this one matches */ + if (ThreadData->ProcessId == dwProcessId) + { + /* Make sure the thread ID matches too */ + if (ThreadData->ThreadId == dwThreadId) + { + /* Check if we have a thread handle */ + if (ThreadData->ThreadHandle) + { + /* Close it */ + CloseHandle(ThreadData->ThreadHandle); + } + + /* Check if we have a process handle */ + if (ThreadData->ProcessHandle) + { + /* Close it */ + CloseHandle(ThreadData->ProcessHandle); + } + + /* Unlink the thread data */ + DbgSsSetThreadData(ThreadData->Next); + + /* Free it*/ + RtlFreeHeap(RtlGetProcessHeap(), 0, ThreadData); + + /* Move to the next structure */ + ThreadData = DbgSsGetThreadData(); + continue; + } + } + + /* Move to the next one */ + ThreadData = ThreadData->Next; + } +} + +VOID +WINAPI +CloseAllProcessHandles(IN DWORD dwProcessId) +{ + PDBGSS_THREAD_DATA ThreadData; + + /* Loop all thread data events */ + ThreadData = DbgSsGetThreadData(); + while (ThreadData) + { + /* Check if this one matches */ + if (ThreadData->ProcessId == dwProcessId) + { + /* Check if we have a thread handle */ + if (ThreadData->ThreadHandle) + { + /* Close it */ + CloseHandle(ThreadData->ThreadHandle); + } + + /* Check if we have a process handle */ + if (ThreadData->ProcessHandle) + { + /* Close it */ + CloseHandle(ThreadData->ProcessHandle); + } + + /* Unlink the thread data */ + DbgSsSetThreadData(ThreadData->Next); + + /* Free it*/ + RtlFreeHeap(RtlGetProcessHeap(), 0, ThreadData); + + /* Move to the next structure */ + ThreadData = DbgSsGetThreadData(); + continue; + } + + /* Move to the next one */ + ThreadData = ThreadData->Next; + } +} + +HANDLE +WINAPI +ProcessIdToHandle(IN DWORD dwProcessId) +{ + NTSTATUS Status; + OBJECT_ATTRIBUTES ObjectAttributes; + HANDLE Handle; + CLIENT_ID ClientId; + + /* If we don't have a PID, look it up */ + if (dwProcessId == -1) dwProcessId = (DWORD)CsrGetProcessId(); + + /* Open a handle to the process */ + ClientId.UniqueProcess = (HANDLE)dwProcessId; + InitializeObjectAttributes(&ObjectAttributes, NULL, 0, NULL, NULL); + Status = NtOpenProcess(&Handle, + PROCESS_ALL_ACCESS, + &ObjectAttributes, + &ClientId); + if (!NT_SUCCESS(Status)) + { + /* Fail */ + SetLastErrorByStatus(Status); + return 0; + } + + /* Return the handle */ + return Handle; +} + +/* PUBLIC FUNCTIONS **********************************************************/ /* * @implemented @@ -77,37 +316,11 @@ return FALSE; } - /* Succes */ + /* Remove the process/thread handles */ + RemoveHandles(dwProcessId, dwThreadId); + + /* Success */ return TRUE; -} - -HANDLE -ProcessIdToHandle(IN DWORD dwProcessId) -{ - NTSTATUS Status; - OBJECT_ATTRIBUTES ObjectAttributes; - HANDLE Handle; - CLIENT_ID ClientId; - - /* If we don't have a PID, look it up */ - if (dwProcessId == 0xFFFFFFFF) dwProcessId = (DWORD)CsrGetProcessId(); - - /* Open a handle to the process */ - ClientId.UniqueProcess = (HANDLE)dwProcessId; - InitializeObjectAttributes(&ObjectAttributes, NULL, 0, NULL, NULL); - Status = NtOpenProcess(&Handle, - PROCESS_ALL_ACCESS, - &ObjectAttributes, - &ClientId); - if (!NT_SUCCESS(Status)) - { - /* Fail */ - SetLastErrorByStatus(Status); - return 0; - } - - /* Return the handle */ - return Handle; } /* @@ -134,6 +347,9 @@ /* Now debug the process */ Status = DbgUiDebugActiveProcess(Handle); + NtClose(Handle); + + /* Check if debugging worked */ if (!NT_SUCCESS(Status)) { /* Fail */ @@ -158,6 +374,9 @@ /* Get the process handle */ Handle = ProcessIdToHandle(dwProcessId); if (!Handle) return FALSE; + + /* Close all the process handles */ + CloseAllProcessHandles(dwProcessId); /* Now stop debgging the process */ Status = DbgUiStopDebugging(Handle); @@ -240,7 +459,7 @@ */ BOOL WINAPI -IsDebuggerPresent (VOID) +IsDebuggerPresent(VOID) { return (BOOL)NtCurrentPeb()->BeingDebugged; } @@ -251,7 +470,7 @@ BOOL WINAPI WaitForDebugEvent(IN LPDEBUG_EVENT lpDebugEvent, - DWORD dwMilliseconds) + IN DWORD dwMilliseconds) { /* FIXME: TODO */ SetLastError(ERROR_CALL_NOT_IMPLEMENTED);

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs