Author: hpoussin
Date: Wed Aug 9 16:15:18 2006
New Revision: 23532
URL: http://svn.reactos.org/svn/reactos?rev=23532&view=rev
Log:
Fix a bug in NtQueryInformationThread, which was leading to its unusability in user mode
Modified:
trunk/reactos/ntoskrnl/ps/query.c
Modified: trunk/reactos/ntoskrnl/ps/query.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=23…
==============================================================================
--- trunk/reactos/ntoskrnl/ps/query.c (original)
+++ trunk/reactos/ntoskrnl/ps/query.c Wed Aug 9 16:15:18 2006
@@ -890,12 +890,13 @@
PAGED_CODE();
/* Verify Information Class validity */
- Status = DefaultSetInfoBufferCheck(ThreadInformationClass,
- PsThreadInfoClass,
- RTL_NUMBER_OF(PsThreadInfoClass),
- ThreadInformation,
- ThreadInformationLength,
- PreviousMode);
+ Status = DefaultQueryInfoBufferCheck(ThreadInformationClass,
+ PsThreadInfoClass,
+ RTL_NUMBER_OF(PsThreadInfoClass),
+ ThreadInformation,
+ ThreadInformationLength,
+ ReturnLength,
+ PreviousMode);
if (!NT_SUCCESS(Status)) return Status;
/* Check what class this is */
Author: fireball
Date: Tue Aug 8 16:41:56 2006
New Revision: 23524
URL: http://svn.reactos.org/svn/reactos?rev=23524&view=rev
Log:
Force -fno-sibling-call-optimisation to every module's CFLAGs. This fixes *numerous* bugs (thanks to a bug in GCC itself), even in DBG=1 builds!
Just an example, comctl32.dll doesn't crash anymore in LISTVIEW_Callback().
Thanks to Dmitriy Philippov (aka Shedon) for encountering the comctl32 bug and investigating it!
Modified:
trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp
Modified: trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/mingw…
==============================================================================
--- trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp (original)
+++ trunk/reactos/tools/rbuild/backend/mingw/modulehandler.cpp Tue Aug 8 16:41:56 2006
@@ -1885,6 +1885,10 @@
globalCflags += " -pipe";
if ( !module.allowWarnings )
globalCflags += " -Werror";
+
+ // Always force disabling of sibling calls optimisation for GCC
+ // (TODO: Move to version-specific once this bug is fixed in GCC)
+ globalCflags += " -fno-optimize-sibling-calls";
fprintf (
fMakefile,