Ros-diffs

ros-diffs@reactos.org

81390 discussions

[ion] 22267: - Final fixes to ObpCreateHandle that I can think of before splitting Create/Increment (might be lacking some security checks or trace/database functionality, but I haven't found any info on the latter, while the former I will stub, but I don't have the skills to imlement (ObAssignObjectSecurity)): * Honour ObjectType passed to the function and fail if it doesn't match. * Use table-based logic instead of process-based logic for Kernel vs User-mode handles (same change that's been do
by ion＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: ion Date: Wed Jun 7 10:15:59 2006 New Revision: 22267 URL: http://svn.reactos.ru/svn/reactos?rev=22267&view=rev Log: - Final fixes to ObpCreateHandle that I can think of before splitting Create/Increment (might be lacking some security checks or trace/database functionality, but I haven't found any info on the latter, while the former I will stub, but I don't have the skills to imlement (ObAssignObjectSecurity)): * Honour ObjectType passed to the function and fail if it doesn't match. * Use table-based logic instead of process-based logic for Kernel vs User-mode handles (same change that's been done all over the place, since it requires only one dereference of the process object). * Do the GENERIC/MAXIMUM_ALLOWED logic directly inside the ACCESS_STATE structure. * This is where we should call the OpenProcedure (acc. to Gl00my), but this kills win32k -- investigate, #ifed out for now. * Increase the object type's number of handles as well. * Set the handle table entry's ObAttributes correctly; the old code seems to have been messing that up. * Honour the AdditionalReferences parameter and do referencing bias if requested. * Honour the ReturnedObject parameter to return the object pointer back to the caller. * Add OBTRACEing to the function. * If we failed because a handle couldn't be allocated, use the distinguied STATUS_INSUFFICIENT_RESOURCES error code instead of the generic STATUS_UNSCUCESFFUL, and backout all the changes we made by calling ObpDecrementHandleCount. Modified: trunk/reactos/ntoskrnl/ob/obhandle.c Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obhandle.c (original) +++ trunk/reactos/ntoskrnl/ob/obhandle.c Wed Jun 7 10:15:59 2006 @@ -359,7 +359,7 @@ // ObOpenHandle == 1, I'm guessing this is actually the // OpenReason. Also makes sense since this function is shared // by Duplication, Creation and Opening. - IN PVOID ObjectBody, + IN PVOID Object, IN POBJECT_TYPE Type OPTIONAL, IN PACCESS_STATE AccessState, IN ULONG AdditionalReferences, @@ -369,92 +369,162 @@ OUT PHANDLE ReturnedHandle) { HANDLE_TABLE_ENTRY NewEntry; - PEPROCESS Process, CurrentProcess; + PVOID HandleTable; POBJECT_HEADER ObjectHeader; + POBJECT_TYPE ObjectType; HANDLE Handle; KAPC_STATE ApcState; BOOLEAN AttachedToProcess = FALSE; - ACCESS_MASK GrantedAccess; - - PAGED_CODE(); - - DPRINT("ObpCreateHandle(obj %p)\n",ObjectBody); - - ASSERT(ObjectBody); - - CurrentProcess = PsGetCurrentProcess(); - - ObjectHeader = OBJECT_TO_OBJECT_HEADER(ObjectBody); - - /* check that this is a valid kernel pointer */ + + /* Get the object header and type */ + ObjectHeader = OBJECT_TO_OBJECT_HEADER(Object); + ObjectType = ObjectHeader->Type; + OBTRACE("OBTRACE - %s - Creating handle for: %p. Reason: %lx. HC LC %lx %lx\n", + __FUNCTION__, + Object, + OpenReason, + ObjectHeader->HandleCount, + ObjectHeader->PointerCount); + + /* Check if the types match */ + if ((Type) && (ObjectType != Type)) + { + /* They don't; fail */ + DPRINT1("Type mismatch: %wZ, %wZ\n", &ObjectType->Name, &Type->Name); + return STATUS_OBJECT_TYPE_MISMATCH; + } + + /* Check if this is a kernel handle */ + if ((HandleAttributes & OBJ_KERNEL_HANDLE) && (AccessMode == KernelMode)) + { + /* Set the handle table */ + HandleTable = ObpKernelHandleTable; + + /* Check if we're not in the system process */ + if (PsGetCurrentProcess() != PsInitialSystemProcess) + { + /* Attach to the system process */ + KeStackAttachProcess(&PsInitialSystemProcess->Pcb, &ApcState); + AttachedToProcess = TRUE; + } + } + else + { + /* Get the current handle table */ + HandleTable = PsGetCurrentProcess()->ObjectTable; + } + + /* Convert MAXIMUM_ALLOWED to GENERIC_ALL */ + if (AccessState->RemainingDesiredAccess & MAXIMUM_ALLOWED) + { + /* Mask out MAXIMUM_ALLOWED and stick GENERIC_ALL instead */ + AccessState->RemainingDesiredAccess &= ~MAXIMUM_ALLOWED; + AccessState->RemainingDesiredAccess |= GENERIC_ALL; + } + + /* Check if we have to map the GENERIC mask */ + if (AccessState->RemainingDesiredAccess & GENERIC_ACCESS) + { + /* Map it to the correct access masks */ + RtlMapGenericMask(&AccessState->RemainingDesiredAccess, + &ObjectType->TypeInfo.GenericMapping); + } + + /* Increase the handle count */ + if(InterlockedIncrement(&ObjectHeader->HandleCount) == 1) + { + /* + * FIXME: Is really needed? Perhaps we should instead take + * advantage of the AddtionalReferences parameter to add the + * bias when required. This might be the source of the mysterious + * ReactOS bug where ObInsertObject *requires* an immediate dereference + * even in a success case. + * Whill have to think more about this when doing the Increment/Create + * split later. + */ + ObReferenceObject(Object); + } + + /* Check if we have an open procedure */ +#if 0 + if (ObjectType->TypeInfo.OpenProcedure) + { + /* Call it */ + ObjectType->TypeInfo.OpenProcedure(OpenReason, + PsGetCurrentProcess(), + Object, + AccessState-> + PreviouslyGrantedAccess, + 0); + } +#endif + + /* Increase total number of handles */ + ObjectType->TotalNumberOfHandles++; + + /* Save the object header (assert its validity too) */ ASSERT((ULONG_PTR)ObjectHeader & EX_HANDLE_ENTRY_LOCKED); - - GrantedAccess = AccessState->RemainingDesiredAccess | - AccessState->PreviouslyGrantedAccess; - if (GrantedAccess & MAXIMUM_ALLOWED) - { - GrantedAccess &= ~MAXIMUM_ALLOWED; - GrantedAccess |= GENERIC_ALL; - } - - if (GrantedAccess & GENERIC_ACCESS) - { - RtlMapGenericMask(&GrantedAccess, - &ObjectHeader->Type->TypeInfo.GenericMapping); - } - NewEntry.Object = ObjectHeader; - if(HandleAttributes & OBJ_INHERIT) - NewEntry.ObAttributes |= EX_HANDLE_ENTRY_INHERITABLE; - else - NewEntry.ObAttributes &= ~EX_HANDLE_ENTRY_INHERITABLE; - NewEntry.GrantedAccess = GrantedAccess; - - if ((HandleAttributes & OBJ_KERNEL_HANDLE) && - ExGetPreviousMode == KernelMode) - { - Process = PsInitialSystemProcess; - if (Process != CurrentProcess) - { - KeStackAttachProcess(&Process->Pcb, - &ApcState); - AttachedToProcess = TRUE; - } - } - else - { - Process = CurrentProcess; - /* mask out the OBJ_KERNEL_HANDLE attribute */ - HandleAttributes &= ~OBJ_KERNEL_HANDLE; - } - - Handle = ExCreateHandle(Process->ObjectTable, - &NewEntry); - - if (AttachedToProcess) - { - KeUnstackDetachProcess(&ApcState); - } - - if(Handle != NULL) - { + + /* Mask out the internal attributes */ + NewEntry.ObAttributes |= HandleAttributes & + (EX_HANDLE_ENTRY_PROTECTFROMCLOSE | + EX_HANDLE_ENTRY_INHERITABLE | + EX_HANDLE_ENTRY_AUDITONCLOSE); + + /* Save the access mask */ + NewEntry.GrantedAccess = AccessState->RemainingDesiredAccess | + AccessState->PreviouslyGrantedAccess; + + /* + * Create the actual handle. We'll need to do this *after* calling + * ObpIncrementHandleCount to make sure that Object Security is valid + * (specified in Gl00my documentation on Ob) + */ + OBTRACE("OBTRACE - %s - Handle Properties: [%p-%lx-%lx]\n", + __FUNCTION__, + NewEntry.Object, NewEntry.ObAttributes & 3, NewEntry.GrantedAccess); + Handle = ExCreateHandle(HandleTable, &NewEntry); + + /* Detach it needed */ + if (AttachedToProcess) KeUnstackDetachProcess(&ApcState); + + /* Check if we got a handle */ + if(Handle) + { + /* Handle extra references */ + while (AdditionalReferences--) + { + /* Increment the count */ + InterlockedIncrement(&ObjectHeader->PointerCount); + } + + /* Check if this was a kernel handle */ if (HandleAttributes & OBJ_KERNEL_HANDLE) { - /* mark the handle value */ + /* Set the kernel handle bit */ Handle = ObMarkHandleAsKernelHandle(Handle); } - if(InterlockedIncrement(&ObjectHeader->HandleCount) == 1) - { - ObReferenceObject(ObjectBody); - } - + /* Return handle and object */ *ReturnedHandle = Handle; - + if (ReturnedObject) *ReturnedObject = Object; + + /* Return success */ + OBTRACE("OBTRACE - %s - Incremented count for: %p. Reason: %lx HC LC %lx %lx\n", + __FUNCTION__, + Object, + OpenReason, + ObjectHeader->HandleCount, + ObjectHeader->PointerCount); return STATUS_SUCCESS; } - return STATUS_UNSUCCESSFUL; + /* Decrement the handle count and fail */ + ObpDecrementHandleCount(&ObjectHeader->Body, + PsGetCurrentProcess(), + NewEntry.GrantedAccess); + return STATUS_INSUFFICIENT_RESOURCES; } /*++

1 0

[ion] 22266: - Change ObpCreateHandle to the one documented and explained in the Gl00my documentation. It also fits the re-factored split create/increment model better, supports open reasons, and allows to do type-checking and extra object referencing from within one routine. - Add code to ObOpenObjectByName to detect the OpenReason. Experimental, since I'm not sure when to clear the flag.
by ion＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: ion Date: Wed Jun 7 09:37:04 2006 New Revision: 22266 URL: http://svn.reactos.ru/svn/reactos?rev=22266&view=rev Log: - Change ObpCreateHandle to the one documented and explained in the Gl00my documentation. It also fits the re-factored split create/increment model better, supports open reasons, and allows to do type-checking and extra object referencing from within one routine. - Add code to ObOpenObjectByName to detect the OpenReason. Experimental, since I'm not sure when to clear the flag. Modified: trunk/reactos/ntoskrnl/ob/obhandle.c Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obhandle.c (original) +++ trunk/reactos/ntoskrnl/ob/obhandle.c Wed Jun 7 09:37:04 2006 @@ -353,17 +353,20 @@ NTSTATUS NTAPI -ObpCreateHandle(PVOID ObjectBody, - PACCESS_STATE AccessState, - ULONG HandleAttributes, - PHANDLE HandleReturn) - /* - * FUNCTION: Add a handle referencing an object - * ARGUMENTS: - * obj = Object body that the handle should refer to - * RETURNS: The created handle - * NOTE: The handle is valid only in the context of the current process - */ +ObpCreateHandle(IN OB_OPEN_REASON OpenReason, // Gloomy says this is "enables Security" if == 1. + // since this function *has* to call ObpIncrementHandleCount, + // which needs to somehow know the OpenReason, and since + // ObOpenHandle == 1, I'm guessing this is actually the + // OpenReason. Also makes sense since this function is shared + // by Duplication, Creation and Opening. + IN PVOID ObjectBody, + IN POBJECT_TYPE Type OPTIONAL, + IN PACCESS_STATE AccessState, + IN ULONG AdditionalReferences, + IN ULONG HandleAttributes, + IN KPROCESSOR_MODE AccessMode, + OUT PVOID *ReturnedObject, + OUT PHANDLE ReturnedHandle) { HANDLE_TABLE_ENTRY NewEntry; PEPROCESS Process, CurrentProcess; @@ -446,7 +449,7 @@ ObReferenceObject(ObjectBody); } - *HandleReturn = Handle; + *ReturnedHandle = Handle; return STATUS_SUCCESS; } @@ -550,11 +553,13 @@ Ret = (HandleTableEntry->ObAttributes & EX_HANDLE_ENTRY_INHERITABLE) != 0; if(Ret) { + /* Get the object header */ + ObjectHeader = EX_HTE_TO_HDR(HandleTableEntry); + /* Setup the access state */ AccessState.PreviouslyGrantedAccess = HandleTableEntry->GrantedAccess; /* Get the object header and increment the handle and pointer counts */ - ObjectHeader = EX_HTE_TO_HDR(HandleTableEntry); InterlockedIncrement(&ObjectHeader->HandleCount); InterlockedIncrement(&ObjectHeader->PointerCount); } @@ -790,9 +795,11 @@ OBJECT_CREATE_INFORMATION ObjectCreateInfo; NTSTATUS Status; OBP_LOOKUP_CONTEXT Context; + POBJECT_HEADER ObjectHeader; AUX_DATA AuxData; PGENERIC_MAPPING GenericMapping = NULL; ACCESS_STATE AccessState; + OB_OPEN_REASON OpenReason; PAGED_CODE(); /* Capture all the info */ @@ -840,10 +847,28 @@ NULL); if (!NT_SUCCESS(Status)) goto Cleanup; + /* Check if this object has create information */ + ObjectHeader = OBJECT_TO_OBJECT_HEADER(Object); + if (ObjectHeader->Flags & OB_FLAG_CREATE_INFO) + { + /* Then we are creating a new handle */ + OpenReason = ObCreateHandle; + } + else + { + /* Otherwise, we are merely opening it */ + OpenReason = ObOpenHandle; + } + /* Create the actual handle now */ - Status = ObpCreateHandle(Object, + Status = ObpCreateHandle(OpenReason, + Object, + ObjectType, PassedAccessState, + 0, ObjectCreateInfo.Attributes, + AccessMode, + NULL, Handle); Cleanup: @@ -910,9 +935,14 @@ } /* Create the handle */ - Status = ObpCreateHandle(Object, + Status = ObpCreateHandle(ObOpenHandle, + Object, + ObjectType, PassedAccessState, + 0, HandleAttributes, + AccessMode, + NULL, Handle); /* Delete the access state */ @@ -924,6 +954,7 @@ /* ROS Hack: Dereference the object and return */ ObDereferenceObject(Object); + /* Return */ OBTRACE("OBTRACE: %s returning Object with PC S: %lx %lx\n", __FUNCTION__, OBJECT_TO_OBJECT_HEADER(Object)->PointerCount, @@ -1128,12 +1159,15 @@ DPRINT("Creating handle\n"); if (Handle != NULL) { - Status = ObpCreateHandle(&Header->Body, - PassedAccessState, - ObjectCreateInfo->Attributes, - Handle); - DPRINT("handle Created: %d. refcount. handlecount %d %d\n", - *Handle, Header->PointerCount, Header->HandleCount); + Status = ObpCreateHandle(ObCreateHandle, + &Header->Body, + NULL, + PassedAccessState, + AdditionalReferences + 1, + ObjectCreateInfo->Attributes, + ExGetPreviousMode(), + NULL, + Handle); } /* We can delete the Create Info now */ @@ -1260,9 +1294,14 @@ DesiredAccess, &ObjectType->TypeInfo.GenericMapping); - Status = ObpCreateHandle(ObjectBody, + Status = ObpCreateHandle(ObDuplicateHandle, + ObjectBody, + ObjectType, PassedAccessState, + 0, HandleAttributes, + PreviousMode, + NULL, &hTarget); if (AttachedToProcess)

1 0

[ion] 22265: - Add some trace macros to monitor handle/pointer counts for fixing regressions/bugs later. - Change ObpCreateHandle to use an ACCESS_STATE structure instead of DesiredAccess. This is to help moving to an updated model where creating and incrementing a handle are 2 operations, so that code can be refactored (similarly to how we now have Delete/Decrement as 2 operations). - Fix functions that were not creating an ACCESS_STATE Structure to create one locally now, or use the one passed
by ion＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: ion Date: Wed Jun 7 09:04:43 2006 New Revision: 22265 URL: http://svn.reactos.ru/svn/reactos?rev=22265&view=rev Log: - Add some trace macros to monitor handle/pointer counts for fixing regressions/bugs later. - Change ObpCreateHandle to use an ACCESS_STATE structure instead of DesiredAccess. This is to help moving to an updated model where creating and incrementing a handle are 2 operations, so that code can be refactored (similarly to how we now have Delete/Decrement as 2 operations). - Fix functions that were not creating an ACCESS_STATE Structure to create one locally now, or use the one passed as a parameter, if available. Modified: trunk/reactos/ntoskrnl/ob/obhandle.c Modified: trunk/reactos/ntoskrnl/ob/obhandle.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/ob/obhandle.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ob/obhandle.c (original) +++ trunk/reactos/ntoskrnl/ob/obhandle.c Wed Jun 7 09:04:43 2006 @@ -18,6 +18,12 @@ #include <internal/debug.h> PHANDLE_TABLE ObpKernelHandleTable = NULL; + +#ifdef _OBDEBUG_ +#define OBTRACE DPRINT1 +#else +#define OBTRACE DPRINT +#endif /* UGLY FUNCTIONS ************************************************************/ @@ -215,6 +221,11 @@ /* Get the object type and header */ ObjectHeader = OBJECT_TO_OBJECT_HEADER(ObjectBody); ObjectType = ObjectHeader->Type; + OBTRACE("OBTRACE - %s - Decrementing count for: %p. HC LC %lx %lx\n", + __FUNCTION__, + ObjectBody, + ObjectHeader->HandleCount, + ObjectHeader->PointerCount); /* FIXME: The process handle count should be in the Handle DB. Investigate */ SystemHandleCount = ObjectHeader->HandleCount; @@ -239,6 +250,11 @@ /* Decrease the total number of handles for this type */ ObjectType->TotalNumberOfHandles--; + OBTRACE("OBTRACE - %s - Decremented count for: %p. HC LC %lx %lx\n", + __FUNCTION__, + ObjectBody, + ObjectHeader->HandleCount, + ObjectHeader->PointerCount); } /*++ @@ -285,6 +301,12 @@ ObjectType = ObjectHeader->Type; Body = &ObjectHeader->Body; GrantedAccess = HandleEntry->GrantedAccess; + OBTRACE("OBTRACE - %s - Deleting handle: %lx for %p. HC LC %lx %lx\n", + __FUNCTION__, + Handle, + Body, + ObjectHeader->HandleCount, + ObjectHeader->PointerCount); /* Check if the object has an Okay To Close procedure */ if (ObjectType->TypeInfo.OkayToCloseProcedure) @@ -316,6 +338,12 @@ /* Now decrement the handle count */ ObpDecrementHandleCount(Body, PsGetCurrentProcess(), GrantedAccess); Status = STATUS_SUCCESS; + OBTRACE("OBTRACE - %s - Deleted handle: %lx for %p. HC LC %lx %lx\n", + __FUNCTION__, + Handle, + Body, + ObjectHeader->HandleCount, + ObjectHeader->PointerCount); } /* Leave the critical region and return the status */ @@ -326,7 +354,7 @@ NTSTATUS NTAPI ObpCreateHandle(PVOID ObjectBody, - ACCESS_MASK GrantedAccess, + PACCESS_STATE AccessState, ULONG HandleAttributes, PHANDLE HandleReturn) /* @@ -343,6 +371,7 @@ HANDLE Handle; KAPC_STATE ApcState; BOOLEAN AttachedToProcess = FALSE; + ACCESS_MASK GrantedAccess; PAGED_CODE(); @@ -357,6 +386,8 @@ /* check that this is a valid kernel pointer */ ASSERT((ULONG_PTR)ObjectHeader & EX_HANDLE_ENTRY_LOCKED); + GrantedAccess = AccessState->RemainingDesiredAccess | + AccessState->PreviouslyGrantedAccess; if (GrantedAccess & MAXIMUM_ALLOWED) { GrantedAccess &= ~MAXIMUM_ALLOWED; @@ -512,12 +543,16 @@ { POBJECT_HEADER ObjectHeader; BOOLEAN Ret = FALSE; + ACCESS_STATE AccessState; PAGED_CODE(); /* Make sure that the handle is inheritable */ Ret = (HandleTableEntry->ObAttributes & EX_HANDLE_ENTRY_INHERITABLE) != 0; if(Ret) { + /* Setup the access state */ + AccessState.PreviouslyGrantedAccess = HandleTableEntry->GrantedAccess; + /* Get the object header and increment the handle and pointer counts */ ObjectHeader = EX_HTE_TO_HDR(HandleTableEntry); InterlockedIncrement(&ObjectHeader->HandleCount); @@ -807,7 +842,7 @@ /* Create the actual handle now */ Status = ObpCreateHandle(Object, - DesiredAccess, + PassedAccessState, ObjectCreateInfo.Attributes, Handle); @@ -825,6 +860,10 @@ Quickie: ObpReleaseCapturedAttributes(&ObjectCreateInfo); if (ObjectName.Buffer) ObpReleaseCapturedName(&ObjectName); + OBTRACE("OBTRACE: %s returning Object with PC S: %lx %lx\n", + __FUNCTION__, + OBJECT_TO_OBJECT_HEADER(Object)->PointerCount, + Status); return Status; } @@ -842,6 +881,8 @@ OUT PHANDLE Handle) { NTSTATUS Status; + ACCESS_STATE AccessState; + AUX_DATA AuxData; PAGED_CODE(); /* Reference the object */ @@ -851,14 +892,42 @@ AccessMode); if (!NT_SUCCESS(Status)) return Status; + /* Check if we didn't get an access state */ + if (!PassedAccessState) + { + /* Use our built-in access state */ + PassedAccessState = &AccessState; + Status = SeCreateAccessState(&AccessState, + &AuxData, + DesiredAccess, + &ObjectType->TypeInfo.GenericMapping); + if (!NT_SUCCESS(Status)) + { + /* Fail */ + ObDereferenceObject(Object); + return Status; + } + } + /* Create the handle */ Status = ObpCreateHandle(Object, - DesiredAccess, + PassedAccessState, HandleAttributes, Handle); + /* Delete the access state */ + if (PassedAccessState == &AccessState) + { + SeDeleteAccessState(PassedAccessState); + } + /* ROS Hack: Dereference the object and return */ ObDereferenceObject(Object); + + OBTRACE("OBTRACE: %s returning Object with PC S: %lx %lx\n", + __FUNCTION__, + OBJECT_TO_OBJECT_HEADER(Object)->PointerCount, + Status); return Status; } @@ -915,6 +984,8 @@ SECURITY_SUBJECT_CONTEXT SubjectContext; OBP_LOOKUP_CONTEXT Context; POBJECT_HEADER_NAME_INFO ObjectNameInfo; + ACCESS_STATE AccessState; + AUX_DATA AuxData; PAGED_CODE(); /* Get the Header and Create Info */ @@ -1030,6 +1101,23 @@ DPRINT("Security Complete\n"); SeReleaseSubjectContext(&SubjectContext); + /* Check if we didn't get an access state */ + if (!PassedAccessState) + { + /* Use our built-in access state */ + PassedAccessState = &AccessState; + Status = SeCreateAccessState(&AccessState, + &AuxData, + DesiredAccess, + &Header->Type->TypeInfo.GenericMapping); + if (!NT_SUCCESS(Status)) + { + /* Fail */ + ObDereferenceObject(Object); + return Status; + } + } + /* Create the Handle */ /* HACKHACK: Because of ROS's incorrect startup, this can be called * without a valid Process until I finalize the startup patch, @@ -1041,7 +1129,7 @@ if (Handle != NULL) { Status = ObpCreateHandle(&Header->Body, - DesiredAccess, + PassedAccessState, ObjectCreateInfo->Attributes, Handle); DPRINT("handle Created: %d. refcount. handlecount %d %d\n", @@ -1076,6 +1164,9 @@ KPROCESSOR_MODE PreviousMode; KAPC_STATE ApcState; NTSTATUS Status = STATUS_SUCCESS; + ACCESS_STATE AccessState; + AUX_DATA AuxData; + PACCESS_STATE PassedAccessState = NULL; PAGED_CODE(); @@ -1162,8 +1253,15 @@ AttachedToProcess = TRUE; } + /* Use our built-in access state */ + PassedAccessState = &AccessState; + Status = SeCreateAccessState(&AccessState, + &AuxData, + DesiredAccess, + &ObjectType->TypeInfo.GenericMapping); + Status = ObpCreateHandle(ObjectBody, - DesiredAccess, + PassedAccessState, HandleAttributes, &hTarget);

1 0

[ion] 22264: - Clone ObpCreateHandle to CmpCreateHandle. I am about to fix its implementation and since Cm* currently abuses Ob I feel it safer to give its own internal function. - Make ObpCreateHandle internal to Ob as it should be. Change NtCreateProcessTokenEx to use ObOpenObjectByPointer, it has no business manually trying to create a handle. Same goes for ExpLoadInitialProcess.
by ion＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: ion Date: Wed Jun 7 05:47:33 2006 New Revision: 22264 URL: http://svn.reactos.ru/svn/reactos?rev=22264&view=rev Log: - Clone ObpCreateHandle to CmpCreateHandle. I am about to fix its implementation and since Cm* currently abuses Ob I feel it safer to give its own internal function. - Make ObpCreateHandle internal to Ob as it should be. Change NtCreateProcessTokenEx to use ObOpenObjectByPointer, it has no business manually trying to create a handle. Same goes for ExpLoadInitialProcess. Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c trunk/reactos/ntoskrnl/ex/init.c trunk/reactos/ntoskrnl/include/internal/ob.h trunk/reactos/ntoskrnl/ps/security.c Modified: trunk/reactos/ntoskrnl/cm/ntfunc.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/cm/ntfunc.c?rev=22… ============================================================================== --- trunk/reactos/ntoskrnl/cm/ntfunc.c (original) +++ trunk/reactos/ntoskrnl/cm/ntfunc.c Wed Jun 7 05:47:33 2006 @@ -29,6 +29,106 @@ FAST_MUTEX CmiCallbackLock; /* FUNCTIONS ****************************************************************/ + +NTSTATUS +NTAPI +CmpCreateHandle(PVOID ObjectBody, + ACCESS_MASK GrantedAccess, + ULONG HandleAttributes, + PHANDLE HandleReturn) + /* + * FUNCTION: Add a handle referencing an object + * ARGUMENTS: + * obj = Object body that the handle should refer to + * RETURNS: The created handle + * NOTE: The handle is valid only in the context of the current process + */ +{ + HANDLE_TABLE_ENTRY NewEntry; + PEPROCESS Process, CurrentProcess; + POBJECT_HEADER ObjectHeader; + HANDLE Handle; + KAPC_STATE ApcState; + BOOLEAN AttachedToProcess = FALSE; + + PAGED_CODE(); + + DPRINT("CmpCreateHandle(obj %p)\n",ObjectBody); + + ASSERT(ObjectBody); + + CurrentProcess = PsGetCurrentProcess(); + + ObjectHeader = OBJECT_TO_OBJECT_HEADER(ObjectBody); + + /* check that this is a valid kernel pointer */ + ASSERT((ULONG_PTR)ObjectHeader & EX_HANDLE_ENTRY_LOCKED); + + if (GrantedAccess & MAXIMUM_ALLOWED) + { + GrantedAccess &= ~MAXIMUM_ALLOWED; + GrantedAccess |= GENERIC_ALL; + } + + if (GrantedAccess & GENERIC_ACCESS) + { + RtlMapGenericMask(&GrantedAccess, + &ObjectHeader->Type->TypeInfo.GenericMapping); + } + + NewEntry.Object = ObjectHeader; + if(HandleAttributes & OBJ_INHERIT) + NewEntry.ObAttributes |= EX_HANDLE_ENTRY_INHERITABLE; + else + NewEntry.ObAttributes &= ~EX_HANDLE_ENTRY_INHERITABLE; + NewEntry.GrantedAccess = GrantedAccess; + + if ((HandleAttributes & OBJ_KERNEL_HANDLE) && + ExGetPreviousMode == KernelMode) + { + Process = PsInitialSystemProcess; + if (Process != CurrentProcess) + { + KeStackAttachProcess(&Process->Pcb, + &ApcState); + AttachedToProcess = TRUE; + } + } + else + { + Process = CurrentProcess; + /* mask out the OBJ_KERNEL_HANDLE attribute */ + HandleAttributes &= ~OBJ_KERNEL_HANDLE; + } + + Handle = ExCreateHandle(Process->ObjectTable, + &NewEntry); + + if (AttachedToProcess) + { + KeUnstackDetachProcess(&ApcState); + } + + if(Handle != NULL) + { + if (HandleAttributes & OBJ_KERNEL_HANDLE) + { + /* mark the handle value */ + Handle = ObMarkHandleAsKernelHandle(Handle); + } + + if(InterlockedIncrement(&ObjectHeader->HandleCount) == 1) + { + ObReferenceObject(ObjectBody); + } + + *HandleReturn = Handle; + + return STATUS_SUCCESS; + } + + return STATUS_UNSUCCESSFUL; +} /* * @implemented @@ -291,13 +391,13 @@ goto Cleanup; } - Status = ObpCreateHandle(Object, + Status = CmpCreateHandle(Object, DesiredAccess, ObjectCreateInfo.Attributes, &hKey); if (!NT_SUCCESS(Status)) - DPRINT1("ObpCreateHandle failed Status 0x%x\n", Status); + DPRINT1("CmpCreateHandle failed Status 0x%x\n", Status); PostCreateKeyInfo.Object = NULL; PostCreateKeyInfo.Status = Status; @@ -1361,7 +1461,7 @@ goto openkey_cleanup; } - Status = ObpCreateHandle(Object, + Status = CmpCreateHandle(Object, DesiredAccess, ObjectCreateInfo.Attributes, &hKey); Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=2226… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c (original) +++ trunk/reactos/ntoskrnl/ex/init.c Wed Jun 7 05:47:33 2006 @@ -426,21 +426,9 @@ { UNICODE_STRING CurrentDirectory; UNICODE_STRING ImagePath = RTL_CONSTANT_STRING(L"\\SystemRoot\\system32\\smss.exe"); - HANDLE SystemProcessHandle; NTSTATUS Status; PRTL_USER_PROCESS_PARAMETERS Params=NULL; RTL_USER_PROCESS_INFORMATION Info; - - /* Create a handle to the process */ - Status = ObpCreateHandle(PsInitialSystemProcess, - PROCESS_CREATE_PROCESS | PROCESS_CREATE_THREAD | PROCESS_QUERY_INFORMATION, - OBJ_KERNEL_HANDLE, - &SystemProcessHandle); - if(!NT_SUCCESS(Status)) - { - DPRINT1("Failed to create a handle for the system process!\n"); - return Status; - } RtlInitUnicodeString(&CurrentDirectory, SharedUserData->NtSystemRoot); @@ -459,7 +447,6 @@ if(!NT_SUCCESS(Status)) { DPRINT1("Failed to create ppb!\n"); - ZwClose(SystemProcessHandle); return Status; } @@ -469,14 +456,13 @@ Params, NULL, NULL, - SystemProcessHandle, + NULL, FALSE, NULL, NULL, &Info); /* Close the handle and free the params */ - ZwClose(SystemProcessHandle); RtlDestroyProcessParameters(Params); if (!NT_SUCCESS(Status)) Modified: trunk/reactos/ntoskrnl/include/internal/ob.h URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/include/internal/o… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/ob.h (original) +++ trunk/reactos/ntoskrnl/include/internal/ob.h Wed Jun 7 05:47:33 2006 @@ -68,15 +68,6 @@ NTAPI ObInitSymbolicLinkImplementation( VOID -); - -NTSTATUS -NTAPI -ObpCreateHandle( - PVOID ObjectBody, - ACCESS_MASK GrantedAccess, - ULONG HandleAttributes, - PHANDLE Handle ); NTSTATUS Modified: trunk/reactos/ntoskrnl/ps/security.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/ntoskrnl/ps/security.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ps/security.c (original) +++ trunk/reactos/ntoskrnl/ps/security.c Wed Jun 7 05:47:33 2006 @@ -97,10 +97,13 @@ &Token); if(NT_SUCCESS(Status)) { - Status = ObpCreateHandle(Token, - DesiredAccess, - HandleAttributes, - &hToken); + Status = ObOpenObjectByPointer(Token, + 0, + NULL, + DesiredAccess, + SepTokenObjectType, + PreviousMode, + &hToken); ObDereferenceObject(Token); if(NT_SUCCESS(Status))

1 0

[jimtabor] 22263: Quick patch.
by jimtabor＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: jimtabor Date: Wed Jun 7 05:45:18 2006 New Revision: 22263 URL: http://svn.reactos.ru/svn/reactos?rev=22263&view=rev Log: Quick patch. Modified: trunk/reactos/subsystems/win32/win32k/objects/text.c Modified: trunk/reactos/subsystems/win32/win32k/objects/text.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/subsystems/win32/win32k/obj… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/text.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/text.c Wed Jun 7 05:45:18 2006 @@ -3280,12 +3280,11 @@ if (!dc) { SetLastWin32Error(ERROR_INVALID_HANDLE); - } - else - { - Ret = dc->w.charExtra; - if( Set ) dc->w.charExtra = CharExtra; - } + return Ret; + } + Ret = dc->w.charExtra; + if( Set ) dc->w.charExtra = CharExtra; + DC_UnlockDc(dc); return (Ret); }

1 0

[jimtabor] 22262: Cleanup coding of IntGdiPolyPolygon and IntGdiPolygon.
by jimtabor＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: jimtabor Date: Wed Jun 7 05:28:44 2006 New Revision: 22262 URL: http://svn.reactos.ru/svn/reactos?rev=22262&view=rev Log: Cleanup coding of IntGdiPolyPolygon and IntGdiPolygon. Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c Modified: trunk/reactos/subsystems/win32/win32k/objects/fillshap.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/subsystems/win32/win32k/obj… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/fillshap.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/fillshap.c Wed Jun 7 05:28:44 2006 @@ -94,7 +94,7 @@ if (FillBrushObj && !(FillBrushObj->flAttrs & GDIBRUSH_IS_NULL)) { IntGdiInitBrushInstance(&FillBrushInst, FillBrushObj, dc->XlateBrush); - ret = FillPolygon ( dc, BitmapObj, &FillBrushInst.BrushObject, ROP2_TO_MIX(dc->w.ROPmode), UnsafePoints, Count, DestRect ); + ret = FillPolygon ( dc, BitmapObj, &FillBrushInst.BrushObject, ROP2_TO_MIX(dc->w.ROPmode), UnsafePoints, Count, DestRect ); } BRUSHOBJ_UnlockBrush(FillBrushObj); @@ -104,35 +104,29 @@ if (PenBrushObj && !(PenBrushObj->flAttrs & GDIBRUSH_IS_NULL)) { IntGdiInitBrushInstance(&PenBrushInst, PenBrushObj, dc->XlatePen); - for ( CurrentPoint = 0; CurrentPoint < Count; ++CurrentPoint ) - { - POINT To, From; //, Next; - - /* Let CurrentPoint be i - * if i+1 > Count, Draw a line from Points[i] to Points[0] - * Draw a line from Points[i] to Points[i+1] - */ - From = UnsafePoints[CurrentPoint]; - if (Count <= CurrentPoint + 1) - To = UnsafePoints[0]; - else - To = UnsafePoints[CurrentPoint + 1]; - - //DPRINT("Polygon Making line from (%d,%d) to (%d,%d)\n", From.x, From.y, To.x, To.y ); - ret = IntEngLineTo(&BitmapObj->SurfObj, + + while(Count-- >1) + { + +// DPRINT1("Polygon Making line from (%d,%d) to (%d,%d)\n", +// UnsafePoints[0].x, UnsafePoints[0].y, +// UnsafePoints[1].x, UnsafePoints[1].y ); + + ret = IntEngLineTo(&BitmapObj->SurfObj, dc->CombinedClip, &PenBrushInst.BrushObject, - From.x, - From.y, - To.x, - To.y, + UnsafePoints[0].x, /* From */ + UnsafePoints[0].y, + UnsafePoints[1].x, /* To */ + UnsafePoints[1].y, &DestRect, ROP2_TO_MIX(dc->w.ROPmode)); /* MIX */ + if(!ret) break; + UnsafePoints++; } } PENOBJ_UnlockPen(PenBrushObj); } - BITMAPOBJ_UnlockBitmap(BitmapObj); return ret; @@ -144,25 +138,12 @@ LPINT PolyCounts, int Count) { - int i; - LPPOINT pt; - LPINT pc; - BOOL ret = FALSE; // default to failure - - pt = Points; - pc = PolyCounts; - - for (i=0;i<Count;i++) - { - ret = IntGdiPolygon ( dc, pt, *pc ); - if (ret == FALSE) - { - return ret; - } - pt+=*pc++; - } - - return ret; + while(--Count >=0) + { + if(!IntGdiPolygon ( dc, Points, *PolyCounts )) return FALSE; + Points+=*PolyCounts++; + } + return TRUE; } /******************************************************************************/

1 0

[jimtabor] 22261: Implement Get & SetTextCharacterExtra. Does nothing ATM.
by jimtabor＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: jimtabor Date: Wed Jun 7 05:22:47 2006 New Revision: 22261 URL: http://svn.reactos.ru/svn/reactos?rev=22261&view=rev Log: Implement Get & SetTextCharacterExtra. Does nothing ATM. Modified: trunk/reactos/dll/win32/gdi32/misc/stubs.c trunk/reactos/include/reactos/win32k/ntgdibad.h trunk/reactos/subsystems/win32/win32k/objects/text.c trunk/reactos/tools/nci/w32ksvc.db Modified: trunk/reactos/dll/win32/gdi32/misc/stubs.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/gdi32/misc/stubs.… ============================================================================== --- trunk/reactos/dll/win32/gdi32/misc/stubs.c (original) +++ trunk/reactos/dll/win32/gdi32/misc/stubs.c Wed Jun 7 05:22:47 2006 @@ -251,9 +251,7 @@ HDC hDc ) { - UNIMPLEMENTED; - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return 0; + return NtGdiGetSetTextCharExtra( hDc, 0, FALSE); } @@ -390,13 +388,11 @@ int STDCALL SetTextCharacterExtra( - HDC a0, - int a1 - ) -{ - UNIMPLEMENTED; - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return 0; + HDC hDC, + int CharExtra + ) +{ + return NtGdiGetSetTextCharExtra( hDC, CharExtra, TRUE); } Modified: trunk/reactos/include/reactos/win32k/ntgdibad.h URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/include/reactos/win32k/ntgd… ============================================================================== --- trunk/reactos/include/reactos/win32k/ntgdibad.h (original) +++ trunk/reactos/include/reactos/win32k/ntgdibad.h Wed Jun 7 05:22:47 2006 @@ -680,6 +680,11 @@ INT STDCALL NtGdiGetRelAbs(HDC hDC); /* Should be done in user-mode using shared GDI Objects. */ +INT +STDCALL +NtGdiGetSetTextCharExtra( HDC hDC, INT CharExtra, BOOL Set); + +/* Should be done in user-mode using shared GDI Objects. */ INT STDCALL NtGdiGetStretchBltMode(HDC hDC); /* Use NtGdiDoPalette with GdiPalSetSystemEntries. */ Modified: trunk/reactos/subsystems/win32/win32k/objects/text.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/subsystems/win32/win32k/obj… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/text.c (original) +++ trunk/reactos/subsystems/win32/win32k/objects/text.c Wed Jun 7 05:22:47 2006 @@ -3267,4 +3267,26 @@ return sizeof(LOGFONTW); } + +/* Remove this HAX! after the below function is done in GDI32.DLL! */ +INT +STDCALL +NtGdiGetSetTextCharExtra( HDC hDC, INT CharExtra, BOOL Set) +{ + /* Ulta-Ugly Hax! */ + INT Ret = 0x80000000; + DPRINT("TextCharacterExtra %d", CharExtra); + PDC dc = DC_LockDc ( hDC ); + if (!dc) + { + SetLastWin32Error(ERROR_INVALID_HANDLE); + } + else + { + Ret = dc->w.charExtra; + if( Set ) dc->w.charExtra = CharExtra; + } + return (Ret); +} + /* EOF */ Modified: trunk/reactos/tools/nci/w32ksvc.db URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/tools/nci/w32ksvc.db?rev=22… ============================================================================== --- trunk/reactos/tools/nci/w32ksvc.db (original) +++ trunk/reactos/tools/nci/w32ksvc.db Wed Jun 7 05:22:47 2006 @@ -150,6 +150,7 @@ NtGdiGetRelAbs 1 NtGdiGetRegionData 3 NtGdiGetRgnBox 2 +NtGdiGetSetTextCharExtra 3 NtGdiGetStockObject 1 NtGdiGetStretchBltMode 1 NtGdiGetSystemPaletteEntries 4

1 0

[greatlrd] 22260: Implement %Fp now we have 25 fails with wine test for string version of *printf api
by greatlrd＠svn.reactos.org 07 Jun '06

07 Jun '06

Author: greatlrd Date: Wed Jun 7 04:04:51 2006 New Revision: 22260 URL: http://svn.reactos.ru/svn/reactos?rev=22260&view=rev Log: Implement %Fp now we have 25 fails with wine test for string version of *printf api Modified: trunk/reactos/lib/rtl/sprintf.c trunk/reactos/lib/rtl/swprintf.c Modified: trunk/reactos/lib/rtl/sprintf.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/rtl/sprintf.c?rev=22260… ============================================================================== --- trunk/reactos/lib/rtl/sprintf.c (original) +++ trunk/reactos/lib/rtl/sprintf.c Wed Jun 7 04:04:51 2006 @@ -26,7 +26,7 @@ #define LEFT 16 /* left justified */ #define SPECIAL 32 /* 0x */ #define LARGE 64 /* use 'ABCDEF' instead of 'abcdef' */ - +#define REMOVEHEX 256 /* use 256 as remve 0x frim BASE 16 */ typedef struct { unsigned int mantissal:32; unsigned int mantissah:20; @@ -116,7 +116,7 @@ } } - if (type & SPECIAL) { + if ((type & SPECIAL) && ((type & REMOVEHEX) == 0)) { if (base == 16) size -= 2; @@ -142,7 +142,7 @@ ++buf; } - if (type & SPECIAL) { + if ((type & SPECIAL) && ((type & REMOVEHEX) == 0)) { if (base==16) { if (buf <= end) *buf = '0'; @@ -213,7 +213,7 @@ size--; } } - if (type & SPECIAL) { + if (type & SPECIAL) { if (base == 16) size -= 2; else if (base == 8) @@ -470,7 +470,10 @@ } else if (*fmt == 'I' && *(fmt+1) == '3' && *(fmt+2) == '2') { qualifier = 'l'; fmt += 3; - } + } else if (*fmt == 'F' && *(fmt+1) == 'p') { + fmt += 1; + flags |= REMOVEHEX; + } /* default base */ base = 10; Modified: trunk/reactos/lib/rtl/swprintf.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/rtl/swprintf.c?rev=2226… ============================================================================== --- trunk/reactos/lib/rtl/swprintf.c (original) +++ trunk/reactos/lib/rtl/swprintf.c Wed Jun 7 04:04:51 2006 @@ -26,7 +26,7 @@ #define LEFT 16 /* left justified */ #define SPECIAL 32 /* 0x */ #define LARGE 64 /* use 'ABCDEF' instead of 'abcdef' */ - +#define REMOVEHEX 256 /* use 256 as remve 0x frim BASE 16 */ typedef struct { unsigned int mantissal:32; unsigned int mantissah:20; @@ -116,7 +116,7 @@ } } - if (type & SPECIAL) { + if ((type & SPECIAL) && ((type & REMOVEHEX) == 0)) { if (base == 16) size -= 2; } @@ -141,7 +141,7 @@ ++buf; } - if (type & SPECIAL) { + if ((type & SPECIAL) && ((type & REMOVEHEX) == 0)) { if (base==16) { if (buf <= end) *buf = L'0'; @@ -468,7 +468,10 @@ } else if (*fmt == L'I' && *(fmt+1) == L'3' && *(fmt+2) == L'2') { qualifier = L'l'; fmt += 3; - } + } else if (*fmt == L'F' && *(fmt+1) == L'p') { + fmt += 1; + flags |= REMOVEHEX; + } /* default base */ base = 10; @@ -566,8 +569,7 @@ case L'p': if ((flags & LARGE) == 0) - flags |= LARGE; - + flags |= LARGE; if (field_width == -1) { field_width = 2*sizeof(void *); flags |= ZEROPAD;

1 0

[greatlrd] 22259: using uppercaps for %p instead lowercaps when it format the string, that make passing one more of wine test 27 fails now
by greatlrd＠svn.reactos.org 06 Jun '06

06 Jun '06

Author: greatlrd Date: Wed Jun 7 03:22:11 2006 New Revision: 22259 URL: http://svn.reactos.ru/svn/reactos?rev=22259&view=rev Log: using uppercaps for %p instead lowercaps when it format the string, that make passing one more of wine test 27 fails now Modified: trunk/reactos/lib/rtl/sprintf.c trunk/reactos/lib/rtl/swprintf.c Modified: trunk/reactos/lib/rtl/sprintf.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/rtl/sprintf.c?rev=22259… ============================================================================== --- trunk/reactos/lib/rtl/sprintf.c (original) +++ trunk/reactos/lib/rtl/sprintf.c Wed Jun 7 03:22:11 2006 @@ -566,6 +566,9 @@ continue; case 'p': + if ((flags & LARGE) == 0) + flags |= LARGE; + if (field_width == -1) { field_width = 2 * sizeof(void *); flags |= ZEROPAD; Modified: trunk/reactos/lib/rtl/swprintf.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/rtl/swprintf.c?rev=2225… ============================================================================== --- trunk/reactos/lib/rtl/swprintf.c (original) +++ trunk/reactos/lib/rtl/swprintf.c Wed Jun 7 03:22:11 2006 @@ -565,6 +565,9 @@ continue; case L'p': + if ((flags & LARGE) == 0) + flags |= LARGE; + if (field_width == -1) { field_width = 2*sizeof(void *); flags |= ZEROPAD;

1 0

[janderwald] 22258: add Wine's powrprof to build
by janderwald＠svn.reactos.org 06 Jun '06

06 Jun '06

Author: janderwald Date: Wed Jun 7 03:14:09 2006 New Revision: 22258 URL: http://svn.reactos.ru/svn/reactos?rev=22258&view=rev Log: add Wine's powrprof to build Added: trunk/reactos/dll/win32/powrprof/powrprof.rbuild (with props) trunk/reactos/dll/win32/powrprof/powrprof.rc (with props) trunk/reactos/dll/win32/powrprof/powrprof_gcc.def (with props) Modified: trunk/reactos/baseaddress.rbuild trunk/reactos/dll/win32/powrprof/powrprof.c (contents, props changed) trunk/reactos/dll/win32/win32.rbuild trunk/reactos/media/doc/README.WINE Modified: trunk/reactos/baseaddress.rbuild URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/baseaddress.rbuild?rev=2225… ============================================================================== --- trunk/reactos/baseaddress.rbuild (original) +++ trunk/reactos/baseaddress.rbuild Wed Jun 7 03:14:09 2006 @@ -62,6 +62,7 @@ <property name="BASEADDRESS_ICMP" value="0x741F0000" /> <property name="BASEADDRESS_USERENV" value="0x74850000" /> <property name="BASEADDRESS_SYSSETUP" value="0x74a30000" /> + <property name="BASEADDRESS_POWRPROF" value="0x74ad0000" /> <property name="BASEADDRESS_OLEDLG" value="0x74d00000" /> <property name="BASEADDRESS_SAMSRV" value="0x74f30000" /> <property name="BASEADDRESS_SAMLIB" value="0x750C0000" /> Modified: trunk/reactos/dll/win32/powrprof/powrprof.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/powrprof/powrprof… ============================================================================== --- trunk/reactos/dll/win32/powrprof/powrprof.c (original) +++ trunk/reactos/dll/win32/powrprof/powrprof.c Wed Jun 7 03:14:09 2006 @@ -1,344 +1,344 @@ -/* - * Copyright (C) 2005 Benjamin Cutler - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - - -#include <stdarg.h> - -#include "ntstatus.h" -#define WIN32_NO_STATUS -#include "windef.h" -#include "winbase.h" -#include "winnt.h" -#include "winreg.h" -#include "winternl.h" -#include "powrprof.h" -#include "wine/debug.h" -#include "wine/unicode.h" - -WINE_DEFAULT_DEBUG_CHANNEL(powrprof); - -/* Notes to implementors: - * #1: The native implementation of these functions attempted to read in - * registry entries that I was unable to locate on any of the Windows - * machines I checked, but I only had desktops available, so maybe - * laptop users will have better luck. They return FNF errors because - * that's what the native DLL was returning during my tests. - * #2: These functions call NtPowerInformation but I don't know what they - * do with the results, and NtPowerInformation doesn't do much in WINE yet - * anyway. - * #3: Since I can't get several other functions working (see note #1), - * implementing these functions is going to have to wait until somebody can - * cobble together some sane test input. */ - -static const WCHAR szPowerCfgSubKey[] = { 'S', 'o', 'f', 't', 'w', 'a', 'r', 'e', - '\\', 'M', 'i', 'c', 'r', 'o', 's', 'o', 'f', 't', '\\', 'W', 'i', - 'n', 'd', 'o', 'w', 's', '\\', 'C', 'u', 'r', 'r', 'e', 'n', 't', - 'V', 'e', 'r', 's', 'i', 'o', 'n', '\\', 'C', 'o', 'n', 't', 'r', - 'o', 'l', 's', ' ', 'F', 'o', 'l', 'd', 'e', 'r', '\\', 'P', 'o', - 'w', 'e', 'r', 'C', 'f', 'g', 0 }; -static const WCHAR szSemaphoreName[] = { 'P', 'o', 'w', 'e', 'r', 'P', 'r', 'o', - 'f', 'i', 'l', 'e', 'R', 'e', 'g', 'i', 's', 't', 'r', 'y', 'S', - 'e', 'm', 'a', 'p', 'h', 'o', 'r', 'e', 0 }; -static const WCHAR szDiskMax[] = { 'D', 'i', 's', 'k', 'S', 'p', 'i', 'n', 'd', - 'o', 'w', 'n', 'M', 'a', 'x', 0 }; -static const WCHAR szDiskMin[] = { 'D', 'i', 's', 'k', 'S', 'p', 'i', 'n', 'd', - 'o', 'w', 'n', 'M', 'i', 'n', 0 }; -static const WCHAR szLastID[] = { 'L', 'a', 's', 't', 'I', 'D', 0 }; -static HANDLE PPRegSemaphore = NULL; - -NTSTATUS WINAPI CallNtPowerInformation( - POWER_INFORMATION_LEVEL InformationLevel, - PVOID lpInputBuffer, ULONG nInputBufferSize, - PVOID lpOutputBuffer, ULONG nOutputBufferSize) -{ - return NtPowerInformation(InformationLevel, lpInputBuffer, - nInputBufferSize, lpOutputBuffer, nOutputBufferSize); -} - -BOOLEAN WINAPI CanUserWritePwrScheme(VOID) -{ - HKEY hKey = NULL; - LONG r; - BOOLEAN bSuccess = TRUE; - - TRACE("()\n"); - - r = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szPowerCfgSubKey, 0, KEY_READ | KEY_WRITE, &hKey); - - if (r != ERROR_SUCCESS) { - TRACE("RegOpenKeyEx failed: %ld\n", r); - bSuccess = FALSE; - } - - SetLastError(r); - RegCloseKey(hKey); - return bSuccess; -} - -BOOLEAN WINAPI DeletePwrScheme(UINT uiIndex) -{ - /* FIXME: See note #1 */ - FIXME("(%d) stub!\n", uiIndex); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI EnumPwrSchemes(PWRSCHEMESENUMPROC lpfnPwrSchemesEnumProc, - LPARAM lParam) -{ - /* FIXME: See note #1 */ - FIXME("(%p, %ld) stub!\n", lpfnPwrSchemesEnumProc, lParam); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI GetActivePwrScheme(PUINT puiID) -{ - /* FIXME: See note #1 */ - FIXME("(%p) stub!\n", puiID); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI GetCurrentPowerPolicies( - PGLOBAL_POWER_POLICY pGlobalPowerPolicy, - PPOWER_POLICY pPowerPolicy) -{ - /* FIXME: See note #2 */ - SYSTEM_POWER_POLICY ACPower, DCPower; - - FIXME("(%p, %p) stub!\n", pGlobalPowerPolicy, pPowerPolicy); - - NtPowerInformation(SystemPowerPolicyAc, 0, 0, &ACPower, sizeof(SYSTEM_POWER_POLICY)); - NtPowerInformation(SystemPowerPolicyDc, 0, 0, &DCPower, sizeof(SYSTEM_POWER_POLICY)); - - return FALSE; -} - -BOOLEAN WINAPI GetPwrCapabilities( - PSYSTEM_POWER_CAPABILITIES lpSystemPowerCapabilities) -{ - NTSTATUS r; - - TRACE("(%p)\n", lpSystemPowerCapabilities); - - r = NtPowerInformation(SystemPowerCapabilities, 0, 0, lpSystemPowerCapabilities, sizeof(SYSTEM_POWER_CAPABILITIES)); - - SetLastError(RtlNtStatusToDosError(r)); - - return r == STATUS_SUCCESS; -} - -BOOLEAN WINAPI GetPwrDiskSpindownRange(PUINT RangeMax, PUINT RangeMin) -{ - HKEY hKey; - BYTE lpValue[40]; - LONG r; - DWORD cbValue = sizeof(lpValue); - - TRACE("(%p, %p)\n", RangeMax, RangeMin); - - if (RangeMax == NULL || RangeMin == NULL) { - SetLastError(ERROR_INVALID_PARAMETER); - return FALSE; - } - - SetLastError(ERROR_SUCCESS); - - WaitForSingleObject(PPRegSemaphore, INFINITE); - - r = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szPowerCfgSubKey, 0, KEY_READ, &hKey); - if (r != ERROR_SUCCESS) { - TRACE("RegOpenKeyEx failed: %ld\n", r); - TRACE("Using defaults: 3600, 3\n"); - *RangeMax = 3600; - *RangeMin = 3; - ReleaseSemaphore(PPRegSemaphore, 1, NULL); - return TRUE; - } - - r = RegQueryValueExW(hKey, szDiskMax, 0, 0, lpValue, &cbValue); - if (r != ERROR_SUCCESS) { - TRACE("Couldn't open DiskSpinDownMax: %ld\n", r); - TRACE("Using default: 3600\n"); - *RangeMax = 3600; - } else { - *RangeMax = atoiW((LPCWSTR)lpValue); - } - - cbValue = sizeof(lpValue); - - r = RegQueryValueExW(hKey, szDiskMin, 0, 0, lpValue, &cbValue); - if (r != ERROR_SUCCESS) { - TRACE("Couldn't open DiskSpinDownMin: %ld\n", r); - TRACE("Using default: 3\n"); - *RangeMin = 3; - } else { - *RangeMin = atoiW((LPCWSTR)lpValue); - } - - RegCloseKey(hKey); - - ReleaseSemaphore(PPRegSemaphore, 1, NULL); - - return TRUE; -} - -BOOLEAN WINAPI IsAdminOverrideActive(PADMINISTRATOR_POWER_POLICY p) -{ - FIXME("( %p) stub!\n", p); - return FALSE; -} - -BOOLEAN WINAPI IsPwrHibernateAllowed(VOID) -{ - /* FIXME: See note #2 */ - SYSTEM_POWER_CAPABILITIES PowerCaps; - FIXME("() stub!\n"); - NtPowerInformation(SystemPowerCapabilities, NULL, 0, &PowerCaps, sizeof(PowerCaps)); - return FALSE; -} - -BOOLEAN WINAPI IsPwrShutdownAllowed(VOID) -{ - /* FIXME: See note #2 */ - SYSTEM_POWER_CAPABILITIES PowerCaps; - FIXME("() stub!\n"); - NtPowerInformation(SystemPowerCapabilities, NULL, 0, &PowerCaps, sizeof(PowerCaps)); - return FALSE; -} - -BOOLEAN WINAPI IsPwrSuspendAllowed(VOID) -{ - /* FIXME: See note #2 */ - SYSTEM_POWER_CAPABILITIES PowerCaps; - FIXME("() stub!\n"); - NtPowerInformation(SystemPowerCapabilities, NULL, 0, &PowerCaps, sizeof(PowerCaps)); - return FALSE; -} - -BOOLEAN WINAPI ReadGlobalPwrPolicy(PGLOBAL_POWER_POLICY pGlobalPowerPolicy) -{ - /* FIXME: See note #1 */ - FIXME("(%p) stub!\n", pGlobalPowerPolicy); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI ReadProcessorPwrScheme(UINT uiID, - PMACHINE_PROCESSOR_POWER_POLICY pMachineProcessorPowerPolicy) -{ - /* FIXME: See note #1 */ - FIXME("(%d, %p) stub!\n", uiID, pMachineProcessorPowerPolicy); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI ReadPwrScheme(UINT uiID, - PPOWER_POLICY pPowerPolicy) -{ - /* FIXME: See note #1 */ - FIXME("(%d, %p) stub!\n", uiID, pPowerPolicy); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI SetActivePwrScheme(UINT uiID, - PGLOBAL_POWER_POLICY lpGlobalPowerPolicy, - PPOWER_POLICY lpPowerPolicy) -{ - /* FIXME: See note #1 */ - FIXME("(%d, %p, %p) stub!\n", uiID, lpGlobalPowerPolicy, lpPowerPolicy); - SetLastError(ERROR_FILE_NOT_FOUND); - return FALSE; -} - -BOOLEAN WINAPI SetSuspendState(BOOLEAN Hibernate, BOOLEAN ForceCritical, - BOOLEAN DisableWakeEvent) -{ - /* FIXME: I have NO idea how you're supposed to call NtInitiatePowerAction - * here, because it's not a documented function that I can find */ - FIXME("(%d, %d, %d) stub!\n", Hibernate, ForceCritical, DisableWakeEvent); - return TRUE; -} - -BOOLEAN WINAPI WriteGlobalPwrPolicy(PGLOBAL_POWER_POLICY pGlobalPowerPolicy) -{ - /* FIXME: See note #3 */ - FIXME("(%p) stub!\n", pGlobalPowerPolicy); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return FALSE; -} - -BOOLEAN WINAPI WriteProcessorPwrScheme(UINT ID, - PMACHINE_PROCESSOR_POWER_POLICY pMachineProcessorPowerPolicy) -{ - /* FIXME: See note #3 */ - FIXME("(%d, %p) stub!\n", ID, pMachineProcessorPowerPolicy); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return FALSE; -} - -BOOLEAN WINAPI WritePwrScheme(PUINT puiID, LPWSTR lpszName, LPWSTR lpszDescription, - PPOWER_POLICY pPowerPolicy) -{ - /* FIXME: See note #3 */ - FIXME("(%p, %s, %s, %p) stub!\n", puiID, debugstr_w(lpszName), debugstr_w(lpszDescription), pPowerPolicy); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return FALSE; -} - -BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) -{ - FIXME("(%p, %ld, %p) not fully implemented\n", hinstDLL, fdwReason, lpvReserved); - - switch(fdwReason) { - case DLL_PROCESS_ATTACH: { - - HKEY hKey; - LONG r; - - DisableThreadLibraryCalls(hinstDLL); - - r = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szPowerCfgSubKey, 0, KEY_READ | KEY_WRITE, &hKey); - - if (r != ERROR_SUCCESS) { - TRACE("Couldn't open registry key HKLM\\%s, using some sane(?) defaults\n", debugstr_w(szPowerCfgSubKey)); - } else { - BYTE lpValue[40]; - DWORD cbValue = sizeof(lpValue); - r = RegQueryValueExW(hKey, szLastID, 0, 0, lpValue, &cbValue); - if (r != ERROR_SUCCESS) { - TRACE("Couldn't open registry entry HKLM\\%s\\LastID, using some sane(?) defaults\n", debugstr_w(szPowerCfgSubKey)); - } - RegCloseKey(hKey); - } - - PPRegSemaphore = CreateSemaphoreW(NULL, 1, 1, szSemaphoreName); - if (PPRegSemaphore == NULL) { - ERR("Couldn't create Semaphore: %ld\n", GetLastError()); - return FALSE; - } - break; - } - case DLL_PROCESS_DETACH: - CloseHandle(PPRegSemaphore); - break; - } - return TRUE; -} +/* + * Copyright (C) 2005 Benjamin Cutler + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + + +#include <stdarg.h> + +#include "ntstatus.h" +#define WIN32_NO_STATUS +#include "windef.h" +#include "winbase.h" +#include "winnt.h" +#include "winreg.h" +#include "winternl.h" +#include "powrprof.h" +#include "wine/debug.h" +#include "wine/unicode.h" + +WINE_DEFAULT_DEBUG_CHANNEL(powrprof); + +/* Notes to implementors: + * #1: The native implementation of these functions attempted to read in + * registry entries that I was unable to locate on any of the Windows + * machines I checked, but I only had desktops available, so maybe + * laptop users will have better luck. They return FNF errors because + * that's what the native DLL was returning during my tests. + * #2: These functions call NtPowerInformation but I don't know what they + * do with the results, and NtPowerInformation doesn't do much in WINE yet + * anyway. + * #3: Since I can't get several other functions working (see note #1), + * implementing these functions is going to have to wait until somebody can + * cobble together some sane test input. */ + +static const WCHAR szPowerCfgSubKey[] = { 'S', 'o', 'f', 't', 'w', 'a', 'r', 'e', + '\\', 'M', 'i', 'c', 'r', 'o', 's', 'o', 'f', 't', '\\', 'W', 'i', + 'n', 'd', 'o', 'w', 's', '\\', 'C', 'u', 'r', 'r', 'e', 'n', 't', + 'V', 'e', 'r', 's', 'i', 'o', 'n', '\\', 'C', 'o', 'n', 't', 'r', + 'o', 'l', 's', ' ', 'F', 'o', 'l', 'd', 'e', 'r', '\\', 'P', 'o', + 'w', 'e', 'r', 'C', 'f', 'g', 0 }; +static const WCHAR szSemaphoreName[] = { 'P', 'o', 'w', 'e', 'r', 'P', 'r', 'o', + 'f', 'i', 'l', 'e', 'R', 'e', 'g', 'i', 's', 't', 'r', 'y', 'S', + 'e', 'm', 'a', 'p', 'h', 'o', 'r', 'e', 0 }; +static const WCHAR szDiskMax[] = { 'D', 'i', 's', 'k', 'S', 'p', 'i', 'n', 'd', + 'o', 'w', 'n', 'M', 'a', 'x', 0 }; +static const WCHAR szDiskMin[] = { 'D', 'i', 's', 'k', 'S', 'p', 'i', 'n', 'd', + 'o', 'w', 'n', 'M', 'i', 'n', 0 }; +static const WCHAR szLastID[] = { 'L', 'a', 's', 't', 'I', 'D', 0 }; +static HANDLE PPRegSemaphore = NULL; + +NTSTATUS WINAPI CallNtPowerInformation( + POWER_INFORMATION_LEVEL InformationLevel, + PVOID lpInputBuffer, ULONG nInputBufferSize, + PVOID lpOutputBuffer, ULONG nOutputBufferSize) +{ + return NtPowerInformation(InformationLevel, lpInputBuffer, + nInputBufferSize, lpOutputBuffer, nOutputBufferSize); +} + +BOOLEAN WINAPI CanUserWritePwrScheme(VOID) +{ + HKEY hKey = NULL; + LONG r; + BOOLEAN bSuccess = TRUE; + + TRACE("()\n"); + + r = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szPowerCfgSubKey, 0, KEY_READ | KEY_WRITE, &hKey); + + if (r != ERROR_SUCCESS) { + TRACE("RegOpenKeyEx failed: %ld\n", r); + bSuccess = FALSE; + } + + SetLastError(r); + RegCloseKey(hKey); + return bSuccess; +} + +BOOLEAN WINAPI DeletePwrScheme(UINT uiIndex) +{ + /* FIXME: See note #1 */ + FIXME("(%d) stub!\n", uiIndex); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI EnumPwrSchemes(PWRSCHEMESENUMPROC lpfnPwrSchemesEnumProc, + LPARAM lParam) +{ + /* FIXME: See note #1 */ + FIXME("(%p, %ld) stub!\n", lpfnPwrSchemesEnumProc, lParam); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI GetActivePwrScheme(PUINT puiID) +{ + /* FIXME: See note #1 */ + FIXME("(%p) stub!\n", puiID); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI GetCurrentPowerPolicies( + PGLOBAL_POWER_POLICY pGlobalPowerPolicy, + PPOWER_POLICY pPowerPolicy) +{ + /* FIXME: See note #2 */ + SYSTEM_POWER_POLICY ACPower, DCPower; + + FIXME("(%p, %p) stub!\n", pGlobalPowerPolicy, pPowerPolicy); + + NtPowerInformation(SystemPowerPolicyAc, 0, 0, &ACPower, sizeof(SYSTEM_POWER_POLICY)); + NtPowerInformation(SystemPowerPolicyDc, 0, 0, &DCPower, sizeof(SYSTEM_POWER_POLICY)); + + return FALSE; +} + +BOOLEAN WINAPI GetPwrCapabilities( + PSYSTEM_POWER_CAPABILITIES lpSystemPowerCapabilities) +{ + NTSTATUS r; + + TRACE("(%p)\n", lpSystemPowerCapabilities); + + r = NtPowerInformation(SystemPowerCapabilities, 0, 0, lpSystemPowerCapabilities, sizeof(SYSTEM_POWER_CAPABILITIES)); + + SetLastError(RtlNtStatusToDosError(r)); + + return r == STATUS_SUCCESS; +} + +BOOLEAN WINAPI GetPwrDiskSpindownRange(PUINT RangeMax, PUINT RangeMin) +{ + HKEY hKey; + BYTE lpValue[40]; + LONG r; + DWORD cbValue = sizeof(lpValue); + + TRACE("(%p, %p)\n", RangeMax, RangeMin); + + if (RangeMax == NULL || RangeMin == NULL) { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } + + SetLastError(ERROR_SUCCESS); + + WaitForSingleObject(PPRegSemaphore, INFINITE); + + r = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szPowerCfgSubKey, 0, KEY_READ, &hKey); + if (r != ERROR_SUCCESS) { + TRACE("RegOpenKeyEx failed: %ld\n", r); + TRACE("Using defaults: 3600, 3\n"); + *RangeMax = 3600; + *RangeMin = 3; + ReleaseSemaphore(PPRegSemaphore, 1, NULL); + return TRUE; + } + + r = RegQueryValueExW(hKey, szDiskMax, 0, 0, lpValue, &cbValue); + if (r != ERROR_SUCCESS) { + TRACE("Couldn't open DiskSpinDownMax: %ld\n", r); + TRACE("Using default: 3600\n"); + *RangeMax = 3600; + } else { + *RangeMax = atoiW((LPCWSTR)lpValue); + } + + cbValue = sizeof(lpValue); + + r = RegQueryValueExW(hKey, szDiskMin, 0, 0, lpValue, &cbValue); + if (r != ERROR_SUCCESS) { + TRACE("Couldn't open DiskSpinDownMin: %ld\n", r); + TRACE("Using default: 3\n"); + *RangeMin = 3; + } else { + *RangeMin = atoiW((LPCWSTR)lpValue); + } + + RegCloseKey(hKey); + + ReleaseSemaphore(PPRegSemaphore, 1, NULL); + + return TRUE; +} + +BOOLEAN WINAPI IsAdminOverrideActive(PADMINISTRATOR_POWER_POLICY p) +{ + FIXME("( %p) stub!\n", p); + return FALSE; +} + +BOOLEAN WINAPI IsPwrHibernateAllowed(VOID) +{ + /* FIXME: See note #2 */ + SYSTEM_POWER_CAPABILITIES PowerCaps; + FIXME("() stub!\n"); + NtPowerInformation(SystemPowerCapabilities, NULL, 0, &PowerCaps, sizeof(PowerCaps)); + return FALSE; +} + +BOOLEAN WINAPI IsPwrShutdownAllowed(VOID) +{ + /* FIXME: See note #2 */ + SYSTEM_POWER_CAPABILITIES PowerCaps; + FIXME("() stub!\n"); + NtPowerInformation(SystemPowerCapabilities, NULL, 0, &PowerCaps, sizeof(PowerCaps)); + return FALSE; +} + +BOOLEAN WINAPI IsPwrSuspendAllowed(VOID) +{ + /* FIXME: See note #2 */ + SYSTEM_POWER_CAPABILITIES PowerCaps; + FIXME("() stub!\n"); + NtPowerInformation(SystemPowerCapabilities, NULL, 0, &PowerCaps, sizeof(PowerCaps)); + return FALSE; +} + +BOOLEAN WINAPI ReadGlobalPwrPolicy(PGLOBAL_POWER_POLICY pGlobalPowerPolicy) +{ + /* FIXME: See note #1 */ + FIXME("(%p) stub!\n", pGlobalPowerPolicy); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI ReadProcessorPwrScheme(UINT uiID, + PMACHINE_PROCESSOR_POWER_POLICY pMachineProcessorPowerPolicy) +{ + /* FIXME: See note #1 */ + FIXME("(%d, %p) stub!\n", uiID, pMachineProcessorPowerPolicy); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI ReadPwrScheme(UINT uiID, + PPOWER_POLICY pPowerPolicy) +{ + /* FIXME: See note #1 */ + FIXME("(%d, %p) stub!\n", uiID, pPowerPolicy); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI SetActivePwrScheme(UINT uiID, + PGLOBAL_POWER_POLICY lpGlobalPowerPolicy, + PPOWER_POLICY lpPowerPolicy) +{ + /* FIXME: See note #1 */ + FIXME("(%d, %p, %p) stub!\n", uiID, lpGlobalPowerPolicy, lpPowerPolicy); + SetLastError(ERROR_FILE_NOT_FOUND); + return FALSE; +} + +BOOLEAN WINAPI SetSuspendState(BOOLEAN Hibernate, BOOLEAN ForceCritical, + BOOLEAN DisableWakeEvent) +{ + /* FIXME: I have NO idea how you're supposed to call NtInitiatePowerAction + * here, because it's not a documented function that I can find */ + FIXME("(%d, %d, %d) stub!\n", Hibernate, ForceCritical, DisableWakeEvent); + return TRUE; +} + +BOOLEAN WINAPI WriteGlobalPwrPolicy(PGLOBAL_POWER_POLICY pGlobalPowerPolicy) +{ + /* FIXME: See note #3 */ + FIXME("(%p) stub!\n", pGlobalPowerPolicy); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; +} + +BOOLEAN WINAPI WriteProcessorPwrScheme(UINT ID, + PMACHINE_PROCESSOR_POWER_POLICY pMachineProcessorPowerPolicy) +{ + /* FIXME: See note #3 */ + FIXME("(%d, %p) stub!\n", ID, pMachineProcessorPowerPolicy); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; +} + +BOOLEAN WINAPI WritePwrScheme(PUINT puiID, LPWSTR lpszName, LPWSTR lpszDescription, + PPOWER_POLICY pPowerPolicy) +{ + /* FIXME: See note #3 */ + FIXME("(%p, %s, %s, %p) stub!\n", puiID, debugstr_w(lpszName), debugstr_w(lpszDescription), pPowerPolicy); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; +} + +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) +{ + FIXME("(%p, %ld, %p) not fully implemented\n", hinstDLL, fdwReason, lpvReserved); + + switch(fdwReason) { + case DLL_PROCESS_ATTACH: { + + HKEY hKey; + LONG r; + + DisableThreadLibraryCalls(hinstDLL); + + r = RegOpenKeyExW(HKEY_LOCAL_MACHINE, szPowerCfgSubKey, 0, KEY_READ | KEY_WRITE, &hKey); + + if (r != ERROR_SUCCESS) { + TRACE("Couldn't open registry key HKLM\\%s, using some sane(?) defaults\n", debugstr_w(szPowerCfgSubKey)); + } else { + BYTE lpValue[40]; + DWORD cbValue = sizeof(lpValue); + r = RegQueryValueExW(hKey, szLastID, 0, 0, lpValue, &cbValue); + if (r != ERROR_SUCCESS) { + TRACE("Couldn't open registry entry HKLM\\%s\\LastID, using some sane(?) defaults\n", debugstr_w(szPowerCfgSubKey)); + } + RegCloseKey(hKey); + } + + PPRegSemaphore = CreateSemaphoreW(NULL, 1, 1, szSemaphoreName); + if (PPRegSemaphore == NULL) { + ERR("Couldn't create Semaphore: %ld\n", GetLastError()); + return FALSE; + } + break; + } + case DLL_PROCESS_DETACH: + CloseHandle(PPRegSemaphore); + break; + } + return TRUE; +} Propchange: trunk/reactos/dll/win32/powrprof/powrprof.c ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/dll/win32/powrprof/powrprof.rbuild URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/powrprof/powrprof… ============================================================================== --- trunk/reactos/dll/win32/powrprof/powrprof.rbuild (added) +++ trunk/reactos/dll/win32/powrprof/powrprof.rbuild Wed Jun 7 03:14:09 2006 @@ -1,0 +1,19 @@ +<module name="powrprof" type="win32dll" baseaddress="${BASEADDRESS_POWRPROF}" installbase="system32" installname="powrprof.dll" allowwarnings="true"> + <importlibrary definition="powrprof_gcc.def" /> + <include base="ReactOS">include/wine</include> + <define name="_DISABLE_TIDENTS" /> + <define name="__REACTOS__" /> + <define name="__USE_W32API" /> + <define name="UNICODE" /> + <define name="_UNICODE" /> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x501</define> + <define name="WINVER">0x501</define> + <library>wine</library> + <library>ntdll</library> + <library>rtl</library> + <library>kernel32</library> + <library>ntoskrnl</library> + <file>powrprof.c</file> + <file>powrprof.rc</file> +</module> Propchange: trunk/reactos/dll/win32/powrprof/powrprof.rbuild ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/dll/win32/powrprof/powrprof.rc URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/powrprof/powrprof… ============================================================================== --- trunk/reactos/dll/win32/powrprof/powrprof.rc (added) +++ trunk/reactos/dll/win32/powrprof/powrprof.rc Wed Jun 7 03:14:09 2006 @@ -1,0 +1,10 @@ +/* $Id: version.rc 12852 2005-01-06 13:58:04Z mf $ */ + +#include "powrprof.h" +//#include "misc.h" +//#include "type.h" +#define REACTOS_VERSION_DLL +#define REACTOS_STR_FILE_DESCRIPTION "Power Profile Helper DLL\0" +#define REACTOS_STR_INTERNAL_NAME "powerprof\0" +#define REACTOS_STR_ORIGINAL_FILENAME "powerprof.dll\0" +#include <reactos/version.rc> Propchange: trunk/reactos/dll/win32/powrprof/powrprof.rc ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/dll/win32/powrprof/powrprof_gcc.def URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/powrprof/powrprof… ============================================================================== --- trunk/reactos/dll/win32/powrprof/powrprof_gcc.def (added) +++ trunk/reactos/dll/win32/powrprof/powrprof_gcc.def Wed Jun 7 03:14:09 2006 @@ -1,0 +1,36 @@ + +; $Id: version.def 12852 2005-01-06 13:58:04Z mf $ +; ReactOS Operating System +; +LIBRARY powrprof.dll +EXPORTS +CallNtPowerInformation@20 +;NtPowerInformation@20=ntokrnl._NtPowerInformation@20 +CanUserWritePwrScheme@0 +;DebugPrintA +;DllInitialize +DeletePwrScheme@4 +;DevicePowerClose +;DevicePowerEnumDevices +;DevicePowerOpen +;DevicePowerSetDeviceState +EnumPwrSchemes@8 +GetActivePwrScheme@4 +GetCurrentPowerPolicies@8 +GetPwrCapabilities@4 +GetPwrDiskSpindownRange@8 +IsAdminOverrideActive@4 +IsPwrHibernateAllowed@0 +IsPwrShutdownAllowed@0 +IsPwrSuspendAllowed@0 +;LoadCurrentPwrScheme +;MergeLegacyPwrScheme +ReadGlobalPwrPolicy@4 +ReadProcessorPwrScheme@8 +ReadPwrScheme@8 +SetActivePwrScheme@12 +SetSuspendState@12 +;ValidatePowerPolicies@8 +WriteGlobalPwrPolicy@4 +WriteProcessorPwrScheme@8 +WritePwrScheme@16 Propchange: trunk/reactos/dll/win32/powrprof/powrprof_gcc.def ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/dll/win32/win32.rbuild URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/win32.rbuild?rev=… ============================================================================== --- trunk/reactos/dll/win32/win32.rbuild (original) +++ trunk/reactos/dll/win32/win32.rbuild Wed Jun 7 03:14:09 2006 @@ -160,6 +160,9 @@ <directory name="opengl32"> <xi:include href="opengl32/opengl32.rbuild" /> </directory> +<directory name="powrprof"> + <xi:include href="powrprof/powrprof.rbuild" /> +</directory> <directory name="psapi"> <xi:include href="psapi/psapi.rbuild" /> </directory> Modified: trunk/reactos/media/doc/README.WINE URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=2… ============================================================================== --- trunk/reactos/media/doc/README.WINE (original) +++ trunk/reactos/media/doc/README.WINE Wed Jun 7 03:14:09 2006 @@ -62,6 +62,7 @@ reactos/dll/win32/oleaut32 # Synced to Wine-0_9_10 reactos/dll/win32/oledlg # Synced to Wine-0_9_5 reactos/dll/win32/olepro32 # Synced to Wine-0_9_10 +reactos/dll/win32/powrprof # Synced to Wine-0_9_14 reactos/dll/win32/riched20 # Synced to Wine-0_9_5 reactos/dll/win32/richedit # Synced to Wine-0_9_10 reactos/dll/win32/rpcrt4 # Synced to Wine-0_9_10

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs