Ros-diffs

ros-diffs@reactos.org

81390 discussions

[hpoussin] 22156: Fix calculation of loss percentage
by hpoussin＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: hpoussin Date: Thu Jun 1 22:27:08 2006 New Revision: 22156 URL: http://svn.reactos.ru/svn/reactos?rev=22156&view=rev Log: Fix calculation of loss percentage Modified: trunk/reactos/base/applications/network/ping/ping.c Modified: trunk/reactos/base/applications/network/ping/ping.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/network/p… ============================================================================== --- trunk/reactos/base/applications/network/ping/ping.c (original) +++ trunk/reactos/base/applications/network/ping/ping.c Thu Jun 1 22:27:08 2006 @@ -606,11 +606,7 @@ } /* Calculate loss percent */ - if (LostCount > 0) { - Count = (SentCount * 100) / LostCount; - } else { - Count = 0; - } + Count = (LostCount * 100) / SentCount; if (!MinRTTSet) MinRTT = MaxRTT;

1 0

[greatlrd] 22155: fix so fread return right value of bytes/chars it reads make one more wine test pass in msvcrt file
by greatlrd＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: greatlrd Date: Thu Jun 1 22:20:34 2006 New Revision: 22155 URL: http://svn.reactos.ru/svn/reactos?rev=22155&view=rev Log: fix so fread return right value of bytes/chars it reads make one more wine test pass in msvcrt file Modified: trunk/reactos/lib/crt/stdio/fread.c Modified: trunk/reactos/lib/crt/stdio/fread.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/lib/crt/stdio/fread.c?rev=2… ============================================================================== --- trunk/reactos/lib/crt/stdio/fread.c (original) +++ trunk/reactos/lib/crt/stdio/fread.c Thu Jun 1 22:20:34 2006 @@ -81,5 +81,8 @@ } } } - return count - (to_read/size); + // return count - (to_read/size) + /* FIXME is this formual right ?, I copy the formula from djgpp + in our to_read or copy ? */ + return size != 0 ? count - ((to_read + size - 1) / size) : 0; }

1 0

[cwittich] 22154: -don't update the time in the DTP control when the user is about to change it
by cwittich＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: cwittich Date: Thu Jun 1 22:06:25 2006 New Revision: 22154 URL: http://svn.reactos.ru/svn/reactos?rev=22154&view=rev Log: -don't update the time in the DTP control when the user is about to change it Modified: trunk/reactos/dll/cpl/timedate/timedate.c Modified: trunk/reactos/dll/cpl/timedate/timedate.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/cpl/timedate/timedate.c… ============================================================================== --- trunk/reactos/dll/cpl/timedate/timedate.c (original) +++ trunk/reactos/dll/cpl/timedate/timedate.c Thu Jun 1 22:06:25 2006 @@ -52,6 +52,7 @@ static HBITMAP hBitmap = NULL; static int cxSource, cySource; +static WNDPROC pOldWndProc = NULL; /* Applets */ APPLET Applets[NUM_APPLETS] = @@ -289,6 +290,25 @@ } +INT_PTR CALLBACK +DTPProc(HWND hwnd, + UINT uMsg, + WPARAM wParam, + LPARAM lParam) +{ + switch (uMsg) + { + case WM_KEYDOWN: + /* stop the timer when the user is about to change the time */ + if ((wParam != VK_LEFT) & (wParam != VK_RIGHT)) + KillTimer(GetParent(hwnd), ID_TIMER); + return CallWindowProc(pOldWndProc, hwnd, uMsg, wParam, lParam); + break; + default: + return CallWindowProc(pOldWndProc, hwnd, uMsg, wParam, lParam); + } +} + /* Property page dialog callback */ INT_PTR CALLBACK DateTimePageProc(HWND hwndDlg, @@ -321,6 +341,8 @@ NULL, hApplet, NULL); + + pOldWndProc = (WNDPROC) SetWindowLong(GetDlgItem(hwndDlg, IDC_TIMEPICKER), GWL_WNDPROC, (INT_PTR) DTPProc); break; case WM_TIMER:

1 0

[greatlrd] 22153: [AUDIT] this code is clear, if u look at djgpp fread u will see it base directly of it same struct and line out.
by greatlrd＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: greatlrd Date: Thu Jun 1 21:42:00 2006 New Revision: 22153 URL: http://svn.reactos.ru/svn/reactos?rev=22153&view=rev Log: [AUDIT] this code is clear, if u look at djgpp fread u will see it base directly of it same struct and line out. Modified: trunk/reactos/lib/crt/stdio/fread.c (props changed) Propchange: trunk/reactos/lib/crt/stdio/fread.c ------------------------------------------------------------------------------ --- svn:needs-lock (original) +++ svn:needs-lock (removed) @@ -1,1 +1,0 @@ -*

1 0

[gedmurphy] 22152: add a really dodgy delete button. I'll replace all these buttons in due course.
by gedmurphy＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: gedmurphy Date: Thu Jun 1 21:29:05 2006 New Revision: 22152 URL: http://svn.reactos.ru/svn/reactos?rev=22152&view=rev Log: add a really dodgy delete button. I'll replace all these buttons in due course. Modified: trunk/reactos/base/applications/servman/res/toolbar.bmp Modified: trunk/reactos/base/applications/servman/res/toolbar.bmp URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/r… ============================================================================== Binary files - no diff available.

1 0

[cwittich] 22151: -forgot to add world.bmp
by cwittich＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: cwittich Date: Thu Jun 1 21:26:49 2006 New Revision: 22151 URL: http://svn.reactos.ru/svn/reactos?rev=22151&view=rev Log: -forgot to add world.bmp Added: trunk/reactos/dll/cpl/timedate/resources/world.bmp (with props) Added: trunk/reactos/dll/cpl/timedate/resources/world.bmp URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/cpl/timedate/resources/… ============================================================================== Binary file - no diff available. Propchange: trunk/reactos/dll/cpl/timedate/resources/world.bmp ------------------------------------------------------------------------------ svn:mime-type = application/octet-stream

1 0

[hpoussin] 22150: If the section name contained a dot, sometimes the right section to install was not found
by hpoussin＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: hpoussin Date: Thu Jun 1 21:08:28 2006 New Revision: 22150 URL: http://svn.reactos.ru/svn/reactos?rev=22150&view=rev Log: If the section name contained a dot, sometimes the right section to install was not found Modified: trunk/reactos/dll/win32/setupapi/devinst.c Modified: trunk/reactos/dll/win32/setupapi/devinst.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/setupapi/devinst.… ============================================================================== --- trunk/reactos/dll/win32/setupapi/devinst.c (original) +++ trunk/reactos/dll/win32/setupapi/devinst.c Thu Jun 1 21:08:28 2006 @@ -93,6 +93,7 @@ PSP_ALTPLATFORM_INFO PlatformInfo; BYTE ProductType; WORD SuiteMask; + DWORD PrefixLength; WCHAR BestSection[LINE_LEN + 1]; DWORD BestScore1, BestScore2, BestScore3, BestScore4, BestScore5; }; @@ -1052,7 +1053,7 @@ * Field[5] Suite mask * Remark: lastests fields may be NULL if the information is not provided */ - Fields[0] = strchrW(Section, '.'); + Fields[0] = Section; if (Fields[0] == NULL) { TRACE("No extension found\n"); @@ -1209,8 +1210,11 @@ DWORD Score1, Score2, Score3, Score4, Score5; BOOL ret; + if (SectionName[info->PrefixLength] != '.') + return TRUE; + ret = CheckSectionValid( - SectionName, + &SectionName[info->PrefixLength], info->PlatformInfo, info->ProductType, info->SuiteMask, @@ -1318,6 +1322,7 @@ CallbackInfo.PlatformInfo = pPlatformInfo; CallbackInfo.ProductType = ProductType; CallbackInfo.SuiteMask = SuiteMask; + CallbackInfo.PrefixLength = strlenW(InfSectionName); CallbackInfo.BestScore1 = ULONG_MAX; CallbackInfo.BestScore2 = ULONG_MAX; CallbackInfo.BestScore3 = ULONG_MAX; @@ -7629,7 +7634,7 @@ ret = SetupDiGetActualSectionToInstallW( SelectedDriver->InfFileDetails->hInf, SelectedDriver->Details.SectionName, - SectionName, MAX_PATH - strlenW(DotCoInstallers), &SectionNameLength, NULL); + SectionName, MAX_PATH, &SectionNameLength, NULL); if (!ret) goto done; @@ -7946,7 +7951,6 @@ strcatW(Windir, BackSlash); strcatW(Windir, InfDirectory); - DPRINT1("Comparing %S and %S\n", FullName, Windir); if (strncmpiW(FullName, Windir, last - FullName) == 0) { /* The path is %SYSTEMROOT%\Inf */

1 0

[gedmurphy] 22149: hmm, tortoise is messing me about ; )
by gedmurphy＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: gedmurphy Date: Thu Jun 1 20:47:11 2006 New Revision: 22149 URL: http://svn.reactos.ru/svn/reactos?rev=22149&view=rev Log: hmm, tortoise is messing me about ;) Modified: trunk/reactos/base/applications/servman/En.rc Modified: trunk/reactos/base/applications/servman/En.rc URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/E… ============================================================================== --- trunk/reactos/base/applications/servman/En.rc (original) +++ trunk/reactos/base/applications/servman/En.rc Thu Jun 1 20:47:11 2006 @@ -79,7 +79,7 @@ EDITTEXT IDC_DISP_NAME, 70, 29, 176, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP | ES_READONLY EDITTEXT IDC_DESCRIPTION, 70, 46, 176, 24, WS_CHILD | WS_VISIBLE | WS_VSCROLL | WS_TABSTOP | ES_MULTILINE | ES_READONLY EDITTEXT IDC_EXEPATH, 6, 86, 240, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP | ES_READONLY - CONTROL "",IDC_START_TYPE,"ComboBox",0x50010003,70,107,176,40 + CONTROL "", IDC_START_TYPE, "ComboBox", WS_CHILD | WS_VISIBLE | WS_TABSTOP | CBS_DROPDOWNLIST, 70, 107, 176, 40 PUSHBUTTON "Start", IDC_START, 6, 155, 54, 15, WS_DISABLED PUSHBUTTON "Stop", IDC_STOP, 68, 155, 54, 15, WS_DISABLED PUSHBUTTON "Pause", IDC_PAUSE , 130, 155, 54, 15, WS_DISABLED @@ -90,7 +90,7 @@ LTEXT "Path to executable:", IDC_STATIC, 6, 73, 82, 9 LTEXT "Startup type:", IDC_STATIC, 6, 108, 53, 11 LTEXT "Service status:", IDC_STATIC, 4, 138, 53, 11 - CONTROL "",IDC_SERV_STATUS,"Static",0x50000000,70,138,176,11 + LTEXT "", IDC_SERV_STATUS, 70, 138, 176, 11, WS_CHILD | WS_VISIBLE LTEXT "You can specify the start parameters that apply when you start the service from here.",IDC_STATIC, 6,177,240,15 LTEXT "Start parameters:", IDC_STATIC, 6, 200, 58, 11 EDITTEXT IDC_START_PARAM, 68, 199, 178, 13, WS_CHILD | WS_VISIBLE | WS_TABSTOP @@ -164,8 +164,6 @@ END -IDB_BUTTONS BITMAP DISCARDABLE "res/toolbar.bmp" - STRINGTABLE DISCARDABLE BEGIN @@ -196,11 +194,12 @@ IDS_TOOLTIP_PROP "Properties" IDS_TOOLTIP_REFRESH "Refresh" IDS_TOOLTIP_EXPORT "Export list" + IDS_TOOLTIP_CREATE "Create a new service" + IDS_TOOLTIP_DELETE "Deletes an existing service" IDS_TOOLTIP_START "Start service" IDS_TOOLTIP_STOP "Stop service" IDS_TOOLTIP_PAUSE "Pause service" IDS_TOOLTIP_RESTART "Restart service" - IDS_TOOLTIP_NEW "Create a new service" IDS_TOOLTIP_HELP "Help" IDS_TOOLTIP_EXIT "Exit" END

1 0

[gedmurphy] 22148: - Start a complete overhaul of servman, using abstraction instead of the old messy way. - Far to many changes to list, so I'm not even gonna even try ; )
by gedmurphy＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: gedmurphy Date: Thu Jun 1 20:42:08 2006 New Revision: 22148 URL: http://svn.reactos.ru/svn/reactos?rev=22148&view=rev Log: - Start a complete overhaul of servman, using abstraction instead of the old messy way. - Far to many changes to list, so I'm not even gonna even try ;) Added: trunk/reactos/base/applications/servman/mainwnd.c trunk/reactos/base/applications/servman/misc.c trunk/reactos/base/applications/servman/precomp.h trunk/reactos/base/applications/servman/stop.c Removed: trunk/reactos/base/applications/servman/geterror.c trunk/reactos/base/applications/servman/servman.h Modified: trunk/reactos/base/applications/servman/about.c trunk/reactos/base/applications/servman/control.c trunk/reactos/base/applications/servman/create.c trunk/reactos/base/applications/servman/delete.c trunk/reactos/base/applications/servman/export.c trunk/reactos/base/applications/servman/progress.c trunk/reactos/base/applications/servman/propsheet.c trunk/reactos/base/applications/servman/query.c trunk/reactos/base/applications/servman/resource.h trunk/reactos/base/applications/servman/servman.c trunk/reactos/base/applications/servman/servman.rbuild trunk/reactos/base/applications/servman/servman.rc trunk/reactos/base/applications/servman/start.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/applications/servman/about.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/a… Modified: trunk/reactos/base/applications/servman/control.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/c… Modified: trunk/reactos/base/applications/servman/create.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/c… Modified: trunk/reactos/base/applications/servman/delete.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/d… Modified: trunk/reactos/base/applications/servman/export.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/e… Removed: trunk/reactos/base/applications/servman/geterror.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/g… Added: trunk/reactos/base/applications/servman/mainwnd.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/m… Added: trunk/reactos/base/applications/servman/misc.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/m… Added: trunk/reactos/base/applications/servman/precomp.h URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/p… Modified: trunk/reactos/base/applications/servman/progress.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/p… Modified: trunk/reactos/base/applications/servman/propsheet.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/p… Modified: trunk/reactos/base/applications/servman/query.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/q… Modified: trunk/reactos/base/applications/servman/resource.h URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/r… Modified: trunk/reactos/base/applications/servman/servman.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/s… Removed: trunk/reactos/base/applications/servman/servman.h URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/s… Modified: trunk/reactos/base/applications/servman/servman.rbuild URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/s… Modified: trunk/reactos/base/applications/servman/servman.rc URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/s… Modified: trunk/reactos/base/applications/servman/start.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/s… Added: trunk/reactos/base/applications/servman/stop.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/base/applications/servman/s…

1 0

[cwittich] 22147: -forgot to check lpDrawItem->CtlID
by cwittich＠svn.reactos.org 01 Jun '06

01 Jun '06

Author: cwittich Date: Thu Jun 1 20:34:53 2006 New Revision: 22147 URL: http://svn.reactos.ru/svn/reactos?rev=22147&view=rev Log: -forgot to check lpDrawItem->CtlID Modified: trunk/reactos/dll/cpl/timedate/timedate.c Modified: trunk/reactos/dll/cpl/timedate/timedate.c URL: http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/cpl/timedate/timedate.c… ============================================================================== --- trunk/reactos/dll/cpl/timedate/timedate.c (original) +++ trunk/reactos/dll/cpl/timedate/timedate.c Thu Jun 1 20:34:53 2006 @@ -809,18 +809,21 @@ case WM_DRAWITEM: { LPDRAWITEMSTRUCT lpDrawItem; - PAINTSTRUCT ps; - HDC hdc, hdcMem; lpDrawItem = (LPDRAWITEMSTRUCT) lParam; - hdc = BeginPaint(hwndDlg, &ps); - hdcMem = CreateCompatibleDC(hdc); - SelectObject(hdcMem, hBitmap); - StretchBlt(lpDrawItem->hDC, lpDrawItem->rcItem.left, lpDrawItem->rcItem.top, - lpDrawItem->rcItem.right - lpDrawItem->rcItem.left, - lpDrawItem->rcItem.bottom - lpDrawItem->rcItem.top, - hdcMem, 0, 0, cxSource, cySource, SRCCOPY); - DeleteDC(hdcMem); - EndPaint(hwndDlg, &ps); + if(lpDrawItem->CtlID == IDC_WORLD_BACKGROUND) + { + PAINTSTRUCT ps; + HDC hdc, hdcMem; + hdc = BeginPaint(hwndDlg, &ps); + hdcMem = CreateCompatibleDC(hdc); + SelectObject(hdcMem, hBitmap); + StretchBlt(lpDrawItem->hDC, lpDrawItem->rcItem.left, lpDrawItem->rcItem.top, + lpDrawItem->rcItem.right - lpDrawItem->rcItem.left, + lpDrawItem->rcItem.bottom - lpDrawItem->rcItem.top, + hdcMem, 0, 0, cxSource, cySource, SRCCOPY); + DeleteDC(hdcMem); + EndPaint(hwndDlg, &ps); + } break; } case WM_COMMAND:

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs