Ros-diffs

ros-diffs@reactos.org

81390 discussions

[ekohl] 19066: Add Tonga timezone (GMT+13:00).
by ekohl＠svn.reactos.com 08 Nov '05

08 Nov '05

Add Tonga timezone (GMT+13:00). Modified: trunk/reactos/bootdata/hivesft.inf _____ Modified: trunk/reactos/bootdata/hivesft.inf --- trunk/reactos/bootdata/hivesft.inf 2005-11-08 20:53:53 UTC (rev 19065) +++ trunk/reactos/bootdata/hivesft.inf 2005-11-08 20:57:31 UTC (rev 19066) @@ -724,6 +724,14 @@ 0x00,0x00,0x03,0x00,0x00,0x00,0x03,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x 00,0x00,\ 0x00,0x00,0x0a,0x00,0x00,0x00,0x01,0x00,0x02,0x00,0x00,0x00,0x00,0x00,0x 00,0x00 +HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Display",0x00000000,"(GMT+13:00) Nuku` alofa" +HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Dlt",0x00000000,"Tonga Daylight Time" +HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Std",0x00000000,"Tonga Standard Time" +HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","Index",0x00010001,300 +HKLM,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Time Zones\Tonga Standard Time","TZI",0x00000001,\ +0xf4,0xfc,0xff,0xff,0x00,0x00,0x00,0x00,0xc4,0xff,0xff,0xff,\ +0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0 x00,0x00,\ +0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0 x00,0x00 ;HKLM,"SOFTWARE\ReactOS\Windows NT\CurrentVersion\Winlogon","Shell",0x00020000,"%SystemRoot%\system32\cm d.exe" HKLM,"SOFTWARE\ReactOS\Windows NT\CurrentVersion\Winlogon","Shell",0x00020000,"%SystemRoot%\explorer.ex e"

1 0

[ion] 19065: - Add some definitions to NDK
by ion＠svn.reactos.com 08 Nov '05

08 Nov '05

- Add some definitions to NDK - Prettify/document CreatePipe and correct some mistakes, use 120 second timeout like on NT and send FILE_PIPE flags instead of weird BOOLEAN values from hell. Modified: trunk/reactos/include/ndk/iotypes.h Modified: trunk/reactos/include/ndk/rtlfuncs.h Modified: trunk/reactos/lib/kernel32/file/pipe.c _____ Modified: trunk/reactos/include/ndk/iotypes.h --- trunk/reactos/include/ndk/iotypes.h 2005-11-08 20:50:04 UTC (rev 19064) +++ trunk/reactos/include/ndk/iotypes.h 2005-11-08 20:53:53 UTC (rev 19065) @@ -37,6 +37,7 @@ #define FILE_DOES_NOT_EXIST 0x00000005 /* Pipe Flags */ +#define FILE_PIPE_BYTE_STREAM_TYPE 0x00000000 #define FILE_PIPE_BYTE_STREAM_MODE 0x00000000 #define FILE_PIPE_MESSAGE_MODE 0x00000001 #define FILE_PIPE_QUEUE_OPERATION 0x00000000 _____ Modified: trunk/reactos/include/ndk/rtlfuncs.h --- trunk/reactos/include/ndk/rtlfuncs.h 2005-11-08 20:50:04 UTC (rev 19064) +++ trunk/reactos/include/ndk/rtlfuncs.h 2005-11-08 20:53:53 UTC (rev 19065) @@ -1184,6 +1184,15 @@ NTSYSAPI BOOLEAN NTAPI +RtlPrefixString( + PCANSI_STRING String1, + PCANSI_STRING String2, + BOOLEAN CaseInsensitive +); + +NTSYSAPI +BOOLEAN +NTAPI RtlPrefixUnicodeString( PCUNICODE_STRING String1, PCUNICODE_STRING String2, _____ Modified: trunk/reactos/lib/kernel32/file/pipe.c --- trunk/reactos/lib/kernel32/file/pipe.c 2005-11-08 20:50:04 UTC (rev 19064) +++ trunk/reactos/lib/kernel32/file/pipe.c 2005-11-08 20:53:53 UTC (rev 19065) @@ -17,95 +17,109 @@ /* GLOBALS ******************************************************************/ -ULONG ProcessPipeId = 0; +LONG ProcessPipeId = 0; /* FUNCTIONS ****************************************************************/ /* * @implemented */ -BOOL STDCALL CreatePipe(PHANDLE hReadPipe, - PHANDLE hWritePipe, - LPSECURITY_ATTRIBUTES lpPipeAttributes, - DWORD nSize) +BOOL +STDCALL +CreatePipe(PHANDLE hReadPipe, + PHANDLE hWritePipe, + LPSECURITY_ATTRIBUTES lpPipeAttributes, + DWORD nSize) { - WCHAR Buffer[64]; - UNICODE_STRING PipeName; - OBJECT_ATTRIBUTES ObjectAttributes; - IO_STATUS_BLOCK StatusBlock; - LARGE_INTEGER DefaultTimeout; - NTSTATUS Status; - HANDLE ReadPipeHandle; - HANDLE WritePipeHandle; - ULONG PipeId; - ULONG Attributes; - PSECURITY_DESCRIPTOR SecurityDescriptor = NULL; + WCHAR Buffer[64]; + UNICODE_STRING PipeName; + OBJECT_ATTRIBUTES ObjectAttributes; + IO_STATUS_BLOCK StatusBlock; + LARGE_INTEGER DefaultTimeout; + NTSTATUS Status; + HANDLE ReadPipeHandle; + HANDLE WritePipeHandle; + LONG PipeId; + ULONG Attributes; + PSECURITY_DESCRIPTOR SecurityDescriptor = NULL; - DefaultTimeout.QuadPart = -300000000; /* 30 seconds */ + /* Set the timeout to 120 seconds */ + DefaultTimeout.QuadPart = -1200000000; - PipeId = (ULONG)InterlockedIncrement((LONG*)&ProcessPipeId); - swprintf(Buffer, - L"\\\\.\\PIPE\\Win32Pipes.%08x.%08x", - NtCurrentTeb()->Cid.UniqueProcess, - PipeId); - RtlInitUnicodeString (&PipeName, - Buffer); + /* Use default buffer size if desired */ + if (!nSize) nSize = 0x1000; - Attributes = OBJ_CASE_INSENSITIVE; - if (lpPipeAttributes) - { - SecurityDescriptor = lpPipeAttributes->lpSecurityDescriptor; - if (lpPipeAttributes->bInheritHandle) - Attributes |= OBJ_INHERIT; - } + /* Increase the Pipe ID */ + PipeId = InterlockedIncrement(&ProcessPipeId); - /* use default buffer size if desired */ - if (nSize == 0) - nSize = 0x1000; + /* Create the pipe name */ + swprintf(Buffer, + L"\\\\.\\PIPE\\Win32Pipes.%08x.%08x", + NtCurrentTeb()->Cid.UniqueProcess, + PipeId); + RtlInitUnicodeString(&PipeName, Buffer); - InitializeObjectAttributes(&ObjectAttributes, - &PipeName, - Attributes, - NULL, - SecurityDescriptor); + /* Always use case insensitive */ + Attributes = OBJ_CASE_INSENSITIVE; - Status = NtCreateNamedPipeFile(&ReadPipeHandle, - FILE_GENERIC_READ |FILE_WRITE_ATTRIBUTES | SYNCHRONIZE, - &ObjectAttributes, - &StatusBlock, - FILE_SHARE_WRITE, - FILE_CREATE, - FILE_SYNCHRONOUS_IO_NONALERT, - FALSE, - FALSE, - FALSE, - 1, - nSize, - nSize, - &DefaultTimeout); - if (!NT_SUCCESS(Status)) - { - SetLastErrorByStatus(Status); - return FALSE; - } + /* Check if we got attributes */ + if (lpPipeAttributes) + { + /* Use the attributes' SD instead */ + SecurityDescriptor = lpPipeAttributes->lpSecurityDescriptor; - Status = NtOpenFile(&WritePipeHandle, - FILE_GENERIC_WRITE | SYNCHRONIZE, - &ObjectAttributes, - &StatusBlock, - FILE_SHARE_READ, - FILE_SYNCHRONOUS_IO_NONALERT); - if (!NT_SUCCESS(Status)) - { - NtClose(ReadPipeHandle); - SetLastErrorByStatus(Status); - return FALSE; - } + /* Set OBJ_INHERIT if requested */ + if (lpPipeAttributes->bInheritHandle) Attributes |= OBJ_INHERIT; + } - *hReadPipe = ReadPipeHandle; - *hWritePipe = WritePipeHandle; + /* Initialize the attributes */ + InitializeObjectAttributes(&ObjectAttributes, + &PipeName, + Attributes, + NULL, + SecurityDescriptor); - return TRUE; + /* Create the named pipe */ + Status = NtCreateNamedPipeFile(&ReadPipeHandle, + FILE_GENERIC_READ |FILE_WRITE_ATTRIBUTES | SYNCHRONIZE, + &ObjectAttributes, + &StatusBlock, + FILE_SHARE_WRITE, + FILE_CREATE, + FILE_SYNCHRONOUS_IO_NONALERT, + FILE_PIPE_BYTE_STREAM_TYPE, + FILE_PIPE_BYTE_STREAM_MODE, + FILE_PIPE_BYTE_STREAM_MODE, + 1, + nSize, + nSize, + &DefaultTimeout); + if (!NT_SUCCESS(Status)) + { + /* Convert error and fail */ + SetLastErrorByStatus(Status); + return FALSE; + } + + /* Now try opening it for write access */ + Status = NtOpenFile(&WritePipeHandle, + FILE_GENERIC_WRITE | SYNCHRONIZE, + &ObjectAttributes, + &StatusBlock, + FILE_SHARE_READ, + FILE_SYNCHRONOUS_IO_NONALERT | FILE_NON_DIRECTORY_FILE); + if (!NT_SUCCESS(Status)) + { + /* Convert error and fail */ + NtClose(ReadPipeHandle); + SetLastErrorByStatus(Status); + return FALSE; + } + + /* Return both handles */ + *hReadPipe = ReadPipeHandle; + *hWritePipe = WritePipeHandle; + return TRUE; } /* EOF */

1 0

[ion] 19064: - Remove silly debug print
by ion＠svn.reactos.com 08 Nov '05

08 Nov '05

- Remove silly debug print Modified: trunk/reactos/ntoskrnl/ob/security.c _____ Modified: trunk/reactos/ntoskrnl/ob/security.c --- trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 20:07:41 UTC (rev 19063) +++ trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 20:50:04 UTC (rev 19064) @@ -264,7 +264,7 @@ { /* HACK: Return the same descriptor back */ PSECURITY_DESCRIPTOR SdCopy; - DPRINT1("ObLogSecurityDescriptor is not implemented! %lx\n", InputSecurityDescriptor->Revision); + DPRINT1("ObLogSecurityDescriptor is not implemented!\n", InputSecurityDescriptor); SdCopy = ExAllocatePool(PagedPool, sizeof(*SdCopy)); RtlMoveMemory(SdCopy, InputSecurityDescriptor, sizeof(*SdCopy));

1 0

[turner] 19063: Change KEBUGCHECK -> KEBUGCHECKEX
by turner＠svn.reactos.com 08 Nov '05

08 Nov '05

Change KEBUGCHECK -> KEBUGCHECKEX Modified: trunk/reactos/ntoskrnl/ex/work.c _____ Modified: trunk/reactos/ntoskrnl/ex/work.c --- trunk/reactos/ntoskrnl/ex/work.c 2005-11-08 19:43:54 UTC (rev 19062) +++ trunk/reactos/ntoskrnl/ex/work.c 2005-11-08 20:07:41 UTC (rev 19063) @@ -78,15 +78,21 @@ /* Make sure it returned at right IRQL */ if (KeGetCurrentIrql() != PASSIVE_LEVEL) { - /* FIXME: Make this an Ex */ - KEBUGCHECK(WORKER_THREAD_RETURNED_AT_BAD_IRQL); + KEBUGCHECKEX(WORKER_THREAD_RETURNED_AT_BAD_IRQL, + (ULONG_PTR)WorkItem->WorkerRoutine, + KeGetCurrentIrql(), + (ULONG_PTR)WorkItem->Parameter, + (ULONG_PTR)WorkItem); } /* Make sure it returned with Impersionation Disabled */ if (PsGetCurrentThread()->ActiveImpersonationInfo) { - /* FIXME: Make this an Ex */ - KEBUGCHECK(IMPERSONATING_WORKER_THREAD); + KEBUGCHECKEX(IMPERSONATING_WORKER_THREAD, + (ULONG_PTR)WorkItem->WorkerRoutine, + (ULONG_PTR)WorkItem->Parameter, + (ULONG_PTR)WorkItem, + 0); } } }

1 0

[gvg] 19062: Add Language entries for all Locale entries. Fixes bug 955.
by gvg＠svn.reactos.com 08 Nov '05

08 Nov '05

Add Language entries for all Locale entries. Fixes bug 955. Modified: trunk/reactos/bootdata/hivesys.inf _____ Modified: trunk/reactos/bootdata/hivesys.inf --- trunk/reactos/bootdata/hivesys.inf 2005-11-08 18:54:18 UTC (rev 19061) +++ trunk/reactos/bootdata/hivesys.inf 2005-11-08 19:43:54 UTC (rev 19062) @@ -142,31 +142,111 @@ HKLM,"SYSTEM\CurrentControlSet\Control\NLS\CodePage","MACCP",0x00000000, "10000" ; NLS Language settings -HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0401",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0402",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0403",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0404",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0405",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0406",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0407",0x00000000," l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0807",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0c07",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","1407",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0408",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0409",0x00000000," l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0809",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0c09",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","1009",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","1409",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","1809",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","1c09",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","2009",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","3009",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","3409",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","040a",0x00000000," l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","080a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0c0a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","100a",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","140a",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","180a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","1c0a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","200a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","240a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","280a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","2c0a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","300a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","340a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","380a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","3c0a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","400a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","440a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","480a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","4c0a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","500a",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","040b",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","040c",0x00000000," l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","080c",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0c0c",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","100c",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","140c",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","180c",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","040d",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","040e",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","040f",0x00000000," l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0410",0x00000000," l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0810",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0411",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0412",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0413",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0813",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0414",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0814",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0415",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0416",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0816",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0418",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0419",0x00000000," l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","041a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","081a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0c1a",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","041b",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","041c",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","041d",0x00000000," l_intl.nls" -HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0809",0x00000000, "l_intl.nls" -HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0807",0x00000000, "l_intl.nls" -HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0813",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","081d",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","041e",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","041f",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0420",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0421",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0422",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0423",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0424",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0425",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0426",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0427",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0429",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","042a",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","042b",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","042c",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","082c",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","042d",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","042f",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0436",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0437",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0438",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0439",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","043e",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","083e",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","043f",0x00000000 ,"l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0440",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0441",0x00000000, "l_intl.nls" +;HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0443",0x00000000 ,"l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0843",0x00000000, "l_intl.nls" +HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","0456",0x00000000, "l_intl.nls" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","Default",0x0000000 0,"0409" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Language","InstallLanguage",0 x00000000,"0409" ; Supported and installed locales +; If you add/uncomment an entry here, please also add the appropriate Language +; in the previous section. HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Locale",,0x00000012 HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Locale","00000402",0x00010001 ,"5" HKLM,"SYSTEM\CurrentControlSet\Control\NLS\Locale","00000403",0x00010001 ,"1"

1 0

[ion] 19061: - Fix hackplementation of ObLogSecurityDescriptor. Callers are supposed to free their input, so we can't re-use it; instead, allocate a new copy like we should.
by ion＠svn.reactos.com 08 Nov '05

08 Nov '05

- Fix hackplementation of ObLogSecurityDescriptor. Callers are supposed to free their input, so we can't re-use it; instead, allocate a new copy like we should. Modified: trunk/reactos/lib/rtl/unicodeprefix.c Modified: trunk/reactos/ntoskrnl/ob/security.c _____ Modified: trunk/reactos/lib/rtl/unicodeprefix.c --- trunk/reactos/lib/rtl/unicodeprefix.c 2005-11-08 17:22:26 UTC (rev 19060) +++ trunk/reactos/lib/rtl/unicodeprefix.c 2005-11-08 18:54:18 UTC (rev 19061) @@ -10,7 +10,7 @@ #include <rtl.h> -//#define NDEBUG +#define NDEBUG #include <debug.h> /* _____ Modified: trunk/reactos/ntoskrnl/ob/security.c --- trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 17:22:26 UTC (rev 19060) +++ trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 18:54:18 UTC (rev 19061) @@ -263,8 +263,12 @@ IN ULONG RefBias) { /* HACK: Return the same descriptor back */ - DPRINT1("ObLogSecurityDescriptor is not implemented!\n"); - *OutputSecurityDescriptor = InputSecurityDescriptor; + PSECURITY_DESCRIPTOR SdCopy; + DPRINT1("ObLogSecurityDescriptor is not implemented! %lx\n", InputSecurityDescriptor->Revision); + + SdCopy = ExAllocatePool(PagedPool, sizeof(*SdCopy)); + RtlMoveMemory(SdCopy, InputSecurityDescriptor, sizeof(*SdCopy)); + *OutputSecurityDescriptor = SdCopy; return STATUS_SUCCESS; }

1 0

[ion] 19060: - Remove unimplemented macro in SeOpenObjectAuditAlarm and replace it with a DPRINT1; that way callers won't freeze while calling it.
by ion＠svn.reactos.com 08 Nov '05

08 Nov '05

- Remove unimplemented macro in SeOpenObjectAuditAlarm and replace it with a DPRINT1; that way callers won't freeze while calling it. Modified: trunk/reactos/ntoskrnl/ob/security.c Modified: trunk/reactos/ntoskrnl/se/audit.c _____ Modified: trunk/reactos/ntoskrnl/ob/security.c --- trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 17:20:58 UTC (rev 19059) +++ trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 17:22:26 UTC (rev 19060) @@ -262,9 +262,8 @@ OUT PSECURITY_DESCRIPTOR *OutputSecurityDescriptor, IN ULONG RefBias) { - DPRINT1("ObLogSecurityDescriptor is not implemented!\n"); - /* HACK: Return the same descriptor back */ + DPRINT1("ObLogSecurityDescriptor is not implemented!\n"); *OutputSecurityDescriptor = InputSecurityDescriptor; return STATUS_SUCCESS; } _____ Modified: trunk/reactos/ntoskrnl/se/audit.c --- trunk/reactos/ntoskrnl/se/audit.c 2005-11-08 17:20:58 UTC (rev 19059) +++ trunk/reactos/ntoskrnl/se/audit.c 2005-11-08 17:22:26 UTC (rev 19060) @@ -225,7 +225,7 @@ IN KPROCESSOR_MODE AccessMode, OUT PBOOLEAN GenerateOnClose) { - UNIMPLEMENTED; + DPRINT1("SeOpenObjectAuditAlarm is UNIMPLEMENTED!\n"); }

1 0

[hpoussin] 19059: When a driver is a legacy driver, call its AddDevice function with a NULL Pdo
by hpoussin＠svn.reactos.com 08 Nov '05

08 Nov '05

When a driver is a legacy driver, call its AddDevice function with a NULL Pdo Modified: trunk/reactos/drivers/bus/acpi/ospm/acpisys.c Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.c Modified: trunk/reactos/drivers/input/kbdclass/kbdclass.c Modified: trunk/reactos/drivers/input/mouclass/mouclass.c Modified: trunk/reactos/ntoskrnl/io/device.c _____ Modified: trunk/reactos/drivers/bus/acpi/ospm/acpisys.c --- trunk/reactos/drivers/bus/acpi/ospm/acpisys.c 2005-11-08 17:14:19 UTC (rev 19058) +++ trunk/reactos/drivers/bus/acpi/ospm/acpisys.c 2005-11-08 17:20:58 UTC (rev 19059) @@ -143,8 +143,8 @@ DeviceExtension->Pdo = PhysicalDeviceObject; DeviceExtension->Common.IsFDO = TRUE; - DeviceExtension->Common.Ldo = - IoAttachDeviceToDeviceStack(Fdo, PhysicalDeviceObject); + //DeviceExtension->Common.Ldo = + // IoAttachDeviceToDeviceStack(Fdo, PhysicalDeviceObject); DeviceExtension->State = dsStopped; _____ Modified: trunk/reactos/drivers/input/i8042prt/i8042prt.c --- trunk/reactos/drivers/input/i8042prt/i8042prt.c 2005-11-08 17:14:19 UTC (rev 19058) +++ trunk/reactos/drivers/input/i8042prt/i8042prt.c 2005-11-08 17:20:58 UTC (rev 19059) @@ -696,14 +696,15 @@ PDEVICE_EXTENSION DevExt; PFDO_DEVICE_EXTENSION FdoDevExt; PDEVICE_OBJECT Fdo; - static BOOLEAN AlreadyAdded = FALSE; DPRINT("I8042AddDevice\n"); - /* HACK! */ - if (AlreadyAdded) + if (Pdo != NULL) + { + /* Device detected by pnpmgr. Ignore it, as we already have + * detected the keyboard and mouse at first call */ return STATUS_UNSUCCESSFUL; - AlreadyAdded = TRUE; + } Status = IoCreateDevice(DriverObject, sizeof(DEVICE_EXTENSION), @@ -716,8 +717,6 @@ if (!NT_SUCCESS(Status)) return Status; - IoAttachDeviceToDeviceStack(Fdo, Pdo); - DevExt = Fdo->DeviceExtension; RtlZeroMemory(DevExt, sizeof(DEVICE_EXTENSION)); _____ Modified: trunk/reactos/drivers/input/kbdclass/kbdclass.c --- trunk/reactos/drivers/input/kbdclass/kbdclass.c 2005-11-08 17:14:19 UTC (rev 19058) +++ trunk/reactos/drivers/input/kbdclass/kbdclass.c 2005-11-08 17:20:58 UTC (rev 19059) @@ -482,6 +482,9 @@ DPRINT("ClassAddDevice called. Pdo = 0x%p\n", Pdo); + if (Pdo == NULL) + return STATUS_SUCCESS; + DriverExtension = IoGetDriverObjectExtension(DriverObject, DriverObject); /* Create new device object */ _____ Modified: trunk/reactos/drivers/input/mouclass/mouclass.c --- trunk/reactos/drivers/input/mouclass/mouclass.c 2005-11-08 17:14:19 UTC (rev 19058) +++ trunk/reactos/drivers/input/mouclass/mouclass.c 2005-11-08 17:20:58 UTC (rev 19059) @@ -472,6 +472,9 @@ DPRINT("ClassAddDevice called. Pdo = 0x%p\n", Pdo); + if (Pdo == NULL) + return STATUS_SUCCESS; + DriverExtension = IoGetDriverObjectExtension(DriverObject, DriverObject); /* Create new device object */ _____ Modified: trunk/reactos/ntoskrnl/io/device.c --- trunk/reactos/ntoskrnl/io/device.c 2005-11-08 17:14:19 UTC (rev 19058) +++ trunk/reactos/ntoskrnl/io/device.c 2005-11-08 17:20:58 UTC (rev 19059) @@ -72,6 +72,7 @@ { PDEVICE_OBJECT Fdo; NTSTATUS Status; + BOOLEAN IsPnpDriver = FALSE; if (DriverObject->DriverExtension->AddDevice) { @@ -83,39 +84,43 @@ DPRINT("Calling driver AddDevice entrypoint at %08lx\n", DriverObject->DriverExtension->AddDevice); + IsPnpDriver = !IopDeviceNodeHasFlag(DeviceNode, DNF_LEGACY_DRIVER); Status = DriverObject->DriverExtension->AddDevice( - DriverObject, DeviceNode->PhysicalDeviceObject); + DriverObject, IsPnpDriver ? DeviceNode->PhysicalDeviceObject : NULL); if (!NT_SUCCESS(Status)) { return Status; } - Fdo = IoGetAttachedDeviceReference(DeviceNode->PhysicalDeviceObject); - - if (Fdo == DeviceNode->PhysicalDeviceObject) + if (IsPnpDriver) { - /* FIXME: What do we do? Unload the driver or just disable the device? */ - DbgPrint("An FDO was not attached\n"); - IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); - return STATUS_UNSUCCESSFUL; - } + Fdo = IoGetAttachedDeviceReference(DeviceNode->PhysicalDeviceObject); - IopDeviceNodeSetFlag(DeviceNode, DNF_ADDED); + if (Fdo == DeviceNode->PhysicalDeviceObject) + { + /* FIXME: What do we do? Unload the driver or just disable the device? */ + DbgPrint("An FDO was not attached\n"); + IopDeviceNodeSetFlag(DeviceNode, DNF_DISABLED); + return STATUS_UNSUCCESSFUL; + } - if (Fdo->DeviceType == FILE_DEVICE_ACPI) - { - static BOOLEAN SystemPowerDeviceNodeCreated = FALSE; + if (Fdo->DeviceType == FILE_DEVICE_ACPI) + { + static BOOLEAN SystemPowerDeviceNodeCreated = FALSE; - /* There can be only one system power device */ - if (!SystemPowerDeviceNodeCreated) - { - PopSystemPowerDeviceNode = DeviceNode; - SystemPowerDeviceNodeCreated = TRUE; + /* There can be only one system power device */ + if (!SystemPowerDeviceNodeCreated) + { + PopSystemPowerDeviceNode = DeviceNode; + SystemPowerDeviceNodeCreated = TRUE; + } } + + ObDereferenceObject(Fdo); } - ObDereferenceObject(Fdo); + IopDeviceNodeSetFlag(DeviceNode, DNF_ADDED); } return STATUS_SUCCESS; @@ -564,7 +569,7 @@ if (!NT_SUCCESS(Status)) { - DPRINT1("Cannot insert Device Object into Handle Table\n"); + DPRINT1("Cannot insert Device Object into Handle Table (status 0x%08lx)\n", Status); *DeviceObject = NULL; return Status; }

1 0

[ion] 19058: - Don't loop indefintely in RtlFindUnicodePrefix if the splaylinks have changed inside the loop.
by ion＠svn.reactos.com 08 Nov '05

08 Nov '05

- Don't loop indefintely in RtlFindUnicodePrefix if the splaylinks have changed inside the loop. Modified: trunk/reactos/lib/rtl/unicodeprefix.c _____ Modified: trunk/reactos/lib/rtl/unicodeprefix.c --- trunk/reactos/lib/rtl/unicodeprefix.c 2005-11-08 17:07:57 UTC (rev 19057) +++ trunk/reactos/lib/rtl/unicodeprefix.c 2005-11-08 17:14:19 UTC (rev 19058) @@ -10,7 +10,7 @@ #include <rtl.h> -#define NDEBUG +//#define NDEBUG #include <debug.h> /* @@ -179,7 +179,8 @@ DPRINT("CurrentEntry->NameLength %lx\n", CurrentEntry->NameLength); /* Get the splay links and loop */ - while ((SplayLinks = &CurrentEntry->Links)) + SplayLinks = &CurrentEntry->Links; + while (SplayLinks) { /* Get the entry */ DPRINT("SplayLinks %p\n", SplayLinks);

1 0

[ion] 19057: - Hackplement ObLogSecurityDescriptor for W2K3 drivers to be happy.
by ion＠svn.reactos.com 08 Nov '05

08 Nov '05

- Hackplement ObLogSecurityDescriptor for W2K3 drivers to be happy. Modified: trunk/reactos/ntoskrnl/ob/security.c _____ Modified: trunk/reactos/ntoskrnl/ob/security.c --- trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 16:59:41 UTC (rev 19056) +++ trunk/reactos/ntoskrnl/ob/security.c 2005-11-08 17:07:57 UTC (rev 19057) @@ -263,7 +263,10 @@ IN ULONG RefBias) { DPRINT1("ObLogSecurityDescriptor is not implemented!\n"); - return STATUS_NOT_IMPLEMENTED; + + /* HACK: Return the same descriptor back */ + *OutputSecurityDescriptor = InputSecurityDescriptor; + return STATUS_SUCCESS; }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs