Ros-diffs

ros-diffs@reactos.org

81390 discussions

[gvg] 17887: Do some boundschecking on iOrder. Fixes bug 770.
by gvg＠svn.reactos.com 16 Sep '05

16 Sep '05

Do some boundschecking on iOrder. Fixes bug 770. Modified: trunk/reactos/lib/comctl32/header.c _____ Modified: trunk/reactos/lib/comctl32/header.c --- trunk/reactos/lib/comctl32/header.c 2005-09-16 18:07:19 UTC (rev 17886) +++ trunk/reactos/lib/comctl32/header.c 2005-09-16 18:18:48 UTC (rev 17887) @@ -930,6 +930,10 @@ nItem = infoPtr->uNumItem; iOrder = (phdi->mask & HDI_ORDER) ? phdi->iOrder : nItem; + if (iOrder < 0) + iOrder = 0; + else if (infoPtr->uNumItem < iOrder) + iOrder = infoPtr->uNumItem; if (infoPtr->uNumItem == 0) { infoPtr->items = Alloc (sizeof (HEADER_ITEM));

1 0

[amunger] 17886: Fix release build of ntdll by adding __NO_CTYPE_INLINES to rtl.xml
by amunger＠svn.reactos.com 16 Sep '05

16 Sep '05

Fix release build of ntdll by adding __NO_CTYPE_INLINES to rtl.xml Modified: trunk/reactos/lib/rtl/rtl.xml _____ Modified: trunk/reactos/lib/rtl/rtl.xml --- trunk/reactos/lib/rtl/rtl.xml 2005-09-16 18:00:49 UTC (rev 17885) +++ trunk/reactos/lib/rtl/rtl.xml 2005-09-16 18:07:19 UTC (rev 17886) @@ -1,6 +1,7 @@ <module name="rtl" type="staticlibrary"> <define name="__USE_W32API" /> <define name="_NTOSKRNL_" /> + <define name="__NO_CTYPE_INLINES" /> <include base="rtl">.</include> <if property="ARCH" value="i386"> <directory name="i386">

1 0

[amunger] 17885: Fix release build of dflat32, initalizing some vars and fixing one typo.
by amunger＠svn.reactos.com 16 Sep '05

16 Sep '05

Fix release build of dflat32, initalizing some vars and fixing one typo. Modified: trunk/rosapps/dflat32/search.c Modified: trunk/rosapps/dflat32/watch.c _____ Modified: trunk/rosapps/dflat32/search.c --- trunk/rosapps/dflat32/search.c 2005-09-16 17:53:40 UTC (rev 17884) +++ trunk/rosapps/dflat32/search.c 2005-09-16 18:00:49 UTC (rev 17885) @@ -47,7 +47,8 @@ /* ------- search for the occurrance of a string ------- */ static void SearchTextBox(DFWINDOW wnd, int incr) { - char *s1 = NULL, *s2, *cp1; + char *s1 , *s2, *cp1; + s1 = s2 = cp1 = NULL; DF_DBOX *db = Replacing ? &ReplaceTextDB : &SearchTextDB; char *cp = DfGetEditBoxText(db, DF_ID_SEARCHFOR); BOOL rpl = TRUE, FoundOne = FALSE; _____ Modified: trunk/rosapps/dflat32/watch.c --- trunk/rosapps/dflat32/watch.c 2005-09-16 17:53:40 UTC (rev 17884) +++ trunk/rosapps/dflat32/watch.c 2005-09-16 18:00:49 UTC (rev 17885) @@ -44,7 +44,7 @@ // (DF_PARAM) &mx, (DF_PARAM) &my); mx = 0;//DF_SCREENWIDTH / 2; - mx = 0;//DF_SCREENHEIGHT / 2; + my = 0;//DF_SCREENHEIGHT / 2; wnd = DfDfCreateWindow( DF_BOX, NULL,

1 0

[gvg] 17884: Fix "var might be used uninitialized" warning
by gvg＠svn.reactos.com 16 Sep '05

16 Sep '05

Fix "var might be used uninitialized" warning Modified: trunk/reactos/subsys/system/notepad/dialog.c _____ Modified: trunk/reactos/subsys/system/notepad/dialog.c --- trunk/reactos/subsys/system/notepad/dialog.c 2005-09-16 15:34:19 UTC (rev 17883) +++ trunk/reactos/subsys/system/notepad/dialog.c 2005-09-16 17:53:40 UTC (rev 17884) @@ -140,7 +140,7 @@ HANDLE hFile; DWORD dwNumWrite; LPWSTR pTemp; - LPVOID pConverted; + LPVOID pConverted = NULL; DWORD size; BYTE bom[3]; int iBomSize = 0;

1 0

[gvg] 17883: Only access dwTypeData if the caller pronounced it valid.
by gvg＠svn.reactos.com 16 Sep '05

16 Sep '05

Only access dwTypeData if the caller pronounced it valid. Modified: trunk/reactos/lib/user32/windows/menu.c _____ Modified: trunk/reactos/lib/user32/windows/menu.c --- trunk/reactos/lib/user32/windows/menu.c 2005-09-16 15:18:23 UTC (rev 17882) +++ trunk/reactos/lib/user32/windows/menu.c 2005-09-16 15:34:19 UTC (rev 17883) @@ -4646,7 +4646,10 @@ MENUITEMINFOW MenuItemInfoW; RtlCopyMemory(&MenuItemInfoW, lpmii, min(lpmii->cbSize, sizeof(MENUITEMINFOW))); - MenuItemInfoW.cch = wcslen(MenuItemInfoW.dwTypeData); + if (0 != (MenuItemInfoW.fMask & MIIM_STRING)) + { + MenuItemInfoW.cch = wcslen(MenuItemInfoW.dwTypeData); + } return NtUserMenuItemInfo(hMenu, uItem, fByPosition, (PROSMENUITEMINFO)&MenuItemInfoW, TRUE);

1 0

[hbirr] 17882: Free all messages in LpcpDeletePort.
by hbirr＠svn.reactos.com 16 Sep '05

16 Sep '05

Free all messages in LpcpDeletePort. Modified: trunk/reactos/ntoskrnl/lpc/close.c _____ Modified: trunk/reactos/ntoskrnl/lpc/close.c --- trunk/reactos/ntoskrnl/lpc/close.c 2005-09-16 15:18:07 UTC (rev 17881) +++ trunk/reactos/ntoskrnl/lpc/close.c 2005-09-16 15:18:23 UTC (rev 17882) @@ -87,9 +87,27 @@ VOID STDCALL LpcpDeletePort (PVOID ObjectBody) { - // PEPORT Port = (PEPORT)ObjectBody; + PLIST_ENTRY Entry; + PQUEUEDMESSAGE Message; - // DPRINT1("Deleting port %x\n", Port); + PEPORT Port = (PEPORT)ObjectBody; + + DPRINT("Deleting port %x\n", Port); + + /* Free all waiting messages */ + while (!IsListEmpty(&Port->QueueListHead)) + { + Entry = RemoveHeadList(&Port->QueueListHead); + Message = CONTAINING_RECORD (Entry, QUEUEDMESSAGE, QueueListEntry); + ExFreePool(Message); + } + + while (!IsListEmpty(&Port->ConnectQueueListHead)) + { + Entry = RemoveHeadList(&Port->ConnectQueueListHead); + Message = CONTAINING_RECORD (Entry, QUEUEDMESSAGE, QueueListEntry); + ExFreePool(Message); + } }

1 0

[turner] 17881: start even console apps in there own new window. caught by GvG.
by turner＠svn.reactos.com 16 Sep '05

16 Sep '05

start even console apps in there own new window. caught by GvG. Modified: trunk/reactos/subsys/system/cmd/start.c _____ Modified: trunk/reactos/subsys/system/cmd/start.c --- trunk/reactos/subsys/system/cmd/start.c 2005-09-16 15:00:22 UTC (rev 17880) +++ trunk/reactos/subsys/system/cmd/start.c 2005-09-16 15:18:07 UTC (rev 17881) @@ -237,18 +237,8 @@ } else { - if(!_tcsicmp(szFullName,comspec)) - { bCreate = CreateProcess (szFullName, szFullCmdLine, NULL, NULL, FALSE, CREATE_NEW_CONSOLE, NULL, NULL, &stui, &prci); - - } - else - { - bCreate = CreateProcess (szFullName, szFullCmdLine, NULL, NULL, FALSE, - DETACHED_PROCESS, NULL, NULL, &stui, &prci); - } - } if (bCreate)

1 0

[turner] 17880: fix a bug in 'if exsist', it was only reading to the first space for the file name, ignoring quotes and there fore searching for bad file names.
by turner＠svn.reactos.com 16 Sep '05

16 Sep '05

fix a bug in 'if exsist', it was only reading to the first space for the file name, ignoring quotes and there fore searching for bad file names. Modified: trunk/reactos/subsys/system/cmd/if.c _____ Modified: trunk/reactos/subsys/system/cmd/if.c --- trunk/reactos/subsys/system/cmd/if.c 2005-09-16 14:50:25 UTC (rev 17879) +++ trunk/reactos/subsys/system/cmd/if.c 2005-09-16 15:00:22 UTC (rev 17880) @@ -69,15 +69,36 @@ param++; pp = param; - while (*pp && !_istspace (*pp)) + + INT i; + BOOL bInside = FALSE; + /* find the whole path to the file */ + for(i = 0; i < _tcslen(param); i++) + { + if(param[i] == _T('\"')) + bInside = !bInside; + if((param[i] == _T(' ')) && !bInside) + { + break; + } pp++; + } + *pp++ = _T('\0'); + i = 0; + /* remove quotes */ + while(i < _tcslen(param)) + { + if(param[i] == _T('\"')) + memmove(&param[i],&param[i + 1], _tcslen(&param[i]) * sizeof(TCHAR)); + else + i++; + } if (*pp) - { + { WIN32_FIND_DATA f; HANDLE hFind; - - *pp++ = _T('\0'); + hFind = FindFirstFile (param, &f); x_flag ^= (hFind == INVALID_HANDLE_VALUE) ? 0 : X_EXEC; if (hFind != INVALID_HANDLE_VALUE)

1 0

[hbirr] 17879: Dereference the port object in PspExitThread.
by hbirr＠svn.reactos.com 16 Sep '05

16 Sep '05

Dereference the port object in PspExitThread. Modified: trunk/reactos/ntoskrnl/ps/kill.c _____ Modified: trunk/reactos/ntoskrnl/ps/kill.c --- trunk/reactos/ntoskrnl/ps/kill.c 2005-09-16 13:58:37 UTC (rev 17878) +++ trunk/reactos/ntoskrnl/ps/kill.c 2005-09-16 14:50:25 UTC (rev 17879) @@ -281,6 +281,7 @@ /* Send the LPC Message */ LpcSendTerminationPort(TerminationPort->Port, CurrentThread->CreateTime); + ObDereferenceObject(TerminationPort->Port); /* Free the Port */ ExFreePool(TerminationPort);

1 0

[turner] 17878: Set errorlevel to 0 when user enters 'no' on del confirmation. this is how MS does it.
by turner＠svn.reactos.com 16 Sep '05

16 Sep '05

Set errorlevel to 0 when user enters 'no' on del confirmation. this is how MS does it. Modified: trunk/reactos/subsys/system/cmd/del.c _____ Modified: trunk/reactos/subsys/system/cmd/del.c --- trunk/reactos/subsys/system/cmd/del.c 2005-09-16 08:48:00 UTC (rev 17877) +++ trunk/reactos/subsys/system/cmd/del.c 2005-09-16 13:58:37 UTC (rev 17878) @@ -264,7 +264,8 @@ if ((res == PROMPT_NO) || (res == PROMPT_BREAK)) { - continue; //FIXME: Errorcode? + nErrorLevel = 0; + continue; } }

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs