Ros-diffs

ros-diffs@reactos.org

81390 discussions

[reactos] 01/01: [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.16
by Katayama Hirofumi MZ 18 Nov '19

18 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=203a6babdffffe21c0ae6… commit 203a6babdffffe21c0ae6081e460fff5798bb436 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Mon Nov 18 10:36:06 2019 +0900 Commit: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> CommitDate: Mon Nov 18 10:36:06 2019 +0900 [MEDIA][FONTS] Improve tahomabd.ttf (Cyrillic and Latin) No.16 Tahoma Bold. Version 0.008 khmz. 11px QUOTATION MARK. 11px LATIN CAPITAL LETTER F. 11px CYRILLIC CAPITAL LETTER BE. 11px CYRILLIC CAPITAL LETTER DE. 11px CYRILLIC SMALL LETTER SHA. CORE-8408 --- media/fonts/tahomabd.ttf | Bin 160488 -> 160488 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/media/fonts/tahomabd.ttf b/media/fonts/tahomabd.ttf index 35cc64dc7a9..1b0ef28bdd9 100644 Binary files a/media/fonts/tahomabd.ttf and b/media/fonts/tahomabd.ttf differ

1 0

[reactos] 01/01: [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic and Latin) No.15
by Katayama Hirofumi MZ 18 Nov '19

18 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7d7f134f9430ea5ec9e59… commit 7d7f134f9430ea5ec9e59ff012eb996ae08b1ef9 Author: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> AuthorDate: Mon Nov 18 10:27:29 2019 +0900 Commit: Katayama Hirofumi MZ <katayama.hirofumi.mz(a)gmail.com> CommitDate: Mon Nov 18 10:27:29 2019 +0900 [MEDIA][FONTS] Improve tahoma.ttf (Cyrillic and Latin) No.15 Tahoma font. Version 0.011 khmz. 11px LATIN CAPITAL LETTER R. 11px LATIN CAPITAL LETTER R WITH ACUTE. 11px LATIN CAPITAL LETTER R WITH CARON. 11px LATIN SMALL LETTER K. 11px CYRILLIC CAPITAL LETTER U. 11px CYRILLIC SMALL LETTER TSE. CORE-8408 --- media/fonts/tahoma.ttf | Bin 155304 -> 155304 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/media/fonts/tahoma.ttf b/media/fonts/tahoma.ttf index a855d864036..80db951662a 100644 Binary files a/media/fonts/tahoma.ttf and b/media/fonts/tahoma.ttf differ

1 0

[reactos] 02/02: [KDBG] If no parameters are given to the 'filter' command, display the list of available debug filter components.
by Hermès Bélusca-Maïto 18 Nov '19

18 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=40c57de728d9ab23213d7… commit 40c57de728d9ab23213d70b87053ed0943120d06 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Mon Nov 18 01:34:19 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Nov 18 01:36:04 2019 +0100 [KDBG] If no parameters are given to the 'filter' command, display the list of available debug filter components. --- ntoskrnl/kdbg/kdb_cli.c | 428 +++++++++++++++++++++++++----------------------- 1 file changed, 226 insertions(+), 202 deletions(-) diff --git a/ntoskrnl/kdbg/kdb_cli.c b/ntoskrnl/kdbg/kdb_cli.c index 8debef5dca9..daeccb9f2e8 100644 --- a/ntoskrnl/kdbg/kdb_cli.c +++ b/ntoskrnl/kdbg/kdb_cli.c @@ -135,6 +135,177 @@ extern volatile ULONG KdbDmesgTotalWritten; STRING KdbPromptString = RTL_CONSTANT_STRING("kdb:> "); +// +// Debug Filter Component Table +// +static struct +{ + PCSTR Name; + ULONG Id; +} +ComponentTable[] = +{ +// +// Default components +// + { "WIN2000", MAXULONG }, + { "DEFAULT", DPFLTR_DEFAULT_ID }, +// +// Standard components +// + { "SYSTEM", DPFLTR_SYSTEM_ID }, + { "SMSS", DPFLTR_SMSS_ID }, + { "SETUP", DPFLTR_SETUP_ID }, + { "NTFS", DPFLTR_NTFS_ID }, + { "FSTUB", DPFLTR_FSTUB_ID }, + { "CRASHDUMP", DPFLTR_CRASHDUMP_ID }, + { "CDAUDIO", DPFLTR_CDAUDIO_ID }, + { "CDROM", DPFLTR_CDROM_ID }, + { "CLASSPNP", DPFLTR_CLASSPNP_ID }, + { "DISK", DPFLTR_DISK_ID }, + { "REDBOOK", DPFLTR_REDBOOK_ID }, + { "STORPROP", DPFLTR_STORPROP_ID }, + { "SCSIPORT", DPFLTR_SCSIPORT_ID }, + { "SCSIMINIPORT", DPFLTR_SCSIMINIPORT_ID }, + { "CONFIG", DPFLTR_CONFIG_ID }, + { "I8042PRT", DPFLTR_I8042PRT_ID }, + { "SERMOUSE", DPFLTR_SERMOUSE_ID }, + { "LSERMOUS", DPFLTR_LSERMOUS_ID }, + { "KBDHID", DPFLTR_KBDHID_ID }, + { "MOUHID", DPFLTR_MOUHID_ID }, + { "KBDCLASS", DPFLTR_KBDCLASS_ID }, + { "MOUCLASS", DPFLTR_MOUCLASS_ID }, + { "TWOTRACK", DPFLTR_TWOTRACK_ID }, + { "WMILIB", DPFLTR_WMILIB_ID }, + { "ACPI", DPFLTR_ACPI_ID }, + { "AMLI", DPFLTR_AMLI_ID }, + { "HALIA64", DPFLTR_HALIA64_ID }, + { "VIDEO", DPFLTR_VIDEO_ID }, + { "SVCHOST", DPFLTR_SVCHOST_ID }, + { "VIDEOPRT", DPFLTR_VIDEOPRT_ID }, + { "TCPIP", DPFLTR_TCPIP_ID }, + { "DMSYNTH", DPFLTR_DMSYNTH_ID }, + { "NTOSPNP", DPFLTR_NTOSPNP_ID }, + { "FASTFAT", DPFLTR_FASTFAT_ID }, + { "SAMSS", DPFLTR_SAMSS_ID }, + { "PNPMGR", DPFLTR_PNPMGR_ID }, + { "NETAPI", DPFLTR_NETAPI_ID }, + { "SCSERVER", DPFLTR_SCSERVER_ID }, + { "SCCLIENT", DPFLTR_SCCLIENT_ID }, + { "SERIAL", DPFLTR_SERIAL_ID }, + { "SERENUM", DPFLTR_SERENUM_ID }, + { "UHCD", DPFLTR_UHCD_ID }, + { "RPCPROXY", DPFLTR_RPCPROXY_ID }, + { "AUTOCHK", DPFLTR_AUTOCHK_ID }, + { "DCOMSS", DPFLTR_DCOMSS_ID }, + { "UNIMODEM", DPFLTR_UNIMODEM_ID }, + { "SIS", DPFLTR_SIS_ID }, + { "FLTMGR", DPFLTR_FLTMGR_ID }, + { "WMICORE", DPFLTR_WMICORE_ID }, + { "BURNENG", DPFLTR_BURNENG_ID }, + { "IMAPI", DPFLTR_IMAPI_ID }, + { "SXS", DPFLTR_SXS_ID }, + { "FUSION", DPFLTR_FUSION_ID }, + { "IDLETASK", DPFLTR_IDLETASK_ID }, + { "SOFTPCI", DPFLTR_SOFTPCI_ID }, + { "TAPE", DPFLTR_TAPE_ID }, + { "MCHGR", DPFLTR_MCHGR_ID }, + { "IDEP", DPFLTR_IDEP_ID }, + { "PCIIDE", DPFLTR_PCIIDE_ID }, + { "FLOPPY", DPFLTR_FLOPPY_ID }, + { "FDC", DPFLTR_FDC_ID }, + { "TERMSRV", DPFLTR_TERMSRV_ID }, + { "W32TIME", DPFLTR_W32TIME_ID }, + { "PREFETCHER", DPFLTR_PREFETCHER_ID }, + { "RSFILTER", DPFLTR_RSFILTER_ID }, + { "FCPORT", DPFLTR_FCPORT_ID }, + { "PCI", DPFLTR_PCI_ID }, + { "DMIO", DPFLTR_DMIO_ID }, + { "DMCONFIG", DPFLTR_DMCONFIG_ID }, + { "DMADMIN", DPFLTR_DMADMIN_ID }, + { "WSOCKTRANSPORT", DPFLTR_WSOCKTRANSPORT_ID }, + { "VSS", DPFLTR_VSS_ID }, + { "PNPMEM", DPFLTR_PNPMEM_ID }, + { "PROCESSOR", DPFLTR_PROCESSOR_ID }, + { "DMSERVER", DPFLTR_DMSERVER_ID }, + { "SR", DPFLTR_SR_ID }, + { "INFINIBAND", DPFLTR_INFINIBAND_ID }, + { "IHVDRIVER", DPFLTR_IHVDRIVER_ID }, + { "IHVVIDEO", DPFLTR_IHVVIDEO_ID }, + { "IHVAUDIO", DPFLTR_IHVAUDIO_ID }, + { "IHVNETWORK", DPFLTR_IHVNETWORK_ID }, + { "IHVSTREAMING", DPFLTR_IHVSTREAMING_ID }, + { "IHVBUS", DPFLTR_IHVBUS_ID }, + { "HPS", DPFLTR_HPS_ID }, + { "RTLTHREADPOOL", DPFLTR_RTLTHREADPOOL_ID }, + { "LDR", DPFLTR_LDR_ID }, + { "TCPIP6", DPFLTR_TCPIP6_ID }, + { "ISAPNP", DPFLTR_ISAPNP_ID }, + { "SHPC", DPFLTR_SHPC_ID }, + { "STORPORT", DPFLTR_STORPORT_ID }, + { "STORMINIPORT", DPFLTR_STORMINIPORT_ID }, + { "PRINTSPOOLER", DPFLTR_PRINTSPOOLER_ID }, + { "VSSDYNDISK", DPFLTR_VSSDYNDISK_ID }, + { "VERIFIER", DPFLTR_VERIFIER_ID }, + { "VDS", DPFLTR_VDS_ID }, + { "VDSBAS", DPFLTR_VDSBAS_ID }, + { "VDSDYN", DPFLTR_VDSDYN_ID }, // Specified in Vista+ + { "VDSDYNDR", DPFLTR_VDSDYNDR_ID }, + { "VDSLDR", DPFLTR_VDSLDR_ID }, // Specified in Vista+ + { "VDSUTIL", DPFLTR_VDSUTIL_ID }, + { "DFRGIFC", DPFLTR_DFRGIFC_ID }, + { "MM", DPFLTR_MM_ID }, + { "DFSC", DPFLTR_DFSC_ID }, + { "WOW64", DPFLTR_WOW64_ID }, +// +// Components specified in Vista+, some of which we also use in ReactOS +// + { "ALPC", DPFLTR_ALPC_ID }, + { "WDI", DPFLTR_WDI_ID }, + { "PERFLIB", DPFLTR_PERFLIB_ID }, + { "KTM", DPFLTR_KTM_ID }, + { "IOSTRESS", DPFLTR_IOSTRESS_ID }, + { "HEAP", DPFLTR_HEAP_ID }, + { "WHEA", DPFLTR_WHEA_ID }, + { "USERGDI", DPFLTR_USERGDI_ID }, + { "MMCSS", DPFLTR_MMCSS_ID }, + { "TPM", DPFLTR_TPM_ID }, + { "THREADORDER", DPFLTR_THREADORDER_ID }, + { "ENVIRON", DPFLTR_ENVIRON_ID }, + { "EMS", DPFLTR_EMS_ID }, + { "WDT", DPFLTR_WDT_ID }, + { "FVEVOL", DPFLTR_FVEVOL_ID }, + { "NDIS", DPFLTR_NDIS_ID }, + { "NVCTRACE", DPFLTR_NVCTRACE_ID }, + { "LUAFV", DPFLTR_LUAFV_ID }, + { "APPCOMPAT", DPFLTR_APPCOMPAT_ID }, + { "USBSTOR", DPFLTR_USBSTOR_ID }, + { "SBP2PORT", DPFLTR_SBP2PORT_ID }, + { "COVERAGE", DPFLTR_COVERAGE_ID }, + { "CACHEMGR", DPFLTR_CACHEMGR_ID }, + { "MOUNTMGR", DPFLTR_MOUNTMGR_ID }, + { "CFR", DPFLTR_CFR_ID }, + { "TXF", DPFLTR_TXF_ID }, + { "KSECDD", DPFLTR_KSECDD_ID }, + { "FLTREGRESS", DPFLTR_FLTREGRESS_ID }, + { "MPIO", DPFLTR_MPIO_ID }, + { "MSDSM", DPFLTR_MSDSM_ID }, + { "UDFS", DPFLTR_UDFS_ID }, + { "PSHED", DPFLTR_PSHED_ID }, + { "STORVSP", DPFLTR_STORVSP_ID }, + { "LSASS", DPFLTR_LSASS_ID }, + { "SSPICLI", DPFLTR_SSPICLI_ID }, + { "CNG", DPFLTR_CNG_ID }, + { "EXFAT", DPFLTR_EXFAT_ID }, + { "FILETRACE", DPFLTR_FILETRACE_ID }, + { "XSAVE", DPFLTR_XSAVE_ID }, + { "SE", DPFLTR_SE_ID }, + { "DRIVEEXTENDER", DPFLTR_DRIVEEXTENDER_ID }, +}; + +// +// Command Table +// static const struct { PCHAR Name; @@ -202,198 +373,6 @@ static const struct /* FUNCTIONS *****************************************************************/ -/*!\brief Transform a component name to an integer - * - * \param ComponentName The name of the component. - * \param ComponentId Receives the component id on success. - * - * \retval TRUE Success. - * \retval FALSE Failure. - */ -static BOOLEAN -KdbpGetComponentId( - IN PCCH ComponentName, - OUT PULONG ComponentId) -{ - ULONG i; - - static struct - { - PCCH Name; - ULONG Id; - } - ComponentTable[] = - { -// -// Default components -// - { "WIN2000", MAXULONG }, - { "DEFAULT", DPFLTR_DEFAULT_ID }, -// -// Standard components -// - { "SYSTEM", DPFLTR_SYSTEM_ID }, - { "SMSS", DPFLTR_SMSS_ID }, - { "SETUP", DPFLTR_SETUP_ID }, - { "NTFS", DPFLTR_NTFS_ID }, - { "FSTUB", DPFLTR_FSTUB_ID }, - { "CRASHDUMP", DPFLTR_CRASHDUMP_ID }, - { "CDAUDIO", DPFLTR_CDAUDIO_ID }, - { "CDROM", DPFLTR_CDROM_ID }, - { "CLASSPNP", DPFLTR_CLASSPNP_ID }, - { "DISK", DPFLTR_DISK_ID }, - { "REDBOOK", DPFLTR_REDBOOK_ID }, - { "STORPROP", DPFLTR_STORPROP_ID }, - { "SCSIPORT", DPFLTR_SCSIPORT_ID }, - { "SCSIMINIPORT", DPFLTR_SCSIMINIPORT_ID }, - { "CONFIG", DPFLTR_CONFIG_ID }, - { "I8042PRT", DPFLTR_I8042PRT_ID }, - { "SERMOUSE", DPFLTR_SERMOUSE_ID }, - { "LSERMOUS", DPFLTR_LSERMOUS_ID }, - { "KBDHID", DPFLTR_KBDHID_ID }, - { "MOUHID", DPFLTR_MOUHID_ID }, - { "KBDCLASS", DPFLTR_KBDCLASS_ID }, - { "MOUCLASS", DPFLTR_MOUCLASS_ID }, - { "TWOTRACK", DPFLTR_TWOTRACK_ID }, - { "WMILIB", DPFLTR_WMILIB_ID }, - { "ACPI", DPFLTR_ACPI_ID }, - { "AMLI", DPFLTR_AMLI_ID }, - { "HALIA64", DPFLTR_HALIA64_ID }, - { "VIDEO", DPFLTR_VIDEO_ID }, - { "SVCHOST", DPFLTR_SVCHOST_ID }, - { "VIDEOPRT", DPFLTR_VIDEOPRT_ID }, - { "TCPIP", DPFLTR_TCPIP_ID }, - { "DMSYNTH", DPFLTR_DMSYNTH_ID }, - { "NTOSPNP", DPFLTR_NTOSPNP_ID }, - { "FASTFAT", DPFLTR_FASTFAT_ID }, - { "SAMSS", DPFLTR_SAMSS_ID }, - { "PNPMGR", DPFLTR_PNPMGR_ID }, - { "NETAPI", DPFLTR_NETAPI_ID }, - { "SCSERVER", DPFLTR_SCSERVER_ID }, - { "SCCLIENT", DPFLTR_SCCLIENT_ID }, - { "SERIAL", DPFLTR_SERIAL_ID }, - { "SERENUM", DPFLTR_SERENUM_ID }, - { "UHCD", DPFLTR_UHCD_ID }, - { "RPCPROXY", DPFLTR_RPCPROXY_ID }, - { "AUTOCHK", DPFLTR_AUTOCHK_ID }, - { "DCOMSS", DPFLTR_DCOMSS_ID }, - { "UNIMODEM", DPFLTR_UNIMODEM_ID }, - { "SIS", DPFLTR_SIS_ID }, - { "FLTMGR", DPFLTR_FLTMGR_ID }, - { "WMICORE", DPFLTR_WMICORE_ID }, - { "BURNENG", DPFLTR_BURNENG_ID }, - { "IMAPI", DPFLTR_IMAPI_ID }, - { "SXS", DPFLTR_SXS_ID }, - { "FUSION", DPFLTR_FUSION_ID }, - { "IDLETASK", DPFLTR_IDLETASK_ID }, - { "SOFTPCI", DPFLTR_SOFTPCI_ID }, - { "TAPE", DPFLTR_TAPE_ID }, - { "MCHGR", DPFLTR_MCHGR_ID }, - { "IDEP", DPFLTR_IDEP_ID }, - { "PCIIDE", DPFLTR_PCIIDE_ID }, - { "FLOPPY", DPFLTR_FLOPPY_ID }, - { "FDC", DPFLTR_FDC_ID }, - { "TERMSRV", DPFLTR_TERMSRV_ID }, - { "W32TIME", DPFLTR_W32TIME_ID }, - { "PREFETCHER", DPFLTR_PREFETCHER_ID }, - { "RSFILTER", DPFLTR_RSFILTER_ID }, - { "FCPORT", DPFLTR_FCPORT_ID }, - { "PCI", DPFLTR_PCI_ID }, - { "DMIO", DPFLTR_DMIO_ID }, - { "DMCONFIG", DPFLTR_DMCONFIG_ID }, - { "DMADMIN", DPFLTR_DMADMIN_ID }, - { "WSOCKTRANSPORT", DPFLTR_WSOCKTRANSPORT_ID }, - { "VSS", DPFLTR_VSS_ID }, - { "PNPMEM", DPFLTR_PNPMEM_ID }, - { "PROCESSOR", DPFLTR_PROCESSOR_ID }, - { "DMSERVER", DPFLTR_DMSERVER_ID }, - { "SR", DPFLTR_SR_ID }, - { "INFINIBAND", DPFLTR_INFINIBAND_ID }, - { "IHVDRIVER", DPFLTR_IHVDRIVER_ID }, - { "IHVVIDEO", DPFLTR_IHVVIDEO_ID }, - { "IHVAUDIO", DPFLTR_IHVAUDIO_ID }, - { "IHVNETWORK", DPFLTR_IHVNETWORK_ID }, - { "IHVSTREAMING", DPFLTR_IHVSTREAMING_ID }, - { "IHVBUS", DPFLTR_IHVBUS_ID }, - { "HPS", DPFLTR_HPS_ID }, - { "RTLTHREADPOOL", DPFLTR_RTLTHREADPOOL_ID }, - { "LDR", DPFLTR_LDR_ID }, - { "TCPIP6", DPFLTR_TCPIP6_ID }, - { "ISAPNP", DPFLTR_ISAPNP_ID }, - { "SHPC", DPFLTR_SHPC_ID }, - { "STORPORT", DPFLTR_STORPORT_ID }, - { "STORMINIPORT", DPFLTR_STORMINIPORT_ID }, - { "PRINTSPOOLER", DPFLTR_PRINTSPOOLER_ID }, - { "VSSDYNDISK", DPFLTR_VSSDYNDISK_ID }, - { "VERIFIER", DPFLTR_VERIFIER_ID }, - { "VDS", DPFLTR_VDS_ID }, - { "VDSBAS", DPFLTR_VDSBAS_ID }, - { "VDSDYN", DPFLTR_VDSDYN_ID }, - { "VDSDYNDR", DPFLTR_VDSDYNDR_ID }, - { "VDSLDR", DPFLTR_VDSLDR_ID }, - { "VDSUTIL", DPFLTR_VDSUTIL_ID }, - { "DFRGIFC", DPFLTR_DFRGIFC_ID }, - { "MM", DPFLTR_MM_ID }, - { "DFSC", DPFLTR_DFSC_ID }, - { "WOW64", DPFLTR_WOW64_ID }, -// -// Components specified in Vista+, some of which we also use in ReactOS -// - { "ALPC", DPFLTR_ALPC_ID }, - { "WDI", DPFLTR_WDI_ID }, - { "PERFLIB", DPFLTR_PERFLIB_ID }, - { "KTM", DPFLTR_KTM_ID }, - { "IOSTRESS", DPFLTR_IOSTRESS_ID }, - { "HEAP", DPFLTR_HEAP_ID }, - { "WHEA", DPFLTR_WHEA_ID }, - { "USERGDI", DPFLTR_USERGDI_ID }, - { "MMCSS", DPFLTR_MMCSS_ID }, - { "TPM", DPFLTR_TPM_ID }, - { "THREADORDER", DPFLTR_THREADORDER_ID }, - { "ENVIRON", DPFLTR_ENVIRON_ID }, - { "EMS", DPFLTR_EMS_ID }, - { "WDT", DPFLTR_WDT_ID }, - { "FVEVOL", DPFLTR_FVEVOL_ID }, - { "NDIS", DPFLTR_NDIS_ID }, - { "NVCTRACE", DPFLTR_NVCTRACE_ID }, - { "LUAFV", DPFLTR_LUAFV_ID }, - { "APPCOMPAT", DPFLTR_APPCOMPAT_ID }, - { "USBSTOR", DPFLTR_USBSTOR_ID }, - { "SBP2PORT", DPFLTR_SBP2PORT_ID }, - { "COVERAGE", DPFLTR_COVERAGE_ID }, - { "CACHEMGR", DPFLTR_CACHEMGR_ID }, - { "MOUNTMGR", DPFLTR_MOUNTMGR_ID }, - { "CFR", DPFLTR_CFR_ID }, - { "TXF", DPFLTR_TXF_ID }, - { "KSECDD", DPFLTR_KSECDD_ID }, - { "FLTREGRESS", DPFLTR_FLTREGRESS_ID }, - { "MPIO", DPFLTR_MPIO_ID }, - { "MSDSM", DPFLTR_MSDSM_ID }, - { "UDFS", DPFLTR_UDFS_ID }, - { "PSHED", DPFLTR_PSHED_ID }, - { "STORVSP", DPFLTR_STORVSP_ID }, - { "LSASS", DPFLTR_LSASS_ID }, - { "SSPICLI", DPFLTR_SSPICLI_ID }, - { "CNG", DPFLTR_CNG_ID }, - { "EXFAT", DPFLTR_EXFAT_ID }, - { "FILETRACE", DPFLTR_FILETRACE_ID }, - { "XSAVE", DPFLTR_XSAVE_ID }, - { "SE", DPFLTR_SE_ID }, - { "DRIVEEXTENDER", DPFLTR_DRIVEEXTENDER_ID }, - }; - - for (i = 0; i < sizeof(ComponentTable) / sizeof(ComponentTable[0]); i++) - { - if (_stricmp(ComponentName, ComponentTable[i].Name) == 0) - { - *ComponentId = ComponentTable[i].Id; - return TRUE; - } - } - - return FALSE; -} - /*!\brief Evaluates an expression... * * Much like KdbpRpnEvaluateExpression, but prints the error message (if any) @@ -647,7 +626,34 @@ end: } #endif -/*!\brief Display list of active debug channels +/*!\brief Retrieves the component ID corresponding to a given component name. + * + * \param ComponentName The name of the component. + * \param ComponentId Receives the component id on success. + * + * \retval TRUE Success. + * \retval FALSE Failure. + */ +static BOOLEAN +KdbpGetComponentId( + IN PCSTR ComponentName, + OUT PULONG ComponentId) +{ + ULONG i; + + for (i = 0; i < sizeof(ComponentTable) / sizeof(ComponentTable[0]); i++) + { + if (_stricmp(ComponentName, ComponentTable[i].Name) == 0) + { + *ComponentId = ComponentTable[i].Id; + return TRUE; + } + } + + return FALSE; +} + +/*!\brief Displays the list of active debug channels, or enable/disable debug channels. */ static BOOLEAN KdbpCmdFilter( @@ -657,26 +663,44 @@ KdbpCmdFilter( ULONG i, j, ComponentId, Level; ULONG set = DPFLTR_MASK, clear = DPFLTR_MASK; PCHAR pend; - LPCSTR opt, p; + PCSTR opt, p; static struct { - LPCSTR Name; + PCSTR Name; ULONG Level; } debug_classes[] = { - { "error", 1 << DPFLTR_ERROR_LEVEL }, + { "error", 1 << DPFLTR_ERROR_LEVEL }, { "warning", 1 << DPFLTR_WARNING_LEVEL }, - { "trace", 1 << DPFLTR_TRACE_LEVEL }, - { "info", 1 << DPFLTR_INFO_LEVEL }, + { "trace", 1 << DPFLTR_TRACE_LEVEL }, + { "info", 1 << DPFLTR_INFO_LEVEL }, }; + if (Argc <= 1) + { + /* Display the list of available debug filter components */ + KdbpPrint("REMARKS:\n" + "- The 'WIN2000' system-wide debug filter component is used for DbgPrint()\n" + " messages without Component ID and Level.\n" + "- The 'DEFAULT' debug filter component is used for DbgPrint() messages with\n" + " an unknown Component ID.\n\n"); + KdbpPrint("The list of debug filter components currently available on your system is:\n\n"); + KdbpPrint(" Component Name Component ID\n" + "================ ==============\n"); + for (i = 0; i < sizeof(ComponentTable) / sizeof(ComponentTable[0]); i++) + { + KdbpPrint("%16s 0x%08lx\n", ComponentTable[i].Name, ComponentTable[i].Id); + } + return TRUE; + } + for (i = 1; i < Argc; i++) { opt = Argv[i]; p = opt + strcspn(opt, "+-"); - if (!p[0]) p = opt; /* assume it's a debug channel name */ + if (!p[0]) p = opt; /* Assume it's a debug channel name */ if (p > opt) { @@ -685,7 +709,7 @@ KdbpCmdFilter( SIZE_T len = strlen(debug_classes[j].Name); if (len != (p - opt)) continue; - if (_strnicmp(opt, debug_classes[j].Name, len) == 0) /* found it */ + if (_strnicmp(opt, debug_classes[j].Name, len) == 0) /* Found it */ { if (*p == '+') set |= debug_classes[j].Level; @@ -3521,7 +3545,7 @@ BOOLEAN KdbpInvokeCliCallbacks( IN PCHAR Command, IN ULONG Argc, - IN PCH Argv[]) + IN PCHAR Argv[]) { ULONG i; @@ -3559,7 +3583,7 @@ KdbpDoCommand( PCHAR p; ULONG Argc; // FIXME: for what do we need a 1024 characters command line and 256 tokens? - static PCH Argv[256]; + static PCHAR Argv[256]; static CHAR OrigCommand[1024]; RtlStringCbCopyA(OrigCommand, sizeof(OrigCommand), Command);

1 0

[reactos] 01/02: [NTOS:KD/KD64] Fix x64 build.
by Hermès Bélusca-Maïto 18 Nov '19

18 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=548393c6e759f47336e15… commit 548393c6e759f47336e158d6d6aa4e5cd551f9ba Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Mon Nov 18 01:33:06 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Nov 18 01:36:04 2019 +0100 [NTOS:KD/KD64] Fix x64 build. --- ntoskrnl/kd/kdmain.c | 2 +- ntoskrnl/kd64/kdapi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/kd/kdmain.c b/ntoskrnl/kd/kdmain.c index ce8a738f26d..25a63a1c0cb 100644 --- a/ntoskrnl/kd/kdmain.c +++ b/ntoskrnl/kd/kdmain.c @@ -131,7 +131,7 @@ KdpServiceDispatcher(ULONG Service, /* Special case for stack frame dumps */ case 'DsoR': { - KeRosDumpStackFrames((PULONG)Buffer1, Buffer1Length); + KeRosDumpStackFrames((PULONG_PTR)Buffer1, Buffer1Length); break; } diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index e12ac7e5353..e7d304bf726 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2193,7 +2193,7 @@ KdSystemDebugControl( /* Special case for stack frame dumps */ case 'DsoR': { - KeRosDumpStackFrames((PULONG)InputBuffer, InputBufferLength); + KeRosDumpStackFrames((PULONG_PTR)InputBuffer, InputBufferLength); break; } #endif

1 0

[reactos] 06/06: [I8042PRT] Remove dead commented-out code; Allow sending ROS-specific commands to the kernel debugger since KD64 also support them.
by Hermès Bélusca-Maïto 17 Nov '19

17 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ea6d427d10840e4b63f5a… commit ea6d427d10840e4b63f5af7a2012881379be74c1 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 17 23:01:18 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 17 23:21:55 2019 +0100 [I8042PRT] Remove dead commented-out code; Allow sending ROS-specific commands to the kernel debugger since KD64 also support them. [NTOS:MM] Remove an extra ')' in a DbgPrint() string. --- drivers/input/i8042prt/i8042prt.c | 11 ----------- drivers/input/i8042prt/keyboard.c | 2 -- ntoskrnl/mm/ARM3/mminit.c | 2 +- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/input/i8042prt/i8042prt.c b/drivers/input/i8042prt/i8042prt.c index 61963240472..19027a9b0df 100644 --- a/drivers/input/i8042prt/i8042prt.c +++ b/drivers/input/i8042prt/i8042prt.c @@ -502,17 +502,6 @@ DriverEntry( ULONG i; NTSTATUS Status; - /* ROS Hack: ideally, we shouldn't have to initialize debug level this way, - but since the only way is to change it via KDBG, it's better to leave - it here too. */ -#if 0 - DbgSetDebugFilterState( - DPFLTR_I8042PRT_ID, - (1 << DPFLTR_ERROR_LEVEL) | (1 << DPFLTR_WARNING_LEVEL) | - (1 << DPFLTR_TRACE_LEVEL) /*| (1 << DPFLTR_INFO_LEVEL)*/ | DPFLTR_MASK, - TRUE); -#endif - Status = IoAllocateDriverObjectExtension( DriverObject, DriverObject, diff --git a/drivers/input/i8042prt/keyboard.c b/drivers/input/i8042prt/keyboard.c index 177443ea620..e33ec89659b 100644 --- a/drivers/input/i8042prt/keyboard.c +++ b/drivers/input/i8042prt/keyboard.c @@ -866,7 +866,6 @@ i8042KbdInterruptService( /* b - Bugcheck */ KeBugCheck(MANUALLY_INITIATED_CRASH); } -#if defined(KDBG) else { /* Send request to the kernel debugger. @@ -879,7 +878,6 @@ i8042KbdInterruptService( NULL, KernelMode); } -#endif } } diff --git a/ntoskrnl/mm/ARM3/mminit.c b/ntoskrnl/mm/ARM3/mminit.c index f1d7c2b7e95..fcd1c7dae2f 100644 --- a/ntoskrnl/mm/ARM3/mminit.c +++ b/ntoskrnl/mm/ARM3/mminit.c @@ -1557,7 +1557,7 @@ MmDumpArmPfnDatabase(IN BOOLEAN StatusOnly) // Pretty-print the page // if (!StatusOnly) - DbgPrint("0x%08p:\t%20s\t(%04d.%04d)\t[%16s - %16s])\n", + DbgPrint("0x%08p:\t%20s\t(%04d.%04d)\t[%16s - %16s]\n", i << PAGE_SHIFT, Consumer, Pfn1->u3.e2.ReferenceCount,

1 0

[reactos] 05/06: [NTOS:KD/KD64/KDBG] Share some code between our legacy KD/KDBG and KD64.
by Hermès Bélusca-Maïto 17 Nov '19

17 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a890fc64d17e7c4a09a3c… commit a890fc64d17e7c4a09a3cbe24e0dfc972d743dda Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 17 22:55:36 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 17 23:21:54 2019 +0100 [NTOS:KD/KD64/KDBG] Share some code between our legacy KD/KDBG and KD64. Our legacy KD module is slowly being phased out for the more recent KD64 Kernel Debugger that supports WinDbg, but at the same time we must retain support for GCC debugging and the KDBG interface. For the time being few #ifdef _WINKD_ have been introduced in KD64 so that some of its code/data does not completely get shared yet with the legacy KD, until the latter becomes phased out. KD Modifications: ================= - Remove the implementation of NtQueryDebugFilterState() / NtSetDebugFilterState() that now comes entirely from KD64. - Remove KD variables that are now shared with KD64. - Share common code with KD64: KdpMoveMemory(), KdpZeroMemory(), KdpCopyMemoryChunks(), KdpPrint(), KdpPrompt(). - KDBG: Remove the duplicated KdpCopyMemoryChunks() function. - In KdpServiceDispatcher() and KdpEnterDebuggerException(), call the KdpPrint() worker function that correctly probes and captures its arguments. - Temporarily stub out KdEnterDebugger() and KdExitDebugger() that is used by the shared code, until KD is removed and only the KD64 version of these functions remain. - Re-implement the KD/KDBG KdpPrompt() function using a custom KdpPromptString() helper compatible with KD64, that is called by the KD64 implementation of KdpPrompt(). This KdpPromptString() helper now issues the prompt on all the KD loggers: e.g. if you use both at the same time COM-port and SCREEN debugging, the prompt will appear on both. Before that the prompt was always being displayed on COM port even if e.g. a SCREEN-only debug session was used... - ppc_irq.c: Fix the prototype of KdpServiceDispatcher(). KD64 Fixes: =========== - Initialize the MaximumLength member of the counted STRING variables before using them elsewhere. - Get rid of alloca() within SEH block in KdpPrint() (addendum to 7b95fcf9). - Add the ROS-specific handy dump commands in KdSystemDebugControl(). --- ntoskrnl/include/internal/kd.h | 63 +++--------- ntoskrnl/kd/kdio.c | 145 +++++++++++++++++++++------ ntoskrnl/kd/kdmain.c | 215 +++++++++++++++++------------------------ ntoskrnl/kd64/kdapi.c | 47 +++++++-- ntoskrnl/kd64/kddata.c | 4 + ntoskrnl/kd64/kdprint.c | 32 ++++-- ntoskrnl/kdbg/kdb.c | 83 ---------------- ntoskrnl/kdbg/kdb_cli.c | 215 ++--------------------------------------- ntoskrnl/ke/powerpc/ppc_irq.c | 8 +- ntoskrnl/ntos.cmake | 5 +- 10 files changed, 299 insertions(+), 518 deletions(-) diff --git a/ntoskrnl/include/internal/kd.h b/ntoskrnl/include/internal/kd.h index ef66e2abea2..ede52d82c57 100644 --- a/ntoskrnl/include/internal/kd.h +++ b/ntoskrnl/include/internal/kd.h @@ -7,9 +7,6 @@ // struct _KD_DISPATCH_TABLE; extern CPPORT GdbPortInfo; -extern BOOLEAN KdBreakAfterSymbolLoad; -extern BOOLEAN KdPitchDebugger; -extern BOOLEAN KdIgnoreUmExceptions; BOOLEAN NTAPI @@ -93,8 +90,7 @@ typedef enum _KD_CONTINUE_TYPE kdContinue = 0, kdDoNotHandleException, kdHandleException -} -KD_CONTINUE_TYPE; +} KD_CONTINUE_TYPE; typedef VOID @@ -122,14 +118,6 @@ KD_CONTINUE_TYPE PKTRAP_FRAME TrapFrame ); -BOOLEAN -NTAPI -KdIsThisAKdTrap( - IN PEXCEPTION_RECORD ExceptionRecord, - IN PCONTEXT Context, - IN KPROCESSOR_MODE PreviousMode -); - /* INIT ROUTINES *************************************************************/ BOOLEAN @@ -188,13 +176,6 @@ KdpKdbgInit( /* KD ROUTINES ***************************************************************/ -ULONG -NTAPI -KdpPrintString( - _In_reads_bytes_(Length) PCHAR UnsafeString, - _In_ ULONG Length, - _In_ KPROCESSOR_MODE PreviousMode); - BOOLEAN NTAPI KdpDetectConflicts(PCM_RESOURCE_LIST DriverList); @@ -215,37 +196,22 @@ KdpSafeWriteMemory( IN ULONGLONG Value ); -VOID -NTAPI -KdpEnableSafeMem(VOID); - /* KD GLOBALS ***************************************************************/ -typedef -BOOLEAN -(NTAPI *PKDEBUG_ROUTINE)( - IN PKTRAP_FRAME TrapFrame, - IN PKEXCEPTION_FRAME ExceptionFrame, - IN PEXCEPTION_RECORD ExceptionRecord, - IN PCONTEXT Context, - IN KPROCESSOR_MODE PreviousMode, - IN BOOLEAN SecondChance -); - -/* serial debug connection */ +/* Serial debug connection */ #define DEFAULT_DEBUG_PORT 2 /* COM2 */ #define DEFAULT_DEBUG_COM1_IRQ 4 /* COM1 IRQ */ #define DEFAULT_DEBUG_COM2_IRQ 3 /* COM2 IRQ */ #define DEFAULT_DEBUG_BAUD_RATE 115200 /* 115200 Baud */ /* KD Native Modes */ -#define KdScreen 0 -#define KdSerial 1 -#define KdFile 2 -#define KdBochs 3 -#define KdKdbg 4 -#define KdMax 5 +#define KdScreen 0 +#define KdSerial 1 +#define KdFile 2 +#define KdBochs 3 +#define KdKdbg 4 +#define KdMax 5 /* KD Private Debug Modes */ typedef struct _KDP_DEBUG_MODE @@ -268,8 +234,7 @@ typedef struct _KDP_DEBUG_MODE /* Generic Value */ ULONG Value; }; -} -KDP_DEBUG_MODE; +} KDP_DEBUG_MODE; /* KD Internal Debug Services */ typedef enum _KDP_DEBUG_SERVICE @@ -286,8 +251,7 @@ typedef enum _KDP_DEBUG_SERVICE KdSpare3 = 0x24, /* j */ EnterDebugger = 0x25, /* k */ ThatsWhatSheSaid = 69 /* FIGURE IT OUT */ -} -KDP_DEBUG_SERVICE; +} KDP_DEBUG_SERVICE; /* Dispatch Table for Wrapper Functions */ typedef struct _KD_DISPATCH_TABLE @@ -297,8 +261,7 @@ typedef struct _KD_DISPATCH_TABLE PKDP_PRINT_ROUTINE KdpPrintRoutine; PKDP_PROMPT_ROUTINE KdpPromptRoutine; PKDP_EXCEPTION_ROUTINE KdpExceptionRoutine; -} -KD_DISPATCH_TABLE, *PKD_DISPATCH_TABLE; +} KD_DISPATCH_TABLE, *PKD_DISPATCH_TABLE; /* The current Debugging Mode */ extern KDP_DEBUG_MODE KdpDebugMode; @@ -328,10 +291,6 @@ extern KD_DISPATCH_TABLE WrapperTable; /* The KD Native Provider List */ extern LIST_ENTRY KdProviders; -extern PKDEBUG_ROUTINE KiDebugRoutine; -extern KD_CONTEXT KdpContext; -extern ULONG Kd_WIN2000_Mask; - #endif #if DBG && defined(_M_IX86) && !defined(_WINKD_) // See ke/i386/traphdlr.c diff --git a/ntoskrnl/kd/kdio.c b/ntoskrnl/kd/kdio.c index 23b163b4ebf..4921d6af7c2 100644 --- a/ntoskrnl/kd/kdio.c +++ b/ntoskrnl/kd/kdio.c @@ -585,40 +585,15 @@ KdpScreenInit(PKD_DISPATCH_TABLE DispatchTable, /* GENERAL FUNCTIONS *********************************************************/ -ULONG +BOOLEAN NTAPI KdpPrintString( - _In_reads_bytes_(Length) PCHAR UnsafeString, - _In_ ULONG Length, - _In_ KPROCESSOR_MODE PreviousMode) + _In_ PSTRING Output) { PLIST_ENTRY CurrentEntry; PKD_DISPATCH_TABLE CurrentTable; - PCHAR String; - CHAR StringBuffer[512]; - if (!KdpDebugMode.Value) return 0; - - Length = min(Length, sizeof(StringBuffer)); - - if (PreviousMode != KernelMode) - { - _SEH2_TRY - { - ProbeForRead(UnsafeString, Length, 1); - String = StringBuffer; - RtlCopyMemory(String, UnsafeString, Length); - } - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) - { - return 0; - } - _SEH2_END; - } - else - { - String = UnsafeString; - } + if (!KdpDebugMode.Value) return FALSE; /* Call the registered handlers */ CurrentEntry = KdProviders.Flink; @@ -630,7 +605,7 @@ KdpPrintString( KdProvidersList); /* Call it */ - CurrentTable->KdpPrintRoutine(String, Length); + CurrentTable->KdpPrintRoutine(Output->Buffer, Output->Length); /* Next Table */ CurrentEntry = CurrentEntry->Flink; @@ -638,10 +613,116 @@ KdpPrintString( /* Call the Wrapper Routine */ if (WrapperTable.KdpPrintRoutine) - WrapperTable.KdpPrintRoutine(String, Length); + WrapperTable.KdpPrintRoutine(Output->Buffer, Output->Length); + + return FALSE; +} + +extern STRING KdbPromptString; + +BOOLEAN +NTAPI +KdpPromptString( + _In_ PSTRING PromptString, + _In_ PSTRING ResponseString) +{ + KIRQL OldIrql; + STRING StringChar; + CHAR Response; + USHORT i; + ULONG DummyScanCode; + + StringChar.Buffer = &Response; + StringChar.Length = StringChar.MaximumLength = sizeof(Response); + + /* Display the string and print a new line for log neatness */ + KdpPrintString(PromptString); + *StringChar.Buffer = '\n'; + KdpPrintString(&StringChar); + + /* Print the kdb prompt */ + KdpPrintString(&KdbPromptString); + + // TODO: Use an improved KdbpReadCommand() function for our purposes. + + /* Acquire the printing spinlock without waiting at raised IRQL */ + OldIrql = KdpAcquireLock(&KdpSerialSpinLock); + + if (!(KdbDebugState & KD_DEBUG_KDSERIAL)) + KbdDisableMouse(); + + /* Loop the whole string */ + for (i = 0; i < ResponseString->MaximumLength; i++) + { + /* Check if this is serial debugging mode */ + if (KdbDebugState & KD_DEBUG_KDSERIAL) + { + /* Get the character from serial */ + do + { + Response = KdbpTryGetCharSerial(MAXULONG); + } while (Response == -1); + } + else + { + /* Get the response from the keyboard */ + do + { + Response = KdbpTryGetCharKeyboard(&DummyScanCode, MAXULONG); + } while (Response == -1); + } + + /* Check for return */ + if (Response == '\r') + { + /* + * We might need to discard the next '\n'. + * Wait a bit to make sure we receive it. + */ + KeStallExecutionProcessor(100000); + + /* Check the mode */ + if (KdbDebugState & KD_DEBUG_KDSERIAL) + { + /* Read and discard the next character, if any */ + KdbpTryGetCharSerial(5); + } + else + { + /* Read and discard the next character, if any */ + KdbpTryGetCharKeyboard(&DummyScanCode, 5); + } + + /* + * Null terminate the output string -- documentation states that + * DbgPrompt does not null terminate, but it does + */ + *(PCHAR)(ResponseString->Buffer + i) = 0; + break; + } + + /* Write it back and print it to the log */ + *(PCHAR)(ResponseString->Buffer + i) = Response; + KdpReleaseLock(&KdpSerialSpinLock, OldIrql); + KdpPrintString(&StringChar); + OldIrql = KdpAcquireLock(&KdpSerialSpinLock); + } + + /* Return the length */ + ResponseString->Length = i; + + if (!(KdbDebugState & KD_DEBUG_KDSERIAL)) + KbdEnableMouse(); + + /* Release the spinlock */ + KdpReleaseLock(&KdpSerialSpinLock, OldIrql); + + /* Print a new line */ + *StringChar.Buffer = '\n'; + KdpPrintString(&StringChar); - /* Return the Length */ - return Length; + /* Success; we don't need to resend */ + return FALSE; } /* EOF */ diff --git a/ntoskrnl/kd/kdmain.c b/ntoskrnl/kd/kdmain.c index fdbeeea4deb..ce8a738f26d 100644 --- a/ntoskrnl/kd/kdmain.c +++ b/ntoskrnl/kd/kdmain.c @@ -11,6 +11,38 @@ #define NDEBUG #include <debug.h> +// +// Retrieves the ComponentId and Level for BREAKPOINT_PRINT +// and OutputString and OutputStringLength for BREAKPOINT_PROMPT. +// +#if defined(_X86_) + +// +// EBX/EDI on x86 +// +#define KdpGetParameterThree(Context) ((Context)->Ebx) +#define KdpGetParameterFour(Context) ((Context)->Edi) + +#elif defined(_AMD64_) + +// +// R8/R9 on AMD64 +// +#define KdpGetParameterThree(Context) ((Context)->R8) +#define KdpGetParameterFour(Context) ((Context)->R9) + +#elif defined(_ARM_) + +// +// R3/R4 on ARM +// +#define KdpGetParameterThree(Context) ((Context)->R3) +#define KdpGetParameterFour(Context) ((Context)->R4) + +#else +#error Unsupported Architecture +#endif + /* VARIABLES ***************************************************************/ BOOLEAN KdDebuggerEnabled = FALSE; @@ -19,22 +51,12 @@ BOOLEAN KdDebuggerNotPresent = TRUE; BOOLEAN KdBreakAfterSymbolLoad = FALSE; BOOLEAN KdPitchDebugger = TRUE; BOOLEAN KdIgnoreUmExceptions = FALSE; -KD_CONTEXT KdpContext; -ULONG Kd_WIN2000_Mask; -LONG KdpTimeSlipPending; -KDDEBUGGER_DATA64 KdDebuggerDataBlock; -VOID NTAPI PspDumpThreads(BOOLEAN SystemThreads); -typedef struct -{ - ULONG ComponentId; - ULONG Level; -} KD_COMPONENT_DATA; -#define MAX_KD_COMPONENT_TABLE_ENTRIES 128 -KD_COMPONENT_DATA KdpComponentTable[MAX_KD_COMPONENT_TABLE_ENTRIES]; -ULONG KdComponentTableEntries = 0; +VOID NTAPI PspDumpThreads(BOOLEAN SystemThreads); +#if 0 ULONG Kd_DEFAULT_MASK = 1 << DPFLTR_ERROR_LEVEL; +#endif /* PRIVATE FUNCTIONS *********************************************************/ @@ -50,8 +72,19 @@ KdpServiceDispatcher(ULONG Service, switch (Service) { case BREAKPOINT_PRINT: /* DbgPrint */ - Result = KdpPrintString(Buffer1, Buffer1Length, PreviousMode); + { + /* Call KDBG */ + BOOLEAN Handled; + Result = KdpPrint(MAXULONG, + DPFLTR_INFO_LEVEL, + (PCHAR)Buffer1, + (USHORT)Buffer1Length, + PreviousMode, + NULL, // TrapFrame, + NULL, // ExceptionFrame, + &Handled); break; + } #if DBG case ' soR': /* ROS-INTERNAL */ @@ -144,14 +177,20 @@ KdpEnterDebuggerException(IN PKTRAP_FRAME TrapFrame, /* Check if this is a debug print */ if (ExceptionCommand == BREAKPOINT_PRINT) { - /* Print the string */ - KdpServiceDispatcher(BREAKPOINT_PRINT, - (PVOID)ExceptionRecord->ExceptionInformation[1], - ExceptionRecord->ExceptionInformation[2], - PreviousMode); - - /* Return success */ - KeSetContextReturnRegister(Context, STATUS_SUCCESS); + /* Call KDBG */ + NTSTATUS ReturnStatus; + BOOLEAN Handled; + ReturnStatus = KdpPrint((ULONG)KdpGetParameterThree(Context), + (ULONG)KdpGetParameterFour(Context), + (PCHAR)ExceptionRecord->ExceptionInformation[1], + (USHORT)ExceptionRecord->ExceptionInformation[2], + PreviousMode, + TrapFrame, + ExceptionFrame, + &Handled); + + /* Update the return value for the caller */ + KeSetContextReturnRegister(Context, ReturnStatus); } #ifdef KDBG else if (ExceptionCommand == BREAKPOINT_LOAD_SYMBOLS) @@ -168,7 +207,7 @@ KdpEnterDebuggerException(IN PKTRAP_FRAME TrapFrame, ProbeForRead(SymbolsInfo, sizeof(*SymbolsInfo), 1); - RtlCopyMemory(&CapturedSymbolsInfo, + KdpMoveMemory(&CapturedSymbolsInfo, SymbolsInfo, sizeof(*SymbolsInfo)); SymbolsInfo = &CapturedSymbolsInfo; @@ -191,27 +230,18 @@ KdpEnterDebuggerException(IN PKTRAP_FRAME TrapFrame, } else if (ExceptionCommand == BREAKPOINT_PROMPT) { - ULONG ReturnValue; - LPSTR OutString; - USHORT OutStringLength; - - /* Get the response string and length */ - OutString = (LPSTR)Context->Ebx; - OutStringLength = (USHORT)Context->Edi; - /* Call KDBG */ - ReturnValue = KdpPrompt((LPSTR)ExceptionRecord-> - ExceptionInformation[1], - (USHORT)ExceptionRecord-> - ExceptionInformation[2], - OutString, - OutStringLength, - PreviousMode, - TrapFrame, - ExceptionFrame); - - /* Return the number of characters that we received */ - Context->Eax = ReturnValue; + ULONG ReturnLength; + ReturnLength = KdpPrompt((PCHAR)ExceptionRecord->ExceptionInformation[1], + (USHORT)ExceptionRecord->ExceptionInformation[2], + (PCHAR)KdpGetParameterThree(Context), + (USHORT)KdpGetParameterFour(Context), + PreviousMode, + TrapFrame, + ExceptionFrame); + + /* Update the return value for the caller */ + KeSetContextReturnRegister(Context, ReturnLength); } #endif @@ -274,6 +304,20 @@ KdUpdateDataBlock(VOID) { } +BOOLEAN +NTAPI +KdEnterDebugger(IN PKTRAP_FRAME TrapFrame, + IN PKEXCEPTION_FRAME ExceptionFrame) +{ + return FALSE; +} + +VOID +NTAPI +KdExitDebugger(IN BOOLEAN Enable) +{ +} + /* * @implemented */ @@ -381,91 +425,6 @@ KdChangeOption(IN KD_OPTION Option, return STATUS_NOT_IMPLEMENTED; } - -NTSTATUS -NTAPI -NtQueryDebugFilterState(IN ULONG ComponentId, - IN ULONG Level) -{ - ULONG i; - - /* Convert Level to mask if it isn't already one */ - if (Level < 32) - Level = 1 << Level; - - /* Check if it is not the default component */ - if (ComponentId != MAXULONG) - { - /* No, search for an existing entry in the table */ - for (i = 0; i < KdComponentTableEntries; i++) - { - /* Check if it is the right component */ - if (ComponentId == KdpComponentTable[i].ComponentId) - { - /* Check if mask are matching */ - return (Level & KdpComponentTable[i].Level) ? TRUE : FALSE; - } - } - } - - /* Entry not found in the table, use default mask */ - return (Level & Kd_DEFAULT_MASK) ? TRUE : FALSE; -} - -NTSTATUS -NTAPI -NtSetDebugFilterState(IN ULONG ComponentId, - IN ULONG Level, - IN BOOLEAN State) -{ - ULONG i; - - /* Convert Level to mask if it isn't already one */ - if (Level < 32) - Level = 1 << Level; - Level &= ~DPFLTR_MASK; - - /* Check if it is the default component */ - if (ComponentId == MAXULONG) - { - /* Yes, modify the default mask */ - if (State) - Kd_DEFAULT_MASK |= Level; - else - Kd_DEFAULT_MASK &= ~Level; - - return STATUS_SUCCESS; - } - - /* Search for an existing entry */ - for (i = 0; i < KdComponentTableEntries; i++ ) - { - if (ComponentId == KdpComponentTable[i].ComponentId) - break; - } - - /* Check if we have found an existing entry */ - if (i == KdComponentTableEntries) - { - /* Check if we have enough space in the table */ - if (i == MAX_KD_COMPONENT_TABLE_ENTRIES) - return STATUS_INVALID_PARAMETER_1; - - /* Add a new entry */ - ++KdComponentTableEntries; - KdpComponentTable[i].ComponentId = ComponentId; - KdpComponentTable[i].Level = Kd_DEFAULT_MASK; - } - - /* Update entry table */ - if (State) - KdpComponentTable[i].Level |= Level; - else - KdpComponentTable[i].Level &= ~Level; - - return STATUS_SUCCESS; -} - /* * @unimplemented */ diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 5c48a1e767e..e12ac7e5353 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -13,6 +13,8 @@ #define NDEBUG #include <debug.h> +VOID NTAPI PspDumpThreads(BOOLEAN SystemThreads); + /* PRIVATE FUNCTIONS *********************************************************/ VOID @@ -121,6 +123,8 @@ KdpCopyMemoryChunks( return RemainingLength == 0 ? STATUS_SUCCESS : STATUS_UNSUCCESSFUL; } +#ifdef _WINKD_ + VOID NTAPI KdpQueryMemory(IN PDBGKD_MANIPULATE_STATE64 State, @@ -2118,8 +2122,12 @@ KdDisableDebuggerWithLock(IN BOOLEAN NeedLock) return STATUS_SUCCESS; } +#endif // _WINKD_ + /* PUBLIC FUNCTIONS **********************************************************/ +#ifdef _WINKD_ + /* * @implemented */ @@ -2157,15 +2165,40 @@ KdSystemDebugControl( _In_ KPROCESSOR_MODE PreviousMode) { /* Handle some internal commands */ - if (Command == ' soR') + switch (Command) { - switch ((ULONG_PTR)InputBuffer) +#if DBG + case ' soR': /* ROS-INTERNAL */ { - case 0x24: - MmDumpArmPfnDatabase(FALSE); - break; + switch ((ULONG_PTR)InputBuffer) + { + case 0x21: // DumpAllThreads: + PspDumpThreads(TRUE); + break; + + case 0x22: // DumpUserThreads: + PspDumpThreads(FALSE); + break; + + case 0x24: // KdSpare3: + MmDumpArmPfnDatabase(FALSE); + break; + + default: + break; + } + return STATUS_SUCCESS; } - return STATUS_SUCCESS; + + /* Special case for stack frame dumps */ + case 'DsoR': + { + KeRosDumpStackFrames((PULONG)InputBuffer, InputBufferLength); + break; + } +#endif + default: + break; } /* Local kernel debugging is not yet supported */ @@ -2291,6 +2324,8 @@ KdRefreshDebuggerNotPresent(VOID) return DebuggerNotPresent; } +#endif // _WINKD_ + /* * @implemented */ diff --git a/ntoskrnl/kd64/kddata.c b/ntoskrnl/kd64/kddata.c index 5576c405842..23887d165cf 100644 --- a/ntoskrnl/kd64/kddata.c +++ b/ntoskrnl/kd64/kddata.c @@ -71,12 +71,15 @@ BOOLEAN KdpContextSent; // // Debug Trap Handlers // +#ifdef _WINKD_ PKDEBUG_ROUTINE KiDebugRoutine = KdpStub; PKDEBUG_SWITCH_ROUTINE KiDebugSwitchRoutine; +#endif // // Debugger Configuration Settings // +#ifdef _WINKD_ BOOLEAN KdBreakAfterSymbolLoad; BOOLEAN KdPitchDebugger; BOOLEAN KdDebuggerNotPresent; @@ -89,6 +92,7 @@ BOOLEAN KdpDebuggerStructuresInitialized; BOOLEAN KdEnteredDebugger; ULONG KdDisableCount; LARGE_INTEGER KdPerformanceCounterRate; +#endif // // Breakpoint Data diff --git a/ntoskrnl/kd64/kdprint.c b/ntoskrnl/kd64/kdprint.c index 0389f32e39b..4d35bf6df76 100644 --- a/ntoskrnl/kd64/kdprint.c +++ b/ntoskrnl/kd64/kdprint.c @@ -15,6 +15,8 @@ /* FUNCTIONS *****************************************************************/ +#ifdef _WINKD_ + BOOLEAN NTAPI KdpPrintString( @@ -210,6 +212,23 @@ KdpSymbol(IN PSTRING DllPath, KdExitDebugger(Enable); } +#else + +extern +BOOLEAN +NTAPI +KdpPrintString( + _In_ PSTRING Output); + +extern +BOOLEAN +NTAPI +KdpPromptString( + _In_ PSTRING PromptString, + _In_ PSTRING ResponseString); + +#endif // _WINKD_ + USHORT NTAPI KdpPrompt( @@ -262,7 +281,7 @@ KdpPrompt( /* Setup the prompt and response buffers */ PromptBuffer.Buffer = PromptString; - PromptBuffer.Length = PromptLength; + PromptBuffer.Length = PromptBuffer.MaximumLength = PromptLength; ResponseBuffer.Buffer = SafeResponseString; ResponseBuffer.Length = 0; ResponseBuffer.MaximumLength = MaximumResponseLength; @@ -322,7 +341,7 @@ KdpPrint( NTSTATUS Status; BOOLEAN Enable; STRING OutputString; - PVOID CapturedString; + CHAR CapturedString[512]; /* Assume failure */ *Handled = FALSE; @@ -350,7 +369,7 @@ KdpPrint( } /* Normalize the length */ - Length = min(Length, 512); + Length = min(Length, sizeof(CapturedString)); /* Check if we need to verify the string */ if (PreviousMode != KernelMode) @@ -360,7 +379,6 @@ KdpPrint( { /* Probe and capture the string */ ProbeForRead(String, Length, 1); - CapturedString = alloca(Length); KdpMoveMemory(CapturedString, String, Length); String = CapturedString; } @@ -374,7 +392,7 @@ KdpPrint( /* Setup the output string */ OutputString.Buffer = String; - OutputString.Length = Length; + OutputString.Length = OutputString.MaximumLength = Length; /* Log the print */ //KdLogDbgPrint(&OutputString); @@ -425,12 +443,12 @@ KdpDprintf( sizeof(Buffer), Format, ap); + va_end(ap); /* Set it up */ String.Buffer = Buffer; - String.Length = Length + 1; + String.Length = String.MaximumLength = Length; /* Send it to the debugger directly */ KdpPrintString(&String); - va_end(ap); } diff --git a/ntoskrnl/kdbg/kdb.c b/ntoskrnl/kdbg/kdb.c index 5e7f5e249fc..d2a890276fe 100644 --- a/ntoskrnl/kdbg/kdb.c +++ b/ntoskrnl/kdbg/kdb.c @@ -1723,89 +1723,6 @@ KdbpGetCommandLineSettings( } } -/* - * Copied from ntoskrnl/kd64/kdapi.c - */ -NTSTATUS -NTAPI -KdpCopyMemoryChunks(IN ULONG64 Address, - IN PVOID Buffer, - IN ULONG TotalSize, - IN ULONG ChunkSize, - IN ULONG Flags, - OUT PULONG ActualSize OPTIONAL) -{ - NTSTATUS Status; - ULONG RemainingLength, CopyChunk; - - /* Check if we didn't get a chunk size or if it is too big */ - if (ChunkSize == 0) - { - /* Default to 4 byte chunks */ - ChunkSize = 4; - } - else if (ChunkSize > MMDBG_COPY_MAX_SIZE) - { - /* Normalize to maximum size */ - ChunkSize = MMDBG_COPY_MAX_SIZE; - } - - /* Copy the whole range in aligned chunks */ - RemainingLength = TotalSize; - CopyChunk = 1; - while (RemainingLength > 0) - { - /* - * Determine the best chunk size for this round. - * The ideal size is aligned, isn't larger than the - * the remaining length and respects the chunk limit. - */ - while (((CopyChunk * 2) <= RemainingLength) && - (CopyChunk < ChunkSize) && - ((Address & ((CopyChunk * 2) - 1)) == 0)) - { - /* Increase it */ - CopyChunk *= 2; - } - - /* - * The chunk size can be larger than the remaining size if this - * isn't the first round, so check if we need to shrink it back. - */ - while (CopyChunk > RemainingLength) - { - /* Shrink it */ - CopyChunk /= 2; - } - - /* Do the copy */ - Status = MmDbgCopyMemory(Address, - Buffer, - CopyChunk, - Flags); - if (!NT_SUCCESS(Status)) - { - /* Copy failed, break out */ - break; - } - - /* Update pointers and length for the next run */ - Address = Address + CopyChunk; - Buffer = (PVOID)((ULONG_PTR)Buffer + CopyChunk); - RemainingLength = RemainingLength - CopyChunk; - } - - /* We may have modified executable code, flush the instruction cache */ - KeSweepICache((PVOID)(ULONG_PTR)Address, TotalSize); - - /* - * Return the size we managed to copy and return - * success if we could copy the whole range. - */ - if (ActualSize) *ActualSize = TotalSize - RemainingLength; - return RemainingLength == 0 ? STATUS_SUCCESS : STATUS_UNSUCCESSFUL; -} - NTSTATUS KdbpSafeReadMemory( OUT PVOID Dest, diff --git a/ntoskrnl/kdbg/kdb_cli.c b/ntoskrnl/kdbg/kdb_cli.c index 5e7d40d230f..8debef5dca9 100644 --- a/ntoskrnl/kdbg/kdb_cli.c +++ b/ntoskrnl/kdbg/kdb_cli.c @@ -133,6 +133,8 @@ extern volatile ULONG KdpDmesgCurrentPosition; extern volatile ULONG KdpDmesgFreeBytes; extern volatile ULONG KdbDmesgTotalWritten; +STRING KdbPromptString = RTL_CONSTANT_STRING("kdb:> "); + static const struct { PCHAR Name; @@ -476,7 +478,7 @@ KdbpCmdEvalExpression( } /* Evaluate the expression */ - Ok = KdbpEvaluateExpression(Argv[1], sizeof("kdb:> ")-1 + (Argv[1]-Argv[0]), &Result); + Ok = KdbpEvaluateExpression(Argv[1], KdbPromptString.Length + (Argv[1]-Argv[0]), &Result); if (Ok) { if (Result > 0x00000000ffffffffLL) @@ -785,7 +787,7 @@ KdbpCmdDisassembleX( /* Evaluate the expression */ if (Argc > 1) { - if (!KdbpEvaluateExpression(Argv[1], sizeof("kdb:> ")-1 + (Argv[1]-Argv[0]), &Result)) + if (!KdbpEvaluateExpression(Argv[1], KdbPromptString.Length + (Argv[1]-Argv[0]), &Result)) return TRUE; if (Result > (ULONGLONG)(~((ULONG_PTR)0))) @@ -1164,7 +1166,7 @@ KdbpCmdBackTrace( Argv[1]++; /* Evaluate the expression */ - if (!KdbpEvaluateExpression(Argv[1], sizeof("kdb:> ")-1 + (Argv[1]-Argv[0]), &Result)) + if (!KdbpEvaluateExpression(Argv[1], KdbPromptString.Length + (Argv[1]-Argv[0]), &Result)) return TRUE; if (Result > (ULONGLONG)(~((ULONG_PTR)0))) @@ -1557,7 +1559,7 @@ KdbpCmdBreakPoint(ULONG Argc, PCHAR Argv[]) /* Evaluate the address expression */ if (!KdbpEvaluateExpression(Argv[AddressArgIndex], - sizeof("kdb:> ")-1 + (Argv[AddressArgIndex]-Argv[0]), + KdbPromptString.Length + (Argv[AddressArgIndex]-Argv[0]), &Result)) { return TRUE; @@ -1922,7 +1924,7 @@ KdbpCmdMod( Argv[Argc][strlen(Argv[Argc])] = ' '; /* Evaluate the expression */ - if (!KdbpEvaluateExpression(Argv[1], sizeof("kdb:> ")-1 + (Argv[1]-Argv[0]), &Result)) + if (!KdbpEvaluateExpression(Argv[1], KdbPromptString.Length + (Argv[1]-Argv[0]), &Result)) { return TRUE; } @@ -3651,7 +3653,7 @@ KdbpCliMainLoop( KdbNumberOfRowsPrinted = KdbNumberOfColsPrinted = 0; /* Print the prompt */ - KdbpPrint("kdb:> "); + KdbpPrint(KdbPromptString.Buffer); /* Read a command and remember it */ KdbpReadCommand(Command, sizeof (Command)); @@ -3814,204 +3816,3 @@ KdbpCliInit(VOID) ExFreePool(FileBuffer); } - -VOID -NTAPI -KdpSerialDebugPrint( - LPSTR Message, - ULONG Length -); - -STRING KdpPromptString = RTL_CONSTANT_STRING("kdb:> "); -extern KSPIN_LOCK KdpSerialSpinLock; - -USHORT -NTAPI -KdpPrompt( - _In_reads_bytes_(InStringLength) PCHAR UnsafeInString, - _In_ USHORT InStringLength, - _Out_writes_bytes_(OutStringLength) PCHAR UnsafeOutString, - _In_ USHORT OutStringLength, - _In_ KPROCESSOR_MODE PreviousMode, - _In_ PKTRAP_FRAME TrapFrame, - _In_ PKEXCEPTION_FRAME ExceptionFrame) -{ - USHORT i; - CHAR Response; - ULONG DummyScanCode; - KIRQL OldIrql; - PCHAR InString; - PCHAR OutString; - CHAR InStringBuffer[512]; - CHAR OutStringBuffer[512]; - - /* Normalize the lengths */ - InStringLength = min(InStringLength, - sizeof(InStringBuffer)); - OutStringLength = min(OutStringLength, - sizeof(OutStringBuffer)); - - /* Check if we need to verify the string */ - if (PreviousMode != KernelMode) - { - /* Handle user-mode buffers safely */ - _SEH2_TRY - { - /* Probe the prompt */ - ProbeForRead(UnsafeInString, - InStringLength, - 1); - - /* Capture prompt */ - InString = InStringBuffer; - RtlCopyMemory(InString, - UnsafeInString, - InStringLength); - - /* Probe and make room for response */ - ProbeForWrite(UnsafeOutString, - OutStringLength, - 1); - OutString = OutStringBuffer; - } - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) - { - /* Bad string pointer, bail out */ - _SEH2_YIELD(return 0); - } - _SEH2_END; - } - else - { - InString = UnsafeInString; - OutString = UnsafeOutString; - } - - /* Acquire the printing spinlock without waiting at raised IRQL */ - while (TRUE) - { - /* Wait when the spinlock becomes available */ - while (!KeTestSpinLock(&KdpSerialSpinLock)); - - /* Spinlock was free, raise IRQL */ - KeRaiseIrql(HIGH_LEVEL, &OldIrql); - - /* Try to get the spinlock */ - if (KeTryToAcquireSpinLockAtDpcLevel(&KdpSerialSpinLock)) - break; - - /* Someone else got the spinlock, lower IRQL back */ - KeLowerIrql(OldIrql); - } - - /* Loop the string to send */ - for (i = 0; i < InStringLength; i++) - { - /* Print it to serial */ - KdPortPutByteEx(&SerialPortInfo, *(PCHAR)(InString + i)); - } - - /* Print a new line for log neatness */ - KdPortPutByteEx(&SerialPortInfo, '\r'); - KdPortPutByteEx(&SerialPortInfo, '\n'); - - /* Print the kdb prompt */ - for (i = 0; i < KdpPromptString.Length; i++) - { - /* Print it to serial */ - KdPortPutByteEx(&SerialPortInfo, - *(KdpPromptString.Buffer + i)); - } - - if (!(KdbDebugState & KD_DEBUG_KDSERIAL)) - KbdDisableMouse(); - - /* Loop the whole string */ - for (i = 0; i < OutStringLength; i++) - { - /* Check if this is serial debugging mode */ - if (KdbDebugState & KD_DEBUG_KDSERIAL) - { - /* Get the character from serial */ - do - { - Response = KdbpTryGetCharSerial(MAXULONG); - } while (Response == -1); - } - else - { - /* Get the response from the keyboard */ - do - { - Response = KdbpTryGetCharKeyboard(&DummyScanCode, MAXULONG); - } while (Response == -1); - } - - /* Check for return */ - if (Response == '\r') - { - /* - * We might need to discard the next '\n'. - * Wait a bit to make sure we receive it. - */ - KeStallExecutionProcessor(100000); - - /* Check the mode */ - if (KdbDebugState & KD_DEBUG_KDSERIAL) - { - /* Read and discard the next character, if any */ - KdbpTryGetCharSerial(5); - } - else - { - /* Read and discard the next character, if any */ - KdbpTryGetCharKeyboard(&DummyScanCode, 5); - } - - /* - * Null terminate the output string -- documentation states that - * DbgPrompt does not null terminate, but it does - */ - *(PCHAR)(OutString + i) = 0; - break; - } - - /* Write it back and print it to the log */ - *(PCHAR)(OutString + i) = Response; - KdPortPutByteEx(&SerialPortInfo, Response); - } - - if (!(KdbDebugState & KD_DEBUG_KDSERIAL)) - KbdEnableMouse(); - - /* Print a new line */ - KdPortPutByteEx(&SerialPortInfo, '\r'); - KdPortPutByteEx(&SerialPortInfo, '\n'); - - /* Release spinlock */ - KiReleaseSpinLock(&KdpSerialSpinLock); - - /* Lower IRQL back */ - KeLowerIrql(OldIrql); - - /* Copy back response if required */ - if (PreviousMode != KernelMode) - { - _SEH2_TRY - { - /* Safely copy back response to user mode */ - RtlCopyMemory(UnsafeOutString, - OutString, - i); - } - _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) - { - /* String became invalid after we exited, fail */ - _SEH2_YIELD(return 0); - } - _SEH2_END; - } - - /* Return the length */ - return i; -} diff --git a/ntoskrnl/ke/powerpc/ppc_irq.c b/ntoskrnl/ke/powerpc/ppc_irq.c index 772f06b7c79..d516861bd53 100644 --- a/ntoskrnl/ke/powerpc/ppc_irq.c +++ b/ntoskrnl/ke/powerpc/ppc_irq.c @@ -745,7 +745,10 @@ KeDisableInterrupts(VOID) ULONG NTAPI -KdpServiceDispatcher(ULONG Service, PCHAR Buffer, ULONG Length); +KdpServiceDispatcher(ULONG Service, + PVOID Buffer1, + ULONG Buffer1Length, + KPROCESSOR_MODE PreviousMode); typedef ULONG (*PSYSCALL_FUN) (ULONG,ULONG,ULONG,ULONG,ULONG,ULONG,ULONG,ULONG,ULONG,ULONG); @@ -769,7 +772,8 @@ KiSystemService(ppc_trap_frame_t *trap_frame) trap_frame->gpr[3] = KdpServiceDispatcher (trap_frame->gpr[3], (PCHAR)trap_frame->gpr[4], - trap_frame->gpr[5]); + trap_frame->gpr[5], + UserMode /*KernelMode*/); break; case 0xf0000: /* Thread startup */ /* XXX how to use UserThread (gpr[6]) */ diff --git a/ntoskrnl/ntos.cmake b/ntoskrnl/ntos.cmake index 9d4d6685408..ffe14d67078 100644 --- a/ntoskrnl/ntos.cmake +++ b/ntoskrnl/ntos.cmake @@ -405,7 +405,10 @@ if(NOT _WINKD_) ${REACTOS_SOURCE_DIR}/ntoskrnl/kd/wrappers/kdbg.c ${REACTOS_SOURCE_DIR}/ntoskrnl/kd/kdinit.c ${REACTOS_SOURCE_DIR}/ntoskrnl/kd/kdio.c - ${REACTOS_SOURCE_DIR}/ntoskrnl/kd/kdmain.c) + ${REACTOS_SOURCE_DIR}/ntoskrnl/kd/kdmain.c + ${REACTOS_SOURCE_DIR}/ntoskrnl/kd64/kdapi.c + ${REACTOS_SOURCE_DIR}/ntoskrnl/kd64/kddata.c + ${REACTOS_SOURCE_DIR}/ntoskrnl/kd64/kdprint.c) else() # _WINKD_

1 0

[reactos] 04/06: [NTOS:KD64] Some code formatting + add SAL2 annotations to the functions that are going to be involved in the next commit.
by Hermès Bélusca-Maïto 17 Nov '19

17 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=54c03f6965ec8fdca52ac… commit 54c03f6965ec8fdca52aca75c3baed6e959fb07b Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 17 22:28:42 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 17 23:21:53 2019 +0100 [NTOS:KD64] Some code formatting + add SAL2 annotations to the functions that are going to be involved in the next commit. + s/ReturnStatus/Status/ , and get rid of Win32 LPSTR and replace by PCHAR (since the concerned code deals with counted strings). --- ntoskrnl/include/internal/kd64.h | 58 +++++++++++----------- ntoskrnl/kd64/kdapi.c | 49 +++++++++---------- ntoskrnl/kd64/kdprint.c | 101 ++++++++++++++++++--------------------- ntoskrnl/kd64/kdtrap.c | 21 ++++---- sdk/include/ndk/kdfuncs.h | 14 +++--- 5 files changed, 115 insertions(+), 128 deletions(-) diff --git a/ntoskrnl/include/internal/kd64.h b/ntoskrnl/include/internal/kd64.h index f1fa443c8da..bff0a3a872d 100644 --- a/ntoskrnl/include/internal/kd64.h +++ b/ntoskrnl/include/internal/kd64.h @@ -12,9 +12,9 @@ // Default size of the DbgPrint log buffer // #if DBG -#define KD_DEFAULT_LOG_BUFFER_SIZE 0x8000 +#define KD_DEFAULT_LOG_BUFFER_SIZE 0x8000 #else -#define KD_DEFAULT_LOG_BUFFER_SIZE 0x1000 +#define KD_DEFAULT_LOG_BUFFER_SIZE 0x1000 #endif // @@ -211,26 +211,26 @@ KdDisableDebuggerWithLock( NTSTATUS NTAPI KdpPrint( - IN ULONG ComponentId, - IN ULONG Level, - IN LPSTR String, - IN USHORT Length, - IN KPROCESSOR_MODE PreviousMode, - IN PKTRAP_FRAME TrapFrame, - IN PKEXCEPTION_FRAME ExceptionFrame, - OUT PBOOLEAN Handled + _In_ ULONG ComponentId, + _In_ ULONG Level, + _In_reads_bytes_(Length) PCHAR String, + _In_ USHORT Length, + _In_ KPROCESSOR_MODE PreviousMode, + _In_ PKTRAP_FRAME TrapFrame, + _In_ PKEXCEPTION_FRAME ExceptionFrame, + _Out_ PBOOLEAN Handled ); USHORT NTAPI KdpPrompt( - IN LPSTR PromptString, - IN USHORT PromptLength, - OUT LPSTR ResponseString, - IN USHORT MaximumResponseLength, - IN KPROCESSOR_MODE PreviousMode, - IN PKTRAP_FRAME TrapFrame, - IN PKEXCEPTION_FRAME ExceptionFrame + _In_reads_bytes_(PromptLength) PCHAR PromptString, + _In_ USHORT PromptLength, + _Out_writes_bytes_(MaximumResponseLength) PCHAR ResponseString, + _In_ USHORT MaximumResponseLength, + _In_ KPROCESSOR_MODE PreviousMode, + _In_ PKTRAP_FRAME TrapFrame, + _In_ PKEXCEPTION_FRAME ExceptionFrame ); VOID @@ -345,12 +345,12 @@ KdpAllowDisable( NTSTATUS NTAPI KdpCopyMemoryChunks( - IN ULONG64 Address, - IN PVOID Buffer, - IN ULONG TotalSize, - IN ULONG ChunkSize, - IN ULONG Flags, - OUT PULONG ActualSize OPTIONAL + _In_ ULONG64 Address, + _In_ PVOID Buffer, + _In_ ULONG TotalSize, + _In_ ULONG ChunkSize, + _In_ ULONG Flags, + _Out_opt_ PULONG ActualSize ); // @@ -359,16 +359,16 @@ KdpCopyMemoryChunks( VOID NTAPI KdpMoveMemory( - IN PVOID Destination, - IN PVOID Source, - IN SIZE_T Length + _In_ PVOID Destination, + _In_ PVOID Source, + _In_ SIZE_T Length ); VOID NTAPI KdpZeroMemory( - IN PVOID Destination, - IN SIZE_T Length + _In_ PVOID Destination, + _In_ SIZE_T Length ); // @@ -510,7 +510,7 @@ KdpSysCheckLowMemory( VOID __cdecl KdpDprintf( - IN PCHAR Format, + _In_ PCHAR Format, ... ); diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 1f0066d8ffe..5c48a1e767e 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -17,9 +17,10 @@ VOID NTAPI -KdpMoveMemory(IN PVOID Destination, - IN PVOID Source, - IN SIZE_T Length) +KdpMoveMemory( + _In_ PVOID Destination, + _In_ PVOID Source, + _In_ SIZE_T Length) { PCHAR DestinationBytes, SourceBytes; @@ -31,8 +32,9 @@ KdpMoveMemory(IN PVOID Destination, VOID NTAPI -KdpZeroMemory(IN PVOID Destination, - IN SIZE_T Length) +KdpZeroMemory( + _In_ PVOID Destination, + _In_ SIZE_T Length) { PCHAR DestinationBytes; @@ -43,12 +45,13 @@ KdpZeroMemory(IN PVOID Destination, NTSTATUS NTAPI -KdpCopyMemoryChunks(IN ULONG64 Address, - IN PVOID Buffer, - IN ULONG TotalSize, - IN ULONG ChunkSize, - IN ULONG Flags, - OUT PULONG ActualSize OPTIONAL) +KdpCopyMemoryChunks( + _In_ ULONG64 Address, + _In_ PVOID Buffer, + _In_ ULONG TotalSize, + _In_ ULONG ChunkSize, + _In_ ULONG Flags, + _Out_opt_ PULONG ActualSize) { NTSTATUS Status; ULONG RemainingLength, CopyChunk; @@ -94,10 +97,7 @@ KdpCopyMemoryChunks(IN ULONG64 Address, } /* Do the copy */ - Status = MmDbgCopyMemory(Address, - Buffer, - CopyChunk, - Flags); + Status = MmDbgCopyMemory(Address, Buffer, CopyChunk, Flags); if (!NT_SUCCESS(Status)) { /* Copy failed, break out */ @@ -2147,15 +2147,16 @@ KdDisableDebugger(VOID) */ NTSTATUS NTAPI -KdSystemDebugControl(IN SYSDBG_COMMAND Command, - IN PVOID InputBuffer, - IN ULONG InputBufferLength, - OUT PVOID OutputBuffer, - IN ULONG OutputBufferLength, - IN OUT PULONG ReturnLength, - IN KPROCESSOR_MODE PreviousMode) +KdSystemDebugControl( + _In_ SYSDBG_COMMAND Command, + _In_ PVOID InputBuffer, + _In_ ULONG InputBufferLength, + _Out_ PVOID OutputBuffer, + _In_ ULONG OutputBufferLength, + _Inout_ PULONG ReturnLength, + _In_ KPROCESSOR_MODE PreviousMode) { - /* handle sime internal commands */ + /* Handle some internal commands */ if (Command == ' soR') { switch ((ULONG_PTR)InputBuffer) @@ -2269,7 +2270,7 @@ KdRefreshDebuggerNotPresent(VOID) /* Check if the debugger is completely disabled */ if (KdPitchDebugger) { - /* Don't try to refresh then -- fail early */ + /* Don't try to refresh then, fail early */ return TRUE; } diff --git a/ntoskrnl/kd64/kdprint.c b/ntoskrnl/kd64/kdprint.c index 8f721e80887..0389f32e39b 100644 --- a/ntoskrnl/kd64/kdprint.c +++ b/ntoskrnl/kd64/kdprint.c @@ -17,7 +17,8 @@ BOOLEAN NTAPI -KdpPrintString(IN PSTRING Output) +KdpPrintString( + _In_ PSTRING Output) { STRING Data, Header; DBGKD_DEBUG_IO DebugIo; @@ -57,8 +58,9 @@ KdpPrintString(IN PSTRING Output) BOOLEAN NTAPI -KdpPromptString(IN PSTRING PromptString, - IN PSTRING ResponseString) +KdpPromptString( + _In_ PSTRING PromptString, + _In_ PSTRING ResponseString) { STRING Data, Header; DBGKD_DEBUG_IO DebugIo; @@ -210,19 +212,20 @@ KdpSymbol(IN PSTRING DllPath, USHORT NTAPI -KdpPrompt(IN LPSTR PromptString, - IN USHORT PromptLength, - OUT PCHAR ResponseString, - IN USHORT MaximumResponseLength, - IN KPROCESSOR_MODE PreviousMode, - IN PKTRAP_FRAME TrapFrame, - IN PKEXCEPTION_FRAME ExceptionFrame) +KdpPrompt( + _In_reads_bytes_(PromptLength) PCHAR PromptString, + _In_ USHORT PromptLength, + _Out_writes_bytes_(MaximumResponseLength) PCHAR ResponseString, + _In_ USHORT MaximumResponseLength, + _In_ KPROCESSOR_MODE PreviousMode, + _In_ PKTRAP_FRAME TrapFrame, + _In_ PKEXCEPTION_FRAME ExceptionFrame) { STRING PromptBuffer, ResponseBuffer; BOOLEAN Enable, Resend; + PCHAR SafeResponseString; CHAR CapturedPrompt[512]; CHAR SafeResponseBuffer[512]; - PCHAR SafeResponseString; /* Normalize the lengths */ PromptLength = min(PromptLength, @@ -236,26 +239,18 @@ KdpPrompt(IN LPSTR PromptString, /* Handle user-mode buffers safely */ _SEH2_TRY { - /* Probe the prompt */ - ProbeForRead(PromptString, - PromptLength, - 1); - - /* Capture prompt */ - KdpMoveMemory(CapturedPrompt, - PromptString, - PromptLength); + /* Probe and capture the prompt */ + ProbeForRead(PromptString, PromptLength, 1); + KdpMoveMemory(CapturedPrompt, PromptString, PromptLength); PromptString = CapturedPrompt; - /* Probe and make room for response */ - ProbeForWrite(ResponseString, - MaximumResponseLength, - 1); + /* Probe and make room for the response */ + ProbeForWrite(ResponseString, MaximumResponseLength, 1); SafeResponseString = SafeResponseBuffer; } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { - /* Bad string pointer, bail out */ + /* Bad string pointer, bail out */ _SEH2_YIELD(return 0); } _SEH2_END; @@ -265,7 +260,7 @@ KdpPrompt(IN LPSTR PromptString, SafeResponseString = ResponseString; } - /* Setup the prompt and response buffers */ + /* Setup the prompt and response buffers */ PromptBuffer.Buffer = PromptString; PromptBuffer.Length = PromptLength; ResponseBuffer.Buffer = SafeResponseString; @@ -290,19 +285,19 @@ KdpPrompt(IN LPSTR PromptString, /* Exit the debugger */ KdExitDebugger(Enable); - /* Copy back response if required */ + /* Copy back the response if required */ if (PreviousMode != KernelMode) { _SEH2_TRY { - /* Safely copy back response to user mode */ + /* Safely copy back the response to user mode */ KdpMoveMemory(ResponseString, ResponseBuffer.Buffer, ResponseBuffer.Length); } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { - /* String became invalid after we exited, fail */ + /* String became invalid after we exited, fail */ _SEH2_YIELD(return 0); } _SEH2_END; @@ -314,16 +309,17 @@ KdpPrompt(IN LPSTR PromptString, NTSTATUS NTAPI -KdpPrint(IN ULONG ComponentId, - IN ULONG Level, - IN LPSTR String, - IN USHORT Length, - IN KPROCESSOR_MODE PreviousMode, - IN PKTRAP_FRAME TrapFrame, - IN PKEXCEPTION_FRAME ExceptionFrame, - OUT PBOOLEAN Handled) +KdpPrint( + _In_ ULONG ComponentId, + _In_ ULONG Level, + _In_reads_bytes_(Length) PCHAR String, + _In_ USHORT Length, + _In_ KPROCESSOR_MODE PreviousMode, + _In_ PKTRAP_FRAME TrapFrame, + _In_ PKEXCEPTION_FRAME ExceptionFrame, + _Out_ PBOOLEAN Handled) { - NTSTATUS ReturnStatus; + NTSTATUS Status; BOOLEAN Enable; STRING OutputString; PVOID CapturedString; @@ -356,27 +352,21 @@ KdpPrint(IN ULONG ComponentId, /* Normalize the length */ Length = min(Length, 512); - /* Check if we need to verify the buffer */ + /* Check if we need to verify the string */ if (PreviousMode != KernelMode) { /* Capture user-mode buffers */ _SEH2_TRY { - /* Probe the string */ - ProbeForRead(String, - Length, - 1); - - /* Capture it */ + /* Probe and capture the string */ + ProbeForRead(String, Length, 1); CapturedString = alloca(Length); - KdpMoveMemory(CapturedString, - String, - Length); + KdpMoveMemory(CapturedString, String, Length); String = CapturedString; } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { - /* Bad pointer, fail the print */ + /* Bad string pointer, bail out */ _SEH2_YIELD(return STATUS_ACCESS_VIOLATION); } _SEH2_END; @@ -404,29 +394,30 @@ KdpPrint(IN ULONG ComponentId, if (KdpPrintString(&OutputString)) { /* User pressed CTRL-C, breakpoint on return */ - ReturnStatus = STATUS_BREAKPOINT; + Status = STATUS_BREAKPOINT; } else { /* String was printed */ - ReturnStatus = STATUS_SUCCESS; + Status = STATUS_SUCCESS; } /* Exit the debugger and return */ KdExitDebugger(Enable); *Handled = TRUE; - return ReturnStatus; + return Status; } VOID __cdecl -KdpDprintf(IN PCHAR Format, - ...) +KdpDprintf( + _In_ PCHAR Format, + ...) { STRING String; - CHAR Buffer[100]; USHORT Length; va_list ap; + CHAR Buffer[100]; /* Format the string */ va_start(ap, Format); diff --git a/ntoskrnl/kd64/kdtrap.c b/ntoskrnl/kd64/kdtrap.c index 91a83de4691..0be83956849 100644 --- a/ntoskrnl/kd64/kdtrap.c +++ b/ntoskrnl/kd64/kdtrap.c @@ -166,7 +166,7 @@ KdpTrap(IN PKTRAP_FRAME TrapFrame, /* Call the worker routine */ ReturnStatus = KdpPrint((ULONG)KdpGetParameterThree(ContextRecord), (ULONG)KdpGetParameterFour(ContextRecord), - (LPSTR)ExceptionRecord->ExceptionInformation[1], + (PCHAR)ExceptionRecord->ExceptionInformation[1], (USHORT)ExceptionRecord->ExceptionInformation[2], PreviousMode, TrapFrame, @@ -174,17 +174,16 @@ KdpTrap(IN PKTRAP_FRAME TrapFrame, &Handled); /* Update the return value for the caller */ - KeSetContextReturnRegister(ContextRecord, - ReturnStatus); + KeSetContextReturnRegister(ContextRecord, ReturnStatus); break; /* DbgPrompt */ case BREAKPOINT_PROMPT: /* Call the worker routine */ - ReturnLength = KdpPrompt((LPSTR)ExceptionRecord->ExceptionInformation[1], + ReturnLength = KdpPrompt((PCHAR)ExceptionRecord->ExceptionInformation[1], (USHORT)ExceptionRecord->ExceptionInformation[2], - (LPSTR)KdpGetParameterThree(ContextRecord), + (PCHAR)KdpGetParameterThree(ContextRecord), (USHORT)KdpGetParameterFour(ContextRecord), PreviousMode, TrapFrame, @@ -205,10 +204,8 @@ KdpTrap(IN PKTRAP_FRAME TrapFrame, case BREAKPOINT_LOAD_SYMBOLS: /* Call the worker routine */ - KdpSymbol((PSTRING)ExceptionRecord-> - ExceptionInformation[1], - (PKD_SYMBOLS_INFO)ExceptionRecord-> - ExceptionInformation[2], + KdpSymbol((PSTRING)ExceptionRecord->ExceptionInformation[1], + (PKD_SYMBOLS_INFO)ExceptionRecord->ExceptionInformation[2], Unload, PreviousMode, ContextRecord, @@ -221,10 +218,8 @@ KdpTrap(IN PKTRAP_FRAME TrapFrame, case BREAKPOINT_COMMAND_STRING: /* Call the worker routine */ - KdpCommandString((PSTRING)ExceptionRecord-> - ExceptionInformation[1], - (PSTRING)ExceptionRecord-> - ExceptionInformation[2], + KdpCommandString((PSTRING)ExceptionRecord->ExceptionInformation[1], + (PSTRING)ExceptionRecord->ExceptionInformation[2], PreviousMode, ContextRecord, TrapFrame, diff --git a/sdk/include/ndk/kdfuncs.h b/sdk/include/ndk/kdfuncs.h index 2d9278f8f80..21681a67674 100644 --- a/sdk/include/ndk/kdfuncs.h +++ b/sdk/include/ndk/kdfuncs.h @@ -33,13 +33,13 @@ Author: NTSTATUS NTAPI KdSystemDebugControl( - SYSDBG_COMMAND Command, - PVOID InputBuffer, - ULONG InputBufferLength, - PVOID OutputBuffer, - ULONG OutputBufferLength, - PULONG ReturnLength, - KPROCESSOR_MODE PreviousMode + _In_ SYSDBG_COMMAND Command, + _In_ PVOID InputBuffer, + _In_ ULONG InputBufferLength, + _Out_ PVOID OutputBuffer, + _In_ ULONG OutputBufferLength, + _Inout_ PULONG ReturnLength, + _In_ KPROCESSOR_MODE PreviousMode ); BOOLEAN

1 0

[reactos] 03/06: [NTOS] Complete the support of Debug Filters. CORE-13529
by Hermès Bélusca-Maïto 17 Nov '19

17 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6c1aac6948626bc7b9046… commit 6c1aac6948626bc7b9046895bdd640b0c0cd1ec1 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 17 17:16:55 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 17 23:21:53 2019 +0100 [NTOS] Complete the support of Debug Filters. CORE-13529 - KD64: Update the list of supported Debug Filter Masks (KdComponentTable) with the more up-to-date one from KDBG, that includes some components that have been added in Vista+, but some of which we also use in ReactOS. - NtQueryDebugFilterState(), NtSetDebugFilterState() and KdpPrint(): Add the Vista+ behaviour or falling back to the DEFAULT component ID settings for unknown Components (compiled in only wheen NTDDI_VERSION >= NTDDI_VISTA). + Remove redundant comments and update these functions with SAL2 annotations. - KDBG: Add extra documentation for the debug filter components list. - CONFIG: Load all the supported Debug Filter Masks settings from the registry. --- ntoskrnl/config/cmdata.c | 1135 ++++++++++++++++++++++++++++++++++---- ntoskrnl/include/internal/kd64.h | 165 +++++- ntoskrnl/kd64/kdapi.c | 42 +- ntoskrnl/kd64/kddata.c | 97 +++- ntoskrnl/kd64/kdprint.c | 13 +- ntoskrnl/kdbg/kdb_cli.c | 12 +- sdk/include/ndk/kdfuncs.h | 10 +- 7 files changed, 1351 insertions(+), 123 deletions(-) diff --git a/ntoskrnl/config/cmdata.c b/ntoskrnl/config/cmdata.c index 7a2c6af6c55..7b34fc936cb 100644 --- a/ntoskrnl/config/cmdata.c +++ b/ntoskrnl/config/cmdata.c @@ -145,7 +145,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"ObjectSecurityMode", @@ -153,7 +152,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"LUIDDeviceMapsDisabled", @@ -161,7 +159,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"LSA", L"AuditBaseDirectories", @@ -169,7 +166,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"LSA", L"AuditBaseObjects", @@ -177,7 +173,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"LSA\\audit", L"ProcessAccessesToAudit", @@ -185,7 +180,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"TimeZoneInformation", L"ActiveTimeBias", @@ -193,7 +187,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"TimeZoneInformation", L"Bias", @@ -201,7 +194,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"TimeZoneInformation", L"RealTimeIsUniversal", @@ -209,7 +201,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"GlobalFlag", @@ -217,7 +208,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PagedPoolQuota", @@ -225,7 +215,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"NonPagedPoolQuota", @@ -233,7 +222,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PagingFileQuota", @@ -241,7 +229,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"AllocationPreference", @@ -249,7 +236,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"DynamicMemory", @@ -257,7 +243,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"Mirroring", @@ -265,7 +250,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"SystemViewSize", @@ -273,7 +257,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"SessionImageSize", @@ -281,7 +264,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"SessionPoolSize", @@ -289,7 +271,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PoolUsageMaximum", @@ -297,7 +278,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"MapAllocationFragment", @@ -305,7 +285,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PagedPoolSize", @@ -313,7 +292,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"NonPagedPoolSize", @@ -321,7 +299,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"NonPagedPoolMaximumPercent", @@ -329,7 +306,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"LargeSystemCache", @@ -337,7 +313,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"LargeStackSize", @@ -345,7 +320,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"SystemPages", @@ -353,7 +327,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"LowMemoryThreshold", @@ -361,7 +334,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"HighMemoryThreshold", @@ -369,7 +341,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"DisablePagingExecutive", @@ -377,7 +348,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"ModifiedPageLife", @@ -385,7 +355,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"SecondLevelDataCache", @@ -393,7 +362,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"ClearPageFileAtShutdown", @@ -401,7 +369,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PoolTagSmallTableSize", @@ -409,7 +376,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PoolTagBigTableSize", @@ -417,7 +383,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PoolTag", @@ -425,7 +390,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"PoolTagOverruns", @@ -433,7 +397,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"SnapUnloads", @@ -441,7 +404,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"ProtectNonPagedPool", @@ -449,7 +411,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"TrackLockedPages", @@ -457,7 +418,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"TrackPtes", @@ -465,7 +425,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"VerifyDrivers", @@ -473,7 +432,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &MmVerifyDriverBufferLength, &MmVerifyDriverBufferType }, - { L"Session Manager\\Memory Management", L"VerifyDriverLevel", @@ -481,7 +439,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"VerifyMode", @@ -489,7 +446,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"LargePageMinimum", @@ -497,7 +453,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"EnforceWriteProtection", @@ -505,7 +460,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"MakeLowMemory", @@ -513,7 +467,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"WriteWatch", @@ -521,7 +474,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Memory Management", L"MinimumStackCommitInBytes", @@ -529,7 +481,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Executive", L"AdditionalCriticalWorkerThreads", @@ -537,7 +488,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Executive", L"AdditionalDelayedWorkerThreads", @@ -545,7 +495,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Executive", L"PriorityQuantumMatrix", @@ -553,7 +502,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &DummyData, NULL }, - { L"Session Manager\\Kernel", L"DpcQueueDepth", @@ -561,7 +509,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Kernel", L"MinimumDpcRate", @@ -569,7 +516,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Kernel", L"AdjustDpcThreshold", @@ -577,7 +523,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Kernel", L"IdealDpcRate", @@ -585,7 +530,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Kernel", L"ObUnsecureGlobalNames", @@ -593,7 +537,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &ObpUnsecureGlobalNamesLength, NULL }, - { L"Session Manager\\I/O System", L"CountOperations", @@ -601,7 +544,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\I/O System", L"LargeIrpStackLocations", @@ -609,7 +551,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\I/O System", L"IoVerifierLevel", @@ -617,7 +558,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"ResourceTimeoutCount", @@ -625,7 +565,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"CriticalSectionTimeout", @@ -633,7 +572,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"HeapSegmentReserve", @@ -648,7 +586,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"HeapDeCommitTotalFreeThreshold", @@ -656,7 +593,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"HeapDeCommitFreeBlockThreshold", @@ -664,7 +600,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"ProductOptions", L"ProductType", @@ -672,7 +607,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Terminal Server", L"TSEnabled", @@ -680,7 +614,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Terminal Server", L"TSAppCompat", @@ -697,7 +630,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &CmSuiteBufferLength, &CmSuiteBufferType }, - { L"Windows", L"CSDVersion", @@ -705,7 +637,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Windows", L"CSDReleaseType", @@ -713,7 +644,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Nls\\Language", L"Default", @@ -721,7 +651,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &CmDefaultLanguageIdLength, &CmDefaultLanguageIdType }, - { L"Nls\\Language", L"InstallLanguage", @@ -729,7 +658,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &CmInstallUILanguageIdLength, &CmInstallUILanguageIdType }, - { L"\0\0", L"RegistrySizeLimit", @@ -737,7 +665,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &DummyData, &DummyData }, - { L"Session Manager", L"ForceNpxEmulation", @@ -745,7 +672,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"PowerPolicySimulate", @@ -753,7 +679,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager\\Executive", L"MaxTimeSeparationBeforeCorrect", @@ -761,7 +686,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Windows", L"ShutdownTime", @@ -769,7 +693,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = &DummyData, NULL }, - { L"PriorityControl", L"Win32PrioritySeparation", @@ -777,7 +700,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"EnableTimerWatchdog", @@ -785,7 +707,6 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - { L"Session Manager", L"Debugger Retries", @@ -794,6 +715,9 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL }, +// +// Debug Filter Masks - See kd64/kddata.c +// { L"Session Manager\\Debug Print Filter", L"WIN2000", @@ -801,33 +725,1056 @@ INIT_SECTION CM_SYSTEM_CONTROL_VECTOR CmControlVector[] = NULL, NULL }, - - /* TODO: Add the other masks */ - { - L"WMI", - L"MaxEventSize", - &DummyData, + L"Session Manager\\Debug Print Filter", + L"SYSTEM", + &Kd_SYSTEM_Mask, NULL, NULL }, - { - L"WMI\\Trace", - L"UsePerformanceClock", - &DummyData, + L"Session Manager\\Debug Print Filter", + L"SMSS", + &Kd_SMSS_Mask, NULL, NULL }, - { - L"WMI\\Trace", - L"TraceAlignment", - &DummyData, + L"Session Manager\\Debug Print Filter", + L"SETUP", + &Kd_SETUP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"NTFS", + &Kd_NTFS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FSTUB", + &Kd_FSTUB_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CRASHDUMP", + &Kd_CRASHDUMP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CDAUDIO", + &Kd_CDAUDIO_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CDROM", + &Kd_CDROM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CLASSPNP", + &Kd_CLASSPNP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DISK", + &Kd_DISK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"REDBOOK", + &Kd_REDBOOK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"STORPROP", + &Kd_STORPROP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SCSIPORT", + &Kd_SCSIPORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SCSIMINIPORT", + &Kd_SCSIMINIPORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CONFIG", + &Kd_CONFIG_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"I8042PRT", + &Kd_I8042PRT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SERMOUSE", + &Kd_SERMOUSE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"LSERMOUS", + &Kd_LSERMOUS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"KBDHID", + &Kd_KBDHID_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MOUHID", + &Kd_MOUHID_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"KBDCLASS", + &Kd_KBDCLASS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MOUCLASS", + &Kd_MOUCLASS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TWOTRACK", + &Kd_TWOTRACK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WMILIB", + &Kd_WMILIB_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"ACPI", + &Kd_ACPI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"AMLI", + &Kd_AMLI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"HALIA64", + &Kd_HALIA64_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VIDEO", + &Kd_VIDEO_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SVCHOST", + &Kd_SVCHOST_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VIDEOPRT", + &Kd_VIDEOPRT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TCPIP", + &Kd_TCPIP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DMSYNTH", + &Kd_DMSYNTH_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"NTOSPNP", + &Kd_NTOSPNP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FASTFAT", + &Kd_FASTFAT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SAMSS", + &Kd_SAMSS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PNPMGR", + &Kd_PNPMGR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"NETAPI", + &Kd_NETAPI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SCSERVER", + &Kd_SCSERVER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SCCLIENT", + &Kd_SCCLIENT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SERIAL", + &Kd_SERIAL_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SERENUM", + &Kd_SERENUM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"UHCD", + &Kd_UHCD_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"RPCPROXY", + &Kd_RPCPROXY_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"AUTOCHK", + &Kd_AUTOCHK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DCOMSS", + &Kd_DCOMSS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"UNIMODEM", + &Kd_UNIMODEM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SIS", + &Kd_SIS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FLTMGR", + &Kd_FLTMGR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WMICORE", + &Kd_WMICORE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"BURNENG", + &Kd_BURNENG_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IMAPI", + &Kd_IMAPI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SXS", + &Kd_SXS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FUSION", + &Kd_FUSION_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IDLETASK", + &Kd_IDLETASK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SOFTPCI", + &Kd_SOFTPCI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TAPE", + &Kd_TAPE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MCHGR", + &Kd_MCHGR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IDEP", + &Kd_IDEP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PCIIDE", + &Kd_PCIIDE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FLOPPY", + &Kd_FLOPPY_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FDC", + &Kd_FDC_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TERMSRV", + &Kd_TERMSRV_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"W32TIME", + &Kd_W32TIME_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PREFETCHER", + &Kd_PREFETCHER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"RSFILTER", + &Kd_RSFILTER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FCPORT", + &Kd_FCPORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PCI", + &Kd_PCI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DMIO", + &Kd_DMIO_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DMCONFIG", + &Kd_DMCONFIG_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DMADMIN", + &Kd_DMADMIN_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WSOCKTRANSPORT", + &Kd_WSOCKTRANSPORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VSS", + &Kd_VSS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PNPMEM", + &Kd_PNPMEM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PROCESSOR", + &Kd_PROCESSOR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DMSERVER", + &Kd_DMSERVER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SR", + &Kd_SR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"INFINIBAND", + &Kd_INFINIBAND_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IHVDRIVER", + &Kd_IHVDRIVER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IHVVIDEO", + &Kd_IHVVIDEO_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IHVAUDIO", + &Kd_IHVAUDIO_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IHVNETWORK", + &Kd_IHVNETWORK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IHVSTREAMING", + &Kd_IHVSTREAMING_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IHVBUS", + &Kd_IHVBUS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"HPS", + &Kd_HPS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"RTLTHREADPOOL", + &Kd_RTLTHREADPOOL_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"LDR", + &Kd_LDR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TCPIP6", + &Kd_TCPIP6_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"ISAPNP", + &Kd_ISAPNP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SHPC", + &Kd_SHPC_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"STORPORT", + &Kd_STORPORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"STORMINIPORT", + &Kd_STORMINIPORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PRINTSPOOLER", + &Kd_PRINTSPOOLER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VSSDYNDISK", + &Kd_VSSDYNDISK_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VERIFIER", + &Kd_VERIFIER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VDS", + &Kd_VDS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VDSBAS", + &Kd_VDSBAS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VDSDYN", + &Kd_VDSDYN_Mask, // Specified in Vista+ + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VDSDYNDR", + &Kd_VDSDYNDR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VDSLDR", + &Kd_VDSLDR_Mask, // Specified in Vista+ + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"VDSUTIL", + &Kd_VDSUTIL_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DFRGIFC", + &Kd_DFRGIFC_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DEFAULT", + &Kd_DEFAULT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MM", + &Kd_MM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DFSC", + &Kd_DFSC_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WOW64", + &Kd_WOW64_Mask, + NULL, + NULL + }, +// +// Components specified in Vista+, some of which we also use in ReactOS +// + { + L"Session Manager\\Debug Print Filter", + L"ALPC", + &Kd_ALPC_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WDI", + &Kd_WDI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PERFLIB", + &Kd_PERFLIB_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"KTM", + &Kd_KTM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"IOSTRESS", + &Kd_IOSTRESS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"HEAP", + &Kd_HEAP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WHEA", + &Kd_WHEA_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"USERGDI", + &Kd_USERGDI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MMCSS", + &Kd_MMCSS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TPM", + &Kd_TPM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"THREADORDER", + &Kd_THREADORDER_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"ENVIRON", + &Kd_ENVIRON_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"EMS", + &Kd_EMS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"WDT", + &Kd_WDT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FVEVOL", + &Kd_FVEVOL_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"NDIS", + &Kd_NDIS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"NVCTRACE", + &Kd_NVCTRACE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"LUAFV", + &Kd_LUAFV_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"APPCOMPAT", + &Kd_APPCOMPAT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"USBSTOR", + &Kd_USBSTOR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SBP2PORT", + &Kd_SBP2PORT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"COVERAGE", + &Kd_COVERAGE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CACHEMGR", + &Kd_CACHEMGR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MOUNTMGR", + &Kd_MOUNTMGR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CFR", + &Kd_CFR_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"TXF", + &Kd_TXF_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"KSECDD", + &Kd_KSECDD_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FLTREGRESS", + &Kd_FLTREGRESS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MPIO", + &Kd_MPIO_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"MSDSM", + &Kd_MSDSM_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"UDFS", + &Kd_UDFS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"PSHED", + &Kd_PSHED_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"STORVSP", + &Kd_STORVSP_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"LSASS", + &Kd_LSASS_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SSPICLI", + &Kd_SSPICLI_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"CNG", + &Kd_CNG_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"EXFAT", + &Kd_EXFAT_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"FILETRACE", + &Kd_FILETRACE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"XSAVE", + &Kd_XSAVE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"SE", + &Kd_SE_Mask, + NULL, + NULL + }, + { + L"Session Manager\\Debug Print Filter", + L"DRIVEEXTENDER", + &Kd_DRIVEEXTENDER_Mask, + NULL, + NULL + }, +// +// END OF Debug Filter Masks +// + + { + L"WMI", + L"MaxEventSize", + &DummyData, + NULL, + NULL + }, + { + L"WMI\\Trace", + L"UsePerformanceClock", + &DummyData, + NULL, + NULL + }, + { + L"WMI\\Trace", + L"TraceAlignment", + &DummyData, NULL, NULL }, - { NULL, NULL, diff --git a/ntoskrnl/include/internal/kd64.h b/ntoskrnl/include/internal/kd64.h index 6917845a1b7..f1fa443c8da 100644 --- a/ntoskrnl/include/internal/kd64.h +++ b/ntoskrnl/include/internal/kd64.h @@ -546,9 +546,7 @@ extern BOOLEAN KdpControlCPressed; extern BOOLEAN KdpContextSent; extern KSPIN_LOCK KdpDebuggerLock; extern LARGE_INTEGER KdTimerStop, KdTimerStart, KdTimerDifference; -extern ULONG KdComponentTableSize; -extern ULONG Kd_WIN2000_Mask; -extern PULONG KdComponentTable[104]; + extern CHAR KdpMessageBuffer[0x1000], KdpPathBuffer[0x1000]; extern CHAR KdPrintDefaultCircularBuffer[KD_DEFAULT_LOG_BUFFER_SIZE]; extern BREAKPOINT_ENTRY KdpBreakpointTable[KD_BREAKPOINT_MAX]; @@ -559,3 +557,164 @@ extern ULONG KdpNumInternalBreakpoints; extern ULONG_PTR KdpCurrentSymbolStart, KdpCurrentSymbolEnd; extern ULONG TraceDataBuffer[40]; extern ULONG TraceDataBufferPosition; + +// +// Debug Filter Component Table +// +#define MAX_KD_COMPONENT_TABLE_ENTRIES 147 +extern ULONG KdComponentTableSize; +extern PULONG KdComponentTable[MAX_KD_COMPONENT_TABLE_ENTRIES]; + +// +// Debug Filter Masks +// +extern ULONG Kd_WIN2000_Mask; +extern ULONG Kd_SYSTEM_Mask; +extern ULONG Kd_SMSS_Mask; +extern ULONG Kd_SETUP_Mask; +extern ULONG Kd_NTFS_Mask; +extern ULONG Kd_FSTUB_Mask; +extern ULONG Kd_CRASHDUMP_Mask; +extern ULONG Kd_CDAUDIO_Mask; +extern ULONG Kd_CDROM_Mask; +extern ULONG Kd_CLASSPNP_Mask; +extern ULONG Kd_DISK_Mask; +extern ULONG Kd_REDBOOK_Mask; +extern ULONG Kd_STORPROP_Mask; +extern ULONG Kd_SCSIPORT_Mask; +extern ULONG Kd_SCSIMINIPORT_Mask; +extern ULONG Kd_CONFIG_Mask; +extern ULONG Kd_I8042PRT_Mask; +extern ULONG Kd_SERMOUSE_Mask; +extern ULONG Kd_LSERMOUS_Mask; +extern ULONG Kd_KBDHID_Mask; +extern ULONG Kd_MOUHID_Mask; +extern ULONG Kd_KBDCLASS_Mask; +extern ULONG Kd_MOUCLASS_Mask; +extern ULONG Kd_TWOTRACK_Mask; +extern ULONG Kd_WMILIB_Mask; +extern ULONG Kd_ACPI_Mask; +extern ULONG Kd_AMLI_Mask; +extern ULONG Kd_HALIA64_Mask; +extern ULONG Kd_VIDEO_Mask; +extern ULONG Kd_SVCHOST_Mask; +extern ULONG Kd_VIDEOPRT_Mask; +extern ULONG Kd_TCPIP_Mask; +extern ULONG Kd_DMSYNTH_Mask; +extern ULONG Kd_NTOSPNP_Mask; +extern ULONG Kd_FASTFAT_Mask; +extern ULONG Kd_SAMSS_Mask; +extern ULONG Kd_PNPMGR_Mask; +extern ULONG Kd_NETAPI_Mask; +extern ULONG Kd_SCSERVER_Mask; +extern ULONG Kd_SCCLIENT_Mask; +extern ULONG Kd_SERIAL_Mask; +extern ULONG Kd_SERENUM_Mask; +extern ULONG Kd_UHCD_Mask; +extern ULONG Kd_RPCPROXY_Mask; +extern ULONG Kd_AUTOCHK_Mask; +extern ULONG Kd_DCOMSS_Mask; +extern ULONG Kd_UNIMODEM_Mask; +extern ULONG Kd_SIS_Mask; +extern ULONG Kd_FLTMGR_Mask; +extern ULONG Kd_WMICORE_Mask; +extern ULONG Kd_BURNENG_Mask; +extern ULONG Kd_IMAPI_Mask; +extern ULONG Kd_SXS_Mask; +extern ULONG Kd_FUSION_Mask; +extern ULONG Kd_IDLETASK_Mask; +extern ULONG Kd_SOFTPCI_Mask; +extern ULONG Kd_TAPE_Mask; +extern ULONG Kd_MCHGR_Mask; +extern ULONG Kd_IDEP_Mask; +extern ULONG Kd_PCIIDE_Mask; +extern ULONG Kd_FLOPPY_Mask; +extern ULONG Kd_FDC_Mask; +extern ULONG Kd_TERMSRV_Mask; +extern ULONG Kd_W32TIME_Mask; +extern ULONG Kd_PREFETCHER_Mask; +extern ULONG Kd_RSFILTER_Mask; +extern ULONG Kd_FCPORT_Mask; +extern ULONG Kd_PCI_Mask; +extern ULONG Kd_DMIO_Mask; +extern ULONG Kd_DMCONFIG_Mask; +extern ULONG Kd_DMADMIN_Mask; +extern ULONG Kd_WSOCKTRANSPORT_Mask; +extern ULONG Kd_VSS_Mask; +extern ULONG Kd_PNPMEM_Mask; +extern ULONG Kd_PROCESSOR_Mask; +extern ULONG Kd_DMSERVER_Mask; +extern ULONG Kd_SR_Mask; +extern ULONG Kd_INFINIBAND_Mask; +extern ULONG Kd_IHVDRIVER_Mask; +extern ULONG Kd_IHVVIDEO_Mask; +extern ULONG Kd_IHVAUDIO_Mask; +extern ULONG Kd_IHVNETWORK_Mask; +extern ULONG Kd_IHVSTREAMING_Mask; +extern ULONG Kd_IHVBUS_Mask; +extern ULONG Kd_HPS_Mask; +extern ULONG Kd_RTLTHREADPOOL_Mask; +extern ULONG Kd_LDR_Mask; +extern ULONG Kd_TCPIP6_Mask; +extern ULONG Kd_ISAPNP_Mask; +extern ULONG Kd_SHPC_Mask; +extern ULONG Kd_STORPORT_Mask; +extern ULONG Kd_STORMINIPORT_Mask; +extern ULONG Kd_PRINTSPOOLER_Mask; +extern ULONG Kd_VSSDYNDISK_Mask; +extern ULONG Kd_VERIFIER_Mask; +extern ULONG Kd_VDS_Mask; +extern ULONG Kd_VDSBAS_Mask; +extern ULONG Kd_VDSDYN_Mask; // Specified in Vista+ +extern ULONG Kd_VDSDYNDR_Mask; +extern ULONG Kd_VDSLDR_Mask; // Specified in Vista+ +extern ULONG Kd_VDSUTIL_Mask; +extern ULONG Kd_DFRGIFC_Mask; +extern ULONG Kd_DEFAULT_Mask; +extern ULONG Kd_MM_Mask; +extern ULONG Kd_DFSC_Mask; +extern ULONG Kd_WOW64_Mask; +// +// Components specified in Vista+, some of which we also use in ReactOS +// +extern ULONG Kd_ALPC_Mask; +extern ULONG Kd_WDI_Mask; +extern ULONG Kd_PERFLIB_Mask; +extern ULONG Kd_KTM_Mask; +extern ULONG Kd_IOSTRESS_Mask; +extern ULONG Kd_HEAP_Mask; +extern ULONG Kd_WHEA_Mask; +extern ULONG Kd_USERGDI_Mask; +extern ULONG Kd_MMCSS_Mask; +extern ULONG Kd_TPM_Mask; +extern ULONG Kd_THREADORDER_Mask; +extern ULONG Kd_ENVIRON_Mask; +extern ULONG Kd_EMS_Mask; +extern ULONG Kd_WDT_Mask; +extern ULONG Kd_FVEVOL_Mask; +extern ULONG Kd_NDIS_Mask; +extern ULONG Kd_NVCTRACE_Mask; +extern ULONG Kd_LUAFV_Mask; +extern ULONG Kd_APPCOMPAT_Mask; +extern ULONG Kd_USBSTOR_Mask; +extern ULONG Kd_SBP2PORT_Mask; +extern ULONG Kd_COVERAGE_Mask; +extern ULONG Kd_CACHEMGR_Mask; +extern ULONG Kd_MOUNTMGR_Mask; +extern ULONG Kd_CFR_Mask; +extern ULONG Kd_TXF_Mask; +extern ULONG Kd_KSECDD_Mask; +extern ULONG Kd_FLTREGRESS_Mask; +extern ULONG Kd_MPIO_Mask; +extern ULONG Kd_MSDSM_Mask; +extern ULONG Kd_UDFS_Mask; +extern ULONG Kd_PSHED_Mask; +extern ULONG Kd_STORVSP_Mask; +extern ULONG Kd_LSASS_Mask; +extern ULONG Kd_SSPICLI_Mask; +extern ULONG Kd_CNG_Mask; +extern ULONG Kd_EXFAT_Mask; +extern ULONG Kd_FILETRACE_Mask; +extern ULONG Kd_XSAVE_Mask; +extern ULONG Kd_SE_Mask; +extern ULONG Kd_DRIVEEXTENDER_Mask; diff --git a/ntoskrnl/kd64/kdapi.c b/ntoskrnl/kd64/kdapi.c index 3b6ba4ff9f6..1f0066d8ffe 100644 --- a/ntoskrnl/kd64/kdapi.c +++ b/ntoskrnl/kd64/kdapi.c @@ -2295,8 +2295,9 @@ KdRefreshDebuggerNotPresent(VOID) */ NTSTATUS NTAPI -NtQueryDebugFilterState(IN ULONG ComponentId, - IN ULONG Level) +NtQueryDebugFilterState( + _In_ ULONG ComponentId, + _In_ ULONG Level) { PULONG Mask; @@ -2316,16 +2317,22 @@ NtQueryDebugFilterState(IN ULONG ComponentId, } else { +#if (NTDDI_VERSION >= NTDDI_VISTA) + /* Use the default component ID */ + Mask = &Kd_DEFAULT_Mask; + // Level = DPFLTR_INFO_LEVEL; // Override the Level. +#else /* Invalid ID, fail */ return STATUS_INVALID_PARAMETER_1; +#endif } - /* Convert Level to bit field if necessary */ + /* Convert Level to bit field if required */ if (Level < 32) Level = 1 << Level; + Level &= ~DPFLTR_MASK; /* Determine if this Level is filtered out */ - if ((Kd_WIN2000_Mask & Level) || - (*Mask & Level)) + if ((Kd_WIN2000_Mask & Level) || (*Mask & Level)) { /* This mask will get through to the debugger */ return (NTSTATUS)TRUE; @@ -2342,15 +2349,15 @@ NtQueryDebugFilterState(IN ULONG ComponentId, */ NTSTATUS NTAPI -NtSetDebugFilterState(IN ULONG ComponentId, - IN ULONG Level, - IN BOOLEAN State) +NtSetDebugFilterState( + _In_ ULONG ComponentId, + _In_ ULONG Level, + _In_ BOOLEAN State) { PULONG Mask; /* Modifying debug filters requires the debug privilege */ - if (!SeSinglePrivilegeCheck(SeDebugPrivilege, - ExGetPreviousMode())) + if (!SeSinglePrivilegeCheck(SeDebugPrivilege, ExGetPreviousMode())) { /* Fail */ return STATUS_ACCESS_DENIED; @@ -2372,25 +2379,24 @@ NtSetDebugFilterState(IN ULONG ComponentId, } else { +#if (NTDDI_VERSION >= NTDDI_VISTA) + /* Use the default component ID */ + Mask = &Kd_DEFAULT_Mask; +#else /* Invalid ID, fail */ return STATUS_INVALID_PARAMETER_1; +#endif } /* Convert Level to bit field if required */ if (Level < 32) Level = 1 << Level; + Level &= ~DPFLTR_MASK; - /* Check what kind of operation this is */ + /* Set or remove the Level */ if (State) - { - /* Set the Level */ *Mask |= Level; - } else - { - /* Remove the Level */ *Mask &= ~Level; - } - /* Success */ return STATUS_SUCCESS; } diff --git a/ntoskrnl/kd64/kddata.c b/ntoskrnl/kd64/kddata.c index 681eb9bed9d..5576c405842 100644 --- a/ntoskrnl/kd64/kddata.c +++ b/ntoskrnl/kd64/kddata.c @@ -237,19 +237,66 @@ ULONG Kd_VSSDYNDISK_Mask; ULONG Kd_VERIFIER_Mask; ULONG Kd_VDS_Mask; ULONG Kd_VDSBAS_Mask; +ULONG Kd_VDSDYN_Mask; // Specified in Vista+ ULONG Kd_VDSDYNDR_Mask; +ULONG Kd_VDSLDR_Mask; // Specified in Vista+ ULONG Kd_VDSUTIL_Mask; ULONG Kd_DFRGIFC_Mask; ULONG Kd_DEFAULT_Mask; ULONG Kd_MM_Mask; ULONG Kd_DFSC_Mask; ULONG Kd_WOW64_Mask; +// +// Components specified in Vista+, some of which we also use in ReactOS +// +ULONG Kd_ALPC_Mask; +ULONG Kd_WDI_Mask; +ULONG Kd_PERFLIB_Mask; +ULONG Kd_KTM_Mask; +ULONG Kd_IOSTRESS_Mask; +ULONG Kd_HEAP_Mask; +ULONG Kd_WHEA_Mask; +ULONG Kd_USERGDI_Mask; +ULONG Kd_MMCSS_Mask; +ULONG Kd_TPM_Mask; +ULONG Kd_THREADORDER_Mask; +ULONG Kd_ENVIRON_Mask; +ULONG Kd_EMS_Mask; +ULONG Kd_WDT_Mask; +ULONG Kd_FVEVOL_Mask; +ULONG Kd_NDIS_Mask; +ULONG Kd_NVCTRACE_Mask; +ULONG Kd_LUAFV_Mask; +ULONG Kd_APPCOMPAT_Mask; +ULONG Kd_USBSTOR_Mask; +ULONG Kd_SBP2PORT_Mask; +ULONG Kd_COVERAGE_Mask; +ULONG Kd_CACHEMGR_Mask; +ULONG Kd_MOUNTMGR_Mask; +ULONG Kd_CFR_Mask; +ULONG Kd_TXF_Mask; +ULONG Kd_KSECDD_Mask; +ULONG Kd_FLTREGRESS_Mask; +ULONG Kd_MPIO_Mask; +ULONG Kd_MSDSM_Mask; +ULONG Kd_UDFS_Mask; +ULONG Kd_PSHED_Mask; +ULONG Kd_STORVSP_Mask; +ULONG Kd_LSASS_Mask; +ULONG Kd_SSPICLI_Mask; +ULONG Kd_CNG_Mask; +ULONG Kd_EXFAT_Mask; +ULONG Kd_FILETRACE_Mask; +ULONG Kd_XSAVE_Mask; +ULONG Kd_SE_Mask; +ULONG Kd_DRIVEEXTENDER_Mask; +// End Mask ULONG Kd_ENDOFTABLE_Mask; // // Debug Filter Component Table // -PULONG KdComponentTable[104] = +PULONG KdComponentTable[MAX_KD_COMPONENT_TABLE_ENTRIES] = { &Kd_SYSTEM_Mask, &Kd_SMSS_Mask, @@ -347,13 +394,61 @@ PULONG KdComponentTable[104] = &Kd_VERIFIER_Mask, &Kd_VDS_Mask, &Kd_VDSBAS_Mask, + &Kd_VDSDYN_Mask, // Specified in Vista+ &Kd_VDSDYNDR_Mask, + &Kd_VDSLDR_Mask, // Specified in Vista+ &Kd_VDSUTIL_Mask, &Kd_DFRGIFC_Mask, &Kd_DEFAULT_Mask, &Kd_MM_Mask, &Kd_DFSC_Mask, &Kd_WOW64_Mask, + +// +// Components specified in Vista+, some of which we also use in ReactOS +// + &Kd_ALPC_Mask, + &Kd_WDI_Mask, + &Kd_PERFLIB_Mask, + &Kd_KTM_Mask, + &Kd_IOSTRESS_Mask, + &Kd_HEAP_Mask, + &Kd_WHEA_Mask, + &Kd_USERGDI_Mask, + &Kd_MMCSS_Mask, + &Kd_TPM_Mask, + &Kd_THREADORDER_Mask, + &Kd_ENVIRON_Mask, + &Kd_EMS_Mask, + &Kd_WDT_Mask, + &Kd_FVEVOL_Mask, + &Kd_NDIS_Mask, + &Kd_NVCTRACE_Mask, + &Kd_LUAFV_Mask, + &Kd_APPCOMPAT_Mask, + &Kd_USBSTOR_Mask, + &Kd_SBP2PORT_Mask, + &Kd_COVERAGE_Mask, + &Kd_CACHEMGR_Mask, + &Kd_MOUNTMGR_Mask, + &Kd_CFR_Mask, + &Kd_TXF_Mask, + &Kd_KSECDD_Mask, + &Kd_FLTREGRESS_Mask, + &Kd_MPIO_Mask, + &Kd_MSDSM_Mask, + &Kd_UDFS_Mask, + &Kd_PSHED_Mask, + &Kd_STORVSP_Mask, + &Kd_LSASS_Mask, + &Kd_SSPICLI_Mask, + &Kd_CNG_Mask, + &Kd_EXFAT_Mask, + &Kd_FILETRACE_Mask, + &Kd_XSAVE_Mask, + &Kd_SE_Mask, + &Kd_DRIVEEXTENDER_Mask, + // End Mask &Kd_ENDOFTABLE_Mask, }; diff --git a/ntoskrnl/kd64/kdprint.c b/ntoskrnl/kd64/kdprint.c index 7604a255ab4..8f721e80887 100644 --- a/ntoskrnl/kd64/kdprint.c +++ b/ntoskrnl/kd64/kdprint.c @@ -331,8 +331,19 @@ KdpPrint(IN ULONG ComponentId, /* Assume failure */ *Handled = FALSE; - /* Validate the mask */ +#if (NTDDI_VERSION >= NTDDI_VISTA) + if ((ComponentId >= KdComponentTableSize) && (ComponentId < MAXULONG)) + { + /* Use the default component ID */ + Mask = &Kd_DEFAULT_Mask; + // Level = DPFLTR_INFO_LEVEL; // Override the Level. + } +#endif + /* Convert Level to bit field if required */ if (Level < 32) Level = 1 << Level; + Level &= ~DPFLTR_MASK; + + /* Validate the mask */ if (!(Kd_WIN2000_Mask & Level) || ((ComponentId < KdComponentTableSize) && !(*KdComponentTable[ComponentId] & Level))) diff --git a/ntoskrnl/kdbg/kdb_cli.c b/ntoskrnl/kdbg/kdb_cli.c index abf2e6d84aa..5e7d40d230f 100644 --- a/ntoskrnl/kdbg/kdb_cli.c +++ b/ntoskrnl/kdbg/kdb_cli.c @@ -222,7 +222,14 @@ KdbpGetComponentId( } ComponentTable[] = { - { "DEFAULT", MAXULONG }, +// +// Default components +// + { "WIN2000", MAXULONG }, + { "DEFAULT", DPFLTR_DEFAULT_ID }, +// +// Standard components +// { "SYSTEM", DPFLTR_SYSTEM_ID }, { "SMSS", DPFLTR_SMSS_ID }, { "SETUP", DPFLTR_SETUP_ID }, @@ -327,6 +334,9 @@ KdbpGetComponentId( { "MM", DPFLTR_MM_ID }, { "DFSC", DPFLTR_DFSC_ID }, { "WOW64", DPFLTR_WOW64_ID }, +// +// Components specified in Vista+, some of which we also use in ReactOS +// { "ALPC", DPFLTR_ALPC_ID }, { "WDI", DPFLTR_WDI_ID }, { "PERFLIB", DPFLTR_PERFLIB_ID }, diff --git a/sdk/include/ndk/kdfuncs.h b/sdk/include/ndk/kdfuncs.h index cd71e2b58cf..2d9278f8f80 100644 --- a/sdk/include/ndk/kdfuncs.h +++ b/sdk/include/ndk/kdfuncs.h @@ -57,17 +57,17 @@ NTSYSCALLAPI NTSTATUS NTAPI NtQueryDebugFilterState( - ULONG ComponentId, - ULONG Level + _In_ ULONG ComponentId, + _In_ ULONG Level ); NTSYSCALLAPI NTSTATUS NTAPI NtSetDebugFilterState( - ULONG ComponentId, - ULONG Level, - BOOLEAN State + _In_ ULONG ComponentId, + _In_ ULONG Level, + _In_ BOOLEAN State ); NTSYSCALLAPI

1 0

[reactos] 02/06: [NTOS:KD/KDBG] Code enhancements for KDBG/KD.
by Hermès Bélusca-Maïto 17 Nov '19

17 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=9537653ee79376b200be8… commit 9537653ee79376b200be87ebabd7e6ce7a30065f Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 17 16:44:22 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 17 23:21:50 2019 +0100 [NTOS:KD/KDBG] Code enhancements for KDBG/KD. - Introduce KdpScreenAcquire() / KdpScreenRelease() helpers that allow to correctly acquire or release the screen when using INBV for "Screen-Mode" debugging. - Introduce KdpAcquireLock() / KdpReleaseLock() helpers so as to reduce the copy-pasted code required when acquiring spin-locks in the KD debug logger functions. - Close the opened KdpLogFileHandle file in the KdpInitDebugLog() logger in case we failed to create the logger writer thread. Also use explicit kernel-mode handle when opening the log file. - static-ify some local variables, remove few hardcoded values, and minor formatting. - Correctly define the INIT_FUNCTION's. --- ntoskrnl/include/internal/kd.h | 17 ++- ntoskrnl/kd/kdinit.c | 8 +- ntoskrnl/kd/kdio.c | 233 ++++++++++++++++++++++------------------- ntoskrnl/kd64/kdinit.c | 10 +- ntoskrnl/kdbg/kdb.c | 35 +++---- 5 files changed, 156 insertions(+), 147 deletions(-) diff --git a/ntoskrnl/include/internal/kd.h b/ntoskrnl/include/internal/kd.h index 162ece58f71..ef66e2abea2 100644 --- a/ntoskrnl/include/internal/kd.h +++ b/ntoskrnl/include/internal/kd.h @@ -106,7 +106,7 @@ VOID typedef VOID (NTAPI*PKDP_PRINT_ROUTINE)( - LPSTR String, + PCHAR String, ULONG Length ); @@ -139,6 +139,12 @@ KdInitSystem( PLOADER_PARAMETER_BLOCK LoaderBlock ); +VOID +KdpScreenAcquire(VOID); + +VOID +KdpScreenRelease(VOID); + VOID NTAPI KdpScreenInit( @@ -155,7 +161,7 @@ KdpSerialInit( VOID NTAPI -KdpInitDebugLog( +KdpDebugLogInit( struct _KD_DISPATCH_TABLE *DispatchTable, ULONG BootPhase ); @@ -193,13 +199,6 @@ BOOLEAN NTAPI KdpDetectConflicts(PCM_RESOURCE_LIST DriverList); -VOID -NTAPI -KdpBochsDebugPrint( - IN PCH Message, - IN ULONG Length -); - BOOLEAN NTAPI KdpSafeReadMemory( diff --git a/ntoskrnl/kd/kdinit.c b/ntoskrnl/kd/kdinit.c index 3e32b160920..a73ec17ecad 100644 --- a/ntoskrnl/kd/kdinit.c +++ b/ntoskrnl/kd/kdinit.c @@ -31,7 +31,7 @@ KD_DISPATCH_TABLE DispatchTable[KdMax]; PKDP_INIT_ROUTINE InitRoutines[KdMax] = {KdpScreenInit, KdpSerialInit, - KdpInitDebugLog, + KdpDebugLogInit, KdpBochsInit, KdpKdbgInit}; @@ -39,9 +39,9 @@ extern ANSI_STRING KdpLogFileName; /* PRIVATE FUNCTIONS *********************************************************/ +INIT_FUNCTION PCHAR NTAPI -INIT_FUNCTION KdpGetDebugMode(PCHAR Currentp2) { PCHAR p1, p2 = Currentp2; @@ -135,9 +135,9 @@ KdpGetDebugMode(PCHAR Currentp2) return p2; } +INIT_FUNCTION VOID NTAPI -INIT_FUNCTION KdpCallInitRoutine(ULONG BootPhase) { PLIST_ENTRY CurrentEntry; @@ -213,7 +213,7 @@ KdInitSystem(ULONG BootPhase, } else { - /* Called from a bugcheck or a re-enable. Unconditionally enable KD */ + /* Called from a bugcheck or a re-enable. Unconditionally enable KD. */ KdDebuggerEnabled = TRUE; } diff --git a/ntoskrnl/kd/kdio.c b/ntoskrnl/kd/kdio.c index 38a1d3fc9a2..23b163b4ebf 100644 --- a/ntoskrnl/kd/kdio.c +++ b/ntoskrnl/kd/kdio.c @@ -17,33 +17,33 @@ /* GLOBALS *******************************************************************/ #define KdpBufferSize (1024 * 512) -BOOLEAN KdpLoggingEnabled = FALSE; -PCHAR KdpDebugBuffer = NULL; -volatile ULONG KdpCurrentPosition = 0; -volatile ULONG KdpFreeBytes = 0; -KSPIN_LOCK KdpDebugLogSpinLock; -KEVENT KdpLoggerThreadEvent; -HANDLE KdpLogFileHandle; +static BOOLEAN KdpLoggingEnabled = FALSE; +static PCHAR KdpDebugBuffer = NULL; +static volatile ULONG KdpCurrentPosition = 0; +static volatile ULONG KdpFreeBytes = 0; +static KSPIN_LOCK KdpDebugLogSpinLock; +static KEVENT KdpLoggerThreadEvent; +static HANDLE KdpLogFileHandle; ANSI_STRING KdpLogFileName = RTL_CONSTANT_STRING("\\SystemRoot\\debug.log"); -KSPIN_LOCK KdpSerialSpinLock; +static KSPIN_LOCK KdpSerialSpinLock; ULONG SerialPortNumber = DEFAULT_DEBUG_PORT; CPPORT SerialPortInfo = {0, DEFAULT_DEBUG_BAUD_RATE, 0}; -/* Current Port in use. FIXME: Do we support more then one? */ +/* Current Port in use. FIXME: Do we support more than one? */ ULONG KdpPort; #define KdpScreenLineLengthDefault 80 -CHAR KdpScreenLineBuffer[KdpScreenLineLengthDefault + 1] = ""; -ULONG KdpScreenLineBufferPos = 0, KdpScreenLineLength = 0; +static CHAR KdpScreenLineBuffer[KdpScreenLineLengthDefault + 1] = ""; +static ULONG KdpScreenLineBufferPos = 0, KdpScreenLineLength = 0; const ULONG KdpDmesgBufferSize = 128 * 1024; // 512*1024; // 5*1024*1024; PCHAR KdpDmesgBuffer = NULL; volatile ULONG KdpDmesgCurrentPosition = 0; volatile ULONG KdpDmesgFreeBytes = 0; volatile ULONG KdbDmesgTotalWritten = 0; -KSPIN_LOCK KdpDmesgLogSpinLock; volatile BOOLEAN KdbpIsInDmesgMode = FALSE; +static KSPIN_LOCK KdpDmesgLogSpinLock; /* UTILITY FUNCTIONS *********************************************************/ @@ -57,8 +57,8 @@ volatile BOOLEAN KdbpIsInDmesgMode = FALSE; * * See also: kd64\kdinit.c */ -static SIZE_T -INIT_FUNCTION +static INIT_FUNCTION +SIZE_T KdpGetMemorySizeInMBs(IN PLOADER_PARAMETER_BLOCK LoaderBlock) { PLIST_ENTRY ListEntry; @@ -98,8 +98,8 @@ KdpGetMemorySizeInMBs(IN PLOADER_PARAMETER_BLOCK LoaderBlock) } /* See also: kd64\kdinit.c */ -static VOID -INIT_FUNCTION +static INIT_FUNCTION +VOID KdpPrintBanner(IN SIZE_T MemSizeMBs) { DPRINT1("-----------------------------------------------------\n"); @@ -109,10 +109,51 @@ KdpPrintBanner(IN SIZE_T MemSizeMBs) DPRINT1("ARC Paths: %s %s %s %s\n", KeLoaderBlock->ArcBootDeviceName, KeLoaderBlock->NtHalPathName, KeLoaderBlock->ArcHalDeviceName, KeLoaderBlock->NtBootPathName); } -/* FILE DEBUG LOG FUNCTIONS **************************************************/ +/* LOCKING FUNCTIONS *********************************************************/ + +KIRQL +NTAPI +KdpAcquireLock(IN PKSPIN_LOCK SpinLock) +{ + KIRQL OldIrql; + + /* Acquire the spinlock without waiting at raised IRQL */ + while (TRUE) + { + /* Loop until the spinlock becomes available */ + while (!KeTestSpinLock(SpinLock)); + + /* Spinlock is free, raise IRQL to high level */ + KeRaiseIrql(HIGH_LEVEL, &OldIrql); + + /* Try to get the spinlock */ + if (KeTryToAcquireSpinLockAtDpcLevel(SpinLock)) + break; + + /* Someone else got the spinlock, lower IRQL back */ + KeLowerIrql(OldIrql); + } + + return OldIrql; +} VOID NTAPI +KdpReleaseLock(IN PKSPIN_LOCK SpinLock, + IN KIRQL OldIrql) +{ + /* Release the spinlock */ + KiReleaseSpinLock(SpinLock); + // KeReleaseSpinLockFromDpcLevel(SpinLock); + + /* Restore the old IRQL */ + KeLowerIrql(OldIrql); +} + +/* FILE DEBUG LOG FUNCTIONS **************************************************/ + +static VOID +NTAPI KdpLoggerThread(PVOID Context) { ULONG beg, end, num; @@ -122,7 +163,7 @@ KdpLoggerThread(PVOID Context) while (TRUE) { - KeWaitForSingleObject(&KdpLoggerThreadEvent, 0, KernelMode, FALSE, NULL); + KeWaitForSingleObject(&KdpLoggerThreadEvent, Executive, KernelMode, FALSE, NULL); /* Bug */ /* Keep KdpCurrentPosition and KdpFreeBytes values in local @@ -158,32 +199,18 @@ KdpLoggerThread(PVOID Context) } } -VOID +static VOID NTAPI -KdpPrintToLogFile(PCH String, +KdpPrintToLogFile(PCHAR String, ULONG StringLength) { - ULONG beg, end, num; KIRQL OldIrql; + ULONG beg, end, num; if (KdpDebugBuffer == NULL) return; /* Acquire the printing spinlock without waiting at raised IRQL */ - while (TRUE) - { - /* Wait when the spinlock becomes available */ - while (!KeTestSpinLock(&KdpDebugLogSpinLock)); - - /* Spinlock was free, raise IRQL */ - KeRaiseIrql(HIGH_LEVEL, &OldIrql); - - /* Try to get the spinlock */ - if (KeTryToAcquireSpinLockAtDpcLevel(&KdpDebugLogSpinLock)) - break; - - /* Someone else got the spinlock, lower IRQL back */ - KeLowerIrql(OldIrql); - } + OldIrql = KdpAcquireLock(&KdpDebugLogSpinLock); beg = KdpCurrentPosition; num = KdpFreeBytes; @@ -207,21 +234,17 @@ KdpPrintToLogFile(PCH String, } } - /* Release spinlock */ - KiReleaseSpinLock(&KdpDebugLogSpinLock); - - /* Lower IRQL */ - KeLowerIrql(OldIrql); + /* Release the spinlock */ + KdpReleaseLock(&KdpDebugLogSpinLock, OldIrql); /* Signal the logger thread */ if (OldIrql <= DISPATCH_LEVEL && KdpLoggingEnabled) - KeSetEvent(&KdpLoggerThreadEvent, 0, FALSE); + KeSetEvent(&KdpLoggerThreadEvent, IO_NO_INCREMENT, FALSE); } VOID NTAPI -INIT_FUNCTION -KdpInitDebugLog(PKD_DISPATCH_TABLE DispatchTable, +KdpDebugLogInit(PKD_DISPATCH_TABLE DispatchTable, ULONG BootPhase) { NTSTATUS Status; @@ -239,12 +262,11 @@ KdpInitDebugLog(PKD_DISPATCH_TABLE DispatchTable, KdComPortInUse = NULL; /* Write out the functions that we support for now */ - DispatchTable->KdpInitRoutine = KdpInitDebugLog; + DispatchTable->KdpInitRoutine = KdpDebugLogInit; DispatchTable->KdpPrintRoutine = KdpPrintToLogFile; /* Register as a Provider */ InsertTailList(&KdProviders, &DispatchTable->KdProvidersList); - } else if (BootPhase == 1) { @@ -272,7 +294,7 @@ KdpInitDebugLog(PKD_DISPATCH_TABLE DispatchTable, InitializeObjectAttributes(&ObjectAttributes, &FileName, - 0, + OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, NULL, NULL); @@ -291,7 +313,8 @@ KdpInitDebugLog(PKD_DISPATCH_TABLE DispatchTable, RtlFreeUnicodeString(&FileName); - if (!NT_SUCCESS(Status)) return; + if (!NT_SUCCESS(Status)) + return; KeInitializeEvent(&KdpLoggerThreadEvent, SynchronizationEvent, TRUE); @@ -303,8 +326,11 @@ KdpInitDebugLog(PKD_DISPATCH_TABLE DispatchTable, NULL, KdpLoggerThread, NULL); - - if (!NT_SUCCESS(Status)) return; + if (!NT_SUCCESS(Status)) + { + NtClose(KdpLogFileHandle); + return; + } Priority = 7; NtSetInformationThread(ThreadHandle, @@ -318,28 +344,14 @@ KdpInitDebugLog(PKD_DISPATCH_TABLE DispatchTable, VOID NTAPI -KdpSerialDebugPrint(LPSTR Message, +KdpSerialDebugPrint(PCHAR Message, ULONG Length) { + PCHAR pch = (PCHAR)Message; KIRQL OldIrql; - PCHAR pch = (PCHAR) Message; /* Acquire the printing spinlock without waiting at raised IRQL */ - while (TRUE) - { - /* Wait when the spinlock becomes available */ - while (!KeTestSpinLock(&KdpSerialSpinLock)); - - /* Spinlock was free, raise IRQL */ - KeRaiseIrql(HIGH_LEVEL, &OldIrql); - - /* Try to get the spinlock */ - if (KeTryToAcquireSpinLockAtDpcLevel(&KdpSerialSpinLock)) - break; - - /* Someone else got the spinlock, lower IRQL back */ - KeLowerIrql(OldIrql); - } + OldIrql = KdpAcquireLock(&KdpSerialSpinLock); /* Output the message */ while (pch < Message + Length && *pch != '\0') @@ -352,11 +364,8 @@ KdpSerialDebugPrint(LPSTR Message, pch++; } - /* Release spinlock */ - KiReleaseSpinLock(&KdpSerialSpinLock); - - /* Lower IRQL */ - KeLowerIrql(OldIrql); + /* Release the spinlock */ + KdpReleaseLock(&KdpSerialSpinLock, OldIrql); } VOID @@ -399,27 +408,58 @@ KdpSerialInit(PKD_DISPATCH_TABLE DispatchTable, /* SCREEN FUNCTIONS **********************************************************/ +VOID +KdpScreenAcquire(VOID) +{ + if (InbvIsBootDriverInstalled() /* && + !InbvCheckDisplayOwnership() */) + { + /* Acquire ownership and reset the display */ + InbvAcquireDisplayOwnership(); + InbvResetDisplay(); + InbvSolidColorFill(0, 0, 639, 479, 0); + InbvSetTextColor(15); + InbvInstallDisplayStringFilter(NULL); + InbvEnableDisplayString(TRUE); + InbvSetScrollRegion(0, 0, 639, 479); + } +} + +// extern VOID NTAPI InbvSetDisplayOwnership(IN BOOLEAN DisplayOwned); + +VOID +KdpScreenRelease(VOID) +{ + if (InbvIsBootDriverInstalled()&& + InbvCheckDisplayOwnership()) + { + /* Release the display */ + // InbvSetDisplayOwnership(FALSE); + InbvNotifyDisplayOwnershipLost(NULL); + } +} + /* * Screen debug logger function KdpScreenPrint() writes text messages into * KdpDmesgBuffer, using it as a circular buffer. KdpDmesgBuffer contents could * be later (re)viewed using dmesg command of kdbg. KdpScreenPrint() protects * KdpDmesgBuffer from simultaneous writes by use of KdpDmesgLogSpinLock. */ -VOID +static VOID NTAPI -KdpScreenPrint(LPSTR Message, +KdpScreenPrint(PCHAR Message, ULONG Length) { - ULONG beg, end, num; + PCHAR pch = (PCHAR)Message; KIRQL OldIrql; - PCHAR pch = (PCHAR) Message; + ULONG beg, end, num; while (pch < Message + Length && *pch) { - if(*pch == '\b') + if (*pch == '\b') { /* HalDisplayString does not support '\b'. Workaround it and use '\r' */ - if(KdpScreenLineLength > 0) + if (KdpScreenLineLength > 0) { /* Remove last character from buffer */ KdpScreenLineBuffer[--KdpScreenLineLength] = '\0'; @@ -436,10 +476,10 @@ KdpScreenPrint(LPSTR Message, KdpScreenLineBuffer[KdpScreenLineLength] = '\0'; } - if(*pch == '\n' || KdpScreenLineLength == KdpScreenLineLengthDefault) + if (*pch == '\n' || KdpScreenLineLength == KdpScreenLineLengthDefault) { /* Print buffered characters */ - if(KdpScreenLineBufferPos != KdpScreenLineLength) + if (KdpScreenLineBufferPos != KdpScreenLineLength) HalDisplayString(KdpScreenLineBuffer + KdpScreenLineBufferPos); /* Clear line buffer */ @@ -451,7 +491,7 @@ KdpScreenPrint(LPSTR Message, } /* Print buffered characters */ - if(KdpScreenLineBufferPos != KdpScreenLineLength) + if (KdpScreenLineBufferPos != KdpScreenLineLength) { HalDisplayString(KdpScreenLineBuffer + KdpScreenLineBufferPos); KdpScreenLineBufferPos = KdpScreenLineLength; @@ -465,21 +505,7 @@ KdpScreenPrint(LPSTR Message, return; /* Acquire the printing spinlock without waiting at raised IRQL */ - while (TRUE) - { - /* Wait when the spinlock becomes available */ - while (!KeTestSpinLock(&KdpDmesgLogSpinLock)); - - /* Spinlock was free, raise IRQL */ - KeRaiseIrql(HIGH_LEVEL, &OldIrql); - - /* Try to get the spinlock */ - if (KeTryToAcquireSpinLockAtDpcLevel(&KdpDmesgLogSpinLock)) - break; - - /* Someone else got the spinlock, lower IRQL back */ - KeLowerIrql(OldIrql); - } + OldIrql = KdpAcquireLock(&KdpDmesgLogSpinLock); /* Invariant: always_true(KdpDmesgFreeBytes == KdpDmesgBufferSize); * set num to min(KdpDmesgFreeBytes, Length). @@ -504,11 +530,8 @@ KdpScreenPrint(LPSTR Message, KdbDmesgTotalWritten += num; } - /* Release spinlock */ - KiReleaseSpinLock(&KdpDmesgLogSpinLock); - - /* Lower IRQL */ - KeLowerIrql(OldIrql); + /* Release the spinlock */ + KdpReleaseLock(&KdpDmesgLogSpinLock, OldIrql); /* Optional step(?): find out a way to notify about buffer exhaustion, * and possibly fall into kbd to use dmesg command: user will read @@ -544,13 +567,7 @@ KdpScreenInit(PKD_DISPATCH_TABLE DispatchTable, KdbDmesgTotalWritten = 0; /* Take control of the display */ - InbvAcquireDisplayOwnership(); - InbvResetDisplay(); - InbvSolidColorFill(0, 0, 639, 479, 0); - InbvSetTextColor(15); - InbvSetScrollRegion(0, 0, 639, 479); - InbvInstallDisplayStringFilter(NULL); - InbvEnableDisplayString(TRUE); + KdpScreenAcquire(); /* Initialize spinlock */ KeInitializeSpinLock(&KdpDmesgLogSpinLock); diff --git a/ntoskrnl/kd64/kdinit.c b/ntoskrnl/kd64/kdinit.c index b6a8beb9ce9..43d2e8fc6b5 100644 --- a/ntoskrnl/kd64/kdinit.c +++ b/ntoskrnl/kd64/kdinit.c @@ -26,8 +26,8 @@ * * See also: kd\kdio.c */ -static SIZE_T -INIT_FUNCTION +static INIT_FUNCTION +SIZE_T KdpGetMemorySizeInMBs(IN PLOADER_PARAMETER_BLOCK LoaderBlock) { PLIST_ENTRY ListEntry; @@ -67,8 +67,8 @@ KdpGetMemorySizeInMBs(IN PLOADER_PARAMETER_BLOCK LoaderBlock) } /* See also: kd\kdio.c */ -static VOID -INIT_FUNCTION +static INIT_FUNCTION +VOID KdpPrintBanner(IN SIZE_T MemSizeMBs) { DPRINT1("-----------------------------------------------------\n"); @@ -340,7 +340,7 @@ KdInitSystem(IN ULONG BootPhase, } else { - /* Called from a bugcheck or a re-enable. Save the Kernel Base */ + /* Called from a bugcheck or a re-enable. Save the Kernel Base. */ KdVersionBlock.KernBase = (ULONG64)(LONG_PTR)PsNtosImageBase; /* Unconditionally enable KD */ diff --git a/ntoskrnl/kdbg/kdb.c b/ntoskrnl/kdbg/kdb.c index d75ab137e64..5e7f5e249fc 100644 --- a/ntoskrnl/kdbg/kdb.c +++ b/ntoskrnl/kdbg/kdb.c @@ -1218,21 +1218,9 @@ KdbpInternalEnter(VOID) KbdDisableMouse(); - if (KdpDebugMode.Screen && - InbvIsBootDriverInstalled() && - !InbvCheckDisplayOwnership()) - { - /* Acquire ownership and reset the display */ - InbvAcquireDisplayOwnership(); - InbvResetDisplay(); - - /* Display debugger prompt */ - InbvSolidColorFill(0, 0, 639, 479, 0); - InbvSetTextColor(15); - InbvInstallDisplayStringFilter(NULL); - InbvEnableDisplayString(TRUE); - InbvSetScrollRegion(0, 0, 639, 479); - } + /* Take control of the display */ + if (KdpDebugMode.Screen) + KdpScreenAcquire(); /* Call the interface's main loop on a different stack */ Thread = PsGetCurrentThread(); @@ -1244,7 +1232,7 @@ KdbpInternalEnter(VOID) Thread->Tcb.StackLimit = (ULONG_PTR)KdbStack; Thread->Tcb.KernelStack = (char*)KdbStack + KDB_STACK_SIZE; - /*KdbpPrint("Switching to KDB stack 0x%08x-0x%08x (Current Stack is 0x%08x)\n", Thread->Tcb.StackLimit, Thread->Tcb.StackBase, Esp);*/ + // KdbpPrint("Switching to KDB stack 0x%08x-0x%08x (Current Stack is 0x%08x)\n", Thread->Tcb.StackLimit, Thread->Tcb.StackBase, Esp); KdbpStackSwitchAndCall(KdbStack + KDB_STACK_SIZE - sizeof(ULONG), KdbpCallMainLoop); @@ -1252,6 +1240,11 @@ KdbpInternalEnter(VOID) Thread->Tcb.StackBase = SavedStackBase; Thread->Tcb.StackLimit = SavedStackLimit; Thread->Tcb.KernelStack = SavedKernelStack; + + /* Release the display */ + if (KdpDebugMode.Screen) + KdpScreenRelease(); + KbdEnableMouse(); } @@ -1363,7 +1356,7 @@ KdbEnterDebuggerException( EnterConditionMet = FALSE; } - /* If we stopped on one of our breakpoints then let the user know. */ + /* If we stopped on one of our breakpoints then let the user know */ KdbLastBreakPointNr = -1; KdbEnteredOnSingleStep = FALSE; @@ -1374,7 +1367,7 @@ KdbEnterDebuggerException( if (ExceptionCode == STATUS_BREAKPOINT) { - /* ... and restore the original instruction. */ + /* ... and restore the original instruction */ if (!NT_SUCCESS(KdbpOverwriteInstruction(KdbCurrentProcess, BreakPoint->Address, BreakPoint->Data.SavedInstruction, NULL))) { @@ -1408,7 +1401,7 @@ KdbEnterDebuggerException( { ASSERT((TrapFrame->EFlags & EFLAGS_TF) == 0); - /* Delete the temporary breakpoint which was used to step over or into the instruction. */ + /* Delete the temporary breakpoint which was used to step over or into the instruction */ KdbpDeleteBreakPoint(-1, BreakPoint); if (--KdbNumSingleSteps > 0) @@ -1626,7 +1619,7 @@ KdbEnterDebuggerException( return kdHandleException; } - /* Call the main loop. */ + /* Call the main loop */ KdbpInternalEnter(); /* Check if we should single step */ @@ -1698,9 +1691,9 @@ continue_execution: return ContinueType; } +INIT_FUNCTION VOID NTAPI -INIT_FUNCTION KdbpGetCommandLineSettings( PCHAR p1) {

1 0

[reactos] 01/06: [SDK:RTL] Add one validity check + comment documentation for RtlDispatchException().
by Hermès Bélusca-Maïto 17 Nov '19

17 Nov '19

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a4b6e0d929b0696fa7c9a… commit a4b6e0d929b0696fa7c9a258476ea1ff5778a125 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sat Nov 16 22:47:05 2019 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 17 23:21:47 2019 +0100 [SDK:RTL] Add one validity check + comment documentation for RtlDispatchException(). - RtlDispatchException(): Check for invalid stack in ExceptionContinueSearch handler and bail out if so. - Update few comments and fix a typo. - Add a documenting comment about SafeSEH functionality support. See e.g. the following articles: https://www.optiv.com/blog/old-meets-new-microsoft-windows-safeseh-incompat… https://msrc-blog.microsoft.com/2012/01/10/more-information-on-the-impact-o… --- sdk/lib/rtl/i386/except.c | 39 ++++++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/sdk/lib/rtl/i386/except.c b/sdk/lib/rtl/i386/except.c index 7054a0f02e0..530d5c75253 100644 --- a/sdk/lib/rtl/i386/except.c +++ b/sdk/lib/rtl/i386/except.c @@ -113,11 +113,18 @@ RtlDispatchException(IN PEXCEPTION_RECORD ExceptionRecord, continue; } - /* Set invalid stack and return false */ + /* Set invalid stack and bail out */ ExceptionRecord->ExceptionFlags |= EXCEPTION_STACK_INVALID; return FALSE; } + // + // TODO: Implement and call here RtlIsValidHandler(RegistrationFrame->Handler) + // for supporting SafeSEH functionality, see the following articles: + // https://www.optiv.com/blog/old-meets-new-microsoft-windows-safeseh-incompat… + // https://msrc-blog.microsoft.com/2012/01/10/more-information-on-the-impact-o… + // + /* Check if logging is enabled */ RtlpCheckLogException(ExceptionRecord, Context, @@ -144,7 +151,7 @@ RtlDispatchException(IN PEXCEPTION_RECORD ExceptionRecord, { /* Continue execution */ case ExceptionContinueExecution: - + { /* Check if it was non-continuable */ if (ExceptionRecord->ExceptionFlags & EXCEPTION_NONCONTINUABLE) { @@ -161,20 +168,25 @@ RtlDispatchException(IN PEXCEPTION_RECORD ExceptionRecord, else { /* In user mode, call any registered vectored continue handlers */ - RtlCallVectoredContinueHandlers(ExceptionRecord, - Context); + RtlCallVectoredContinueHandlers(ExceptionRecord, Context); /* Execution continues */ return TRUE; } + } /* Continue searching */ case ExceptionContinueSearch: + if (ExceptionRecord->ExceptionFlags & EXCEPTION_STACK_INVALID) + { + /* We have an invalid stack, bail out */ + return FALSE; + } break; /* Nested exception */ case ExceptionNestedException: - + { /* Turn the nested flag on */ ExceptionRecord->ExceptionFlags |= EXCEPTION_NESTED_CALL; @@ -185,10 +197,11 @@ RtlDispatchException(IN PEXCEPTION_RECORD ExceptionRecord, NestedFrame = DispatcherContext.RegistrationPointer; } break; + } /* Anything else */ default: - + { /* Set up the exception record */ ExceptionRecord2.ExceptionRecord = ExceptionRecord; ExceptionRecord2.ExceptionCode = STATUS_INVALID_DISPOSITION; @@ -198,13 +211,14 @@ RtlDispatchException(IN PEXCEPTION_RECORD ExceptionRecord, /* Raise the exception */ RtlRaiseException(&ExceptionRecord2); break; + } } /* Go to the next frame */ RegistrationFrame = RegistrationFrame->Next; } - /* Unhandled, return false */ + /* Unhandled, bail out */ return FALSE; } @@ -335,22 +349,24 @@ RtlUnwind(IN PVOID TargetFrame OPTIONAL, Context, &DispatcherContext, RegistrationFrame->Handler); + switch(Disposition) { /* Continue searching */ case ExceptionContinueSearch: break; - /* Collission */ - case ExceptionCollidedUnwind : - + /* Collision */ + case ExceptionCollidedUnwind: + { /* Get the original frame */ RegistrationFrame = DispatcherContext.RegistrationPointer; break; + } /* Anything else */ default: - + { /* Set up the exception record */ ExceptionRecord2.ExceptionRecord = ExceptionRecord; ExceptionRecord2.ExceptionCode = STATUS_INVALID_DISPOSITION; @@ -360,6 +376,7 @@ RtlUnwind(IN PVOID TargetFrame OPTIONAL, /* Raise the exception */ RtlRaiseException(&ExceptionRecord2); break; + } } /* Go to the next frame */

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs