[ros-diffs] [reactos] 01/01: [WIN32KNT_APITEST] Improve NtGdiSetBitmapBits testcase more and more (#1307)

[Katayama Hirofumi MZ]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f9037bd33f7fca347c347c...

commit f9037bd33f7fca347c347c4f1740996a857e55c3
Author:     Katayama Hirofumi MZ [e-mail]
AuthorDate: Sat Jan 26 20:28:40 2019 +0900
Commit:     GitHub [e-mail]
CommitDate: Sat Jan 26 20:28:40 2019 +0900

[WIN32KNT_APITEST] Improve NtGdiSetBitmapBits testcase more and more (#1307)

CORE-15657
---
 .../apitests/win32nt/ntgdi/NtGdiSetBitmapBits.c    | 198 ++++++++++++++++++++-
 1 file changed, 189 insertions(+), 9 deletions(-)

diff --git a/modules/rostests/apitests/win32nt/ntgdi/NtGdiSetBitmapBits.c b/modules/rostests/apitests/win32nt/ntgdi/NtGdiSetBitmapBits.c
index 2c34b91bc0..dcea8a8f8e 100644
--- a/modules/rostests/apitests/win32nt/ntgdi/NtGdiSetBitmapBits.c
+++ b/modules/rostests/apitests/win32nt/ntgdi/NtGdiSetBitmapBits.c
@@ -9,63 +9,91 @@

START_TEST(NtGdiSetBitmapBits)
 {
-    BYTE Bits[50] = {0,1,2,3,4,5,6,7,8,9};
+    BYTE Bits[100] = {0,1,2,3,4,5,6,7,8,9};
     HBITMAP hBitmap;
     HDC hDC;
     BITMAPINFO bmi;
     LPVOID pvBits;

-    SetLastError(ERROR_SUCCESS);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(0, 0, 0), 0);
-    ok_long(GetLastError(), ERROR_SUCCESS);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test NULL bitnap handle */
-    SetLastError(ERROR_SUCCESS);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(0, 5, Bits), 0);
     ok_long(GetLastError(), ERROR_INVALID_HANDLE);

/* Test invalid bitmap handle */
     hBitmap = (HBITMAP)CreatePen(PS_SOLID, 1, RGB(1,2,3));
-    SetLastError(ERROR_SUCCESS);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 5, Bits), 0);
     ok_long(GetLastError(), ERROR_INVALID_HANDLE);
     DeleteObject(hBitmap);

hBitmap = CreateBitmap(3, 3, 1, 8, NULL);
-    SetLastError(ERROR_SUCCESS);
+    ok(hBitmap != NULL, "hBitmap was NULL.\n");

/* test NULL pointer and count buffer size != 0 */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 5, NULL), 0);
+    ok_long(GetLastError(), 0xDEADFACE);

/* test NULL pointer and buffer size == 0*/
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 0, NULL), 0);
+    ok_long(GetLastError(), 0xDEADFACE);

/* test bad pointer */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 5, (PBYTE)0x500), 0);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test if we can set a number of bytes between lines */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 5, Bits), 5);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test alignment */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 4, Bits+1), 4);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test 1 byte too much */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 10, Bits), 10);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test one row too much */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 12, Bits), 12);
+    ok_long(GetLastError(), 0xDEADFACE);

+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 13, Bits), 12);
+    ok_long(GetLastError(), 0xDEADFACE);

+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 100, Bits), 12);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test huge bytes count */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 12345678, Bits), 0);
+    ok_long(GetLastError(), 0xDEADFACE);
+
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiSetBitmapBits(hBitmap, 0xFFFF, Bits), 0);
+    ok_long(GetLastError(), 0xDEADFACE);
+
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiSetBitmapBits(hBitmap, 0x10000, Bits), 0);
+    ok_long(GetLastError(), 0xDEADFACE);

/* Test negative bytes count */
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, -5, Bits), 0);
-
-    ok_long(GetLastError(), ERROR_SUCCESS);
+    ok_long(GetLastError(), 0xDEADFACE);

DeleteObject(hBitmap);

@@ -75,56 +103,181 @@ START_TEST(NtGdiSetBitmapBits)
     ok(hBitmap != NULL, "hBitmap was NULL.\n");

FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 0, Bits), 0);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0x55);
+
+    FillMemory(Bits, sizeof(Bits), 0x55);
+    
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0);
+    ok_int(Bits[1], 0x55);
+
+    FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0);
+    ok_int(Bits[1], 0);
+    ok_int(Bits[2], 0x55);
+
+    FillMemory(Bits, sizeof(Bits), 0x33);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiSetBitmapBits(hBitmap, 10, Bits), 10);
+    ok_long(GetLastError(), 0xDEADFACE);
+
+    FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiSetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
+    FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0xAA);
+    ok_int(Bits[1], 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0xAA);
+    ok_int(Bits[1], 0x33);
+    ok_int(Bits[2], 0x55);
+
+    FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiSetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
+    FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0xAA);
+    ok_int(Bits[1], 0xAA);
+    ok_int(Bits[2], 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0xAA);
+    ok_int(Bits[1], 0xAA);
+    ok_int(Bits[2], 0x33);
+    ok_int(Bits[3], 0x55);
+
+    FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiSetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
+    FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0xAA);
+    ok_int(Bits[1], 0xAA);
+    ok_int(Bits[2], 0xAA);
+    ok_int(Bits[3], 0x55);
+    SetLastError(0xDEADFACE);
+    ok_long(NtGdiGetBitmapBits(hBitmap, 4, Bits), 4);
+    ok_long(GetLastError(), 0xDEADFACE);
+    ok_int(Bits[0], 0xAA);
+    ok_int(Bits[1], 0xAA);
+    ok_int(Bits[2], 0xAA);
+    ok_int(Bits[3], 0x33);
+    ok_int(Bits[4], 0x55);
+
+    DeleteObject(hBitmap);
+
+    /* ------------------------- */
+
+    hDC = CreateCompatibleDC(NULL);
+
+    ZeroMemory(&bmi, sizeof(bmi));
+    bmi.bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
+    bmi.bmiHeader.biWidth = 15;
+    bmi.bmiHeader.biHeight = 15;    /* positive */
+    bmi.bmiHeader.biPlanes = 1;
+    bmi.bmiHeader.biBitCount = 24;
+    hBitmap = CreateDIBSection(hDC, &bmi, DIB_RGB_COLORS, &pvBits, NULL, 0);
+    ok(hBitmap != NULL, "hBitmap was NULL.\n");
+
+    FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 0, Bits), 0);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0x55);

FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0);
     ok_int(Bits[1], 0x55);

FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0);
     ok_int(Bits[1], 0);
     ok_int(Bits[2], 0x55);

FillMemory(Bits, sizeof(Bits), 0x33);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 10, Bits), 10);
+    ok_long(GetLastError(), 0xDEADFACE);

FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
     FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0x33);
     ok_int(Bits[2], 0x55);

FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0x33);
     ok_int(Bits[3], 0x55);

FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
     FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0xAA);
     ok_int(Bits[3], 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 4, Bits), 4);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0xAA);
@@ -132,6 +285,7 @@ START_TEST(NtGdiSetBitmapBits)
     ok_int(Bits[4], 0x55);

DeleteObject(hBitmap);
+    DeleteDC(hDC);

/* ------------------------- */

@@ -140,63 +294,89 @@ START_TEST(NtGdiSetBitmapBits)
     ZeroMemory(&bmi, sizeof(bmi));
     bmi.bmiHeader.biSize = sizeof(BITMAPINFOHEADER);
     bmi.bmiHeader.biWidth = 15;
-    bmi.bmiHeader.biHeight = 15;
+    bmi.bmiHeader.biHeight = -15;   /* negative */
     bmi.bmiHeader.biPlanes = 1;
     bmi.bmiHeader.biBitCount = 24;
     hBitmap = CreateDIBSection(hDC, &bmi, DIB_RGB_COLORS, &pvBits, NULL, 0);
     ok(hBitmap != NULL, "hBitmap was NULL.\n");

FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 0, Bits), 0);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0x55);

FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0);
     ok_int(Bits[1], 0x55);

FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0);
     ok_int(Bits[1], 0);
     ok_int(Bits[2], 0x55);

FillMemory(Bits, sizeof(Bits), 0x33);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 10, Bits), 10);
+    ok_long(GetLastError(), 0xDEADFACE);

FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
     FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 1, Bits), 1);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0x33);
     ok_int(Bits[2], 0x55);

FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 2, Bits), 2);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0x33);
     ok_int(Bits[3], 0x55);

FillMemory(Bits, sizeof(Bits), 0xAA);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiSetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
     FillMemory(Bits, sizeof(Bits), 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 3, Bits), 3);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0xAA);
     ok_int(Bits[3], 0x55);
+    SetLastError(0xDEADFACE);
     ok_long(NtGdiGetBitmapBits(hBitmap, 4, Bits), 4);
+    ok_long(GetLastError(), 0xDEADFACE);
     ok_int(Bits[0], 0xAA);
     ok_int(Bits[1], 0xAA);
     ok_int(Bits[2], 0xAA);