[ros-diffs] [reactos] 49/72: [NTFS] - Add some fixes and improvements to btree.c from CR-123: -CompareTreeKeys() - Assert that the first key isn't the dummy key. -CreateIndexRootFromBTree() - Assert that CurrentKey->IndexEntry->Length isn't 0. -DumpBTreeKey() - Use sizeof(WCHAR) in place of magic 2. -NtfsInsertKey() - Check for allocation failure of NewKey.

[Trevor Thompson]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7e9acb7ddae095b06d573…

commit 7e9acb7ddae095b06d573d4d5bb19a93624c739a
Author: Trevor Thompson <tmt256(a)email.vccs.edu>
AuthorDate: Tue Jul 4 21:47:43 2017 +0000

    [NTFS] - Add some fixes and improvements to btree.c from CR-123:
    -CompareTreeKeys() - Assert that the first key isn't the dummy key.
    -CreateIndexRootFromBTree() - Assert that CurrentKey->IndexEntry->Length
isn't 0.
    -DumpBTreeKey() - Use sizeof(WCHAR) in place of magic 2.
    -NtfsInsertKey() - Check for allocation failure of NewKey.
    
    svn path=/branches/GSoC_2016/NTFS/; revision=75280
---
 drivers/filesystems/ntfs/btree.c | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/drivers/filesystems/ntfs/btree.c b/drivers/filesystems/ntfs/btree.c
index d23871d3ff..f4641d005c 100644
--- a/drivers/filesystems/ntfs/btree.c
+++ b/drivers/filesystems/ntfs/btree.c
@@ -62,6 +62,8 @@ CompareTreeKeys(PB_TREE_KEY Key1, PB_TREE_KEY Key2, BOOLEAN
CaseSensitive)
     UNICODE_STRING Key1Name, Key2Name;
     LONG Comparison;
 
+    ASSERT(!(Key1->IndexEntry->Flags & NTFS_INDEX_ENTRY_END));
+
     // If Key2 is the "dummy key", key 1 will always come first
     if (Key2->NextKey == NULL)
         return -1;
@@ -322,11 +324,10 @@ CreateIndexRootFromBTree(PDEVICE_EXTENSION DeviceExt,
             return STATUS_NOT_IMPLEMENTED;
         }
 
+        ASSERT(CurrentKey->IndexEntry->Length != 0);
+
         // Copy the index entry
-        if (CurrentKey->IndexEntry->Length > 0)
-            RtlCopyMemory(CurrentNodeEntry, CurrentKey->IndexEntry,
CurrentKey->IndexEntry->Length);
-        else
-            DPRINT1("DRIVER ERROR: CurrentKey->IndexEntry->Length <= 0
!\n");
+        RtlCopyMemory(CurrentNodeEntry, CurrentKey->IndexEntry,
CurrentKey->IndexEntry->Length);
 
         DPRINT1("Index Node Entry Stream Length: %u\nIndex Node Entry Length:
%u\n",
                 CurrentNodeEntry->KeyLength,
@@ -409,7 +410,7 @@ DumpBTreeKey(PB_TREE_KEY Key, int Number, int Depth)
     if (!(Key->IndexEntry->Flags & NTFS_INDEX_ENTRY_END))
     {
         UNICODE_STRING FileName;
-        FileName.Length = Key->IndexEntry->FileName.NameLength * 2;
+        FileName.Length = Key->IndexEntry->FileName.NameLength * sizeof(WCHAR);
         FileName.MaximumLength = FileName.Length;
         FileName.Buffer = Key->IndexEntry->FileName.Name;
         DbgPrint(" '%wZ'\n", &FileName);
@@ -514,6 +515,12 @@ NtfsInsertKey(ULONGLONG FileReference,
 
     // Setup the New Key
     NewKey = ExAllocatePoolWithTag(NonPagedPool, sizeof(B_TREE_KEY), TAG_NTFS);
+    if (!NewKey)
+    {
+        DPRINT1("ERROR: Failed to allocate memory for new key!\n");
+        ExFreePoolWithTag(NewEntry, TAG_NTFS);
+        return STATUS_INSUFFICIENT_RESOURCES;
+    }
     NewKey->IndexEntry = NewEntry;
     NewKey->NextKey = NULL;