[ros-diffs] [hpoussin] 21830: In case of error, Reg* functions set the output handle to NULL. Don't rely on it to be INVALID_HANDLE_VALUE This commit is related to bug 1455

Author: hpoussin
Date: Sun May  7 18:02:00 2006
New Revision: 21830

URL: http://svn.reactos.ru/svn/reactos?rev=21830&view=rev
Log:
In case of error, Reg* functions set the output handle to NULL. Don't rely on it to be
INVALID_HANDLE_VALUE
This commit is related to bug 1455

Modified:
    trunk/reactos/dll/win32/setupapi/devinst.c
    trunk/reactos/dll/win32/setupapi/install.c

Modified: trunk/reactos/dll/win32/setupapi/devinst.c
URL:
http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/setupapi/devinst.…
==============================================================================
--- trunk/reactos/dll/win32/setupapi/devinst.c (original)
+++ trunk/reactos/dll/win32/setupapi/devinst.c Sun May  7 18:02:00 2006
@@ -788,11 +788,15 @@
 cleanup:
   if (ret == INVALID_HANDLE_VALUE)
   {
-    if (list && list->HKLM != 0 && list->HKLM !=
HKEY_LOCAL_MACHINE)
-      RegCloseKey(list->HKLM);
+    if (list)
+    {
+      if (list->HKLM != NULL && list->HKLM != HKEY_LOCAL_MACHINE)
+        RegCloseKey(list->HKLM);
+    }
     HeapFree(GetProcessHeap(), 0, list);
   }
-  HeapFree(GetProcessHeap(), 0, UNCServerName);
+  if (UNCServerName)
+    HeapFree(GetProcessHeap(), 0, UNCServerName);
   return ret;
 }
 
@@ -1660,8 +1664,8 @@
     struct DeviceInfoElement *deviceInfo;
 
     hInterfaceKey = INVALID_HANDLE_VALUE;
-    hDeviceInstanceKey = INVALID_HANDLE_VALUE;
-    hReferenceKey = INVALID_HANDLE_VALUE;
+    hDeviceInstanceKey = NULL;
+    hReferenceKey = NULL;
 
     /* Open registry key related to this interface */
     hInterfaceKey = SetupDiOpenClassRegKeyExW(InterfaceGuid, KEY_ENUMERATE_SUB_KEYS,
DIOCR_INTERFACE, MachineName, NULL);
@@ -1684,7 +1688,7 @@
         i++;
 
         /* Open sub key */
-        if (hDeviceInstanceKey != INVALID_HANDLE_VALUE)
+        if (hDeviceInstanceKey != NULL)
             RegCloseKey(hDeviceInstanceKey);
         rc = RegOpenKeyExW(hInterfaceKey, KeyBuffer, 0, KEY_QUERY_VALUE |
KEY_ENUMERATE_SUB_KEYS, &hDeviceInstanceKey);
         if (rc != ERROR_SUCCESS)
@@ -1774,7 +1778,7 @@
                 continue;
 
             /* Open sub key */
-            if (hReferenceKey != INVALID_HANDLE_VALUE)
+            if (hReferenceKey != NULL)
                 RegCloseKey(hReferenceKey);
             rc = RegOpenKeyExW(hDeviceInstanceKey, KeyBuffer, 0, KEY_QUERY_VALUE,
&hReferenceKey);
             if (rc != ERROR_SUCCESS)
@@ -1811,7 +1815,6 @@
             }
             rc = RegQueryValueExW(hReferenceKey, SymbolicLink, NULL, NULL,
(LPBYTE)pSymbolicLink, &dwLength);
             pSymbolicLink[dwLength / sizeof(WCHAR)] = '\0';
-            RegCloseKey(hReferenceKey);
             if (rc != ERROR_SUCCESS)
                 goto cleanup;
             if (!CreateDeviceInterface(deviceInfo, pSymbolicLink, InterfaceGuid,
&interfaceInfo))
@@ -1850,9 +1853,9 @@
     rc = ERROR_SUCCESS;
 
 cleanup:
-    if (hReferenceKey != INVALID_HANDLE_VALUE)
+    if (hReferenceKey != NULL)
         RegCloseKey(hReferenceKey);
-    if (hDeviceInstanceKey != INVALID_HANDLE_VALUE)
+    if (hDeviceInstanceKey != NULL)
         RegCloseKey(hDeviceInstanceKey);
     if (hInterfaceKey != INVALID_HANDLE_VALUE)
         RegCloseKey(hInterfaceKey);
@@ -4619,8 +4622,8 @@
         IN DWORD HwProfile,
         IN DWORD samDesired)
 {
-    HKEY hHWProfilesKey = INVALID_HANDLE_VALUE;
-    HKEY hHWProfileKey = INVALID_HANDLE_VALUE;
+    HKEY hHWProfilesKey = NULL;
+    HKEY hHWProfileKey = NULL;
     HKEY ret = INVALID_HANDLE_VALUE;
     LONG rc;
 
@@ -4663,9 +4666,9 @@
     ret = hHWProfileKey;
 
 cleanup:
-    if (hHWProfilesKey != INVALID_HANDLE_VALUE)
+    if (hHWProfilesKey != NULL)
         RegCloseKey(hHWProfilesKey);
-    if (hHWProfileKey != INVALID_HANDLE_VALUE && hHWProfileKey != ret)
+    if (hHWProfileKey != NULL && hHWProfileKey != ret)
         RegCloseKey(hHWProfileKey);
     return ret;
 }
@@ -4712,10 +4715,10 @@
         DWORD Index; /* Index used in the DriverKey name */
         DWORD rc;
         HKEY hHWProfileKey = INVALID_HANDLE_VALUE;
-        HKEY hEnumKey = INVALID_HANDLE_VALUE;
-        HKEY hClassKey = INVALID_HANDLE_VALUE;
+        HKEY hEnumKey = NULL;
+        HKEY hClassKey = NULL;
         HKEY hDeviceKey = INVALID_HANDLE_VALUE;
-        HKEY hKey = INVALID_HANDLE_VALUE;
+        HKEY hKey = NULL;
         HKEY RootKey;
 
         if (Scope == DICS_FLAG_GLOBAL)
@@ -4856,13 +4859,13 @@
         HeapFree(GetProcessHeap(), 0, DriverKey);
         if (hHWProfileKey != INVALID_HANDLE_VALUE)
             RegCloseKey(hHWProfileKey);
-        if (hEnumKey != INVALID_HANDLE_VALUE)
+        if (hEnumKey != NULL)
             RegCloseKey(hEnumKey);
-        if (hClassKey != INVALID_HANDLE_VALUE)
+        if (hClassKey != NULL)
             RegCloseKey(hClassKey);
         if (hDeviceKey != INVALID_HANDLE_VALUE)
             RegCloseKey(hDeviceKey);
-        if (hKey != INVALID_HANDLE_VALUE && hKey != ret)
+        if (hKey != NULL && hKey != ret)
             RegCloseKey(hKey);
     }
 
@@ -4907,8 +4910,8 @@
         DWORD dwRegType;
         DWORD rc;
         HKEY hHWProfileKey = INVALID_HANDLE_VALUE;
-        HKEY hEnumKey = INVALID_HANDLE_VALUE;
-        HKEY hKey = INVALID_HANDLE_VALUE;
+        HKEY hEnumKey = NULL;
+        HKEY hKey = NULL;
         HKEY RootKey;
 
         if (Scope == DICS_FLAG_GLOBAL)
@@ -4939,7 +4942,7 @@
             KeyType == DIREG_DEV ? samDesired : KEY_QUERY_VALUE,
             &hKey);
         RegCloseKey(hEnumKey);
-        hEnumKey = INVALID_HANDLE_VALUE;
+        hEnumKey = NULL;
         if (rc != ERROR_SUCCESS)
         {
             SetLastError(rc);
@@ -4976,7 +4979,7 @@
             goto cleanup;
         }
         RegCloseKey(hKey);
-        hKey = INVALID_HANDLE_VALUE;
+        hKey = NULL;
         /* Need to open the driver key */
         rc = RegOpenKeyExW(
             RootKey,
@@ -5005,9 +5008,9 @@
 cleanup:
         if (hHWProfileKey != INVALID_HANDLE_VALUE)
             RegCloseKey(hHWProfileKey);
-        if (hEnumKey != INVALID_HANDLE_VALUE)
+        if (hEnumKey != NULL)
             RegCloseKey(hEnumKey);
-        if (hKey != INVALID_HANDLE_VALUE && hKey != ret)
+        if (hKey != NULL && hKey != ret)
             RegCloseKey(hKey);
     }
 
@@ -7010,7 +7013,7 @@
 GetCurrentHwProfile(
     IN HDEVINFO DeviceInfoSet)
 {
-    HKEY hKey = INVALID_HANDLE_VALUE;
+    HKEY hKey = NULL;
     DWORD dwRegType, dwLength;
     DWORD hwProfile;
     LONG rc;
@@ -7049,7 +7052,7 @@
     ret = hwProfile;
 
 cleanup:
-    if (hKey != INVALID_HANDLE_VALUE)
+    if (hKey != NULL)
         RegCloseKey(hKey);
 
     return hwProfile;
@@ -7638,7 +7641,6 @@
     LPWSTR lpGuidString = NULL, lpFullGuidString = NULL;
     BOOL RebootRequired = FALSE;
     HKEY hKey = INVALID_HANDLE_VALUE;
-    HKEY hClassKey = INVALID_HANDLE_VALUE;
     BOOL NeedtoCopyFile;
     LARGE_INTEGER fullVersion;
     LONG rc;
@@ -7894,8 +7896,6 @@
 
 cleanup:
     /* End of installation */
-    if (hClassKey != INVALID_HANDLE_VALUE)
-        RegCloseKey(hClassKey);
     if (hKey != INVALID_HANDLE_VALUE)
         RegCloseKey(hKey);
     if (lpGuidString)

Modified: trunk/reactos/dll/win32/setupapi/install.c
URL:
http://svn.reactos.ru/svn/reactos/trunk/reactos/dll/win32/setupapi/install.…
==============================================================================
--- trunk/reactos/dll/win32/setupapi/install.c (original)
+++ trunk/reactos/dll/win32/setupapi/install.c Sun May  7 18:02:00 2006
@@ -1167,7 +1167,7 @@
     LPQUERY_SERVICE_CONFIG ServiceConfig = NULL;
     BOOL ret = FALSE;
 
-    HKEY hGroupOrderListKey = INVALID_HANDLE_VALUE;
+    HKEY hGroupOrderListKey = NULL;
     LPWSTR ServiceBinary = NULL;
     LPWSTR LoadOrderGroup = NULL;
     LPWSTR DisplayName = NULL;
@@ -1359,7 +1359,7 @@
         CloseServiceHandle(hSCManager);
     if (hService != NULL)
         CloseServiceHandle(hService);
-    if (hGroupOrderListKey != INVALID_HANDLE_VALUE)
+    if (hGroupOrderListKey != NULL)
         RegCloseKey(hGroupOrderListKey);
     MyFree(ServiceConfig);
     MyFree(ServiceBinary);