[ros-diffs] [reactos] 01/01: [CRT] Do Not lock ioinfo when spawning functions (#4099) CORE-15176

[Doug Lyons]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=252a7530d0dc267b1cd17…

commit 252a7530d0dc267b1cd1743769524c88bbadc429
Author:     Doug Lyons <douglyons(a)douglyons.com>
AuthorDate: Thu Nov 11 11:30:43 2021 -0600
Commit:     GitHub <noreply(a)github.com>
CommitDate: Thu Nov 11 18:30:43 2021 +0100

    [CRT] Do Not lock ioinfo when spawning functions (#4099) CORE-15176
    
    
    This fixes CORE-15176 'Gimp 2.6.11 hangs when opening a file'.
    It regressed by 0.4.9-dev-446-g bffd8201d0a822365e1950c558aaf33c26f20002
    
    I do intend to port this fix back.
---
 sdk/lib/crt/stdio/file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sdk/lib/crt/stdio/file.c b/sdk/lib/crt/stdio/file.c
index 0793a3fffaa..40cda33700b 100644
--- a/sdk/lib/crt/stdio/file.c
+++ b/sdk/lib/crt/stdio/file.c
@@ -434,7 +434,7 @@ unsigned create_io_inherit_block(WORD *size, BYTE **block)
   for (fd = 0; fd < last_fd; fd++)
   {
     /* to be inherited, we need it to be open, and that DONTINHERIT isn't set */
-    fdinfo = get_ioinfo(fd);
+    fdinfo = get_ioinfo_nolock(fd);
     if ((fdinfo->wxflag & (WX_OPEN | WX_DONTINHERIT)) == WX_OPEN)
     {
       *wxflag_ptr = fdinfo->wxflag;
@@ -445,7 +445,6 @@ unsigned create_io_inherit_block(WORD *size, BYTE **block)
       *wxflag_ptr = 0;
       *handle_ptr = INVALID_HANDLE_VALUE;
     }
-    release_ioinfo(fdinfo);
     wxflag_ptr++; handle_ptr++;
   }
   return TRUE;