[ros-diffs] [cgutman] 43636: - Don't set AT_ARP for the loopback interface - Remove hacks in iphlpapi that hid this bug

Author: cgutman
Date: Tue Oct 20 05:54:27 2009
New Revision: 43636

URL: http://svn.reactos.org/svn/reactos?rev=43636&view=rev
Log:
 - Don't set AT_ARP for the loopback interface
 - Remove hacks in iphlpapi that hid this bug

Modified:
    trunk/reactos/dll/win32/iphlpapi/ipstats_reactos.c
    trunk/reactos/drivers/network/tcpip/tcpip/iinfo.c

Modified: trunk/reactos/dll/win32/iphlpapi/ipstats_reactos.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/iphlpapi/ipstats…
==============================================================================
--- trunk/reactos/dll/win32/iphlpapi/ipstats_reactos.c [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/iphlpapi/ipstats_reactos.c [iso-8859-1] Tue Oct 20 05:54:27
2009
@@ -513,8 +513,7 @@
 
     for( i = 0; i < numEntities; i++ ) {
         if( isInterface( &entitySet[i] ) &&
-	    hasArp( tcpFile, &entitySet[i] ) &&
-	    !isLoopback( tcpFile, &entitySet[i] ) ) {
+	    hasArp( tcpFile, &entitySet[i] ) ) {
 
 	    status = tdiGetSetOfThings( tcpFile,
 					INFO_CLASS_PROTOCOL,
@@ -574,8 +573,7 @@
 
     for( i = 0; i < numEntities; i++ ) {
         if( isInterface( &entitySet[i] ) &&
-	    hasArp( tcpFile, &entitySet[i] ) &&
-	    !isLoopback( tcpFile, &entitySet[i] ) ) {
+	    hasArp( tcpFile, &entitySet[i] ) ) {
 
 	    status = tdiGetSetOfThings( tcpFile,
 					INFO_CLASS_PROTOCOL,

Modified: trunk/reactos/drivers/network/tcpip/tcpip/iinfo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/tcpi…
==============================================================================
--- trunk/reactos/drivers/network/tcpip/tcpip/iinfo.c [iso-8859-1] (original)
+++ trunk/reactos/drivers/network/tcpip/tcpip/iinfo.c [iso-8859-1] Tue Oct 20 05:54:27
2009
@@ -197,7 +197,7 @@
     EntityList[EntityCount].tei_entity   = AT_ENTITY;
     EntityList[EntityCount].tei_instance = ATCount;
     EntityList[EntityCount].context      = Interface;
-    EntityList[EntityCount].flags        = AT_ARP;
+    EntityList[EntityCount].flags        = (Interface != Loopback) ? AT_ARP : AT_NULL;
     EntityCount++;
 
     TcpipReleaseSpinLock( &EntityListLock, OldIrql );