[ros-diffs] [reactos] 01/01: [KSECDD] Improve GetSecurityUserInfo stub (#2438)

[Doug Lyons]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cb10698316c9d4d4b9c49…

commit cb10698316c9d4d4b9c499b6c9a9791d6eb023d5
Author:     Doug Lyons <douglyons(a)douglyons.com>
AuthorDate: Wed Apr 15 17:32:47 2020 -0500
Commit:     GitHub <noreply(a)github.com>
CommitDate: Thu Apr 16 01:32:47 2020 +0300

    [KSECDD] Improve GetSecurityUserInfo stub (#2438)
    
    - Fix UNIMPLEMENTED_DBGBREAK seen using FileMon
    - Add SAL2 Annotations and remove unneeded comments
    - Return NULL pointer
    
    CORE-15186
---
 drivers/crypto/ksecdd/ksecdd.spec |  2 +-
 drivers/crypto/ksecdd/stubs.c     | 12 +++++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/ksecdd/ksecdd.spec b/drivers/crypto/ksecdd/ksecdd.spec
index 796edb8d2b7..2f1fc69edd8 100644
--- a/drivers/crypto/ksecdd/ksecdd.spec
+++ b/drivers/crypto/ksecdd/ksecdd.spec
@@ -12,7 +12,7 @@
 @ stdcall FreeCredentialsHandle(ptr)
 @ stdcall GenerateDirEfs()
 @ stdcall GenerateSessionKey()
-@ stdcall GetSecurityUserInfo()
+@ stdcall GetSecurityUserInfo(ptr long ptr)
 @ stdcall ImpersonateSecurityContext(ptr)
 @ stdcall ImportSecurityContextW(ptr ptr ptr ptr)
 @ stdcall InitSecurityInterfaceW()
diff --git a/drivers/crypto/ksecdd/stubs.c b/drivers/crypto/ksecdd/stubs.c
index 176b4acb9f9..426861c97ae 100644
--- a/drivers/crypto/ksecdd/stubs.c
+++ b/drivers/crypto/ksecdd/stubs.c
@@ -13,6 +13,7 @@
 #define NDEBUG
 #include <debug.h>
 
+typedef PVOID PSECURITY_PACKAGE_OPTIONS, PSecurityUserData;
 
 /* FUNCTIONS ******************************************************************/
 
@@ -160,11 +161,16 @@ GenerateSessionKey(VOID)
     UNIMPLEMENTED_DBGBREAK();
 }
 
-VOID
+SECURITY_STATUS
 SEC_ENTRY
-GetSecurityUserInfo(VOID)
+GetSecurityUserInfo(
+    _In_opt_    PLUID LogonId,
+    _In_        ULONG Flags,
+    _Outptr_    PSecurityUserData *UserInformation)
 {
-    UNIMPLEMENTED_DBGBREAK();
+    UNIMPLEMENTED;
+    *UserInformation = NULL;
+    return STATUS_UNSUCCESSFUL;
 }
 
 SECURITY_STATUS