[ros-diffs] [reactos] 01/01: [ADVAPI32] Mute frequent taskmgr logspam CORE-18521 (#5888)

[Joachim Henze]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=561ad3c1d6ab4d5f617e5…

commit 561ad3c1d6ab4d5f617e54e03a3e9f0feb46cc70
Author:     Joachim Henze <joachim.henze(a)reactos.org>
AuthorDate: Sun Nov 5 18:32:13 2023 +0100
Commit:     GitHub <noreply(a)github.com>
CommitDate: Sun Nov 5 18:32:13 2023 +0100

    [ADVAPI32] Mute frequent taskmgr logspam CORE-18521 (#5888)
    
    
    George explained that this is supposed to fail like that,
    aka "works as designed". So let's at least mute this now,
    as it is spammed with every taskmgr refresh cycle
    and allows me to reduce logfile-sizes from ~50MB back to ~2MB
    when building ros on ros.
    
    err:(dll/win32/advapi32/wine/security.c:309) NtOpenProcessToken failed! Status
c0000022.
    
    Fixes CORE-18521
    
    Also strip some EOL-whitespace in the file, and slightly improve the header.
---
 dll/win32/advapi32/wine/security.c | 68 ++++++++++++++++++--------------------
 1 file changed, 33 insertions(+), 35 deletions(-)

diff --git a/dll/win32/advapi32/wine/security.c b/dll/win32/advapi32/wine/security.c
index 5a86b4d65c6..ac422625069 100644
--- a/dll/win32/advapi32/wine/security.c
+++ b/dll/win32/advapi32/wine/security.c
@@ -1,13 +1,11 @@
 /*
- * COPYRIGHT:       See COPYING in the top level directory
+ * PROJECT:     ReactOS system libraries
+ * LICENSE:     See COPYING in the top level directory
  * WINE COPYRIGHT:
  * Copyright 1999, 2000 Juergen Schmied <juergen.schmied(a)debitel.net>
  * Copyright 2003 CodeWeavers Inc. (Ulrich Czekalla)
  * Copyright 2006 Robert Reif
  * Copyright 2006 Hervé Poussineau
- *
- * PROJECT:         ReactOS system libraries
- * FILE:            dll/win32/advapi32/wine/security.c
  */
 
 #include <advapi32.h>
@@ -306,7 +304,7 @@ OpenProcessToken(HANDLE ProcessHandle,
                                 TokenHandle);
     if (!NT_SUCCESS(Status))
     {
-        ERR("NtOpenProcessToken failed! Status %08x.\n", Status);
+        WARN("NtOpenProcessToken failed! Status %08x\n", Status);
         SetLastError(RtlNtStatusToDosError(Status));
         return FALSE;
     }
@@ -2402,32 +2400,32 @@ BuildTrusteeWithNameW(PTRUSTEE_W pTrustee,
     pTrustee->ptstrName = name;
 }
 
-/****************************************************************************** 
- * GetTrusteeFormA [ADVAPI32.@] 
- */ 
-TRUSTEE_FORM WINAPI GetTrusteeFormA(PTRUSTEEA pTrustee) 
-{  
-    TRACE("(%p)\n", pTrustee); 
-  
-    if (!pTrustee) 
-        return TRUSTEE_BAD_FORM; 
-  
-    return pTrustee->TrusteeForm; 
-}  
-  
-/****************************************************************************** 
- * GetTrusteeFormW [ADVAPI32.@] 
- */ 
-TRUSTEE_FORM WINAPI GetTrusteeFormW(PTRUSTEEW pTrustee) 
-{  
-    TRACE("(%p)\n", pTrustee); 
-  
-    if (!pTrustee) 
-        return TRUSTEE_BAD_FORM; 
-  
-    return pTrustee->TrusteeForm; 
-}  
-  
+/******************************************************************************
+ * GetTrusteeFormA [ADVAPI32.@]
+ */
+TRUSTEE_FORM WINAPI GetTrusteeFormA(PTRUSTEEA pTrustee)
+{
+    TRACE("(%p)\n", pTrustee);
+
+    if (!pTrustee)
+        return TRUSTEE_BAD_FORM;
+
+    return pTrustee->TrusteeForm;
+}
+
+/******************************************************************************
+ * GetTrusteeFormW [ADVAPI32.@]
+ */
+TRUSTEE_FORM WINAPI GetTrusteeFormW(PTRUSTEEW pTrustee)
+{
+    TRACE("(%p)\n", pTrustee);
+
+    if (!pTrustee)
+        return TRUSTEE_BAD_FORM;
+
+    return pTrustee->TrusteeForm;
+}
+
 /******************************************************************************
  * GetTrusteeNameA [ADVAPI32.@]
  */
@@ -2758,10 +2756,10 @@ static DWORD ParseAceStringRights(LPCWSTR* StringAcl)
 
 /******************************************************************************
  * ParseStringAclToAcl
- * 
- * dacl_flags(string_ace1)(string_ace2)... (string_acen) 
+ *
+ * dacl_flags(string_ace1)(string_ace2)... (string_acen)
  */
-static BOOL ParseStringAclToAcl(LPCWSTR StringAcl, LPDWORD lpdwFlags, 
+static BOOL ParseStringAclToAcl(LPCWSTR StringAcl, LPDWORD lpdwFlags,
     PACL pAcl, LPDWORD cBytes)
 {
     DWORD val;
@@ -3551,7 +3549,7 @@ BOOL WINAPI ConvertStringSidToSidW(LPCWSTR StringSid, PSID* Sid)
 
         bret = ParseStringSidToSid(StringSid, pSid, &cBytes);
         if (!bret)
-            LocalFree(*Sid); 
+            LocalFree(*Sid);
     }
     return bret;
 }