[ros-diffs] [janderwald] 51252: [SNDVOL32] - Set Control variable to null, which prevents that mixer controls being assigned to another line when the current line does not have any controls. Bug was highlighte...

Author: janderwald
Date: Mon Apr  4 14:27:29 2011
New Revision: 51252

URL: http://svn.reactos.org/svn/reactos?rev=51252&view=rev
Log:
[SNDVOL32]
- Set Control variable to null, which prevents that mixer controls being assigned to
another line when the current line does not have any controls. Bug was highlighted when
opening the property window. In that case sndvol32 frees the previous setting, so all
mixer lines are also getting freed including their controls, which caused a double free in
the case the line did not have any controls assigned.

Modified:
    trunk/reactos/base/applications/sndvol32/mixer.c

Modified: trunk/reactos/base/applications/sndvol32/mixer.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndvol32…
==============================================================================
--- trunk/reactos/base/applications/sndvol32/mixer.c [iso-8859-1] (original)
+++ trunk/reactos/base/applications/sndvol32/mixer.c [iso-8859-1] Mon Apr  4 14:27:29
2011
@@ -189,7 +189,7 @@
                                   MIXER_GETLINEINFOF_SOURCE);
         if (Result == MMSYSERR_NOERROR)
         {
-            LPMIXERCONTROL Controls;
+            LPMIXERCONTROL Controls = NULL;
             PSND_MIXER_CONNECTION Con;
 
             DPRINT("++ Source: %ws\n", LineInfo.szName);