Re: [ros-diffs] [weiden] 15030: open the module image file with read access rights instead of full access rights

[Joseph Galbraith]

weiden(a)svn.reactos.com wrote:
>   open the module image file with read access rights
> instead of full access rights
>  
>  Modified: trunk/reactos/ntoskrnl/ldr/loader.c
>  
>  ------------------------------------------------------------------------
>  *Modified: trunk/reactos/ntoskrnl/ldr/loader.c*
>  
>  --- trunk/reactos/ntoskrnl/ldr/loader.c	2005-05-06 00:09:08 UTC (rev 15029)
>  +++ trunk/reactos/ntoskrnl/ldr/loader.c	2005-05-06 00:11:14 UTC (rev 15030)
>  @@ -311,7 +311,7 @@
>  
>           NULL);
>       CHECKPOINT;
>       Status = ZwOpenFile(&FileHandle,
>  
>  -        FILE_ALL_ACCESS,
>  
>  +        GENERIC_READ,
>  
>           &ObjectAttributes,
>           &IoStatusBlock,
>           0, 
Should these be FILE_EXECUTE_ACCESS?

I've never been quite clear on how FILE_EXECUTE_ACCESS works--
but if it should be used anyplace, it seems like the loader is
it?

Thanks,

Joseph