[ros-diffs] [hbelusca] 66138: [RTL] - Whitespace files. - Add missing PSEH inclusion (that can be detected if one comments the objbase.h include in rtl.h ...) [MKHIVE] Code cleanup + add a comment to explain w...

Author: hbelusca
Date: Sun Feb  1 13:33:06 2015
New Revision: 66138

URL: http://svn.reactos.org/svn/reactos?rev=66138&view=rev
Log:
[RTL]
- Whitespace files.
- Add missing PSEH inclusion (that can be detected if one comments the objbase.h include
in rtl.h ...)

[MKHIVE]
Code cleanup + add a comment to explain what this ntoskrnl.h file is.

Modified:
    trunk/reactos/lib/rtl/access.c
    trunk/reactos/lib/rtl/acl.c
    trunk/reactos/lib/rtl/atom.c
    trunk/reactos/lib/rtl/avltable.c
    trunk/reactos/lib/rtl/bootdata.c
    trunk/reactos/lib/rtl/byteswap.c
    trunk/reactos/lib/rtl/compress.c
    trunk/reactos/lib/rtl/crc32.c
    trunk/reactos/lib/rtl/dbgbuffer.c
    trunk/reactos/lib/rtl/dos8dot3.c
    trunk/reactos/lib/rtl/encode.c
    trunk/reactos/lib/rtl/exception.c
    trunk/reactos/lib/rtl/generictable.c
    trunk/reactos/lib/rtl/handle.c
    trunk/reactos/lib/rtl/heap.c
    trunk/reactos/lib/rtl/heappage.c
    trunk/reactos/lib/rtl/heapuser.c
    trunk/reactos/lib/rtl/image.c
    trunk/reactos/lib/rtl/largeint.c
    trunk/reactos/lib/rtl/luid.c
    trunk/reactos/lib/rtl/mem.c
    trunk/reactos/lib/rtl/memstream.c
    trunk/reactos/lib/rtl/message.c
    trunk/reactos/lib/rtl/rtl.h
    trunk/reactos/tools/mkhive/cmi.c
    trunk/reactos/tools/mkhive/ntoskrnl.h

Modified: trunk/reactos/lib/rtl/access.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/access.c?rev=66138…
==============================================================================
--- trunk/reactos/lib/rtl/access.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/access.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/access.c
  * PURPOSE:         Access rights handling functions

Modified: trunk/reactos/lib/rtl/acl.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/acl.c?rev=66138&am…
==============================================================================
--- trunk/reactos/lib/rtl/acl.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/acl.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         Security manager
  * FILE:            lib/rtl/acl.c

Modified: trunk/reactos/lib/rtl/atom.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/atom.c?rev=66138&a…
==============================================================================
--- trunk/reactos/lib/rtl/atom.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/atom.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/atom.c
  * PURPOSE:         Atom managment

Modified: trunk/reactos/lib/rtl/avltable.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/avltable.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/avltable.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/avltable.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,10 +1,10 @@
 /*
-* PROJECT:         ReactOS Runtime Library
-* LICENSE:         BSD - See COPYING.ARM in the top level directory
-* FILE:            lib/rtl/avltable.c
-* PURPOSE:         AVL Tree Generic Table Implementation
-* PROGRAMMERS:     ReactOS Portable Systems Group
-*/
+ * PROJECT:         ReactOS Runtime Library
+ * LICENSE:         BSD - See COPYING.ARM in the top level directory
+ * FILE:            lib/rtl/avltable.c
+ * PURPOSE:         AVL Tree Generic Table Implementation
+ * PROGRAMMERS:     ReactOS Portable Systems Group
+ */
 
 /* INCLUDES ******************************************************************/
 

Modified: trunk/reactos/lib/rtl/bootdata.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/bootdata.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/bootdata.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/bootdata.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         Boot Data implementation
  * FILE:            lib/rtl/bootdata.c

Modified: trunk/reactos/lib/rtl/byteswap.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/byteswap.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/byteswap.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/byteswap.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/mem.c
  * PURPOSE:         Memory functions

Modified: trunk/reactos/lib/rtl/compress.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/compress.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/compress.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/compress.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         Compression and decompression functions
  * FILE:            lib/rtl/compress.c

Modified: trunk/reactos/lib/rtl/crc32.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/crc32.c?rev=66138&…
==============================================================================
--- trunk/reactos/lib/rtl/crc32.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/crc32.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         crc32 functions
  * FILE:            lib/rtl/crc32.c

Modified: trunk/reactos/lib/rtl/dbgbuffer.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/dbgbuffer.c?rev=66…
==============================================================================
--- trunk/reactos/lib/rtl/dbgbuffer.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/dbgbuffer.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,8 +1,9 @@
-/* COPYRIGHT:       See COPYING in the top level directory
-* PROJECT:         ReactOS system libraries
-* FILE:            lib/rtl/dbgbuffer.c
-* PROGRAMER:       James Tabor
-*/
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
+ * PROJECT:         ReactOS system libraries
+ * FILE:            lib/rtl/dbgbuffer.c
+ * PROGRAMER:       James Tabor
+ */
 
 /* INCLUDES *****************************************************************/
 
@@ -14,8 +15,8 @@
 /* FUNCTIONS *****************************************************************/
 
 /*
-* @unimplemented
-*/
+ * @unimplemented
+ */
 PRTL_DEBUG_INFORMATION
 NTAPI
 RtlCreateQueryDebugBuffer(IN ULONG Size,
@@ -42,8 +43,8 @@
 }
 
 /*
-* @unimplemented
-*/
+ * @unimplemented
+ */
 NTSTATUS
 NTAPI
 RtlDestroyQueryDebugBuffer(IN PRTL_DEBUG_INFORMATION Buf)
@@ -66,9 +67,8 @@
 }
 
 /*
-*	Based on lib/epsapi/enum/modules.c by KJK::Hyperion.
-*
-*/
+ *  Based on lib/epsapi/enum/modules.c by KJK::Hyperion.
+ */
 NTSTATUS
 NTAPI
 RtlpQueryRemoteProcessModules(HANDLE ProcessHandle,
@@ -233,8 +233,8 @@
 }
 
 /*
-* @unimplemented
-*/
+ * @unimplemented
+ */
 NTSTATUS
 NTAPI
 RtlQueryProcessDebugInformation(IN ULONG ProcessId,

Modified: trunk/reactos/lib/rtl/dos8dot3.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/dos8dot3.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/dos8dot3.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/dos8dot3.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/dos8dot3.c
  * PURPOSE:         Short name (8.3 name) functions

Modified: trunk/reactos/lib/rtl/encode.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/encode.c?rev=66138…
==============================================================================
--- trunk/reactos/lib/rtl/encode.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/encode.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         Security descriptor functions
  * FILE:            lib/rtl/encode.c

Modified: trunk/reactos/lib/rtl/exception.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/exception.c?rev=66…
==============================================================================
--- trunk/reactos/lib/rtl/exception.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/exception.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS Runtime Library
  * PURPOSE:         User-Mode Exception Support
  * FILE:            lib/rtl/exception.c

Modified: trunk/reactos/lib/rtl/generictable.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/generictable.c?rev…
==============================================================================
--- trunk/reactos/lib/rtl/generictable.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/generictable.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,10 +1,10 @@
 /*
-* PROJECT:         ReactOS Runtime Library
-* LICENSE:         GPL - See COPYING in the top level directory
-* FILE:            lib/rtl/generictable.c
-* PURPOSE:         Splay Tree Generic Table Implementation
-* PROGRAMMERS:     Alex Ionescu (alex.ionescu(a)reactos.org)
-*/
+ * PROJECT:         ReactOS Runtime Library
+ * LICENSE:         GPL - See COPYING in the top level directory
+ * FILE:            lib/rtl/generictable.c
+ * PURPOSE:         Splay Tree Generic Table Implementation
+ * PROGRAMMERS:     Alex Ionescu (alex.ionescu(a)reactos.org)
+ */
 
 /* INCLUDES ******************************************************************/
 

Modified: trunk/reactos/lib/rtl/handle.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/handle.c?rev=66138…
==============================================================================
--- trunk/reactos/lib/rtl/handle.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/handle.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         Handle table
  * FILE:            lib/rtl/handle.c

Modified: trunk/reactos/lib/rtl/heap.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/heap.c?rev=66138&a…
==============================================================================
--- trunk/reactos/lib/rtl/heap.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/heap.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/heap.c
  * PURPOSE:         RTL Heap backend allocator

Modified: trunk/reactos/lib/rtl/heappage.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/heappage.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/heappage.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/heappage.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/heappage.c
  * PURPOSE:         RTL Page Heap implementation

Modified: trunk/reactos/lib/rtl/heapuser.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/heapuser.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/heapuser.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/heapuser.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/heap.c
  * PURPOSE:         RTL Heap backend allocator (user mode only functions)

Modified: trunk/reactos/lib/rtl/image.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/image.c?rev=66138&…
==============================================================================
--- trunk/reactos/lib/rtl/image.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/image.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/image.c
  * PURPOSE:         Image handling functions

Modified: trunk/reactos/lib/rtl/largeint.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/largeint.c?rev=661…
==============================================================================
--- trunk/reactos/lib/rtl/largeint.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/largeint.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/largeint.c
  * PURPOSE:         Large integer operations

Modified: trunk/reactos/lib/rtl/luid.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/luid.c?rev=66138&a…
==============================================================================
--- trunk/reactos/lib/rtl/luid.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/luid.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * PURPOSE:         Locally unique identifier (LUID) helper functions
  * FILE:            lib/rtl/luid.c

Modified: trunk/reactos/lib/rtl/mem.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/mem.c?rev=66138&am…
==============================================================================
--- trunk/reactos/lib/rtl/mem.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/mem.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/mem.c
  * PURPOSE:         Memory functions

Modified: trunk/reactos/lib/rtl/memstream.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/memstream.c?rev=66…
==============================================================================
--- trunk/reactos/lib/rtl/memstream.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/memstream.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/mem.c
  * PURPOSE:         MemoryStream functions

Modified: trunk/reactos/lib/rtl/message.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/message.c?rev=6613…
==============================================================================
--- trunk/reactos/lib/rtl/message.c	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/message.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,4 +1,5 @@
-/* COPYRIGHT:       See COPYING in the top level directory
+/*
+ * COPYRIGHT:       See COPYING in the top level directory
  * PROJECT:         ReactOS system libraries
  * FILE:            lib/rtl/message.c
  * PURPOSE:         Message table functions

Modified: trunk/reactos/lib/rtl/rtl.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/rtl.h?rev=66138&am…
==============================================================================
--- trunk/reactos/lib/rtl/rtl.h	[iso-8859-1] (original)
+++ trunk/reactos/lib/rtl/rtl.h	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -39,6 +39,9 @@
 #include <ndk/sefuncs.h>
 #include <ndk/umfuncs.h>
 
+/* SEH support with PSEH */
+#include <pseh/pseh2.h>
+
 /* Internal RTL header */
 #include "rtlp.h"
 

Modified: trunk/reactos/tools/mkhive/cmi.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/cmi.c?rev=661…
==============================================================================
--- trunk/reactos/tools/mkhive/cmi.c	[iso-8859-1] (original)
+++ trunk/reactos/tools/mkhive/cmi.c	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -219,7 +219,7 @@
     return Status;
 }
 
-NTSTATUS
+static NTSTATUS
 CmiCreateSubKey(
     IN PCMHIVE RegistryHive,
     IN HCELL_INDEX ParentKeyCellOffset,
@@ -363,6 +363,7 @@
     return STATUS_SUCCESS;
 }
 
+#if 0 // Those two functions seem to be unused, but keep them just in case we may need to
use them in the future...
 static BOOLEAN
 CmiCompareHash(
     IN PCUNICODE_STRING KeyName,
@@ -378,8 +379,7 @@
     return (strncmp(Buffer, HashString, 4) == 0);
 }
 
-
-BOOLEAN
+static BOOLEAN
 CmiCompareHashI(
     IN PCUNICODE_STRING KeyName,
     IN PCHAR HashString)
@@ -393,6 +393,7 @@
 
     return (strncasecmp(Buffer, HashString, 4) == 0);
 }
+#endif
 
 NTSTATUS
 CmiScanForSubKey(

Modified: trunk/reactos/tools/mkhive/ntoskrnl.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/ntoskrnl.h?re…
==============================================================================
--- trunk/reactos/tools/mkhive/ntoskrnl.h	[iso-8859-1] (original)
+++ trunk/reactos/tools/mkhive/ntoskrnl.h	[iso-8859-1] Sun Feb  1 13:33:06 2015
@@ -1,10 +1,6 @@
+/*
+ * This header is used together with cmindex.c and cmname.c
+ */
+
 #define NDEBUG
 #include "mkhive.h"
-
-PVOID
-NTAPI
-CmpAllocate(
-    IN SIZE_T Size,
-    IN BOOLEAN Paged,
-    IN ULONG Tag
-);