Re: [ros-diffs] [cgutman] 41213: - Export and hackplement NdisSetTimerEx - Implementation is #ifed out currently but I may enable it later - Hopefully somebody can think of a better way to do it than the current code

[Alex Ionescu]

There's nothing ugly about this -- this is exactly what the field is for.

Best regards,
Alex Ionescu



On Sat, May 30, 2009 at 4:07 PM,  <cgutman(a)svn.reactos.org> wrote:
>   Author: cgutman
>  Date: Sun May 31 03:07:13 2009
>  New Revision: 41213
>
>  URL: http://svn.reactos.org/svn/reactos?rev=41213&view=rev
>  Log:
>   - Export and hackplement NdisSetTimerEx
>   - Implementation is #ifed out currently but I may enable it later
>   - Hopefully somebody can think of a better way to do it than the current code
>
>  Modified:
>     trunk/reactos/drivers/network/ndis/ndis.def
>     trunk/reactos/drivers/network/ndis/ndis/time.c
>
>  Modified: trunk/reactos/drivers/network/ndis/ndis.def
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis.…
>  ==============================================================================
>  --- trunk/reactos/drivers/network/ndis/ndis.def [iso-8859-1] (original)
>  +++ trunk/reactos/drivers/network/ndis/ndis.def [iso-8859-1] Sun May 31 03:07:13 2009
>  @@ -257,6 +257,7 @@
>   NdisSetPacketPoolProtocolId@8
>   ;NdisSetProtocolFilter ?
>   NdisSetTimer@8
>  +NdisSetTimerEx@12
>   NdisSetupDmaTransfer@24
>   NdisSystemProcessorCount@0
>   NdisTerminateWrapper@8
>
>  Modified: trunk/reactos/drivers/network/ndis/ndis/time.c
>  URL:
> http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/…
>  ==============================================================================
>  --- trunk/reactos/drivers/network/ndis/ndis/time.c [iso-8859-1] (original)
>  +++ trunk/reactos/drivers/network/ndis/ndis/time.c [iso-8859-1] Sun May 31 03:07:13 2009
>  @@ -243,5 +243,26 @@
>    KeSetTimer (&Timer->Timer, Timeout, &Timer->Dpc);
>   }
>
>  +VOID
>  +EXPORT
>  +NdisSetTimerEx(
>  +    IN PNDIS_TIMER  Timer,
>  +    IN UINT  MillisecondsToDelay,
>  +    IN PVOID  FunctionContext)
>  +{
>  +#if 0
>  +    /* FIXME: I'm not sure how to this in a nice way
>  +     * We can't store the function context anywhere in NDIS_TIMER
>  +     * so I'm forced to do this
>  +     */
>  +
>  +    Timer->Dpc.DeferredContext = FunctionContext;
>  +
>  +    NdisSetTimer(Timer, MillisecondsToDelay);
>  +#else
>  +    UNIMPLEMENTED
>  +#endif
>  +}
>  +
>   /* EOF */
>
>
>