[ros-diffs] [reactos] 01/01: [SDK] Add dummy import lib files for MSVC_IDE build, to work around a CMake bug generating broken dll targets ROSBE-159

[Mark Jansen]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5730485a51d8bb58ff9f8…

commit 5730485a51d8bb58ff9f8f2131b85c128510a6b6
Author:     Mark Jansen <mark.jansen(a)reactos.org>
AuthorDate: Thu Sep 10 22:03:52 2020 +0200
Commit:     Mark Jansen <mark.jansen(a)reactos.org>
CommitDate: Sun Sep 20 19:18:15 2020 +0200

    [SDK] Add dummy import lib files for MSVC_IDE build,
    to work around a CMake bug generating broken dll targets
    ROSBE-159
---
 sdk/cmake/msvc.cmake | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake
index 94847a84167..e1899089a6f 100644
--- a/sdk/cmake/msvc.cmake
+++ b/sdk/cmake/msvc.cmake
@@ -172,6 +172,13 @@ string(REPLACE "/implib:<TARGET_IMPLIB>" ""
CMAKE_CXX_CREATE_SHARED_LIBRARY "${C
 string(REPLACE "/implib:<TARGET_IMPLIB>" ""
CMAKE_C_CREATE_SHARED_MODULE "${CMAKE_C_CREATE_SHARED_MODULE}")
 string(REPLACE "/implib:<TARGET_IMPLIB>" ""
CMAKE_CXX_CREATE_SHARED_MODULE "${CMAKE_CXX_CREATE_SHARED_MODULE}")
 
+# HACK2: CMake lacks the ability to completely remove the 'implib' argument for
solution files...
+# To work around this, we just let it create a dummy file
+if(MSVC_IDE)
+    set(CMAKE_IMPORT_LIBRARY_SUFFIX ".dummy")
+endif()
+
+
 if(CMAKE_DISABLE_NINJA_DEPSLOG)
     set(cl_includes_flag "")
 else()