[ros-diffs] [reactos] 05/05: [CMAKE] Add 3 more critical warnings for MSVC - C4311: pointer truncation from '<pointer>' to '<integer>' - C4312: conversion from '<integer>' to '<pointer>' of greater size - C4133: incompatible types - from '<x> *' to '<y> *' - C4028: formal parameter different from declaration

[Timo Kreuzer]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=545a2c79367e1457e4bc7…

commit 545a2c79367e1457e4bc7ac14d3c0f840c7e063c
Author:     Timo Kreuzer <timo.kreuzer(a)reactos.org>
AuthorDate: Tue Feb 27 22:00:40 2018 +0100
Commit:     Timo Kreuzer <timo.kreuzer(a)reactos.org>
CommitDate: Sat Apr 13 14:07:50 2019 +0200

    [CMAKE] Add 3 more critical warnings for MSVC
    - C4311: pointer truncation from '<pointer>' to
'<integer>'
    - C4312: conversion from '<integer>' to '<pointer>' of
greater size
    - C4133: incompatible types - from '<x> *' to '<y> *'
    - C4028: formal parameter different from declaration
---
 sdk/cmake/msvc.cmake | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/sdk/cmake/msvc.cmake b/sdk/cmake/msvc.cmake
index 6eec2b15bcd..8419591b8b5 100644
--- a/sdk/cmake/msvc.cmake
+++ b/sdk/cmake/msvc.cmake
@@ -90,13 +90,15 @@ add_compile_flags("/wd4018")
 # - C4098: void function returning a value
 # - C4113: parameter lists differ
 # - C4129: unrecognized escape sequence
-# - TODO: C4133: incompatible types
+# - C4133: incompatible types - from '<x> *' to '<y> *'
 # - C4163: 'identifier': not available as an intrinsic function
 # - C4229: modifiers on data are ignored
-# - C4700: uninitialized variable usage
+# - C4311: pointer truncation from '<pointer>' to
'<integer>'
+# - C4312: conversion from '<integer>' to '<pointer>' of
greater size
 # - C4603: macro is not defined or definition is different after precompiled header use
+# - C4700: uninitialized variable usage
 # - C4716: function must return a value
-add_compile_flags("/we4013 /we4020 /we4022 /we4047 /we4098 /we4113 /we4129 /we4163
/we4229 /we4700 /we4603 /we4716")
+add_compile_flags("/we4013 /we4020 /we4022 /we4028 /we4047 /we4098 /we4113 /we4129
/we4133 /we4163 /we4229 /we4311 /we4312 /we4603 /we4700 /we4716")
 # TODO: Check and fix other architectures.
 if(ARCH STREQUAL "i386")
     add_compile_flags("/we4028")