[ros-diffs] [tkreuzer] 56421: [GDI32] Fix CombineTransform to pass all tests

Author: tkreuzer
Date: Wed Apr 25 15:20:55 2012
New Revision: 56421

URL: http://svn.reactos.org/svn/reactos?rev=56421&view=rev
Log:
[GDI32]
Fix CombineTransform to pass all tests

Modified:
    trunk/reactos/win32ss/gdi/gdi32/objects/coord.c

Modified: trunk/reactos/win32ss/gdi/gdi32/objects/coord.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/gdi32/objects/c...
==============================================================================
--- trunk/reactos/win32ss/gdi/gdi32/objects/coord.c [iso-8859-1] (original)
+++ trunk/reactos/win32ss/gdi/gdi32/objects/coord.c [iso-8859-1] Wed Apr 25 15:20:55 2012
@@ -56,7 +56,8 @@
     GdiTransformPoints2(&xform, pptOut, pptIn, nCount);
 }

-#define MAX_OFFSET 4294967040.0
+#define MAX_OFFSET 4294967041.0
+#define _fmul(x,y) (((x) == 0) ? 0 : (x) * (y))

BOOL
 WINAPI
@@ -70,31 +71,39 @@
     /* Check paramters */
     if (!pxfResult || !pxf1 || !pxf2) return FALSE;

-    /* Do matrix multiplication */
-    xformTmp.eM11 = pxf1->eM11 * pxf2->eM11 + pxf1->eM12 * pxf2->eM21;
-    xformTmp.eM12 = pxf1->eM11 * pxf2->eM12 + pxf1->eM12 * pxf2->eM22;
-    xformTmp.eM21 = pxf1->eM21 * pxf2->eM11 + pxf1->eM22 * pxf2->eM21;
-    xformTmp.eM22 = pxf1->eM21 * pxf2->eM12 + pxf1->eM22 * pxf2->eM22;
-    xformTmp.eDx = pxf1->eDx * pxf2->eM11 + pxf1->eDy * pxf2->eM21 + pxf2->eDx;
-    xformTmp.eDy = pxf1->eDx * pxf2->eM12 + pxf1->eDy * pxf2->eM22 + pxf2->eDy;
-
+    /* Do matrix multiplication, start with scaling elements */
+    xformTmp.eM11 = (pxf1->eM11 * pxf2->eM11) + (pxf1->eM12 * pxf2->eM21);
+    xformTmp.eM22 = (pxf1->eM21 * pxf2->eM12) + (pxf1->eM22 * pxf2->eM22);
+
+    /* Calculate shear/rotate elements only of they are present */
+    if ((pxf1->eM12 != 0.) || (pxf1->eM21 != 0.) ||
+        (pxf2->eM12 != 0.) || (pxf2->eM21 != 0.))
+    {
+        xformTmp.eM12 = (pxf1->eM11 * pxf2->eM12) + (pxf1->eM12 * pxf2->eM22);
+        xformTmp.eM21 = (pxf1->eM21 * pxf2->eM11) + (pxf1->eM22 * pxf2->eM21);
+    }
+    else
+    {
+        xformTmp.eM12 = 0.;
+        xformTmp.eM21 = 0.;
+    }
+
+    /* Calculate the offset */
+    xformTmp.eDx = _fmul(pxf1->eDx, pxf2->eM11) + _fmul(pxf1->eDy, pxf2->eM21) + pxf2->eDx;
+    xformTmp.eDy = _fmul(pxf1->eDx, pxf2->eM12) + _fmul(pxf1->eDy, pxf2->eM22) + pxf2->eDy;
+
+    /* Check for invalid offset ranges */
+    if ((xformTmp.eDx > MAX_OFFSET) || (xformTmp.eDx < -MAX_OFFSET) ||
+        (xformTmp.eDy > MAX_OFFSET) || (xformTmp.eDy < -MAX_OFFSET))
+    {
+        return FALSE;
+    }
+
+    /* All is ok, return the calculated values */
     *pxfResult = xformTmp;
-#if 0
-    /* windows compatibility fixups (needs more work) */
-    if (_isnan(xformTmp.eM12))
-    {
-        if (pxf1->eM11 == 0 || pxf2->eM12 == 0) pxfResult->eM12 = 0.;
-    }
-#endif
-    /* Check for invalid offset ranges */
-    if (xformTmp.eDx > MAX_OFFSET || xformTmp.eDx < -MAX_OFFSET ||
-        xformTmp.eDy > MAX_OFFSET || xformTmp.eDy < -MAX_OFFSET)
-    {
-        return FALSE;
-    }
-
-    return TRUE;
-}
+    return TRUE;
+}
+

BOOL
 WINAPI