[ros-diffs] 01/01: [NETAPI] Implement NetGroupGetInfo

[Eric Kohl]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=a9da3c50bea58d0c1bf0d…

commit a9da3c50bea58d0c1bf0d2925a90cb449cd2a38c
Author:     Eric Kohl <eric.kohl(a)reactos.org>
AuthorDate: Sun Sep 9 09:40:11 2018 +0200
Commit:     Eric Kohl <eric.kohl(a)reactos.org>
CommitDate: Sun Sep 9 09:40:11 2018 +0200

    [NETAPI] Implement NetGroupGetInfo
---
 dll/win32/netapi32/group.c     |  17 -----
 dll/win32/netapi32/group_new.c | 163 ++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 162 insertions(+), 18 deletions(-)

diff --git a/dll/win32/netapi32/group.c b/dll/win32/netapi32/group.c
index cac6be73b0..7139f1b3b6 100644
--- a/dll/win32/netapi32/group.c
+++ b/dll/win32/netapi32/group.c
@@ -86,23 +86,6 @@ NetGroupDelUser(IN LPCWSTR servername,
 }
 
 
-/************************************************************
- * NetGroupGetInfo  (NETAPI32.@)
- *
- */
-NET_API_STATUS
-WINAPI
-NetGroupGetInfo(IN LPCWSTR servername,
-                IN LPCWSTR groupname,
-                IN DWORD level,
-                OUT LPBYTE *bufptr)
-{
-    FIXME("(%s, %s, %d, %p) stub!\n", debugstr_w(servername),
-          debugstr_w(groupname), level, bufptr);
-    return ERROR_ACCESS_DENIED;
-}
-
-
 /************************************************************
  * NetGroupGetUsers  (NETAPI32.@)
  *
diff --git a/dll/win32/netapi32/group_new.c b/dll/win32/netapi32/group_new.c
index 5fa38313cf..7e4f9ef0a1 100644
--- a/dll/win32/netapi32/group_new.c
+++ b/dll/win32/netapi32/group_new.c
@@ -192,7 +192,7 @@ done:
 static
 VOID
 FreeGroupInfo(
-    PGROUP_GENERAL_INFORMATION GroupInfo)
+    _In_ PGROUP_GENERAL_INFORMATION GroupInfo)
 {
     if (GroupInfo->Name.Buffer != NULL)
         SamFreeMemory(GroupInfo->Name.Buffer);
@@ -204,6 +204,66 @@ FreeGroupInfo(
 }
 
 
+static
+NET_API_STATUS
+OpenGroupByName(
+    _In_ SAM_HANDLE DomainHandle,
+    _In_ PUNICODE_STRING GroupName,
+    _In_ ULONG DesiredAccess,
+    _Out_ PSAM_HANDLE GroupHandle,
+    _Out_ PULONG RelativeId)
+{
+    PULONG RelativeIds = NULL;
+    PSID_NAME_USE Use = NULL;
+    NET_API_STATUS ApiStatus = NERR_Success;
+    NTSTATUS Status = STATUS_SUCCESS;
+
+    /* Get the RID for the given user name */
+    Status = SamLookupNamesInDomain(DomainHandle,
+                                    1,
+                                    GroupName,
+                                    &RelativeIds,
+                                    &Use);
+    if (!NT_SUCCESS(Status))
+    {
+        ERR("SamLookupNamesInDomain failed (Status %08lx)\n", Status);
+        return NetpNtStatusToApiStatus(Status);
+    }
+
+    /* Fail, if it is not an alias account */
+    if (Use[0] != SidTypeGroup)
+    {
+        ERR("Object is not a group!\n");
+        ApiStatus = NERR_GroupNotFound;
+        goto done;
+    }
+
+    /* Open the alias account */
+    Status = SamOpenGroup(DomainHandle,
+                          DesiredAccess,
+                          RelativeIds[0],
+                          GroupHandle);
+    if (!NT_SUCCESS(Status))
+    {
+        ERR("SamOpenGroup failed (Status %08lx)\n", Status);
+        ApiStatus = NetpNtStatusToApiStatus(Status);
+        goto done;
+    }
+
+    if (RelativeId != NULL)
+        *RelativeId = RelativeIds[0];
+
+done:
+    if (RelativeIds != NULL)
+        SamFreeMemory(RelativeIds);
+
+    if (Use != NULL)
+        SamFreeMemory(Use);
+
+    return ApiStatus;
+}
+
+
 /* PUBLIC FUNCTIONS **********************************************************/
 
 NET_API_STATUS
@@ -454,4 +514,105 @@ done:
     return ApiStatus;
 }
 
+
+NET_API_STATUS
+WINAPI
+NetGroupGetInfo(
+    _In_opt_ LPCWSTR servername,
+    _In_ LPCWSTR groupname,
+    _In_ DWORD level,
+    _Out_ LPBYTE *bufptr)
+{
+    UNICODE_STRING ServerName;
+    UNICODE_STRING GroupName;
+    SAM_HANDLE ServerHandle = NULL;
+    SAM_HANDLE DomainHandle = NULL;
+    SAM_HANDLE GroupHandle = NULL;
+    PGROUP_GENERAL_INFORMATION GroupInfo = NULL;
+    PVOID Buffer = NULL;
+    ULONG RelativeId;
+    NET_API_STATUS ApiStatus = NERR_Success;
+    NTSTATUS Status = STATUS_SUCCESS;
+
+    TRACE("NetGroupGetInfo(%s, %s, %d, %p)\n",
+          debugstr_w(servername), debugstr_w(groupname), level, bufptr);
+
+    if (servername != NULL)
+        RtlInitUnicodeString(&ServerName, servername);
+
+    RtlInitUnicodeString(&GroupName, groupname);
+
+    /* Connect to the SAM Server */
+    Status = SamConnect((servername != NULL) ? &ServerName : NULL,
+                        &ServerHandle,
+                        SAM_SERVER_CONNECT | SAM_SERVER_LOOKUP_DOMAIN,
+                        NULL);
+    if (!NT_SUCCESS(Status))
+    {
+        ERR("SamConnect failed (Status %08lx)\n", Status);
+        ApiStatus = NetpNtStatusToApiStatus(Status);
+        goto done;
+    }
+
+    /* Open the Acount Domain */
+    Status = OpenAccountDomain(ServerHandle,
+                               (servername != NULL) ? &ServerName : NULL,
+                               DOMAIN_LOOKUP,
+                               &DomainHandle);
+    if (!NT_SUCCESS(Status))
+    {
+        ERR("OpenAccountDomain failed (Status %08lx)\n", Status);
+        ApiStatus = NetpNtStatusToApiStatus(Status);
+        goto done;
+    }
+
+    /* Open the group account in the account domain */
+    ApiStatus = OpenGroupByName(DomainHandle,
+                                &GroupName,
+                                GROUP_READ_INFORMATION,
+                                &GroupHandle,
+                                &RelativeId);
+    if (ApiStatus != NERR_Success)
+    {
+        ERR("OpenGroupByName failed (ApiStatus %lu)\n", ApiStatus);
+        if (ApiStatus == ERROR_NONE_MAPPED)
+            ApiStatus = NERR_GroupNotFound;
+        goto done;
+    }
+
+    Status = SamQueryInformationGroup(GroupHandle,
+                                      GroupGeneralInformation,
+                                      (PVOID *)&GroupInfo);
+    if (!NT_SUCCESS(Status))
+    {
+        ERR("SamQueryInformationGroup failed (Status %08lx)\n", Status);
+        ApiStatus = NetpNtStatusToApiStatus(Status);
+        goto done;
+    }
+
+    ApiStatus = BuildGroupInfoBuffer(GroupInfo,
+                                     level,
+                                     RelativeId,
+                                     &Buffer);
+    if (ApiStatus != NERR_Success)
+        goto done;
+
+done:
+    if (GroupInfo != NULL)
+        FreeGroupInfo(GroupInfo);
+
+    if (GroupHandle != NULL)
+        SamCloseHandle(GroupHandle);
+
+    if (DomainHandle != NULL)
+        SamCloseHandle(DomainHandle);
+
+    if (ServerHandle != NULL)
+        SamCloseHandle(ServerHandle);
+
+    *bufptr = (LPBYTE)Buffer;
+
+    return ApiStatus;
+}
+
 /* EOF */