[ros-diffs] [weiden] 20968: implement the object types SE_REGISTRY_KEY, SE_FILE_OBJECT, SE_SERVICE and SE_WINDOW_OBJECT for GetSecurityInfo()

implement the object types SE_REGISTRY_KEY, SE_FILE_OBJECT, SE_SERVICE
and SE_WINDOW_OBJECT for GetSecurityInfo()
Modified: trunk/reactos/lib/ntmarta/ntmarta.c
Modified: trunk/reactos/lib/ntmarta/ntmarta.h
  _____  

Modified: trunk/reactos/lib/ntmarta/ntmarta.c
--- trunk/reactos/lib/ntmarta/ntmarta.c	2006-01-22 03:07:21 UTC (rev
20967)
+++ trunk/reactos/lib/ntmarta/ntmarta.c	2006-01-22 03:27:21 UTC (rev
20968)
@@ -49,7 +49,7 @@

                           PSECURITY_DESCRIPTOR* ppSecurityDescriptor)
 {
     PSECURITY_DESCRIPTOR pSD = NULL;
-    ULONG RequiredSize, SDSize = 0;
+    ULONG SDSize = 0;
     NTSTATUS Status;
     DWORD LastErr;
     DWORD Ret = ERROR_SUCCESS;
@@ -57,59 +57,83 @@
     /* save the last error code */
     LastErr = GetLastError();
 
-AllocBuffer:
-    /* allocate a buffer large enough to hold the
-       security descriptor we need to return */
-    SDSize += 0x100;
-    if (pSD != NULL)
+    do
     {
-        pSD = LocalAlloc(LMEM_FIXED,
-                         (SIZE_T)SDSize);
-    }
-    else
-    {
-        pSD = LocalReAlloc((HLOCAL)pSD,
-                           (SIZE_T)SDSize,
-                           LMEM_MOVEABLE);
-    }
+        /* allocate a buffer large enough to hold the
+           security descriptor we need to return */
+        SDSize += 0x100;
+        if (pSD != NULL)
+        {
+            pSD = LocalAlloc(LMEM_FIXED,
+                             (SIZE_T)SDSize);
+        }
+        else
+        {
+            pSD = LocalReAlloc((HLOCAL)pSD,
+                               (SIZE_T)SDSize,
+                               LMEM_MOVEABLE);
+        }
 
-    if (pSD == NULL)
-    {
-        Ret = GetLastError();
-        goto Cleanup;
-    }
+        if (pSD == NULL)
+        {
+            Ret = GetLastError();
+            break;
+        }
 
-    /* perform the actual query depending on the object type */
-    switch (ObjectType)
-    {
-        case SE_KERNEL_OBJECT:
+        /* perform the actual query depending on the object type */
+        switch (ObjectType)
         {
-            Status = NtQuerySecurityObject(handle,
-                                           SecurityInfo,
-                                           pSD,
-                                           SDSize,
-                                           &RequiredSize);
-            if (Status == STATUS_BUFFER_TOO_SMALL)
+            case SE_REGISTRY_KEY:
             {
-                /* not enough memory, increase the size of
-                   the buffer and try again */
-                ASSERT(RequiredSize > SDSize);
-                SDSize = RequiredSize;
-                goto AllocBuffer;
+                Ret = RegGetKeySecurity((HKEY)handle,
+                                        SecurityInfo,
+                                        pSD,
+                                        &SDSize);
+                break;
             }
-            Ret = RtlNtStatusToDosError(Status);
-            break;
-        }
 
-        default:
-        {
-            UNIMPLEMENTED;
-            Ret = ERROR_CALL_NOT_IMPLEMENTED;
-            break;
+            case SE_FILE_OBJECT:
+            case SE_KERNEL_OBJECT:
+            {
+                Status = NtQuerySecurityObject(handle,
+                                               SecurityInfo,
+                                               pSD,
+                                               SDSize,
+                                               &SDSize);
+                Ret = RtlNtStatusToDosError(Status);
+                break;
+            }
+
+            case SE_SERVICE:
+            {
+                Ret = QueryServiceObjectSecurity((SC_HANDLE)handle,
+                                                 SecurityInfo,
+                                                 pSD,
+                                                 SDSize,
+                                                 &SDSize);
+                break;
+            }
+
+            case SE_WINDOW_OBJECT:
+            {
+                Ret = GetUserObjectSecurity(handle,
+                                            &SecurityInfo,
+                                            pSD,
+                                            SDSize,
+                                            &SDSize);
+                break;
+            }
+
+            default:
+            {
+                UNIMPLEMENTED;
+                Ret = ERROR_CALL_NOT_IMPLEMENTED;
+                break;
+            }
         }
-    }
 
-Cleanup:
+    } while (Ret == ERROR_INSUFFICIENT_BUFFER);
+
     if (Ret == ERROR_SUCCESS)
     {
         *ppSecurityDescriptor = pSD;
  _____  

Modified: trunk/reactos/lib/ntmarta/ntmarta.h
--- trunk/reactos/lib/ntmarta/ntmarta.h	2006-01-22 03:07:21 UTC (rev
20967)
+++ trunk/reactos/lib/ntmarta/ntmarta.h	2006-01-22 03:27:21 UTC (rev
20968)
@@ -3,6 +3,7 @@

 #include <windows.h>
 #include <ndk/ntndk.h>
 #include <accctrl.h>
+#include <winsvc.h>
 
 #ifndef HAS_FN_PROGRESSW
 #define FN_PROGRESSW FN_PROGRESS