[ros-diffs] [reactos] 01/01: [UMPNPMGR] Add missing parameter checks to PNP_GetDeviceStatus

[Eric Kohl]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=830e15b622515b3f70e7ca...

commit 830e15b622515b3f70e7cafc07d15173fa3df1b1
Author:     Eric Kohl [e-mail]
AuthorDate: Mon Jun 21 21:33:24 2021 +0200
Commit:     Eric Kohl [e-mail]
CommitDate: Mon Jun 21 21:33:24 2021 +0200

[UMPNPMGR] Add missing parameter checks to PNP_GetDeviceStatus
---
 base/services/umpnpmgr/rpcserver.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/base/services/umpnpmgr/rpcserver.c b/base/services/umpnpmgr/rpcserver.c
index d84e0cab4ff..bb63bce02bd 100644
--- a/base/services/umpnpmgr/rpcserver.c
+++ b/base/services/umpnpmgr/rpcserver.c
@@ -22,7 +22,7 @@
  * FILE:             base/services/umpnpmgr/rpcserver.c
  * PURPOSE:          RPC server
  * PROGRAMMER:       Eric Kohl ([e-mail])
- *                   Herv� Poussineau ([e-mail])
+ *                   Hervé Poussineau ([e-mail])
  *                   Colin Finck ([e-mail])
  */

@@ -3199,6 +3199,12 @@ PNP_GetDeviceStatus(
     DPRINT("PNP_GetDeviceStatus(%p %S %p %p 0x%08lx)\n",
            hBinding, pDeviceID, pulStatus, pulProblem, ulFlags);

+    if (ulFlags != 0)
+        return CR_INVALID_FLAG;
+
+    if ((pulStatus == NULL) || (pulProblem == NULL))
+        return CR_INVALID_POINTER;
+
     if (!IsValidDeviceInstanceID(pDeviceID))
         return CR_INVALID_DEVINST;