[ros-diffs] [tfaber] 68870: [TCPIP_DRVTEST] - Handle errors to avoid uninitialized variable usage

Author: tfaber
Date: Sun Aug 30 09:31:23 2015
New Revision: 68870

URL: http://svn.reactos.org/svn/reactos?rev=68870&view=rev
Log:
[TCPIP_DRVTEST]
- Handle errors to avoid uninitialized variable usage

Modified:
    trunk/rostests/drivers/tcpip/InterfaceInfo.c

Modified: trunk/rostests/drivers/tcpip/InterfaceInfo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/drivers/tcpip/InterfaceIn…
==============================================================================
--- trunk/rostests/drivers/tcpip/InterfaceInfo.c	[iso-8859-1] (original)
+++ trunk/rostests/drivers/tcpip/InterfaceInfo.c	[iso-8859-1] Sun Aug 30 09:31:23 2015
@@ -19,6 +19,7 @@
     HANDLE FileHandle;
     DWORD BufferSize;
     BOOL Result;
+    DWORD Error;
     ULONG i;
 
     /* Open a control channel file for TCP */
@@ -44,8 +45,9 @@
         sizeof(InterfaceInfo),
         &BufferSize,
         NULL);
+    Error = GetLastError();
     ok(!Result, "DeviceIoControl succeeded.\n");
-    ok_long(GetLastError(), ERROR_INVALID_FUNCTION);
+    ok_long(Error, ERROR_INVALID_FUNCTION);
     ok_long(BufferSize, 0);
 
     CloseHandle(FileHandle);
@@ -73,7 +75,7 @@
         sizeof(InterfaceInfo),
         &BufferSize,
         NULL);
-    ok(Result, "DeviceIoControl failed.\n");
+    ok(Result, "DeviceIoControl failed, GLE %lu.\n", GetLastError());
     ok(BufferSize != 0, "Buffer size is zero.\n");
     trace("Buffer size is %lu.\n", BufferSize);
 
@@ -92,14 +94,17 @@
                 BufferSize,
                 &BufferSize,
                 NULL);
-        ok(Result, "DeviceIoControl failed.\n");
+        ok(Result, "DeviceIoControl failed, GLE %lu.\n", GetLastError());
     }
 
-    /* Nothing much to test. Just print out the adapters we got */
-    trace("We got %ld adapters.\n", pInterfaceInfo->NumAdapters);
-    for (i = 0; i < pInterfaceInfo->NumAdapters; i++)
+    if (Result && BufferSize >= RTL_SIZEOF_THROUGH_FIELD(IP_INTERFACE_INFO,
NumAdapters))
     {
-        trace("\tIndex %lu, name %S\n", pInterfaceInfo->Adapter[i].Index,
pInterfaceInfo->Adapter[i].Name);
+        /* Nothing much to test. Just print out the adapters we got */
+        trace("We got %ld adapters.\n", pInterfaceInfo->NumAdapters);
+        for (i = 0; i < pInterfaceInfo->NumAdapters; i++)
+        {
+            trace("\tIndex %lu, name %S\n",
pInterfaceInfo->Adapter[i].Index, pInterfaceInfo->Adapter[i].Name);
+        }
     }
 
     if (pInterfaceInfo != &InterfaceInfo)