[ros-diffs] [akhaldi] 61502: [USBEHCI] * Remove inclusions that already exist in the main header. * Cleanup the main header. * Improve the GUIDs situation. CORE-7716

Author: akhaldi
Date: Fri Jan  3 17:23:55 2014
New Revision: 61502

URL: http://svn.reactos.org/svn/reactos?rev=61502&view=rev
Log:
[USBEHCI]
* Remove inclusions that already exist in the main header.
* Cleanup the main header.
* Improve the GUIDs situation.
CORE-7716

Added:
    trunk/reactos/drivers/usb/usbehci/guid.cpp   (with props)
Modified:
    trunk/reactos/drivers/usb/usbehci/CMakeLists.txt
    trunk/reactos/drivers/usb/usbehci/hardware.h
    trunk/reactos/drivers/usb/usbehci/interfaces.h
    trunk/reactos/drivers/usb/usbehci/usbehci.h

Modified: trunk/reactos/drivers/usb/usbehci/CMakeLists.txt
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/CMakeL…
==============================================================================
--- trunk/reactos/drivers/usb/usbehci/CMakeLists.txt	[iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/usbehci/CMakeLists.txt	[iso-8859-1] Fri Jan  3 17:23:55
2014
@@ -10,7 +10,8 @@
     usbehci.cpp
     usb_request.cpp
     usb_queue.cpp
-    hardware.cpp)
+    hardware.cpp
+    guid.cpp)
 
 add_library(usbehci SHARED
     ${SOURCE}

Added: trunk/reactos/drivers/usb/usbehci/guid.cpp
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/guid.c…
==============================================================================
--- trunk/reactos/drivers/usb/usbehci/guid.cpp	(added)
+++ trunk/reactos/drivers/usb/usbehci/guid.cpp	[iso-8859-1] Fri Jan  3 17:23:55 2014
@@ -0,0 +1,6 @@
+/* DO NOT USE THE PRECOMPILED HEADER FOR THIS FILE! */
+
+#include <initguid.h>
+#include <libusb.h>
+
+/* NO CODE HERE, THIS IS JUST REQUIRED FOR THE GUID DEFINITIONS */

Propchange: trunk/reactos/drivers/usb/usbehci/guid.cpp
------------------------------------------------------------------------------
    svn:eol-style = native

Modified: trunk/reactos/drivers/usb/usbehci/hardware.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/hardwa…
==============================================================================
--- trunk/reactos/drivers/usb/usbehci/hardware.h	[iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/usbehci/hardware.h	[iso-8859-1] Fri Jan  3 17:23:55 2014
@@ -1,7 +1,4 @@
 #pragma once
-
-#include <ntddk.h>
-
 
 //
 // Host Controller Capability Registers
@@ -325,4 +322,4 @@
 #define EHCI_QH_CAPS_SCM_SHIFT  8			// Split Completion Mask
 #define EHCI_QH_CAPS_SCM_MASK   0xff
 #define EHCI_QH_CAPS_ISM_SHIFT  0			// Interrupt Schedule Mask
-#define EHCI_QH_CAPS_ISM_MASK  0xff
+#define EHCI_QH_CAPS_ISM_MASK  0xff

Modified: trunk/reactos/drivers/usb/usbehci/interfaces.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/interf…
==============================================================================
--- trunk/reactos/drivers/usb/usbehci/interfaces.h	[iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/usbehci/interfaces.h	[iso-8859-1] Fri Jan  3 17:23:55 2014
@@ -1,9 +1,5 @@
-
 #ifndef INTERFACES_HPP
 #define INTERFACES_HPP
-
-#include "libusb.h"
-
 

//=========================================================================================
 //
@@ -152,4 +148,4 @@
 
 typedef IEHCIQueue *PEHCIQUEUE;
 
-#endif
+#endif /* INTERFACES_HPP */

Modified: trunk/reactos/drivers/usb/usbehci/usbehci.h
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbehci/usbehc…
==============================================================================
--- trunk/reactos/drivers/usb/usbehci/usbehci.h	[iso-8859-1] (original)
+++ trunk/reactos/drivers/usb/usbehci/usbehci.h	[iso-8859-1] Fri Jan  3 17:23:55 2014
@@ -1,35 +1,7 @@
 #ifndef USBEHCI_H__
 #define USBEHCI_H__
 
-#define INITGUID
-
-#include <ntddk.h>
-#include <hubbusif.h>
-#include <usbbusif.h>
-#include <usbioctl.h>
-
-extern "C"
-{
-#include <usbdlib.h>
-}
-
-
-
-//
-// FIXME: 
-// #include <usbprotocoldefs.h>
-//
-#include <usb.h>
-#include <stdio.h>
-#include <wdmguid.h>
-
-//
-// FIXME:
-// the following includes are required to get kcom to compile
-//
-#include <portcls.h>
-#include <dmusicks.h>
-#include <kcom.h>
+#include <libusb.h>
 
 #include "hardware.h"
 #include "interfaces.h"
@@ -61,4 +33,4 @@
 //
 NTSTATUS NTAPI InternalCreateUSBRequest(PUSBREQUEST *OutRequest);
 
-#endif
+#endif /* USBEHCI_H__ */