[ros-diffs] [reactos] 01/01: [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)

[Joachim Henze]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5ee97b95370cc1ad05d94…

commit 5ee97b95370cc1ad05d944206b51ad597f111ac8
Author:     Joachim Henze <joachim.henze(a)reactos.org>
AuthorDate: Mon Jul 3 22:30:34 2023 +0200
Commit:     GitHub <noreply(a)github.com>
CommitDate: Mon Jul 3 22:30:34 2023 +0200

    [NETSTAT] -b flag implies -o flag on Windows XP/2003. CORE-19006 (#5377)
    
    
    When calling 'netstat -abn'
    Win 2k3sp2 and XPSP3 do show both: the processes name and the PID.
    Contrary Win 7 and Win 8.1 would show only the process name then without the PID.
    
    The newer Windows versions would require you to explicitly pass -o
    if you want to see the PID also.
    
    We do follow 2k3sp2 because it is our target. The process name is not of much use
    without having the PID as well, especially if multiple processes with the
    same name do run on a system, e.g.: multiple 'svchost.exe' processes.
    
    Ros will automatically switch to the Win7-way when newer
    Windows versions will be targeted at build-time.
---
 base/applications/network/netstat/netstat.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/base/applications/network/netstat/netstat.c
b/base/applications/network/netstat/netstat.c
index f9f05046d92..b3754fa2de1 100644
--- a/base/applications/network/netstat/netstat.c
+++ b/base/applications/network/netstat/netstat.c
@@ -98,6 +98,9 @@ BOOL ParseCmdline(int argc, wchar_t* argv[])
                         // UNIMPLEMENTED.
                         ConPuts(StdErr, L"'b' option is FIXME (Accepted
option though unimplemented feature).\n");
                         bDoShowProcName = TRUE;
+#if (_WIN32_WINNT < _WIN32_WINNT_VISTA)
+                        bDoShowProcessId = TRUE;
+#endif
                         break;
                     case L'e':
                         bDoShowEthStats = TRUE;