[ros-diffs] [reactos] 01/01: [MSCONFIG_NEW] Exclude from the iso, for the time being CORE-18067

[Joachim Henze]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e6de6098fb1ec1798f6c9…

commit e6de6098fb1ec1798f6c94150ea092dd3030a0a2
Author:     Joachim Henze <Joachim.Henze(a)reactos.org>
AuthorDate: Thu Mar 3 03:33:40 2022 +0100
Commit:     Joachim Henze <Joachim.Henze(a)reactos.org>
CommitDate: Thu Mar 3 03:33:40 2022 +0100

    [MSCONFIG_NEW] Exclude from the iso, for the time being CORE-18067
    
    Since more than 10 years we do ship two binaries for the very same purpose in our
isos:
    msconfig and msconfig_new.
    
    msconfig_new was an attempt to refactor the old tool, but it got stuck rather soon
    and is bloating our isos since then, and consuming build-time.
    My testing shows that the older version is superior in many ways
    compared to that refactoring attempt: see CORE-18067 for examples of some bugs.
    
    Personally I think focusing on the older tool exclusively would make more sense
    than trying to improve that refactoring proposal.
    But since one never knows what the future might bring and I did not want to step on
anyones toes,
    I decided to just disable the build and iso-integration of the unfinished one
meanwhile,
    instead of dumping it entirely. Although my feeling is that after 10years of waiting
    it's not worth waiting another 10 years with that.
---
 base/applications/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/base/applications/CMakeLists.txt b/base/applications/CMakeLists.txt
index c363430f0cb..7679233e5f2 100644
--- a/base/applications/CMakeLists.txt
+++ b/base/applications/CMakeLists.txt
@@ -21,7 +21,7 @@ add_subdirectory(magnify)
 add_subdirectory(mmc)
 add_subdirectory(mplay32)
 add_subdirectory(msconfig)
-add_subdirectory(msconfig_new)
+#add_subdirectory(msconfig_new) #excluded from the build because it is significantly more
buggy than the old msconfig. see CORE-18067 for examples
 add_subdirectory(mscutils)
 add_subdirectory(mshta)
 add_subdirectory(mspaint)