[ros-diffs] [reactos] 01/01: [EVENTLOG] Use the STDCALL calling convention for all remote procedure calls.

[Eric Kohl]

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=52fa3479f32ef3240d4aa…

commit 52fa3479f32ef3240d4aaded1bf246b7801fdf98
Author: Eric Kohl <eric.kohl(a)reactos.org>
AuthorDate: Sun Nov 12 15:54:22 2017 +0100

    [EVENTLOG] Use the STDCALL calling convention for all remote procedure calls.
---
 base/services/eventlog/rpc.c            |  25 ++++++++
 sdk/include/reactos/idl/eventlogrpc.idl | 100 ++++++++++++++++++++++++--------
 2 files changed, 100 insertions(+), 25 deletions(-)

diff --git a/base/services/eventlog/rpc.c b/base/services/eventlog/rpc.c
index 01cd920b6b..da1706ac33 100644
--- a/base/services/eventlog/rpc.c
+++ b/base/services/eventlog/rpc.c
@@ -285,6 +285,7 @@ ElfDeleteEventLogHandle(PIELF_HANDLE LogHandle)
 
 /* Function 0 */
 NTSTATUS
+WINAPI
 ElfrClearELFW(
     IELF_HANDLE LogHandle,
     PRPC_UNICODE_STRING BackupFileName)
@@ -308,6 +309,7 @@ ElfrClearELFW(
 
 /* Function 1 */
 NTSTATUS
+WINAPI
 ElfrBackupELFW(
     IELF_HANDLE LogHandle,
     PRPC_UNICODE_STRING BackupFileName)
@@ -327,6 +329,7 @@ ElfrBackupELFW(
 
 /* Function 2 */
 NTSTATUS
+WINAPI
 ElfrCloseEL(
     PIELF_HANDLE LogHandle)
 {
@@ -336,6 +339,7 @@ ElfrCloseEL(
 
 /* Function 3 */
 NTSTATUS
+WINAPI
 ElfrDeregisterEventSource(
     PIELF_HANDLE LogHandle)
 {
@@ -345,6 +349,7 @@ ElfrDeregisterEventSource(
 
 /* Function 4 */
 NTSTATUS
+WINAPI
 ElfrNumberOfRecords(
     IELF_HANDLE LogHandle,
     PULONG NumberOfRecords)
@@ -393,6 +398,7 @@ ElfrNumberOfRecords(
 
 /* Function 5 */
 NTSTATUS
+WINAPI
 ElfrOldestRecord(
     IELF_HANDLE LogHandle,
     PULONG OldestRecordNumber)
@@ -423,6 +429,7 @@ ElfrOldestRecord(
 
 /* Function 6 */
 NTSTATUS
+WINAPI
 ElfrChangeNotify(
     IELF_HANDLE LogHandle,
     RPC_CLIENT_ID ClientId,
@@ -435,6 +442,7 @@ ElfrChangeNotify(
 
 /* Function 7 */
 NTSTATUS
+WINAPI
 ElfrOpenELW(
     EVENTLOG_HANDLE_W UNCServerName,
     PRPC_UNICODE_STRING ModuleName,
@@ -462,6 +470,7 @@ ElfrOpenELW(
 
 /* Function 8 */
 NTSTATUS
+WINAPI
 ElfrRegisterEventSourceW(
     EVENTLOG_HANDLE_W UNCServerName,
     PRPC_UNICODE_STRING ModuleName,
@@ -493,6 +502,7 @@ ElfrRegisterEventSourceW(
 
 /* Function 9 */
 NTSTATUS
+WINAPI
 ElfrOpenBELW(
     EVENTLOG_HANDLE_W UNCServerName,
     PRPC_UNICODE_STRING BackupFileName,
@@ -516,6 +526,7 @@ ElfrOpenBELW(
 
 /* Function 10 */
 NTSTATUS
+WINAPI
 ElfrReadELW(
     IELF_HANDLE LogHandle,
     ULONG ReadFlags,
@@ -709,6 +720,7 @@ ElfrIntReportEventW(
 
 /* Function 11 */
 NTSTATUS
+WINAPI
 ElfrReportEventW(
     IELF_HANDLE LogHandle,
     ULONG Time,
@@ -746,6 +758,7 @@ ElfrReportEventW(
 
 /* Function 12 */
 NTSTATUS
+WINAPI
 ElfrClearELFA(
     IELF_HANDLE LogHandle,
     PRPC_STRING BackupFileName)
@@ -770,6 +783,7 @@ ElfrClearELFA(
 
 /* Function 13 */
 NTSTATUS
+WINAPI
 ElfrBackupELFA(
     IELF_HANDLE LogHandle,
     PRPC_STRING BackupFileName)
@@ -794,6 +808,7 @@ ElfrBackupELFA(
 
 /* Function 14 */
 NTSTATUS
+WINAPI
 ElfrOpenELA(
     EVENTLOG_HANDLE_A UNCServerName,
     PRPC_STRING ModuleName,
@@ -830,6 +845,7 @@ ElfrOpenELA(
 
 /* Function 15 */
 NTSTATUS
+WINAPI
 ElfrRegisterEventSourceA(
     EVENTLOG_HANDLE_A UNCServerName,
     PRPC_STRING ModuleName,
@@ -877,6 +893,7 @@ ElfrRegisterEventSourceA(
 
 /* Function 16 */
 NTSTATUS
+WINAPI
 ElfrOpenBELA(
     EVENTLOG_HANDLE_A UNCServerName,
     PRPC_STRING BackupFileName,
@@ -919,6 +936,7 @@ ElfrOpenBELA(
 
 /* Function 17 */
 NTSTATUS
+WINAPI
 ElfrReadELA(
     IELF_HANDLE LogHandle,
     ULONG ReadFlags,
@@ -970,6 +988,7 @@ ElfrReadELA(
 
 /* Function 18 */
 NTSTATUS
+WINAPI
 ElfrReportEventA(
     IELF_HANDLE LogHandle,
     ULONG Time,
@@ -1088,6 +1107,7 @@ Done:
 
 /* Function 19 */
 NTSTATUS
+WINAPI
 ElfrRegisterClusterSvc(
     handle_t BindingHandle)
 {
@@ -1098,6 +1118,7 @@ ElfrRegisterClusterSvc(
 
 /* Function 20 */
 NTSTATUS
+WINAPI
 ElfrDeregisterClusterSvc(
     handle_t BindingHandle)
 {
@@ -1108,6 +1129,7 @@ ElfrDeregisterClusterSvc(
 
 /* Function 21 */
 NTSTATUS
+WINAPI
 ElfrWriteClusterEvents(
     handle_t BindingHandle)
 {
@@ -1118,6 +1140,7 @@ ElfrWriteClusterEvents(
 
 /* Function 22 */
 NTSTATUS
+WINAPI
 ElfrGetLogInformation(
     IELF_HANDLE LogHandle,
     ULONG InfoLevel,
@@ -1169,6 +1192,7 @@ ElfrGetLogInformation(
 
 /* Function 23 */
 NTSTATUS
+WINAPI
 ElfrFlushEL(
     IELF_HANDLE LogHandle)
 {
@@ -1196,6 +1220,7 @@ ElfrFlushEL(
 
 /* Function 24 */
 NTSTATUS
+WINAPI
 ElfrReportEventAndSourceW(
     IELF_HANDLE LogHandle,
     ULONG Time,
diff --git a/sdk/include/reactos/idl/eventlogrpc.idl
b/sdk/include/reactos/idl/eventlogrpc.idl
index 4dd5cadd51..f9c0e7fae1 100644
--- a/sdk/include/reactos/idl/eventlogrpc.idl
+++ b/sdk/include/reactos/idl/eventlogrpc.idl
@@ -42,41 +42,57 @@ typedef struct _RPC_CLIENT_ID {
 interface eventlog
 {
     /* Function 0 */
-    NTSTATUS ElfrClearELFW(
+    NTSTATUS
+    __stdcall
+    ElfrClearELFW(
         [in] IELF_HANDLE LogHandle,
         [in, unique] PRPC_UNICODE_STRING BackupFileName);
 
     /* Function 1 */
-     NTSTATUS ElfrBackupELFW(
+     NTSTATUS
+    __stdcall
+    ElfrBackupELFW(
         [in] IELF_HANDLE LogHandle,
         [in, unique] PRPC_UNICODE_STRING BackupFileName);
 
     /* Function 2 */
-    NTSTATUS ElfrCloseEL(
+    NTSTATUS
+    __stdcall
+    ElfrCloseEL(
         [in, out] PIELF_HANDLE LogHandle);
 
     /* Function 3 */
-    NTSTATUS ElfrDeregisterEventSource(
+    NTSTATUS
+    __stdcall
+    ElfrDeregisterEventSource(
         [in, out] PIELF_HANDLE LogHandle);
 
     /* Function 4 */
-    NTSTATUS ElfrNumberOfRecords(
+    NTSTATUS
+    __stdcall
+    ElfrNumberOfRecords(
         [in] IELF_HANDLE LogHandle,
         [out] PULONG NumberOfRecords);
 
     /* Function 5 */
-    NTSTATUS ElfrOldestRecord(
+    NTSTATUS
+    __stdcall
+    ElfrOldestRecord(
         [in] IELF_HANDLE LogHandle,
         [out] PULONG OldestRecordNumber);
 
     /* Function 6 */
-    NTSTATUS ElfrChangeNotify(
+    NTSTATUS
+    __stdcall
+    ElfrChangeNotify(
         [in] IELF_HANDLE LogHandle,
         [in] RPC_CLIENT_ID ClientId,
         [in] ULONG Event);
 
     /* Function 7 */
-    NTSTATUS ElfrOpenELW(
+    NTSTATUS
+    __stdcall
+    ElfrOpenELW(
         [in, unique] EVENTLOG_HANDLE_W UNCServerName, /* FIXME */
         [in] PRPC_UNICODE_STRING ModuleName,
         [in] PRPC_UNICODE_STRING RegModuleName,
@@ -85,7 +101,9 @@ interface eventlog
         [out] PIELF_HANDLE LogHandle);
 
     /* Function 8 */
-    NTSTATUS ElfrRegisterEventSourceW(
+    NTSTATUS
+    __stdcall
+    ElfrRegisterEventSourceW(
         [in, unique] EVENTLOG_HANDLE_W UNCServerName, /* FIXME */
         [in] PRPC_UNICODE_STRING ModuleName,
         [in] PRPC_UNICODE_STRING RegModuleName,
@@ -94,7 +112,9 @@ interface eventlog
         [out] PIELF_HANDLE LogHandle);
 
     /* Function 9 */
-    NTSTATUS ElfrOpenBELW(
+    NTSTATUS
+    __stdcall
+    ElfrOpenBELW(
         [in, unique] EVENTLOG_HANDLE_W UNCServerName, /* FIXME */
         [in] PRPC_UNICODE_STRING BackupFileName,
         [in] ULONG MajorVersion,
@@ -102,7 +122,9 @@ interface eventlog
         [out] PIELF_HANDLE LogHandle);
 
     /* Function 10 */
-    NTSTATUS ElfrReadELW(
+    NTSTATUS
+    __stdcall
+    ElfrReadELW(
         [in] IELF_HANDLE LogHandle,
         [in] ULONG ReadFlags,
         [in] ULONG RecordOffset,
@@ -112,7 +134,9 @@ interface eventlog
         [out] PULONG MinNumberOfBytesNeeded);
 
     /* Function 11 */
-    NTSTATUS ElfrReportEventW(
+    NTSTATUS
+    __stdcall
+    ElfrReportEventW(
         [in] IELF_HANDLE LogHandle,
         [in] ULONG Time,
         [in] USHORT EventType,
@@ -129,17 +153,23 @@ interface eventlog
         [in, out, unique] PULONG TimeWritten);
 
     /* Function 12 */
-    NTSTATUS ElfrClearELFA(
+    NTSTATUS
+    __stdcall
+    ElfrClearELFA(
         [in] IELF_HANDLE LogHandle,
         [in, unique] PRPC_STRING BackupFileName);
 
     /* Function 13 */
-     NTSTATUS ElfrBackupELFA(
+    NTSTATUS
+    __stdcall
+    ElfrBackupELFA(
         [in] IELF_HANDLE LogHandle,
         [in, unique] PRPC_STRING BackupFileName);
 
     /* Function 14 */
-    NTSTATUS ElfrOpenELA(
+    NTSTATUS
+    __stdcall
+    ElfrOpenELA(
         [in, unique] EVENTLOG_HANDLE_A UNCServerName, /* FIXME */
         [in] PRPC_STRING ModuleName,
         [in] PRPC_STRING RegModuleName,
@@ -148,7 +178,9 @@ interface eventlog
         [out] PIELF_HANDLE LogHandle);
 
     /* Function 15 */
-    NTSTATUS ElfrRegisterEventSourceA(
+    NTSTATUS
+    __stdcall
+    ElfrRegisterEventSourceA(
         [in, unique] EVENTLOG_HANDLE_A UNCServerName, /* FIXME */
         [in] PRPC_STRING ModuleName,
         [in] PRPC_STRING RegModuleName,
@@ -157,7 +189,9 @@ interface eventlog
         [out] PIELF_HANDLE LogHandle);
 
     /* Function 16 */
-    NTSTATUS ElfrOpenBELA(
+    NTSTATUS
+    __stdcall
+    ElfrOpenBELA(
         [in, unique] EVENTLOG_HANDLE_A UNCServerName, /* FIXME */
         [in] PRPC_STRING BackupFileName,
         [in] ULONG MajorVersion,
@@ -165,7 +199,9 @@ interface eventlog
         [out] PIELF_HANDLE LogHandle);
 
     /* Function 17 */
-    NTSTATUS ElfrReadELA(
+    NTSTATUS
+    __stdcall
+    ElfrReadELA(
         [in] IELF_HANDLE LogHandle,
         [in] ULONG ReadFlags,
         [in] ULONG RecordOffset,
@@ -175,7 +211,9 @@ interface eventlog
         [out] PULONG MinNumberOfBytesNeeded);
 
     /* Function 18 */
-    NTSTATUS ElfrReportEventA(
+    NTSTATUS
+    __stdcall
+    ElfrReportEventA(
         [in] IELF_HANDLE LogHandle,
         [in] ULONG Time,
         [in] USHORT EventType,
@@ -192,19 +230,27 @@ interface eventlog
         [in, out, unique] PULONG TimeWritten);
 
     /* Function 19 */
-    NTSTATUS ElfrRegisterClusterSvc(
+    NTSTATUS
+    __stdcall
+    ElfrRegisterClusterSvc(
         [in] handle_t BindingHandle);
 
     /* Function 20 */
-    NTSTATUS ElfrDeregisterClusterSvc(
+    NTSTATUS
+    __stdcall
+    ElfrDeregisterClusterSvc(
         [in] handle_t BindingHandle);
 
     /* Function 21 */
-    NTSTATUS ElfrWriteClusterEvents(
+    NTSTATUS
+    __stdcall
+    ElfrWriteClusterEvents(
         [in] handle_t BindingHandle);
 
     /* Function 22 */
-    NTSTATUS ElfrGetLogInformation(
+    NTSTATUS
+    __stdcall
+    ElfrGetLogInformation(
         [in] IELF_HANDLE LogHandle,
         [in] ULONG InfoLevel,
         [out, size_is(cbBufSize)] PBYTE Buffer,
@@ -212,11 +258,15 @@ interface eventlog
         [out] PULONG pcbBytesNeeded);
 
     /* Function 23 */
-    NTSTATUS ElfrFlushEL(
+    NTSTATUS
+    __stdcall
+    ElfrFlushEL(
         [in] IELF_HANDLE LogHandle);
 
     /* Function 24 */
-    NTSTATUS ElfrReportEventAndSourceW(
+    NTSTATUS
+    __stdcall
+    ElfrReportEventAndSourceW(
         [in] IELF_HANDLE LogHandle,
         [in] ULONG Time,
         [in] USHORT EventType,