[ros-diffs] [weiden] 13556: don't leak a reference to the timer object when copying to the buffer failed in NtQueryTimer() and don't use uninitialized variable in NtSetTimer()

don't leak a reference to the timer object when copying to the buffer
failed in NtQueryTimer() and don't use uninitialized variable in
NtSetTimer()
Modified: trunk/reactos/ntoskrnl/ex/timer.c
  _____  

Modified: trunk/reactos/ntoskrnl/ex/timer.c
--- trunk/reactos/ntoskrnl/ex/timer.c	2005-02-14 07:46:14 UTC (rev
13555)
+++ trunk/reactos/ntoskrnl/ex/timer.c	2005-02-14 11:46:17 UTC (rev
13556)
@@ -483,22 +483,27 @@

     /* Check for Success */
     if(NT_SUCCESS(Status)) {
         
-        /* Return the Basic Information */       
-         _SEH_TRY {
-           
-            /* FIXME: Interrupt correction based on Interrupt Time */
-            DPRINT("Returning Information for Timer: %x. Time
Remaining: %d\n", Timer, Timer->KeTimer.DueTime.QuadPart);
-            BasicInfo->TimeRemaining.QuadPart =
Timer->KeTimer.DueTime.QuadPart;
-            BasicInfo->SignalState = KeReadStateTimer(&Timer->KeTimer);
-            ObDereferenceObject(Timer);
+        switch(TimerInformationClass) {
+           case TimerBasicInformation: {
+              /* Return the Basic Information */
+               _SEH_TRY {
 
-            if(ReturnLength != NULL) {
-                *ReturnLength = sizeof(TIMER_BASIC_INFORMATION);
-            }
+                  /* FIXME: Interrupt correction based on Interrupt
Time */
+                  DPRINT("Returning Information for Timer: %x. Time
Remaining: %d\n", Timer, Timer->KeTimer.DueTime.QuadPart);
+                  BasicInfo->TimeRemaining.QuadPart =
Timer->KeTimer.DueTime.QuadPart;
+                  BasicInfo->SignalState =
KeReadStateTimer(&Timer->KeTimer);
+
+                  if(ReturnLength != NULL) {
+                      *ReturnLength = sizeof(TIMER_BASIC_INFORMATION);
+                  }
+
+              } _SEH_HANDLE {
+                  Status = _SEH_GetExceptionCode();
+              } _SEH_END;
+           }
+        }
         
-        } _SEH_HANDLE {
-            Status = _SEH_GetExceptionCode();
-        } _SEH_END;
+        ObDereferenceObject(Timer);
     }
    
     /* Return Status */
@@ -517,7 +522,7 @@
 {
     PETIMER Timer;
     KIRQL OldIrql;
-    BOOLEAN KillTimer;
+    BOOLEAN KillTimer = FALSE;
     BOOLEAN State;
     KPROCESSOR_MODE PreviousMode = ExGetPreviousMode();
     PETHREAD CurrentThread = PsGetCurrentThread();