[ros-diffs] [cfinck] 28423: - Always include "wine/unicode.h" before all other headers, when we need the wchar_t type. unicode.h includes windef.h, which includes winnt.h, which has the handling for the wchar_t type. As it's the first included header, no other wchar_t type will be defined before. - Remove the wchar_t definition from the Makefile as the winnt.h header will define it as "unsigned short" automatically.

Author: cfinck
Date: Sun Aug 19 19:38:21 2007
New Revision: 28423

URL: http://svn.reactos.org/svn/reactos?rev=28423&view=rev
Log:
- Always include "wine/unicode.h" before all other headers, when we need the
wchar_t type.
  unicode.h includes windef.h, which includes winnt.h, which has the handling for the
wchar_t type. As it's the first included header, no other wchar_t type will be defined
before.
- Remove the wchar_t definition from the Makefile as the winnt.h header will define it as
"unsigned short" automatically.

Modified:
    trunk/reactos/tools/unicode/cptable.c
    trunk/reactos/tools/unicode/mbtowc.c
    trunk/reactos/tools/unicode/string.c
    trunk/reactos/tools/unicode/unicode.mak
    trunk/reactos/tools/unicode/utf8.c
    trunk/reactos/tools/unicode/wctomb.c

Modified: trunk/reactos/tools/unicode/cptable.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/unicode/cptable.c?re…
==============================================================================
--- trunk/reactos/tools/unicode/cptable.c (original)
+++ trunk/reactos/tools/unicode/cptable.c Sun Aug 19 19:38:21 2007
@@ -18,10 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
-#include <windef.h>
+#include "wine/unicode.h"
 #include <stdlib.h>
-
-#include "wine/unicode.h"
 
 /* Everything below this line is generated automatically by cpmap.pl */
 /* ### cpmap begin ### */

Modified: trunk/reactos/tools/unicode/mbtowc.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/unicode/mbtowc.c?rev…
==============================================================================
--- trunk/reactos/tools/unicode/mbtowc.c (original)
+++ trunk/reactos/tools/unicode/mbtowc.c Sun Aug 19 19:38:21 2007
@@ -18,9 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
+#include "wine/unicode.h"
 #include <string.h>
-
-#include "wine/unicode.h"
 
 /* get the decomposition of a Unicode char */
 static int get_decomposition( WCHAR src, WCHAR *dst, unsigned int dstlen )

Modified: trunk/reactos/tools/unicode/string.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/unicode/string.c?rev…
==============================================================================
--- trunk/reactos/tools/unicode/string.c (original)
+++ trunk/reactos/tools/unicode/string.c Sun Aug 19 19:38:21 2007
@@ -18,10 +18,9 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
+#include "wine/unicode.h"
 #include <limits.h>
 #include <stdio.h>
-
-#include "wine/unicode.h"
 
 extern const WCHAR wine_casemap_lower[];
 extern const WCHAR wine_casemap_upper[];

Modified: trunk/reactos/tools/unicode/unicode.mak
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/unicode/unicode.mak?…
==============================================================================
--- trunk/reactos/tools/unicode/unicode.mak (original)
+++ trunk/reactos/tools/unicode/unicode.mak Sun Aug 19 19:38:21 2007
@@ -96,7 +96,6 @@
 
 UNICODE_HOST_CFLAGS = \
 	-D__USE_W32API -DWINVER=0x501 -DWINE_UNICODE_API= \
-	-Dwchar_t="unsigned short" -D_WCHAR_T_DEFINED \
 	-I$(UNICODE_BASE) -Iinclude/reactos/wine -Iinclude -Iinclude/psdk \
 	$(TOOLS_CFLAGS)
 

Modified: trunk/reactos/tools/unicode/utf8.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/unicode/utf8.c?rev=2…
==============================================================================
--- trunk/reactos/tools/unicode/utf8.c (original)
+++ trunk/reactos/tools/unicode/utf8.c Sun Aug 19 19:38:21 2007
@@ -18,9 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
+#include "wine/unicode.h"
 #include <string.h>
-
-#include "wine/unicode.h"
 
 /* number of following bytes in sequence based on first byte value (for bytes above 0x7f)
*/
 static const char utf8_length[128] =

Modified: trunk/reactos/tools/unicode/wctomb.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/unicode/wctomb.c?rev…
==============================================================================
--- trunk/reactos/tools/unicode/wctomb.c (original)
+++ trunk/reactos/tools/unicode/wctomb.c Sun Aug 19 19:38:21 2007
@@ -18,9 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
  */
 
+#include "wine/unicode.h"
 #include <string.h>
-
-#include "wine/unicode.h"
 
 /* search for a character in the unicode_compose_table; helper for compose() */
 static inline int binary_search( WCHAR ch, int low, int high )