[ros-diffs] [akhaldi] 58981: [PCI] * Add some function annotations. * Fix several debug print specifiers. * Properly mark some unreferenced parameters as such.

Author: akhaldi
Date: Thu May  9 21:24:16 2013
New Revision: 58981

URL: http://svn.reactos.org/svn/reactos?rev=58981&view=rev
Log:
[PCI]
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.

Modified:
    trunk/reactos/drivers/bus/pci/fdo.c
    trunk/reactos/drivers/bus/pci/pci.c
    trunk/reactos/drivers/bus/pci/pdo.c

Modified: trunk/reactos/drivers/bus/pci/fdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pci/fdo.c?rev=…
==============================================================================
--- trunk/reactos/drivers/bus/pci/fdo.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pci/fdo.c	[iso-8859-1] Thu May  9 21:24:16 2013
@@ -456,6 +456,7 @@
 {
   NTSTATUS Status;
 
+  UNREFERENCED_PARAMETER(DeviceObject);
   UNREFERENCED_PARAMETER(Irp);
 
   DPRINT("Called\n");

Modified: trunk/reactos/drivers/bus/pci/pci.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pci/pci.c?rev=…
==============================================================================
--- trunk/reactos/drivers/bus/pci/pci.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pci/pci.c	[iso-8859-1] Thu May  9 21:24:16 2013
@@ -53,7 +53,7 @@
   NTSTATUS Status;
 
   UNREFERENCED_PARAMETER(DeviceObject);
-  DPRINT("Called. IRP is at (0x%X)\n", Irp);
+  DPRINT("Called. IRP is at (0x%p)\n", Irp);
 
   Irp->IoStatus.Information = 0;
 
@@ -68,7 +68,7 @@
   if (Status != STATUS_PENDING) {
     Irp->IoStatus.Status = Status;
 
-    DPRINT("Completing IRP at 0x%X\n", Irp);
+    DPRINT("Completing IRP at 0x%p\n", Irp);
 
     IoCompleteRequest(Irp, IO_NO_INCREMENT);
   }
@@ -98,7 +98,7 @@
 
   DeviceExtension = (PCOMMON_DEVICE_EXTENSION)DeviceObject->DeviceExtension;
 
-  DPRINT("IsFDO %d\n", DeviceExtension->IsFDO);
+  DPRINT("IsFDO %u\n", DeviceExtension->IsFDO);
 
   if (DeviceExtension->IsFDO) {
     Status = FdoPnpControl(DeviceObject, Irp);
@@ -180,6 +180,7 @@
   return STATUS_SUCCESS;
 }
 
+DRIVER_UNLOAD PciUnload;
 
 VOID
 NTAPI
@@ -187,6 +188,7 @@
   IN PDRIVER_OBJECT DriverObject)
 {
     /* The driver object extension is destroyed by the I/O manager */
+    UNREFERENCED_PARAMETER(DriverObject);
 }
 
 NTSTATUS

Modified: trunk/reactos/drivers/bus/pci/pdo.c
URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/bus/pci/pdo.c?rev=…
==============================================================================
--- trunk/reactos/drivers/bus/pci/pdo.c	[iso-8859-1] (original)
+++ trunk/reactos/drivers/bus/pci/pdo.c	[iso-8859-1] Thu May  9 21:24:16 2013
@@ -398,7 +398,7 @@
   }
   else
   {
-    DPRINT1("Unsupported header type %u\n",
PCI_CONFIGURATION_TYPE(&PciConfig));
+    DPRINT1("Unsupported header type %d\n",
PCI_CONFIGURATION_TYPE(&PciConfig));
   }
 
   if (ResCount == 0)
@@ -708,7 +708,7 @@
   }
   else
   {
-    DPRINT1("Unsupported header type %u\n",
PCI_CONFIGURATION_TYPE(&PciConfig));
+    DPRINT1("Unsupported header type %d\n",
PCI_CONFIGURATION_TYPE(&PciConfig));
   }
 
   if (ResCount == 0)
@@ -896,8 +896,11 @@
   InterlockedDecrement(&DeviceExtension->References);
 }
 
-
-static BOOLEAN NTAPI
+static TRANSLATE_BUS_ADDRESS InterfaceBusTranslateBusAddress;
+
+static
+BOOLEAN
+NTAPI
 InterfaceBusTranslateBusAddress(
   IN PVOID Context,
   IN PHYSICAL_ADDRESS BusAddress,
@@ -917,8 +920,11 @@
     BusAddress, AddressSpace, TranslatedAddress);
 }
 
-
-static PDMA_ADAPTER NTAPI
+static GET_DMA_ADAPTER InterfaceBusGetDmaAdapter;
+
+static
+PDMA_ADAPTER
+NTAPI
 InterfaceBusGetDmaAdapter(
   IN PVOID Context,
   IN PDEVICE_DESCRIPTION DeviceDescription,
@@ -929,8 +935,11 @@
   return (PDMA_ADAPTER)HalGetAdapter(DeviceDescription, NumberOfMapRegisters);
 }
 
-
-static ULONG NTAPI
+static GET_SET_DEVICE_DATA InterfaceBusSetBusData;
+
+static
+ULONG
+NTAPI
 InterfaceBusSetBusData(
   IN PVOID Context,
   IN ULONG DataType,
@@ -962,8 +971,11 @@
   return Size;
 }
 
-
-static ULONG NTAPI
+static GET_SET_DEVICE_DATA InterfaceBusGetBusData;
+
+static
+ULONG
+NTAPI
 InterfaceBusGetBusData(
   IN PVOID Context,
   IN ULONG DataType,
@@ -1229,6 +1241,8 @@
     UCHAR Irq;
     USHORT Command;
 
+    UNREFERENCED_PARAMETER(Irp);
+
     if (!RawResList)
         return STATUS_SUCCESS;
 
@@ -1244,7 +1258,7 @@
 
             if (RawPartialDesc->Type == CmResourceTypeInterrupt)
             {
-                DPRINT1("Assigning IRQ %d to PCI device 0x%x on bus 0x%x\n",
+                DPRINT1("Assigning IRQ %u to PCI device 0x%x on bus 0x%x\n",
                         RawPartialDesc->u.Interrupt.Vector,
                         DeviceExtension->PciDevice->SlotNumber.u.AsULONG,
                         DeviceExtension->PciDevice->BusNumber);
@@ -1401,6 +1415,7 @@
 {
   NTSTATUS Status;
 
+  UNREFERENCED_PARAMETER(DeviceObject);
   UNREFERENCED_PARAMETER(Irp);
   DPRINT("Called\n");